Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

04.02.2020 20:42, Max Reitz wrote: On 04.02.20 16:35, Vladimir Sementsov-Ogievskiy wrote: 31.01.2020 20:44, Eric Blake wrote: Having two slightly-different function names for related purposes is unwieldy, especially since I envision adding yet another notion of zero support in an upcoming

[PATCH 3/3] stellaris: delay timer_new to avoid memleaks

From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = stellaris-gptm. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "stellaris-gptm"}}' This patch delay

[PATCH 1/3] armv7m_systick: delay timer_new to avoid memleaks

From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = armv7m_systick. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "armv7m_systick"}}' This patch delay

[PATCH 2/3] stm32f2xx_timer: delay timer_new to avoid memleaks

From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = stm32f2xx_timer. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "stm32f2xx_timer"}}' This patch

[PATCH 0/3] delay timer_new to avoid memleaks

From: Pan Nengyuan This series delay timer_new into realize() to fix some memleaks when we call 'device-list-properties'. Pan Nengyuan (3): armv7m_systick: delay timer_new to avoid memleaks stm32f2xx_timer: delay timer_new to avoid memleaks stellaris: delay timer_new to avoid memleaks

Re: [PATCH] drop "from __future__ import print_function"

Paolo Bonzini writes: > This is only needed for Python 2, which we do not support anymore. > > Based-on: <20200204160028.16211-1-pbonz...@redhat.com> > Cc: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini For QAPI and QMP: Acked-by: Markus Armbruster

Re: Summary of Re: Making QEMU easier for management tools and applications

Markus Armbruster writes: [...] > = Ways to provide machine-friendly initial configuration = > > Two ways to provide machine-friendly initial configuration on par with > QMP have been proposed: > > 1. Extend QMP > >Machines use the CLI only to configure a QMP socket. The remainder >of

Re: Restrictions of libnet (was: Re: VW ELF loader)

On 05/02/2020 06.30, David Gibson wrote: > On Tue, Feb 04, 2020 at 10:20:14AM +0100, Thomas Huth wrote: >> On 04/02/2020 09.54, Cornelia Huck wrote: >>> On Tue, 4 Feb 2020 07:16:46 +0100 >>> Thomas Huth wrote: >>> On 04/02/2020 00.26, Paolo Bonzini wrote: > > > Il mar 4 feb 2020,

Re: [PATCH] virtio: clean up when virtio_queue_set_rings() fails

On Tue, Feb 04, 2020 at 03:16:18PM +, Stefan Hajnoczi wrote: > hw/virtio.c checks vq->vring.desc != NULL to see if the vring has been > set up successfully. > > When virtio_queue_set_rings() fails due to an invalid vring memory > address it must clear vq->vring.desc (and related fields) so we

Re: VW ELF loader

On Mon, Feb 03, 2020 at 04:08:54PM +0100, Paolo Bonzini wrote: > On 03/02/20 11:58, Alexey Kardashevskiy wrote: > >>> So really, the question isn't whether we implement things in firmware > >>> or in qemu. It's whether we implement the firmware functionality as > >>> guest cpu code, which needs

Re: VW ELF loader

On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote: > Il mar 4 feb 2020, 00:20 Alexey Kardashevskiy ha scritto: > > > > > > > Speaking seriously, what would I put into the guest? > > Only things that would be considered drivers. Ignore the partitions issue > for now so that you can

Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU

On 2020/2/5 上午11:23, Vikram Garhwal wrote: Hi Jason, Yes, I will maintain this NIC. Thanks for the help. Regards, Vikram Good to know that. Please update MAINTINERS and it would be better if you can draft a qtest for this NIC. I leave some quick comments for the patch and I hope the

Re: [PATCH 1/1] hw/net/can: Introduce Xlnx ZynqMP CAN controller for QEMU

On 2020/2/4 上午5:06, Vikram Garhwal wrote: XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Signed-off-by: Vikram Garhwal --- hw/net/can/Makefile.objs |1 +

Re: Restrictions of libnet (was: Re: VW ELF loader)

On Tue, Feb 04, 2020 at 10:20:14AM +0100, Thomas Huth wrote: > On 04/02/2020 09.54, Cornelia Huck wrote: > > On Tue, 4 Feb 2020 07:16:46 +0100 > > Thomas Huth wrote: > > > >> On 04/02/2020 00.26, Paolo Bonzini wrote: > >>> > >>> > >>> Il mar 4 feb 2020, 00:20 Alexey Kardashevskiy >>>

[PATCH qemu v6] spapr: OF CI networking

This is a *hack* to demonstrate the idea. I am connecting the OF CI's "net" device to a corresponding network backend. Unlike blockdev with its simple API allowing to just read from a device, network requires a client and in presence of an existing device in QEMU, having another device-agnostinc

RE: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU

Hi Jason, Yes, I will maintain this NIC. Thanks for the help. Regards, Vikram > -Original Message- > From: Jason Wang > Sent: Tuesday, February 4, 2020 7:17 PM > To: Vikram Garhwal ; qemu-devel@nongnu.org > Subject: Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU > > >

Re: [PATCH qemu v6 6/6] spapr: Implement Open Firmware client interface

On 04/02/2020 00:03, BALATON Zoltan wrote: > On Mon, 3 Feb 2020, Alexey Kardashevskiy wrote: > [...] >> diff --git a/hw/ppc/spapr_of_client.c b/hw/ppc/spapr_of_client.c >> new file mode 100644 >> index ..31555c356de8 >> --- /dev/null >> +++ b/hw/ppc/spapr_of_client.c >> @@ -0,0

Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN controller for QEMU

On 2020/2/4 上午5:06, Vikram Garhwal wrote: Example for single CAN: -object can-bus,id=canbus0 \ -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \ -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 Example for connecting both CAN: -object

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

Peter Maydell 于2020年2月4日周二 下午9:22写道： > On Tue, 4 Feb 2020 at 03:51, Gavin Shan wrote: > > Note: I'm still investigating the code to see how SError can be injected > when TCG > > is used. I think we need same function when TCG is enabled, or it's > something for > > future. > > TCG doesn't

Re: [PATCH v5 2/4] nvdimm: add uuid property to nvdimm

On Tue, Feb 04, 2020 at 03:55:23PM +0100, Igor Mammedov wrote: > On Thu, 30 Jan 2020 05:47:59 -0600 > Shivaprasad G Bhat wrote: > > > For ppc64, PAPR requires the nvdimm device to have UUID property > > set in the device tree. Add an option to get it from the user. > > > > Signed-off-by:

Re: [PATCH 0/4] linux-user: fix use of SIGRTMIN

On Tue, Feb 4, 2020 at 3:55 AM Laurent Vivier wrote: > We should add signal 63 here, but it's becoming not very clean. https://golang.org/issue/33746 has some discussion of the issue. The Go maintainers wanted to clean this up rather than just adding 63. The patch is on ice right now because it

[Bug 1861946] [NEW] qemu-4.2.0 qemu-system-i386 not receive scancode 86 of spanish keyboard (ascii chars '<' & '>')

Public bug reported: Hello. I am using qemu-4.2.0 for Windows 64 downloaded from https://qemu.weilnetz.de/w64/, and I use qemu-system-i386.exe for run Minix 3.1.2a: C:\Program Files\qemu> qemu-system-i386 minix3hd.qcow All is Ok except the keyboard (spanish). Actually the Spanish keyboard

Re: Does Libvirt's json parser support single quoted string in qmp json string?

On 2/3/20 11:27 AM, Eric Blake wrote: > [adding Markus] > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: >>> On 1/31/20 4:38 AM, Peter Luo wrote: >>> error: internal error: cannot parse json {"execute": "block-commit",

Re: VW ELF loader

On 04/02/2020 10:26, Paolo Bonzini wrote: > > > Il mar 4 feb 2020, 00:20 Alexey Kardashevskiy > ha scritto: > > > > Speaking seriously, what would I put into the guest? > > > Only things that would be considered drivers. Ignore the partitions > issue for now

Re: [PATCH rc4 26/29] target/avr: Update build system

On Friday, January 31, 2020, Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Michael Rolnik > > Make AVR support buildable. > > [AM: Remove word 'Atmel' from filenames and all elements of code] > Suggested-by: Aleksandar Markovic > > Signed-off-by: Michael Rolnik >

Re: [PATCH v5 05/20] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

On Tuesday, February 4, 2020, Laurent Vivier wrote: > Le 04/02/2020 à 12:56, Aleksandar Markovic a écrit : > > On Tue, Jan 14, 2020 at 5:40 PM Laurent Vivier > wrote: > >> > >> Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit : > >>> From: Aleksandar Markovic > >>> > >>> Update mips syscall

Re: [PATCH v5 05/20] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

Le 04/02/2020 à 12:56, Aleksandar Markovic a écrit : > On Tue, Jan 14, 2020 at 5:40 PM Laurent Vivier wrote: >> >> Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit : >>> From: Aleksandar Markovic >>> >>> Update mips syscall numbers based on Linux kernel tag v5.5-rc3 >>> (commit 46cf053e). >>>

Re: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend

Sure! I probably won't send a pull request for a week or so though. Paolo Il mar 4 feb 2020, 16:39 Igor Mammedov ha scritto: > On Tue, 4 Feb 2020 16:08:30 +0100 > Igor Mammedov wrote: > > > On Fri, 31 Jan 2020 16:08:30 +0100 > > Igor Mammedov wrote: > > > > Paolo, > > forgot to add address

Re: [PATCH qemu] spapr/rtas: Print message from "ibm,os-term"

On Mon, Feb 03, 2020 at 02:20:44PM +1100, Alexey Kardashevskiy wrote: > The "ibm,os-term" RTAS call has a single parameter which is a pointer to > a message from the guest kernel about the termination cause; this prints > it. > > Signed-off-by: Alexey Kardashevskiy Applied to ppc-for-5.0,

Re: [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test

Richard Henderson writes: > On 1/14/20 5:09 AM, Alex Bennée wrote: >> This test exercises the gdbstub while runing the sve-iotcl test. I >> haven't plubmed it into make system as we need a way of verifying if >> gdb has the right support for SVE. >> >> Signed-off-by: Alex Bennée >> >> ---

Re: [PATCH v3 1/4] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter

On 1/30/20 8:51 PM, Philippe Mathieu-Daudé wrote: On 1/27/20 8:28 PM, Wainer dos Santos Moschetta wrote: On 1/24/20 7:36 AM, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: The test case may need to boot the VM with an accelerator that isn't actually

Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests

On 1/24/20 1:45 PM, Philippe Mathieu-Daudé wrote: On 1/22/20 2:27 AM, Wainer dos Santos Moschetta wrote: Added boot Linux test cases that launch QEMU with kvm enabled. Likewise it was added tests for tcg. Signed-off-by: Wainer dos Santos Moschetta ---  

[PATCH v2] linux-user: implement TARGET_SO_PEERSEC

"The purpose of this option is to allow an application to obtain the security credentials of a Unix stream socket peer. It is analogous to SO_PEERCRED (which provides authentication using standard Unix credentials of pid, uid and gid), and extends this concept to other security models." --

Re: [PATCH] linux-user: implement TARGET_SO_PEERSEC

Le 03/02/2020 à 18:37, Laurent Vivier a écrit : > "The purpose of this option is to allow an application to obtain the > security credentials of a Unix stream socket peer. It is analogous to > SO_PEERCRED (which provides authentication using standard Unix credentials > of pid, uid and gid), and

Re: [PATCH v3 00/18] APIC ID fixes for AMD EPYC CPU models

On 2/4/20 2:02 AM, Igor Mammedov wrote: > On Mon, 3 Feb 2020 13:31:29 -0600 > Babu Moger wrote: > >> On 2/3/20 8:59 AM, Igor Mammedov wrote: >>> On Tue, 03 Dec 2019 18:36:54 -0600 >>> Babu Moger wrote: >>> This series fixes APIC ID encoding problems on AMD EPYC CPUs.

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

On 2/4/20 11:56 AM, John Snow wrote: > This is the only instance of a non-zero constant not using a symbolic > constant. Signed-off-by: John Snow > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

On 04.02.20 17:44, David Hildenbrand wrote: > On 04.02.20 16:23, Igor Mammedov wrote: >> On Fri, 17 Jan 2020 17:45:16 + >> Shameer Kolothum wrote: >> >>> If ACPI blob length modifications happens after the initial >>> virt_acpi_build() call, and the changed blob length is within >>> the PAGE

Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

On 2/4/20 11:53 AM, Max Reitz wrote: On 31.01.20 18:44, Eric Blake wrote: Having two slightly-different function names for related purposes is unwieldy, especially since I envision adding yet another notion of zero support in an upcoming patch. It doesn't help that bdrv_has_zero_init() is a

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

Patchew URL: https://patchew.org/QEMU/20200204165638.25051-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] qemu-options: replace constant 1 with HAS_ARG Message-id: 20200204165638.25051-1-js...@redhat.com

Re: [PATCH 00/17] Improve qcow2 all-zero detection

On 2/4/20 11:32 AM, Max Reitz wrote: On 31.01.20 18:44, Eric Blake wrote: Based-on: <20200124103458.1525982-2-david.edmond...@oracle.com> ([PATCH v2 1/2] qemu-img: Add --target-is-zero to convert) I'm working on adding an NBD extension that reports whether an image is already all zero when the

[PULL 16/16] .travis.yml: ensure python3-sphinx installed for docs

Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200204105142.21845-1-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index 3b35b7cf04d..6c0ec6cf69f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -194,7 +194,7 @@ matrix: addons: apt:

[PULL 13/16] .travis.yml: drop the travis_retry from tests

This was a crutch when we introduced it - however it does have the disadvantage of causing tests to timeout with large amounts of logs. Lets drop it and see if the stability has improved since. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > Although I've never experienced it, due to not running Windows guests, I've > recently learned that a Windows guest permits a user (hopefully only one > with local admin privileges??!) to "hot-unplug" any PCI device. I've also >

Re: [PATCH v2] mailmap: Add more entries to sanitize 'git log' output

ping? On 1/18/20 3:32 PM, Philippe Mathieu-Daudé wrote: Most of these developers have the Signed-off-by tag properly written, but not the author/committer name. Fix this. Also we incorrectly wrote Arei Gonglei name, update and reorder. The committer name/email is displayed when using: $

[PULL 15/16] .travis.yml: single thread build-tcg

I've theorised that a parallel build-tcg is somehow getting confused when two fedora-30 based cross compilers attempt to build at the same time. From one data-point so far this may fix the problem although the plugins job runs quite close to timeout. Signed-off-by: Alex Bennée Message-Id:

[PULL 14/16] .travis.yml: drop cris-linux-user from the plugins test

While it shouldn't cause problems we will never get useful information from cris as it has yet to be converted to the common translator loop. It also causes the Travis CI to fail for weird reasons which I have so far been unable to replicate on a normal Xenial system. Signed-off-by: Alex Bennée

[PULL 08/16] .travis.yml: move cache flushing to early common phase

We shall be adding more common early setup in a future commit. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200203090932.19147-11-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index f245765cfed..1b92f40eab2

[PULL 09/16] .travis.yml: probe for number of available processors

The arm64 hardware was especially hit by only building on 3 of the 32 available cores. Introduce a JOBS environment variable which we use for all parallel builds. We still run the main checks single threaded though so to make it easier to spot hangs. Signed-off-by: Alex Bennée Reviewed-by:

[PULL 02/16] tests/docker: better handle symlinked libs

When we are copying we want to ensure we grab the first resolution (the found in path section). However even that binary might be a symlink so lets make sure we chase the symlinks to copy the right binary to where it can be found. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[PULL 12/16] .travis.yml: introduce TEST_BUILD_CMD and use it for check-tcg

At least for check-tcg we can split the build phase from the test phase and do the former in parallel. While we are at it drop the V=1 for the check-tcg part as it just generates a lot more noise in the logs. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[PULL 10/16] tests/tcg: add a configure compiler check for ARMv8.1 and SVE

We will need this for some tests later. The docker images already support it by default. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200203090932.19147-13-alex.ben...@linaro.org> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index

[PULL 05/16] .travis.yml: Drop superfluous use of --python=python3 parameter

From: Philippe Mathieu-Daudé As we require Python3 since commit ddf9069963, we don't need to explicit it with the --python=/usr/bin/python3 configure option. Reported-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id:

[PULL 11/16] tests/tcg: gate pauth-% tests on having compiler support

Otherwise we end up failing to build our tests on CI which may have older compilers that the user expects. We can get rid of this once we can fallback to multiarch containers. Signed-off-by: Alex Bennée Message-Id: <20200203090932.19147-14-alex.ben...@linaro.org> diff --git

[PULL 06/16] .travis.yml: Add description to each job

From: Philippe Mathieu-Daudé The NAME variable can be used to describe nicely a job (see [*]). As we currently have 32 jobs, use it. This helps for quickly finding a particular job. before: https://travis-ci.org/qemu/qemu/builds/639887646 after:

[PULL 03/16] travis.yml: Install genisoimage package

From: Wainer dos Santos Moschetta The genisoimage program is required for tests/cdrom-test tests, otherwise they are skipped. The current Travis environments do not provide it by default, so let's explicitly require the genisoimage package. Signed-off-by: Wainer dos Santos Moschetta

[PULL 01/16] tests/docker: move most cross compilers to buster base

This includes fixing up the dependencies (Which were already wrong for one of the mips variants). Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200203090932.19147-2-alex.ben...@linaro.org> diff --git

[PULL 04/16] .shippable: --disable-docs for cross-compile tests

The sphinx support is fairly new and we don't seem to have all the bugs worked out for cross development environments right now. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200203090932.19147-6-alex.ben...@linaro.org> diff

[PULL 07/16] .travis.yml: build documents under bionic

It looks like the xenial tooling doesn't like something in our setup. We should probably be moving to bionic for everything soon anyway (libssh aside). Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[PULL 00/16] testing updates

The following changes since commit 7bd9d0a9e26c7a3c67c0f174f0009ba19969b158: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-02-04' into staging (2020-02-04 16:12:31 +) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [PATCH] make all Python scripts executable

On 2/4/20 5:02 PM, Paolo Bonzini wrote: Scripts that have a Python shebang are meant to be executed directly from the shell; give them 755 permissions. Ah I should have done the chmod in my "Explicit usage of Python 3 (scripts with __main__)" patches, but I would have missed

Re: [PATCH v2 2/4] linux-user: cleanup signal.c

On 2/4/20 6:10 PM, Laurent Vivier wrote: No functional changes. Prepare the field for future fixes. Remove memset(.., 0, ...) that is useless on a static array Signed-off-by: Laurent Vivier --- Notes: v2: replace i, j by target_sig, host_sig linux-user/signal.c | 48

Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

On 31.01.20 18:44, Eric Blake wrote: > Having two slightly-different function names for related purposes is > unwieldy, especially since I envision adding yet another notion of > zero support in an upcoming patch. It doesn't help that > bdrv_has_zero_init() is a misleading name (I originally

Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

On 2/4/20 11:42 AM, Max Reitz wrote: I understand that this is preexisting logic, but could I ask: why? What's wrong if driver can guarantee that created file is all-zero, but is not sure about file resizing? I agree that it's normal for these flags to have the same value, but what is the

Re: [PATCH 10/17] block: Add new BDRV_ZERO_OPEN flag

On 2/4/20 11:34 AM, Max Reitz wrote: +++ b/include/block/block.h @@ -105,6 +105,16 @@ typedef enum { * for drivers that set .bdrv_co_truncate. */ BDRV_ZERO_TRUNCATE = 0x2, + +/* + * bdrv_known_zeroes() should include this bit if an image is + * known to read

Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

On 04.02.20 16:35, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2020 20:44, Eric Blake wrote: >> Having two slightly-different function names for related purposes is >> unwieldy, especially since I envision adding yet another notion of >> zero support in an upcoming patch.  It doesn't help that >>

Re: [PATCH] exec: do not define use_icount for user-mode emulation

Paolo Bonzini writes: > use_icount is also defined by stubs/cpu-get-icount.c, we do not need > to have a useless definition in exec.c. > > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée > --- > exec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] build: move TARGET_GPROF to config-host.mak

Paolo Bonzini writes: > TARGET_GPROF is the same for all targets, write it to > config-host.mak instead. > > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée > --- > bsd-user/syscall.c | 6 +++--- > configure| 4 +++- > linux-user/exit.c| 4 ++-- >

Re: [PATCH 10/17] block: Add new BDRV_ZERO_OPEN flag

On 31.01.20 18:44, Eric Blake wrote: > Knowing that a file reads as all zeroes when created is useful, but > limited in scope to drivers that can create images. However, there > are also situations where pre-existing images can quickly be > determined to read as all zeroes, even when the image

Re: [PATCH] drop "from __future__ import print_function"

Paolo Bonzini writes: > This is only needed for Python 2, which we do not support anymore. > > Based-on: <20200204160028.16211-1-pbonz...@redhat.com> > Cc: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini testing bits Acked-by: Alex Bennée > --- > scripts/analyse-9p-simpletrace.py

Re: [PATCH] build: move TARGET_GPROF to config-host.mak

On 2/4/20 5:11 PM, Paolo Bonzini wrote: TARGET_GPROF is the same for all targets, write it to config-host.mak instead. Signed-off-by: Paolo Bonzini --- bsd-user/syscall.c | 6 +++--- configure| 4 +++- linux-user/exit.c| 4 ++-- linux-user/signal.c | 2 +-

Re: [PATCH 00/17] Improve qcow2 all-zero detection

On 31.01.20 18:44, Eric Blake wrote: > Based-on: <20200124103458.1525982-2-david.edmond...@oracle.com> > ([PATCH v2 1/2] qemu-img: Add --target-is-zero to convert) > > I'm working on adding an NBD extension that reports whether an image > is already all zero when the client first connects. I

Re: [PATCH v2 00/12] python: Explicit usage of Python 3

On 1/30/20 5:32 PM, Philippe Mathieu-Daudé wrote: Hello, These are mechanical sed patches used to convert the code base to Python 3, as suggested on this thread: https://www.mail-archive.com/qemu-devel@nongnu.org/msg675024.html Since v1: - new checkpatch.pl patch - addressed Kevin and Vladimir

[PATCH v2 3/4] linux-user: fix TARGET_NSIG and _NSIG uses

Valid signal numbers are between 1 (SIGHUP) and SIGRTMAX. System includes define _NSIG to SIGRTMAX + 1, but QEMU (like kernel) defines TARGET_NSIG to TARGET_SIGRTMAX. Fix all the checks involving the signal range. Signed-off-by: Laurent Vivier --- Notes: v2: replace i, j by target_sig,

[PATCH v2 4/4] linux-user: fix use of SIGRTMIN

Some RT signals can be in use by glibc, it's why SIGRTMIN (34) is generally greater than __SIGRTMIN (32). So SIGRTMIN cannot be mapped to TARGET_SIGRTMIN. Instead of swapping only SIGRTMIN and SIGRTMAX, map all the range [TARGET_SIGRTMIN ... TARGET_SIGRTMAX - X] to [__SIGRTMIN + X ...

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

On 2/4/20 10:56 AM, John Snow wrote: This is the only instance of a non-zero constant not using a symbolic constant. --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/qemu-options.hx b/qemu-options.hx index

[PATCH v2 11/33] block: Unify bdrv_child_cb_attach()

Make bdrv_child_cb_attach() call bdrv_backing_attach() for children with a COW role (and drop the reverse call from bdrv_backing_attach()), so it can be used for any child (with a proper role set). Because so far no child has a proper role set, we need a temporary new callback for

[PATCH v2 32/33] block: Pass BdrvChildRole in remaining cases

These calls have no real use for the child role yet, but it will not harm to give one. Notably, the bdrv_root_attach_child() call in blockjob.c is left unmodified because there is not much the generic BlockJob object wants from its children. Signed-off-by: Max Reitz --- block/block-backend.c |

Re: [PATCH] drop "from __future__ import print_function"

On 2/4/20 6:10 PM, Paolo Bonzini wrote: On 04/02/20 17:07, Philippe Mathieu-Daudé wrote: On 2/4/20 5:06 PM, Paolo Bonzini wrote: This is only needed for Python 2, which we do not support anymore. Based-on: <20200204160028.16211-1-pbonz...@redhat.com> Cc: Philippe Mathieu-Daudé Signed-off-by:

[PATCH v2 0/4] linux-user: fix use of SIGRTMIN

This series fixes the problem of the first real-time signals already in use by the glibc that are not available for the target glibc. Instead of reverting the first and last real-time signals we rely on the value provided by the glibc (SIGRTMIN) to know the first available signal and we map all

[PATCH v2 2/4] linux-user: cleanup signal.c

No functional changes. Prepare the field for future fixes. Remove memset(.., 0, ...) that is useless on a static array Signed-off-by: Laurent Vivier --- Notes: v2: replace i, j by target_sig, host_sig linux-user/signal.c | 48 ++--- 1 file changed,

[PATCH v2 1/4] linux-user: add missing TARGET_SIGRTMIN for hppa

This signal is defined for all other targets and we will need it later Signed-off-by: Laurent Vivier --- linux-user/hppa/target_signal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h index ba159ff8d006..c2a0102ed73d 100644

Re: [PATCH] drop "from __future__ import print_function"

On 04/02/20 17:07, Philippe Mathieu-Daudé wrote: > On 2/4/20 5:06 PM, Paolo Bonzini wrote: >> This is only needed for Python 2, which we do not support anymore. >> >> Based-on: <20200204160028.16211-1-pbonz...@redhat.com> >> Cc: Philippe Mathieu-Daudé >> Signed-off-by: Paolo Bonzini >> --- >>  

[PATCH v2 29/33] block: Make bdrv_filter_default_perms() static

Signed-off-by: Max Reitz --- block.c | 12 ++-- include/block/block_int.h | 10 -- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index 747a2973f5..091e9cc16a 100644 --- a/block.c +++ b/block.c @@ -2194,12 +2194,12 @@ int

[PATCH v2 30/33] block: Drop bdrv_format_default_perms()

Signed-off-by: Max Reitz --- block.c | 19 --- include/block/block_int.h | 11 --- 2 files changed, 30 deletions(-) diff --git a/block.c b/block.c index 091e9cc16a..b6e35ed552 100644 --- a/block.c +++ b/block.c @@ -2317,25 +2317,6 @@ static void

[PATCH v2 28/33] block: Use bdrv_default_perms()

bdrv_default_perms() can decide which permission profile to use based on the BdrvChildRole, so block drivers do not need to select it explicitly. The blkverify driver now no longer shares the WRITE permission for the image to verify. We thus have to adjust two places in test-block-iothread not

[PATCH v2 33/33] block: Drop @child_class from bdrv_child_perm()

Implementations should decide the necessary permissions based on @role. Signed-off-by: Max Reitz --- block.c | 45 - block/backup-top.c | 3 +-- block/blkdebug.c| 3 +-- block/blklogwrites.c| 3 +--

[PATCH v2 23/33] block: Drop child_backing

Signed-off-by: Max Reitz --- block.c | 62 +++ include/block/block_int.h | 1 - 2 files changed, 4 insertions(+), 59 deletions(-) diff --git a/block.c b/block.c index 6b705ee23a..e245b5d8d9 100644 --- a/block.c +++ b/block.c @@ -1169,15

[PATCH v2 20/33] block: Switch child_format users to child_of_bds

Both users (quorum and blkverify) use child_format for not-really-filtered children, so the appropriate BdrvChildRole in both cases is DATA. (Note that this will cause bdrv_inherited_options() to force-allow format probing.) Signed-off-by: Max Reitz --- block/blkverify.c | 4 ++--

[PATCH v2 24/33] block: Make format drivers use child_of_bds

Commonly, they need to pass the BDRV_CHILD_IMAGE set as the BdrvChildRole; but there are exceptions for drivers with external data files (qcow2 and vmdk). Signed-off-by: Max Reitz --- block/bochs.c | 4 ++-- block/cloop.c | 4 ++-- block/crypto.c| 4 ++-- block/dmg.c | 4

[PATCH v2 10/33] block: Use bdrv_inherited_options()

Let child_file's, child_format's, and child_backing's .inherit_options() implementations fall back to bdrv_inherited_options() to show that it would really work for all of these cases, if only the parents passed the appropriate BdrvChildRole and parent_is_format values. (Also, make

[PATCH v2 31/33] block: Drop child_file

Signed-off-by: Max Reitz --- block.c | 30 +- include/block/block_int.h | 1 - tests/test-bdrv-drain.c | 8 +++- 3 files changed, 4 insertions(+), 35 deletions(-) diff --git a/block.c b/block.c index b6e35ed552..e3390e8d41 100644 ---

[PATCH v2 27/33] tests: Use child_of_bds instead of child_file

Signed-off-by: Max Reitz --- tests/test-bdrv-drain.c | 29 + tests/test-bdrv-graph-mod.c | 6 -- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 15393a0140..91567ca97d 100644 ---

[PATCH v2 16/33] block: Pull out bdrv_default_perms_for_storage()

Signed-off-by: Max Reitz --- block.c | 71 + 1 file changed, 46 insertions(+), 25 deletions(-) diff --git a/block.c b/block.c index b26ec10cce..b7999696d4 100644 --- a/block.c +++ b/block.c @@ -2318,6 +2318,50 @@ static void

[PATCH v2 12/33] block: Unify bdrv_child_cb_detach()

Make bdrv_child_cb_detach() call bdrv_backing_detach() for children with a COW role (and drop the reverse call from bdrv_backing_detach()), so it can be used for any child (with a proper role set). Because so far no child has a proper role set, we need a temporary new callback for

[PATCH v2 25/33] block: Make filter drivers use child_of_bds

Note that some filters have secondary children, namely blkverify (the image to be verified) and blklogwrites (the log). This patch does not touch those children. Note that for blkverify, the filtered child should not be format-probed. While there is nothing enforcing this here, in practice, it

[PATCH v2 04/33] block: Add BdrvChildRole to BdrvChild

For now, it is always set to 0. Later patches in this series will ensure that all callers pass an appropriate combination of flags. Signed-off-by: Max Reitz --- block.c | 11 --- block/backup-top.c | 3 ++- block/blkdebug.c| 2 +-

[PATCH v2 17/33] block: Split bdrv_default_perms_for_storage()

We can be less restrictive about pure data children than those with metadata on them. For bdrv_format_default_perms(), we keep the safe option of bdrv_default_perms_for_metadata() (until we drop bdrv_format_default_perms() altogether). That means that bdrv_default_perms_for_data() is unused at

[PATCH v2 26/33] block: Use child_of_bds in remaining places

Replace child_file by child_of_bds in all remaining places (excluding tests). Signed-off-by: Max Reitz --- block.c | 3 ++- block/backup-top.c | 4 ++-- block/blklogwrites.c | 4 ++-- block/blkreplay.c| 5 +++-- block/raw-format.c | 15 +-- 5 files changed,

[PATCH v2 13/33] block: Add child_of_bds

Any current user of child_file, child_format, and child_backing can and should use this generic BdrvChildClass instead, as it can handle all of these cases. However, to be able to do so, the users must pass the appropriate BdrvChildRole when the child is created/attached. (The following commits

[PATCH v2 19/33] raw-format: Split raw_read_options()

Split raw_read_options() into one function that actually just reads the options, and another that applies them. This will allow us to detect whether the user has specified any options before attaching the file child (so we can decide on its role based on the options). Signed-off-by: Max Reitz

  1   2   3   4   >