Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

2020-03-09 Thread Michael S. Tsirkin
On Mon, Feb 24, 2020 at 02:42:18PM +0800, Longpeng(Mike) wrote: > From: Longpeng > > vhost_log_alloc() may fails and returned pointer of log is null. > However there're two places derefernce the return pointer without > check. > > Signed-off-by: Longpeng > --- > hw/virtio/vhost.c | 19

[PATCH qemu v8 3/3] spapr: Implement Open Firmware client interface

2020-03-09 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a

[PATCH qemu v8 2/3] spapr/cas: Separate CAS handling from rebuilding the FDT

2020-03-09 Thread Alexey Kardashevskiy
At the moment "ibm,client-architecture-support" ("CAS") is implemented in SLOF and QEMU assists via the custom H_CAS hypercall which copies an updated flatten device tree (FDT) blob to the SLOF memory which it then uses to update its internal tree. When we enable the OpenFirmware client interface

[PATCH qemu v8 0/3] spapr: Kill SLOF

2020-03-09 Thread Alexey Kardashevskiy
This is another attempt to implement minimalistic Open Firmware Client Interface in QEMU. v8 is simplified to only support -kernel/-initrd; this does not have early boot serial output (wait until Linux initializes the serial console). With this, I can boot unmodified Fedora 30 via petitboot

[PATCH qemu v8 1/3] ppc/spapr: Move GPRs setup to one place

2020-03-09 Thread Alexey Kardashevskiy
At the moment "pseries" starts in SLOF which only expects the FDT blob pointer in r3. As we are going to introduce a OpenFirmware support in QEMU, we will be booting OF clients directly and these expect a stack pointer in r1, Linux looks at r3/r4 for the initramdisk location (although vmlinux can

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-03-09 Thread Cleber Rosa
On Sat, Feb 08, 2020 at 01:02:41PM +, Peter Maydell wrote: > On Fri, 7 Feb 2020 at 19:34, Cleber Rosa wrote: > > Also, the build and make steps worked fine without `--disable-gnutls`. > > I was trying to not carry over any "exception" type of arguments, > > unless they proved to be necessary.

Re: [PATCH] docs: Add RX target.

2020-03-09 Thread Yoshinori Sato
2020-03-10 00:07 に Eric Blake さんは書きました: On 3/8/20 8:06 AM, Yoshinori Sato wrote: Add rx-virt target specificaion document. specification Signed-off-by: Yoshinori Sato --- docs/system/target-rx.rst | 35 +++ docs/system/targets.rst | 1 + 2 files

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Richard Henderson
On 3/9/20 1:45 PM, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in 3.3.14) so that

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-03-09 Thread Cleber Rosa
On Thu, Feb 06, 2020 at 02:05:04PM +0100, Philippe Mathieu-Daudé wrote: > > > > On another thread Thomas said he doesn't want to be responsible of other > > tests: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg670132.html > > > > We could move the set of tests converted from Peter

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 09:54:27PM +0100, BALATON Zoltan wrote: > On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: > > On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > > > The pci_do_device_reset() function (called from pci_device_reset) > > > clears the PCI_INTERRUPT_LINE config reg

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 09:50:57PM +0100, BALATON Zoltan wrote: > On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: > > On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > > > Some machines operate in "non 100% native mode" where interrupts are > > > fixed at legacy IDE interrupts and

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

2020-03-09 Thread Paul Zimmerman
Hi John, Thanks for the tips! I found an issue when testing with the usb-storage device, so I will work on fixing that, and then think about how best to split up the patches. Thanks, Paul On Mon, Mar 9, 2020 at 7:23 PM John Snow wrote: > > > On 3/6/20 7:34 PM, Paul Zimmerman wrote: > > Hi

Re: [PATCH v2 4/4] virtio-net: block migration if RSS feature negotiated

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: Block migration for reference implementation of RSS feature in QEMU. When we add support for RSS on backend side, we'll implement migration of current RSS settings. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 18

Re: [PATCH v2 3/4] virtio-net: implement RX RSS processing

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 86

Re: [PATCH v2 2/4] virtio-net: implement RSS configuration command

2020-03-09 Thread Jason Wang
On 2020/3/9 下午4:34, Yuri Benditovich wrote: Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 148

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

2020-03-09 Thread David Gibson
On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote: > On reboot, all memory that was previously added using object_add and > device_add is placed in this DIMM area. > > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in > the correct memory zone, so no unmovable

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread David Gibson
On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-03-09 Thread Cleber Rosa
- Original Message - > From: "David Gibson" > To: "Alex Bennée" > Cc: qemu-devel@nongnu.org, "Wainer dos Santos Moschetta" > , "Kamil Rytarowski" > , "Hervé Poussineau" , "Cleber Rosa" > , > qemu-...@nongnu.org, "Philippe Mathieu-Daudé" > Sent: Monday, March 9, 2020 9:41:16 PM >

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-03-09 Thread David Gibson
On Fri, Feb 28, 2020 at 04:10:19PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > Use NetBSD content delivery network to get faster downloads. > > Even with this patch I get failures on my big dev box: > > (48/67) >

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

2020-03-09 Thread John Snow
On 3/6/20 7:34 PM, Paul Zimmerman wrote: > Hi Folks, > > I have been working on an emulation of the dwc-otg USB controller > (host mode only for now), as implemented on the Raspberry Pi 3 and > below, and on numerous other embedded platforms. I have it to a point > where it works pretty well

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

2020-03-09 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Hi Michael, ping... On 2020/2/24 14:42, Longpeng(Mike) wrote: > From: Longpeng > > vhost_log_alloc() may fails and returned pointer of log is null. > However there're two places derefernce the return pointer without > check. > > Signed-off-by: Longpeng > --- > hw/virtio/vhost.c | 19

Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied

2020-03-09 Thread John Snow
CC qemu-block and qcow2 maintainers (Use scripts/get_maintainer.pl to identify maintainers.) On 3/9/20 12:35 PM, Yi Li wrote: > The QCowL2Meta **m parameter is not used > > Signed-off-by: Yi Li > --- > block/qcow2-cluster.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 20:38:08 -0400 Peter Xu wrote: > On Mon, Mar 09, 2020 at 04:33:59PM -0600, Alex Williamson wrote: > > [...] > > > > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > > > index 15747fe2c2..13921b333d 100644 > > > > --- a/hw/intc/ioapic.c > > > > +++ b/hw/intc/ioapic.c >

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

Re: [PATCH] python/qemu/qmp.py: QMP debug with VM label

2020-03-09 Thread John Snow
On 3/4/20 5:05 AM, Oksana Vohchana wrote: > QEMUMachine writes some messages to the default logger. > But it sometimes to hard the read the output if we have requested to > more than one VM. > This patch adds name in QMP command if it needs and labels with it in > debug mode. > Hiya! I like

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
On 10/03/2020 2:54, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!N5car8IBDE_QFIGGfZAaPfF3gc3sv_CIDltJvgI8K5bvOLgPcGxKnVicygP6jf4$ Hi, This series failed the asan build test.

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

Re: [PATCH] spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest

2020-03-09 Thread David Gibson
On Fri, Mar 06, 2020 at 01:33:07PM +0100, Cédric Le Goater wrote: > The "ibm,xive-lisn-ranges" defines ranges of interrupt numbers that > the guest can use to configure IPIs. It starts at 0 today but it could > change to some other offset. Make clear which IRQ range we are > exposing by using

Re: [PATCH 5/5] hw/core/loader: Provide rom_add_file_fixed() a 'max_size' argument

2020-03-09 Thread David Gibson
On Mon, Mar 09, 2020 at 03:43:53PM +0100, Philippe Mathieu-Daudé wrote: > Let rom_add_file_fixed() call rom_add_file() with a 'max_size' > argument, to avoid writing more than the available space for > the ROMs. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > ---

[PATCH] i386/kvm: Add CPU property to expose VMware CPUID signature

2020-03-09 Thread Liran Alon
Some guests are only familiar with VMware PV interface. Therefore, in order for these guests to run properly on KVM, we need to be able to expose VMware main CPUID leaf. i.e. leaf 0x4000. E.g. Without exposing this VMware CPUID leaf, some guests will fail to boot. For example, because of

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Peter Xu
On Mon, Mar 09, 2020 at 04:33:59PM -0600, Alex Williamson wrote: [...] > > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > > index 15747fe2c2..13921b333d 100644 > > > --- a/hw/intc/ioapic.c > > > +++ b/hw/intc/ioapic.c > > > @@ -236,8 +236,27 @@ void ioapic_eoi_broadcast(int vector) > > >

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-09 Thread Pan Nengyuan
On 3/10/2020 12:16 AM, Mark Cave-Ayland wrote: > On 09/03/2020 14:14, Markus Armbruster wrote: > >> Pan Nengyuan writes: >> >>> On 3/9/2020 8:34 PM, Markus Armbruster wrote: Peter Maydell writes: > On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote: >> On 3/9/2020 5:21 PM,

[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2020-03-09 Thread tstrike
L0 DistroRelease: Ubuntu 20.04 on Kernel Linux 5.4.0-14-generic x86_64 L1 3 guestsWindows 10, Centos 8 No L2s No guests are enabled for UEFI Boot -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
On 10/03/2020 2:13, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!IXfneuptZ4caQyQEEgsIN74dLYkkLHJ8XSqL2iGyrzODUx_Jt8Vk-eKN_QQftVU$ Hi, This series seems to have some coding style

Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id:

[PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

2020-03-09 Thread Liran Alon
This is VMware documented functionallity that some guests rely on. Returns the BIOS UUID of the current virtual machine. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 14 ++ include/hw/i386/pc.h | 1 + 2 files changed, 15 insertions(+) diff

[PATCH 06/14] hw/i386/vmport: Define enum for all commands

2020-03-09 Thread Liran Alon
No functional change. Defining an enum for all VMPort commands have the following advantages: * It gets rid of the error-prone requirement to update VMPORT_ENTRIES when new VMPort commands are added to QEMU. * It makes it clear to know by looking at one place at the source, what are all the

[PATCH 13/14] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-09 Thread Liran Alon
This command returns to guest information on LAPIC bus frequency and TSC frequency. One can see how this interface is used by Linux vmware_platform_setup() introduced in Linux commit 88b094fb8d4f ("x86: Hypervisor detection and get tsc_freq from hypervisor"). Reviewed-by: Nikita Leshenko

[PATCH 09/14] hw/i386/vmport: Add support for CMD_GETTIMEFULL

2020-03-09 Thread Liran Alon
Similar to CMD_GETTIME but lacks the 136-year overflow issue, by returning full 64-bit of host uSeconds. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 17 + include/hw/i386/pc.h | 1 + 2 files changed, 18 insertions(+) diff --git

[PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

2020-03-09 Thread Liran Alon
Hi, This series aims to fix several bugs in VMPort and improve it by supporting more VMPort commands and make command results more configurable to user via QEMU command-line. This functionality was proven to be useful to run various VMware VMs when attempting to run them as-is on top of

[PATCH 14/14] hw/i386/vmport: Assert vmport initialized before registering commands

2020-03-09 Thread Liran Alon
vmport_register() is also called from other modules such as vmmouse. Therefore, these modules rely that vmport is realized before those call sites. If this is violated, vmport_register() will NULL-deref. To make such issues easier to debug, assert in vmport_register() that vmport is already

[PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

2020-03-09 Thread Liran Alon
As can be seen from VmCheck_GetVersion() in open-vm-tools code, CMD_GETVERSION should return VMX type in ECX register. Default is to fake host as VMware ESX server. But user can control this value by "-global vmport.vmx-type=X". Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon ---

[PATCH 03/14] hw/i386/vmport: Add device properties

2020-03-09 Thread Liran Alon
No functional change. This is done as a preparation for the following patches that will introduce several device properties. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/i386/vmport.c

[PATCH 12/14] i386/cpu: Store LAPIC bus frequency in CPU structure

2020-03-09 Thread Liran Alon
No functional change. This information will be used by following patches. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- linux-headers/asm-x86/kvm.h | 4 target/i386/cpu.h | 1 + target/i386/kvm.c | 6 +++--- 3 files changed, 8 insertions(+), 3 deletions(-)

[PATCH 02/14] hw/i386/vmport: Set EAX to -1 on failed and unsupported commands

2020-03-09 Thread Liran Alon
This is used as a signal for VMware Tools to know if a command it attempted to invoke, failed or is unsupported. As a result, VMware Tools will either report failure to user or fallback to another backdoor command in attempt to perform some operation. A few examples: * open-vm-tools

[PATCH 08/14] hw/i386/vmport: Add support for CMD_GETTIME

2020-03-09 Thread Liran Alon
This command is used by guest to gettimeofday() from host. See usage example in open-vm-tools TimeSyncReadHost() function. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 21 + include/hw/i386/pc.h | 1 + 2 files changed, 22 insertions(+)

[PATCH 11/14] hw/i386/vmport: Allow x2apic without IR

2020-03-09 Thread Liran Alon
Signal to guest that hypervisor supports x2apic without VT-d/IOMMU Interrupt-Remapping support. This allows guest to use x2apic in case all APIC IDs fits in 8-bit (i.e. Max APIC ID < 255). See Linux kernel commit 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform") and Linux

[PATCH 10/14] hw/i386/vmport: Add support for CMD_GET_VCPU_INFO

2020-03-09 Thread Liran Alon
Command currently returns that it is unimplemented by setting the reserved-bit in it's return value. Following patches will return various useful vCPU information to guest. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 13 + include/hw/i386/pc.h

[PATCH 01/14] hw/i386/vmport: Propagate IOPort read to vCPU EAX register

2020-03-09 Thread Liran Alon
vmport_ioport_read() returns the value that should propagate to vCPU EAX register when guest reads VMPort IOPort (i.e. By x86 IN instruction). However, because vmport_ioport_read() calls cpu_synchronize_state(), the returned value gets overridden by the value in QEMU vCPU EAX register. i.e.

[PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-09 Thread Liran Alon
Instead of hard-coding the VMX version, make it a VMPORT object property. This would allow user to control it's value via "-global vmport.vmx-version=X". Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Peter Xu
On Mon, Mar 09, 2020 at 04:10:59PM -0600, Alex Williamson wrote: > On Fri, 28 Feb 2020 11:15:02 -0500 > Peter Xu wrote: > > > This is majorly only for X86 because that's the only one that supports > > split irqchip for now. > > > > When the irqchip is split, we face a dilemma that KVM irqfd

Re: [PATCH 0/5] docs/system: Split target-arm.rst

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309215818.2021-1-peter.mayd...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Mon, 9 Mar 2020 16:10:59 -0600 Alex Williamson wrote: > On Fri, 28 Feb 2020 11:15:02 -0500 > Peter Xu wrote: > > > This is majorly only for X86 because that's the only one that supports > > split irqchip for now. > > > > When the irqchip is split, we face a dilemma that KVM irqfd will be >

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309204557.14836-1...@altlinux.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Fri, 28 Feb 2020 11:15:02 -0500 Peter Xu wrote: > This is majorly only for X86 because that's the only one that supports > split irqchip for now. > > When the irqchip is split, we face a dilemma that KVM irqfd will be > enabled, however the slow irqchip is still running in the userspace. >

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:12, Peter Maydell wrote: > If you're ready to send out the next version before that, > then leave it with the include:: directive and we can > fix it up to the new structure later. PS: in case you weren't aware, softfreeze for the 5.0 release is 17th March, so if this

[PATCH 5/5] docs: Be consistent about capitalization of 'Arm'

2020-03-09 Thread Peter Maydell
The company 'Arm' went through a rebranding some years back involving a recapitalization from 'ARM' to 'Arm'. As a result our documentation is a bit inconsistent between the two forms. It's not worth trying to update everywhere in QEMU, but it's easy enough to make docs/ consistent. Note that

[PATCH 2/5] docs/system: Split target-arm.rst into sub-documents

2020-03-09 Thread Peter Maydell
Currently the documentation for Arm system emulator targets is in a single target-arm.rst. This describes only some of the boards and often in a fairly abbreviated fashion. Restructure it so that each board has its own documentation file in the docs/system/arm/ subdirectory. This will hopefully

[PATCH 1/5] Makefile: Allow for subdirectories in Sphinx manual dependencies

2020-03-09 Thread Peter Maydell
Currently we put 'docs/foo/*.rst' in the Make list of dependencies for the Sphinx 'foo' manual, which means all the files must be in the top level of that manual's directory. We'd like to be able to have subdirectories inside some of the manuals, so add 'docs/foo/*/*.rst' to the dependencies too.

[PATCH 4/5] docs: Move arm-cpu-features.rst into the system manual

2020-03-09 Thread Peter Maydell
Now we have somewhere to put arm-specific rst documentation, we can move arm-cpu-features.rst from the docs/ top level directory into docs/system/arm/. Signed-off-by: Peter Maydell --- .../{arm-cpu-features.rst => system/arm/cpu-features.rst} | 8 +--- docs/system/target-arm.rst

[PATCH 3/5] docs/system/target-arm.rst: Add some introductory text

2020-03-09 Thread Peter Maydell
Now we've moved the various bits of per-board documentation into their own files, the top level document is a little bare. Add some introductory information, including a note that many of the board models we support are currently undocumented. (Most sections of this new text were originally

[PATCH 0/5] docs/system: Split target-arm.rst

2020-03-09 Thread Peter Maydell
This patchseries splits the 'target-arm.rst' file in the System manual into one file per board or family of boards. It's not sensible for us to document all 50-odd boards in a single enormous page, and the split will encourage more detailed and useful per-board information. The impetus for doing

Re: [PATCH v1 0/5] testing updates (docker and acceptance CI tweaks)

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309202318.3481-1-alex.ben...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v3 0/3] Implement "non 100% native mode" in via-ide

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1583781493.git.bala...@eik.bme.hu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, BALATON Zoltan wrote: On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour

Re: [PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-03-09 Thread Alex Williamson
On Thu, 5 Mar 2020 19:43:24 -0500 Peter Xu wrote: > On Thu, Mar 05, 2020 at 04:58:57PM -0700, Alex Williamson wrote: > > Hi, Alex, > > [...] > > > > +bool kvm_resample_fd_notify(int gsi) > > > +{ > > > +KVMResampleFd *rfd; > > > + > > > +if (!kvm_irqchip_is_split()) { > > > +

[PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread Unai Martinez-Corral
Hi, This series reworks qemu-binfmt-conf.sh: * Argument from option '--systemd' is generalized to , and it is accepted for any mode (default, debian or systemd). It can be a single target arch or a list of them. * Option '-r|--clear' is added, which allows to remove an already registered

[PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Vitaly Chikunov
rlwinm cannot just AND with Mask if shift value is zero on ppc64 when Mask Begin is greater than Mask End and high bits are set to 1. Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and ROTL32 is defined (in 3.3.14) so that rotated value should have two copies of lower word of the

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: The pci_do_device_reset() function (called from pci_device_reset) clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did this without taking wmask into account. We'll

Re: [PULL 00/12] hmp queue

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:48, wrote: > > Patchew URL: > https://patchew.org/QEMU/20200309194650.160552-1-dgilb...@redhat.com/ > > > > Hi, > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Michael S. Tsirkin wrote: On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
On Mon, Mar 9, 2020 at 9:12 PM Peter Maydell wrote: > On Mon, 9 Mar 2020 at 20:05, Niek Linnenbank > wrote: > > Ah now I see what is going on here. So the new rst files are ment to > automatically generate > > documentation in various formats using the Python sphinx tool, correct? > > Yep.

Re: [PATCH] machine/memory encryption: Disable mem merge

2020-03-09 Thread Eduardo Habkost
On Thu, Jan 30, 2020 at 05:50:46PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When a host is running with memory encryption, the memory isn't visible > to the host kernel; attempts to merge that memory are futile because > what it's really comparing is

Re: [PULL 00/12] hmp queue

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309194650.160552-1-dgilb...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > The pci_do_device_reset() function (called from pci_device_reset) > clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did > this without taking wmask into account. We'll have a device model now > that needs to set a

Re: [PATCH v3 3/3] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 08:18:13PM +0100, BALATON Zoltan wrote: > Some machines operate in "non 100% native mode" where interrupts are > fixed at legacy IDE interrupts and some guests expect this behaviour > without checking based on knowledge about hardware. Even Linux has > arch specific

[PATCH v1 4/5] tests/docker: Update VirGL to v0.8.0

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé Building the qemu:debian-amd64 fails when building VirGL: make[2]: Entering directory '/usr/src/virglrenderer/src/gallium/auxiliary' CC cso_cache/cso_cache.lo CC cso_cache/cso_hash.lo CC os/os_misc.lo CC util/u_debug.lo

[PATCH v1 2/5] tests/docker: Update VirGL git repository URL

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé freedesktop.org is moving to a GitLab instance, use the new url. - https://www.fooishbar.org/blog/gitlab-fdo-introduction/ - https://gitlab.freedesktop.org/freedesktop/freedesktop/-/wikis/home Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée

[PATCH v1 0/5] testing updates (docker and acceptance CI tweaks)

2020-03-09 Thread Alex Bennée
Hi, Another week, another testing series. Apart from gathering up some docker tweaks from Phillipe I've also added skips for some MIPS and SPARC acceptance tests that are timing out in CI but not for me locally. Alex Bennée (1): tests/acceptance: disable two more tests while in CI Philippe

[PATCH v1 5/5] tests/acceptance: disable two more tests while in CI

2020-03-09 Thread Alex Bennée
These keep timing out on Travis. The reason is unknown so add a FIXME for those who want to track down exactly why this is happening. In the meantime you can still run check-acceptance manually without change. Signed-off-by: Alex Bennée --- tests/acceptance/machine_mips_malta.py | 2 ++

[PATCH v1 1/5] tests/docker: Install tools to cross-debug and build Linux kernels

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé We often run Linux kernels to test QEMU. We sometimes need to build them manually to use non-default features. We only miss the tiny 'bc' tool. The ncurses library is helpful to run 'make menuconfig'. Finally, gdb-multiarch allow us to debug a TCG guest when its

[PATCH v1 3/5] tests/docker: Remove obsolete VirGL --with-glx configure option

2020-03-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé The GLX configure option has been removed in 71c75f201d [*]. We missed that when updating to v0.7.0 in commit fab3220f97. This silents: configure: creating ./config.status config.status: creating virglrenderer.pc ... configure: WARNING: unrecognized

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Mark Cave-Ayland wrote: On 09/03/2020 00:42, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread BALATON Zoltan
On Mon, 9 Mar 2020, Mark Cave-Ayland wrote: On 09/03/2020 00:42, BALATON Zoltan wrote: Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Peter Maydell
On Mon, 9 Mar 2020 at 20:05, Niek Linnenbank wrote: > Ah now I see what is going on here. So the new rst files are ment to > automatically generate > documentation in various formats using the Python sphinx tool, correct? Yep. Assuming you have Sphinx installed, "make" should build the

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-09 Thread Niek Linnenbank
On Mon, Mar 9, 2020 at 8:43 PM Peter Maydell wrote: > On Mon, 9 Mar 2020 at 19:38, Niek Linnenbank > wrote: > > On Mon, Mar 9, 2020 at 12:22 PM Peter Maydell > wrote: > >> Yes, this is now the right place to put arm board-specific > >> documentation (the rearranging and conversion from texinfo

Re: [PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309191200.GA60@669c1c222ef4/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v10 0/10] qemu-binfmt-conf.sh Message-id: 20200309191200.GA60@669c1c222ef4 Type: series === TEST SCRIPT

Re: [PATCH v10 0/10] qemu-binfmt-conf.sh

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309191200.GA60@669c1c222ef4/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-09 Thread Mark Cave-Ayland
On 09/03/2020 00:42, BALATON Zoltan wrote: > Some machines operate in "non 100% native mode" where interrupts are > fixed at legacy IDE interrupts and some guests expect this behaviour > without checking based on knowledge about hardware. Even Linux has > arch specific workarounds for this that

[PATCH v3 2/3] pci: Honour wmask when resetting PCI_INTERRUPT_LINE

2020-03-09 Thread BALATON Zoltan
The pci_do_device_reset() function (called from pci_device_reset) clears the PCI_INTERRUPT_LINE config reg of devices on the bus but did this without taking wmask into account. We'll have a device model now that needs to set a constant value for this reg and this patch allows to do that without

[PATCH v3 0/3] Implement "non 100% native mode" in via-ide

2020-03-09 Thread BALATON Zoltan
This small series implements "non-100% native mode" of via-ide found at least on pegasos2 where io addresses come from PCI BARs but interrupts are hard coded to legacy IRQ14 and 15. This is needed for guests that expect it and activate work arounds on that platform and don't work unless this is

[PULL 12/12] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Thomas Huth It's been deprecated since QEMU v3.1.0. Time to finally remove it now. Signed-off-by: Thomas Huth Message-Id: <20191205104109.18680-1-th...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Reworked Thomas's deprecated.texi to the rst --- docs/system/deprecated.rst | 15

[PULL 10/12] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c

2020-03-09 Thread Dr. David Alan Gilbert (git)
From: Maxim Levitsky Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert Message-Id: <20200308092440.23564-11-mlevi...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 389 + include/block/block-hmp-cmds.h |

  1   2   3   4   5   6   >