Re: [PATCH v2 3/4] target/i386: add the missing features for Icelake-Server CPU model

2020-03-27 Thread Xiaoyao Li
On 3/28/2020 11:06 AM, Chenyi Qiang wrote: Add the SHA_NI and AVX512IFMA feature bits in FEAT_7_0_EBX, RDPID feature bit in FEAT_7_0_ECX and FSRM feature bit in FEAT_7_0_EDX. Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v6 61/61] target/riscv: configure and turn on vector extension from command line

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Vector extension is default off. The only way to use vector extension is > 1. use cpu rv32 or rv64 > 2. turn on it by command line > "-cpu rv64,x-v=true,vlen=128,elen=64,vext_spec=v0.7.1". > > vlen is the vector register length, default value is 128 bit. >

Re: [PATCH v6 59/61] target/riscv: vector register gather instruction

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 9 ++ > target/riscv/insn32.decode | 3 + > target/riscv/insn_trans/trans_rvv.inc.c | 127 > target/riscv/vector_helper.c| 64

Re: [PATCH v6 58/61] target/riscv: vector slide instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 17 > target/riscv/insn32.decode | 7 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 17 > target/riscv/vector_helper.c| 128

Re: [PATCH v6 57/61] target/riscv: floating-point scalar move instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +/* Floating-Point Scalar Move Instructions */ > +static bool trans_vfmv_f_s(DisasContext *s, arg_vfmv_f_s *a) > +{ > +if (!s->vill && has_ext(s, RVF) && > +(s->mstatus_fs != 0) && (s->sew != 0)) { > +#ifdef HOST_WORDS_BIGENDIAN > +int

Re: [PATCH v6 55/61] target/riscv: integer extract instruction

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +/* Integer Extract Instruction */ > +static void extract_element(TCGv dest, TCGv_ptr base, > +int ofs, int sew) > +{ > +switch (sew) { > +case MO_8: > +tcg_gen_ld8u_tl(dest, base, ofs); > +break; > +

Re: [PATCH v3 2/2] net/colo-compare.c: handling of the full primary or secondary queue

2020-03-27 Thread Derek Su
Lukas Straub 於 2020年3月28日 週六 上午2:28寫道: > > On Sat, 28 Mar 2020 02:20:21 +0800 > Derek Su wrote: > > > Lukas Straub 於 2020年3月28日 週六 上午1:46寫道: > > > > > > On Wed, 25 Mar 2020 17:43:54 +0800 > > > Derek Su wrote: > > > > > > > The pervious handling of the full primary or queue is only dropping >

Re: [PATCH v6 41/61] target/riscv: vector floating-point merge instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +for (i = 0; i < vl; i++) {\ > +if (!vm && !vext_elem_mask(v0, mlen, i)) {\ > +ETYPE s2 = *((ETYPE *)vs2 + H(i));\ > +*((ETYPE *)vd + H1(i)) = s2; \ H1

[PATCH v2 3/4] target/i386: add the missing features for Icelake-Server CPU model

2020-03-27 Thread Chenyi Qiang
Add the SHA_NI and AVX512IFMA feature bits in FEAT_7_0_EBX, RDPID feature bit in FEAT_7_0_ECX and FSRM feature bit in FEAT_7_0_EDX. Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

[PATCH v2 2/4] target/i386: add fast short REP MOV support

2020-03-27 Thread Chenyi Qiang
For CPUs support fast short REP MOV[CPUID.(EAX=7,ECX=0):EDX(bit4)], e.g Icelake and Tigerlake, expose it to the guest VM. Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c

[PATCH v2 4/4] target/i386: modify Icelake-Client and Icelake-Server CPU model number

2020-03-27 Thread Chenyi Qiang
According to the Intel Icelake family list, Icelake-Client uses model number 125(0x7D) and Icelake-Server uses model number 106(0x6A). Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c

[PATCH v2 1/4] target/i386: add missing vmx features for several CPU models

2020-03-27 Thread Chenyi Qiang
Add some missing VMX features in Skylake-Server, Cascadelake-Server and Icelake-Server CPU models based on the output of Paolo's script. Signed-off-by: Chenyi Qiang --- target/i386/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c

[PATCH v2 0/4] modify CPU model info

2020-03-27 Thread Chenyi Qiang
Add the missing VMX features in Skylake-Server, Cascadelake-Server and Icelake-Server CPU models. In Icelake-Server CPU model, it also lacks sha_ni, avx512ifma, rdpid and fsrm. The model numbers of Icelake-Client and Icelake-Server need to be fixed. Changes in v2: - add missing features

Re: [PATCH v6 40/61] target/riscv: vector floating-point classify instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/fpu_helper.c | 33 + > target/riscv/helper.h | 4 ++ > target/riscv/insn32.decode | 1 + > target/riscv/insn_trans/trans_rvv.inc.c | 3 + >

Re: [PATCH v6 39/61] target/riscv: vector floating-point compare instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +static uint8_t vmfne16(uint16_t a, uint16_t b, float_status *s) > +{ > +int compare = float16_compare_quiet(a, b, s); > +return compare != float_relation_equal && > + compare != float_relation_unordered; > +} > + > +static uint8_t

Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.

2020-03-27 Thread maozy
On 3/28/20 2:02 AM, Dr. David Alan Gilbert wrote: * Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: When running: (qemu) info migrate_parameters announce-initial: 50 ms announce-max: 550 ms announce-step: 100 ms compress-wait-thread: on ... max-bandwidth: 33554432 bytes/second

Re: [PATCH v6 29/61] target/riscv: vector narrowing fixed-point clip instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 13 +++ > target/riscv/insn32.decode | 6 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 8 ++ > target/riscv/vector_helper.c| 137

Re: [PATCH v6 28/61] target/riscv: vector single-width scaling shift instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 17 > target/riscv/insn32.decode | 6 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 8 ++ > target/riscv/vector_helper.c| 117

Re: [PATCH v6 27/61] target/riscv: vector widening saturating scaled multiply-add

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 22 +++ > target/riscv/insn32.decode | 7 + > target/riscv/insn_trans/trans_rvv.inc.c | 9 ++ > target/riscv/vector_helper.c| 205

Re: [PATCH v6 25/61] target/riscv: vector single-width averaging add and subtract

2020-03-27 Thread Richard Henderson
On 3/27/20 6:07 PM, LIU Zhiwei wrote: > > > On 2020/3/28 8:32, Richard Henderson wrote: >> On 3/18/20 8:46 PM, LIU Zhiwei wrote: >>> +static inline int32_t asub32(CPURISCVState *env, int vxrm, int32_t a, >>> int32_t b) >>> +{ >>> +int64_t res = (int64_t)a - b; >>> +uint8_t round =

Re: [PATCH v6 26/61] target/riscv: vector single-width fractional multiply with rounding and saturation

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +static int64_t vsmul64(CPURISCVState *env, int vxrm, int64_t a, int64_t b) > +{ > +uint8_t round; > +uint64_t hi_64, lo_64, Hi62; > +uint8_t hi62, hi63, lo63; > + > +muls64(_64, _64, a, b); > +hi62 = extract64(hi_64, 62, 1); > +lo63

Re: [PATCH v6 25/61] target/riscv: vector single-width averaging add and subtract

2020-03-27 Thread LIU Zhiwei
On 2020/3/28 8:32, Richard Henderson wrote: On 3/18/20 8:46 PM, LIU Zhiwei wrote: +static inline int32_t asub32(CPURISCVState *env, int vxrm, int32_t a, int32_t b) +{ +int64_t res = (int64_t)a - b; +uint8_t round = get_round(vxrm, res, 1); + +return (res >> 1) + round; +} + I

PCI device perf limitation

2020-03-27 Thread Mohammad El-Shabani
Hi, I noticed a perf issue in my own pci device, and managed to reproduce it with the pci-testdev with a small patch. Here: 1. diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c 2. index 188de4d9cc..b2e225d25b 100644 3. --- a/hw/misc/pci-testdev.c 4. +++

[PATCH v4 1/2] virtio-blk: delete vqs on the error path in realize()

2020-03-27 Thread Pan Nengyuan
virtio_vqs forgot to free on the error path in realize(). Fix that. The asan stack: Direct leak of 14336 byte(s) in 1 object(s) allocated from: #0 0x7f58b93fd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7f58b858249d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d) #2

[PATCH v4 0/2] fix two virtio queues memleak

2020-03-27 Thread Pan Nengyuan
This series fix two vqs leak: 1. Do delete vqs on the error path in virtio_blk_device_realize(). 2. Do delete vqs in virtio_iommu_device_unrealize() to fix another leaks. v2->v1: - Fix incorrect free in virtio_blk_device_realize, it will cause a uaf. v3->v2: - Also clean 's->as_by_busptr' hash

[PATCH v4 2/2] virtio-iommu: avoid memleak in the unrealize

2020-03-27 Thread Pan Nengyuan
req_vq/event_vq forgot to free in unrealize. Fix that. And also do clean 's->as_by_busptr' hash table in unrealize to fix another leak. Signed-off-by: Pan Nengyuan Acked-by: Eric Auger --- Cc: Eric Auger Cc: Stefan Hajnoczi --- v3->v1/v2: - Also clean 's->as_by_busptr' hash table in

Re: [PATCH v6 25/61] target/riscv: vector single-width averaging add and subtract

2020-03-27 Thread Richard Henderson
On 3/18/20 8:46 PM, LIU Zhiwei wrote: > +static inline int32_t asub32(CPURISCVState *env, int vxrm, int32_t a, > int32_t b) > +{ > +int64_t res = (int64_t)a - b; > +uint8_t round = get_round(vxrm, res, 1); > + > +return (res >> 1) + round; > +} > + > > I find a corner case here.  As

Re: [PATCH v3 2/2] virtio-iommu: delete vqs in unrealize to fix memleak

2020-03-27 Thread Pan Nengyuan
On 3/28/2020 12:26 AM, Stefano Garzarella wrote: > On Fri, Mar 27, 2020 at 05:56:42PM +0800, Pan Nengyuan wrote: >> req_vq/event_vq forgot to free in unrealize. Fix that. >> And aslo do clean 's->as_by_busptr' hash table in unrealize to fix another >> leak. > > s/aslo/also > > Maybe we can

[Bug 1868116] Re: QEMU monitor no longer works

2020-03-27 Thread Launchpad Bug Tracker
This bug was fixed in the package vte2.91 - 0.60.0-2ubuntu2 --- vte2.91 (0.60.0-2ubuntu2) focal; urgency=medium * debian/libvte-2.91-0.install - Dropped files duplicated in libvte-2.91-common * debian/control.in - Add appropriate Breaks/Replaces for moved files. -- Ken

Re: [PATCH v6 24/61] target/riscv: vector single-width saturating add and subtract

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 33 ++ > target/riscv/insn32.decode | 10 + > target/riscv/insn_trans/trans_rvv.inc.c | 16 + > target/riscv/vector_helper.c| 389

Re: [PATCH v6 23/61] target/riscv: vector integer merge and move instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +if (s->vl_eq_vlmax) { > +#ifdef TARGET_RISCV64 > +tcg_gen_gvec_dup_i64(s->sew, vreg_ofs(s, a->rd), > + MAXSZ(s), MAXSZ(s), s1); > +#else > +tcg_gen_gvec_dup_i32(s->sew, vreg_ofs(s, a->rd), > +

Re: [PATCH v6 18/61] target/riscv: vector single-width integer multiply instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +static int64_t do_mulhsu_d(int64_t s2, uint64_t s1) > +{ > +uint64_t hi_64, lo_64, abs_s2 = s2; > + > +if (s2 < 0) { > +abs_s2 = -s2; > +} > +mulu64(_64, _64, abs_s2, s1); > +if (s2 < 0) { > +lo_64 = ~lo_64; > +

Re: [PATCH v6 12/61] target/riscv: vector integer add-with-carry / subtract-with-borrow instructions

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > target/riscv/helper.h | 33 ++ > target/riscv/insn32.decode | 11 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 78 + > target/riscv/vector_helper.c| 148

Re: [PATCH v6 10/61] target/riscv: vector single-width integer add and subtract

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > +if (a->vm && s->vl_eq_vlmax) { > +gvec_fn(s->sew, vreg_ofs(s, a->rd), > +vreg_ofs(s, a->rs2), vreg_ofs(s, a->rs1), > +MAXSZ(s), MAXSZ(s)); Indentation is off here. > +static inline bool > +do_opivx_gvec(DisasContext *s,

Re: [PATCH v6 09/61] target/riscv: add vector amo operations

2020-03-27 Thread Richard Henderson
On 3/17/20 8:06 AM, LIU Zhiwei wrote: > Vector AMOs operate as if aq and rl bits were zero on each element > with regard to ordering relative to other instructions in the same hart. > Vector AMOs provide no ordering guarantee between element operations > in the same vector AMO instruction > >

Re: [PATCH v6 05/61] target/riscv: add an internals.h header

2020-03-27 Thread Richard Henderson
On 3/17/20 8:05 AM, LIU Zhiwei wrote: > The internals.h keeps things that are not relevant to the actual architecture, > only to the implementation, separate. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/internals.h | 24 > 1 file changed, 24 insertions(+) >

[PATCH] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-03-27 Thread Richard Henderson
All other calls to normalize*Subnormal detect zero input before the call -- this is the only outlier. This case can happen with +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of the correct sign. Reported-by: Coverity (CID 1421991) Signed-off-by: Richard Henderson ---

Re: [PATCH] qemu-user: fix build with LLVM lld 10

2020-03-27 Thread Richard Henderson
On 3/27/20 3:51 AM, Laurent Vivier wrote: >> The Plan is still to drop this whole section of code. >> >> However, it's still blocked on getting the x86_64 vsyscall patches upstream. > > Richard, > > will you propose another fix to fix build with LLVM lld 10? Sent. r~

Re: [PATCH v1 5/7] fpu/softfloat: avoid undefined behaviour when normalising empty sigs

2020-03-27 Thread Peter Maydell
On Fri, 27 Mar 2020 at 22:27, Richard Henderson wrote: > I wonder if I have the energy to petition the committee to drop, for C202? all > of the "undefined" nonsense that only applies to sign-magnitute and > ones-compliment computers, which haven't been seen since the 70's... There was certainly

Re: [PATCH v1 5/7] fpu/softfloat: avoid undefined behaviour when normalising empty sigs

2020-03-27 Thread Richard Henderson
On 3/27/20 3:09 AM, Peter Maydell wrote: > On Fri, 27 Mar 2020 at 09:49, Alex Bennée wrote: >> >> The undefined behaviour checker pointed out that a shift of 64 would >> lead to undefined behaviour. >> >> Signed-off-by: Alex Bennée >> --- >> fpu/softfloat.c | 11 --- >> 1 file changed,

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 17:53:39 +0100 David Hildenbrand wrote: > On 27.03.20 17:46, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 17:05:34 +0100 > > Christian Borntraeger wrote: > > > >> On 27.03.20 17:01, David Hildenbrand wrote: > >>> On 27.03.20 16:34, Christian Borntraeger wrote: >

Re: [PATCH v1 3/7] tests/tcg: remove extraneous pasting macros

2020-03-27 Thread Richard Henderson
On 3/27/20 2:49 AM, Alex Bennée wrote: > We are not using them and they just get in the way. > > Signed-off-by: Alex Bennée > --- > tests/tcg/x86_64/system/boot.S | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH for-5.0 v3 6/7] configure: Override the os default with --disable-pie

2020-03-27 Thread Richard Henderson
Some distributions, e.g. Ubuntu 19.10, enable PIE by default. If for some reason one wishes to build a non-pie binary, we must provide additional options to override. At the same time, reorg the code to an elif chain. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH v1 2/7] linux-user: protect fcntl64 with an #ifdef

2020-03-27 Thread Richard Henderson
On 3/27/20 2:49 AM, Alex Bennée wrote: > Checking TARGET_ABI_BITS is sketchy - we should check for the presence > of the define to be sure. Also clean up the white space while we are > there. > > Signed-off-by: Alex Bennée > --- > linux-user/syscall.c | 8 > 1 file changed, 4

[PATCH for-5.0 v3 4/7] configure: Always detect -no-pie toolchain support

2020-03-27 Thread Richard Henderson
The CFLAGS_NOPIE and LDFLAGS_NOPIE variables are used in pc-bios/optionrom/Makefile, which has nothing to do with the PIE setting of the main qemu executables. This overrides any operating system default to build all executables as PIE, which is important for ROMs. Reviewed-by: Philippe

Re: [PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Richard Henderson
On 3/27/20 2:49 AM, Alex Bennée wrote: > It's perfectly possible to have no function symbols in your elf file > and if we do the undefined behaviour sanitizer rightly complains about > us passing NULL to qsort. Check nsyms before we go ahead. > > Signed-off-by: Alex Bennée > --- >

[PATCH for-5.0 v3 3/7] configure: Do not force pie=no for non-x86

2020-03-27 Thread Richard Henderson
PIE is supported on many other hosts besides x86. The default for non-x86 is now the same as x86: pie is used if supported, and may be forced via --enable/--disable-pie. The original commit (40d6444e91c) said: "Non-x86 are not changed, as they require TCG changes" but I think that's wrong --

[PATCH for-5.0 v3 2/7] tcg: Remove softmmu code_gen_buffer fixed address

2020-03-27 Thread Richard Henderson
The commentary talks about "in concert with the addresses assigned in the relevant linker script", except there is no linker script for softmmu, nor has there been for some time. (Do not confuse the user-only linker script editing that was removed in the previous patch, because user-only does not

[PATCH for-5.0 v3 1/7] configure: Drop adjustment of textseg

2020-03-27 Thread Richard Henderson
This adjustment was random and unnecessary. The user mode startup code in probe_guest_base() will choose a value for guest_base that allows the host qemu binary to not conflict with the guest binary. With modern distributions, this isn't even used, as the default is PIE, which does the same job

[PATCH for-5.0 v3 7/7] configure: Support -static-pie if requested

2020-03-27 Thread Richard Henderson
Recent toolchains support static and pie at the same time. As with normal dynamic builds, allow --static to default to PIE if supported by the toolchain. Allow --enable/--disable-pie to override the default. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Fix --disable-pie

[PATCH for-5.0 v3 5/7] configure: Unnest detection of -z, relro and -z, now

2020-03-27 Thread Richard Henderson
There is nothing about these options that is related to PIE. Use them unconditionally. Reviewed-by: Alex Bennée Reviewed-by: Fangrui Song Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- v2: Do not split into two tests. v3: Update to QEMU_LDFLAGS. --- configure | 9

[PATCH for-5.0 v3 0/7] configure: Improve PIE and other linkage

2020-03-27 Thread Richard Henderson
Version 3 is a rebase from January, with s/LDCONFIG/QEMU_LDCONFIG/. I plan on including this in the next tcg-next pull request, if there is no other commentary. r~ Richard Henderson (7): configure: Drop adjustment of textseg tcg: Remove softmmu code_gen_buffer fixed address configure: Do

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2020 17:51:23 +0100 David Hildenbrand wrote: > On 27.03.20 17:48, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 16:29:30 +0100 > > David Hildenbrand wrote: > > > >> Historically, we fixed up the RAM size (rounded it down), to fit into > >> storage increments. Since commit

Re: [PATCH v6 5/8] gpiolib: Introduce gpiod_set_config()

2020-03-27 Thread Linus Walleij
On Tue, Mar 24, 2020 at 2:57 PM Geert Uytterhoeven wrote: > The GPIO Aggregator will need a method to forward a .set_config() call > to its parent gpiochip. This requires obtaining the gpio_chip and > offset for a given gpio_desc. While gpiod_to_chip() is public, > gpio_chip_hwgpio() is not,

Re: [PATCH v6 5/8] gpiolib: Introduce gpiod_set_config()

2020-03-27 Thread Linus Walleij
two cleanups that I tried to apply) byt Yue's cleanup patch > > commit d18fddff061d2796525e6d4a958cb3d30aed8efd > > "gpiolib: Remove duplicated function gpio_do_set_config()" > > makes none of them apply :/ > > /me confused. > > That commit was reverted la

Re: Error building Qemu 2.12.0 on Fedora 31 GCC 9.2.1 with the below error

2020-03-27 Thread Peter Maydell
On Fri, 27 Mar 2020 at 20:49, Viktor Madarasz wrote: > > Hi > > Im trying to build Qemu 2.12.0 on Fedora 31 with GCC 9.2.1 as this > particular qemu version is the only one working for my > qemu-systems-ppc64 emulation I need > > ./configure runs with no problem but running make breaks at this

[Bug 1869426] Re: 5.0rc0->4.2 serial migraiton

2020-03-27 Thread Dr. David Alan Gilbert
git bisect says: c9808d602813bce4fada7bf9ecc463aa779b73f7 is the first bad commit commit c9808d602813bce4fada7bf9ecc463aa779b73f7 Author: Marc-André Lureau Date: Tue Oct 22 01:02:50 2019 +0200 serial: realize the serial device Instead of calling serial_realize_core(), use the QDev

[Bug 1869426] Re: 5.0rc0->4.2 serial migraiton

2020-03-27 Thread Dr. David Alan Gilbert
Marc-Andre: I think you're ending up with two top level objects with vmsd's -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869426 Title: 5.0rc0->4.2 serial migraiton Status in QEMU: New Bug

Re: AIO_WAIT_WHILE questions

2020-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1242491200.59.1585326983...@webmail.proxmox.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: AIO_WAIT_WHILE questions Message-id: 1242491200.59.1585326983...@webmail.proxmox.com Type: series

Error building Qemu 2.12.0 on Fedora 31 GCC 9.2.1 with the below error

2020-03-27 Thread Viktor Madarasz
Hi Im trying to build Qemu 2.12.0 on Fedora 31 with GCC 9.2.1 as this particular qemu version is the only one working for my qemu-systems-ppc64 emulation I need ./configure runs with no problem but running make breaks at this point. --   CC 

[PULL 5/5] cmd646-ide: use qdev gpio rather than qemu_allocate_irqs()

2020-03-27 Thread John Snow
From: Mark Cave-Ayland This prevents the memory from qemu_allocate_irqs() from being leaked which can in some cases be spotted by Coverity (CID 1421984). Signed-off-by: Mark Cave-Ayland Message-id: 20200324210519.2974-4-mark.cave-ayl...@ilande.co.uk Signed-off-by: John Snow ---

[PULL 4/5] via-ide: use qdev gpio rather than qemu_allocate_irqs()

2020-03-27 Thread John Snow
From: Mark Cave-Ayland This prevents the memory from qemu_allocate_irqs() from being leaked which can in some cases be spotted by Coverity (CID 1421984). Signed-off-by: Mark Cave-Ayland Message-id: 20200324210519.2974-3-mark.cave-ayl...@ilande.co.uk Signed-off-by: John Snow --- hw/ide/via.c

[PULL 2/5] hw/ide/sii3112: Use qdev gpio rather than qemu_allocate_irqs()

2020-03-27 Thread John Snow
From: Peter Maydell Coverity points out (CID 1421984) that we are leaking the memory returned by qemu_allocate_irqs(). We can avoid this leak by switching to using qdev_init_gpio_in(); the base class finalize will free the irqs that this allocates under the hood. Signed-off-by: Peter Maydell

[PULL 3/5] via-ide: don't use PCI level for legacy IRQs

2020-03-27 Thread John Snow
From: Mark Cave-Ayland The PCI level calculation was accidentally left in when rebasing from a previous patchset. Since both IRQs are driven separately, the value being passed into the IRQ handler should be used directly. Signed-off-by: Mark Cave-Ayland Message-id:

[Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton

2020-03-27 Thread Dr. David Alan Gilbert
Public bug reported: Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error: Unknown savevm section or instance 'serial' 1 dumping the migration streams it looks like 5.0 is duplicating the serial migration data: "serial (26)": { "divider": "0x000c", "rbr": "0x00",

[PULL 1/5] fdc/i8257: implement verify transfer mode

2020-03-27 Thread John Snow
From: Sven Schnelle While working on the Tulip driver i tried to write some Teledisk images to a floppy image which didn't work. Turned out that Teledisk checks the written data by issuing a READ command to the FDC but running the DMA controller in VERIFY mode. As we ignored the DMA request in

[PULL 0/5] Ide patches

2020-03-27 Thread John Snow
The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-26 20:55:54 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git

Re: AIO_WAIT_WHILE questions

2020-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1242491200.59.1585326983...@webmail.proxmox.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] qtest: add tulip test case

2020-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200327161146.16402-1-liq...@163.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v4] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Eric Blake
On 3/27/20 1:59 PM, Alberto Garcia wrote: A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images

Re: [PULL v2 for 5.0 00/12] testing updates (+ one mttcg change)

2020-03-27 Thread Peter Maydell
On Fri, 27 Mar 2020 at 18:13, Alex Bennée wrote: > > The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging > (2020-03-26 20:55:54 +) > > are available in the Git

Re: [PATCH v3] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Alberto Garcia
On Fri 27 Mar 2020 07:57:40 PM CET, Eric Blake wrote: >> +/* If the image does not support QCOW_OFLAG_ZERO then discarding >> + * clusters could expose stale data from the backing file. */ >> +if (s->qcow_version < 3 && bs->backing) { >> +return -ENOTSUP; >> +} > > Hmm.

[PATCH v4] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Alberto Garcia
A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images the cluster is simply deallocated, exposing

Re: [PATCH v3] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Eric Blake
On 3/27/20 11:48 AM, Alberto Garcia wrote: A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images

Re: [PATCH v3] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Eric Blake
On 3/27/20 1:43 PM, Alberto Garcia wrote: On Fri 27 Mar 2020 07:13:04 PM CET, Eric Blake wrote: +for qcow2_compat in 0.10 1.1; do +echo "# Create an image with compat=$qcow2_compat without a backing file" +_make_test_img -o "compat=$qcow2_compat" 128k + +echo "# Fill all clusters

Re: [PATCH 2/3] io: Support shutdown of TLS channel

2020-03-27 Thread Eric Blake
On 3/27/20 12:43 PM, Daniel P. Berrangé wrote: I don't think it is acceptable to do this loop here. The gnutls_bye() function triggers several I/O operations which could block. Looping like this means we busy-wait, blocking this thread for as long as I/O is blocking on the socket. Hmm, good

Re: [PATCH 0/3] nbd: Try for cleaner TLS shutdown

2020-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200327161936.2225989-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v3] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Alberto Garcia
On Fri 27 Mar 2020 07:13:04 PM CET, Eric Blake wrote: >> +for qcow2_compat in 0.10 1.1; do >> +echo "# Create an image with compat=$qcow2_compat without a backing >> file" >> +_make_test_img -o "compat=$qcow2_compat" 128k >> + >> +echo "# Fill all clusters with data and then discard

Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.

2020-03-27 Thread Stefano Garzarella
On Sat, Mar 28, 2020 at 12:14:54AM +0800, Mao Zhongyi wrote: > When running: > (qemu) info migrate_parameters > announce-initial: 50 ms > announce-max: 550 ms > announce-step: 100 ms > compress-wait-thread: on > ... > max-bandwidth: 33554432 bytes/second > downtime-limit: 300 milliseconds >

Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Robert Foley
On Fri, 27 Mar 2020 at 01:14, Emilio G. Cota wrote: > > (Apologies if I missed some Cc's; I was not Cc'ed in patch 0 > so I'm blindly crafting a reply.) Sorry I forgot to including you in patch 0, my bad. Will be sure to include you in the future. > On Thu, Mar 26, 2020 at 15:30:43 -0400,

Re: [PATCH v3 2/2] net/colo-compare.c: handling of the full primary or secondary queue

2020-03-27 Thread Lukas Straub
On Sat, 28 Mar 2020 02:20:21 +0800 Derek Su wrote: > Lukas Straub 於 2020年3月28日 週六 上午1:46寫道: > > > > On Wed, 25 Mar 2020 17:43:54 +0800 > > Derek Su wrote: > > > > > The pervious handling of the full primary or queue is only dropping > > > the packet. If there are lots of clients to the guest

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread David Hildenbrand
On 27.03.20 19:16, Halil Pasic wrote: > On Fri, 27 Mar 2020 17:46:20 +0100 > Igor Mammedov wrote: > >> On Fri, 27 Mar 2020 17:05:34 +0100 >> Christian Borntraeger wrote: >> >>> On 27.03.20 17:01, David Hildenbrand wrote: On 27.03.20 16:34, Christian Borntraeger wrote: > > >

Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Alex Bennée
Emilio G. Cota writes: > (Apologies if I missed some Cc's; I was not Cc'ed in patch 0 > so I'm blindly crafting a reply.) > >> Changes for V8: >> - Fixed issue where in rr mode we could destroy the BQL twice. > > I remember doing little to no testing in record-replay mode, so > there should

[PULL v2 12/12] .travis.yml: Add a KVM-only s390x job

2020-03-27 Thread Alex Bennée
From: Philippe Mathieu-Daudé Add a job to build QEMU on s390x with TCG disabled, so this configuration won't bitrot over time. This job is quick, running check-unit: Ran for 5 min 30 sec https://travis-ci.org/github/philmd/qemu/jobs/665456423 Acked-by: Cornelia Huck Signed-off-by: Philippe

Re: [PATCH v3 2/2] net/colo-compare.c: handling of the full primary or secondary queue

2020-03-27 Thread Derek Su
Lukas Straub 於 2020年3月28日 週六 上午1:46寫道: > > On Wed, 25 Mar 2020 17:43:54 +0800 > Derek Su wrote: > > > The pervious handling of the full primary or queue is only dropping > > the packet. If there are lots of clients to the guest VM, > > the "drop" will lead to the lost of the networking

[PULL v2 09/12] tests/docker: Install gcrypt devel package in Debian image

2020-03-27 Thread Alex Bennée
From: Philippe Mathieu-Daudé In commit 6f8bbb374be we enabled building with the gcrypt library on the the Debian 'x86 host', which was based on Debian Stretch. Later in commit 698a71edbed we upgraded the Debian base image to Buster. Apparently Debian Stretch was listing gcrypt as a QEMU

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-27 Thread Halil Pasic
On Fri, 27 Mar 2020 17:46:20 +0100 Igor Mammedov wrote: > On Fri, 27 Mar 2020 17:05:34 +0100 > Christian Borntraeger wrote: > > > On 27.03.20 17:01, David Hildenbrand wrote: > > > On 27.03.20 16:34, Christian Borntraeger wrote: > > >> > > >> > > >> On 27.03.20 16:29, David Hildenbrand wrote:

[PULL v2 10/12] tests/docker: Use Python3 PyYAML in the Fedora image

2020-03-27 Thread Alex Bennée
From: Philippe Mathieu-Daudé The Python2 PyYAML is now pointless, switch to the Python3 version. Fixes: bcbf27947 (docker: move tests from python2 to python3) Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

[PULL v2 11/12] tests/docker: Add libepoxy and libudev packages to the Fedora image

2020-03-27 Thread Alex Bennée
From: Philippe Mathieu-Daudé Install optional dependencies of QEMU to get better coverage. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200322120104.21267-5-phi...@redhat.com> Message-Id:

[PULL v2 05/12] tests/vm: update NetBSD to 9.0

2020-03-27 Thread Alex Bennée
From: Gerd Hoffmann The installer supports GPT now, so the install workflow has changed a bit. Also: run without VGA device. This works around a bug in the seabios sercon code and makes the bootloader menu show up on the serial line, so we can drop the quirk for that. Signed-off-by: Gerd

[PULL v2 07/12] configure: disable MTTCG for MIPS guests

2020-03-27 Thread Alex Bennée
While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu

[PULL v2 04/12] tests/vm: update FreeBSD to 12.1

2020-03-27 Thread Alex Bennée
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Alex Bennée Message-Id: <20200310083218.26355-4-kra...@redhat.com> Message-Id: <20200323161514.23952-4-alex.ben...@linaro.org> diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 58166766d91..298967fe9cf 100755 ---

[PULL v2 08/12] tests/docker: Keep package list sorted

2020-03-27 Thread Alex Bennée
From: Philippe Mathieu-Daudé Keep package list sorted, this eases rebase/cherry-pick. Fixes: 3a6784813 Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200322120104.21267-2-phi...@redhat.com> Message-Id:

[PULL v2 02/12] tests/vm: write raw console log

2020-03-27 Thread Alex Bennée
From: Gerd Hoffmann Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal to watch the install console. Signed-off-by: Gerd Hoffmann Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200310083218.26355-2-kra...@redhat.com> Message-Id:

[PULL v2 06/12] tests/vm: fix basevm config

2020-03-27 Thread Alex Bennée
When the patch was merged it was part of a longer series which had already merged the config changes. Semu-revert the config related changes for now so things will build. Fixes: b081986c85fd2 Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 03/12] tests/vm: move vga setup

2020-03-27 Thread Alex Bennée
From: Gerd Hoffmann Move '-device VGA' from basevm.py to the guests, so they have the chance to opt out and run without display device. Signed-off-by: Gerd Hoffmann Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200310083218.26355-3-kra...@redhat.com>

Re: [PATCH v3] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-27 Thread Eric Blake
On 3/27/20 11:48 AM, Alberto Garcia wrote: A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images

[PULL v2 for 5.0 00/12] testing updates (+ one mttcg change)

2020-03-27 Thread Alex Bennée
The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-26 20:55:54 +) are available in the Git repository at: https://github.com/stsquad/qemu.git

[PULL v2 01/12] qemu/atomic.h: add #ifdef guards for stdatomic.h

2020-03-27 Thread Alex Bennée
Deep inside the FreeBSD netmap headers we end up including stdatomic.h which clashes with qemu's atomic functions which are modelled along the C11 standard. To avoid a massive rename lets just ifdef around the problem. Signed-off-by: Alex Bennée Message-Id:

Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.

2020-03-27 Thread Dr. David Alan Gilbert
* Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: > When running: > (qemu) info migrate_parameters > announce-initial: 50 ms > announce-max: 550 ms > announce-step: 100 ms > compress-wait-thread: on > ... > max-bandwidth: 33554432 bytes/second > downtime-limit: 300 milliseconds >

  1   2   3   >