Re: [PATCH 5/6] acpi: serial: don't use _STA method

2020-03-31 Thread Gerd Hoffmann
Hi, > > Hmm, I'm wondering whenever it would be useful to have ... > > > >ISADeviceClass->build_aml(Aml *scope, ISADevice *dev); > > in relation to iqr, you said earlier that device doesn't know to which irq > it's mapped. > that might be a problem in this case, likewise for (MM)IO

Re: [PATCH v14 3/4] qcow2: add zstd cluster compression

2020-03-31 Thread Vladimir Sementsov-Ogievskiy
31.03.2020 20:44, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance

Re: [PATCH for-5.0?] qemu-img: Report convert errors by bytes, not sectors

2020-03-31 Thread Vladimir Sementsov-Ogievskiy
01.04.2020 1:24, Eric Blake wrote: Various qemu-img commands are inconsistent on whether they report status/errors in terms of bytes or sector offsets. The latter is confusing (especially as more places move to 4k block sizes), so let's switch everything to just use bytes everywhere.

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 31 Mar 2020 at 10:01, Markus Armbruster wrote: >> I doubt including basic spatch instructions with every script is a good >> idea. Better explain it in one place, with proper maintenance. >> scripts/coccinelle/README? We could be a bit more verbose there, >>

RE: [PATCH v2 10/22] vfio/pci: set host iommu context to vIOMMU

2020-03-31 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > Sent: Tuesday, March 31, 2020 10:30 PM > To: Liu, Yi L ; qemu-devel@nongnu.org; > Subject: Re: [PATCH v2 10/22] vfio/pci: set host iommu context to vIOMMU > > Yi, > > On 3/30/20 6:24 AM, Liu Yi L wrote: > > For vfio-pci devices, it could use

[PATCH] migration/throttle: use the xfer pages as threshold

2020-03-31 Thread Wang Xin
If VM migration with lots of zero page or enable data compress, the peroid tansfer bytes may be much less than the available bandwidth, which trigger unnecessary guest throttle down. Use the raw transfer pages as the threshold instead. Signed-off-by: Wang Xin diff --git a/migration/ram.c

[PATCH] exec: fetch the alignment of Linux devdax pmem character device nodes

2020-03-31 Thread Jingqi Liu
If the backend file is devdax pmem character device, the alignment specified by the option 'align=NUM' in the '-object memory-backend-file' needs to match the alignment requirement of the devdax pmem character device. This patch fetches the devdax pmem file 'align', so that we can compare it with

[PATCH] MAINTAINERS: Add myself as vhost-user-blk maintainer

2020-03-31 Thread Raphael Norwitz
As suggested by Michael, let's add me as a maintainer of vhost-user-blk and vhost-user-scsi. CC: Michael S. Tsirkin CC Peter Maydell Signed-off-by: Raphael Norwitz --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] configure: warn if not using a separate build directory

2020-03-31 Thread Carlo Arenas
On Tue, Mar 31, 2020 at 3:38 AM Daniel P. Berrangé wrote: > Running configure directly from the source directory is a build > configuration that will go away in future. It is also not currently > s/in future/in the future/g Carlo

Re: [PATCH v2] migration/throttle: Add cpu-throttle-tailslow migration parameter

2020-03-31 Thread zhukeqian
Hi Eric, On 2020/3/31 23:03, Eric Blake wrote: > On 3/15/20 11:29 PM, Keqian Zhu wrote: >> At the tail stage of throttling, the Guest is very sensitive to >> CPU percentage while the @cpu-throttle-increment is excessive >> usually at tail stage. >> >> If this parameter is true, we will compute

Re: Question on dirty sync before kvm memslot removal

2020-03-31 Thread Paolo Bonzini
On 31/03/20 18:51, Peter Xu wrote: > On Tue, Mar 31, 2020 at 05:34:43PM +0200, Paolo Bonzini wrote: >> On 31/03/20 17:23, Peter Xu wrote: Or KVM_MEM_READONLY. >>> Yeah, I used a new flag because I thought READONLY was a bit tricky to >>> be used directly here. The thing is IIUC if guest

Re: [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-03-31 Thread Peter Xu
On Tue, Mar 31, 2020 at 04:32:45PM -0600, Alex Williamson wrote: > On Wed, 18 Mar 2020 10:51:59 -0400 > Peter Xu wrote: > > > v4: > > - pick r-b and a-b for Alex without patch 4 > > - only kick resamplefd for level triggered irq (as 3.1 change on patch > > 4) [Alex] > > - fix mingw build error

Re: [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-03-31 Thread Alex Williamson
On Wed, 18 Mar 2020 10:51:59 -0400 Peter Xu wrote: > v4: > - pick r-b and a-b for Alex without patch 4 > - only kick resamplefd for level triggered irq (as 3.1 change on patch > 4) [Alex] > - fix mingw build error with below squashed into patch 4: IMO, it'd be nice to get this in for QEMU

[PATCH for-5.0?] qemu-img: Report convert errors by bytes, not sectors

2020-03-31 Thread Eric Blake
Various qemu-img commands are inconsistent on whether they report status/errors in terms of bytes or sector offsets. The latter is confusing (especially as more places move to 4k block sizes), so let's switch everything to just use bytes everywhere. Signed-off-by: Eric Blake --- Noticed while

Re: [PATCH v1] vl/s390: fixup ram sizes for compat machines

2020-03-31 Thread Igor Mammedov
On Tue, 31 Mar 2020 11:35:54 -0400 Christian Borntraeger wrote: > compat machines did fixup the ram size to match what can be reported via > sclp. We need to mimic those for machines 4.2 and older to not fail on > inbound migration. not entirely correct, migration wouldn't fail if target was

[ANNOUNCE] QEMU 5.0.0-rc1 is now available

2020-03-31 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 5.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.0.0-rc1.tar.xz

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

2020-03-31 Thread Philippe Mathieu-Daudé
Cc'ing Avocado team On 3/31/20 6:18 PM, Richard Henderson wrote: On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote: This test was written/tested around beginning of 2019, but was extracted from a bigger series and posted end of June 2019 [*]. Unfortunately I did not notice commit 162abf1a8 was

Re: [PATCH v3] configure: warn if not using a separate build directory

2020-03-31 Thread Philippe Mathieu-Daudé
On 3/31/20 8:28 PM, Markus Armbruster wrote: Eric Blake writes: On 3/31/20 12:16 PM, Daniel P. Berrangé wrote: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a

Re: [PATCH 5/6] acpi: serial: don't use _STA method

2020-03-31 Thread Igor Mammedov
On Tue, 31 Mar 2020 17:23:42 +0200 Gerd Hoffmann wrote: > > > -static Aml *build_com_device_aml(uint8_t uid) > > > +static void build_com_device_aml(Aml *scope, uint8_t uid) > > > { > > > Aml *dev; > > > Aml *crs; > > > -Aml *method; > > > -Aml *if_ctx; > > > -Aml

Re: [PATCH] hw/vfio: let readonly flag take effect for mmaped regions

2020-03-31 Thread Alex Williamson
On Mon, 30 Mar 2020 21:59:41 -0400 Yan Zhao wrote: > On Mon, Mar 30, 2020 at 10:59:23PM +0800, Alex Williamson wrote: > > On Mon, 30 Mar 2020 02:34:02 -0400 > > Yan Zhao wrote: > > > > > On Mon, Mar 30, 2020 at 09:35:27AM +0800, Yan Zhao wrote: > > > > On Sat, Mar 28, 2020 at 01:25:37AM

Re: [PATCH v3 0/3] Fix some AIO context locking in jobs

2020-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200331122045.164356-1-s.rei...@proxmox.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v17 Kernel 6/7] vfio iommu: Adds flag to indicate dirty pages tracking capability support

2020-03-31 Thread Alex Williamson
On Wed, 1 Apr 2020 00:38:49 +0530 Kirti Wankhede wrote: > On 3/31/2020 2:28 AM, Alex Williamson wrote: > > On Mon, 30 Mar 2020 22:20:43 +0530 > > Kirti Wankhede wrote: > > > >> Flag VFIO_IOMMU_INFO_DIRTY_PGS in VFIO_IOMMU_GET_INFO indicates that driver > >> support dirty pages tracking. > >>

Re: [PATCH v17 Kernel 6/7] vfio iommu: Adds flag to indicate dirty pages tracking capability support

2020-03-31 Thread Kirti Wankhede
On 3/31/2020 2:28 AM, Alex Williamson wrote: On Mon, 30 Mar 2020 22:20:43 +0530 Kirti Wankhede wrote: Flag VFIO_IOMMU_INFO_DIRTY_PGS in VFIO_IOMMU_GET_INFO indicates that driver support dirty pages tracking. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia ---

Re: [PATCH v17 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-03-31 Thread Alex Williamson
On Wed, 1 Apr 2020 00:16:13 +0530 Kirti Wankhede wrote: > On 3/31/2020 3:04 AM, Alex Williamson wrote: > > On Mon, 30 Mar 2020 22:20:42 +0530 > > Kirti Wankhede wrote: > > > >> DMA mapped pages, including those pinned by mdev vendor drivers, might > >> get unpinned and unmapped while

Re: [PATCH v3 0/3] Fix some AIO context locking in jobs

2020-03-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200331122045.164356-1-s.rei...@proxmox.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-03-31 Thread Richard Henderson
On 3/31/20 8:33 AM, Jonathan Cameron wrote: > Just wondering if there are any known issues with this? Nope. It works for me. Can you give us any more details. r~

Re: [PATCH v14 4/4] iotests: 287: add qcow2 compression type test

2020-03-31 Thread Eric Blake
On 3/31/20 1:43 PM, Eric Blake wrote: Is it also worth trying to generate an image with (pseudo-)random contents, and trying qemu-img convert to prove that uncompressable clusters are handled sanely?  Ideally, there would be a way to use a fixed PRNG and seed that produces a deterministic

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 10:01, Markus Armbruster wrote: > I doubt including basic spatch instructions with every script is a good > idea. Better explain it in one place, with proper maintenance. > scripts/coccinelle/README? We could be a bit more verbose there, > e.g. to clarify required vs.

Re: [PATCH v17 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-03-31 Thread Kirti Wankhede
On 3/31/2020 3:04 AM, Alex Williamson wrote: On Mon, 30 Mar 2020 22:20:42 +0530 Kirti Wankhede wrote: DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while

Re: [PATCH v14 4/4] iotests: 287: add qcow2 compression type test

2020-03-31 Thread Eric Blake
On 3/31/20 12:44 PM, Denis Plotnikov wrote: The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128

Re: [PATCH v2 0/6] dwc-hsotg (aka dwc2) USB host controller emulation

2020-03-31 Thread Paul Zimmerman
On Tue, Mar 31, 2020 at 4:16 AM Philippe Mathieu-Daudé wrote: > On 3/31/20 11:28 AM, Gerd Hoffmann wrote: > > On Sat, Mar 28, 2020 at 05:16:59PM -0700, Paul Zimmerman wrote: > >> This patch series adds emulation for the dwc-hsotg USB controller, > >> which is used on the Raspberry Pi 3 and

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 31.03.2020 16:14, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 31.03.2020 12:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Add script to find and fix trivial use-after-free of Error objects.

Re: [PATCH v16 QEMU 00/16] Add migration support for VFIO devices

2020-03-31 Thread Alex Williamson
On Wed, 25 Mar 2020 02:38:58 +0530 Kirti Wankhede wrote: > Hi, > > This Patch set adds migration support for VFIO devices in QEMU. Hi Kirti, Do you have any migration data you can share to show that this solution is viable and useful? I was chatting with Dave Gilbert and there still seems to

Re: [PATCH v14 3/4] qcow2: add zstd cluster compression

2020-03-31 Thread Eric Blake
On 3/31/20 12:44 PM, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available.

Re: [PATCH v3] configure: warn if not using a separate build directory

2020-03-31 Thread Markus Armbruster
Eric Blake writes: > On 3/31/20 12:16 PM, Daniel P. Berrangé wrote: >> Running configure directly from the source directory is a build >> configuration that will go away in future. It is also not currently >> covered by any automated testing. Display a deprecation warning if >> the user attempts

Re: [PATCH v14 1/4] qcow2: introduce compression type feature

2020-03-31 Thread Eric Blake
On 3/31/20 12:44 PM, Denis Plotnikov wrote: The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be

[PATCH v14 1/4] qcow2: introduce compression type feature

2020-03-31 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus

[PATCH v14 3/4] qcow2: add zstd cluster compression

2020-03-31 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and

[PATCH v14 4/4] iotests: 287: add qcow2 compression type test

2020-03-31 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

[PATCH v14 2/4] qcow2: rework the cluster compression routine

2020-03-31 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71

[PATCH v14 0/4] qcow2: Implement zstd cluster compression method

2020-03-31 Thread Denis Plotnikov
v14: * fix bug on compression - looping until compress == 0 [Me] * apply reworked Vladimir's suggestions: 1. not mixing ssize_t with size_t 2. safe check for ENOMEM in compression part - avoid overflow 3. tolerate sanity check allow zstd to make progress only on

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 19:23 hat John Snow geschrieben: > > > On 3/31/20 6:21 AM, Max Reitz wrote: > > On 31.03.20 02:00, John Snow wrote: > >> Minor cleanup for HMP functions; helps with line length and consolidates > >> HMP helpers through one implementation function. > >> > >> Although we are

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
David I'm using master 17083d6d1e Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging - Cheers Julio From: Dr. David Alan Gilbert Sent: Tuesday, March 31, 2020 11:26 AM To: Montes, Julio Cc: Paolo Bonzini ; Vitaly Kuznetsov ;

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-03-31 Thread Jonathan Cameron
On Tue, 31 Mar 2020 16:33:24 +0100 Jonathan Cameron wrote: > On Fri, 7 Feb 2020 11:52:46 + > Peter Maydell wrote: > > > On Thu, 6 Feb 2020 at 10:54, Richard Henderson > > wrote: > > > > > > Version 7 has one more tweak to the vhe tlb flushing > > > that Peter asked for. All patches

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Dr. David Alan Gilbert
* Montes, Julio (julio.mon...@intel.com) wrote: > Sorry for my last email, it was incomplete > > Hi Vitaly > > thanks for raising this, unfortunately this patch didn't work for me, I still > get the same error: Are you trying that on top of 5.0 or ontop of the older 4.2 world? >

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread John Snow
On 3/31/20 6:21 AM, Max Reitz wrote: > On 31.03.20 02:00, John Snow wrote: >> Minor cleanup for HMP functions; helps with line length and consolidates >> HMP helpers through one implementation function. >> >> Although we are adding a universal toggle to turn QMP logging on or off, >> many

Re: [kvm-unit-tests PATCH v3] s390x: Add stsi 3.2.2 tests

2020-03-31 Thread David Hildenbrand
On 31.03.20 11:35, Cornelia Huck wrote: > On Tue, 31 Mar 2020 03:14:56 -0400 > Janosch Frank wrote: > >> Subcode 3.2.2 is handled by KVM/QEMU and should therefore be tested >> a bit more thorough. > > s/thorough/thoroughly/ ? I fixed that up for now. [...] >> +if

Re: [PATCH v3] configure: warn if not using a separate build directory

2020-03-31 Thread Eric Blake
On 3/31/20 12:16 PM, Daniel P. Berrangé wrote: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup,

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit
> On Mar 31, 2020, at 7:09 AM, David Hildenbrand wrote: > > On 31.03.20 16:07, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 04:03:18PM +0200, David Hildenbrand wrote: >>> On 31.03.20 15:37, Michael S. Tsirkin wrote: On Tue, Mar 31, 2020 at 03:32:05PM +0200, David Hildenbrand wrote:

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Nadav Amit
> On Mar 31, 2020, at 6:32 AM, David Hildenbrand wrote: > > On 31.03.20 15:24, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2020 at 12:35:24PM +0200, David Hildenbrand wrote: >>> On 26.03.20 10:49, Michael S. Tsirkin wrote: On Thu, Mar 26, 2020 at 08:54:04AM +0100, David Hildenbrand wrote:

[PATCH v3] configure: warn if not using a separate build directory

2020-03-31 Thread Daniel P . Berrangé
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building

Re: [PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Eric Blake
On 3/31/20 11:16 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to

Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 18:02, Philippe Mathieu-Daudé wrote > What about this memory_region_init_rom() call (and later > memory_region_init_ram) using error_fatal, same reasoning right? Yes. -- PMM

Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-31 Thread Philippe Mathieu-Daudé
On 3/26/20 10:55 PM, Peter Maydell wrote: On Wed, 25 Mar 2020 at 19:19, Philippe Mathieu-Daudé wrote: Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
Sorry for my last email, it was incomplete Hi Vitaly thanks for raising this, unfortunately this patch didn't work for me, I still get the same error: qemu-system-x86_64: error: failed to set MSR 0x48b to 0x1582e qemu-system-x86_64:

Re: [PULL 00/10] virtio, pci, pc: bugfixes, checkpatch, maintainers

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 15:57, Michael S. Tsirkin wrote: > > The following changes since commit 5acad5bf480321f178866dc28e38eeda5a3f19bb: > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into > staging (2020-03-28 00:27:04 +) > > are available in the Git repository

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Montes, Julio
Hi Vitaly thanks for raising this, unfortunately this patch didn't work for me, I still get the same error: my qemu command line: From: Qemu-devel on behalf of Paolo Bonzini Sent: Tuesday, March 31, 2020 10:32 AM To: Vitaly Kuznetsov ; qemu-devel@nongnu.org

Re: Question on dirty sync before kvm memslot removal

2020-03-31 Thread Peter Xu
On Tue, Mar 31, 2020 at 05:34:43PM +0200, Paolo Bonzini wrote: > On 31/03/20 17:23, Peter Xu wrote: > >> Or KVM_MEM_READONLY. > > Yeah, I used a new flag because I thought READONLY was a bit tricky to > > be used directly here. The thing is IIUC if guest writes to a > > READONLY slot then KVM

Re: [PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Paolo Bonzini
On 31/03/20 18:27, Vitaly Kuznetsov wrote: > Commit 048c95163b4 ("target/i386: work around KVM_GET_MSRS bug for > secondary execution controls") added a workaround for KVM pre-dating > commit 6defc591846d ("KVM: nVMX: include conditional controls in /dev/kvm > KVM_GET_MSRS") which wasn't setting

Re: [PATCH v1] vl/s390: fixup ram sizes for compat machines

2020-03-31 Thread Cornelia Huck
On Tue, 31 Mar 2020 11:35:54 -0400 Christian Borntraeger wrote: > compat machines did fixup the ram size to match what can be reported via s/compat machines/Older QEMU versions/ ? > sclp. We need to mimic those for machines 4.2 and older to not fail on "We need to mimic this behavior for

[PATCH] target/i386: do not set unsupported VMX secondary execution controls

2020-03-31 Thread Vitaly Kuznetsov
Commit 048c95163b4 ("target/i386: work around KVM_GET_MSRS bug for secondary execution controls") added a workaround for KVM pre-dating commit 6defc591846d ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS") which wasn't setting certain available controls. The workaround uses

Re: [PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Daniel P . Berrangé
On Tue, Mar 31, 2020 at 05:12:35PM +0100, Peter Maydell wrote: > On Tue, 31 Mar 2020 at 17:05, Eric Blake wrote: > > > > On 3/31/20 10:51 AM, Daniel P. Berrangé wrote: > > > +if test "$in_srcdir" = "yes"; then > > > +echo > > > +echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS

Re: [PATCH-for-5.0 1/7] tests/acceptance/machine_sparc_leon3: Disable HelenOS test

2020-03-31 Thread Richard Henderson
On 3/31/20 3:50 AM, Philippe Mathieu-Daudé wrote: > This test was written/tested around beginning of 2019, but was > extracted from a bigger series and posted end of June 2019 [*]. > Unfortunately I did not notice commit 162abf1a8 was merged by > then, which implements the AHB and APB plug and

Re: bdrv_drained_begin deadlock with io-threads

2020-03-31 Thread Dietmar Maurer
> On March 31, 2020 5:37 PM Kevin Wolf wrote: > > > Am 31.03.2020 um 17:24 hat Dietmar Maurer geschrieben: > > > > > > How can I see/debug those waiting request? > > > > > > Examine bs->tracked_requests list. > > > > > > BdrvTrackedRequest has "Coroutine *co" field. It's a pointer of

Re: [PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Markus Armbruster
Daniel P. Berrangé writes: > Running configure directly from the source directory is a build > configuration that will go away in future. It is also not currently > covered by any automated testing. Display a deprecation warning if > the user attempts to use an in-srcdir build setup, so that

Question about scsi device hotplug (e.g scsi-hd)

2020-03-31 Thread Maxim Levitsky
Hi! I recently investigated an interesting issue related to repeated scsi-hd hotplug/hotunplug. The bugzilla for it is here: https://bugzilla.redhat.com/show_bug.cgi?id=1812399 In nutshell the issue that I think that I found and I would like to ask your opinion on it, since I don't have enough

Re: [PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 17:05, Eric Blake wrote: > > On 3/31/20 10:51 AM, Daniel P. Berrangé wrote: > > +if test "$in_srcdir" = "yes"; then > > +echo > > +echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" > > +echo > > +echo "Support for running the 'configure' script

Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev

2020-03-31 Thread Cornelia Huck
On Tue, 31 Mar 2020 18:05:08 +0200 Markus Armbruster wrote: > Christian Schoenebeck writes: > > > On Dienstag, 31. März 2020 17:27:27 CEST Cornelia Huck wrote: > >> > diff --git a/qemu-options.hx b/qemu-options.hx > >> > index 962a5ebaa6..fd3830c6cd 100644 > >> > --- a/qemu-options.hx > >> >

Re: [PATCH] target/arm: Remove obsolete TODO note from get_phys_addr_lpae()

2020-03-31 Thread Richard Henderson
On 3/31/20 7:34 AM, Peter Maydell wrote: > An old comment in get_phys_addr_lpae() claims that the code does not > support the different format TCR for VTCR_EL2. This used to be true > but it is not true now (in particular the aa64_va_parameters() and > aa32_va_parameters() functions correctly

Re: [PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Eric Blake
On 3/31/20 10:51 AM, Daniel P. Berrangé wrote: Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup,

Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev

2020-03-31 Thread Markus Armbruster
Christian Schoenebeck writes: > On Dienstag, 31. März 2020 17:27:27 CEST Cornelia Huck wrote: >> > diff --git a/qemu-options.hx b/qemu-options.hx >> > index 962a5ebaa6..fd3830c6cd 100644 >> > --- a/qemu-options.hx >> > +++ b/qemu-options.hx >> > @@ -1542,9 +1542,17 @@ SRST >> > >> > ``-virtfs

Re: deprecation of in-tree builds

2020-03-31 Thread BALATON Zoltan
On Tue, 31 Mar 2020, Daniel P. Berrangé wrote: On Tue, Mar 31, 2020 at 05:04:16PM +0200, BALATON Zoltan wrote: OK, so then only supporting out-of-tree builds but adding convenience function and Makefile to still allow people to run configure; make from source dir would solve this without also

[PATCH v2] configure: warn if not using a separate build directory

2020-03-31 Thread Daniel P . Berrangé
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building

Re: [PATCH] configure: warn if not using a separate build directory

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 16:56 hat Daniel P. Berrangé geschrieben: > On Tue, Mar 31, 2020 at 09:44:37AM -0500, Eric Blake wrote: > > On 3/31/20 5:37 AM, Daniel P. Berrangé wrote: > > > Running configure directly from the source directory is a build > > > configuration that will go away in future. It is

Re: deprecation of in-tree builds

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 17:20 hat BALATON Zoltan geschrieben: > On Tue, 31 Mar 2020, Eric Blake wrote: > > On 3/31/20 7:02 AM, Kevin Wolf wrote: > > > Am 31.03.2020 um 09:48 hat Paolo Bonzini geschrieben: > > > > On 30/03/20 16:37, Kevin Wolf wrote: > > > > > If manually dealing with separate build

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Christian Borntraeger
On 31.03.20 17:39, David Hildenbrand wrote: > On 31.03.20 17:33, Igor Mammedov wrote: >> On Tue, 31 Mar 2020 13:17:38 +0200 >> Christian Borntraeger wrote: >> >>> On 27.03.20 23:13, Igor Mammedov wrote: On Fri, 27 Mar 2020 17:53:39 +0100 David Hildenbrand wrote: > On

Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev

2020-03-31 Thread Christian Schoenebeck
On Dienstag, 31. März 2020 17:27:27 CEST Cornelia Huck wrote: > > diff --git a/qemu-options.hx b/qemu-options.hx > > index 962a5ebaa6..fd3830c6cd 100644 > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > @@ -1542,9 +1542,17 @@ SRST > > > > ``-virtfs proxy,sock_fd=sock_fd,mount_tag=mount_tag

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Christian Borntraeger
On 31.03.20 17:33, Igor Mammedov wrote: > On Tue, 31 Mar 2020 13:17:38 +0200 > Christian Borntraeger wrote: > >> On 27.03.20 23:13, Igor Mammedov wrote: >>> On Fri, 27 Mar 2020 17:53:39 +0100 >>> David Hildenbrand wrote: >>> On 27.03.20 17:46, Igor Mammedov wrote: > On Fri, 27

Re: bdrv_drained_begin deadlock with io-threads

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 17:24 hat Dietmar Maurer geschrieben: > > > > How can I see/debug those waiting request? > > > > Examine bs->tracked_requests list. > > > > BdrvTrackedRequest has "Coroutine *co" field. It's a pointer of coroutine > > of this request. You may use qemu-gdb script to print

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread David Hildenbrand
On 31.03.20 17:33, Igor Mammedov wrote: > On Tue, 31 Mar 2020 13:17:38 +0200 > Christian Borntraeger wrote: > >> On 27.03.20 23:13, Igor Mammedov wrote: >>> On Fri, 27 Mar 2020 17:53:39 +0100 >>> David Hildenbrand wrote: >>> On 27.03.20 17:46, Igor Mammedov wrote: > On Fri, 27 Mar

[PATCH v1] vl/s390: fixup ram sizes for compat machines

2020-03-31 Thread Christian Borntraeger
compat machines did fixup the ram size to match what can be reported via sclp. We need to mimic those for machines 4.2 and older to not fail on inbound migration. For Machines >= 5.0 we can simply use an increment size of 1M und use the full range of increment number which allows for all possible

Re: [PATCH v1] s390x: Reject unaligned RAM sizes

2020-03-31 Thread Igor Mammedov
On Tue, 31 Mar 2020 13:17:38 +0200 Christian Borntraeger wrote: > On 27.03.20 23:13, Igor Mammedov wrote: > > On Fri, 27 Mar 2020 17:53:39 +0100 > > David Hildenbrand wrote: > > > >> On 27.03.20 17:46, Igor Mammedov wrote: > >>> On Fri, 27 Mar 2020 17:05:34 +0100 > >>> Christian

Re: Question on dirty sync before kvm memslot removal

2020-03-31 Thread Paolo Bonzini
On 31/03/20 17:23, Peter Xu wrote: >> Or KVM_MEM_READONLY. > Yeah, I used a new flag because I thought READONLY was a bit tricky to > be used directly here. The thing is IIUC if guest writes to a > READONLY slot then KVM should either ignore the write or trigger an > error which I didn't check,

Re: [PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-03-31 Thread Jonathan Cameron
On Fri, 7 Feb 2020 11:52:46 + Peter Maydell wrote: > On Thu, 6 Feb 2020 at 10:54, Richard Henderson > wrote: > > > > Version 7 has one more tweak to the vhe tlb flushing > > that Peter asked for. All patches have reviews. > > > > > > > > Applied to target-arm.next, thanks. Hi Peter /

Re: [PATCH 1/3] crypto: Add qcrypto_tls_shutdown()

2020-03-31 Thread Daniel P . Berrangé
On Tue, Mar 31, 2020 at 10:17:49AM -0500, Eric Blake wrote: > On 3/31/20 3:30 AM, Markus Armbruster wrote: > > Eric Blake writes: > > > > > Gnutls documents that applications that want to distinguish between a > > > clean end-of-communication and a malicious client abruptly tearing the > > >

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-31 Thread Michael S. Tsirkin
On Tue, Mar 31, 2020 at 04:34:48PM +0200, David Hildenbrand wrote: > On 31.03.20 16:29, David Hildenbrand wrote: > > On 31.03.20 16:18, Michael S. Tsirkin wrote: > >> On Tue, Mar 31, 2020 at 04:09:59PM +0200, David Hildenbrand wrote: > >> > >> ... > >> > >> So if we want to address

Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev

2020-03-31 Thread Cornelia Huck
On Tue, 31 Mar 2020 15:23:38 +0200 Christian Schoenebeck wrote: > The docs are ambiguous about the difference (or actually their > equality) between options '-virtfs' vs. '-fsdev'. So clarify that > '-virtfs' is actually just a convenience shortcut for its > generalized form '-fsdev' in

Re: bdrv_drained_begin deadlock with io-threads

2020-03-31 Thread Dietmar Maurer
> > How can I see/debug those waiting request? > > Examine bs->tracked_requests list. > > BdrvTrackedRequest has "Coroutine *co" field. It's a pointer of coroutine of > this request. You may use qemu-gdb script to print request's coroutine > back-trace: I would, but there are no tracked

Re: deprecation of in-tree builds

2020-03-31 Thread Daniel P . Berrangé
On Tue, Mar 31, 2020 at 05:04:16PM +0200, BALATON Zoltan wrote: > On Tue, 31 Mar 2020, Daniel P. Berrangé wrote: > > On Tue, Mar 31, 2020 at 02:33:46PM +0200, BALATON Zoltan wrote: > > > > We will have to ask developers to change habits anyway when we switch to > > > > Meson. I agree with

Re: [PATCH 5/6] acpi: serial: don't use _STA method

2020-03-31 Thread Gerd Hoffmann
> > -static Aml *build_com_device_aml(uint8_t uid) > > +static void build_com_device_aml(Aml *scope, uint8_t uid) > > { > > Aml *dev; > > Aml *crs; > > -Aml *method; > > -Aml *if_ctx; > > -Aml *else_ctx; > > -Aml *zero = aml_int(0); > > -Aml *is_present =

Re: [PATCH] serial: Fix double migration data

2020-03-31 Thread Paolo Bonzini
On 30/03/20 19:56, Marc-André Lureau wrote: >>> Why do you make it a sub-state? >> Because it's consistent with serial-isa and it's simple. > ok, lgtm then > > Reviewed-by: Marc-André Lureau Queued, thanks. Paolo

Re: Question on dirty sync before kvm memslot removal

2020-03-31 Thread Peter Xu
On Mon, Mar 30, 2020 at 03:11:53PM +0200, Paolo Bonzini wrote: > On 27/03/20 16:04, Peter Xu wrote: > > That makes perfect sense to me, however... What if the vcpu generates > > dirty bits _after_ we do KVM_GET_DIRTY_LOG but _before_ we send > > KVM_SET_USER_MEMORY_REGION to remove the memslot?

Re: deprecation of in-tree builds

2020-03-31 Thread Liviu Ionescu
> On 31 Mar 2020, at 15:07, Kevin Wolf wrote: > > Thanks for declaring my workflow irrelevant, I guess... Sorry if this happened, it was not intended. The intention was to point out that there are also other use cases of running the QEMU builds, different from those specific to building

Re: deprecation of in-tree builds

2020-03-31 Thread BALATON Zoltan
On Tue, 31 Mar 2020, Eric Blake wrote: On 3/31/20 7:02 AM, Kevin Wolf wrote: Am 31.03.2020 um 09:48 hat Paolo Bonzini geschrieben: On 30/03/20 16:37, Kevin Wolf wrote: If manually dealing with separate build directories is inconvenient today, it will still be inconvenient with Meson, so this

Re: [PATCH 1/3] crypto: Add qcrypto_tls_shutdown()

2020-03-31 Thread Eric Blake
On 3/31/20 3:30 AM, Markus Armbruster wrote: Eric Blake writes: Gnutls documents that applications that want to distinguish between a clean end-of-communication and a malicious client abruptly tearing the underlying transport out of under our feet need to use gnutls_bye(). Our channel code is

Re: [PATCH v13 3/4] qcow2: add zstd cluster compression

2020-03-31 Thread Denis Plotnikov
On 31.03.2020 17:49, Vladimir Sementsov-Ogievskiy wrote: 31.03.2020 16:17, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment,

[Bug 1867786] Re: Qemu PPC64 freezes with multi-core CPU

2020-03-31 Thread carlosedp
Hi Laurent, confirm that after changing the network adapter to the e1000e it worked flawlessly for hours with 4 cores on Macbook Pro. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1867786

Re: [PATCH v5] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-31 Thread Eric Blake
On 3/31/20 6:43 AM, Alberto Garcia wrote: A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images

Re: deprecation of in-tree builds

2020-03-31 Thread Eric Blake
On 3/31/20 7:02 AM, Kevin Wolf wrote: Am 31.03.2020 um 09:48 hat Paolo Bonzini geschrieben: On 30/03/20 16:37, Kevin Wolf wrote: If manually dealing with separate build directories is inconvenient today, it will still be inconvenient with Meson, so this would mean introducing the automatic

Re: [PATCH v10 00/14] iotests: use python logging

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 02:00 hat John Snow geschrieben: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help

  1   2   3   4   >