[PULL 3/3] target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

2020-04-16 Thread David Gibson
From: Nicholas Piggin If mtmsr L=1 sets MSR[EE] while there is a maskable exception pending, it does not cause an interrupt. This causes the test case to hang: https://lists.gnu.org/archive/html/qemu-ppc/2019-10/msg00826.html More recently, Linux reduced the occurance of operations (e.g., rfi)

[PULL 1/3] linux-user/ppc: Fix padding in mcontext_t for ppc64

2020-04-16 Thread David Gibson
From: Richard Henderson The padding that was added in 95cda4c44ee was added to a union, and so it had no effect. This fixes misalignment errors detected by clang sanitizers for ppc64 and ppc64le. In addition, only ppc64 allocates space for VSX registers, so do not save them for ppc32. The

[PULL 2/3] target/ppc: Fix wrong interpretation of the disposition flag.

2020-04-16 Thread David Gibson
From: Ganesh Goudar Bitwise AND with kvm_run->flags to evaluate if we recovered from MCE or not is not correct, As disposition in kvm_run->flags is a two-bit integer value and not a bit map, So check for equality instead of bitwise AND. Without the fix qemu treats any unrecoverable mce error as

[PULL 0/3] ppc-for-5.0 queue 20200417

2020-04-16 Thread David Gibson
The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.0-20200417 for you to fetch changes up to

[PATCH qemu] spapr: Add PVR setting capability

2020-04-16 Thread Alexey Kardashevskiy
At the moment the VCPU init sequence includes setting PVR which in case of KVM-HV only checks if it matches the hardware PVR mask as PVR cannot be virtualized by the hardware. In order to cope with various CPU revisions only top 16bit of PVR are checked which works for minor revision updates.

Re: [PATCH 4/4] vhost-user-blk: fix crash in realize process

2020-04-16 Thread Raphael Norwitz
Mostly looks good - just a few superficial notes. On Wed, Apr 15, 2020 at 11:28:26AM +0800, Li Feng wrote: > 1. set s->connected to true after vhost_dev_init; > 2. call vhost_dev_get_config when s->connected is true, otherwise the > hdev->host_ops will be nullptr. You mean hdev->vhost_ops,

Re: [PATCH 2/4] vhost-user-blk: fix invalid memory access

2020-04-16 Thread Raphael Norwitz
On Wed, Apr 15, 2020 at 11:28:24AM +0800, Li Feng wrote: > > when s->inflight is freed, vhost_dev_free_inflight may try to access > s->inflight->addr, it will retrigger the following issue. > > ==7309==ERROR: AddressSanitizer: heap-use-after-free on address > 0x604001020d18 at pc 0x55ce948a

Re: [PATCH 1/4] vhost-user-blk: delay vhost_user_blk_disconnect

2020-04-16 Thread Raphael Norwitz
On Wed, Apr 15, 2020 at 11:28:23AM +0800, Li Feng wrote: > > switch (event) { > case CHR_EVENT_OPENED: > @@ -363,7 +376,16 @@ static void vhost_user_blk_event(void *opaque, > QEMUChrEvent event) > } > break; > case CHR_EVENT_CLOSED: > -

Re: [PATCH v3 0/7] s390x/vfio-ccw: Channel Path Handling [QEMU]

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200417023440.70514-1-far...@linux.ibm.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [edk2-discuss] Load Option passing. Either bugs or my confusion.

2020-04-16 Thread Hou Qiming
I'm glad we can reach a consensus that ramfb needs sanity checks. And well, I'm probably at fault with the hijacking. Your QEMU/TCG in QEMU/TCG example also made me realize a deeper problem, though: your setting still can't escape the host display / physical GPU issue. The middle display layers

[PATCH v3 0/7] s390x/vfio-ccw: Channel Path Handling [QEMU]

2020-04-16 Thread Eric Farman
Here is a new pass at the channel-path handling code for vfio-ccw, to take advantage of the corresponding kernel patches posted here: https://lore.kernel.org/kvm/20200417023001.65006-1-far...@linux.ibm.com/ Per the discussion in v2, I dropped the EIO-to-CC3 patch from the head of the series. I

[PATCH v3 1/7] linux-headers: update

2020-04-16 Thread Eric Farman
From: Farhan Ali Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v2->v3: [EF] - Re-ran 16 April 2020 (based on kernel tag v5.6, and limited to bits interesting to this series) v1->v2: [EF] - Re-ran 3 February 2020 (based on kernel tag v5.5)

[PATCH v3 3/7] vfio-ccw: Add support for the schib region

2020-04-16 Thread Eric Farman
From: Farhan Ali The schib region can be used to obtain the latest SCHIB from the host passthrough subchannel. Since the guest SCHIB is virtualized, we currently only update the path related information so that the guest is aware of any path related changes when it issues the 'stsch'

[PATCH v3 6/7] s390x/css: Refactor the css_queue_crw() routine

2020-04-16 Thread Eric Farman
We have a use case (vfio-ccw) where a CRW is already built and ready to use. Rather than teasing out the components just to reassemble it later, let's rework this code so we can queue a fully-qualified CRW directly. Signed-off-by: Eric Farman --- hw/s390x/css.c | 44

[PATCH v3 4/7] vfio-ccw: Add support for the crw region

2020-04-16 Thread Eric Farman
From: Farhan Ali The crw region can be used to obtain information about Channel Report Words (CRW) from vfio-ccw driver. Currently only channel path related CRWs are passed to QEMU from vfio-ccw driver. Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v0->v1: [EF] -

[PATCH v3 5/7] vfio-ccw: Refactor ccw irq handler

2020-04-16 Thread Eric Farman
Make it easier to add new ones in the future. Signed-off-by: Eric Farman Reviewed-by: Cornelia Huck --- Notes: v2->v3: - Added Conny's r-b v1->v2: - Make irq parameter unsigned [CH] - Remove extraneous %m from error_report calls [CH] hw/vfio/ccw.c | 58

[PATCH v3 7/7] vfio-ccw: Add support for the CRW irq

2020-04-16 Thread Eric Farman
From: Farhan Ali The CRW irq will be used by vfio-ccw to notify the userspace about any CRWs the userspace needs to handle. Let's add support for it. Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v2->v3: - Remove "size==0" check in CRW notifier [CH] - Remove

[PATCH v3 2/7] vfio-ccw: Refactor cleanup of regions

2020-04-16 Thread Eric Farman
While we're at it, add a g_free() for the async_cmd_region that is the last thing currently created. g_free() knows how to handle NULL pointers, so this makes it easier to remember what cleanups need to be performed when new regions are added. Signed-off-by: Eric Farman Reviewed-by: Cornelia

Re: [PATCH] target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

2020-04-16 Thread David Gibson
On Tue, Apr 14, 2020 at 09:11:31PM +1000, Nicholas Piggin wrote: 65;5803;1c> If mtmsr L=1 sets MSR[EE] while there is a maskable exception pending, > it does not cause an interrupt. This causes the test case to hang: > > https://lists.gnu.org/archive/html/qemu-ppc/2019-10/msg00826.html > > More

Re: [PATCH] qcow2: Expose bitmaps' size during measure

2020-04-16 Thread Eric Blake
On 4/16/20 5:49 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200416212349.731404-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can

[PATCH v4 3/3] hw/vfio: let read-only flag take effect for mmap'd regions

2020-04-16 Thread Yan Zhao
along side setting host page table to be read-only, the memory regions are also required to be read-only, so that when guest writes to the read-only & mmap'd regions, vmexits would happen and region write handlers are called. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yan Zhao

[PATCH v4 2/3] hw/vfio: drop guest writes to ro regions

2020-04-16 Thread Yan Zhao
for vfio regions that are without write permission, drop guest writes to those regions. Cc: Philippe Mathieu-Daudé Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng --- hw/vfio/common.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c

[PATCH v4 0/3] drop writes to read-only ram device & vfio regions

2020-04-16 Thread Yan Zhao
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patch 1 modifies handler of ram device memory regions to drop guest writes to read-only ram device memory regions patch 2 modifies handler of non-mmap'd read-only vfio regions to drop guest writes to those

[PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-16 Thread Yan Zhao
for ram device regions, drop guest writes if the regions is read-only. Cc: Philippe Mathieu-Daudé Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng --- memory.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/memory.c b/memory.c index 601b749906..9576dd6807 100644 --- a/memory.c +++

Re: [PATCH] qcow2: Expose bitmaps' size during measure

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416212349.731404-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416203624.32366-1-mlevi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] qcow2: Expose bitmaps' size during measure

2020-04-16 Thread Eric Blake
On 4/16/20 4:23 PM, Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field. Reported-by: Nir Soffer Signed-off-by: Eric Blake --- Per

Re: [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416203624.32366-1-mlevi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416203624.32366-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread Message-id:

[PATCH] qcow2: Expose bitmaps' size during measure

2020-04-16 Thread Eric Blake
It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field. Reported-by: Nir Soffer Signed-off-by: Eric Blake --- This is independent from my 'qemu-img convert

Re: [PATCH v2 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts

2020-04-16 Thread Guenter Roeck
Hi Peter, On 4/16/20 8:29 AM, Peter Maydell wrote: > On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: >> >> i.MX7 supports watchdog pretimeout interupts. With this commit, >> the watchdog in mcimx7d-sabre is fully operational, including >> pretimeout support. >> >> Signed-off-by: Guenter Roeck

Re: [PATCH v20 QEMU 0/5] virtio-balloon: add support for free page reporting

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416195641.13144.16955.stgit@localhost.localdomain/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v20 QEMU 0/5] virtio-balloon: add support for free page reporting Message-id:

Re: m68k: gdbstub crashing setting float register on cfv4e cpu

2020-04-16 Thread Pierre Muller
Le 16/04/2020 à 22:09, Laurent Vivier a écrit : > Le 16/04/2020 à 22:03, Pierre Muller a écrit : >> Le 16/04/2020 à 13:18, Laurent Vivier a écrit : >>> Le 14/04/2020 à 18:56, Alex Bennée a écrit : Philippe Mathieu-Daudé writes: > gdbstub/m68k seems broken with floats,

[PATCH 3/4] device-core: use atomic_set on .realized property

2020-04-16 Thread Maxim Levitsky
Some code might race with placement of new devices on a bus. We currently first place a (unrealized) device on the bus and then realize it. As a workaround, users that scan the child device list, can check the realized property to see if it is safe to access such a device. Use an atomic write

[PATCH 4/4] virtio-scsi: don't touch scsi devices that are not yet realized

2020-04-16 Thread Maxim Levitsky
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1812399 Suggested-by: Paolo Bonzini Signed-off-by: Maxim Levitsky --- hw/scsi/virtio-scsi.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index

[PATCH 1/4] scsi/scsi_bus: switch search direction in scsi_device_find

2020-04-16 Thread Maxim Levitsky
This change will allow us to convert the bus children list to RCU, while not changing the logic of this function Signed-off-by: Maxim Levitsky --- hw/scsi/scsi-bus.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index

[PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-04-16 Thread Maxim Levitsky
Hi! This is a patch series that is a result of my discussion with Paulo on how to correctly fix the root cause of the BZ #1812399. The root cause of this bug is the fact that IO thread is running mostly unlocked versus main thread on which device hotplug is done. qdev_device_add first creates

[PATCH 2/4] device-core: use RCU for list of childs of a bus

2020-04-16 Thread Maxim Levitsky
This fixes the race between device emulation code that tries to find a child device to dispatch the request to (e.g a scsi disk), and hotplug of a new device to that bus. Note that this doesn't convert all the readers of the list but only these that might go over that list without BQL held. This

Re: [PATCH 0/2] virtiofsd: drop Linux capabilities(7)

2020-04-16 Thread Vivek Goyal
On Thu, Apr 16, 2020 at 05:49:05PM +0100, Stefan Hajnoczi wrote: > virtiofsd doesn't need of all Linux capabilities(7) available to root. Keep a > whitelisted set of capabilities that we require. This improves security in > case virtiofsd is compromised by making it hard for an attacker to gain

Re: m68k: gdbstub crashing setting float register on cfv4e cpu

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 22:03, Pierre Muller a écrit : > Le 16/04/2020 à 13:18, Laurent Vivier a écrit : >> Le 14/04/2020 à 18:56, Alex Bennée a écrit : >>> >>> Philippe Mathieu-Daudé writes: >>> gdbstub/m68k seems broken with floats, previous to refactor commit a010bdbe719 ("extend GByteArray

Re: m68k: gdbstub crashing setting float register on cfv4e cpu

2020-04-16 Thread Pierre Muller
Le 16/04/2020 à 13:18, Laurent Vivier a écrit : > Le 14/04/2020 à 18:56, Alex Bennée a écrit : >> >> Philippe Mathieu-Daudé writes: >> >>> gdbstub/m68k seems broken with floats, previous to refactor commit >>> a010bdbe719 ("extend GByteArray to read register helpers"). >>> >>> HEAD at 6fb1603aa2:

Re: [PATCH v4 17/30] qcow2: Add subcluster support to calculate_l2_meta()

2020-04-16 Thread Alberto Garcia
On Wed 15 Apr 2020 10:39:26 AM CEST, Vladimir Sementsov-Ogievskiy wrote: >> + * Returns 1 on success, -errno on failure (in order to match the >> + * return value of handle_copied() and handle_alloc()). > > Hmm, honestly, I don't like this idea. handle_copied and handle_alloc > has special return

[PATCH v20 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into

[Bug 1873344] [NEW] KVM Windows 98 sound card passthrough is not working for DOS programs..

2020-04-16 Thread ruthan
Public bug reported: Hello, im trying to passthrough PCI soundcards into Qemu Windows 98 machine - i tried Yamaha 724/744 and Aunreal Vortex 1, for Windows 98 its working fine, but for Windows 98 dosbox mode its at the best half - working - FM (music) only or nothing with detected by games

[PATCH v20 QEMU 4/5] linux-headers: update to contain virito-balloon free page reporting

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v20 QEMU 2/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with

[PATCH v20 QEMU 0/5] virtio-balloon: add support for free page reporting

2020-04-16 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly

[PATCH v20 QEMU 3/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. So if free page hinting is active we should add page poisoning support and let the guest disable it if it isn't using it. Page

[PATCH v20 QEMU 1/5] linux-headers: Update to allow renaming of free_page_report_cmd_id

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Sync to the latest upstream changes for free page hinting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[Bug 1873341] [NEW] Qemu Win98 VM with KVM videocard passthrough DOS mode video is not working for most of games..

2020-04-16 Thread ruthan
Public bug reported: Hello, im using Win98 machine with KVM videocards passthrough which is working fine, but when i try Windows 98 - Dosbox mode, there is something work with all videocards which i tried PCI-E/PCI - Nvidia, 3Dfx, Matrox. Often is framerate is very slow, as slideshow: Doom 2,

[Bug 1873340] [NEW] KVM Old ATI(pre) AMD card passthrough is not working

2020-04-16 Thread ruthan
Public bug reported: Hello, tried to passthroug old ATI pre AMD PCI / PCI-E cards, on machine where anything else is working - Nvidia /Matrox / 3dfx cards.. Here are results: ATI Mach 64 PCI - videocard - machine start segfault ATI Rage XL PCI - videocard - machine start segfault ATI Radeon

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Paul Zimmerman
On 4/16/20 9:30 AM, Philippe Mathieu-Daudé wrote: On 4/16/20 5:47 PM, Peter Maydell wrote: On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: +    s->as = _space_memory; Ideally this should be a device property. (hw/dma/pl080.c has an

[Bug 1873338] [NEW] Dos on the fly CD image replacement is not Working with DOS

2020-04-16 Thread ruthan
Public bug reported: Im not able to exchange CD image on the fly (needed for some games). I messed with command like - in console(ATL+CRTL+2) eject ide1-cd0 and change ide-cd0 D:/Games/!Emulators/Dos-QEMU/ISOs/TestChangeISO.iso , but system so never able to find new CD data.. simply drive so

[Bug 1873337] [NEW] Arrow keys press is double in some programs in Dos

2020-04-16 Thread ruthan
Public bug reported: Hello, im trying to use Qemu for Dos machines. But there is problem with some programs that arrow key press is double in some problems. As advanced Filemanagers - Dos Navigator or File Wizard, same Scandisk. There is gif:

[Bug 1873339] [NEW] Qemu DOS Quake - 640x480 and above resolutions - Unable to load VESA palette in dos prompt and game crashing are not working

2020-04-16 Thread ruthan
Public bug reported: I have problem make Quake Demo working with 640x480+, with 320x200 working fine. I tried 3 virtual videocards settings: -vga cirrus 640x480 is not available, probably emulated GPU has not enough VRAM or some Vesa2 utility is needed. For -vga std and -vga vmware // 640x480

[Bug 1873335] [NEW] Dos Keypad is not working for numbers - numlock is not working

2020-04-16 Thread ruthan
Public bug reported: Hello, i tried to use Qemu 4.2 for Dos, but there is problem what in Dos is not possible turn on Numlock for input numbers, so games need it.. Numlock only working as arrow keys.   I tested bough Windows and Linux builds. With same setting, when i use Windows 98 or later

[PATCH v1 PATCH v1 0/1] tests: machine-none-test: Enable MicroBlaze testing

2020-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This is to re-enable machine-none MicroBlaze testing. Cheers, Edgar Edgar E. Iglesias (1): tests: machine-none-test: Enable MicroBlaze testing tests/qtest/machine-none-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1

[PATCH v1 PATCH v1 1/1] tests: machine-none-test: Enable MicroBlaze testing

2020-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable MicroBlaze testing. Signed-off-by: Edgar E. Iglesias --- tests/qtest/machine-none-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/machine-none-test.c b/tests/qtest/machine-none-test.c index

Re: [PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Eric Blake
(adding Markus for a CLI question, look for [*]) On 4/16/20 1:20 PM, Nir Soffer wrote: On Thu, Apr 16, 2020 at 5:51 PM Eric Blake wrote: Without this series, the process for copying one qcow2 image to another including all of its bitmaps involves running qemu and doing the copying by hand

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 19:22, John Snow wrote: > My goal is to make virtual environments work out of the box. > > I.e., if you run ./configure from inside a VENV, it should "just work." Yeah, this seems reasonable to me. If I understand your patch correctly it ought to work without breaking the

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 21:08, Peter Maydell a écrit : > On Thu, 16 Apr 2020 at 18:16, Laurent Vivier wrote: >> >> Le 16/04/2020 à 18:03, Peter Maydell a écrit : >>> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: The following changes since commit

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 18:16, Laurent Vivier wrote: > > Le 16/04/2020 à 18:03, Peter Maydell a écrit : > > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: > >> > >> The following changes since commit > >> 20038cd7a8412feeb49c01f6ede89e36c8995472: > >> > >> Update version for v5.0.0-rc3

Re: [PATCH] 9pfs: local: ignore O_NOATIME if we don't have permissions

2020-04-16 Thread Omar Sandoval
On Thu, Apr 16, 2020 at 04:58:31PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. April 2020 02:44:33 CEST Omar Sandoval wrote: > > From: Omar Sandoval > > > > QEMU's local 9pfs server passes through O_NOATIME from the client. If > > the QEMU process doesn't have permissions to use

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
> The other thing to keep in mind is that the poison value only really > comes into play with hinting/reporting. In the case of the standard > balloon the pages are considered allocated from the guest's Currently just as free page hinting IMHO. They are temporarily considered allocated. >

Re: [PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Nir Soffer
On Thu, Apr 16, 2020 at 5:51 PM Eric Blake wrote: > > Without this series, the process for copying one qcow2 image to > another including all of its bitmaps involves running qemu and doing > the copying by hand with a series of QMP commands. This makes the > process a bit more convenient. This

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread John Snow
On 4/16/20 8:31 AM, Alex Bennée wrote: > > John Snow writes: > >> On 4/15/20 1:55 PM, Peter Maydell wrote: >>> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: sphinx-build is the name of the script entry point from the sphinx package itself. sphinx-build-3 is a pacakging

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
On Thu, Apr 16, 2020 at 7:55 AM David Hildenbrand wrote: > > >> We should document our result of page poisoning, free page hinting, and > >> free page reporting there as well. I hope you'll have time for the latter. > >> > >>

[PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output

2020-04-16 Thread Sergei Trofimovich
Fix syscall name and parameters priinter. Before the change: ``` $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a ... 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3 1274697 exit_group(0) ``` After the change: ``` $

Re: [PATCH 2/2] virtiofsd: drop all capabilities in the wait parent process

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 6:49 PM, Stefan Hajnoczi wrote: All this process does is wait for its child. No capabilities are needed. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c

[PATCH RFC v5] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Stephen Long
Signed-off-by: Stephen Long --- Made the fixes Richard noted. target/arm/helper-sve.h| 7 +++ target/arm/sve.decode | 6 +++ target/arm/sve_helper.c| 104 + target/arm/translate-sve.c | 29 +++ 4 files changed, 146 insertions(+)

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 18:03, Peter Maydell a écrit : > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: >> >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: >> >> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) >> >> are available in the Git

Re: [PATCH v2] nrf51: Fix last GPIO CNF address

2020-04-16 Thread Peter Maydell
On Wed, 15 Apr 2020 at 05:37, Cameron Esfahani wrote: > > NRF51_GPIO_REG_CNF_END doesn't actually refer to the start of the last > valid CNF register: it's referring to the last byte of the last valid > CNF register. > > This hasn't been a problem up to now, as current implementation in >

[PATCH 2/2] virtiofsd: drop all capabilities in the wait parent process

2020-04-16 Thread Stefan Hajnoczi
All this process does is wait for its child. No capabilities are needed. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index

[PATCH 1/2] virtiofsd: only retain file system capabilities

2020-04-16 Thread Stefan Hajnoczi
virtiofsd runs as root but only needs a subset of root's Linux capabilities(7). As a file server its purpose is to create and access files on behalf of a client. It needs to be able to access files with arbitrary uid/gid owners. It also needs to be create device nodes. Introduce a Linux

[PATCH 0/2] virtiofsd: drop Linux capabilities(7)

2020-04-16 Thread Stefan Hajnoczi
virtiofsd doesn't need of all Linux capabilities(7) available to root. Keep a whitelisted set of capabilities that we require. This improves security in case virtiofsd is compromised by making it hard for an attacker to gain further access to the system. Stefan Hajnoczi (2): virtiofsd: only

Re: [PATCH v2] aspeed: Add boot stub for smp booting

2020-04-16 Thread Peter Maydell
On Thu, 9 Apr 2020 at 07:31, Joel Stanley wrote: > > This is a boot stub that is similar to the code u-boot runs, allowing > the kernel to boot the secondary CPU. > +static void aspeed_write_smpboot(ARMCPU *cpu, > + const struct arm_boot_info *info) > +{ > +

Re: [PATCH v1 0/2] dma/xlnx-zdma: Fix descriptor loading wrt host endianness

2020-04-16 Thread Peter Maydell
On Sat, 4 Apr 2020 at 13:26, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Hi, > > This fixes the endinannes related bugs with descriptor loading > that Peter pointed out. > > Cheers, > Edgar > > Edgar E. Iglesias (2): > dma/xlnx-zdma: Fix descriptor loading (MEM) wrt endianness >

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 5:47 PM, Peter Maydell wrote: On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: +s->as = _space_memory; Ideally this should be a device property. (hw/dma/pl080.c has an example of how to declare a TYPE_MEMORY_REGION

Re: [PATCH RFC v4] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Richard Henderson
On 4/16/20 7:42 AM, Stephen Long wrote: > +static inline uint8_t do_histseg_cnt(uint8_t n, uint64_t m0, uint64_t m1) > +{ > +int esz = 0; Clearer to use MO_8. > +int bits = 8 << esz; > +uint64_t ones = dup_const(esz, 1); > +uint64_t signs = ones << (bits - 1); > +uint64_t

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: > > The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: > > Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: > > On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: > > +s->as = _space_memory; > > Ideally this should be a device property. (hw/dma/pl080.c > has an example of how to declare a TYPE_MEMORY_REGION > property and then create an

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Peter Maydell
On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: > > Add the dwc-hsotg (dwc2) USB host controller emulation code. > Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. > > Note that to use this with the dwc-otg driver in the Raspbian > kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0"

[PATCH 1/2] qom: Factor out user_creatable_add_dict()

2020-04-16 Thread Kevin Wolf
The QMP handler qmp_object_add() and the implementation of --object in qemu-storage-daemon can share most of the code. Currently, qemu-storage-daemon calls qmp_object_add(), but this is not correct because different visitors need to be used. As a first step towards a fix, make qmp_object_add() a

[PATCH 2/2] qemu-storage-daemon: Fix non-string --object properties

2020-04-16 Thread Kevin Wolf
After processing the option string with the keyval parser, we get a QDict that contains only strings. This QDict must be fed to a keyval visitor which converts the strings into the right data types. qmp_object_add(), however, uses the normal QObject input visitor, which expects a QDict where all

[PATCH 0/2] qemu-storage-daemon: Fix non-string --object properties

2020-04-16 Thread Kevin Wolf
Kevin Wolf (2): qom: Factor out user_creatable_add_dict() qemu-storage-daemon: Fix non-string --object properties include/qom/object_interfaces.h | 16 qemu-storage-daemon.c | 4 +--- qom/object_interfaces.c | 31 +++

Re: [PATCH v2 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > i.MX7 supports watchdog pretimeout interupts. With this commit, > the watchdog in mcimx7d-sabre is fully operational, including > pretimeout support. > > Signed-off-by: Guenter Roeck > diff --git a/include/hw/arm/fsl-imx7.h

[PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1()

2020-04-16 Thread Laurent Vivier
From: Sergei Trofimovich Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha. The bug shows up on alpha as it's one of the targets where EPOLL_CLOEXEC differs from other targets: sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 0100

[PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request for you to fetch changes up to

Re: [PATCH v2 7/8] hw/arm/fsl-imx7: Instantiate various unimplemented devices

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > Instantiating PWM, CAN, CAAM, and OCOTP devices is necessary to avoid > crashes when booting mainline Linux. > > Signed-off-by: Guenter Roeck Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 2/8] hw/watchdog: Implement full i.MX watchdog support

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > Implement full support for the watchdog in i.MX systems. > Pretimeout support is optional because the watchdog hardware on i.MX31 > does not support pretimeouts. > > Signed-off-by: Guenter Roeck > --- > v2: Fixup of CONFIG_WDT_IMX ->

Re: [PATCH] 9pfs: local: ignore O_NOATIME if we don't have permissions

2020-04-16 Thread Christian Schoenebeck
On Donnerstag, 16. April 2020 02:44:33 CEST Omar Sandoval wrote: > From: Omar Sandoval > > QEMU's local 9pfs server passes through O_NOATIME from the client. If > the QEMU process doesn't have permissions to use O_NOATIME (namely, it > does not own the file nor have the CAP_FOWNER capability),

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> We should document our result of page poisoning, free page hinting, and >> free page reporting there as well. I hope you'll have time for the latter. >> >> - >> Semantics of VIRTIO_BALLOON_F_PAGE_POISON >>

[Qemu devel PATCH v6 1/3] hw/net: Add Smartfusion2 emac block

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep Modelled Ethernet MAC of Smartfusion2 SoC. Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same PHY is emulated. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +

[Qemu devel PATCH v6 0/3] Add SmartFusion2 EMAC block

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep This patch set emulates Ethernet MAC block present in Microsemi SmartFusion2 SoC. v6: Fixed destination address matching logic Added missing break in emac_write v5: As per Philippe comments: Returned size in receive function Added link property to pass

[Qemu devel PATCH v6 3/3] tests/boot_linux_console: Add ethernet test to SmartFusion2

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep In addition to simple serial test this patch uses ping to test the ethernet block modelled in SmartFusion2 SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 15

[Qemu devel PATCH v6 2/3] msf2: Add EMAC block to SmartFusion2 SoC

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep With SmartFusion2 Ethernet MAC model in place this patch adds the same to SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/arm/msf2-soc.c | 26 --

[PATCH 2/3] qemu-img: Add convert --bitmaps option

2020-04-16 Thread Eric Blake
Make it easier to copy all the persistent bitmaps of a source image along with the contents, by adding a boolean flag for use with qemu-img convert. See also https://bugzilla.redhat.com/show_bug.cgi?id=1779893 Signed-off-by: Eric Blake --- docs/tools/qemu-img.rst | 6 ++- qemu-img.c

[PATCH 3/3] iotests: Add test 291 to for qemu-img convert --bitmaps

2020-04-16 Thread Eric Blake
Add a new test covering the feature added in the previous patch. Signed-off-by: Eric Blake --- tests/qemu-iotests/291 | 143 + tests/qemu-iotests/291.out | 56 +++ tests/qemu-iotests/group | 1 + 3 files changed, 200 insertions(+) create

[PATCH 1/3] blockdev: Split off basic bitmap operations for qemu-img

2020-04-16 Thread Eric Blake
The next patch wants to teach qemu how to copy a bitmap from one qcow2 file to another. But blockdev.o is too heavyweight to link into qemu-img, so it's time to split off the bare bones of what we will need into a new file blockbitmaps.o. Transactions are not needed in qemu-img (if things fail

[PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Eric Blake
Without this series, the process for copying one qcow2 image to another including all of its bitmaps involves running qemu and doing the copying by hand with a series of QMP commands. This makes the process a bit more convenient. I still think that someday we will need a 'qemu-img bitmap' with

  1   2   >