Re: [PATCH] accel: Move Xen accelerator code under accel/xen/

2020-05-07 Thread Philippe Mathieu-Daudé
On 5/7/20 5:58 PM, Philippe Mathieu-Daudé wrote: This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial.

Re: [PATCH] accel: Move Xen accelerator code under accel/xen/

2020-05-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200507155813.16169-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v3 2/2] char-socket: initialize reconnect timer only when the timer doesn't start

2020-05-07 Thread Li Feng
When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at

[PATCH v3 1/2] io/channel: fix crash when qio_channel_readv_all return 0

2020-05-07 Thread Li Feng
Root cause: >From `man recvmsg`, the RETURN VALUE says: These calls return the number of bytes received, or -1 if an error occurred. In the event of an error, errno is set to indicate the error. The return value will be 0 when the peer has performed an orderly shutdown. When an error happens,

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Derek Su
On 2020/5/8 上午10:26, Zhang, Chen wrote: -Original Message- From: Lukas Straub Sent: Thursday, May 7, 2020 11:54 PM To: Zhang, Chen Cc: qemu-devel ; Li Zhijian ; Jason Wang ; Marc- André Lureau ; Paolo Bonzini Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that

[PATCH 2/2] migration/rdma: cleanup rdma context before g_free to avoid memleaks

2020-05-07 Thread Pan Nengyuan
When error happen in initializing 'rdma_return_path', we should cleanup rdma context before g_free(rdma) to avoid some memleaks. This patch fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- migration/rdma.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

Re: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

2020-05-07 Thread Nicholas Piggin
Excerpts from Cédric Le Goater's message of May 8, 2020 3:14 am: > On 5/7/20 1:48 PM, Nicholas Piggin wrote: >> Commit a77fed5bd926 ("ppc/pnv: Add support for NMI interface") got the >> SRR1 setting wrong for sresets that hit outside of power-save states. >> >> Fix this, better documenting the

[PATCH 1/2] migration/rdma: fix potential nullptr access in rdma_start_incoming_migration

2020-05-07 Thread Pan Nengyuan
'rdma' is NULL when taking the first error branch in rdma_start_incoming_migration. And it will cause a null pointer access in label 'err'. Fix that. Fixes: 59c59c67ee6b0327ae932deb303caa47919aeb1e Signed-off-by: Pan Nengyuan --- migration/rdma.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

2020-05-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200507114824.788942-1-npig...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200507114824.788942-1-npig...@gmail.com Subject: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

[PATCH 0/2] migration/rdma: fix nullptr-def in rdma_start_incoming_migration

2020-05-07 Thread Pan Nengyuan
I fix a memleak in rdma_start_incoming_migration some time ago. https://patchwork.kernel.org/patch/11498191/ I'm sorry that it may cause a null-pointer access, this patch fix that. Since we are here, rdma_start_outgoing_migration has the similar memleak, fix it together. Pan Nengyuan (2):

Re: [PATCH 0/5] target/i386: fxtract, fscale fixes

2020-05-07 Thread Richard Henderson
On 5/7/20 7:57 AM, Joseph Myers wrote: > On Thu, 7 May 2020, no-re...@patchew.org wrote: > >> === OUTPUT BEGIN === >> 1/5 Checking commit 69eed0bcaaaf (target/i386: implement special cases for >> fxtract) >> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > > I don't

Re: [RFC v3 5/6] qmp: add QMP command x-debug-virtio-queue-element

2020-05-07 Thread Jason Wang
On 2020/5/7 下午7:49, Laurent Vivier wrote: This new command shows the information of a VirtQueue element. Signed-off-by: Laurent Vivier --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 130 qapi/virtio.json| 94

RE: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 12:09 AM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in > complete and finalize > > On

Re: [RFC v3 4/6] qmp: add QMP command x-debug-virtio-queue-status

2020-05-07 Thread Jason Wang
On 2020/5/7 下午7:49, Laurent Vivier wrote: This new command shows internal status of a VirtQueue. (vrings and indexes). Signed-off-by: Laurent Vivier It looks to me that packed virtqueue is not supported. It's better to add them in the future. --- hw/virtio/virtio-stub.c | 6 +++

Re: Emulating Solaris 10 on SPARC64 sun4u

2020-05-07 Thread jasper.lowell
> I don't know anything about this chip so don't know if it helps but > if > it's any way similar to ESCC (and the ESCC2 name is not just > marketing) > then there's some emulation of that in hw/char/escc.c that you may > want to > look at. From what I can tell, the SAB 82532 is a bit more

Re: [RFC v3 3/6] qmp: decode feature bits in virtio-status

2020-05-07 Thread Jason Wang
On 2020/5/7 下午7:49, Laurent Vivier wrote: Display feature names instead of a features bitmap for host, guest and backend. Decode features according device type, transport features are on the first line. Undecoded bits (if any) are stored in a separate field. Signed-off-by: Laurent Vivier

Re: Emulating Solaris 10 on SPARC64 sun4u

2020-05-07 Thread jasper.lowell
There are two different drivers for the 16550A in OpenSolaris. There is a generic driver in /usr/src/uts/common/io/asy.c. This driver clearly states in comments that it is assigning the device to tty[a-d]. It's really obvious to me that there is support in this driver for using the device for a

RE: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, May 7, 2020 11:54 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that > colo-compare is active

[PATCH RESEND v26 08/10] ACPI: Record Generic Error Status Block(GESB) table

2020-05-07 Thread Dongjiu Geng
kvm_arch_on_sigbus_vcpu() error injection uses source_id as index in etc/hardware_errors to find out Error Status Data Block entry corresponding to error source. So supported source_id values should be assigned here and not be changed afterwards to make sure that guest will write error into

[PATCH RESEND v26 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-05-07 Thread Dongjiu Geng
Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fills this PA to guest APEI GHES memory, then notifies guest according to the SIGBUS type. When guest accesses the poisoned memory, it will generate a Synchronous

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-07 Thread Jason Wang
On 2020/5/7 上午5:26, and...@daynix.com wrote: From: Andrew Melnychenko Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441 Added ICR clearing if there is IMS bit - according to the note by section 13.3.27 of the 8257X developers manual. Signed-off-by: Andrew Melnychenko ---

[PATCH RESEND v26 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-05-07 Thread Dongjiu Geng
I and Xiang are willing to review the APEI-related patches and volunteer as the reviewers for the HEST/GHES part. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- MAINTAINERS | 9 + 1 file changed, 9

[PATCH RESEND v26 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob

2020-05-07 Thread Dongjiu Geng
This patch builds error_block_address and read_ack_register fields in hardware errors table , the error_block_address points to Generic Error Status Block(GESB) via bios_linker. The max size for one GESB is 1kb, For more detailed information, please refer to document: docs/specs/acpi_hest_ghes.rst

[PATCH RESEND v26 06/10] ACPI: Record the Generic Error Status Block address

2020-05-07 Thread Dongjiu Geng
Record the GHEB address via fw_cfg file, when recording a error to CPER, it will use this address to find out Generic Error Data Entries and write the error. In order to avoid migration failure, make hardware error table address to a part of GED device instead of global variable, then this

RE: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, May 7, 2020 11:51 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in > compare_chr_send > > On Thu, 7

[PATCH RESEND v26 03/10] docs: APEI GHES generation and CPER record description

2020-05-07 Thread Dongjiu Geng
Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- docs/specs/acpi_hest_ghes.rst | 110 ++ docs/specs/index.rst | 1 + 2 files changed,

[PATCH RESEND v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-07 Thread Dongjiu Geng
The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Reviewed-by: Xiang Zheng Signed-off-by: Dongjiu Geng --- Change since v25: 1. Address Peter's comments to add a proper doc-comment comment for UUID_LE macros. ---

[PATCH RESEND v26 07/10] KVM: Move hwpoison page related functions into kvm-all.c

2020-05-07 Thread Dongjiu Geng
kvm_hwpoison_page_add() and kvm_unpoison_all() will both be used by X86 and ARM platforms, so moving them into "accel/kvm/kvm-all.c" to avoid duplicate code. For architectures that don't use the poison-list functionality the reset handler will harmlessly do nothing, so let's register the

[PATCH RESEND v26 05/10] ACPI: Build Hardware Error Source Table

2020-05-07 Thread Dongjiu Geng
This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of Generic Hardware Error Source version 2(GHESv2) error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel

[PATCH RESEND v26 02/10] hw/arm/virt: Introduce a RAS machine option

2020-05-07 Thread Dongjiu Geng
RAS Virtualization feature is not supported now, so add a RAS machine option and disable it by default. Reviewed-by: Peter Maydell Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 23

[PATCH RESEND v26 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-05-07 Thread Dongjiu Geng
In the ARMv8 platform, the CPU error types includes synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, host does not know the detailed information of guest, so it is expected that guest can do the recovery. For example, if an exception happens in a guest

Re: [PATCH] migration/rdma: fix a memleak on error path in rdma_start_incoming_migration

2020-05-07 Thread Pan Nengyuan
On 4/24/2020 5:46 PM, Dr. David Alan Gilbert wrote: > * Pan Nengyuan (pannengy...@huawei.com) wrote: >> 'rdma->host' is malloced in qemu_rdma_data_init, but forgot to free on the >> error >> path in rdma_start_incoming_migration(), this patch fix that. >> >> The leak stack: >> Direct leak of 2

Re: Parameter 'driver' expects pluggable device type

2020-05-07 Thread Priyamvad Acharya
Hi, Thanks for providing relevant information. FYI I am using Qemu version *4.2.94 (v5.0.0-rc4-dirty).* I am using *virt* board. Where we need to set *user creatable *to true? Any other modification is needed to allow sysbus device support? Below is the script which I am using to boot linux

Re: Parameter 'driver' expects pluggable device type

2020-05-07 Thread Priyamvad Acharya
Hi, Thanks for providing relevant information. FYI I am using Qemu version *4.2.94 (v5.0.0-rc4-dirty).* I am using *virt* board. Where we need to set *user creatable *to true? Any other modification is needed to allow sysbus device support? Below is the script which I am using to boot linux

Re: [PATCH v1 2/2] Sample mtty: Add migration capability to mtty module

2020-05-07 Thread Yan Zhao
On Thu, May 07, 2020 at 11:19:40AM +0530, Kirti Wankhede wrote: > > > On 5/7/2020 6:31 AM, Yan Zhao wrote: > > On Tue, May 05, 2020 at 01:54:20AM +0800, Kirti Wankhede wrote: > > > This patch makes mtty device migration capable. Purpose od this code is > > > to test migration interface. Only

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-07 Thread Huacai Chen
Hi, Aleksandar, On Thu, May 7, 2020 at 8:18 PM Aleksandar Markovic wrote: > > сре, 6. мај 2020. у 03:43 Huacai Chen је написао/ла: > > > > Hi, Aleksandar, > > > > On Tue, May 5, 2020 at 6:12 PM Aleksandar Markovic > > wrote: > > > > > > > > > > > > уторак, 05. мај 2020., chen huacai је

Re: [PATCH] target/ppc: Untabify excp_helper.c

2020-05-07 Thread David Gibson
On Thu, May 07, 2020 at 06:11:23PM +0200, Greg Kurz wrote: > Some tabs crept in with a recent change. > > Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging" > Signed-off-by: Greg Kurz Applied, thanks. Not quite sure why my pre-commit hook didn't catch this before I sent the

Re: [PATCH] ppc/spapr: add a POWER10 CPU model

2020-05-07 Thread David Gibson
On Thu, May 07, 2020 at 09:38:55AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied to ppc-for-5.1, thanks > --- > hw/ppc/spapr_cpu_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index

Re: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

2020-05-07 Thread David Gibson
On Thu, May 07, 2020 at 09:48:24PM +1000, Nicholas Piggin wrote: > Commit a77fed5bd926 ("ppc/pnv: Add support for NMI interface") got the > SRR1 setting wrong for sresets that hit outside of power-save states. > > Fix this, better documenting the source for the bit definitions. > > Fixes:

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-07 Thread dann frazier
Ike's backport in https://launchpad.net/~ikepanhc/+archive/ubuntu/lp1805256 tests well for me on Cavium Sabre. One minor note is that the function in_aio_context_home_thread() is being called in aio-win32.c, but that function didn't exist in 2.11. We probably want to change that to

Re: [PATCH 00/10] exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic

2020-05-07 Thread Paolo Bonzini
On 07/05/20 19:39, Philippe Mathieu-Daudé wrote: > Stefan suggested to make qemu_ram_writeback() target agnostic, > Paolo to add memory_region_msync(), and Peter to remove > "exec/ram_addr.h" [*]. > > I let a single function in this file, > cpu_physical_memory_sync_dirty_bitmap(), to let the

Re: [PATCH v2] Fix parameter type in vhost migration log path

2020-05-07 Thread Eric Blake
On 5/7/20 4:37 PM, Raphael Norwitz wrote: The ‘enable’ parameter to the vhost_migraion_log() function is given as typo: migration Presumably, the maintainer can fix this rather than needing you to send a v3... an int, but "true"/"false" values are passed in wherever it is invoked. Inside

Re: [PATCH v2] Fix parameter type in vhost migration log path

2020-05-07 Thread Eric Blake
On 5/7/20 4:37 PM, Raphael Norwitz wrote: The ‘enable’ parameter to the vhost_migraion_log() function is given as an int, but "true"/"false" values are passed in wherever it is invoked. Inside the function itself it is only ever compared with bool values. Therefore the parameter value itself

[PATCH v2] Fix parameter type in vhost migration log path

2020-05-07 Thread Raphael Norwitz
The ‘enable’ parameter to the vhost_migraion_log() function is given as an int, but "true"/"false" values are passed in wherever it is invoked. Inside the function itself it is only ever compared with bool values. Therefore the parameter value itself should be changed to bool. Signed-off-by:

[Bug 1857269] Re: Spanish keyboard from Spain (Europe) not found

2020-05-07 Thread José Antonio López Cano
Hello, I thought that the not fully working problem on my laptop was originated by the es keymap file, but it is not. I have edited that file and I receive the same error. I believe that windows version of qemu has a problem, at least, with laptops. A few months ago I get this error with an asus

Re: Parameter 'driver' expects pluggable device type

2020-05-07 Thread John Snow
On 5/6/20 8:56 AM, Priyamvad Acharya wrote: > > Hello developer community, > I want to allow a *sysbus *type device to boot with kernel image(arm > architecture) via Qemu command line . > > When I run qemu arm system executable with *-device *option via qemu > command line,I get following

Re: [PATCH] Fix erroneous double negation in conditional

2020-05-07 Thread Michael S. Tsirkin
On Tue, Apr 28, 2020 at 12:04:29AM -0400, Raphael Norwitz wrote: > In vhost_migration_log() there is the following check: > if(!!enable == dev->log_enabled) { > return 0; > } > > The double negative “!!” is unnecessary and bad coding style. It converts the value to bool. > This

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-07 Thread Alex Bennée
Peter Maydell writes: > On Thu, 7 May 2020 at 19:38, Alex Bennée wrote: >> >> >> Philippe Mathieu-Daudé writes: >> >> > The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run. >> > Add a possibility to users to skip this particular test, by setting >> > the

Re: [PATCH v16 QEMU 08/16] vfio: Register SaveVMHandlers for VFIO device

2020-05-07 Thread Alex Williamson
On Thu, 7 May 2020 01:00:05 +0530 Kirti Wankhede wrote: > On 5/6/2020 10:23 PM, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Wed, 6 May 2020 02:38:46 -0400 > >> Yan Zhao wrote: > >> > >>> On Tue, May 05, 2020 at 12:37:26PM +0800, Alex Williamson

Re: [PATCH] Fix erroneous double negation in conditional

2020-05-07 Thread Eric Blake
On 5/7/20 3:06 PM, Raphael Norwitz wrote: In vhost_migration_log() there is the following check: if(!!enable == dev->log_enabled) { return 0; } The double negative “!!” is unnecessary and bad coding style. This change removes it. !!int or !!ptr is not bad coding style - it

[PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

2020-05-07 Thread Amanieu d'Antras
This fixes signal handlers running with the wrong endianness if the interrupted code used SETEND to dynamically switch endianness. Signed-off-by: Amanieu d'Antras --- linux-user/arm/signal.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-user/arm/signal.c

Re: [RFC v4 0/6] hmp, qmp: Add some commands to introspect virtio devices

2020-05-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200507134800.10837-1-lviv...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200507134800.10837-1-lviv...@redhat.com Subject: [RFC v4 0/6] hmp,qmp: Add some commands to

[PATCH] Fix erroneous double negation in conditional

2020-05-07 Thread Raphael Norwitz
In vhost_migration_log() there is the following check: if(!!enable == dev->log_enabled) { return 0; } The double negative “!!” is unnecessary and bad coding style. This change removes it. Signed-off-by: Raphael Norwitz --- hw/virtio/vhost.c | 2 +- 1 file changed, 1

Re: [PATCH v2] Fix stack smashing when handling PR_GET_PDEATHSIG

2020-05-07 Thread Laurent Vivier
Le 07/05/2020 à 15:03, Stephen Long a écrit : > The bug was triggered by the following code on aarch64-linux-user: > > #include > #include > > int main(void) > { > int PDeathSig = 0; > if (prctl(PR_GET_PDEATHSIG, ) == 0 && PDeathSig == SIGKILL) > prctl(PR_GET_PDEATHSIG, 0); > return

Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process

2020-05-07 Thread Peter Xu
Hi, Eric, On Thu, May 07, 2020 at 04:31:59PM +0200, Eric Auger wrote: > @@ -640,6 +641,24 @@ static IOMMUTLBEntry > virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, > goto unlock; > } > > +for (i = 0; i < s->nb_reserved_regions; i++) { > +if (interval.low >=

Re: [PATCH 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-07 Thread Peter Xu
Hi, Eric, On Thu, May 07, 2020 at 04:31:58PM +0200, Eric Auger wrote: [...] > @@ -452,17 +520,33 @@ static void virtio_iommu_handle_command(VirtIODevice > *vdev, VirtQueue *vq) > case VIRTIO_IOMMU_T_UNMAP: > tail.status = virtio_iommu_handle_unmap(s, iov, iov_cnt); >

Re: backing chain & block status & filters

2020-05-07 Thread Vladimir Sementsov-Ogievskiy
07.05.2020 15:58, Max Reitz wrote: On 28.04.20 16:51, Vladimir Sementsov-Ogievskiy wrote: 28.04.2020 14:08, Max Reitz wrote: On 28.04.20 10:55, Vladimir Sementsov-Ogievskiy wrote: Hi! I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and is_allocated_above", and returned to

[PATCH v2 9/9] target/riscv: Use a smaller guess size for no-MMU PMP

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/pmp.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index 0e6b640fbd..5aba4d13ea 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -233,12 +233,21 @@ bool

[PATCH v2 6/9] hw/intc: Initial commit of lowRISC Ibex PLIC

2020-05-07 Thread Alistair Francis
The Ibex core contains a PLIC that although similar to the RISC-V spec is not RISC-V spec compliant. This patch implements a Ibex PLIC in a somewhat generic way. As the current RISC-V PLIC needs tidying up, my hope is that as the Ibex PLIC move towards spec compliance this PLIC implementation

[PATCH v2 4/9] riscv: Initial commit of OpenTitan machine

2020-05-07 Thread Alistair Francis
This adds a barebone OpenTitan machine to QEMU. Signed-off-by: Alistair Francis --- MAINTAINERS | 10 ++ default-configs/riscv32-softmmu.mak | 1 + default-configs/riscv64-softmmu.mak | 11 +- hw/riscv/Kconfig| 5 + hw/riscv/Makefile.objs

[PATCH v2 5/9] hw/char: Initial commit of Ibex UART

2020-05-07 Thread Alistair Francis
This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is based on the documentation from: https://docs.opentitan.org/hw/ip/uart/doc/ Signed-off-by: Alistair Francis --- MAINTAINERS | 2 +

[PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-07 Thread Alistair Francis
If the reset vector is set in the init function don't set it again in realise. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 059d71f2c7..8f837edf8d

[PATCH v2 1/9] riscv/boot: Add a missing header include

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- include/hw/riscv/boot.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h index 474a940ad5..9daa98da08 100644 --- a/include/hw/riscv/boot.h +++ b/include/hw/riscv/boot.h @@ -21,6 +21,7 @@ #define

[PATCH v2 8/9] riscv/opentitan: Connect the UART device

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/opentitan.c | 24 ++-- include/hw/riscv/opentitan.h | 13 + 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c index 3926321d8c..a6c0b949ca 100644 ---

[PATCH v2 3/9] target/riscv: Add the lowRISC Ibex CPU

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 10 ++ target/riscv/cpu.h | 1 + 2 files changed, 11 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 8f837edf8d..235101f685 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -160,6 +160,15 @@

[PATCH v2 7/9] riscv/opentitan: Connect the PLIC device

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/opentitan.c | 19 +-- include/hw/riscv/opentitan.h | 3 +++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c index c00f0720ab..3926321d8c 100644 ---

[PATCH v2 0/9] RISC-V Add the OpenTitan Machine

2020-05-07 Thread Alistair Francis
OpenTitan is an open source silicon Root of Trust (RoT) project. This series adds initial support for the OpenTitan machine to QEMU. This series add the Ibex CPU to the QEMU RISC-V target. It then adds the OpenTitan machine, the Ibex UART and the Ibex PLIC. The UART has been tested sending and

[PATCH v2 3/3] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-07 Thread Alistair Francis
The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since 4.1. It's not commonly used so let's remove support for it. Signed-off-by: Alistair Francis --- target/riscv/cpu.c| 2 - target/riscv/cpu.h| 1 - target/riscv/csr.c

Re: [PATCH v1 2/2] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-07 Thread Alistair Francis
On Wed, May 6, 2020 at 5:11 AM Philippe Mathieu-Daudé wrote: > > Hi Alistair, > > On 5/6/20 3:12 AM, Alistair Francis wrote: > > The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since > > 4.1. It's not commonly used so let's remove support for it. > > > > Signed-off-by: Alistair

[PATCH v2 1/3] hw/riscv: spike: Remove deprecated ISA specific machines

2020-05-07 Thread Alistair Francis
The ISA specific Spike machines have been deprecated in QEMU since 4.1, let's finally remove them. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- hw/riscv/spike.c | 217 --- include/hw/riscv/spike.h | 6 +- 2 files

[PATCH v2 2/3] target/riscv: Remove the deprecated CPUs

2020-05-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 28 target/riscv/cpu.h | 7 --- tests/qtest/machine-none-test.c | 4 ++-- 3 files changed, 2 insertions(+), 37 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c

[PATCH v2 0/3] RTISC-V: Remove deprecated ISA, CPUs and machines

2020-05-07 Thread Alistair Francis
v2: - Remove the CPUs and ISA seperatley Alistair Francis (3): hw/riscv: spike: Remove deprecated ISA specific machines target/riscv: Remove the deprecated CPUs target/riscv: Drop support for ISA spec version 1.09.1 hw/riscv/spike.c | 217 --

Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment

2020-05-07 Thread Maxim Levitsky
On Thu, 2020-05-07 at 11:09 -0500, Eric Blake wrote: > On 5/7/20 7:54 AM, Maxim Levitsky wrote: > > This will be used first to implement luks keyslot management. > > > > block_crypto_amend_opts_init will be used to convert > > qemu-img cmdline to QCryptoBlockAmendOptions > > > > Signed-off-by:

Re: [PATCH v4 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()

2020-05-07 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 07.05.20 17:42, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >> * David Hildenbrand (da...@redhat.com) wrote: > >>> Let's consolidate resetting the variables. > >>> > >>> Cc: "Dr. David Alan Gilbert" >

[PATCH 0/1] hw/net: Added basic IPv6 fragmentation. Fixed IPv6 payload length. Fixed CSO for IPv6.

2020-05-07 Thread andrew
From: Andrew Melnychenko Compare to previous patch - fixed issue with compilation in docker fedora test. Andrew Melnychenko (1): hw/net: Added basic IPv6 fragmentation. Fixed IPv6 payload length. Fixed CSO for IPv6. hw/net/net_tx_pkt.c | 54 ---

[PATCH 1/1] hw/net: Added basic IPv6 fragmentation. Fixed IPv6 payload length. Fixed CSO for IPv6.

2020-05-07 Thread andrew
From: Andrew Melnychenko Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065 Overall, there was an issue that big frames of IPv6 doesn't sent. With network backend with 'virtual header' - there was an issue in 'plen' field. Overall, during TSO, 'plen' would be changed, but with

Re: Emulating Solaris 10 on SPARC64 sun4u

2020-05-07 Thread BALATON Zoltan
On Thu, 7 May 2020, jasper.low...@bt.com wrote: I've started work on emulating the SAB 82532 ESSC2 but it's unfortunately way more complex than than the 16550A. For instance, it's I don't know anything about this chip so don't know if it helps but if it's any way similar to ESCC (and the

Re: [PATCH] block/block-copy: fix use-after-free of task pointer

2020-05-07 Thread Eric Blake
On 5/7/20 1:38 PM, Vladimir Sementsov-Ogievskiy wrote: Obviously, we should g_free the task after trace point and offset update. Reported-by: Coverity Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e Signed-off-by: Vladimir Sementsov-Ogievskiy --- Be free to add Coverity number to the commit

Re: [PULL 00/12] migration queue

2020-05-07 Thread Peter Maydell
On Thu, 7 May 2020 at 18:04, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 3c7adbc67d9a5c3e992a4dd13b8704464daaad5b: > > Merge remote-tracking branch > 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2020-05-07 >

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-07 Thread Peter Maydell
On Thu, 7 May 2020 at 19:38, Alex Bennée wrote: > > > Philippe Mathieu-Daudé writes: > > > The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run. > > Add a possibility to users to skip this particular test, by setting > > the AVOCADO_SKIP_SLOW_TESTS environment variable: > > > >

Re: [PATCH v1 2/2] Sample mtty: Add migration capability to mtty module

2020-05-07 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > This patch makes mtty device migration capable. Purpose od this code is > to test migration interface. Only stop-and-copy phase is implemented. > Postcopy migration is not supported. > > Actual data for mtty device migration is very less. Appended

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run. > Add a possibility to users to skip this particular test, by setting > the AVOCADO_SKIP_SLOW_TESTS environment variable: > > $ AVOCADO_SKIP_SLOW_TESTS=please make check-acceptance > ... >

[PATCH] block/block-copy: fix use-after-free of task pointer

2020-05-07 Thread Vladimir Sementsov-Ogievskiy
Obviously, we should g_free the task after trace point and offset update. Reported-by: Coverity Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e Signed-off-by: Vladimir Sementsov-Ogievskiy --- Be free to add Coverity number to the commit message, I don't know it. block/block-copy.c | 2 +- 1

Re: [PATCH v4 5/5] block/block-copy: use aio-task-pool API

2020-05-07 Thread Vladimir Sementsov-Ogievskiy
07.05.2020 18:53, Kevin Wolf wrote: Am 29.04.2020 um 15:08 hat Vladimir Sementsov-Ogievskiy geschrieben: Run block_copy iterations in parallel in aio tasks. Changes: - BlockCopyTask becomes aio task structure. Add zeroes field to pass it to block_copy_do_copy - add call state - it's

Re: [PATCH] linux-user/sparc64: Translate flushw opcode

2020-05-07 Thread Richard Henderson
On 4/10/20 2:14 PM, LemonBoy wrote: > From 11d0cfe58d12e0f191b435ade88622cfceb2098a Mon Sep 17 00:00:00 2001 > From: LemonBoy > Date: Fri, 10 Apr 2020 22:55:26 +0200 > Subject: [PATCH] linux-user/sparc64: Translate flushw opcode > > The ifdef logic should unconditionally compile in the `xop ==

Re: [PATCH v2 10/9] qed: Simplify backing reads

2020-05-07 Thread Vladimir Sementsov-Ogievskiy
07.05.2020 17:45, Eric Blake wrote: The other four drivers that support backing files (qcow, qcow2, parallels, vmdk) all rely on the block layer to populate zeroes when reading beyond EOF of a short backing file. We can simplify the qed code by doing likewise. Signed-off-by: Eric Blake

Re: [PATCH Kernel v18 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-05-07 Thread Alex Williamson
On Thu, 7 May 2020 01:12:25 +0530 Kirti Wankhede wrote: > On 5/6/2020 1:45 PM, Yan Zhao wrote: > > On Mon, May 04, 2020 at 11:58:56PM +0800, Kirti Wankhede wrote: > > > > >> /* > >>* Helper Functions for host iova-pfn list > >>*/ > >> @@ -567,6 +654,18 @@ static int

Re: [PATCH v16 QEMU 04/16] vfio: Add save and load functions for VFIO PCI devices

2020-05-07 Thread Alex Williamson
On Thu, 7 May 2020 11:10:40 +0530 Kirti Wankhede wrote: > On 5/7/2020 1:33 AM, Alex Williamson wrote: > > On Thu, 7 May 2020 01:18:19 +0530 > > Kirti Wankhede wrote: > > > >> On 5/6/2020 11:41 AM, Yan Zhao wrote: > >>> On Tue, May 05, 2020 at 12:37:11PM +0800, Alex Williamson wrote: >

Re: [PATCH v2 4/4] target/arm: Fix tcg_gen_gvec_dup_imm vs DUP (indexed)

2020-05-07 Thread Laurent Desnogues
On Thu, May 7, 2020 at 7:23 PM Richard Henderson wrote: > > DUP (indexed) can duplicate 128-bit elements, so using esz > unconditionally can assert in tcg_gen_gvec_dup_imm. > > Fixes: 8711e71f9cbb > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent

Re: [PATCH] target/ppc: Untabify excp_helper.c

2020-05-07 Thread Philippe Mathieu-Daudé
On 5/7/20 6:11 PM, Greg Kurz wrote: Some tabs crept in with a recent change. Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging" Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé using `git-diff --ignore-space-change`. --- target/ppc/excp_helper.c | 16

Re: [PATCH v3 06/10] iotests: add testfinder.py

2020-05-07 Thread Vladimir Sementsov-Ogievskiy
21.04.2020 19:56, Kevin Wolf wrote: Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben: Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't

Re: [PATCH 08/10] hw/block: Let the NVMe emulated device be target-agnostic

2020-05-07 Thread Philippe Mathieu-Daudé
On 5/7/20 7:39 PM, Philippe Mathieu-Daudé wrote: Now than qemu_ram_msync() has been ... Oops =) "Now than qemu_ram_msync() is no more target-specific, we can make this device-generic." Signed-off-by: Philippe Mathieu-Daudé --- hw/block/Makefile.objs | 2 +- 1 file changed, 1

[PATCH 10/10] exec: Move cpu_physical_memory_* functions to 'exec/memory-internal.h'

2020-05-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory-internal.h | 305 - include/exec/ram_addr.h| 303 +--- accel/tcg/cputlb.c | 1 - hw/ppc/spapr.c | 1 - hw/ppc/spapr_pci.c

[PATCH 09/10] exec: Update coding style to make checkpatch.pl happy

2020-05-07 Thread Philippe Mathieu-Daudé
We will move this code in the next commit. Clean it up first to avoid checkpatch.pl errors. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/include/exec/ram_addr.h

[PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c

2020-05-07 Thread Philippe Mathieu-Daudé
The ramblock_recv_bitmap_offset() function is only used once in migration/ram.c, move it there. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8 migration/ram.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 04/10] exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY

2020-05-07 Thread Philippe Mathieu-Daudé
The CONFIG_SOFTMMU definition is poisoned in "exec/poison.h". As this header is internal, check for poisoned CONFIG_SOFTMMU instead of CONFIG_USER_ONLY to make this include harder to use. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory-internal.h | 2 +- 1 file changed, 1

RE: [PATCH] accel: Move Xen accelerator code under accel/xen/

2020-05-07 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 07 May 2020 16:58 > To: qemu-devel@nongnu.org > Cc: Philippe Mathieu-Daudé ; > xen-de...@lists.xenproject.org; Stefano Stabellini > ; Aleksandar Markovic > ; Aurelien Jarno > ; Paolo Bonzini ; Igor Mammedov > ; > Eduardo

[PATCH 08/10] hw/block: Let the NVMe emulated device be target-agnostic

2020-05-07 Thread Philippe Mathieu-Daudé
Now than qemu_ram_msync() has been ... Signed-off-by: Philippe Mathieu-Daudé --- hw/block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/Makefile.objs b/hw/block/Makefile.objs index 47960b5f0d..8855c22656 100644 --- a/hw/block/Makefile.objs +++

[PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

2020-05-07 Thread Philippe Mathieu-Daudé
The first field of RAMBlock is a rcu_head structure. We need to include the "qemu/rcu.h" to avoid errors when including "exec/ramblock.h" without "qemu/rcu.h": include/exec/ramblock.h:27:21: error: field ‘rcu’ has incomplete type 27 | struct rcu_head rcu; |

[PATCH 03/10] exec: Move tb_invalidate_phys_range() to 'exec/exec-all.h'

2020-05-07 Thread Philippe Mathieu-Daudé
Move tb_invalidate_phys_range() to "exec/exec-all.h" with the other TranslationBlock invalidate functions. Move all these functions altogether. Check for the CONFIG_SOFTMMU definition which is more explicit than CONFIG_USER_ONLY. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/exec-all.h

  1   2   3   4   >