Re: Emulating Solaris 10 on SPARC64 sun4u

2020-05-09 Thread jasper.lowell
Good idea. The ESCC device looks like it's written as a sysbus device. I think the Ultra 5 has no devices on the root sabre bus. The serial controller is behind the ebus (essentially isa). I'm guessing I would need to write a wrapper device around the memory io functions so that it can be used

[Bug 1876678] Re: Ubuntu 20.04 KVM / QEMU Failure with nested FreeBSD bhyve

2020-05-09 Thread John Hartley
Hi Ubuntu / KVM Maintainers, I have now done additional diagnostics on this bug and it appears to be triggered in nested virtualization case when apic virtualisation is available in Layer 0 HW and then passed forward to Layer 1 VM via Libvirt: . Testing found that in case where Layer 1 FreeBSD

[Qemu-devel][PATCH v5 4/4] x86/cpu: Add user space access interface for CET MSRs

2020-05-09 Thread Yang Weijiang
Added interface for CET MSR_IA32_{U,S}_CET, MSR_IA32_PL{0,1,2,3}_SSP, MSR_IA32_INTR_SSP_TBL and MSR_KVM_GUEST_SSP save/restore. Check if corresponding CET features are available before access the MSRs. Signed-off-by: Yang Weijiang --- target/i386/cpu.h | 18 + target/i386/kvm.c |

[Qemu-devel][PATCH v5 2/4] x86/cpuid: Add XSAVES feature words and CET related state bits

2020-05-09 Thread Yang Weijiang
CET SHSTK/IBT MSRs can be saved/restored with XSAVES/XRSTORS, but currently the related feature words are not supported, so add the new entries. XSAVES/RSTORS always use compacted storage format, which means the supervisor states' offsets are always 0, ignore them while calculating stardard format

[Qemu-devel][PATCH v5 3/4] x86/cpuid: Add support for XSAVES dependent feature enumeration

2020-05-09 Thread Yang Weijiang
Currently XSAVES dependent features are not supported in CPUID enumeration, update CPUID(0xD,n>=1) to enable it. CET XSAVES related enumeration includes: CPUID(0xD,1):ECX[bit 11]: user mode CET state, controls bit 11 in XSS. CPUID(0xD,1):ECX[bit 12]: supervisor mode CET state, controls bit 12 in

[Qemu-devel][PATCH v5 0/4] Enable CET support for guest

2020-05-09 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against return/jump-oriented programming (ROP/JOP). It includes two sub-features: Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT). This patchset is to enable CET related CPUID report, XSAVES/XRSTORS support and MSR access etc.

[Qemu-devel][PATCH v5 1/4] x86/cpu: Add CET CPUID/XSAVES flags and data structures

2020-05-09 Thread Yang Weijiang
CET feature SHSTK and IBT are enumerated via CPUID(EAX=0x7,0):ECX[bit 7] and EDX[bit 20] respectively. Two CET bits (bit 11 and 12) are defined in MSR_IA32_XSS to support XSAVES/XRSTORS. CPUID(EAX=0xd, 1):ECX[bit 11] and ECX[bit 12] correspond to CET states in user and supervisor mode

[PATCH] qom: remove index from object_resolve_abs_path()

2020-05-09 Thread Masahiro Yamada
You can advance 'parts' to track the current path fragment. The 'index' parameter is unneeded. Signed-off-by: Masahiro Yamada --- qom/object.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/qom/object.c b/qom/object.c index aa8a3f24e6..a3ee968b12 100644

Re: [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times

2020-05-09 Thread Emilio G. Cota
On Mon, Apr 20, 2020 at 13:04:51 +0300, Nikolay Igotti wrote: > In linux-user multithreaded scenarious CPU could be inited many times with > the same id, > so avoid assertions on already present hashtable entry. > > Signed-off-by: Nikolay Igotti > --- > plugins/core.c | 5 + > 1 file

[Bug 1877794] [NEW] Constant Folding on 64-bit Subtraction causes SIGILL on linux-user glxgears ppc64le to x86_64 by way of generating bad shift instruction with c=-1

2020-05-09 Thread Catherine A. Frederick
Public bug reported: Hello, I've been recently working on my own little branch of QEMU implementing the drm IOCTLs, when I discovered that glxgears seems to crash in GLXSwapBuffers(); with a SIGILL. I investigated this for about 2 weeks, manually trying to trace the call stack, only to find that

Re: [PATCH 09/11] target/cpu: Restrict handlers using hwaddr type to system-mode

2020-05-09 Thread Paolo Bonzini
Il sab 9 mag 2020, 22:01 Philippe Mathieu-Daudé ha scritto: > > I forgot once Peter Maydell told me we can't do that for some reason I > > don't remember. > > > > At least this changes the sizeof(CPUClass), so we get: > > > > qom/object.c:315:type_initialize: assertion failed:

[Bug 1877781] [NEW] TCG does not support x2APIC emulation

2020-05-09 Thread Dan Cross
Public bug reported: This is not a bug so much as a feature request. It would be great if there was a pure-software emulation of the x2APIC on x86_64, so that it could be used on systems that don't support such providing a thing on via a host-based solution (e.g., KVM etc). KVM provides this,

Re: [PATCH 09/11] target/cpu: Restrict handlers using hwaddr type to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
On Sat, May 9, 2020 at 6:08 PM Philippe Mathieu-Daudé wrote: > On 5/9/20 3:09 PM, Philippe Mathieu-Daudé wrote: > > Restrict the following handlers to system-mode: > > - do_unaligned_access > > - do_transaction_failed > > - get_phys_page_debug > > - get_phys_page_attrs_debug > > > >

[Bug 1877688] Re: 9p virtfs device reports error when opening certain files

2020-05-09 Thread A A
Thanks, it works. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877688 Title: 9p virtfs device reports error when opening certain files Status in QEMU: In Progress Bug description: Reading

[Bug 1877688] Re: 9p virtfs device reports error when opening certain files

2020-05-09 Thread Christian Schoenebeck
The following patch should fix this bug for the kvm backend (not for the XEN backend yet). Please let me know if it fixes this bug for you. ** Patch added: "bug1877688_kvm_fix.patch" https://bugs.launchpad.net/qemu/+bug/1877688/+attachment/5369130/+files/bug1877688_kvm_fix.patch ** Changed

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Alex Bennée
Laurent Desnogues writes: > On Sat, May 9, 2020 at 2:38 PM Aleksandar Markovic > wrote: >> >> суб, 9. мај 2020. у 13:37 Laurent Desnogues >> је написао/ла: >> > >> > On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic >> > wrote: >> > > сре, 6. мај 2020. у 13:26 Alex Bennée је >> > >

Re: [PATCH 09/11] target/cpu: Restrict handlers using hwaddr type to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
On 5/9/20 3:09 PM, Philippe Mathieu-Daudé wrote: Restrict the following handlers to system-mode: - do_unaligned_access - do_transaction_failed - get_phys_page_debug - get_phys_page_attrs_debug Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 8 +---

[Bug 1877688] Re: 9p virtfs device reports error when opening certain files

2020-05-09 Thread Christian Schoenebeck
Looks like being introduced by this change: https://patchwork.kernel.org/patch/11319993/ More specifically this one exactly: -if (buf_size < size) { +if (buf_size < P9_IOHDRSZ) { -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Fwd: Qemu Support for Virtio Video V4L2 driver

2020-05-09 Thread Saket Sinha
Hi, As suggested on #qemu-devel IRC channel, I am including virtio-dev, Gerd and Michael to point in the right direction how to move forward with Qemu support for Virtio Video V4L2 driver posted in [1]. [1]: https://patchwork.linuxtv.org/patch/61717/ Regards, Saket Sinha On Sat, May 9, 2020 at

Re: Qemu Support for Virtio Video V4L2 driver

2020-05-09 Thread Saket Sinha
Hi, As suggested on #qemu-devel IRC channel, I am including Gerd and Michael to point in the right direction how to move forward with Qemu support for Virtio Video V4L2 driver posted in [1]. [1]: https://patchwork.linuxtv.org/patch/61717/ Regards, Saket Sinha On Sat, May 9, 2020 at 1:09 AM

[Bug 1877384] Re: 9pfs file create with mapped-xattr can fail on overlayfs

2020-05-09 Thread Christian Schoenebeck
Since the report is about overlayfs being involved, could you please try if the following patch makes a difference? https://github.com/gkurz/qemu/commit/f7f5a1b01307af1c7b6c94672f2ce75c36f10565 It's not yet on master, but will be soon. -- You received this bug notification because you are a

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-09 Thread Lukas Straub
On Thu, 7 May 2020 18:22:35 +0200 Philippe Mathieu-Daudé wrote: > The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run. > Add a possibility to users to skip this particular test, by setting > the AVOCADO_SKIP_SLOW_TESTS environment variable: > > $

[PATCH 11/11] exec/cpu-common: Poison hwaddr type in user-mode emulation

2020-05-09 Thread Philippe Mathieu-Daudé
The 'hwaddr' type is restricted to system-mode. Declare it poisoned on user-mode emulation. Signed-off-by: Philippe Mathieu-Daudé --- Checkpatch complains: WARNING: architecture specific defines should be avoided #10: FILE: include/exec/cpu-common.h:7: +#ifdef __GNUC__ ---

[PATCH 09/11] target/cpu: Restrict handlers using hwaddr type to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
Restrict the following handlers to system-mode: - do_unaligned_access - do_transaction_failed - get_phys_page_debug - get_phys_page_attrs_debug Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 8 +--- target/alpha/cpu.h | 4 +++- target/arm/cpu.h

[PATCH 10/11] exec: Use 'cpu-common.h' instead of system-mode specific 'hwaddr.h'

2020-05-09 Thread Philippe Mathieu-Daudé
The "exec/hwaddr.h" header is restricted to system-mode emulation. Instead, use "exec/cpu-common.h", which is meant for all modes. Signed-off-by: Philippe Mathieu-Daudé --- include/disas/disas.h | 2 +- include/hw/core/cpu.h | 2 +- include/sysemu/accel.h | 2 +- 3 files changed, 3

[PATCH 07/11] target/s390x/helper: Clean ifdef'ry

2020-05-09 Thread Philippe Mathieu-Daudé
All this code is guarded checking CONFIG_USER_ONLY definition. Drop the duplicated checks. Signed-off-by: Philippe Mathieu-Daudé --- Suspicious ifdef'ry in s390_handle_wait() from commit 83f7f32901c. --- target/s390x/helper.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH 04/11] sysemu/hvf: Only declare hvf_allowed when HVF is available

2020-05-09 Thread Philippe Mathieu-Daudé
When HVF is not available, the tcg_allowed variable does not exist. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/hvf.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h index d211e808e9..fe95743124 100644 ---

[PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-09 Thread Philippe Mathieu-Daudé
As these declarations are restricted to !CONFIG_USER_ONLY in helper.c, only declare them when system-mode emulation is used. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/internal.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/s390x/internal.h

[PATCH 06/11] target/s390x: Only compile decode_basedisp() on system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
The decode_basedisp*() methods are only used in ioinst.c, which is only build in system-mode emulation. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/internal.h | 4 1 file changed, 4 insertions(+) diff --git a/target/s390x/internal.h b/target/s390x/internal.h index

[PATCH 01/11] plugins: Restrict functions handling hwaddr to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
Restrict qemu_plugin_hwaddr_is_io() and qemu_plugin_hwaddr_device_offset() to system-mode. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/qemu-plugin.h | 2 ++ plugins/api.c | 17 ++--- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git

[PATCH 00/11] exec/cpu: Poison 'hwaddr' type in user-mode emulation

2020-05-09 Thread Philippe Mathieu-Daudé
The 'hwaddr' type declared in "exec/hwaddr.h" is meant for system-mode emulation only. Poison it in user-mode code. Philippe Mathieu-Daudé (11): plugins: Restrict functions handling hwaddr to system-mode sysemu/accel: Restrict machine methods to system-mode sysemu/tcg: Only declare

[PATCH 02/11] sysemu/accel: Restrict machine methods to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
Restrict init_machine(), setup_post() and has_memory() to system-mode. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/accel.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 47e5788530..e08b8ab8fa 100644 ---

[PATCH 05/11] target/ppc: Restrict PPCVirtualHypervisorClass to system-mode

2020-05-09 Thread Philippe Mathieu-Daudé
The code related to PPC Virtual Hypervisor is pointless in user-mode. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu.h| 4 ++-- target/ppc/kvm_ppc.h| 22 +++--- target/ppc/translate_init.inc.c | 4 3 files changed, 17 insertions(+),

[PATCH 03/11] sysemu/tcg: Only declare tcg_allowed when TCG is available

2020-05-09 Thread Philippe Mathieu-Daudé
When TCG is not available, the tcg_allowed variable does not exist. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/tcg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h index 7d116d2e80..d9d3ca8559 100644 ---

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Aleksandar Markovic
суб, 9. мај 2020. у 14:50 Laurent Desnogues је написао/ла: > > On Sat, May 9, 2020 at 2:38 PM Aleksandar Markovic > wrote: > > > > суб, 9. мај 2020. у 13:37 Laurent Desnogues > > је написао/ла: > > > > > > On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic > > > wrote: > > > > сре, 6. мај

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Laurent Desnogues
On Sat, May 9, 2020 at 2:38 PM Aleksandar Markovic wrote: > > суб, 9. мај 2020. у 13:37 Laurent Desnogues > је написао/ла: > > > > On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic > > wrote: > > > сре, 6. мај 2020. у 13:26 Alex Bennée је > > > написао/ла: > > > > > > > This is very much

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Aleksandar Markovic
суб, 9. мај 2020. у 13:37 Laurent Desnogues је написао/ла: > > On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic > wrote: > > сре, 6. мај 2020. у 13:26 Alex Bennée је > > написао/ла: > > > > > This is very much driven by how much code generation vs running you see. > > > In most of my

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-09 Thread Lukas Straub
On Fri, 8 May 2020 06:50:39 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Friday, May 8, 2020 2:11 PM > > To: Zhang, Chen > > Cc: qemu-devel ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: Re: [PATCH v4 5/6]

Re: [RFC v2 7/9] virito-pci: implement queue_enabled method

2020-05-09 Thread Philippe Mathieu-Daudé
Typo "virtio-pci" in patch subject. On 5/8/20 6:32 PM, Cindy Lu wrote: From: Jason Wang With version 1, we can detect whether a queue is enabled via queue_enabled. Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH v5 02/19] exec: Fix cpu_watchpoint_address_matches address length

2020-05-09 Thread Philippe Mathieu-Daudé
On 5/8/20 5:43 PM, Richard Henderson wrote: The only caller of cpu_watchpoint_address_matches passes TARGET_PAGE_SIZE, so the bug is not currently visible. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Laurent Desnogues
On Sat, May 9, 2020 at 12:17 PM Aleksandar Markovic wrote: > сре, 6. мај 2020. у 13:26 Alex Bennée је написао/ла: > > > This is very much driven by how much code generation vs running you see. > > In most of my personal benchmarks I never really notice code generation > > because I give my

[Bug 1877716] Re: Win10 guest unsuable after a few minutes

2020-05-09 Thread zkrx
I can also replicate the problem on current master. I can solve it by building master with --disable-linux-io-uring. I also tried building Linux 5.4.39 where the issue happens too: Linux cc 5.4.39qemu #1 SMP PREEMPT Sat May 9 12:11:38 CEST 2020 x86_64 GNU/Linux I attached the logs of that latest

Re: [INFO] Some preliminary performance data

2020-05-09 Thread Aleksandar Markovic
суб, 9. мај 2020. у 12:16 Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > > > сре, 6. мај 2020. у 13:26 Alex Bennée је написао/ла: > > > > > > Aleksandar Markovic writes: > > > > Some preliminary thoughts > > > > Alex, many thanks for all your thoughts and hints

Re: [PATCH v5 00/19] target/arm: sve load/store improvements

2020-05-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200508154359.7494-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200508154359.7494-1-richard.hender...@linaro.org Subject: [PATCH v5 00/19] target/arm: sve

[Bug 1877716] Re: Win10 guest unsuable after a few minutes

2020-05-09 Thread Xavier
** Attachment added: "libvirt/qemu log of a 73fd272 run reproducing the issue" https://bugs.launchpad.net/qemu/+bug/1877716/+attachment/5368818/+files/win10.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1877716] Re: Win10 guest unsuable after a few minutes

2020-05-09 Thread Xavier
Note that bisecting is difficult due to the nature of the bug (does not appear before 5 to 10 minutes on my machine). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877716 Title: Win10 guest

[Bug 1877716] Re: Win10 guest unsuable after a few minutes

2020-05-09 Thread Xavier
** Attachment added: "libvirt description of the machine used to debug" https://bugs.launchpad.net/qemu/+bug/1877716/+attachment/5368819/+files/win10.xml -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1877716] [NEW] Win10 guest unsuable after a few minutes

2020-05-09 Thread Xavier
Public bug reported: On Arch Linux, the recent qemu package update seems to misbehave on some systems. In my case, my Windows 10 guest runs fine for around 5 minutes and then start to get really sluggish, even unresponsive. It needs to be forced off. I could reproduce this on a minimal VM with no

Re: [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 11:00 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Tiwei Bie > > > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > > vhost-user. The above patch provides a generic device for vDPA purpose, > > this vDPA device exposes

Re: [PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-05-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200508230823.22956-1-wall...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200508230823.22956-1-wall...@linux.ibm.com Subject: [PATCH v1 0/8] s390: Extended-Length SCCB &

Re: [PATCH V3 10/14] KVM: MIPS: Add Loongson-3 Virtual IPI interrupt support

2020-05-09 Thread Huacai Chen
Hi, Aleksandar, On Fri, May 8, 2020 at 7:23 PM Aleksandar Markovic wrote: > > нед, 3. мај 2020. у 12:14 Huacai Chen је написао/ла: > > > > This patch add Loongson-3 Virtual IPI interrupt support in the kernel, > > because emulate it in QEMU is too expensive for performance. > > > > Huacei, hi!

[Bug 1877706] Re: [Feature request] qemu does not support for Octeon MIPS64 on X86

2020-05-09 Thread Aleksandar Markovic
Probably not, but there may be a workaround. The closest cpu to Octeon that is supported in QEMU is "MIPS64R2-generic". Please try using switch -cpu MIPS64R2-generic in your QEMU command line. Also, I think you should use qemu-mipsn32 rather than qemu-mips or qemu- mips64. I don't have much

Re: [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 10:40 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Tiwei Bie > > > If you think you've done a huge refactor on the code, you can change the > author but need to keep the sob of Tiwei. > > > > > > This patch set introduces a new net client type:

Re: [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 12:42 AM Eric Blake wrote: > > On 5/8/20 11:32 AM, Cindy Lu wrote: > > From: Tiwei Bie > > > > This patch set introduces a new net client type: vhost-vdpa. > > vhost-vdpa net client will set up a vDPA device which is specified > > by a "vhostdev" parameter. > > > >

Re: [RFC v2 3/9] virtio_net: introduce vhost_set_state

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 10:25 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > Introduce a function to set the state to the vhost driver. > > vDPA need to sync the driver's state to NIC > > > Let's split this patch into two. > > 1) introduce vhost_set_state > 2) make virtio-net

Re: [RFC v2 6/9] virtio-bus: introduce queue_enabled method

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 11:02 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Jason Wang > > > > This patch introduces queue_enabled() method which allows the > > transport to implement its own way to report whether or not a queue is > > enabled. > > > > Signed-off-by:

Re: [RFC v2 8/9] vhost_net: set vq ready during start if necessary

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 11:04 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > From: Jason Wang > > > > Signed-off-by: Jason Wang > > --- > > hw/net/vhost_net.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > >

Re: [RFC v2 2/9] net: use the function qemu_get_peer

2020-05-09 Thread Cindy Lu
On Sat, May 9, 2020 at 10:20 AM Jason Wang wrote: > > > On 2020/5/9 上午12:32, Cindy Lu wrote: > > user the qemu_get_peer to replace the old process > > > The title should be "vhost_net: use the function qemu_get_peer". > > Thanks > Sure, I will fix this > > > > > Signed-off-by: Cindy Lu > > --- >

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-05-09 Thread Lockywolf
I am sorry I haven't dealt with this bug for quite a while. KDE 5 is not properly working on my distro, and I wanted to test it when it stabilises. If qemu dislikes long-standing bugs, this bug can be closed, and I'll open a new one when I have time to test it on the new KDE. -- You received

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-09 Thread Jason Wang
On 2020/5/9 上午2:13, Andrew Melnichenko wrote: Yo, I've used OpenSDM_8257x-18.pdf specification. This document was recommended by Intel guys(Also, they referenced to that note). I've made a fast fix and it works. Before that I had a fix for Linux e1000e driver. Overall, the issue was in