Re: [PATCH v4 2/5] virtio-scsi: introduce a constant for fixed virtqueues

On Wed, May 27, 2020 at 6:32 AM Stefan Hajnoczi wrote: > > The event and control virtqueues are always present, regardless of the > multi-queue configuration. Define a constant so that virtqueue number > calculations are easier to read. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Cornelia

Re: [PATCH v4 5/5] vhost-user-blk: default num_queues to -smp N

I'm happy with the code but as David pointed out with virtio-scsi, we should probably add a comment about virtio_pci_optimal_num_queues() capping the number of VQs here too. On Wed, May 27, 2020 at 6:34 AM Stefan Hajnoczi wrote: > > Automatically size the number of request virtqueues to match

[Bug 1881450] [NEW] Emulation of a math function fails for m68k Linux user mode

Public bug reported: Please check the attached math-example.c file. When running the m68k executable under QEMU, it results in an "Illegal instruction" error. Other targets don't produce this error. Steps to reproduce the bug: 1. Download the math-example.c attached file. 2. Compile it by

[Bug 1881450] Re: Emulation of a math function fails for m68k Linux user mode

** Attachment added: "math-example.c" https://bugs.launchpad.net/qemu/+bug/1881450/+attachment/5378914/+files/math-example.c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1881450 Title:

Re: [PATCH v4 2/2] vhost-user-blk: delay vhost_user_blk_disconnect

On Thu, May 28, 2020 at 5:13 AM Dima Stepanov wrote: > > A socket write during vhost-user communication may trigger a disconnect > event, calling vhost_user_blk_disconnect() and clearing all the > vhost_dev structures holding data that vhost-user functions expect to > remain valid to roll back

Re: [PATCH v3] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

On 2020/5/28 下午6:25, Laurent Vivier wrote: >> diff --git a/configure b/configure >> index e225a1e3ff..2c2c489d1e 100755 >> --- a/configure >> +++ b/configure >> @@ -3912,6 +3912,24 @@ EOF >> fi >> fi >> >> +# >> +# libdrm check >> + >> +cat > $TMPC

Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image

суб, 30. мај 2020. у 19:25 Thomas Huth је написао/ла: > > On 30/05/2020 10.54, Aleksandar Markovic wrote: > > 18:44 Pet, 15.05.2020. Thomas Huth > > је написао/ла: > >> > >> Now that we can select the second serial console in the acceptance tests > >> (see commit

Re: [PATCH 0/4] python: pylint and flake8 support

On 5/29/20 12:21 AM, John Snow wrote: > This is a quick series to delint the files under python/qemu, with one > extra fix outside of that domain. > > This was split out from my longer series attempting to package > python/qemu. This part is a nice standalone chunk. > > John Snow (4): >

Re: [PATCH v6 0/4] vhost-user block device backend implementation

Patchew URL: https://patchew.org/QEMU/20200530171441.660814-1-coiby...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH] hw/display/cirrus_vga: Fix code mis-indentation

On 29/05/2020 18.54, Philippe Mathieu-Daudé wrote: > While replacing fprintf() by qemu_log_mask() in commit > 2b55f4d3504, we incorrectly used a 'tab = 4 spaces' > alignment, leading to misindented new code. Fix now. > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- >

[Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

> Not all of those register writes are actually important for the bug, so I simplified them to the fewest writes and fewest bits. Thanks for bringing this up. I tried to trim long write commands from both "sides", but there can still be useless data in the middle. I'll work on something that can

Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image

On 30/05/2020 10.54, Aleksandar Markovic wrote: > 18:44 Pet, 15.05.2020. Thomas Huth > је написао/ла: >> >> Now that we can select the second serial console in the acceptance tests >> (see commit 746f244d9720 "Allow to use other serial consoles than > default"), >> we can

[PATCH v6 3/4] vhost-user block device backend server

By making use of libvhost-user, block device drive can be shared to the connected vhost-user client. Only one client can connect to the server one time. Since vhost-user-server needs a block drive to be created first, delay the creation of this object. Signed-off-by: Coiby Xu ---

[PATCH v6 2/4] generic vhost user server

Sharing QEMU devices via vhost-user protocol. Only one vhost-user client can connect to the server one time. Signed-off-by: Coiby Xu --- util/Makefile.objs | 1 + util/vhost-user-server.c | 404 +++ util/vhost-user-server.h | 59 ++ 3 files

[PATCH v6 1/4] Allow vu_message_read to be replaced

Allow vu_message_read to be replaced by one which will make use of the QIOChannel functions. Thus reading vhost-user message won't stall the guest. Signed-off-by: Coiby Xu --- contrib/libvhost-user/libvhost-user-glib.c | 2 +- contrib/libvhost-user/libvhost-user.c | 11 ++-

[PATCH v6 4/4] new qTest case to test the vhost-user-blk-server

This test case has the same tests as tests/virtio-blk-test.c except for tests have block_resize. Since vhost-user server can only server one client one time, two instances of qemu-storage-daemon are launched for the hotplug test. In order to not block scripts/tap-driver.pl, vhost-user-blk-server

[PATCH v6 0/4] vhost-user block device backend implementation

v6 - add missing license header and include guard - vhost-user server only serve one client one time - a bug fix in custom vu_message_read - using qemu-storage-daemon to start vhost-user-blk-server - a bug fix to pass docker-test-clang@ubuntu Coiby Xu (4): Allow vu_message_read to be

[Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

Forgot to mention: 4. the last write to PxSCTL is what actually causes the reset by clearing the DET bit that was armed. In response to Philippe: Yes, if you had a malicious kernel or root access to the guest, you could emit a sequence of PIO and memory write operations to trip this. Even the

[PATCH] migration/vmstate: Remove unnecessary MemoryRegion forward declaration

"migration/vmstate.h" only uses pointer to MemoryRegion, which is already forward declared in "qemu/typedefs.h". Signed-off-by: Philippe Mathieu-Daudé --- CI: https://travis-ci.org/github/philmd/qemu/builds/692879495 --- include/migration/vmstate.h | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v4] hw/net/imx_fec: Convert debug fprintf() to trace events

From: Jean-Christophe Dubois Signed-off-by: Jean-Christophe Dubois Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200530102707.195131-1-...@tribudubois.net> [PMD: Fixed 32-bit format string using PRIx32/PRIx64] Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3] hw/net/imx_fec.c: Convert debug fprintf() to trace event

On 5/30/20 12:27 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > v2: fix coding style issues. > v3: improve tracing code based on feedback > * change some tracing function names > * remove unnecessary cast > * add register index in addition to

Re: 5.1 proposed schedule

On Sat, 30 May 2020 at 09:03, Aleksandar Markovic wrote: > I really like "Tuesdays" concept. It worked very well for me as a > submaintainer. I don't > know its origin, but it works, bringing some degree of order and > predictability, and at the > same seemingly not imposing larger than

[PATCH v3] hw/net/imx_fec.c: Convert debug fprintf() to trace event

Signed-off-by: Jean-Christophe Dubois --- v2: fix coding style issues. v3: improve tracing code based on feedback * change some tracing function names * remove unnecessary cast * add register index in addition to name hw/net/imx_fec.c| 106

Re: [PATCH] hw/net/imx_fec.c: Convert debug fprintf() to trace event

Le 30/05/2020 à 09:49, Philippe Mathieu-Daudé a écrit : Hi Jean-Christophe, On 5/29/20 8:00 PM, Jean-Christophe Dubois wrote: Signed-off-by: Jean-Christophe Dubois --- hw/net/imx_fec.c| 101 ++-- hw/net/trace-events | 18 2 files

Re: [Libguestfs] Provide NBD via Browser over Websockets

On Fri, May 29, 2020 at 09:08:29PM +, Eric Wheeler wrote: > On Fri, 29 May 2020, Richard W.M. Jones wrote: > > On Fri, May 29, 2020 at 08:58:06AM -0500, Eric Blake wrote: > > > On 5/29/20 8:50 AM, Daniel P. Berrangé wrote: > > > > > > >>>(2) You need to persuade qemu's NBD client to read

[PATCH 2/5] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h'

Extract timer definitions to 'hw/timer/tmu012.h'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200504081653.14841-3-f4...@amsat.org> --- include/hw/sh4/sh.h | 9 - include/hw/timer/tmu012.h | 23 +++ hw/sh4/sh7750.c

[PATCH 4/5] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image

From: Thomas Huth Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. Signed-off-by: Thomas Huth Reviewed-by: Philippe

[PATCH 5/5] .travis.yml: Test SH4 QEMU advent calendar image

From: Thomas Huth Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. Signed-off-by: Thomas Huth Reviewed-by: Philippe

[PATCH 3/5] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include

Remove unused "qemu/timer.h" include. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200504081653.14841-4-f4...@amsat.org> --- hw/timer/sh_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/timer/sh_timer.c b/hw/timer/sh_timer.c index

[PATCH 0/5] hw/sh4: current patch queue

Hi, As there is no SH4 active maintainer, I gathered various patches in a single series, in case someone is willing to apply them. CI report: https://travis-ci.org/github/philmd/qemu/builds/692828388 Regards, Phil. Philippe Mathieu-Daudé (3): hw/sh4: Use MemoryRegion typedef hw/sh4:

[PATCH 1/5] hw/sh4: Use MemoryRegion typedef

Use the MemoryRegion type defined in "qemu/typedefs.h", to keep the repository style consistent. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200504081653.14841-2-f4...@amsat.org> --- include/hw/sh4/sh.h | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH] target/arm/cpu: adjust virtual time for cortex series cpu

Virtual time adjustment was implemented for virt-5.0 machine type, but the cpu property was enabled only for host-passthrough and max cpu model. Let's add it for arm cortex series cpu which has the gernic timer feature enabled. Signed-off-by: Ying Fang diff --git a/target/arm/cpu.c

About the kvm-no-adjvtime CPU property

About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu property kvm-no-adjvtime was introduced to 5.0 virt machine types. However the cpu property was enabled only for host-passthrough and max cpu model. As for other cpu model like cortex-a57, cortex-a53,

Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image

18:44 Pet, 15.05.2020. Thomas Huth је написао/ла: > > Now that we can select the second serial console in the acceptance tests > (see commit 746f244d9720 "Allow to use other serial consoles than default"), > we can also test the sh4 image from the QEMU advent calendar 2018. > > Signed-off-by:

[PATCH v2] hw/net/imx_fec.c: Convert debug fprintf() to trace event

Signed-off-by: Jean-Christophe Dubois --- v2: fix coding style issues. hw/net/imx_fec.c| 101 ++-- hw/net/trace-events | 18 2 files changed, 58 insertions(+), 61 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index

Re: [PATCH] qemu-img: Fix doc typo for 'bitmap' subcommand

29.05.2020 17:45, Eric Blake wrote: Prefer a consistent naming for the --merge argument. Fixes: 3b51ab4bf Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: 5.1 proposed schedule

16:36 Pet, 29.05.2020. Peter Maydell је написао/ла: > > On Tue, 26 May 2020 at 11:07, Peter Maydell wrote: > > > > Here's a draft schedule for 5.1: > > > > 2019-07-06: softfreeze > > this should have read 2020-07-07 (Tuesday)... > I really like "Tuesdays" concept. It worked very well for me as

Re: [PATCH] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image

On 5/15/20 6:43 PM, Thomas Huth wrote: > Now that we can select the second serial console in the acceptance tests > (see commit 746f244d9720 "Allow to use other serial consoles than default"), > we can also test the sh4 image from the QEMU advent calendar 2018. > > Signed-off-by: Thomas Huth

Re: [PATCH v2 54/58] qdev: Make qdev_realize() support bus-less devices

On 5/29/20 3:45 PM, Markus Armbruster wrote: > So far, qdev_realize() supports only devices that plug into a bus: > argument @bus cannot be null. Extend it to support bus-less devices, > too. > > Signed-off-by: Markus Armbruster > --- > hw/core/qdev.c | 9 ++--- > 1 file changed, 6

Re: [PATCH v2 58/58] MAINTAINERS: Make section QOM cover hw/core/*bus.c as well

On 5/29/20 3:45 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bb9861f33b..e6957dac1a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2279,6 +2279,8 @@ R:

[PULL 1/2] hw/m68k/mcf5206: Reduce m5206_mbar_read/write() offset arg to 16-bit

From: Philippe Mathieu-Daudé All calls to m5206_mbar_read/m5206_mbar_write are used with 'offset = hwaddr & 0x3ff', so we are sure the offset fits in 16-bit. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200526094052.1723-2-f4...@amsat.org> Signed-off-by:

[PULL 0/2] m68k coldfire machine cleanup patches

Hi Peter, the following changes since commit c86274bc2e34295764fb44c2aef3cf29623f9b4b: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-tcg-plugins-270520-1' into staging (2020-05-29 17:41:45 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git

[PULL 2/2] hw/m68k/mcf52xx: Replace hw_error() by qemu_log_mask()

From: Philippe Mathieu-Daudé hw_error() calls exit(). This a bit overkill when we can log the accesses as unimplemented or guest error. When fuzzing the devices, we don't want the whole process to exit. Replace some hw_error() calls by qemu_log_mask(). Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 01/58] qdev: Rename qbus_realize() to qbus_init()

On 5/29/20 3:44 PM, Markus Armbruster wrote: > qbus_realize() does not actually realize. Rename it to qbus_init(). > > Signed-off-by: Markus Armbruster > --- > hw/core/bus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/net/imx_fec.c: Convert debug fprintf() to trace event

Hi Jean-Christophe, On 5/29/20 8:00 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > hw/net/imx_fec.c| 101 ++-- > hw/net/trace-events | 18 > 2 files changed, 58 insertions(+), 61 deletions(-) > > diff

Re: [Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

On 5/30/20 12:59 AM, John Snow wrote: > outl 0xcf8 0x8000fa24 > outl 0xcfc 0xe106c000 (Writes e106c00 to BAR5 for 0:31:2) We might eventually display this in the reproducer output. > > outl 0xcf8 0x8000fa04 > outw 0xcfc 0x7 (Enables BM, Memory IO and PIO for 0:31:2) > > outl 0xcf8 0x8000fb20

Re: [PATCH] acpi: tpm: Do not build TCPA table for TPM 2

Hi Stefan On 5/30/20 12:23 AM, Stefan Berger wrote: > On 5/29/20 3:28 PM, Stefan Berger wrote: >> From: Stefan Berger >> >> Do not build a TCPA table for TPM 2 anymore but create the log area when >> building the TPM2 table. The TCPA table is only needed for TPM 1.2. Now I understand the

Re: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus

Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-arm...@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the