Re: [PATCH v5 3/9] hw/misc/pca9552: Rename generic code as pca955x

On 6/22/20 8:34 PM, Philippe Mathieu-Daudé wrote: > Various code from the PCA9552 device model is generic to the > PCA955X family. We'll split the generic code in a base class > in the next commit. To ease review, first do a dumb renaming. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH v5 2/9] hw/misc/pca9552: Rename 'nr_leds' as 'pin_count'

On 6/22/20 8:34 PM, Philippe Mathieu-Daudé wrote: > The PCA9552 device does not expose LEDs, but simple pins > to connnect LEDs to. To be clearer with the device model, > rename 'nr_leds' as 'pin_count'. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater > --- >

Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to users and clean up

On 2020/6/23 上午9:47, Zhang, Chen wrote: -Original Message- From: Lukas Straub Sent: Saturday, June 20, 2020 1:47 AM To: Jason Wang Cc: Zhang, Chen ; qemu-dev ; Zhang Chen Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to users and clean up On Fri, 24 Apr

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

On Mon, Jun 22, 2020 at 11:34 PM Corey Minyard wrote: > On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > > These functions have a parameter that decides the direction of > > transfer but totally confusingly they don't match but inverted sense. > > To avoid frequent mistakes when

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

On Tue, Jun 23, 2020 at 7:15 AM Philippe Mathieu-Daudé wrote: > On 6/23/20 4:06 AM, Corey Minyard wrote: > > On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: > >> On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > >>> These functions have a parameter that decides the

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

On 6/23/20 4:06 AM, Corey Minyard wrote: > On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: >> On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: >>> These functions have a parameter that decides the direction of >>> transfer but totally confusingly they don't match but

[PATCH v3] target/ppc: add vmsumudm vmsumcud instructions

vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo VA-form. vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned Doubleword VA-form. Signed-off-by: Lijun Pan --- v3: implement vmsumudm/vmsumcud through int128 functions, suggested by Richard

Re: [PATCH 4/5] linux-user: Support CLONE_VM and extended clone options

Thanks for the responses Alex. I'm working on your comments, but wanted to clarify some of the points you brought up before mailing a second version. Responses inline. On Tue, Jun 16, 2020 at 9:08 AM Alex Bennée wrote: > Which by the way fail on some targets: > > TESTlinux-test on alpha

Re: sysbus failed assert for xen_sysdev

On Mon, Jun 22, 2020 at 5:17 PM Mark Cave-Ayland wrote: > > On 22/06/2020 21:33, Jason Andryuk wrote: > > > Hi, > > > > Running qemu devel for a Xen VM is failing an assert after the recent > > "qdev: Rework how we plug into the parent bus" sysbus changes. > > > > qemu-system-i386:

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

On Mon, Jun 22, 2020 at 04:32:37PM -0500, Corey Minyard wrote: > On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > > These functions have a parameter that decides the direction of > > transfer but totally confusingly they don't match but inverted sense. > > To avoid frequent

Re: [PATCH] tests/qht-bench: Adjust rate computation and comparisons

Cc'ing Philippe, who authored the fix for this in May as I mention below. Emilio On Sun, Jun 21, 2020 at 17:28:25 -0400, Emilio G. Cota wrote: > On Sat, Jun 20, 2020 at 14:45:51 -0700, Richard Henderson wrote: > > Use <= comparisons vs the threshold, so that threshold UINT64_MAX

Re: [PATCH v2 3/6] cputlb: ensure we save the IOTLB data in case of reset

On Mon, Jun 22, 2020 at 10:02:50 +0100, Alex Bennée wrote: > Emilio G. Cota writes: > > On Wed, Jun 10, 2020 at 16:55:06 +0100, Alex Bennée wrote: (snip) > >> +#ifdef CONFIG_PLUGIN > >> + > >> +typedef struct SavedIOTLB { > >> +struct rcu_head rcu; > >> +struct SavedIOTLB **save_loc; > >>

RE: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to users and clean up

> -Original Message- > From: Lukas Straub > Sent: Saturday, June 20, 2020 1:47 AM > To: Jason Wang > Cc: Zhang, Chen ; qemu-dev de...@nongnu.org>; Zhang Chen > Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to > users and clean up > > On Fri, 24 Apr 2020

[Bug 1884693] [NEW] Assertion failure in address_space_unmap through ahci_map_clb_address

Public bug reported: Hello, Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 -qtest stdio -monitor none -serial none -M pc-q35-5.0 -nographic outl 0xcf8 0x8000fa24 outl 0xcfc 0xe1068000 outl 0xcf8 0x8000fa04 outw 0xcfc 0x7 outl 0xcf8 0x8000fb20 write 0xe1068304 0x1 0x21 write 0xe1068318

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.200623340.24...@digraph.polyomino.org.uk/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.200623340.24...@digraph.polyomino.org.uk/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.200623340.24...@digraph.polyomino.org.uk/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

[Bug 1884684] [NEW] QEMU 5.0: Guest VM hangs/freeze when unplugging USB device

Public bug reported: Setup: Host: Debian/SID, Kernel 5.6, QEMU 5.0 Guest: Windows 10 VM with PCI and USB device passthrough. Problem: Guest VM suddenly hangs when pulling USB device out from the Host. Observations: - Issue appears to be related to QEMU 5.0 - It started after an upgrade to

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

On 23/06/20 02:01, Joseph Myers wrote: > The x87 fpatan emulation is currently based around conversion to > double. This is inherently unsuitable for a good emulation of any > floatx80 operation. Reimplement using the soft-float operations, as > for other such instructions. > > Signed-off-by:

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

On 23/06/20 02:01, Joseph Myers wrote: > The x87 fpatan emulation is currently based around conversion to > double. This is inherently unsuitable for a good emulation of any > floatx80 operation. Reimplement using the soft-float operations, as > for other such instructions. > > Signed-off-by:

[PATCH v2] target/i386: reimplement fpatan using floatx80 operations

The x87 fpatan emulation is currently based around conversion to double. This is inherently unsuitable for a good emulation of any floatx80 operation. Reimplement using the soft-float operations, as for other such instructions. Signed-off-by: Joseph Myers --- Changes in version 2: adjust the

[PATCH v2] Stop vhost-user sending uninitialized mmap_offsets

Prior to this change, the vhost_user_fill_msg_region function filled out all elements of the VhostUserMemoryRegion struct except the mmap_offset. This function is often called on uninitialized structs, which are then copied into VHOST_USER_SET_MEM_TABLE and VHOST_USER_ADD/REM_MEM_REG messages. In

Re: [PATCH 7/7] hw/watchdog/wdt_aspeed: Reduce timer precision to micro-second

On Mon, 22 Jun 2020, at 18:13, Philippe Mathieu-Daudé wrote: > On 6/22/20 2:21 AM, Andrew Jeffery wrote: > > On Wed, 17 Jun 2020, at 13:11, Philippe Mathieu-Daudé wrote: > >> Hi Andrew, > >> > >> On 6/17/20 3:18 AM, Andrew Jeffery wrote: > >>> On Tue, 16 Jun 2020, at 17:21, Philippe

Re: [PATCH v3 9/9] sm501: Fix and optimize overlap check

On Mon, 22 Jun 2020, Peter Maydell wrote: > On Sat, 20 Jun 2020 at 22:04, BALATON Zoltan wrote: >> >> When doing reverse blit we need to check if source and dest overlap >> but it is not trivial due to possible different base and pitch of >> source and dest. Do rectangle overlap if base and pitch

Re: [PATCH v2] target/arm: Check supported KVM features globally (not per vCPU)

On 19/06/20 11:55, Philippe Mathieu-Daudé wrote: > Since commit d70c996df23f, when enabling the PMU we get: > > $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3 > Segmentation fault (core dumped) > > Thread 1 "qemu-system-aar" received signal SIGSEGV, Segmentation

Re: [PATCH v2] target/arm: Check supported KVM features globally (not per vCPU)

On 19/06/20 14:02, Dr. David Alan Gilbert wrote: >> Paolo, does this break migration of encrypted memory assumptions? >> >> Cc: Dr. David Alan Gilbert >> Supersedes: <20200617130800.26355-1-phi...@redhat.com> > I'm not seeing the relevance to migration. I told Philippe that there could be a

Re: [PATCH QEMU v25 07/17] vfio: Register SaveVMHandlers for VFIO device

On Sun, 21 Jun 2020 01:51:16 +0530 Kirti Wankhede wrote: > Define flags to be used as delimeter in migration file stream. > Added .save_setup and .save_cleanup functions. Mapped & unmapped migration > region from these functions at source during saving or pre-copy phase. > Set VFIO device state

Re: [PATCH QEMU v25 08/17] vfio: Add save state functions to SaveVMHandlers

On Sun, 21 Jun 2020 01:51:17 +0530 Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If

Re: [PATCH QEMU v25 05/17] vfio: Add VM state change handler to know state of VM

On Sun, 21 Jun 2020 01:51:14 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [PATCH 1/2] virtio-balloon: Prevent guest from starting a report when we didn't request one

On Mon, Jun 22, 2020 at 1:10 AM David Hildenbrand wrote: > > On 19.06.20 23:53, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Based on code review it appears possible for the driver to force the device > > out of a stopped state when hinting by repeating the last ID it was > >

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

On 5/5/20 10:30 AM, Eric Blake wrote: On 5/5/20 2:35 AM, Kevin Wolf wrote: Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: qcow has no space in the metadata to store a backing format, and there are existing qcow images backed both by raw or by other formats (usually qcow) images, reliant on

Re: [PATCH v3 2/6] blockdev: combine DriveBackupState and BlockdevBackupState

On 6/22/20 12:12 AM, Vladimir Sementsov-Ogievskiy wrote: 19.06.2020 22:56, Eric Blake wrote: From: John Snow They have the same fields -- rename it BlockJobActionState. commit/abort/clean functions are identical after it. I think better to combine them as well here I'll give it a shot in

Re: [PATCH v3 1/6] block: add bitmap-populate job

On 6/19/20 11:16 PM, Vladimir Sementsov-Ogievskiy wrote: 19.06.2020 22:56, Eric Blake wrote: From: John Snow This job copies the allocation map into a bitmap. It's a job because there's no guarantee that allocation interrogation will be quick (or won't hang), so it cannot be retrofitted into

Re: [PATCH v2 0/7] riscv: Switch to use generic platform of opensbi bios images

On Mon, Jun 22, 2020 at 5:27 AM Bin Meng wrote: > > Hi Anup, > > On Mon, Jun 22, 2020 at 8:20 PM Anup Patel wrote: > > > > > > > > > -Original Message- > > > From: Bin Meng > > > Sent: 22 June 2020 17:43 > > > To: Anup Patel > > > Cc: Alistair Francis ; Bastian Koppelmann > > > ;

Re: [PATCH v2 2/7] roms/opensbi: Upgrade from v0.7 to v0.8

On Sun, Jun 21, 2020 at 11:37 PM Bin Meng wrote: > > From: Bin Meng > > Upgrade OpenSBI from v0.7 to v0.8. > > The v0.8 release includes the following commits: > > 1bb00ab lib: No need to provide default PMP region using platform callbacks > a9eac67 include: sbi_platform: Combine reboot and

Re: [PATCH 18/22] riscv/sifive_u: Fix sifive_u_soc_realize() error API violations

On Mon, Jun 22, 2020 at 3:55 AM Markus Armbruster wrote: > > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer

Re: [PATCH] i2c: Match parameters of i2c_start_transfer and i2c_send_recv

On Sun, Jun 21, 2020 at 04:43:38PM +0200, BALATON Zoltan wrote: > These functions have a parameter that decides the direction of > transfer but totally confusingly they don't match but inverted sense. > To avoid frequent mistakes when using these functions change > i2c_send_recv to match

Re: [PATCH 16/22] hw: Fix error API violation around object_property_set_link()

On Mon, Jun 22, 2020 at 3:53 AM Markus Armbruster wrote: > > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer

Re: [PATCH] Stop vhost-user sending uninitialized mmap_offsets

On Mon, Jun 22, 2020 at 06:41:39PM +, Raphael Norwitz wrote: > Prior to this change, the vhost_user_fill_msg_region function filled out > all elements of the VhostUserMemoryRegion struct except the mmap_offset. > > This function is often called on uninitialized structs, which are then >

Re: [PATCH 02/22] pci: Delete useless error_propagate()

On Mon, Jun 22, 2020 at 12:42:30PM +0200, Markus Armbruster wrote: Cc: Jens Freimann Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster --- hw/pci/pci.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Jens Freimann Thanks! regards, Jens

Re: [PATCH 19/22] riscv_hart: Fix riscv_harts_realize() error API violations

On Mon, Jun 22, 2020 at 3:51 AM Markus Armbruster wrote: > > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer

Re: [PATCH 01/22] net/virtio: Fix failover_replug_primary() return value regression

On Mon, Jun 22, 2020 at 12:42:29PM +0200, Markus Armbruster wrote: Commit 150ab54aa6 "net/virtio: fix re-plugging of primary device" fixed failover_replug_primary() to return false on failure. Commit 5a0948d36c "net/virtio: Fix failover error handling crash bugs" broke it again for

Re: sysbus failed assert for xen_sysdev

On 22/06/2020 21:33, Jason Andryuk wrote: > Hi, > > Running qemu devel for a Xen VM is failing an assert after the recent > "qdev: Rework how we plug into the parent bus" sysbus changes. > > qemu-system-i386: hw/core/qdev.c:102: qdev_set_parent_bus: Assertion > `dc->bus_type &&

[PATCH] nbd: Avoid off-by-one in long export name truncation

When snprintf returns the same value as the buffer size, the final byte was truncated to ensure a NUL terminator. Fortunately, such long export names are unusual enough, with no real impact other than what is displayed to the user. Fixes: 5c86bdf12089 Reported-by: Max Reitz Signed-off-by: Eric

Re: [PATCH v5 1/9] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()

On Mon, Jun 22, 2020 at 08:34:20PM +0200, Philippe Mathieu-Daudé wrote: > Extract i2c_try_create_slave() and i2c_realize_and_unref() > from i2c_create_slave(). > We can now set properties on a I2CSlave before it is realized. > > This is in line with the recent qdev/QOM changes merged > in commit

sysbus failed assert for xen_sysdev

Hi, Running qemu devel for a Xen VM is failing an assert after the recent "qdev: Rework how we plug into the parent bus" sysbus changes. qemu-system-i386: hw/core/qdev.c:102: qdev_set_parent_bus: Assertion `dc->bus_type && object_dynamic_cast(OBJECT(bus), dc->bus_type)' failed. dc->bus_type is

Re: [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

Quoting Finn Thain (2020-06-19 22:39:41) > On Sat, 20 Jun 2020, Finn Thain wrote: > > > > > Thanks for picking these fixes. When the maintainer originally merged this > > series of patches, the first patch got slightly damaged. This was remedied > > in a subsequent patch[1]. That is, mainline

Re: [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

Quoting Michael Roth (2020-06-16 09:14:29) > Hi everyone, > > The following new patches are queued for QEMU stable v4.2.1: > > https://github.com/mdroth/qemu/commits/stable-4.2-staging > > The release is planned for 2020-06-25: > > https://wiki.qemu.org/Planning/4.2 > > Due to delays on

Re: [PATCH QEMU v25 03/17] vfio: Add save and load functions for VFIO PCI devices

On Sun, 21 Jun 2020 01:51:12 +0530 Kirti Wankhede wrote: > These functions save and restore PCI device specific data - config > space of PCI device. > Tested save and restore with MSI and MSIX type. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/pci.c

Re: [PATCH v2] target/arm: Check supported KVM features globally (not per vCPU)

On Mon, Jun 22, 2020 at 08:57:51PM +0100, Peter Maydell wrote: > On Fri, 19 Jun 2020 at 12:41, Andrew Jones wrote: > > Can you also post the attached patch with this one (a two patch series)? > > This would be easier to review if you'd just posted it as > a patch with a Based-on: and a note that

Re: [PATCH v2] target/arm: Check supported KVM features globally (not per vCPU)

On Fri, 19 Jun 2020 at 12:41, Andrew Jones wrote: > Can you also post the attached patch with this one (a two patch series)? This would be easier to review if you'd just posted it as a patch with a Based-on: and a note that it needed to be applied after the bugfix patch. Anyway: +/*

Re: [PULL 00/15] Renesas hardware patches for 2020-06-21

понедељак, 22. јун 2020., Philippe Mathieu-Daudé је написао/ла: > Hi Aleksandar, > > On 6/22/20 7:30 PM, Aleksandar Markovic wrote: > > понедељак, 22. јун 2020., Aleksandar Markovic > > > > је написао/ла: > > > > > > > > понедељак, 22. јун 2020.,

Re: make test failure for iotest 267 on qemu-system-sparc64

On 22/06/2020 10:25, Thomas Huth wrote: >> After a recent rebase I've started seeing iotest 267 after running "make >> check" on >> qemu-system-sparc64. The diff output looks similar to this: >> >> --- /home/build/src/qemu/git/qemu/tests/qemu-iotests/267.out2020-01-22 >> 17:57:54.246650995

Re: [PATCH v3 9/9] sm501: Fix and optimize overlap check

On Sat, 20 Jun 2020 at 22:04, BALATON Zoltan wrote: > > When doing reverse blit we need to check if source and dest overlap > but it is not trivial due to possible different base and pitch of > source and dest. Do rectangle overlap if base and pitch match, > otherwise just check if memory area

Re: [PULL 00/18] Block patches

Patchew URL: https://patchew.org/QEMU/20200622151059.921191-1-mre...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/18] Block patches Type: series Message-id: 20200622151059.921191-1-mre...@redhat.com === TEST

[PULL v2 13/15] hw/rx: Add RX GDB simulator

From: Yoshinori Sato Add the RX machine internally simulated in GDB. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson [PMD: Use TYPE_RX62N_CPU, use #define for RX62N_NR_TMR/CMT/SCI, renamed CPU -> MCU,

[PULL v2 00/15] Renesas hardware patches for 2020-06-22

-hw-20200622 for you to fetch changes up to 4adbfa45cc3793fa85157a4813306618f6009f52: docs: Document the RX target (2020-06-22 18:37:12 +0200) Since v1: - Fixed format-string issue on 32-bit platforms - Add a common entry

Re: [PULL 00/15] Renesas hardware patches for 2020-06-21

Hi Aleksandar, On 6/22/20 7:30 PM, Aleksandar Markovic wrote: > понедељак, 22. јун 2020., Aleksandar Markovic > > је написао/ла: > > > > понедељак, 22. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > >

Re: [PATCH v3 00/25] risu cleanups and improvements

Just a note that I'm assuming this is still on Alex's plate to review. Ping me if it gets reviews and is ready to apply. thanks -- PMM On Fri, 22 May 2020 at 03:35, Richard Henderson wrote: > > Version 3 changes the --dump option to --fulldump and --diffdump, > after an off-hand suggestion by

Re: [PULL v2 39/58] Transmit vhost-user memory regions individually

On Fri, Jun 19, 2020 at 6:03 AM Peter Maydell wrote: > > > As noted in my other email, I think the best fix for this is to > have vhost_user_fill_msg_region() take an extra mmap_offset > argument to fill in the mmap_offset itself. In this callsite in > send_add_regions() we would pass in 'offset'

Re: [PATCH 1/2] qcow2: Force preallocation with data-file-raw

On 6/22/20 10:48 AM, Max Reitz wrote: As I noted in my reply to myself, data-file-raw is an autoclear flag. That means, an old version of qemu that doesn’t recognize the flag must read the same data as a new version. It follows that the the L2 tables must be a 1:1 mapping. (Or the flag can’t

[PATCH] Stop vhost-user sending uninitialized mmap_offsets

Prior to this change, the vhost_user_fill_msg_region function filled out all elements of the VhostUserMemoryRegion struct except the mmap_offset. This function is often called on uninitialized structs, which are then copied into VHOST_USER_SET_MEM_TABLE and VHOST_USER_ADD/REM_MEM_REG messages. In

[PATCH v5 7/9] hw/arm/aspeed: Describe each PCA9552 device

We have 2 distinct PCA9552 devices. Set their description to distinguish them when looking at the trace events. Description name taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Signed-off-by: Philippe Mathieu-Daudé --- Cc: Markus Armbruster ---

Re: [PATCH v3 1/2] util: Introduce qemu_get_host_name()

On 6/22/20 8:19 PM, Michal Privoznik wrote: > This function offers operating system agnostic way to fetch host > name. It is implemented for both POSIX-like and Windows systems. > > Signed-off-by: Michal Privoznik Thanks for the updates! Reviewed-by: Philippe Mathieu-Daudé > --- >

[PATCH v5 4/9] hw/misc/pca9552: Add generic PCA955xClass, parent of TYPE_PCA9552

Extract the code common to the PCA955x family in PCA955xClass, keeping the PCA9552 specific parts into pca9552_class_init(). Remove the 'TODO' comment added in commit 5141d4158cf. Suggested-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 6 ++--

[PATCH v5 9/9] hw/misc/pca9552: Model qdev output GPIOs

The PCA9552 has 16 GPIOs which can be used as input, output or PWM mode. QEMU models the output GPIO with the qemu_irq type. Let the device expose the 16 GPIOs to allow us to later connect LEDs to these outputs. Reviewed-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v5 6/9] hw/misc/pca9552: Trace GPIO High/Low events

Add a trivial representation of the PCA9552 GPIOs. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca955x_gpio_status 1592689902.327837:pca955x_gpio_status pca-unspecified GPIOs 0-15 [*...] 1592689902.329934:pca955x_gpio_status pca-unspecified

[PATCH v5 2/9] hw/misc/pca9552: Rename 'nr_leds' as 'pin_count'

The PCA9552 device does not expose LEDs, but simple pins to connnect LEDs to. To be clearer with the device model, rename 'nr_leds' as 'pin_count'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 2 +- hw/misc/pca9552.c | 10 +- 2 files changed, 6

[PATCH v5 5/9] hw/misc/pca9552: Add a 'description' property for debugging purpose

Add a description field to distinguish between multiple devices. Reviewed-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 1 + hw/misc/pca9552.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/hw/misc/pca9552.h

[PATCH v5 3/9] hw/misc/pca9552: Rename generic code as pca955x

Various code from the PCA9552 device model is generic to the PCA955X family. We'll split the generic code in a base class in the next commit. To ease review, first do a dumb renaming. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/pca9552.h | 10 ++--- hw/misc/pca9552.c | 80

[PATCH v5 8/9] hw/misc/pca9552: Trace GPIO change events

Emit a trace event when a GPIO change its state. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca955x_gpio_change 1592690552.687372:pca955x_gpio_change pca1 GPIO id:0 status: 0 -> 1 1592690552.690169:pca955x_gpio_change pca1 GPIO id:1 status: 0 -> 1

[PATCH v5 0/9] hw/misc/pca9552: Trace GPIO change events

This series add trace events to better display GPIO changes. We'll continue in the following series by connecting LEDs to these GPIOs. This helps me to work on a generic LED device, see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg711917.html Since v4: Addressed Cédric review comments

[PATCH v5 1/9] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()

Extract i2c_try_create_slave() and i2c_realize_and_unref() from i2c_create_slave(). We can now set properties on a I2CSlave before it is realized. This is in line with the recent qdev/QOM changes merged in commit 6675a653d2e. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Markus Armbruster ---

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

+Alex On 6/22/20 8:08 PM, John Snow wrote: > On 6/22/20 1:55 PM, Philippe Mathieu-Daudé wrote: >> On 6/22/20 7:51 PM, John Snow wrote: >>> >>> >>> On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: Still doesn't work... https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 >>>

Re: [PATCH RFC 2/3] gitlab: build all container images during CI

Daniel P. Berrangé writes: > We have a number of container images in tests/docker/dockerfiles > that are intended to provide well defined environments for doing > test builds. We want our CI system to use these containers too. > > This introduces builds of all of them as the first stage in the

[PATCH v3] nvme: allow cmb and pmr emulation on same device

Hi All, Resending series recently posted on mailing list related to nvme device extension with couple of fixes after review. This patch series does following: - Fixes problem where CMBS bit was not set in controller capabilities register, so support for CMB was not correctly advertised to

[PATCH v3 2/2] nvme: allow cmb and pmr to be enabled on same device

So far it was not possible to have CMB and PMR emulated on the same device, because BAR2 was used exclusively either of PMR or CMB. This patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. Signed-off-by: Andrzej Jakowski --- hw/block/nvme.c | 119

[PATCH v3 1/2] nvme: indicate CMB support through controller capabilities register

This patch sets CMBS bit in controller capabilities register when user configures NVMe driver with CMB support, so capabilites are correctly reported to guest OS. Signed-off-by: Andrzej Jakowski Reviewed-by: Klaus Jensen --- hw/block/nvme.c | 2 +- include/block/nvme.h | 6 +- 2 files

Re: [PATCH v1 01/18] iotests: Fix 051 output after qdev_init_nofail() removal

John Snow writes: > On 6/22/20 10:31 AM, Alex Bennée wrote: >> From: Philippe Mathieu-Daudé >> >> Commit 96927c744 replaced qdev_init_nofail() call by >> isa_realize_and_unref() which has a different error >> message. Update the test output accordingly. >> >> Gitlab CI error after merging

[PATCH v3 0/2] qga: Ditch g_get_host_name()

v3 of: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html diff to v2: - don't leak @hostname in util/oslib-posix.c:qemu_get_host_name() - document why we are allocating one byte more than needed - switch to g_new0() from g_malloc0(). Michal Privoznik (2): util: Introduce

[PATCH v3 2/2] qga: Use qemu_get_host_name() instead of g_get_host_name()

Problem with g_get_host_name() is that on the first call it saves the hostname into a global variable and from then on, every subsequent call returns the saved hostname. Even if the hostname changes. This doesn't play nicely with guest agent, because if the hostname is acquired before the guest is

[PATCH v3 1/2] util: Introduce qemu_get_host_name()

This function offers operating system agnostic way to fetch host name. It is implemented for both POSIX-like and Windows systems. Signed-off-by: Michal Privoznik --- include/qemu/osdep.h | 10 ++ util/oslib-posix.c | 35 +++ util/oslib-win32.c | 13

Re: [PATCH] qemu-img convert: Don't pre-zero images

On 6/22/20 10:12 AM, Kevin Wolf wrote: Since commit 5a37b60a61c, qemu-img create will pre-zero the target image if it isn't already zero-initialised (most importantly, for host block devices, but also iscsi etc.), so that writing explicit zeros wouldn't be necessary later. This could speed up

Re: [PATCH 7/6] block/io: improve loadvm performance

22.06.2020 20:17, Denis V. Lunev wrote: On 6/22/20 8:02 PM, Vladimir Sementsov-Ogievskiy wrote: 22.06.2020 11:33, Denis V. Lunev wrote: This patch creates intermediate buffer for reading from block driver state and performs read-ahead to this buffer. Snapshot code performs reads sequentially

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

On 6/22/20 1:55 PM, Philippe Mathieu-Daudé wrote: > On 6/22/20 7:51 PM, John Snow wrote: >> >> >> On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: >>> Still doesn't work... >>> https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 >> >> I tried running from master with just these

Re: [PATCH v1 01/18] iotests: Fix 051 output after qdev_init_nofail() removal

On 6/22/20 7:52 PM, John Snow wrote: > > > On 6/22/20 10:31 AM, Alex Bennée wrote: >> From: Philippe Mathieu-Daudé >> >> Commit 96927c744 replaced qdev_init_nofail() call by >> isa_realize_and_unref() which has a different error >> message. Update the test output accordingly. >> >> Gitlab CI

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

On 6/22/20 7:51 PM, John Snow wrote: > > > On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: >> Still doesn't work... >> https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 > > I tried running from master with just these patches applied. So far, the > only failures I am seeing on

Re: [PATCH v2 1/2] util: Introduce qemu_get_host_name()

On Mon, Jun 22, 2020 at 07:53:40PM +0200, Michal Privoznik wrote: > On 6/22/20 7:38 PM, Daniel P. Berrangé wrote: > > On Mon, Jun 22, 2020 at 07:26:44PM +0200, Michal Privoznik wrote: > > > This function offers operating system agnostic way to fetch host > > > name. It is implemented for both

Re: [PATCH v2 1/2] util: Introduce qemu_get_host_name()

On 6/22/20 7:38 PM, Daniel P. Berrangé wrote: On Mon, Jun 22, 2020 at 07:26:44PM +0200, Michal Privoznik wrote: This function offers operating system agnostic way to fetch host name. It is implemented for both POSIX-like and Windows systems. Signed-off-by: Michal Privoznik ---

Re: [PATCH v1 01/18] iotests: Fix 051 output after qdev_init_nofail() removal

On 6/22/20 10:31 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Commit 96927c744 replaced qdev_init_nofail() call by > isa_realize_and_unref() which has a different error > message. Update the test output accordingly. > > Gitlab CI error after merging b77b5b3dc7: >

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: > Still doesn't work... > https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 I tried running from master with just these patches applied. So far, the only failures I am seeing on gitlab/travis are job timeouts. Are you doing

Re: [PATCH v2 1/2] util: Introduce qemu_get_host_name()

On Mon, Jun 22, 2020 at 07:46:08PM +0200, Philippe Mathieu-Daudé wrote: > On 6/22/20 7:26 PM, Michal Privoznik wrote: > > This function offers operating system agnostic way to fetch host > > name. It is implemented for both POSIX-like and Windows systems. > > > > Signed-off-by: Michal Privoznik

Re: [PATCH v2 1/2] util: Introduce qemu_get_host_name()

On 6/22/20 7:26 PM, Michal Privoznik wrote: > This function offers operating system agnostic way to fetch host > name. It is implemented for both POSIX-like and Windows systems. > > Signed-off-by: Michal Privoznik > --- > include/qemu/osdep.h | 10 ++ > util/oslib-posix.c | 32

Re: [PATCH 0/2] qcow2: Force preallocation with data-file-raw

On Mon 22 Jun 2020 11:47:32 AM CEST, Max Reitz wrote: >> I don't know the internals of qcow2 data_file, but are we really using >> qcow2 metadata when accessing the data file? > > Yes. > >> This may have unwanted performance consequences. > > I don’t think so, because in practice normal lookups of

Re: [PATCH v2 1/2] util: Introduce qemu_get_host_name()

On Mon, Jun 22, 2020 at 07:26:44PM +0200, Michal Privoznik wrote: > This function offers operating system agnostic way to fetch host > name. It is implemented for both POSIX-like and Windows systems. > > Signed-off-by: Michal Privoznik > --- > include/qemu/osdep.h | 10 ++ >

Re: [PATCH 1/2] qcow2: Force preallocation with data-file-raw

On Mon 22 Jun 2020 05:06:53 PM CEST, Max Reitz wrote: >>> No, this is wrong. This still wouldn’t fix the problem of having a >>> device file as the external data file, when it already has non-zero >>> data during creation. (Reading the qcow2 file would return zeroes, >>> but reading the device

Re: [PULL 00/15] Renesas hardware patches for 2020-06-21

понедељак, 22. јун 2020., Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> је написао/ла: > > > понедељак, 22. јун 2020., Philippe Mathieu-Daudé је > написао/ла: > >> +Thomas >> >> On 6/22/20 6:19 PM, Peter Maydell wrote: >> > On Mon, 22 Jun 2020 at 17:01, Peter Maydell >> wrote: >> >> >>

[PATCH v2 2/2] qga: Use qemu_get_host_name() instead of g_get_host_name()

Problem with g_get_host_name() is that on the first call it saves the hostname into a global variable and from then on, every subsequent call returns the saved hostname. Even if the hostname changes. This doesn't play nicely with guest agent, because if the hostname is acquired before the guest is

[PATCH v2 1/2] util: Introduce qemu_get_host_name()

This function offers operating system agnostic way to fetch host name. It is implemented for both POSIX-like and Windows systems. Signed-off-by: Michal Privoznik --- include/qemu/osdep.h | 10 ++ util/oslib-posix.c | 32 util/oslib-win32.c | 13

[PATCH v2 0/2] qga: Ditch g_get_host_name()

v2 of: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg04457.html diff to v1: - Move implementation out from qga/ to util/oslib-* Michal Privoznik (2): util: Introduce qemu_get_host_name() qga: Use qemu_get_host_name() instead of g_get_host_name() include/qemu/osdep.h | 10

  1   2   3   4   5   >