[PATCH v1 3/3] hw/intc: ibex_plic: Honour source priorities

2020-07-24 Thread Alistair Francis
This patch follows what commit aa4d30f6618dc "riscv: plic: Honour source priorities" does and ensures that the highest priority interrupt will be serviced first. Signed-off-by: Alistair Francis Cc: Jessica Clarke --- hw/intc/ibex_plic.c | 15 ++- 1 file changed, 10 insertions(+), 5

[PATCH v1 1/3] hw/intc: ibex_plic: Update the pending irqs

2020-07-24 Thread Alistair Francis
After a claim or a priority change we need to update the pending interrupts. This is based on the same patch for the SiFive PLIC: 55765822804f5a58594e "riscv: plic: Add a couple of mising sifive_plic_update calls" Signed-off-by: Alistair Francis Cc: Jessica Clarke --- hw/intc/ibex_plic.c | 4

[PATCH v1 0/3] hw/intc: A few fixes for the Ibex PLIC

2020-07-24 Thread Alistair Francis
Recently some SiFive PLIC fixes have been merged into QEMU, this applies those fixes to the Ibex PLIC as well as an update on how claiming interrupts works. Alistair Francis (3): hw/intc: ibex_plic: Update the pending irqs hw/intc: ibex_plic: Don't allow repeat interrupts on claimed lines

[PATCH v1 2/3] hw/intc: ibex_plic: Don't allow repeat interrupts on claimed lines

2020-07-24 Thread Alistair Francis
Once an interrupt has been claimed, but before it has been compelted we shouldn't receive any more pending interrupts. This patche keeps track of this to ensure that we don't see any more interrupts until it is completed. Signed-off-by: Alistair Francis --- include/hw/intc/ibex_plic.h | 1 +

[Bug 1888918] Re: qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
** Summary changed: - qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt + qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt ** Description changed:

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
** Changed in: qemu Assignee: (unassigned) => Matthieu Bucchianeri (matthieu-bucchianeri) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888918 Title: qemu-ppc: Floating point instructions do

[Bug 1611394] Re: qemu-ppc: Scalar Single-Precision Floating-Point instructions should not test MSR[SPV]

2020-07-24 Thread Matthieu Bucchianeri
I have filed a broader ticket, Bug #1888918, reporting a very similar issue that leads to corruption/bad arithmetic when using double- precision & vector instructions. I will be submitting a patch in the next few days that will also address this ticket. -- You received this bug notification

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
Attaching the output of the test module run on QEMU. As shown in the description, 39 instructions do not comply with the rule described in the Signal Processing Engine (SPE) Programming Environments Manual, Rev. 0. QEMU was run as follows: # qemu/ppc-softmmu/qemu-system-ppc -nographic -machine

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
I have already written a patch for this issue, that I will be submitting to the community in the next few days. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888918 Title: qemu-ppc: Floating

[RFC PATCH 6/8] migration/dirtyrate: Implement get_sample_gap_period() and block_sample_gap_period()

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Implement get_sample_gap_period() and block_sample_gap_period() to sleep specific time between sample actions. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 28 migration/dirtyrate.h | 6 +- 2 files

[RFC PATCH 7/8] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Implement calculate_dirtyrate() function. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 53 +-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/migration/dirtyrate.c

[RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called by libvirt api. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/Makefile.objs | 1 + migration/dirtyrate.c | 45 +

[RFC PATCH 4/8] migration/dirtyrate: Record hash results for each ramblock

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Record hash results for each ramblock. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 157 ++ migration/dirtyrate.h | 1 + 2 files changed, 158 insertions(+) diff --git

[RFC PATCH 5/8] migration/dirtyrate: Compare hash results for recorded ramblock

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Compare hash results for recorded ramblock. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/migration/dirtyrate.c

[RFC PATCH 1/8] migration/dirtyrate: Add get_dirtyrate_thread() function

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Add get_dirtyrate_thread() functions Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 63 +++ migration/dirtyrate.h | 38 +++ 2 files changed, 101 insertions(+)

[RFC PATCH 3/8] migration/dirtyrate: Add dirtyrate statistics series functions

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.c | 47 ++- migration/dirtyrate.h | 11 +++ 2 files changed, 41 insertions(+), 17

[RFC PATCH 0/8] *** A Method for evaluating dirty page rate ***

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Sometimes it is neccessary to evaluate dirty page rate before migration. Users could decide whether to proceed migration based on the evaluation in case of vm performance loss due to heavy workload. Unlikey simulating dirtylog sync which could do harm on runnning vm, we provide

[RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info

2020-07-24 Thread Chuan Zheng
From: Zheng Chuan Add block_dirty_info to store dirtypage info for each ramblock Signed-off-by: Zheng Chuan Signed-off-by: YanYing Zhang --- migration/dirtyrate.h | 13 + 1 file changed, 13 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
Attaching the test program mentioned in the description. This program (a kernel module, in fact) can be loaded on a Linux system both in QEMU or on real hardware. In the next comments, I will attach the detailed output of the test program. ** Attachment added: "SPE test module"

[Bug 1888918] Re: qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
Attaching the output of the test module (above) when run on a real MPC8548. This is to establish a baseline validating which instructions shall or shall not generate the SPE/Embedded Floating-Point Unavailable interrupt. Note that on the MPC8548, it is observed that the "brinc" instruction does

[Bug 1888918] [NEW] qemu-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-07-24 Thread Matthieu Bucchianeri
Public bug reported: When emulating certain floating point instructions or vector instructions on PowerPC machines, QEMU does not properly generate the SPE/Embedded Floating-Point Unavailable interrupt. As described in the Signal Processing Engine (SPE) Programming Environments Manual, Rev. 0,

Re: [PATCH 1/1] scripts/performance: Add bisect.py script

2020-07-24 Thread John Snow
On 7/21/20 7:15 PM, Ahmed Karaman wrote: Python script that locates the commit that caused a performance degradation or improvement in QEMU using the git bisect command (binary search). Syntax: bisect.py [-h] -s,--start START [-e,--end END] [-q,--qemu QEMU] \ --target TARGET --tool

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-24 Thread Guan Xuetao
That's OK for unicore32 target. Acked-by: Guan Xuetao > -原始邮件- > 发件人: "Thomas Huth" > 发送时间: 2020-07-23 21:22:19 (星期四) > 收件人: "Guan Xuetao" , qemu-devel@nongnu.org > 抄送: "Philippe Mathieu-Daudé" , qemu-triv...@nongnu.org, > "Richard Henderson" > 主题: [PATCH] target/unicore32: Remove

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Jason Wang
On 2020/7/24 下午11:34, Cornelia Huck wrote: On Fri, 24 Jul 2020 11:17:57 -0400 "Michael S. Tsirkin" wrote: On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: On Fri, 24 Jul 2020 09:30:58 -0400 "Michael S. Tsirkin" wrote: On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia

[PULL v1 3/3] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Stefan Berger
This patch fixes the odd error reporting when trying to send a file descriptor to the TPM emulator if one has not passed a valid chardev. $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 qemu-system-x86_64: -tpmdev emulator,id=tpm0: tpm-emulator: Failed to send CMD_SET_DATAFD:

[PULL v1 1/3] Revert "tpm: Clean up error reporting in tpm_init_tpmdev()"

2020-07-24 Thread Stefan Berger
From: Markus Armbruster This reverts commit d10e05f15d5c3dd5e5cc59c5dfff460d89d48580. We report some -tpmdev failures, but then continue as if all was fine. Reproducer: $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -chardev null,id=tpm0 -tpmdev

[PULL v1 2/3] tpm: Improve help on TPM types when none are available

2020-07-24 Thread Stefan Berger
From: Markus Armbruster Help is a bit awkward when no TPM types are built into QEMU: $ qemu-system-x86_64 -tpmdev nonexistent,id=tpm0 qemu-system-x86_64: -tpmdev nonexistent,id=tpm0: Parameter 'type' expects a TPM backend type Supported TPM types (choose only one): Improve to

[PULL v1 0/3] Merge tpm 2020/07/24 v1

2020-07-24 Thread Stefan Berger
This series of patches corrects bad error reporting due to erroneous or missing TPM related command line parameters. Regards, Stefan The following changes since commit 7adfbea8fd1efce36019a0c2f198ca73be9d3f18: Merge remote-tracking branch

Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

2020-07-24 Thread Lijun Pan
> On Jul 24, 2020, at 1:46 PM, Lijun Pan wrote: > > > >> On Jul 24, 2020, at 1:00 PM, Richard Henderson > > wrote: >> >> On 7/23/20 9:58 PM, Lijun Pan wrote: >>> vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo >>> VA-form. >>>

Re: Testing the virtio-vhost-user QEMU patch

2020-07-24 Thread Alyssa Ross
Stefan Hajnoczi writes: > On Fri, Jul 24, 2020 at 10:58:45AM +, Alyssa Ross wrote: >> Alyssa Ross writes: >> >> > Stefan Hajnoczi writes: >> > >> >> On Tue, Jul 21, 2020 at 07:14:38AM +, Alyssa Ross wrote: >> >>> Hi -- I hope it's okay me reaching out like this. >> >>> >> >>> I've

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

2020-07-24 Thread Richard Henderson
For the record, reproducing this problem requires root, thus trying to reproduce it outside of a chroot is non-obvious. https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07224.html ** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) =>

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

2020-07-24 Thread Richard Henderson
On 7/24/20 11:53 AM, Paolo Bonzini wrote: > Looks good, will queue when I am back---or just send a pull request yourself > if > you prefer. Ok, will do. Thanks. r~ > > Paolo > > Il ven 24 lug 2020, 20:35 Richard Henderson > ha scritto: > > Ping? >

[PATCH] linux-user: Ensure mmap_min_addr is non-zero

2020-07-24 Thread Richard Henderson
When the chroot does not have /proc mounted, we can read neither /proc/sys/vm/mmap_min_addr nor /proc/sys/maps. The enforcement of mmap_min_addr in the host kernel is done by the security module, and so does not apply to processes owned by root. Which leads pgd_find_hole_fallback to succeed in

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-24 Thread Vladimir Sementsov-Ogievskiy
24.07.2020 20:35, Eric Blake wrote: On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished bitmaps. Still we have

[PATCH v2] cputlb: Make store_helper less fragile to compiler optimizations

2020-07-24 Thread Shu-Chun Weng
This change has no functional change. There is a potential link error with "undefined symbol: qemu_build_not_reached" due to how `store_helper` is structured. This does not produce at current QEMU head, but was reproducible at v4.2.0 with `clang-10 -O2 -fexperimental-new-pass-manager`. The

Re: [PATCH] linux-user: Fix syscall rt_sigtimedwait() implementation

2020-07-24 Thread Laurent Vivier
Le 24/07/2020 à 20:16, Filip Bozuta a écrit : > Implementation of 'rt_sigtimedwait()' in 'syscall.c' uses the > function 'target_to_host_timespec()' to transfer the value of > 'struct timespec' from target to host. However, the implementation > doesn't check whether this conversion succeeds and

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

2020-07-24 Thread Alex Bennée
Richard Henderson writes: > We forgot to update cc_op before these branch insns, > which lead to losing track of the current eflags. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165 > Signed-off-by: Richard Henderson > --- > target/i386/translate.c | 1 + > 1 file changed, 1

Re: [PATCH v3 20/21] qemu-iotests/199: add early shutdown case to bitmaps postcopy

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Previous patches fixed two crashes which may occur on shutdown prior to bitmaps postcopy finished. Check that it works now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- tests/qemu-iotests/199 | 24

Re: [PATCH 1/2] tests: Add 'fetch-acceptance' rule

2020-07-24 Thread Wainer dos Santos Moschetta
Hello, On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: Add a rule to fetch acceptance test assets. This is particularly useful in a CI context, when a single job can fetch and save the cache so other jobs reuse it directly. It is also useful to measure the time spent downloading the assets

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

2020-07-24 Thread Paolo Bonzini
Looks good, will queue when I am back---or just send a pull request yourself if you prefer. Paolo Il ven 24 lug 2020, 20:35 Richard Henderson ha scritto: > Ping? > > On 7/20/20 8:40 AM, Richard Henderson wrote: > > We forgot to update cc_op before these branch insns, > > which lead to losing

Re: [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule

2020-07-24 Thread Willian Rampazzo
On Fri, Jul 24, 2020 at 3:26 PM Wainer dos Santos Moschetta wrote: > > Hi Philippe, > > On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: > > The boot_linux.py file triggers an exception: > > > >$ make fetch-acceptance > >AVOCADO tests/acceptance > >Fetching assets from

Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

2020-07-24 Thread Lijun Pan
> On Jul 24, 2020, at 1:00 PM, Richard Henderson > wrote: > > On 7/23/20 9:58 PM, Lijun Pan wrote: >> vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo >> VA-form. >> vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned >> Doubleword VA-form. >>

Re: [PATCH for-5.1?] target/i386: Save cc_op before loop insns

2020-07-24 Thread Richard Henderson
Ping? On 7/20/20 8:40 AM, Richard Henderson wrote: > We forgot to update cc_op before these branch insns, > which lead to losing track of the current eflags. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1888165 > Signed-off-by: Richard Henderson > --- > target/i386/translate.c | 1 + > 1

Re: [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule

2020-07-24 Thread Wainer dos Santos Moschetta
Hi Philippe, On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote: The boot_linux.py file triggers an exception: $ make fetch-acceptance AVOCADO tests/acceptance Fetching assets from tests/acceptance/empty_cpu_model.py. Fetching assets from tests/acceptance/vnc.py. Fetching assets

Re: [PATCH v3 13/16] linux-user,ppc: fix clock_nanosleep() for linux-user-ppc

2020-07-24 Thread Richard Henderson
On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laurent Vivier > > Our safe_clock_nanosleep() returns -1 and updates errno. > > We don't need to update the CRF bit in syscall.c because it will > be updated in ppc/cpu_loop.c as the return value is negative. > > Signed-off-by: Laurent Vivier >

Re: [PATCH v3 12/16] linux-user: fix clock_nanosleep()

2020-07-24 Thread Richard Henderson
On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laurent Vivier > > If the call is interrupted by a signal handler, it fails with error EINTR > and if "remain" is not NULL and "flags" is not TIMER_ABSTIME, it returns > the remaining unslept time in "remain". > > Update linux-user to not

Re: [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers

2020-07-24 Thread Richard Henderson
On 7/23/20 11:45 PM, Alex Bennée wrote: > From: Laszlo Ersek > > Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an > object that has static storage duration shall be constant expressions or > string literals". > > The compound literal produced by the make_floatx80() macro

Re: [PATCH v3 06/16] accel/tcg: better handle memory constrained systems

2020-07-24 Thread Richard Henderson
On 7/23/20 11:44 PM, Alex Bennée wrote: > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can put the machine under increased memory

[PATCH] linux-user: Fix syscall rt_sigtimedwait() implementation

2020-07-24 Thread Filip Bozuta
Implementation of 'rt_sigtimedwait()' in 'syscall.c' uses the function 'target_to_host_timespec()' to transfer the value of 'struct timespec' from target to host. However, the implementation doesn't check whether this conversion succeeds and thus can cause an unaproppriate error instead of the

Re: [PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: First, if only bitmaps postcopy enabled (not ram postcopy) is enabled (and not ram postcopy), postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). on an And anyway, bitmaps postcopy is not prepared to be somehow

Re: [PATCH v7 40/47] block: Inline bdrv_co_block_status_from_*()

2020-07-24 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: With bdrv_filter_bs(), we can easily handle this default filter behavior in bdrv_co_block_status(). blkdebug wants to have an additional assertion, so it keeps its own implementation, except bdrv_co_block_status_from_file() needs to be inlined there.

Re: [PATCH v5 6/6] target/ppc: add vmsumudm vmsumcud instructions

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo > VA-form. > vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned > Doubleword VA-form. > > Signed-off-by: Lijun Pan > --- > v5: update instruction flag for

Re: [PATCH v5 3/6] target/ppc: add vmulh{su}w instructions

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > vmulhsw: Vector Multiply High Signed Word > vmulhuw: Vector Multiply High Unsigned Word > > Signed-off-by: Lijun Pan > --- > v4/v5: no change > Reviewed-by: Richard Henderson > v3: inline the helper_vmulh{su}w multiply directly instead of using macro > v2:

Re: [PATCH v5 2/6] target/ppc: add vmulld to INDEX_op_mul_vec case

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > Group vmuluwm and vmulld. Make vmulld-specific > changes since it belongs to new ISA 3.1. > > Signed-off-by: Lijun Pan > --- > v5: no change > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style >

Re: [PATCH v5 1/6] Update PowerPC AT_HWCAP2 definition

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > > Signed-off-by: Lijun Pan > --- Reviewed-by: Richard Henderson We should add the rest of the bits as well at some point. r~

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished bitmaps. Still we have to report io stream violation errors,

Re: roms/seabios-hppa can't be built with gcc-10: -fno-ipa-sra

2020-07-24 Thread Helge Deller
On 22.07.20 21:11, Michael Tokarev wrote: > Switching to gcc-10 makes seabios-hppa unbuildable. > It fails at the final linking step with a lot of > missing references to memcpy & memcmp all over the > places. > > The notable difference between gcc-10 and previous > gcc is that ccode32flat.o does

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Christian Schoenebeck
On Freitag, 24. Juli 2020 18:50:47 CEST Peter Maydell wrote: > On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > wrote: > > I guess we were expecting the distrib to update the pkg. > > Apple's view is that you shouldn't be using the sasl header > at all but instead their proprietary crypto

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-24 Thread Igor Mammedov
On Mon, 13 Jul 2020 14:30:29 -0500 Babu Moger wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Monday, July 13, 2020 12:32 PM > > To: Moger, Babu > > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > > de...@nongnu.org > > Subject: Re: [PATCH v2

Re: [PATCH v2 3/4] build: Don't make object files for dtrace on macOS

2020-07-24 Thread Roman Bolshakov
On Fri, Jul 17, 2020 at 12:35:16PM +0300, Roman Bolshakov wrote: > dtrace on macOS uses unresolved symbols with a special prefix to define > probes [1], only headers should be generated for USDT (dtrace(1)). But > it doesn't support backwards compatible no-op -G flag [2] and implicit > build rules

Re: [PATCH 3/3] scripts/qmp/qom-fuse: Fix getattr(), read() for files in /

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: path, prop = "type".rsplit('/', 1) sets path to "", which doesn't work. Correct to "/". BOTD. If it works for you, that's good news. Reviewed-by: John Snow Signed-off-by: Markus Armbruster --- scripts/qmp/qom-fuse | 10 -- 1 file

Re: [PATCH v7 12/21] multi-process: Connect Proxy Object with device in the remote process

2020-07-24 Thread Jag Raman
> On Jul 1, 2020, at 5:20 AM, Stefan Hajnoczi wrote: > > On Sat, Jun 27, 2020 at 10:09:34AM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> Send a message to the remote process to connect PCI device with the >> corresponding Proxy object in QEMU > > I thought the

Re: [PATCH 2/3] scripts/qmp/qom-fuse: Port to current Python module fuse

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Honestly, benefit of the doubt on this one. The Python looks fine, but I don't know much about the FUSE module. Still, it was broken before, so if you claim it now works for you, that's more useful than it used

[PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines

2020-07-24 Thread Philippe Mathieu-Daudé
No MIPS machine uses the ACPI cpu-hotplug feature (QEMU implementation is X86 specific). Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces") Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-softmmu-common.mak | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 0/3] scripts/qmp/qom-fuse: Scrape off the bitrot

2020-07-24 Thread John Snow
On 7/23/20 11:21 AM, Thomas Huth wrote: On 23/07/2020 16.27, Markus Armbruster wrote: Markus Armbruster (3): scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol scripts/qmp/qom-fuse: Port to current Python module fuse scripts/qmp/qom-fuse: Fix getattr(), read() for files in /

Re: [PATCH 1/3] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: Commit c7b942d7f8 "scripts/qmp: Fix shebang and imports" messed with it for reasons I don't quite understand. I do understand how it fails now: it neglects to import sys. Fix that. Apologies. These scripts didn't appear to work because they

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé wrote: > I guess we were expecting the distrib to update the pkg. Apple's view is that you shouldn't be using the sasl header at all but instead their proprietary crypto library APIs, so I wouldn't expect them to ever ship something without

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 06:46:23PM +0200, Philippe Mathieu-Daudé wrote: > On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: > >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > >> since -Werror is only enabled

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, >> since -Werror is only enabled for Linux and MinGW builds by default. So >> let's enable them here now, too.

[PULL 0/3] Fixes 20200724 patches

2020-07-24 Thread Gerd Hoffmann
The following changes since commit 09e0cd773723219d21655587954da2769f64ba01: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20200722-1' into staging (2020-07-23 19:00:42 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20200724

[PULL 2/3] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES

2020-07-24 Thread Gerd Hoffmann
From: Peter Maydell virtio-input-hid.c undefines CONFIG_CURSES before including ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18 that header does not have behaviour dependent on CONFIG_CURSES. Remove the now-unneeded undef. Signed-off-by: Peter Maydell Reviewed-by:

[PULL 3/3] configure: Allow to build tools without pixman

2020-07-24 Thread Gerd Hoffmann
From: Thomas Huth If pixman is not installed, it is currently not possible to run: .../configure --disable-system --enable-tools Seems like there was a dependency from one of the required source files to pixman in the past, but since commit 1ac0206b2ae1ffaeec56 ("qemu-timer.c: Trim list of

[PULL 1/3] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-24 Thread Gerd Hoffmann
From: Thomas Huth The USB_DWC2 switch is currently "default y", so it is included in all qemu-system-* builds, even if it is not needed. Even worse, it does a "select USB", so USB devices are now showing up as available on targets that do not support USB at all. This sysbus device should only be

[PATCH 2/3] hw/arm/boot: Fix MTE for EL3 direct kernel boot

2020-07-24 Thread Richard Henderson
When booting an EL3 cpu with -kernel, we set up EL3 and then drop down to EL2. We need to enable access to v8.5-MemTag tag allocation at EL3 before doing so. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- hw/arm/boot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH for-5.1 0/3] target/arm: mte+pauth fixes

2020-07-24 Thread Richard Henderson
A couple of last minute fixes for MTE: (1) Peter pointed out that EL3's SCR.ATA needs to be set when we're booting a kernel directly. Similarly for API & APK. (2) Vincenzo pointed out that with RRND=1, we can't rely on RGSR having being initialized. I suppose the only

Re: [PATCH v2] gitlab-ci: Fix Avocado cache usage

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 5:52 PM, Wainer dos Santos Moschetta wrote: > Hi Philippe, > > On 7/24/20 4:42 AM, Philippe Mathieu-Daudé wrote: >> In commit 6957fd98dc ("gitlab: add avocado asset caching") we >> tried to save the Avocado cache (as in commit c1073e44b4 with >> Travis-CI) however it doesn't work as

[PATCH 3/3] target/arm: Improve IMPDEF algorithm for IRG

2020-07-24 Thread Richard Henderson
When GCR_EL1.RRND==1, the choosing of the random value is IMPDEF, and the kernel is not expected to have set RGSR_EL1. Force a non-zero value into SEED, so that we do not continually return the same tag. Reported-by: Vincenzo Frascino Signed-off-by: Richard Henderson ---

[PATCH 1/3] hw/arm/boot: Fix PAUTH for EL3 direct kernel boot

2020-07-24 Thread Richard Henderson
When booting an EL3 cpu with -kernel, we set up EL3 and then drop down to EL2. We need to enable access to v8.3-PAuth keys and instructions at EL3 before doing so. Signed-off-by: Richard Henderson --- hw/arm/boot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/boot.c

Re: [PATCH 1/1] python/machine: Change default timeout to 30 seconds

2020-07-24 Thread John Snow
On 7/20/20 4:20 PM, Eduardo Habkost wrote: On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote: 3 seconds is too short for some tests running inside busy VMs. Build it out to a rather generous 30 seconds to find out conclusively if there are more severe problems in the merge/CI tests.

Re: [PATCH v0 0/4] background snapshot

2020-07-24 Thread Peter Xu
On Fri, Jul 24, 2020 at 11:06:17AM +0300, Denis Plotnikov wrote: > > > On 23.07.2020 20:39, Peter Xu wrote: > > On Thu, Jul 23, 2020 at 11:03:55AM +0300, Denis Plotnikov wrote: > > > > > > On 22.07.2020 19:30, Peter Xu wrote: > > > > On Wed, Jul 22, 2020 at 06:47:44PM +0300, Denis Plotnikov

QEMU | Pipeline #170508500 has failed for master | 7adfbea8

2020-07-24 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 7adfbea8 ( https://gitlab.com/qemu-project/qemu/-/commit/7adfbea8fd1efce36019a0c2f198ca73be9d3f18 ) Commit Message: Merge

Re: [ipxe-devel] https booting

2020-07-24 Thread Michael Brown
On 22/07/2020 15:13, Daniel P. Berrangé wrote: We could easily define etc/ipxe/https/{ciphers,cacerts} paths in a different format if better suited for iPXE. Libvirt can set the right path depending on whether its booting a VM with EDK2 vs legacy BIOS The most useful for iPXE would probably be

Re: [PATCH v3 13/21] migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_enable_dirty_bitmap_locked() call does nothing, as if we are in postcopy, bitmap successor must be enabled, and reclaim operation will enable the bitmap. So, actually we need just call _reclaim_ in both if branches, and making

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-07-24 Thread Simon Kaegi
It hangs (still guessing here) immediately -- before anything is logged. I'll try to get you a calltrace but have to figure out how to do that first ;) Any pointers appreciated. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v7 38/47] block: Drop backing_bs()

2020-07-24 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: We want to make it explicit where bs->backing is used, and we have done so. The old role of backing_bs() is now effectively taken by bdrv_cow_bs(). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 5

Re: [PATCH v2] gitlab-ci: Fix Avocado cache usage

2020-07-24 Thread Wainer dos Santos Moschetta
Hi Philippe, On 7/24/20 4:42 AM, Philippe Mathieu-Daudé wrote: In commit 6957fd98dc ("gitlab: add avocado asset caching") we tried to save the Avocado cache (as in commit c1073e44b4 with Travis-CI) however it doesn't work as expected. For some reason Avocado uses /root/avocado_cache/ which we

Re: [PATCH v7 37/47] qemu-img: Use child access functions

2020-07-24 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: This changes iotest 204's output, because blkdebug on top of a COW node used to make qemu-img map disregard the rest of the backing chain (the backing chain was broken by the filter). With this patch, the allocation in the base image is reported correctly.

Re: [PATCH v3 07/21] migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_start

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: No reason to use _locked version of bdrv_enable_dirty_bitmap, as we don't lock this mutex before. Moreover, the adjacent bdrv_dirty_bitmap_enable_successor do lock the mutex. Grammar suggestion: Using the _locked version of

Re: [PATCH V2] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Marc-André Lureau
Hi On Fri, Jul 24, 2020 at 6:16 PM Stefan Berger wrote: > This patch fixes the odd error reporting when trying to send a file > descriptor to the TPM emulator if one has not passed a valid chardev. > > $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 > qemu-system-x86_64: -tpmdev

Re: Possible regression with VGA and resolutions in Windows 10?

2020-07-24 Thread Gerd Hoffmann
On Fri, Jul 24, 2020 at 03:31:23PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 04:10:32PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > The behavior is similar when setting a custom resolution with the xres > > > and yres parameters. Setting it the first time works fine and it

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Cornelia Huck
On Fri, 24 Jul 2020 11:17:57 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: > > On Fri, 24 Jul 2020 09:30:58 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > > > When I

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

2020-07-24 Thread John Paul Adrian Glaubitz
Here you go: https://people.debian.org/~glaubitz/sid-m68k-sbuild.tgz Thanks for looking into it! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888728 Title: Bare chroot in linux-user fails with

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Michael S. Tsirkin
On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: > On Fri, 24 Jul 2020 09:30:58 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > > When I start qemu with a second virtio-net-ccw device (i.e. adding > > > -device

Re: [PULL 0/1] x86 bug fix for -rc2

2020-07-24 Thread Peter Maydell
On Thu, 23 Jul 2020 at 20:14, Eduardo Habkost wrote: > > The following changes since commit 8ffa52c20d5693d454f65f2024a1494edfea65d4: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-07-23 13:38:21 +0100) > > are available in the Git repository at: > >

Re: [PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:08 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 03:47:04PM +0200, Markus Armbruster wrote: >> From: Philippe Mathieu-Daudé >> >> error_propagate_prepend() "behaves like error_prepend()", and >> error_prepend() uses "formatting @fmt, ... like printf()". >> error_prepend()

Re: [PATCH v4 3/8] s390/sclp: rework sclp boundary and length checks

2020-07-24 Thread Collin Walling
On 7/23/20 2:26 AM, Cornelia Huck wrote: > On Tue, 21 Jul 2020 14:40:14 -0400 > Collin Walling wrote: > >> On 7/21/20 4:41 AM, David Hildenbrand wrote: > >>> The options I would support are >>> >>> 1. "sccb_boundary_is_valid" which returns "true" if valid >>> 2. "sccb_boundary_is_invalid" which

Re: [PATCH v3 01/21] qemu-iotests/199: fix style

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Mostly, satisfy pep8 complains. complaints I can touch that up while staging. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Tested-by: Eric Blake --- tests/qemu-iotests/199 | 13 +++-- 1 file

Re: [PATCH 1/3] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-24 Thread Christian Schoenebeck
On Freitag, 24. Juli 2020 16:32:18 CEST Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration of

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 15:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. > For macOS, that unfortunately means that we have to disable

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Cornelia Huck
On Fri, 24 Jul 2020 09:30:58 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > When I start qemu with a second virtio-net-ccw device (i.e. adding > > -device virtio-net-ccw in addition to the autogenerated device), I get > > a segfault. gdb

  1   2   3   >