[Bug 1883732] Re: xhci_kick_epctx: Assertion `ring->dequeue != 0' failed.

2020-08-10 Thread Alexander Bulekov
Here's a QTest reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device nec-usb-xhci -trace usb\* \ -device usb-audio -device usb-storage,drive=mydrive \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -nodefaults -nographic -qtest stdio outl 0xcf8 0x80001014 outl 0xcfc

Re: [PATCH 7/7] target/arm/cpu: spe: Enable spe to work with host cpu

2020-08-10 Thread Haibo Xu
On Mon, 10 Aug 2020 at 19:16, Andrew Jones wrote: > > On Fri, Aug 07, 2020 at 08:10:37AM +, Haibo Xu wrote: > > Turn on the spe cpu property by default when working with host > > cpu type in KVM mode, i.e. we can now do '-cpu host' to add the > > vSPE, and '-cpu host,spe=off' to remove it. >

Re: [PATCH 6/7] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-08-10 Thread Haibo Xu
On Mon, 10 Aug 2020 at 19:05, Andrew Jones wrote: > > On Fri, Aug 07, 2020 at 08:10:36AM +, Haibo Xu wrote: > > Add a virtual SPE device for virt machine while using PPI > > 5 for SPE overflow interrupt number. > > Any reason PPI 5 was selected? > No special reason to choose PPI 5. Just

[Bug 1883729] Re: xhci_find_stream: Assertion `streamid != 0' failed.

2020-08-10 Thread Alexander Bulekov
Attaching a QTest reproducer. ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci -trace usb\* \ -device usb-audio -device usb-storage,drive=mydrive \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -nodefaults -nographic -qtest stdio < repro Close to the crash:

[PATCH] vhost-user: add separate memslot counter for vhost-user

2020-08-10 Thread Jiajun Chen
Used_memslots is equal to dev->mem->nregions now, it is true for vhost kernel, but not for vhost user, which uses the memory regions that have file descriptor. In fact, not all of the memory regions have file descriptor. It is usefully in some scenarios, e.g. used_memslots is 8, and only 5 memory

[PATCH] target/ppc: Integrate icount to purr, vtb, and tbu40

2020-08-10 Thread Gustavo Romero
Currently if option '-icount auto' is passed to the QEMU TCG to enable counting instructions the VM crashes with the following error report when Linux runs on it: qemu-system-ppc64: Bad icount read This happens because read/write access to the SPRs PURR, VTB, and TBU40 is not integrated to the

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Tony.LI
Hi,Alex.May be you are right.I don't understand what you want to express. I don't know what causes traps. Is it caused by software, or qemu executes CPU-sensitive instruction simulation. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-10 Thread Haibo Xu
On Mon, 10 Aug 2020 at 18:29, Andrew Jones wrote: > > On Mon, Aug 10, 2020 at 10:48:41AM +0800, Haibo Xu wrote: > > On Fri, 7 Aug 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > > > > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > > > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), > > > >

[PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-08-10 Thread Havard Skinnemoen
This adds two acceptance tests for the quanta-gsj machine. One test downloads a lightly patched openbmc flash image from github and verifies that it boots all the way to the login prompt. The other test downloads a kernel, initrd and dtb built from the same openbmc source and verifies that the

[PATCH v7 12/13] docs/system: Add Nuvoton machine documentation

2020-08-10 Thread Havard Skinnemoen
Reviewed-by: Cédric Le Goater Signed-off-by: Havard Skinnemoen --- docs/system/arm/nuvoton.rst | 90 + docs/system/target-arm.rst | 1 + 2 files changed, 91 insertions(+) create mode 100644 docs/system/arm/nuvoton.rst diff --git

[PATCH v7 10/13] hw/ssi: NPCM7xx Flash Interface Unit device model

2020-08-10 Thread Havard Skinnemoen
This implements a device model for the NPCM7xx SPI flash controller. Direct reads and writes, and user-mode transactions have been tested in various modes. Protection features are not implemented yet. All the FIU instances are available in the SoC's address space, regardless of whether or not

[PATCH v7 08/13] hw/nvram: NPCM7xx OTP device model

2020-08-10 Thread Havard Skinnemoen
This supports reading and writing OTP fuses and keys. Only fuse reading has been tested. Protection is not implemented. Reviewed-by: Avi Fishman Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Havard Skinnemoen --- hw/arm/npcm7xx.c | 29 +++ hw/nvram/Makefile.objs |

[PATCH v7 09/13] hw/mem: Stubbed out NPCM7xx Memory Controller model

2020-08-10 Thread Havard Skinnemoen
This just implements the bare minimum to cause the boot block to skip memory initialization. Reviewed-by: Tyrone Ting Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Havard Skinnemoen --- hw/arm/npcm7xx.c| 6 +++ hw/mem/Makefile.objs| 1

[PATCH v7 07/13] hw/arm: Load -bios image as a boot ROM for npcm7xx

2020-08-10 Thread Havard Skinnemoen
If a -bios option is specified on the command line, load the image into the internal ROM memory region, which contains the first instructions run by the CPU after reset. If -bios is not specified, the vbootrom included with qemu is loaded by default. Reviewed-by: Tyrone Ting Reviewed-by: Cédric

[PATCH v7 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-08-10 Thread Havard Skinnemoen
The Nuvoton NPCM7xx SoC family are used to implement Baseboard Management Controllers in servers. While the family includes four SoCs, this patch implements limited support for two of them: NPCM730 (targeted for Data Center applications) and NPCM750 (targeted for Enterprise applications). This

[PATCH v7 11/13] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-08-10 Thread Havard Skinnemoen
This allows these NPCM7xx-based boards to boot from a flash image, e.g. one built with OpenBMC. For example like this: IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc qemu-system-arm -machine quanta-gsj -nographic \ -drive file=${IMAGE},if=mtd,bus=0,unit=0,format=raw,snapshot=on

[PATCH v7 01/13] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-08-10 Thread Havard Skinnemoen
Implement a device model for the System Global Control Registers in the NPCM730 and NPCM750 BMC SoCs. This is primarily used to enable SMP boot (the boot ROM spins reading the SCRPAD register) and DDR memory initialization; other registers are best effort for now. The reset values of the MDLR

[PATCH v7 05/13] hw/arm: Add two NPCM7xx-based machines

2020-08-10 Thread Havard Skinnemoen
This adds two new machines, both supported by OpenBMC: - npcm750-evb: Nuvoton NPCM750 Evaluation Board. - quanta-gsj: A board with a NPCM730 chip. They rely on the NPCM7xx SoC device to do the heavy lifting. They are almost completely identical at the moment, apart from the SoC type, which

[PATCH v7 06/13] roms: Add virtual Boot ROM for NPCM7xx SoCs

2020-08-10 Thread Havard Skinnemoen
This is a minimalistic boot ROM written specifically for use with QEMU. It supports loading the second-stage loader from SPI flash into RAM, SMP boot, and not much else. Signed-off-by: Havard Skinnemoen --- .gitmodules | 3 +++ MAINTAINERS | 2 ++ Makefile

[PATCH v7 02/13] hw/misc: Add NPCM7xx Clock Controller device model

2020-08-10 Thread Havard Skinnemoen
Enough functionality to boot the Linux kernel has been implemented. This includes: - Correct power-on reset values so the various clock rates can be accurately calculated. - Clock enables stick around when written. In addition, a best effort attempt to implement SECCNT and CNTR25M was

[PATCH v7 03/13] hw/timer: Add NPCM7xx Timer device model

2020-08-10 Thread Havard Skinnemoen
The NPCM730 and NPCM750 SoCs have three timer modules each holding five timers and some shared registers (e.g. interrupt status). Each timer runs at 25 MHz divided by a prescaler, and counts down from a configurable initial value to zero. When zero is reached, the interrupt flag for the timer is

[PATCH v7 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-08-10 Thread Havard Skinnemoen
I also pushed this and the previous two patchsets to my qemu fork on github. The branches are named npcm7xx-v[1-7]. https://github.com/hskinnemoen/qemu This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to boot an OpenBMC image built for quanta-gsj. This includes device

[PATCH v2 4/4] Add a config option for ePMP.

2020-08-10 Thread Hou Weiying
Add a config option to enable experimental support for ePMP. This is disabled by default and can be enabled with 'x-epmp=true'. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 3 +++ 2 files

[PATCH v2 1/4] Define ePMP mseccfg

2020-08-10 Thread Hou Weiying
Currently using 0x390 and 0x391 for x-epmp (experimental). This may change in the future spec. Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/cpu_bits.h | 3 +++ target/riscv/gdbstub.c | 2 ++ 2 files changed, 5 insertions(+) diff

[PATCH v2 0/4] riscv: Add enhanced PMP support

2020-08-10 Thread Hou Weiying
v1 -> v2 : * regenerate this patch based on the latest upstream Hou Weiying (4): Define ePMP mseccfg Implementation of enhanced PMP(ePMP) support Add ePMP CSR accesses Add a config option for ePMP. target/riscv/cpu.c| 9 ++ target/riscv/cpu.h| 3 +

[PATCH v2 3/4] Add ePMP CSR accesses

2020-08-10 Thread Hou Weiying
Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/csr.c | 18 ++ target/riscv/pmp.c | 40 2 files changed, 58 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index

[PATCH v2 2/4] Implementation of enhanced PMP(ePMP) support

2020-08-10 Thread Hou Weiying
The ePMP can be found in: https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8/edit#heading=h.9wsr1lnxtwe2 Signed-off-by: Hongzheng-Li Signed-off-by: Hou Weiying Signed-off-by: Myriad-Dreamin --- target/riscv/pmp.c| 134 ++

Re: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence

2020-08-10 Thread Joel Stanley
On Mon, 10 Aug 2020 at 17:16, Cédric Le Goater wrote: > > On 8/7/20 1:42 AM, Joel Stanley wrote: > > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: > >> > >> BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until > >> the bit is cleared by HW. Add definitions for the

Re: [PATCH 2/3] target/riscv: Fix write_htinst() implementation

2020-08-10 Thread Alistair Francis
On Wed, Jul 29, 2020 at 4:30 AM Anup Patel wrote: > > The htinst CSR is writeable from M-mode and HS-mode so > we should not ignore writes to htinst CSR. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair > --- > target/riscv/csr.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH] riscv: Fix bug in setting pmpcfg CSR for RISCV64

2020-08-10 Thread Alistair Francis
On Sat, Aug 8, 2020 at 6:05 AM Hou Weiying wrote: > > First, sizeof(target_ulong) equals to 4 on riscv32, so this change > does not change the function on riscv32. Second, sizeof(target_ulong) > equals to 8 on riscv64, and 'reg_index * 8 + i' is not a legal > pmp_index (we will explain later),

Re: [RFC PATCH v2 1/2] hw/riscv: sifive_u: Add file-backed OTP.

2020-08-10 Thread Alistair Francis
,()On Thu, Jul 30, 2020 at 7:49 PM Green Wan wrote: > > Add a file-backed implementation for OTP of sifive_u machine. The > machine property for file-backed is disabled in default. Do file > open, mmap and close for every OTP read/write in case keep the > update-to-date snapshot of OTP. I don't

Re: [PATCH v8 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-08-10 Thread Francisco Iglesias
Hi Vikram, On Tue, Aug 04, 2020 at 02:11:42PM -0700, Vikram Garhwal wrote: > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through command lines. > > Example for using

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-08-10 Thread Brian Norris
On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau wrote: > On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell wrote: > > On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote: > > > Add one more to the pile! Chrome OS noticed this when upgrading to > > > 5.0.0: > > > > > >

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-08-10 Thread Alexander Bulekov
On 200810 2139, Paolo Bonzini wrote: > On 10/08/20 21:01, Daniele Buono wrote: > > So I'm thinking of adding a check in configure. If gold is the linker, > > automatically create (somehow, still working on it) the full link script > > by obtaining the default bfd script and add the required parts.

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Paolo Bonzini
Il lun 10 ago 2020, 21:57 Peter Maydell ha scritto: > > Since it's all handled internally by sphinx, I think you only need to > > add the man pages to the dictionary, and get rid of the corresponding > > Texinfo outputs in qapi/meson.build and qga/meson.build? > > The patchset has a fair amount

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
Il lun 10 ago 2020, 21:55 Peter Maydell ha scritto: > On Mon, 10 Aug 2020 at 20:49, Paolo Bonzini wrote: > > > > On 10/08/20 21:45, Peter Maydell wrote: > > >> Note that if you don't install it, you just get the previous behavior > > >> (plus a warning). But if you want that, it would be

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:46, Paolo Bonzini wrote: > > On 10/08/20 21:36, Peter Maydell wrote: > >> It should be possible and probably not too hard once I figure out how > >> Sphinx events work. It's a fair request since build_always_stale is > >> inferior and Meson requires no particular magic

[PATCH v5 16/20] Makefile: Remove redundant Texinfo related rules

2020-08-10 Thread Peter Maydell
We now don't build anything from Texinfo, so we can remove some redundant Makefile pattern rules and the rule for generating the version.texi file that used to be included from many Texinfo source files. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- Makefile | 31

[PATCH v5 20/20] Remove texinfo dependency from docker and CI configs

2020-08-10 Thread Peter Maydell
We don't need texinfo to build the docs any more, so we can drop that dependency from our docker and other CI configs. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- Changes v4->v5: remove texinfo from ubuntu2004.docker too --- .travis.yml| 1 -

[PATCH v5 14/20] scripts/qapi: Remove texinfo generation support

2020-08-10 Thread Peter Maydell
We no longer use the generated texinfo format documentation, so delete the code that generates it, and the test case for the generation. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- Makefile| 1 - scripts/qapi-gen.py | 2 -

[PATCH v5 19/20] configure: Drop texinfo requirement

2020-08-10 Thread Peter Maydell
We don't need the texinfo and pod2man programs to build our documentation any more, so remove them from configure's tests. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- configure | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/configure

[PATCH v5 13/20] qga/qapi-schema.json: Add some headings

2020-08-10 Thread Peter Maydell
Add some section headings to the QGA json; this is purely so that we have some H1 headings, as otherwise each command ends up being visible in the interop/ manual's table of contents. In an ideal world there might be a proper 'Introduction' section the way there is in qapi/qapi-schema.json.

[PATCH v5 09/20] docs/sphinx: Add new qapi-doc Sphinx extension

2020-08-10 Thread Peter Maydell
Some of our documentation is auto-generated from documentation comments in the JSON schema. For Sphinx, rather than creating a file to include, the most natural way to handle this is to have a small custom Sphinx extension which processes the JSON file and inserts documentation into the rST file

[PATCH v5 17/20] scripts/texi2pod: Delete unused script

2020-08-10 Thread Peter Maydell
We no longer need the texi2pod script, so we can delete it, and the special-casing it had in the checkpatch script. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- scripts/checkpatch.pl | 2 +- scripts/texi2pod.pl | 536 -- 2 files

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:49, Paolo Bonzini wrote: > > On 10/08/20 21:45, Peter Maydell wrote: > >> Note that if you don't install it, you just get the previous behavior > >> (plus a warning). But if you want that, it would be simply "gettext" I > >> guess. You're using tests/vm/*bsd right? > >

[PATCH v5 18/20] Remove Texinfo related files from .gitignore and git.orderfile

2020-08-10 Thread Peter Maydell
We don't use Texinfo any more; we can remove the references to the .texi source files and the generated output files from our .gitignore and git.orderfile. Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- .gitignore| 15 --- scripts/git.orderfile | 1 -

[PATCH v5 10/20] docs/interop: Convert qemu-ga-ref to rST

2020-08-10 Thread Peter Maydell
Convert qemu-ga-ref to rST format. This includes dropping the plain-text, pdf and info format outputs for this document; as with all our other Sphinx-based documentation, we provide HTML and manpage only. The qemu-ga-ref.rst is somewhat more stripped down than the .texi was, because we do not

[PATCH v5 15/20] docs/devel/qapi-code-gen.txt: Update to new rST backend conventions

2020-08-10 Thread Peter Maydell
Update the documentation of QAPI document comment syntax to match the new rST backend requirements. The principal changes are: * whitespace is now significant, and multiline definitions must have their second and subsequent lines indented to match the first line * general rST format markup

[PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

2020-08-10 Thread Peter Maydell
Make the handling of indentation in doc comments more sophisticated, so that when we see a section like: Notes: some text some more text indented line 3 we save it for the doc-comment processing code as: some text some more text indented line 3 and when we see a section

[PATCH v5 05/20] qapi/machine.json: Escape a literal '*' in doc comment

2020-08-10 Thread Peter Maydell
For rST, '*' is a kind of inline markup (for emphasis), so "*-softmmu" is a syntax error because of the missing closing '*'. Escape the '*' with a '\'. The texinfo document generator will leave the '\' in the output, which is not ideal, but that generator is going to go away in a subsequent

[PATCH v5 12/20] qapi: Use rST markup for literal blocks

2020-08-10 Thread Peter Maydell
There are exactly two places in our json doc comments where we use the markup accepted by the texi doc generator where a '|' in the first line of a doc comment means the line should be emitted as a literal block (fixed-width font, whitespace preserved). Since we use this syntax so rarely, instead

[PATCH v5 11/20] docs/interop: Convert qemu-qmp-ref to rST

2020-08-10 Thread Peter Maydell
Convert qemu-qmp-ref to rST format. This includes dropping the plain-text, pdf and info format outputs for this document; as with all our other Sphinx-based documentation, we provide HTML and manpage only. The qemu-qmp-ref.rst is somewhat more stripped down than the .texi was, because we do not

[PATCH v5 02/20] qapi: Fix indentation, again

2020-08-10 Thread Peter Maydell
In commit 26ec4e53f2 and similar commits we fixed the indentation for doc comments in our qapi json files to follow a new stricter standard for indentation, which permits only: @arg: description line 1 description line 2 or: @arg: line 1 line 2 Unfortunately since we

[PATCH v5 04/20] qapi/qapi-schema.json: Put headers in their own doc-comment blocks

2020-08-10 Thread Peter Maydell
Our current QAPI doc-comment markup allows section headers (introduced with a leading '=' or '==') anywhere in any documentation comment. This works for texinfo because the texi generator simply prints a texinfo heading directive at that point in the output stream. For rST generation, since

[PATCH v5 07/20] scripts/qapi: Move doc-comment whitespace stripping to doc.py

2020-08-10 Thread Peter Maydell
As we accumulate lines from doc comments when parsing the JSON, the QAPIDoc class generally strips leading and trailing whitespace using line.strip() when it calls _append_freeform(). This is fine for Texinfo, but for rST leading whitespace is significant. We'd like to move to having the text in

[PATCH v5 06/20] tests/qapi/doc-good.json: Prepare for qapi-doc Sphinx extension

2020-08-10 Thread Peter Maydell
doc-good.json tests doc comment parser corner cases. We're about to largely replace it by a Sphinx extension, which will have different corner cases. Tweak the test so it passes both with the old parser and the Sphinx extension, by making it match the more restrictive rST syntax: * in a single

[PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-08-10 Thread Peter Maydell
This series switches all our QAPI doc comments over from texinfo format to rST. It then removes all the texinfo machinery, because this was the last user of texinfo. This is largely just a rebase of patchset v4 to current master. I've had to add three new patches at the front which fix up newly

[PATCH v5 01/20] qapi/migration.json: Fix indentation

2020-08-10 Thread Peter Maydell
Commits 6a9ad1542065ca0bd54c6 and 9004db48c080632aef23 added some new text to qapi/migration.json which doesn't fit the stricter indentation requirements imposed by the rST documentation generator. Reindent those lines to the new standard. Reviewed-by: Markus Armbruster Reviewed-by: Richard

[PATCH v5 03/20] qapi/block-core.json: Fix nbd-server-start docs

2020-08-10 Thread Peter Maydell
Commit eed8b6917832 added some new text to the nbd-server-start documentation in the wrong place. Since this is after the 'Returns:' line it's parsed as if it were part of the documentation of the "Returns:' information. Move it up to join the rest of the "documentation of the type as a whole"

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:27, Peter Maydell wrote: >> Missing dependency, you have to install python3-setuptools. > since that's a new dependency, is it possible to make it be > diagnosed in a more friendly way than "python barfs out a backtrace" ? Ok, will do. Testing if "import pkg_resources" works is

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:45, Peter Maydell wrote: >> Note that if you don't install it, you just get the previous behavior >> (plus a warning). But if you want that, it would be simply "gettext" I >> guess. You're using tests/vm/*bsd right? > Yes. Unless there's a strong reason for testing the no-gettext

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:36, Paolo Bonzini wrote: > On 10/08/20 21:26, Peter Maydell wrote: > >> This is a real warning. I'll see if we can add a configure option to > >> disable the translations bug it's fairly low priority. > > Is there a package that we could install on these VM configs > >

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:36, Peter Maydell wrote: >> It should be possible and probably not too hard once I figure out how >> Sphinx events work. It's a fair request since build_always_stale is >> inferior and Meson requires no particular magic to include the depfile. >> Maybe that will win you over. :)

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:01, Daniele Buono wrote: > So I'm thinking of adding a check in configure. If gold is the linker, > automatically create (somehow, still working on it) the full link script > by obtaining the default bfd script and add the required parts. Would > that work for you? Maybe even do it

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:26, Peter Maydell wrote: >> This is a real warning. I'll see if we can add a configure option to >> disable the translations bug it's fairly low priority. > Is there a package that we could install on these VM configs > that would provide gettext in a way that satisfies Meson?

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:31, Paolo Bonzini wrote: > > On 10/08/20 21:21, Peter Maydell wrote: > >> Yes, because the Makefile's approach is not maintainable in my opinion; > >> *.rst.inc files were already not included in the Makefile. I'll look > >> into using a Sphinx extension to produce a

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:21, Peter Maydell wrote: >> Yes, because the Makefile's approach is not maintainable in my opinion; >> *.rst.inc files were already not included in the Makefile. I'll look >> into using a Sphinx extension to produce a dependency file. > > Yeah, agreed that the makefile approach

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:26, Paolo Bonzini wrote: > > On 10/08/20 20:09, Peter Maydell wrote: > > ModuleNotFoundError: No module named 'pkg_resources' > > > > ERROR: meson setup failed > > Missing dependency, you have to install python3-setuptools. since that's a new dependency, is it possible

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:22, Paolo Bonzini wrote: > > On 10/08/20 21:16, Peter Maydell wrote: > > And the remainders: > > > > The tests/vm FreeBSD and OpenBSD setups succeed but emit this warning > > (as well as the the usual ones): > > > > WARNING: Gettext not found, all translation targets

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 20:09, Peter Maydell wrote: > ModuleNotFoundError: No module named 'pkg_resources' > > ERROR: meson setup failed Missing dependency, you have to install python3-setuptools. But it will fail just as aarch64 due to the same incorrect line. > make: *** Deleting file 'config-host.mak'

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 21:16, Peter Maydell wrote: > And the remainders: > > The tests/vm FreeBSD and OpenBSD setups succeed but emit this warning > (as well as the the usual ones): > > WARNING: Gettext not found, all translation targets will be ignored. This is a real warning. I'll see if we can add a

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:06, Paolo Bonzini wrote: > > On 10/08/20 20:33, Peter Maydell wrote: > > Does "build_always_stale: true" do what I guess it does from the > > name? Does this mean we're discarding the makefile's approach of > > only running sphinx if it's necessary in favour of always

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 20:20, Peter Maydell wrote: > > In file included from ../../contrib/vhost-user-scsi/vhost-user-scsi.c:15:0: > /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function > ‘scsi_set_uint16’ declared but never defined [-Werror] > inline void scsi_set_uint16(unsigned char *c,

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 19:09, Peter Maydell wrote: > The other hosts are still running, will report results as > they finish. And the remainders: The tests/vm FreeBSD and OpenBSD setups succeed but emit this warning (as well as the the usual ones): WARNING: Gettext not found, all translation

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 19:52, Paolo Bonzini wrote: > > On 10/08/20 20:20, Peter Maydell wrote: > > (Looks like an error in the version of the system header > > file on this system, which, unlike my x86 box, defines > > the prototypes with "inline" (a change that came in upstream > > in commit > >

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Paolo Bonzini
On 10/08/20 20:33, Peter Maydell wrote: > On Mon, 10 Aug 2020 at 19:16, Paolo Bonzini wrote: >> >> Signed-off-by: Marc-André Lureau >> Signed-off-by: Paolo Bonzini > >> diff --git a/configure b/configure >> index 21b9ed2..7e7b4d8 100755 >> --- a/configure >> +++ b/configure >> @@ -7768,7

Re: [PATCH 2/2] configure: add support for Control-Flow Integrity

2020-08-10 Thread Daniele Buono
Hi Alex, Paolo Hitting a small issue while adding support for lto (and therefore cfi) to the fuzzer. The fuzzer requires a modified linker script to place all of the stuff that needs to persist across fuzzing runs into a contiguous section of memory. It does that by inserting three new

Re: [PATCH v8 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-08-10 Thread Francisco Iglesias
On Tue, Aug 04, 2020 at 02:11:43PM -0700, Vikram Garhwal wrote: > Connect CAN0 and CAN1 on the ZynqMP. > > Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias > --- > hw/arm/xlnx-zcu102.c | 20 > hw/arm/xlnx-zynqmp.c | 34

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 20:14, Peter Maydell wrote: > Linux x86-64 succeeded but produced a bunch of warnings: > > ../../meson.build:9: WARNING: Module unstable-keyval has no backwards > or forwards compatibility and might not exist in future releases. This is unavoidable (it's fixed in 0.56.0 but will warn

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 20:20, Peter Maydell wrote: > (Looks like an error in the version of the system header > file on this system, which, unlike my x86 box, defines > the prototypes with "inline" (a change that came in upstream > in commit >

[Bug 1793539] Re: qemu:handle_cpu_signal received signal outside vCPU context @ pc=0x6003ddc5

2020-08-10 Thread Andreas Schwab
As you can see in the build log the package builds sucessfully. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1793539 Title:

Re: [PATCH v8 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-08-10 Thread Francisco Iglesias
Hi Vikram, On Tue, Aug 04, 2020 at 02:11:44PM -0700, Vikram Garhwal wrote: > The QTests perform five tests on the Xilinx ZynqMP CAN controller: > Tests the CAN controller in loopback, sleep and snoop mode. > Tests filtering of incoming CAN messages. > > Signed-off-by: Vikram Garhwal >

Re: [PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 19:16, Paolo Bonzini wrote: > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > diff --git a/configure b/configure > index 21b9ed2..7e7b4d8 100755 > --- a/configure > +++ b/configure > @@ -7768,7 +7768,6 @@ echo "INSTALL_PROG=$install -c -m 0755" >> >

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 19:09, Peter Maydell wrote: > The other hosts are still running, will report results as > they finish. These are just the ones that bailed out > immediately. Linux x86-64 succeeded but produced a bunch of warnings: ../../meson.build:9: WARNING: Module unstable-keyval has

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 18:09, Paolo Bonzini wrote: > > This version is substantially less "draft-like", and the diffstat > is actually quite large with Thursday's draft. > > The changes are as follows: > - updated oss-fuzz build script > - various cases fixed that broke depending on

Re: [PATCH v1 1/1] hyperv: Enable SCONTROL if SYNIC is enabled

2020-08-10 Thread Jon Doron
I think both patches are On Mon, Aug 10, 2020, 20:27 Paolo Bonzini wrote: > On 17/07/20 14:56, Jon Doron wrote: > > Based on an analysis of the HyperV firmwares (Gen1 and Gen2) it seems > > like the SCONTROL is not being set to the ENABLED state as like we have > > thought. > > > > Also from a

Re: [PATCH v1 1/1] hyperv: Enable SCONTROL if SYNIC is enabled

2020-08-10 Thread Paolo Bonzini
On 17/07/20 14:56, Jon Doron wrote: > Based on an analysis of the HyperV firmwares (Gen1 and Gen2) it seems > like the SCONTROL is not being set to the ENABLED state as like we have > thought. > > Also from a test done by Vitaly Kuznetsov, running a nested HyperV it > was concluded that the first

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 19:09, Peter Maydell wrote: > The other hosts are still running, will report results as > they finish. ppc64be host: In file included from ../../contrib/vhost-user-scsi/vhost-user-scsi.c:15:0: /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function

Re: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence

2020-08-10 Thread Cédric Le Goater
On 8/7/20 1:42 AM, Joel Stanley wrote: > On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: >> >> BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until >> the bit is cleared by HW. Add definitions for the default value of >> this register and fix the reset sequence by clearing

[PATCH 145/147] acceptance: use stable URLs for the Debian and Ubuntu installer

2020-08-10 Thread Paolo Bonzini
The kernel and initrd hashes seem to have changed for the Bionic aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt to fail. Correct the paths to use the previous binaries instead of the latest. Do the same for the Lenny alpha installer for consistency, even though those

[PATCH 143/147] meson: convert po/

2020-08-10 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 5 +--- configure | 2 +- meson.build| 3 +++ po/LINGUAS | 7 ++ po/Makefile| 52 - po/POTFILES| 1 + po/meson.build

Re: [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-10 Thread Cédric Le Goater
On 8/10/20 3:43 PM, Mauro Matteo Cascella wrote: > On Thu, Aug 6, 2020 at 3:21 PM Cédric Le Goater wrote: >> >> When inserting the VLAN tag in packets, memmove() can generate an >> integer overflow for packets whose length is less than 12 bytes. >> >> Check length against the size of the ethernet

[PATCH 144/147] meson: update build-system documentation

2020-08-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/build-system.txt | 401 +++- 1 file changed, 213 insertions(+), 188 deletions(-) diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt index fea67b2..df5b949 100644 ---

[PATCH 138/147] rules.mak: drop unneeded macros

2020-08-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitignore | 1 - Makefile| 7 +- configure | 32 +- docs/devel/build-system.txt | 5 +- rules.mak | 231 +--- scripts/create_config

[PATCH 147/147] meson: avoid unstable module warning with Meson 0.56.0 or newer

2020-08-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6556a48..8551ed5 100644 --- a/meson.build +++ b/meson.build @@ -3,7 +3,11 @@ project('qemu', ['c', 'cpp'], meson_version: '>=0.55.0',

[PATCH 135/147] meson: sphinx-build

2020-08-10 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 142 +++-- configure | 1 - docs/index.html.in | 4 +- docs/meson.build | 68 + meson.build| 2 + rules.mak

[PATCH 146/147] cflags Signed-off-by: Paolo Bonzini

2020-08-10 Thread Paolo Bonzini
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 5d64337..82877f1 100755 --- a/configure +++ b/configure @@ -6569,7 +6569,7 @@ EOF update_cxxflags -if do_cxx $QEMU_CXXFLAGS -o $TMPE $TMPCXX $TMPO $QEMU_LDFLAGS; then +if

[PATCH 141/147] meson: move SDL and SDL-image detection to meson

2020-08-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- configure | 142 +++- meson.build | 27 +++--- meson_options.txt | 2 + ui/meson.build | 4 +- 5 files changed, 33 insertions(+), 144 deletions(-)

[PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-10 Thread Paolo Bonzini
Move the create-config logic to meson.build; create a configuration_data object and let meson handle the quoting and output. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- block.c| 4 +- configure | 9 ++- meson.build

[PATCH 132/147] meson: convert systemtap files

2020-08-10 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 85 ++- meson.build | 26 + rules.mak | 3 -- trace/meson.build | 14 - 4 files changed, 35

  1   2   3   4   >