** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840719
Title:
win98se floppy fails to boot with isapc machine
Status in QEMU:
Fix
On Thu, Aug 13, 2020 at 12:24:50PM +0800, Jason Wang wrote:
>
> On 2020/8/10 下午3:46, Yan Zhao wrote:
> > > driver is it handled by?
> > It looks that the devlink is for network device specific, and in
> > devlink.h, it says
> > include/uapi/linux/devlink.h - Network physical device Netlink
> > int
Patchew URL:
https://patchew.org/QEMU/20200814035819.1214-1-jiangyi...@huawei.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
On Fri, Aug 14, 2020 at 01:12:19AM +0200, Greg Kurz wrote:
> Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to
> support the -prom-env parameter"), pseries machines can pre-initialize
> the "system" partition in the NVRAM with the data passed to all -prom-env
> parameters on the
On Thu, Aug 13, 2020 at 05:38:59PM -0300, Gustavo Romero wrote:
> Hi Greg,
>
> On 8/13/20 2:28 PM, Greg Kurz wrote:
> > static inline size_t xive_source_esb_len(XiveSource *xsrc)
> > {
> > return (1ull << xsrc->esb_shift) * xsrc->nr_irqs;
> > }
> >
> > Signed-off-by: Greg Kurz
> > ---
> > F
On Thu, Aug 13, 2020 at 11:39:27PM +0200, Greg Kurz wrote:
> On Thu, 13 Aug 2020 16:57:04 -0300
> Daniel Henrique Barboza wrote:
>
> > Greg,
> >
> > This patch is breaking guest startup in ppc-for-5.2 for me. The process
> > gives an almost instant segfault. Here's what I'm doing:
> >
>
> Ok,
When the cause number is equal to or greater than 23, print "(unknown)" in
trace_riscv_trap. The max valid number of riscv_excp_names is 23, so the last
excpetion "guest_store_page_fault" can not be printed.
In addition, the current check of cause is invalid for riscv_intr_names. So
introduce risc
On Fri, Aug 7, 2020 at 2:36 AM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote:
> > +float flmul;
>
> int8_t? It seems weird that the translator wouldn't also use...
>
It was kept for vector check functions.
However, I've removed flo
On Fri, Aug 7, 2020 at 8:04 AM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 8/6/20 3:46 AM, frank.ch...@sifive.com wrote:
> > +static inline uint32_t vext_max_elems(uint32_t desc, uint32_t esz, bool
> is_ldst)
> > {
> > -return simd_maxsz(desc) << vext_lmul(desc);
> > +/*
在 2020/8/14 上午10:43, Kaige Li 写道:
On 08/13/2020 06:37 PM, Jiaxun Yang wrote:
在 2020/8/13 下午5:41, Kaige Li 写道:
Add definition of the Loongson-3A3000 processor in QEMU.
Hi Kaige,
We're not defining Loongson-3A3000 in QEMU because we have
some features like Loongson-EXT2, VTLB not availab
在 2020/8/14 上午2:15, Philippe Mathieu-Daudé 写道:
The cache operation is encoded in bits [20:18] of the instruction.
The 'op' argument of helper_cache() contains the bits [20:16].
Extract the 3 bits and parse them using a switch case. This allow
us to handle multiple cache types (the cache type i
在 2020/8/14 上午2:15, Philippe Mathieu-Daudé 写道:
QEMU does not model caches, so there is not much to do with the
Invalidate/Writeback opcodes. Make it explicit adding a comment.
Suggested-by: Jiaxun Yang
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Jiaxun Yang
Thanks~
---
targe
On 08/13/2020 06:37 PM, Jiaxun Yang wrote:
在 2020/8/13 下午5:41, Kaige Li 写道:
Add definition of the Loongson-3A3000 processor in QEMU.
Hi Kaige,
We're not defining Loongson-3A3000 in QEMU because we have
some features like Loongson-EXT2, VTLB not available currently, I'd
prefer define it aft
On 8/7/2020 4:13 PM, Kevin Wolf wrote:
Am 07.08.2020 um 09:42 hat Ying Fang geschrieben:
On 8/6/2020 5:13 PM, Kevin Wolf wrote:
Am 05.08.2020 um 04:38 hat Ying Fang geschrieben:
From: fangying
When qemu or qemu-nbd process uses a qcow2 image and configured with
'cache = none', it will w
David Hildenbrand 于2020年8月14日周五 上午1:15写道：
>
> On 13.08.20 18:46, Li Qiang wrote:
>
> For now we use "virtio-mem:" for the subject, without the "hw: "part.
>
> > If error occurs while processing the virtio request we should call
> > 'virtqueue_detach_element' to detach the element from the virtqueu
Laszlo Ersek 于2020年8月14日周五 上午4:21写道：
>
> On 08/13/20 17:36, Li Qiang wrote:
> > Just use 'while (true)' to avoid duplicated.
> > No function change.
> >
> > Signed-off-by: Li Qiang
> > ---
> > hw/display/virtio-gpu.c | 8 +---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff
在 2020/8/12 17:52, Dr. David Alan Gilbert 写道:
* Longpeng(Mike) (longpe...@huawei.com) wrote:
The vsock channel is more widely use in some new features, for example,
the Nitro/Enclave. It can also be used as the migration channel.
Signed-off-by: Longpeng(Mike)
OK; it might be worth adding
Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to
support the -prom-env parameter"), pseries machines can pre-initialize
the "system" partition in the NVRAM with the data passed to all -prom-env
parameters on the QEMU command line.
In this case it is assumed that all the data fi
Patchew URL:
https://patchew.org/QEMU/20200813222625.243136-1-ehabk...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
Patchew URL:
https://patchew.org/QEMU/20200813222625.243136-1-ehabk...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ==
On 8/13/20 7:00 PM, Greg Kurz wrote:
On Thu, 13 Aug 2020 17:38:59 -0300
Gustavo Romero wrote:
Hi Greg,
Hi Gustavo,
On 8/13/20 2:28 PM, Greg Kurz wrote:
static inline size_t xive_source_esb_len(XiveSource *xsrc)
{
return (1ull << xsrc->esb_shift) * xsrc->nr_irqs;
}
Signed-off-by: G
Patchew URL:
https://patchew.org/QEMU/20200813222625.243136-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200813222625.243136-1-ehabk...@redhat.com
Subject: [PATCH 00/41] qom: Automated conver
Can you test with mainline GDB and not a fork?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1889411
Title:
RISC-V: Unable to unwind the stack upon signals
Status in QEMU:
New
Bug description:
Le 13/08/2020 à 17:55, Greg Kurz a écrit :
> Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to
> support the -prom-env parameter"), pseries machines can pre-initialize
> the "system" partition in the NVRAM with the data passed to all -prom-env
> parameters on the QEMU command lin
Many QOM types don't follow the Type/TypeClass pattern
on the instance/struct names. Let the class struct name
be specified in the OBJECT_DECLARE* macros.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 35 ++-
1 file changed, 18 insertions(+), 17 delet
I'm marking this as fix committed, although the fix isn't yet in master
it's in the RISC-V tree and will be in master soon.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https
Replace DECLARE_OBJ_CHECKERS with OBJECT_DECLARE_TYPE where the
typedefs can be safely removed.
Generated running:
$ ./scripts/codeconverter/converter.py -i \
--pattern=DeclareObjCheckers $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
hw/audio/intel-hda.h| 6
This started as a simple script that scanned for regular
expressions, but became more and more complex when exceptions to
the rules were found.
I don't know if this should be maintained in the QEMU source tree
long term (maybe it can be reused for other code transformations
that Coccinelle can't h
Generated using:
$ ./scripts/codeconverter/converter.py -i \
--pattern=QOMDuplicatedTypedefs $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
include/crypto/secret_keyring.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/crypto/secret_key
From: Daniel P. Berrangé
This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro
families in the secret types, in order to eliminate boilerplate code.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20200723181410.3145233-4-berra...@redhat.com>
[ehabkost: rebase, update to pass add
From: Daniel P. Berrangé
This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro
families in the TLS creds types, in order to eliminate boilerplate code.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20200723181410.3145233-5-berra...@redhat.com>
[ehabkost: rebase, update to pass
Provide a TYPE_INFO macro that can be used to register a TypeInfo
struct declaratively. This will allow QOM type registration to
be 100% declarative.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/inclu
The existing type check macros all unconditionally drop const
qualifiers from their arguments. Keep this behavior in the
macros generated by DECLARE_*CHECKER* by now.
In the future, we might use _Generic to preserve const-ness of
the cast function arguments.
Signed-off-by: Eduardo Habkost
---
Generated using:
$ ./scripts/codeconverter/converter.py -i \
--pattern=ObjectDeclareType $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
include/authz/list.h| 7 ++-
include/authz/listfile.h| 7 ++-
include/authz/pamacct.h | 7
From: Daniel P. Berrangé
When creating new QOM types, there is a lot of boilerplate code that
must be repeated using a standard pattern. This is tedious to write
and liable to suffer from subtle inconsistencies. Thus it would
benefit from some simple automation.
QOM was loosely inspired by GLib'
Sometimes the typedefs are buried inside another header, but
we want to benefit from the automatic definition of type cast
functions. Introduce macros that will let type checkers be
defined when typedefs are already available.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 72 +++
ModuleObjName##Class was being used instead of ModuleObjName.
Fix it.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index be64421089..f515230f61 100644
--- a/include/qom/obje
This should be fixed once the current RISC-V branch is merged into
master.
You can see the patch that fixes this here:
https://patchew.org/QEMU/20200812223045.96803-1-alistair.fran...@wdc.com/20200812223045.96803-18-alistair.fran...@wdc.com/
** Changed in: qemu
Assignee: (unassigned) => Alis
From: Daniel P. Berrangé
The object_ref/unref methods are intended for use with any subclass of
the base Object. Using "Object *" in the signature is not adding any
meaningful level of type safety, since callers simply use "OBJECT(ptr)"
and this expands to an unchecked cast "(Object *)".
By usin
CanBusClass doesn't exist. This will break when we automatically
convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros
that reference the non-existing typedef.
Signed-off-by: Eduardo Habkost
---
include/net/can_emu.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/net/
The macro never worked because the NubusBridge typedef doesn't
exist. Delete it.
Signed-off-by: Eduardo Habkost
---
include/hw/nubus/nubus.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
index a8634e54c5..c350948262 100644
--- a/include/h
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/hw/m68k/mcf_fec.h | 1 +
hw/net/mcf_fec.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/includ
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/hw/s390x/s390_flic.h | 1 +
hw/intc/s390_flic_kvm.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/hw/pci/pci.h | 1 +
include/hw/pci/pci_bus.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/
Some of the enum constant names conflict with the QOM type check
macros. This needs to be addressed to allow us to transform the
QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_U_DEV_*, to avoid conflicts.
Signed-off-by: Eduardo Habkost
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/hw/timer/i8254.h | 2 ++
include/hw/timer/i8254_internal.h | 8
2 files changed, 6 insertions(+), 4 deletions(-)
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
hw/net/tulip.h | 1 +
hw/net/tulip.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/net/tulip.h b/hw/net/tuli
The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME
macro. This will be necessary to allow us to use OBJECT_DEFINE*()
for TYPE_HVF_ACCEL.
Signed-off-by: Eduardo Habkost
---
include/sysemu/hvf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/sysemu/hvf.h b/include/sysemu/
Separate run of the script using the --force flag, for the cases
where the typedef wasn't found in the same header.
Generated using:
$ ./scripts/codeconverter/converter.py --force -i \
--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
This is being done as a separate commit because it h
Signed-off-by: Eduardo Habkost
---
hw/pci-host/versatile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c
index 616882a80d..7e4aa467a2 100644
--- a/hw/pci-host/versatile.c
+++ b/hw/pci-host/versatile.c
@@ -161,7 +161,7 @@ stat
Rename the MEGASAS_DEVICE_CLASS() and MEGASAS_DEVICE_GET_CLASS()
macros to be consistent with the MEGASAS() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Signed-off-by: Eduardo Habkost
---
hw/scsi/megasas.c | 12 ++--
1 file ch
This is an extension of the series previously submitted by
Daniel[1], including a script that will convert existing type
checker macros automatically.
The series is divided in the following sections:
Constant renaming
-
Patches 1-10 will just rename existing constants that will
c
The macro was incorrectly defined using OBJECT_CHECK.
Signed-off-by: Eduardo Habkost
---
hw/s390x/virtio-ccw.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h
index c0e3355248..b281896f7d 100644
--- a/hw/s390x/virtio-ccw.h
+++
PlatformBusDeviceClass doesn't exist. This will break when we
automatically convert the code to use OBJECT_DEFINE_TYPE().
Delete the macros that reference the non-existing typedef.
Signed-off-by: Eduardo Habkost
---
include/hw/platform-bus.h | 4
1 file changed, 4 deletions(-)
diff --git
Some of the enum constant names conflict with the QOM type check
macros. This needs to be addressed to allow us to transform the
QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to ASPEED_DEV_*, to avoid conflicts.
Signed-off-by: Eduardo Habkost
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/block/throttle-groups.h | 1 +
block/throttle-groups.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --
Rename the PVSCSI_DEVICE_CLASS() and PVSCSI_DEVICE_GET_CLASS()
macros to be consistent with the PVSCSI() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Signed-off-by: Eduardo Habkost
---
hw/scsi/vmw_pvscsi.c | 8
1 file changed
Some of the enum constant names conflict with the QOM type check
macros. This needs to be addressed to allow us to transform the
QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to IBEX_DEV_*, to avoid conflicts.
Signed-off-by: Eduardo Habkost
--
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Signed-off-by: Eduardo Habkost
---
include/sysemu/hvf.h | 1 +
target/i386/hvf/hvf-i386.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/incl
Rename the DWC2_CLASS to DWC2_USB_CLASS and DWC2_GET_CLASS to
DWC2_USB_GET_CLASS, for consistency with the DWC2_USB macro.
Signed-off-by: Eduardo Habkost
---
hw/usb/hcd-dwc2.h | 4 ++--
hw/usb/hcd-dwc2.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/usb/hcd-dwc2
Some of the enum constant names conflict with the QOM type check
macros. This needs to be addressed to allow us to transform the
QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_E_DEV_*, to avoid conflicts.
Signed-off-by: Eduardo Habkost
Rename the E1000_DEVICE_CLASS() and E1000_DEVICE_GET_CLASS()
macros to be consistent with the E1000() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Signed-off-by: Eduardo Habkost
---
hw/net/e1000.c | 8
1 file changed, 4 inser
Some of the enum constant names conflict with the QOM type check
macros. This needs to be addressed to allow us to transform the
QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to AW_H3_DEV_*, to avoid conflicts.
Signed-off-by: Eduardo Habkost
-
The PL1110 enum value name will conflict with the PL1110 type
cast checker, when we replace the existing macro with an inline
function. Rename it to PL1110_STOCK.
Signed-off-by: Eduardo Habkost
---
hw/display/pl110.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The macro definition had an extra semicolon. This was never
noticed because the macro was only being used where it didn't
make a difference.
Signed-off-by: Eduardo Habkost
---
include/hw/timer/aspeed_timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/timer/as
On Thu, 13 Aug 2020 17:38:59 -0300
Gustavo Romero wrote:
> Hi Greg,
>
Hi Gustavo,
> On 8/13/20 2:28 PM, Greg Kurz wrote:
> > static inline size_t xive_source_esb_len(XiveSource *xsrc)
> > {
> > return (1ull << xsrc->esb_shift) * xsrc->nr_irqs;
> > }
> >
> > Signed-off-by: Greg Kurz
> >
On Thu, 13 Aug 2020 16:57:04 -0300
Daniel Henrique Barboza wrote:
> Greg,
>
> This patch is breaking guest startup in ppc-for-5.2 for me. The process
> gives an almost instant segfault. Here's what I'm doing:
>
Ok, this is because this patch should have been applied after
the "spapr: Cleanups
On Wed, Aug 12, 2020 at 9:12 PM Green Wan wrote:
>
> Hi Alistair,
>
> Thanks for the feedback and tips. Not sure whether I get it right. I gave a
> try with -drive and -device options as below.
>
> $ qemu-system-riscv64 -M sifive_u -drive if=none,format=raw,file=otp.img
> -device riscv.sifive.u.
On Wed, Aug 12, 2020 at 7:26 PM LIU Zhiwei wrote:
>
>
>
> On 2020/8/13 3:13, Alistair Francis wrote:
> > This series updates the experimental QEMU RISC-V Hypervisor spec to the
> > v0.6.1 draft implementation.
> >
> > THis includes support for the new 2-stage lookup instructions and the new
> > CS
On Thu, 13 Aug 2020 19:29:57 +0200
Philippe Mathieu-Daudé wrote:
> Now that our helper is ready for handling multiple IRQs, let
> qemu_vfio_open_pci() take an 'irq_count' argument.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
As with patch 2/ tying IRQ setup with the opening of a device see
On Thu, 13 Aug 2020 19:29:54 +0200
Philippe Mathieu-Daudé wrote:
> As we want to use more than one single IRQ, add a check that
> the device accept our request to use multiple IRQs.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> util/vfio-helpers.c | 6 ++
> util/trace-events | 1 +
>
On Thu, 13 Aug 2020 19:29:56 +0200
Philippe Mathieu-Daudé wrote:
> Let qemu_vfio_pci_init_irq() take an 'index' argument, so we can
> set the EventNotifier to a specific IRQ.
> Add a safety check. Since our helper is limited to one single IRQ
> we are safe.
>
> Our only user is the NVMe block dr
On Thu, 13 Aug 2020 19:29:52 +0200
Philippe Mathieu-Daudé wrote:
> Once opened, we will used the same IRQ type for all our event
> notifiers, so pass the argument when we open the PCI device,
> store the IRQ type in the driver state, and directly use the
> value saved in the state each time we ca
On Thu, Aug 13, 2020 at 9:48 AM Richard Henderson
wrote:
>
> On 8/13/20 7:46 AM, Alistair Francis wrote:
> >> Hi Alistair,
> >>
> >> As Chih-Min said, it's wrong here. He has given the correct patch code
> >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg728540.html
> >>
> >> We can eithe
> -Original Message-
> From: Igor Mammedov
> Sent: Thursday, August 13, 2020 8:56 AM
> To: Moger, Babu
> Cc: Daniel P. Berrangé ; ehabk...@redhat.com;
> m...@redhat.com; qemu-devel@nongnu.org; pbonz...@redhat.com;
> r...@twiddle.net
> Subject: Re: [PATCH v3 2/3] hw/i386: Add a new chec
On 8/10/20 11:07 PM, LIU Zhiwei wrote:
> if (el <= 2 && !arm_is_secure_below_el3(env)) {
> -if (env->cp15.cptr_el[2] & CPTR_TZ) {
> -return 2;
> -}
> -if (env->cp15.cptr_el[2] & CPTR_TFP) {
> -return 0;
> +if ((arm_hcr_el2_eff(env) & HCR_
This is the patch I posted in reply to Shu-Chun Weng's v2 at
https://lists.nongnu.org/archive/html/qemu-devel/2020-07/msg07589.html
with the patch comment adjusted. The patch itself got an official R-b
from Alex, and an informal ack from Shu-Chun.
I plan to include this in tcg-next for 5.2.
r
This has no functional change.
The current function structure is:
inline QEMU_ALWAYSINLINE
store_memop() {
switch () {
...
default:
qemu_build_not_reached();
}
}
inline QEMU_ALWAYSINLINE
store_helper() {
...
if (s
Hi Greg,
On 8/13/20 2:28 PM, Greg Kurz wrote:
static inline size_t xive_source_esb_len(XiveSource *xsrc)
{
return (1ull << xsrc->esb_shift) * xsrc->nr_irqs;
}
Signed-off-by: Greg Kurz
---
Follow-up on "ppc/xive: Rework setup of XiveSource::esb_mmio"
http://patchwork.ozlabs.org/project/qem
On 08/13/20 17:36, Li Qiang wrote:
> Just use 'while (true)' to avoid duplicated.
> No function change.
>
> Signed-off-by: Li Qiang
> ---
> hw/display/virtio-gpu.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
We need more information than just the mmu_idx in order
to create the proper exception syndrome. Only change the
function signature so far.
Signed-off-by: Richard Henderson
---
target/arm/mte_helper.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/arm/mte_
Supercedes: <20200812171946.2044791-1-richard.hender...@linaro.org>
We missed filling in the WnR bit for the syndrome reported
into ESR_ELx for the Tag Check Fail Data Abort.
r~
Richard Henderson (2):
target/arm: Pass the entire mte descriptor to mte_check_fail
target/arm: Fill in the WnR
According to AArch64.TagCheckFault, none of the other ISS values are
provided, so we do not need to go so far as merge_syn_data_abort.
But we were missing the WnR bit.
Tested-by: Andrey Konovalov
Reported-by: Andrey Konovalov
Signed-off-by: Richard Henderson
---
target/arm/mte_helper.c | 9 +++
Without hardware acceleration, a cryptographically strong
algorithm is too expensive for pauth_computepac.
Even with hardware accel, we are not currently expecting
to link the linux-user binaries to any crypto libraries,
and doing so would generally make the --static build fail.
So choose XXH64 a
The crypto overhead of emulating pauth can be significant for
some workloads. Add two boolean properties that allows the
feature to be turned off, on with the architected algorithm,
or on with an implementation defined algorithm.
We need two intermediate booleans to control the state while
parsin
The architected pauth algorithm is quite slow without
hardware support, and boot times for kernels that enable
use of the feature have been significantly impacted.
Version 1 blurb at
https://lists.nongnu.org/archive/html/qemu-devel/2020-08/msg02172.html
which contains larger study of the tradeof
The interface for object_property_add_bool is simpler,
making the code easier to understand.
Signed-off-by: Richard Henderson
---
target/arm/cpu64.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 022786
Greg,
This patch is breaking guest startup in ppc-for-5.2 for me. The process
gives an almost instant segfault. Here's what I'm doing:
$ sudo ./qemu-system-ppc64 -machine
pseries-5.1,accel=kvm,usb=off,dump-guest-core=off -m 65536\
-overcommit mem-lock=off -smp 4,sockets=4,cores=1,threads=1 -rtc
On 8/13/20 11:15 AM, Philippe Mathieu-Daudé wrote:
> switch (cache_operation) {
> -case 0b010:
> -/* Index Store Tag */
> +case 0b010: /* Index Store Tag */
> memory_region_dispatch_write(env->itc_tag, index, env->CP0_TagLo,
> MO_6
On 8/13/20 11:15 AM, Philippe Mathieu-Daudé wrote:
> #ifndef CONFIG_USER_ONLY
> +static const char *type_name[] = {
const char * const
Otherwise,
Reviewed-by: Richard Henderson
r~
Reviewed-by: Michael Rolnik
On Thu, Aug 13, 2020 at 7:50 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 8/12/20 8:53 AM, Thomas Huth wrote:
> > The examples look nicer when using "::" code blocks.
> > Also mention that "-d in_asm" only outputs instructions that have not
> > bee
Hi again,
Seems to be there is no solution for my problem :(
I have succeeded create NTVDMx64 patch on my Windows 10 installation, so i can
run directly 16 bit ms dos applications without any dos emulator.
I take the initiative to close the bug.
Bye
--
You received this bug notification becaus
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1815911
Title:
aptitude crashes qemu-m68k with handle_cpu_signal received signal
outsid
Hi Alex,
On 8/13/20 9:15 PM, Alex Williamson wrote:
> On Thu, 13 Aug 2020 20:02:45 +0200
> Auger Eric wrote:
>
>> Hi Alex,
>>
>> On 8/13/20 6:59 PM, Alex Williamson wrote:
>>> On Thu, 13 Aug 2020 15:37:08 +0800
>>> Chen Qun wrote:
>>>
Clang static code analyzer show warning:
hw/vfi
On Thu, 13 Aug 2020 20:02:45 +0200
Auger Eric wrote:
> Hi Alex,
>
> On 8/13/20 6:59 PM, Alex Williamson wrote:
> > On Thu, 13 Aug 2020 15:37:08 +0800
> > Chen Qun wrote:
> >
> >> Clang static code analyzer show warning:
> >> hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never r
On 12/08/2020 18.26, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 7/24/20 6:42 PM, Gerd Hoffmann wrote:
>> From: Thomas Huth
>>
>> If pixman is not installed, it is currently not possible to run:
>>
>> .../configure --disable-system --enable-tools
>>
>> Seems like there was a dependency from one
On 8/13/20 11:33 AM, Cornelia Huck wrote:
> On Fri, 7 Aug 2020 13:59:42 +0200
> Cornelia Huck wrote:
>
>> On Wed, 05 Aug 2020 12:35:01 +0100
>> Sean Mooney wrote:
>>
>>> On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote:
Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrot
On Thursday, August 13, 2020, Kaige Li wrote:
> This will help ensure that style guidelines are being maintained during
> subsequent changes.
>
> Signed-off-by: Kaige Li
> ---
Agreed.
Reviewed-by: Aleksandar Markovic
> target/mips/translate_init.inc.c | 61 --
>
QEMU does not model caches, so there is not much to do with the
Invalidate/Writeback opcodes. Make it explicit adding a comment.
Suggested-by: Jiaxun Yang
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/op_helper.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --
The cache operation is encoded in bits [20:18] of the instruction.
The 'op' argument of helper_cache() contains the bits [20:16].
Extract the 3 bits and parse them using a switch case. This allow
us to handle multiple cache types (the cache type is encoded in
bits [17:16]).
Previously the if() blo
1 - 100 of 291 matches
Mail list logo
