Re: [PATCH 66/77] target/microblaze: Use tcg_gen_lookup_and_goto_ptr

2020-08-27 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:59:39PM -0700, Richard Henderson wrote: > When goto_tb cannot be used due to branch page crossing, > or due to indirect jumping, tcg_gen_lookup_and_goto_ptr > can be used instead. > > Signed-off-by: Richard Henderson Hi Richard, This patch is for some reason causing s

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-27 Thread Markus Armbruster
Kevin Wolf writes: > Am 27.08.2020 um 13:06 hat Markus Armbruster geschrieben: >> Daniel P. Berrangé writes: >> >> > On Wed, Aug 26, 2020 at 07:28:24PM +0100, Daniel P. Berrangé wrote: >> >> On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: >> >> > Open questions: >> >> >

Re: [PATCH v2 05/21] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-08-27 Thread Cédric Le Goater
On 8/25/20 5:18 PM, Peter Maydell wrote: > On Tue, 25 Aug 2020 at 15:37, Erik Smit wrote: >> On Tue, Aug 25, 2020, 4:33 PM Peter Maydell wrote: >>> >>> On Wed, 19 Aug 2020 at 11:10, Cédric Le Goater wrote: From: erik-smit The BMC Firmware can be downloaded from :

Re: [PATCH 4/6] block, migration: add bdrv_finalize_vmstate helper

2020-08-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Aug 27, 2020 at 04:02:38PM +0300, Denis V. Lunev wrote: >> On 8/27/20 3:58 PM, Daniel P. Berrangé wrote: >> > On Thu, Jul 09, 2020 at 04:26:42PM +0300, Denis V. Lunev wrote: >> >> Right now bdrv_fclose() is just calling bdrv_flush(). >> >> >> >> The problem is

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-27 Thread Markus Armbruster
Rohit Shinde writes: > Hey Markus, > > Thanks for the clarification! No, I do not have patches for the same. I was > browsing through the bite sized tasks page and that did not mention these > details. I will keep this in mind however. For now, I will leave this task > and I might return to it at

Re: [PULL 0/3] Fixes 20200825 patches

2020-08-27 Thread Gerd Hoffmann
On Thu, Aug 27, 2020 at 11:23:58AM +0100, Peter Maydell wrote: > On Thu, 27 Aug 2020 at 08:20, Thomas Huth wrote: > > Peter, what is still missing that you could use the gitlab CI as gating > > tests, too? > > I think we're waiting on a respin of the scripts from > Cleber, aren't we? > > Also we

Re: [PATCH v6 03/20] seabios: add bios-microvm.bin binary

2020-08-27 Thread Gerd Hoffmann
On Thu, Aug 27, 2020 at 04:48:54PM +0200, Sergio Lopez wrote: > On Wed, Aug 26, 2020 at 12:52:37PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes > > 1 file changed, 0 insertions(+), 0 deletions(-) > > create mode 100644

Re: [PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

2020-08-27 Thread Thomas Huth
On 27/08/2020 17.00, Daniel P. Berrangé wrote: > On Mon, Aug 24, 2020 at 11:44:10AM +0200, Thomas Huth wrote: >> The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. >> We've got to exclude some build targets here to make sure that the job >> finishes in time again. The targets that a

Re: Contributor wanting to get started with simple contributions

2020-08-27 Thread Thomas Huth
On 28/08/2020 02.49, Rohit Shinde wrote: > Hey Thomas, > > Thanks for the in-depth response! I appreciate it a lot! > > > > On Wed, Aug 26, 2020 at 9:38 PM Thomas Huth > wrote: > > On 26/08/2020 17.00, Rohit Shinde wrote: > > Hey Thomas, > > > > I didn

Re: [PATCH v1 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-08-27 Thread Raphael Norwitz
On Thu, Aug 27, 2020 at 8:17 AM Michael S. Tsirkin wrote: > > On Tue, Aug 04, 2020 at 01:36:45PM +0300, Dima Stepanov wrote: > > Reference e-mail threads: > > - https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg01509.html > > - https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg05

Re: [PATCH v2 2/7] vhost: check queue state in the vhost_dev_set_log routine

2020-08-27 Thread Raphael Norwitz
On Mon, Aug 24, 2020 at 4:41 AM Dima Stepanov wrote: > > If the vhost-user-blk daemon provides only one virtqueue, but device was > added with several queues, then QEMU will send more VHOST-USER command > than expected by daemon side. The vhost_virtqueue_start() routine > handles such case by chec

Re: [PATCH v2 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-08-27 Thread Raphael Norwitz
Generally I’m happy with this. Some comments: On Mon, Aug 24, 2020 at 4:40 AM Dima Stepanov wrote: > > vhost-user devices can get a disconnect in the middle of the VHOST-USER > handshake on the migration start. If disconnect event happened right > before sending next VHOST-USER command, then the

Re: [PATCH] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs

2020-08-27 Thread Li Qiang
Kindly ping. Li Qiang 于2020年8月14日周五 上午12:52写道: > > If error occurs while processing the virtio request we should call > 'virtqueue_detach_element' to detach the element from the virtqueue > before free the elem. > > Signed-off-by: Li Qiang > --- > hw/virtio/virtio-pmem.c | 1 + > 1 file changed

Re: [PATCH v2] virtio-mem: detach the element from the virtqueue when error occurs

2020-08-27 Thread Li Qiang
Kindly ping. Li Qiang 于2020年8月16日周日 下午10:23写道: > > If error occurs while processing the virtio request we should call > 'virtqueue_detach_element' to detach the element from the virtqueue > before free the elem. > > Signed-off-by: Li Qiang > --- > Change since v1: > Change the subject > Avoid us

Re: Contributor wanting to get started with simple contributions

2020-08-27 Thread Rohit Shinde
Hey Thomas, Thanks for the in-depth response! I appreciate it a lot! On Wed, Aug 26, 2020 at 9:38 PM Thomas Huth wrote: > On 26/08/2020 17.00, Rohit Shinde wrote: > > Hey Thomas, > > > > I didn't really have any specific questions. I wanted to know if there > > was any part of qemu that I cou

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-27 Thread Rohit Shinde
Hey Markus, Thanks for the clarification! No, I do not have patches for the same. I was browsing through the bite sized tasks page and that did not mention these details. I will keep this in mind however. For now, I will leave this task and I might return to it at a later time. Thanks, Rohit. On

QEMU | Pipeline #182890686 has failed for master | 19591e9e

2020-08-27 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 19591e9e ( https://gitlab.com/qemu-project/qemu/-/commit/19591e9e0938ea5066984553c256a043bd5d822f ) Commit Message: Merge remote-tr

RE: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-27 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Thursday, August 27, 2020 4:19 PM > To: Dr. David Alan Gilbert > Cc: ehabk...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; > Moger, Babu ; pbonz...@redhat.com; > r...@twiddle.net > Subject: Re: [PATCH v5 0/8] Remove EPYC mode ap

Re: [PULL 00/13] virtio,pc,acpi: features, fixes

2020-08-27 Thread Peter Maydell
On Thu, 27 Aug 2020 at 14:40, Michael S. Tsirkin wrote: > > The following changes since commit 8e49197ca5e76fdb8928833b2649ef13fc5aab2f: > > Merge remote-tracking branch > 'remotes/hdeller/tags/target-hppa-v3-pull-request' into staging (2020-08-26 > 22:23:53 +0100) > > are available in the Git

[REPORT] Nightly Performance Tests - Thursday, August 27, 2020

2020-08-27 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-27 21:30:03 End Time (UTC) : 2020-08-27 22:02:58 Execution Time : 0:32:54.920498 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

Re: [PATCH 62/77] target/microblaze: Try to keep imm and delay slot together

2020-08-27 Thread Richard Henderson
On 8/27/20 12:17 PM, Edgar E. Iglesias wrote: > On Tue, Aug 25, 2020 at 01:59:35PM -0700, Richard Henderson wrote: >> If the last insn on a page is imm, or a branch with delay slot, >> then end a tb early if this has not begun the tb. If it has >> begun the tb, then we can allow the tb to span two

Re: [PATCH] libvhost-user: Add GCC_FMT_ATTR and fix format string

2020-08-27 Thread Marc-André Lureau
On Fri, Aug 28, 2020 at 1:10 AM Stefan Weil wrote: > Signed-off-by: Stefan Weil > Reviewed-by: Marc-André Lureau --- > contrib/libvhost-user/libvhost-user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-27 Thread Igor Mammedov
On Wed, 26 Aug 2020 15:10:46 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 25 Aug 2020 16:25:21 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > On Tue, 25 Aug 2020 09:15:04 +0100 > > > >

build broken with --enable-gcrypt

2020-08-27 Thread Richard Henderson
The meson conversion seems to have not been properly accomplished for the gcrypt option: we fail to link against -lgcrypt. I tried aping the nettle bits, like the following, but it has no effect. I don't understand how the "nettle" token works, honestly, since it doesn't appear to be used at all.

Re: [PATCH 00/20] target/arm: SVE2 preparatory patches

2020-08-27 Thread Richard Henderson
On 8/27/20 11:28 AM, Peter Maydell wrote: > On Sat, 15 Aug 2020 at 02:31, Richard Henderson > wrote: >> This is collection of cleanups and changes that are required by >> SVE2, but do not directly implement it. The final 3 patches are >> relevant to Peter's aa32 neon work. > > If you agree with

Re: [PATCH 73/77] target/microblaze: Convert dec_stream to decodetree

2020-08-27 Thread Richard Henderson
On 8/27/20 2:10 PM, Edgar E. Iglesias wrote: > I think you've got a typo here, get -> put. Oops, yes. r~

Re: [PATCH 73/77] target/microblaze: Convert dec_stream to decodetree

2020-08-27 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:59:46PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/microblaze/insns.decode | 6 > target/microblaze/translate.c | 64 ++ > 2 files changed, 55 insertions(+), 15 deletions(-) > > diff --git a/

[PATCH] libvhost-user: Add GCC_FMT_ATTR and fix format string

2020-08-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- contrib/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index 53f16bdf08..ff7ac876f4 100644 --- a/contrib/libvhost-user/libvhost-user

Re: [PATCH v5 00/10] preallocate filter

2020-08-27 Thread Vladimir Sementsov-Ogievskiy
21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where allocation is relatively expensive operation. We have to workaround it in Qemu, so here is a new f

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-27 Thread Igor Mammedov
On Thu, 27 Aug 2020 15:07:52 -0400 Eduardo Habkost wrote: > On Thu, Aug 27, 2020 at 07:03:14PM +0200, Igor Mammedov wrote: > > On Wed, 26 Aug 2020 16:03:40 +0100 > > Daniel P. Berrangé wrote: > > > > > On Wed, Aug 26, 2020 at 04:02:58PM +0200, Igor Mammedov wrote: > > > > On Wed, 26 Aug 2020 14

Re: [PATCH v2] configure: add --ninja option

2020-08-27 Thread Paolo Bonzini
Thanks, that might be worth fixing in Meson. Paolo Il gio 27 ago 2020, 17:57 Mark Cave-Ayland ha scritto: > On 26/08/2020 20:02, Paolo Bonzini wrote: > > > On Windows it is not possible to invoke a Python script as $NINJA. > > If ninja is present use it directly, while if it is not we can > > k

Re: [PULL 02/17] meson: Build qemu-nbd on macOS again

2020-08-27 Thread Paolo Bonzini
Even though I did include some patches for other subsystems, I would rather avoid doing that unless they only touch meson.build files. So I went with the minimal regression fix. Paolo Il gio 27 ago 2020, 22:00 Eric Blake ha scritto: > On 8/27/20 1:06 PM, Thomas Huth wrote: > > On 27/08/2020 18.

[PATCH 5/5] hw/hppa: Add power button emulation

2020-08-27 Thread Helge Deller
Emulate a power button switch, tell SeaBIOS the address via fw_cfg and bind the power button to the qemu UI. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 2bed498

[PATCH 2/5] hw/hppa: Make number of TLB and BTLB entries configurable

2020-08-27 Thread Helge Deller
Until now the TLB size was fixed at 256 entries. To allow operating systems to utilize more TLB entries in the future, we need to tell firmware how many TLB entries we actually support in the emulation. Firmware then reports this to the operating system via the PDC_CACHE_INFO call. This patch simp

[PATCH 4/5] hw/hppa: Inform SeaBIOS about fw_cfg port address

2020-08-27 Thread Helge Deller
Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 3 +-- hw/hppa/machine.c | 7 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardware.h index cdb7fa6240..bc258895c9 100644 --- a/hw/hppa/hppa_hardware.h +++ b/hw/hppa/hp

[PATCH 3/5] hw/hppa: Store boot device in fw_cfg section

2020-08-27 Thread Helge Deller
Signed-off-by: Helge Deller --- hw/hppa/machine.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index e9d84d0f03..4b35afc9d5 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -58,6 +58,12 @@ static uint64_t cpu_hppa_to_phys(void *opaque

[PATCH 0/5] hppa power button support and firmware fixes

2020-08-27 Thread Helge Deller
This patch adds emulation for a power button on hppa, makes the number of TLB/BTLB entries configurable from qemu and includes a new hppa firmware with some bugs fixed. Helge Deller (5): seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag hw/hppa: Make number of TLB and BTLB entries configurab

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-27 Thread Igor Mammedov
On Wed, 26 Aug 2020 13:45:51 -0500 Babu Moger wrote: > > > > -Original Message- > > From: Dr. David Alan Gilbert > > Sent: Wednesday, August 26, 2020 1:34 PM > > To: Moger, Babu > > Cc: Igor Mammedov ; Daniel P. Berrangé > > ; ehabk...@redhat.com; m...@redhat.com; Michal > > Privoznik

Re: [PULL 02/17] meson: Build qemu-nbd on macOS again

2020-08-27 Thread Eric Blake
On 8/27/20 1:06 PM, Thomas Huth wrote: On 27/08/2020 18.59, Paolo Bonzini wrote: From: Thomas Huth Before switching to the meson build system, we used to compile qemu-nbd for macOS, too, which is especially important for running the iotests there. Commit b7c70bf2c5 disabled it by accident, sin

[PULL 52/53] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Acked-by: David Gibson Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-8-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/pci-host/ppce500.c | 2 +- 1 file changed, 1 insertion(+

[PULL 50/53] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-6-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/arm/xlnx-zcu102.c

[PULL 49/53] sclpconsole: Use TYPE_* constants

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Acked-by: Cornelia Huck Reviewed-by: Li Qiang Reviewed-by: Thomas Huth Message-Id: <20200826184334.4120620-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/char/sclpconsole-lm.c | 2 +-

[PULL 48/53] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Reviewed-by: Michael S. Tsirkin Message-Id: <20200826184334.4120620-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/i386/amd_iommu.c | 2 +- 1 file changed, 1 inse

[PULL 46/53] etsec: Use TYPE_ETSEC_COMMON constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Acked-by: David Gibson Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/net/fsl_etsec/etsec.c | 2 +- 1 file changed, 1 insertio

[PULL 35/53] piix: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-37-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/

[PULL 36/53] auxbus: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-38-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/misc/auxbus.h | 3 +++ hw/misc/auxbus

[PULL 47/53] nios2_iic: Use TYPE_ALTERA_IIC constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/intc/nios2_iic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PULL 45/53] migration: Rename class type checking macros

2020-08-27 Thread Eduardo Habkost
Rename the macros to make them consistent with the MIGRATION_OBJ macro name. This will make future conversion to OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Juan Quintela Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-51-ehabk...@redhat.com> Signed-off-b

[PULL 33/53] vmbus: Move QOM macros to vmbus.h

2020-08-27 Thread Eduardo Habkost
Move all declarations related to TYPE_VMBUS to the same place in vmbus.h. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-35-ehabk...@redhat.com> Signed-off

[PULL 32/53] pckbd: Move QOM macro to header

2020-08-27 Thread Eduardo Habkost
Move the I8042 macro close to the TYPE_I8042 define. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-34-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost

[PULL 44/53] swim: Rename struct SWIM to Swim

2020-08-27 Thread Eduardo Habkost
Currently we have a SWIM typedef and a SWIM type checking macro, but OBJECT_DECLARE* would transform the SWIM macro into a function, and the function name would conflict with the SWIM typedef name. Rename the struct and typedef to "Swim". This will make future conversion to OBJECT_DECLARE* easier.

[PULL 42/53] nubus: Rename class type checking macros

2020-08-27 Thread Eduardo Habkost
Rename the existing class type checking macros to be consistent with the type name and instance type checking macro. Use a NUBUS_MACFB prefix instead of MACFB_NUBUS. This will make future conversion to OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Acked-by: Laurent Vivier Tested-By: R

[PULL 29/53] ahci: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
The TYPE_* constants and the typedefs are defined in ahci.h, so we can move the type checking macros there too. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528

[PULL 43/53] s390-virtio-ccw: Rename S390_MACHINE_CLASS macro

2020-08-27 Thread Eduardo Habkost
Rename it to be consistent with S390_CCW_MACHINE and TYPE_S390_CCW_MACHINE. This will make future conversion to OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Acked-by: Cornelia Huck Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-49-ehabk...@redhat.com> Signed-off-by: E

[PULL 26/53] spapr: Move typedef SpaprMachineState to spapr.h

2020-08-27 Thread Eduardo Habkost
Move the typedef from spapr_irq.h to spapr.h, and use "struct SpaprMachineState" in the spapr_*.h headers (to avoid circular header dependencies). This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshako

[PULL 41/53] vfio/pci: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-43-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/vfio/pci.h | 3 +++ hw/vfio/pci.c | 3 --- 2

[PULL 40/53] kvm: Move QOM macros to kvm.h

2020-08-27 Thread Eduardo Habkost
Move QOM macros close to the KVMState typedef. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-42-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost ---

[PULL 27/53] s390x: Move typedef SCLPEventFacility to event-facility.h

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. In sclp.h, use "struct SCLPEventFacility" to avoid introducing unnecessary header dependencies. Acked-by: Cornelia Huck Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Tested-By: Roman Bolshako

[PULL 38/53] pxa2xx: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-40-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/arm/pxa.h | 13 + hw/arm/

[PULL 21/53] can_emu: Delete macros for non-existing typedef

2020-08-27 Thread Eduardo Habkost
CanBusClass doesn't exist. This will break when we automatically convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros that reference the non-existing typedef. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshak

[PULL 37/53] rocker: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-39-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/net/rocker/rocker.h | 6 +- hw/net/rocker

[PULL 16/53] pci: Move PCIBusClass typedef to pci.h

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-18-ehabk...@redhat.com> Signed-off-by: Eduardo

[PULL 14/53] tulip: Move TulipState typedef to header

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-16-ehabk.

[PULL 11/53] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS

2020-08-27 Thread Eduardo Habkost
The macro was incorrectly defined using OBJECT_CHECK. Acked-by: Cornelia Huck Reviewed-by: Daniel P. Berrangé Reviewed-by: David Hildenbrand Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-13-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --

[PULL 28/53] vhost-user-gpu: Move QOM macro to header

2020-08-27 Thread Eduardo Habkost
Move the VHOST_USER_GPU type checking macro to virtio-gpu.h, close to the TYPE_VHOST_USER_GPU #define. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <

[PULL 25/53] xen-legacy-backend: Add missing typedef XenLegacyDevice

2020-08-27 Thread Eduardo Habkost
The typedef was used in the XENBACKEND_DEVICE macro, but it was never defined. Define the typedef close to the type checking macro. Acked-by: Anthony PERARD Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-27-ehabk..

[PULL 10/53] versatile: Fix typo in PCI_VPB_HOST definition

2020-08-27 Thread Eduardo Habkost
Fixes: cd93dbf375bd ("versatile_pci: Update to realize and instance init functions") Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-12-ehabk...@redhat.com> Signed-off-by: Eduardo

[PULL 22/53] nubus: Delete unused NUBUS_BRIDGE macro

2020-08-27 Thread Eduardo Habkost
The macro never worked because the NubusBridge typedef doesn't exist. Delete it. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Acked-by: Laurent Vivier Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-24-ehabk...@redhat.com>

[PULL 51/53] tosa: Use TYPE_TOSA_MISC_GPIO constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-7-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/arm/tosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

[PULL 34/53] virtio-serial-bus: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-36-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/virtio/virtio-serial.h | 5 + hw/

[PULL 09/53] aspeed_timer: Fix ASPEED_TIMER macro definition

2020-08-27 Thread Eduardo Habkost
The macro definition had an extra semicolon. This was never noticed because the macro was only being used where it didn't make a difference. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Cédric Le Goater Signed-off-by: Eduardo Habkost Tested-By: Roman Bolsha

[PULL 15/53] throttle-groups: Move ThrottleGroup typedef to header

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-17-ehabk.

[PULL 53/53] dc390: Use TYPE_DC390_DEVICE constant

2020-08-27 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Message-Id: <20200826184334.4120620-9-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/scsi/esp-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 24/53] armsse: Rename QOM macros to avoid conflicts

2020-08-27 Thread Eduardo Habkost
Rename TYPE_ARMSSE to TYPE_ARM_SSE, and ARMSSE*() type checking macros to ARM_SSE*(). This will avoid a future conflict between an ARM_SSE() type checking macro and the ARMSSE typedef name. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <2

[PULL 05/53] pl110: Rename pl110_version enum values

2020-08-27 Thread Eduardo Habkost
The PL110 enum value name will conflict with the PL110 type cast checker, when we replace the existing macro with an inline function. Add a VERSION_ prefix to all pl110_version enum values, to avoid conflicts. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Ed

[PULL 06/53] allwinner-h3: Rename memmap enum constants

2020-08-27 Thread Eduardo Habkost
Some of the enum constant names conflict with the QOM type check macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to allow us to transform the QOM type check macros into functions generated by OBJECT_DECLARE_TYPE(). Rename all the constants to AW_H3_DEV_*, to avoid conflicts. Review

[PULL 04/53] vmw_pvscsi: Rename QOM class cast macros

2020-08-27 Thread Eduardo Habkost
Rename the PVSCSI_DEVICE_CLASS() and PVSCSI_DEVICE_GET_CLASS() macros to be consistent with the PVSCSI() instance cast macro. This will allow us to register the type cast macros using OBJECT_DECLARE_TYPE later. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bols

[PULL 39/53] mptsas: Move QOM macros to header

2020-08-27 Thread Eduardo Habkost
This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-41-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/scsi/mptsas.h | 6 +- hw/scsi/mptsas.c |

[PULL 02/53] e1000: Rename QOM class cast macros

2020-08-27 Thread Eduardo Habkost
Rename the E1000_DEVICE_CLASS() and E1000_DEVICE_GET_CLASS() macros to be consistent with the E1000() instance cast macro. This will allow us to register the type cast macros using OBJECT_DECLARE_TYPE later. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshak

[PULL 31/53] ahci: Move QOM macro to header

2020-08-27 Thread Eduardo Habkost
Move the ALLWINNER_AHCI macro close to the TYPE_ALLWINNER_AHCI define. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-33-ehabk...@redhat.com> Signed-off-by

[PULL 20/53] s390_flic: Move KVMS390FLICState typedef to header

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Acked-by: Cornelia Huck Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Tested-By: Roman Bolshakov Message-Id: <20200825192110.352

[PULL 03/53] megasas: Rename QOM class cast macros

2020-08-27 Thread Eduardo Habkost
Rename the MEGASAS_DEVICE_CLASS() and MEGASAS_DEVICE_GET_CLASS() macros to be consistent with the MEGASAS() instance cast macro. This will allow us to register the type cast macros using OBJECT_DECLARE_TYPE later. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman B

[PULL 30/53] i8257: Move QOM macro to header

2020-08-27 Thread Eduardo Habkost
Move the I8257 macro to i8257.h, close to the TYPE_I8257 define. This will make future conversion to OBJECT_DECLARE* easier. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-32-ehabk...@redhat.com> Signed-off-by: Edua

[PULL 00/53] Machine queue + QOM fixes and cleanups

2020-08-27 Thread Eduardo Habkost
The following changes since commit ac8b279f13865d1a4f1958d3bf34240c1c3af90d: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200827' into staging (2020-08-27 13:48:12 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pu

[PULL 18/53] hvf: Move HVFState typedef to hvf.h

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Roman Bolshakov Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-20-ehabk...@redh

[PULL 23/53] platform-bus: Delete macros for non-existing typedef

2020-08-27 Thread Eduardo Habkost
PlatformBusDeviceClass doesn't exist. This will break when we automatically convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros that reference the non-existing typedef. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <2020082519

[PULL 01/53] numa: hmat: fix cache size check

2020-08-27 Thread Eduardo Habkost
From: Igor Mammedov when QEMU is started like: qemu-system-x86_64 -smp 2 -machine hmat=on \ -m 2G \ -object memory-backend-ram,size=1G,id=m0 \ -object memory-backend-ram,size=1G,id=m1 \ -numa node,nodeid=0,memdev=m0 \ -numa node,nodeid=1,memdev=m1,initiator=0 \ -numa cpu,node-id=0,socket-i

[PULL 13/53] hcd-dwc2: Rename USB_*CLASS macros for consistency

2020-08-27 Thread Eduardo Habkost
Rename the DWC2_CLASS to DWC2_USB_CLASS and DWC2_GET_CLASS to DWC2_USB_GET_CLASS, for consistency with the DWC2_USB macro. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann Tested-By: Roman Bolshakov Message-Id: <2020

[PULL 15/18] linux-user: Add support for 'mq_timedsend_time64()' and 'mq_timedreceive_time64()'

2020-08-27 Thread Laurent Vivier
From: Filip Bozuta This patch implements functionality for following time64 syscalls: *mq_timedsend_time64() This is a year 2038 safe vairant of syscall: int mq_timedsend(mqd_t mqdes, const char *msg_ptr, size_t msg_len, unsigned int msg_prio,

[PULL 18/18] linux-user: Add support for utimensat_time64() and semtimedop_time64()

2020-08-27 Thread Laurent Vivier
From: Filip Bozuta This patch introduces functionality for following time64 syscalls: *utimensat_time64() int utimensat(int dirfd, const char *pathname, const struct timespec times[2], int flags); -- change file timestamps with nanosecond precision -- man page: htt

[PULL 12/53] hvf: Add missing include

2020-08-27 Thread Eduardo Habkost
The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME macro. This will be necessary to allow us to use OBJECT_DEFINE*() for TYPE_HVF_ACCEL. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Roman Bolshakov Signed-off-by: Eduardo Habkost Tested-By: Roman B

[PULL 19/53] mcf_fec: Move mcf_fec_state typedef to header

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-21-ehabk...@redhat.com> Signed-off-by: Eduardo

[PULL 12/18] linux-user: detect mismatched ELF ABI in qemu-mips[n32][el]

2020-08-27 Thread Laurent Vivier
From: Carlo Marcelo Arenas Belón MIPS provides 2 ILP32 ABIs, and therefore 4 possible qemu-mips binaries with 2 pairs using the same endianess and bitness. This could lead to an O32 image loading in the N32 binary or vice versa and in cryptic errors (if lucky that the CPU doesn't match the FPU u

[PULL 17/53] i8254: Move PITCommonState/PITCommonClass typedefs to i8254.h

2020-08-27 Thread Eduardo Habkost
Move typedef closer to the type check macros, to make it easier to convert the code to OBJECT_DEFINE_TYPE() in the future. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Tested-By: Roman Bolshakov Message-Id: <20200825192110.3528606-19-ehabk.

[PULL 08/53] opentitan: Rename memmap enum constants

2020-08-27 Thread Eduardo Habkost
Some of the enum constant names conflict with the QOM type check macros (IBEX_PLIC, IBEX_UART). This needs to be addressed to allow us to transform the QOM type check macros into functions generated by OBJECT_DECLARE_TYPE(). Rename all the constants to IBEX_DEV_*, to avoid conflicts. Reviewed-by

[PULL 13/18] linux-user: Fix 'mq_timedsend()' and 'mq_timedreceive()'

2020-08-27 Thread Laurent Vivier
From: Filip Bozuta Implementations of syscalls 'mq_timedsend()' and 'mq_timedreceive()' in 'syscall.c' use functions 'target_to_host_timespec()' and 'host_to_target_timespec()' to transfer the value of 'struct timespec' between target and host. However, the implementations don't check whether thi

[PULL 08/18] linux-user: Add strace support for printing arguments of some clock and time functions

2020-08-27 Thread Laurent Vivier
From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: * clock_getres, clock_gettime, clock_settime - clock and time functions int clock_getres(clockid_t clockid, struct timespec *res) int clock_gettime(clockid_t clockid, str

[PULL 14/18] linux-user: fix target_to_host_timespec64()

2020-08-27 Thread Laurent Vivier
in 32 bit mode, drop the padding in tv_nsec. If host is 64bit and target is 32bit, the padding bytes will be copied from the target and as the kernel checks the value, the syscall exits with EINVAL. Signed-off-by: Laurent Vivier Message-Id: <20200827070449.2386007-1-laur...@vivier.eu> Fixes: c6c8

[PULL 11/18] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-08-27 Thread Laurent Vivier
From: Filip Bozuta Functions "print_ioctl()" and "print_syscall_ret_ioctl()" are used to print arguments of "ioctl()" with "-strace". These functions use "thunk_print()", which is defined in "thunk.c", to print the contents of ioctl's third arguments that are not basic types. However, this funct

[PULL 07/53] aspeed_soc: Rename memmap/irqmap enum constants

2020-08-27 Thread Eduardo Habkost
Some of the enum constant names conflict with the QOM type check macros: ASPEED_GPIO ASPEED_I2C ASPEED_RTC ASPEED_SCU ASPEED_SDHCI ASPEED_SDMC ASPEED_VIC ASPEED_WDT ASPEED_XDMA This needs to be addressed to allow us to transform the QOM type check macros into functions generated by OBJECT_DECLARE

  1   2   3   4   5   >