Re: [PATCH] hw: usb: hcd-ohci: check len and frame_number variables

2020-09-14 Thread P J P
+-- On Fri, 11 Sep 2020, Alexander Bulekov wrote --+ | > On 200911 2257, Li Qiang wrote: | > > Could you also provide the reproducer? * Sorry, we can not share reproducers on the list, I'm afraid. * Thank you Alex for the -qtests. | > > I think it is better to split this patch to 2 or three as t

Re: [PATCH v3 10/12] target/arm/cpu: spe: Enable spe to work with host cpu

2020-09-14 Thread Andrew Jones
On Tue, Sep 15, 2020 at 03:11:46AM +, Haibo Xu wrote: > Turn on the spe cpu property by default if host cpu > support it, i.e. we can now do '-cpu max|host' to add > the vSPE, and '-cpu max|host,spe=off' to remove it. > > Signed-off-by: Haibo Xu > --- > target/arm/cpu.c | 1 + > target/ar

Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > This is the second part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Series is fully Acked. One more: Acked-by: Markus Armbruster I suggested commit messa

Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Laurent + qemu-block@ > > On 9/14/20 11:14 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Acked-by: Markus Armbruster >>> Acked-by: Paolo Bonzini >>> Signed-off-by: Philippe Mathieu-Daudé >> >> Unlike the other patches that move code

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Paolo Bonzini
Looks good. Can you just add a "# Submodules" heading above the test? I would also like to remove the "yes" value (that is, the default fails if the internal copy is not there) but it can be done later for all submodules. Paolo Il mar 15 set 2020, 01:06 Richard Henderson ha scritto: > On 9/14/

Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code

2020-09-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 9/14/20 1:21 PM, Markus Armbruster wrote: >> David Hildenbrand writes: >> Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé : +Laurent and David > On 9/14/20 11:16 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes:

Re: [PATCH 3/3] gitmodules: add qemu.org vbootrom submodule

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/9/20 12:16 PM, Stefan Hajnoczi wrote: > The vbootrom module is needed for the new NPCM7xx ARM SoCs. The > vbootrom.git repo is now mirrored on qemu.org. QEMU mirrors third-party > code to ensure that users can always build QEMU even if the dependency > goes offline and so QEMU meets its respon

Re: [PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-14 Thread Andrew Jones
On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote: > From: Andrew Jones > > We'll add more to this new function in coming patches so we also > state the gic must be created and call it below create_gic(). > > No functional change intended. > > Signed-off-by: Andrew Jones > Reviewed-by:

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-14 Thread Nick Bauer
Yeah, I figured out that the logic behind that patch was failed and corrected it to get the same error again already. Just to clarify, it is two of the same card giving the same error. I ran dmesg --level=err, but got no output. In the full output of dmesg, though, I noticed that there are some pro

Re: [PATCH 11/11] disas: Enable capstone disassembly for sparc

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/14/20 11:07 PM, Richard Henderson wrote: > On 9/13/20 11:23 PM, Philippe Mathieu-Daudé wrote: >> The old disassembler is easier to follow: >> >> >> IN: >> -0x4000d214: lda [ %g3 ] #ASI_M_FLUSH_PROBE, %g6 >> -0x4000d218: sta %g6, [ %g4 ] #ASI_M_FLUSH_PROBE >> +0x4000d214:

Re: [PATCH v2 3/3] vfio: Create shared routine for scanning info capabilities

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/15/20 12:29 AM, Matthew Rosato wrote: > Rather than duplicating the same loop in multiple locations, > create a static function to do the work. Why not do that first in your series? > > Signed-off-by: Matthew Rosato > --- > hw/vfio/common.c | 33 +++-- > 1 file

Re: [PATCH v2 1/3] vfio: Find DMA available capability

2020-09-14 Thread Philippe Mathieu-Daudé
Hi Matthew, On 9/15/20 12:29 AM, Matthew Rosato wrote: > The underlying host may be limiting the number of outstanding DMA > requests for type 1 IOMMU. Add helper functions to check for the > DMA available capability and retrieve the current number of DMA > mappings allowed. > > Signed-off-by: M

Re: [PATCH v3 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-09-14 Thread Andrew Jones
On Tue, Sep 15, 2020 at 03:11:39AM +, Haibo Xu wrote: > Adds a spe=[on/off] option to enable/disable vSPE support in > guest vCPU. > > Reviewed-by: Andrew Jones > Signed-off-by: Haibo Xu > --- > target/arm/cpu.c | 6 ++ > target/arm/cpu.h | 13 > target/arm/cpu64.c | 5

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Thomas Huth
On 15/09/2020 01.02, Richard Henderson wrote: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always r

Re: [PATCH v6 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

2020-09-14 Thread Cédric Le Goater
On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: > The Witherspoon has 3 LEDs connected to a PCA9552. Add them. > The names and reset values are taken from: > https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml > > Example booting obmc-phosphor-image: > > $ qemu-system-ar

[PATCH v2] hw/arm/aspeed: Add machine properties to define the flash models

2020-09-14 Thread Cédric Le Goater
Some machines don't have much differences a part from the flash model being used. Introduce new machine properties to change them from the command line. For instance, to start the ast2500-evb machine with a different FMC chip and a 64M SPI chip, use : -M ast2500-evb,fmc-model=mx25l25635e,spi-mo

[PATCH v3 10/12] target/arm/cpu: spe: Enable spe to work with host cpu

2020-09-14 Thread Haibo Xu
Turn on the spe cpu property by default if host cpu support it, i.e. we can now do '-cpu max|host' to add the vSPE, and '-cpu max|host,spe=off' to remove it. Signed-off-by: Haibo Xu --- target/arm/cpu.c | 1 + target/arm/cpu.h | 2 ++ target/arm/cpu64.c | 10 +++--- target/arm/kvm64.c

[PATCH v3 09/12] hw/arm/virt: spe: Add vSPE device and corresponding interrupt support

2020-09-14 Thread Haibo Xu
Add a virtual SPE device for virt machine while using PPI 5 for SPE overflow interrupt number which has already selected in kvmtool for the in-kernel irqchip support. Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- hw/arm/virt-acpi-build.c| 3 +++ hw/arm/virt.c | 43 +++

[PATCH v3 08/12] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init

2020-09-14 Thread Haibo Xu
From: Andrew Jones Move the KVM PMU setup part of fdt_add_pmu_nodes() to virt_cpu_post_init(), which is a more appropriate location. Now fdt_add_pmu_nodes() is also named more appropriately, because it no longer does anything but fdt node creation. No functional change intended. Signed-off-by:

[PATCH v3 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-14 Thread Haibo Xu
From: Andrew Jones We'll add more to this new function in coming patches so we also state the gic must be created and call it below create_gic(). No functional change intended. Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- hw/arm/virt.c | 38 ++---

[PATCH v3 04/12] target/arm: spe: Only enable SPE from 5.2 compat machines.

2020-09-14 Thread Haibo Xu
Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- hw/arm/virt.c | 7 +++ include/hw/arm/virt.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index acf9bfbece..3f6d26c531 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1830,6 +1830,10 @@ st

[PATCH v3 05/12] target/arm/kvm: spe: Unify device attr operation helper

2020-09-14 Thread Haibo Xu
From: Andrew Jones Rename kvm_arm_pmu_set_attr() to kvm_arm_set_device_attr(), So both the vPMU and vSPE device can share the same API. Signed-off-by: Andrew Jones Signed-off-by: Haibo Xu --- target/arm/kvm64.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ta

[PATCH v3 06/12] target/arm/kvm: spe: Add device init and set_irq operations

2020-09-14 Thread Haibo Xu
Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- target/arm/kvm64.c | 33 + target/arm/kvm_arm.h | 5 + 2 files changed, 38 insertions(+) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 8ffd31ffdf..5a2032fc9e 100644 --- a/target/arm/kvm64.c

[PATCH v3 12/12] target/arm: spe: Add corresponding test.

2020-09-14 Thread Haibo Xu
Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- target/arm/monitor.c | 2 +- tests/qtest/arm-cpu-features.c | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/target/arm/monitor.c b/target/arm/monitor.c index ba6e01abd0..1b8f08988a 100644 --- a/target/a

[PATCH v3 02/12] target/arm/kvm: spe: Add helper to detect SPE when using KVM

2020-09-14 Thread Haibo Xu
Reviewed-by: Andrew Jones Reviewed-by: Richard Henderson Signed-off-by: Haibo Xu --- target/arm/kvm.c | 5 + target/arm/kvm_arm.h | 13 + 2 files changed, 18 insertions(+) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 8bb7318378..58f991e890 100644 --- a/target/arm

[PATCH v3 11/12] target/arm/kvm: spe: Enable userspace irqchip support.

2020-09-14 Thread Haibo Xu
Since the current kernel patches haven't enabled the userspace irqchip support, this patch is not verified yet! Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- hw/arm/virt.c| 2 +- target/arm/kvm.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c

[PATCH v3 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-09-14 Thread Haibo Xu
Adds a spe=[on/off] option to enable/disable vSPE support in guest vCPU. Reviewed-by: Andrew Jones Signed-off-by: Haibo Xu --- target/arm/cpu.c | 6 ++ target/arm/cpu.h | 13 target/arm/cpu64.c | 52 ++ 3 files changed, 71 insert

[PATCH v3 01/12] update Linux headers with new vSPE macros

2020-09-14 Thread Haibo Xu
Signed-off-by: Haibo Xu --- linux-headers/asm-arm64/kvm.h | 4 linux-headers/linux/kvm.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h index 9e34f0f875..802319ee02 100644 --- a/linux-headers/asm-arm64/kvm.h +++ b/linu

[PATCH v3 00/12] target/arm: Add vSPE support to KVM guest

2020-09-14 Thread Haibo Xu
v3: - Moved the patch 11 kernel header change to patch 01 - Removed doc for vSPE - Moved the assignment of has_spe into aarch64_add_spe_properties - Only enable spe properties in KVM mode - Only trigger the kvm_arm_spe_init with in-kernel irqchip support to avoid breaking bisection

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Robert Hoo
On Mon, 2020-09-14 at 13:38 +, Eduardo Habkost wrote: > On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote: > > On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > > > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > > > On Wed, 2020-09-09 at 14:15 -0400, Eduardo

[PATCH v4 4/6] migration/tls: extract cleanup function for common-use

2020-09-14 Thread Chuan Zheng
multifd channel cleanup is need if multifd handshake failed, let's extract it. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/multifd.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/migr

[PATCH v4 0/6] *** Add Multifd support for TLS migration ***

2020-09-14 Thread Chuan Zheng
v3 -> v4: still use MigrationState field and save hostname in migration_tls_channel_connect remove MigrationState from MultiFDSendParams v2 -> v3: rebase patches on master v1 -> v2: fix memoryleak of MigrationState hostname add tls_hostname into MultiFDSendParams for handsha

[PATCH v4 5/6] migration/tls: add support for multifd tls-handshake

2020-09-14 Thread Chuan Zheng
Similar like migration main thread, we need to do handshake for each multifd thread. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/multifd.c | 77 +++-- 1 file changed, 75 insertions(+), 2 deletio

[PATCH v4 3/6] migration/tls: add tls_hostname into MultiFDSendParams

2020-09-14 Thread Chuan Zheng
Since multifd creation is async with migration_channel_connect, we should pass the hostname from MigrationState to MultiFDSendParams. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/multifd.c | 5 + migration/multifd.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/m

[PATCH v4 6/6] migration/tls: add trace points for multifd-tls

2020-09-14 Thread Chuan Zheng
add trace points for multifd-tls for debug. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/multifd.c| 10 +- migration/trace-events | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/migration/multifd.c b/migra

[PATCH v4 1/6] migration/tls: save hostname into MigrationState

2020-09-14 Thread Chuan Zheng
hostname is need in multifd-tls, save hostname into MigrationState. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin --- migration/channel.c | 1 + migration/migration.c | 1 + migration/migration.h | 5 + migration/tls.c | 2 ++ 4 files changed, 9 insertions(+) diff --git a/migra

[PATCH v4 2/6] migration/tls: extract migration_tls_client_create for common-use

2020-09-14 Thread Chuan Zheng
migration_tls_client_create will be used in multifd-tls, let's extract it. Signed-off-by: Chuan Zheng Signed-off-by: Yan Jin Reviewed-by: Daniel P. Berrangé --- migration/tls.c | 26 ++ migration/tls.h | 6 ++ 2 files changed, 24 insertions(+), 8 deletions(-) diff

RE: [PATCH] vhost-blk: set features before setting inflight feature

2020-09-14 Thread Yu, Jin
> -Original Message- > From: Raphael Norwitz > Sent: Tuesday, September 15, 2020 9:25 AM > To: Yu, Jin > Cc: Michael S. Tsirkin ; Raphael Norwitz > ; Kevin Wolf ; Max > Reitz ; QEMU > Subject: Re: [PATCH] vhost-blk: set features before setting inflight feature > > Backends already recei

[PATCH v9 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h

2020-09-14 Thread Chuan Zheng
RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure, move the existing definition up into migration/ram.h Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 1 + migration/ram.c | 11 +-- migration/ram.h

[PATCH v9 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-09-14 Thread Chuan Zheng
Add trace_calls to make it easier to debug Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 9 + migration/trace-events | 8 2 files changed, 17 insertions(+) diff --git a/migration/dirtyrate.c b/migratio

[PATCH v9 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-09-14 Thread Chuan Zheng
In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE which is set as 128M. Signed-off-by: Chuan Zheng Reviewed-by: David Edmondson Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 21 + migration/dirtyrate.h | 5 + 2 files changed

[PATCH v9 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-09-14 Thread Chuan Zheng
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 62 +++ qapi/migration.json | 50 + 2 files changed, 112 insertions

[PATCH v9 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-09-14 Thread Chuan Zheng
Add dirtyrate statistics functions to record/update dirtyrate info. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 32 migration/dirtyrate.h | 12 2 files changed, 44 insertions(+) diff --git a/migration/

[PATCH v9 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-09-14 Thread Chuan Zheng
Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/migration/dirtyra

[PATCH v9 09/12] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid()

2020-09-14 Thread Chuan Zheng
Implement is_sample_period_valid() to check if the sample period is vaild and do set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 24 ++

[PATCH v9 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-09-14 Thread Chuan Zheng
Record hash results for each sampled page, crc32 is taken to calculate hash results for each sampled length in TARGET_PAGE_SIZE. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: David Edmondson --- migration/dirtyrate.c | 109 +++

[PATCH v9 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-09-14 Thread Chuan Zheng
add DirtyRateStatus to denote calculating status. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 26 ++ qapi/migration.json | 17 + 2 files changed, 43 insertions(+) diff --git a/migration/dirtyrate.c b/migra

[PATCH v9 01/12] migration/dirtyrate: setup up query-dirtyrate framwork

2020-09-14 Thread Chuan Zheng
Add get_dirtyrate_thread() functions to setup query-dirtyrate framework. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.c | 38 ++ migration/dirtyrate.h | 29

[PATCH v9 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-09-14 Thread Chuan Zheng
Implement calculate_dirtyrate() function. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang Reviewed-by: Dr. David Alan Gilbert --- migration/dirtyrate.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrat

[PATCH v9 00/12] *** A Method for evaluating dirty page rate ***

2020-09-14 Thread Chuan Zheng
v8 -> v9: fix wrong index return of record_ramblock_hash_info optimize variable name according to review reset dirty_rate as -1 change returns of compare_page_hash_info to bool v7 -> v8: add atomic_read for dirtyrate status add error_report if set dirtyrate state failed

[PATCH v9 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info

2020-09-14 Thread Chuan Zheng
Add RamblockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert Reviewed-by: David Edmondson --- migration/dirtyrate.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dir

[Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed

2020-09-14 Thread Hansni Bu
chroot works as you expected. And the patch makes sense. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895080 Title: pgb_reserved_va: Assertion `addr == test' failed Status in QEMU: New

[Bug 1895602] [NEW] older OS's do not detect CD change

2020-09-14 Thread Michael Slade
Public bug reported: There are at least two older operating systems, being FreeBSD 2.2 and FreeDOS 1.2, that misbehave when the change command is used on the IDE CD drive, and work fine on a real machine. In both cases, changing the CD causes the guest to either refuse to read the disc or appear

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-14 Thread Paul Zimmerman
Could this be related to bug 1892604? Although I don't know how Laurent would not be seeing the problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895053 Title: Cannot nspawn raspbian 10 [FAI

Re: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-14 Thread Derek Su
Hello, Chen Zhang, Chen 於 2020年9月15日 週二 上午8:09寫道: > Hi Derek, > > > > Looks qemu vl.c, migration/migration.c…etc use the “QEMU_CLOCK_HOST” too. > It will also affected by host NTP. Do you means we should change all the > QEMU_CLOCK_HOST to QEMU_CLOCK_REALTIME? > No, I think it depends on the pu

Re: [PATCH v8 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-09-14 Thread Zheng Chuan
On 2020/9/14 22:59, Li Qiang wrote: > Chuan Zheng 于2020年9月14日周一 下午4:52写道: >> >> Record hash results for each sampled page, crc32 is taken to calculate >> hash results for each sampled length in TARGET_PAGE_SIZE. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> Reviewed-by:

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-14 Thread Raphael Norwitz
A few more comments mixed in below. Once these are addressed I'd support this change from the vhost-user side. We should get opinions from other maintainers though, particularly for the kernel backend and vhost-user-net changes. On Tue, Sep 8, 2020 at 2:11 AM Jiajun Chen wrote: > > Used_memslots

Re: [PATCH] vhost-blk: set features before setting inflight feature

2020-09-14 Thread Raphael Norwitz
Backends already receive the format in vhost_dev_start before the memory tables are set or any of the virtqueues are started. Can you elaborate on why you need to know the virtqueue format before setting the inflight FD? On Thu, Sep 10, 2020 at 2:15 AM Jin Yu wrote: > > Virtqueue has split and pa

Re: [PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-14 Thread Raphael Norwitz
On Fri, Sep 11, 2020 at 4:43 AM Dima Stepanov wrote: > > Add support for the vhost-user-blk-pci device. This node can be used by > the vhost-user-blk tests. Tests for the vhost-user-blk device are added > in the following patches. > > Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz >

RE: [EXT] Re: [RFC PATCH v3 00/34] Hexagon patch series

2020-09-14 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Rob Landley ... > > On 8/30/20 3:47 PM, Taylor Simpson wrote: > > Richard, > > > > Thank you so much for the feedback. I really appreciate it. > > > > I'll get to work addressing the issues. Since some of the items will take > > lo

[REPORT] Nightly Performance Tests - Monday, September 14, 2020

2020-09-14 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-14 23:50:01 End Time (UTC) : 2020-09-15 00:23:36 Execution Time : 0:33:35.073901 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

RE: [PATCH v1 2/2] colo-compare: Record packet creation time by QEMU_CLOCK_REALTIME

2020-09-14 Thread Zhang, Chen
Hi Derek, Looks qemu vl.c, migration/migration.c…etc use the “QEMU_CLOCK_HOST” too. It will also affected by host NTP. Do you means we should change all the QEMU_CLOCK_HOST to QEMU_CLOCK_REALTIME? And use the QEMU_CLOCK_VIRTUAL is not correct, because we need to know time changes during VM stop.

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-14 Thread Bug Watch Updater
Launchpad has imported 14 comments from the remote bug at https://bugzilla.proxmox.com/show_bug.cgi?id=2969. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Richard Henderson
On 9/14/20 4:02 PM, Richard Henderson wrote: > +option('capstone', type: 'combo', value: 'no', > + choices: ['no', 'yes', 'auto', 'system', 'internal'], > + description: 'Whether and how to find the capstone library') Dangit, meant to change value: back to 'auto'. r~

[PATCH v2 10/10] disas/capstone: Add skipdata hook for s390x

2020-09-14 Thread Richard Henderson
It is always possible to tell the length of an insn, even if the actual insn is unknown. Skip the correct number of bytes, so that we stay in sync with the instruction stream. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas/capstone.c | 42 +++

[PATCH v2 08/10] disas: Split out capstone code to disas/capstone.c

2020-09-14 Thread Richard Henderson
There is nothing target-specific about this code, so it can be added to common_ss. This also requires that the base capstone dependency be added to common_ss, so that we get the correct include paths added to CFLAGS. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 12 ++ disas.c

[PATCH v2 05/10] disas: Use qemu/bswap.h for bfd endian loads

2020-09-14 Thread Richard Henderson
Use the routines we have already instead of open-coding. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 32 disas.c | 55 - 2 files changed, 27 insertions(+), 60

[PATCH v2 06/10] disas: Cleanup plugin_disas

2020-09-14 Thread Richard Henderson
Do not retain a GString in thread-local storage. Allocate a new one and free it on every invocation. Do not g_strdup the result; return the buffer from the GString. Do not use warn_report. Using cs_disasm allocated memory via the &insn parameter, but that was never freed. Use cs_disasm_iter so

[PATCH v2 07/10] disas: Configure capstone for aarch64 host without libvixl

2020-09-14 Thread Richard Henderson
The ifdef tangle failed to set cap_arch if libvixl itself was not configured (e.g. due to lack of c++ compiler). Signed-off-by: Richard Henderson --- disas.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index d0ccd4b727..01c8bc6c9e 100644 --- a/disa

[PATCH v2 04/10] disas: Clean up CPUDebug initialization

2020-09-14 Thread Richard Henderson
Rename several functions, dropping "generic" and making "host" vs "target" clearer. Make a bunch of functions static that are not used outside this file. Replace INIT_DISASSEMBLE_INFO with a trio of functions. Signed-off-by: Richard Henderson --- include/disas/dis-asm.h | 60 disas.c

[PATCH v2 02/10] capstone: Update to upstream "next" branch

2020-09-14 Thread Richard Henderson
This branch contains a number of improvements over master, including making all of the disassembler data constant. We are skipping past the 4.0 branchpoint, which changed the location of the includes within the source directory. Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

[PATCH v2 00/10] capstone + disassembler patches

2020-09-14 Thread Richard Henderson
The primary change here is the update for capstone to meson. This bypasses capstone's build system entirely. There's more commentary on that subject with the first patch. Plus a collection of other fixes and cleanups in the area. Changes for v2: * Several configury changes in patch 1, along th

[PATCH v2 03/10] disas: Move host asm annotations to tb_gen_code

2020-09-14 Thread Richard Henderson
Instead of creating GStrings and passing them into log_disas, just print the annotations directly in tb_gen_code. Fix the annotations for the slow paths of the TB, after the part implementing the final guest instruction. Signed-off-by: Richard Henderson --- include/disas/disas.h | 2 +- in

[PATCH v2 09/10] disas: Enable capstone disassembly for s390x

2020-09-14 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- disas.c| 3 +++ target/s390x/cpu.c | 4 meson.build| 11 +++ 3 files changed, 18 insertions(+) diff --git a/disa

[PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

2020-09-14 Thread Richard Henderson
There are better ways to do this, e.g. meson cmake subproject, but that requires cmake 3.7 and some of our CI environments only provide cmake 3.5. Nor can we add a meson.build file to capstone/, because the git submodule would then always report "untracked files". Fixing that would require creati

Re: question regarding vexpress and aarch64 secure boot

2020-09-14 Thread Peter Maydell
On Mon, 14 Sep 2020 at 20:59, Thomas Meyer wrote: > When trying to boot an linux kernel with > > qemu-system-aarch64 -s -S -kernel /path/to/kernel -append > "console=ttyAMA0 loglevel=9 nokaslr" -dtb /path/to/dtb -M vexpress-a15 -cpu > cortex-a53 -nographic This is trying to boot the vexpress-a15

[PATCH v2 3/3] vfio: Create shared routine for scanning info capabilities

2020-09-14 Thread Matthew Rosato
Rather than duplicating the same loop in multiple locations, create a static function to do the work. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c ind

[PATCH v2 0/3] s390x/pci: Accomodate vfio DMA limiting

2020-09-14 Thread Matthew Rosato
Kernel commit 492855939bdb added a limit to the number of outstanding DMA requests for a type1 vfio container. However, lazy unmapping in s390 can in fact cause quite a large number of outstanding DMA requests to build up prior to being purged, potentially the entire guest DMA space. This result

[PATCH v2 2/3] s390x/pci: Honor DMA limits set by vfio

2020-09-14 Thread Matthew Rosato
When an s390 guest is using lazy unmapping, it can result in a very large number of oustanding DMA requests, far beyond the default limit configured for vfio. Let's track DMA usage similar to vfio in the host, and trigger the guest to flush their DMA mappings before vfio runs out. Signed-off-by:

[PATCH v2 1/3] vfio: Find DMA available capability

2020-09-14 Thread Matthew Rosato
The underlying host may be limiting the number of outstanding DMA requests for type 1 IOMMU. Add helper functions to check for the DMA available capability and retrieve the current number of DMA mappings allowed. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 37 +

[Bug 1895053] Re: Cannot nspawn raspbian 10 [FAILED] Failed to start Journal Service.

2020-09-14 Thread Petunia
for file in /proc/sys/fs/binfmt_misc/* ; do echo "$file"; LANG=C cat $file; done /proc/sys/fs/binfmt_misc/aarch64 enabled interpreter /usr/bin/qemu-aarch64-static flags: OCF offset 0 magic 7f454c46020101000200b7 mask ff00fe /proc/sys/fs/binfmt_misc/ar

[PATCH v10 4/4] MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller

2020-09-14 Thread Vikram Garhwal
Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad..3ed61d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1557,6 +1557,14 @@ F: hw/net/o

[PATCH v10 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-09-14 Thread Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller: Tests the CAN controller in loopback, sleep and snoop mode. Tests filtering of incoming CAN messages. Reviewed-by: Francisco Iglesias Signed-off-by: Vikram Garhwal --- tests/qtest/meson.build | 1 + tests/qtest/xln

[PATCH v10 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-09-14 Thread Vikram Garhwal
The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Example for using single CAN: -object can-bus,id=canbus0 \ -machine xlnx-zcu102.canbus0=canbus0 \

[PATCH v10 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-09-14 Thread Vikram Garhwal
Connect CAN0 and CAN1 on the ZynqMP. Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- hw/arm/xlnx-zcu102.c | 20 hw/arm/xlnx-zynqmp.c | 34 ++ include/hw/arm/xlnx-zynqmp.h | 8

[PATCH v10 0/4] Introduce Xilinx ZynqMP CAN controller

2020-09-14 Thread Vikram Garhwal
Changelog: v9 -> v10: Rebase the series with the new meson build system. v8 -> v9: Use g_autofree to do automatic cleanup the object_get_canonical_path() used. v7 -> v8: Change CAN controller to keep one canbus per controller. Add canbus connections at machine level. Remove c

Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region

2020-09-14 Thread Michael Roth
Quoting Alistair Francis (2020-09-14 11:07:26) > On Fri, Sep 11, 2020 at 5:26 AM Michael Roth > wrote: > > > > Quoting Alistair Francis (2020-09-10 13:10:43) > > > On Thu, Sep 3, 2020 at 2:05 PM Michael Roth > > > wrote: > > > > > > > > Quoting Alistair Francis (2020-09-01 18:59:29) > > > > > O

Re: [PATCH 11/11] disas: Enable capstone disassembly for sparc

2020-09-14 Thread Richard Henderson
On 9/13/20 11:23 PM, Philippe Mathieu-Daudé wrote: > The old disassembler is easier to follow: > > > IN: > -0x4000d214: lda [ %g3 ] #ASI_M_FLUSH_PROBE, %g6 > -0x4000d218: sta %g6, [ %g4 ] #ASI_M_FLUSH_PROBE > +0x4000d214: cc80c060 .byte0xcc, 0x80, 0xc0, 0x60 > +0x4000d

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-14 Thread Alex Williamson
PS, this can never be true: + (vdev->device_id & 0xff00) == 0x1425)) The lower byte would always be 00. It's the wrong fix anyway, BAR4 is still missing. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-14 Thread Alex Williamson
There are no BAR resources for this device: 83:00.7 Ethernet controller [0200]: Chelsio Communications Inc Device [1425:] Subsystem: Chelsio Communications Inc Device [1425:] Physical Slot: 818 Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr+ St

Re: [PATCH v2] tests/qtest/qmp-cmd-test: Use inclusive language

2020-09-14 Thread Thomas Huth
On 14/09/2020 18.51, Claudio Fontana wrote: > It seems to me that "blacklist" is a very commonly used technical term, > and expresses the concept more precisely. > > I am not sure what "inclusive language" is or what relationship it has with > technical work on QEMU. See e.g.: https://itsfoss.co

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-14 Thread Nick Bauer
** Bug watch added: bugzilla.proxmox.com/ #2969 https://bugzilla.proxmox.com/show_bug.cgi?id=2969 ** Also affects: debian via https://bugzilla.proxmox.com/show_bug.cgi?id=2969 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of qe

question regarding vexpress and aarch64 secure boot

2020-09-14 Thread Thomas Meyer
Hi, When trying to boot an linux kernel with qemu-system-aarch64 -s -S -kernel /path/to/kernel -append "console=ttyAMA0 loglevel=9 nokaslr" -dtb /path/to/dtb -M vexpress-a15 -cpu cortex-a53 -nographic I do hit the assertion: qemu-system-aarch64: /builddir/build/BUILD/qemu-4.2.1/hw/arm/boot.c:74

Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

2020-09-14 Thread Jason Dillaman
On Mon, Sep 14, 2020 at 3:06 PM Stefano Garzarella wrote: > > Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") > introduced namespace support for RBD, but we forgot to add the > new 'namespace' options to qemu_rbd_strong_runtime_opts[]. > > The 'namespace' is used to identify the i

Re: [PATCH 3/3] configure: automatically parse command line for meson -D options

2020-09-14 Thread Eric Blake
On 9/13/20 5:05 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- Makefile| 6 ++ configure | 71 + docs/devel/build-system.rst | 35 +-- meson-buildoptions.json | 130 +

Re: [PATCH v1 3/6] configure: also skip deprecated targets with target-list-exclude

2020-09-14 Thread Peter Maydell
On Mon, 14 Sep 2020 at 16:27, Alex Bennée wrote: > > Now the user has to make an even more deliberate decision to > enable a deprecated target rather than getting it as a side effect of > using --target-exclude-list. > > Signed-off-by: Alex Bennée > --- > configure | 12 +--- > 1 file ch

Re: [PATCH 1/3] configure: quote command line arguments in config.status

2020-09-14 Thread Eric Blake
On 9/13/20 5:05 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 53723ace57..beae010e39 100755 --- a/configure +++ b/configure @@ -89,6 +89,10 @@ printf " '%s'" "$0" "$@" >>

[PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-14 Thread Eric Blake
If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lock Is another process using the image [base.qcow2]? The easiest fix is to no

[PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]

2020-09-14 Thread Stefano Garzarella
Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces") introduced namespace support for RBD, but we forgot to add the new 'namespace' options to qemu_rbd_strong_runtime_opts[]. The 'namespace' is used to identify the image, so it is a strong option since it can changes the data of a BDS.

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

2020-09-14 Thread Yonggang Luo
On Tue, Sep 15, 2020 at 12:14 AM Daniel P. Berrangé wrote: > > On Mon, Sep 14, 2020 at 11:58:24PM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > > > > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > > > > On Mon, Sep 14, 2020 at 3:23 P

  1   2   3   4   5   >