Re: [PATCH v2 5/6] spice: get monitors physical dimension

2020-09-25 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Note that for consistency, we use the same logic as MonitorsConfig to > figure out the associated monitor. However, I can't find traces of the > discussion/patches about the "new spice-server" behaviour: it still uses > the multiple-configurations path in git mast

Re: [RFC v4 17/70] target/riscv: rvv-1.0: configure instructions

2020-09-25 Thread Frank Chang
On Sat, Sep 26, 2020 at 2:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/25/20 1:51 AM, Frank Chang wrote: > > trans_vsetvli() uses gen_goto_tb() to save the computation in the link > to the > > next TB. > > I know there was a discussion about this back in RVV v0.7.1: > > >

Re: [PATCH] build: Build and install the info manual.

2020-09-25 Thread Maxim Cournoyer
Hello Peter, Peter Maydell writes: > On Fri, 25 Sep 2020 at 07:27, Maxim Cournoyer > wrote: >> >> Take advantage of the Sphinx texinfo backend to generate a QEMU info >> manual. The texinfo format allows for more structure and info readers >> provide more advanced navigation capabilities comp

[Bug 1070762] Re: savevm fails with inserted CD, "Device '%s' is writable but does not support snapshots."

2020-09-25 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1070762 Title: savevm fail

Re: Re: [PATCH] Fix stack smashing when handling PR_GET_PDEATHSIG

2020-09-25 Thread Stephen Long
>> linux-user/syscall.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/linux-user/syscall.c b/linux-user/syscall.c >> index 05f0391..91f9114 100644 >> --- a/linux-user/syscall.c >> +++ b/linux-user/syscall.c >> @@ -10256,7 +10256,7 @@ static abi_long do_syscall1(void

Re: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices pl

Re: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices pl

Re: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices pl

Re: [PATCH] i386: Document when features can be added to kvm_default_props

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925211021.4158567-1-ehabk...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] load_elf: Remove unused address variables from callers

2020-09-25 Thread Alistair Francis
On Wed, Sep 23, 2020 at 2:15 PM BALATON Zoltan wrote: > > On Tue, 7 Jul 2020, BALATON Zoltan wrote: > > On Tue, 7 Jul 2020, Alistair Francis wrote: > >> On Sun, Jul 5, 2020 at 10:41 AM BALATON Zoltan wrote: > >>> Several callers of load_elf() pass pointers for lowaddr and highaddr > >>> parameter

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Paolo Bonzini
On 26/09/20 01:48, Ashish Kalra wrote: > Thanks for your input, i have one additional query with reference to this > support : > > For all explicitly unecrypted guest memory regions such as S/W IOTLB bounce > buffers, > dma_decrypted() allocated regions and for guest regions marked as > "__bss_

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Ashish Kalra
Hello Paolo, On Fri, Sep 25, 2020 at 10:56:10PM +0200, Paolo Bonzini wrote: > On 25/09/20 22:46, Ashish Kalra wrote: > > I was also considering abstracting this vendor/SEV specific debug > > interface via the CPUClass object, the CPUClass object aleady has cpu > > specific methods for doing things

[PULL v7 00/87] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

Re: [PATCH v4 0/6] Qemu SEV-ES guest support

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1601060620.git.thomas.lenda...@amd.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v26 17/17] qapi: Add VFIO devices migration stats in Migration stats

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:19 +0530 Kirti Wankhede wrote: > Added amount of bytes transferred to the target VM by all VFIO devices > > Signed-off-by: Kirti Wankhede > --- > > Note: Comments from v25 for this patch are not addressed yet. > https://www.mail-archive.com/qemu-devel@nongnu.org/msg71

Re: [PATCH 00/16] qapi: static typing conversion, pt2

2020-09-25 Thread John Snow
On 9/22/20 5:12 PM, John Snow wrote: based-on: <20200922210101.4081073-1-js...@redhat.com> [PATCH v2 00/38] qapi: static typing conversion, pt1 Hi, this series adds static type hints to the QAPI module. This is part two! Part 2: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanu

Re: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices pl

Re: [PATCH v1 0/8] s390x/tcg: Implement some z14 facilities

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > With this patchset, I can boot a kernel compiled for z14 (requiring > Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max). Excellent. Looks like it wouldn't take too much additional work for z15, if you're of a mind while we're at it.

Re: [PATCH] target/riscv: raise exception to HS-mode at get_physical_address

2020-09-25 Thread Alistair Francis
On Mon, Aug 24, 2020 at 1:43 AM Yifei Jiang wrote: > > VS-stage translation at get_physical_address needs to translate pte > address by G-stage translation. But the G-stage translation error > can not be distinguished from VS-stage translation error in > riscv_cpu_tlb_fill. On migration, destinati

Re: [PATCH v26 13/17] vfio: create mapped iova list when vIOMMU is enabled

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:15 +0530 Kirti Wankhede wrote: > Create mapped iova list when vIOMMU is enabled. For each mapped iova > save translated address. Add node to list on MAP and remove node from > list on UNMAP. > This list is used to track dirty pages during migration. > > Signed-off-by: K

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

2020-09-25 Thread Steven Sistare
On 9/25/2020 2:43 PM, Steven Sistare wrote: > On 9/11/2020 12:43 PM, Dr. David Alan Gilbert wrote: >> * Steve Sistare (steven.sist...@oracle.com) wrote: >>> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >>> vmstate-saving operation, which saves the state of the virtual m

Re: [PATCH v1 8/8] s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > As with the other crypto functions, we only implement subcode 0 (query) > and no actual encryption/decryption. We now implement S390_FEAT_MSA_EXT_8. > > Signed-off-by: David Hildenbrand > --- > target/s390x/gen-features.c | 1 + > target/s390x/insn-

Re: [PATCH v1 7/8] s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > We implement all relevant instructions. > > Signed-off-by: David Hildenbrand > --- > target/s390x/gen-features.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v1 6/8] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > +static uint32_t cc_calc_muls_32(int64_t res) > +{ > +/* Arithmetic shift with sign extension so we can compare against -1ull. > */ > +const uint64_t tmp = res >> 31; > + > +if (!res) { > +return 0; > +} else if (!(!tmp || tmp

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 4:59 AM Paolo Bonzini wrote: > > On 25/09/20 22:50, Richard Henderson wrote: > > On 9/25/20 12:25 PM, Paolo Bonzini wrote: > >> On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: > >>> That's what I am tring to fixes? what does one import library per > >>> emulator, can we do thi

Re: [PULL v6 00/87] Misc patches for 2020-09-24

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 20:51, Paolo Bonzini wrote: > > The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-09-24 18:48:45 +0100) > > are available in the Git repository at:

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > Reviewed-by: Dr. David Alan Gilbert > --- > hw/vfio/migra

Re: [PATCH v26 07/17] vfio: Register SaveVMHandlers for VFIO device

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:09 +0530 Kirti Wankhede wrote: > Define flags to be used as delimeter in migration file stream. > Added .save_setup and .save_cleanup functions. Mapped & unmapped migration > region from these functions at source during saving or pre-copy phase. > Set VFIO device state d

Re: [PATCH v26 12/17] vfio: Add function to start and stop dirty pages tracking

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:14 +0530 Kirti Wankhede wrote: > Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking > for VFIO devices. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Dr. David Alan Gilbert > --- > hw/vfio/migration.c | 36

Re: [PATCH v26 06/17] vfio: Add migration state change notifier

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:08 +0530 Kirti Wankhede wrote: > Added migration state change notifier to get notification on migration state > change. These states are translated to VFIO device state and conveyed to > vendor > driver. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > Revi

Re: [PATCH v26 08/17] vfio: Add save state functions to SaveVMHandlers

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:10 +0530 Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If pendin

Re: [RFC PATCH v5 2/2] hw/riscv: sifive_u: Add backend drive support

2020-09-25 Thread Alistair Francis
On Tue, Sep 1, 2020 at 8:49 AM Green Wan wrote: > > Add '-drive' support to OTP device. Allow users to assign a raw file > as OTP image. Do you mind writing an example command line argument in the commit message? Also, do you have a test case for this? I would like to add it to my CI. > > Signe

Re: [RFC PATCH v5 1/2] hw/riscv: sifive_u: Add write operation and write-once protection

2020-09-25 Thread Alistair Francis
On Tue, Sep 1, 2020 at 9:09 AM Green Wan wrote: > > - Add write operation to update fuse data bit when PWE bit is on. > - Add array, fuse_wo, to store the 'written' status for all bits >of OTP to block the write operation. > > Signed-off-by: Green Wan Reviewed-by: Alistair Francis Alista

Re: [PATCH] i386: Document when features can be added to kvm_default_props

2020-09-25 Thread Paolo Bonzini
On 25/09/20 23:10, Eduardo Habkost wrote: > It's very easy to mistakenly extend kvm_default_props to include > features that require a kernel version that's too recent. Add a > comment warning about that, pointing to the documentation file > where the minimum kernel version for KVM is documented.

Re: [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > +/* BRANCH INDIRECT ON CONDITION */ > +C(0xe347, BIC, RXY_b, MIE2,0, m2_64, 0, 0, bc, 0) > /* BRANCH ON CONDITION */ > C(0x0700, BCR, RR_b, Z, 0, r2_nz, 0, 0, bc, 0) > C(0x4700, BC, RX_b, Z, 0, a2, 0, 0, bc, 0) > diff

Re: [PATCH v1 4/8] s390x/tcg: Implement MULTIPLY HALFWORD (MGH)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > Just like MULTIPLY HALFWORD IMMEDIATE (MGHI), only the second operand > (signed 16 bit) comes from memory. > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderso

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 20:25, wrote: > In file included from ../src/qapi/qapi-schema.json:78: > ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least 13 > spaces) This is yet another mis-indented line in a change to the QAPI doc-comments (commit 4c437254b807). It hit master

Re: [PATCH v1 3/8] s390x/tcg: Implement MULTIPLY (MG, MGRK)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > Multiply two signed 64bit values and store the 128bit result in r1 (0-63) > and r1 + 1 (64-127). > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 2 ++ > target/s390x/translate.c | 13 + > 2 files changed, 15

Re: [PATCH v1 2/8] s390x/tcg: Implement SUBTRACT HALFWORD (SGH)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > Easy to wire up. > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v1 1/8] s390x/tcg: Implement ADD HALFWORD (AGH)

2020-09-25 Thread Richard Henderson
On 9/22/20 3:31 AM, David Hildenbrand wrote: > Easy, just like ADD HALFWORD IMMEDIATE (AGHI). > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 1 + > target/s390x/translate.c | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH] i386: Document when features can be added to kvm_default_props

2020-09-25 Thread Eduardo Habkost
It's very easy to mistakenly extend kvm_default_props to include features that require a kernel version that's too recent. Add a comment warning about that, pointing to the documentation file where the minimum kernel version for KVM is documented. Signed-off-by: Eduardo Habkost --- target/i386/

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Ashish Kalra
Hello Paolo, Thanks for your response. On Fri, Sep 25, 2020 at 10:51:05AM +0200, Paolo Bonzini wrote: > On 22/09/20 22:11, Ashish Kalra wrote: > > This internally invokes the address_space_rw() accessor functions > > which we had "fixed" internally (as part of the earlier patch) to > > invoke me

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Paolo Bonzini
On 25/09/20 22:50, Richard Henderson wrote: > On 9/25/20 12:25 PM, Paolo Bonzini wrote: >> On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: >>> That's what I am tring to fixes? what does  one import library per >>> emulator, can we do this like NodeJS does? >>>  NodeJS have NAPI support across platform.

Re: SEV guest debugging support for Qemu

2020-09-25 Thread Paolo Bonzini
On 25/09/20 22:46, Ashish Kalra wrote: > I was also considering abstracting this vendor/SEV specific debug > interface via the CPUClass object, the CPUClass object aleady has cpu > specific methods for doing things like guest VA to GPA translations like the > get_phys_page_attrs_debug() method and

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Richard Henderson
On 9/25/20 12:25 PM, Paolo Bonzini wrote: > On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: >> That's what I am tring to fixes? what does  one import library per >> emulator, can we do this like NodeJS does? >>  NodeJS have NAPI support across platform. They create a windows .lib from >> node.exe > >

Re: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-25 Thread Paolo Bonzini
On 25/09/20 22:29, Eduardo Habkost wrote: >> No, it's not possible. KVM doesn't have a say on what the processor >> writes in the tracing packets. > Can KVM refuse to enable packet generation if CSbase is not zero > and CPUID.(EAX=14H,ECX=0)[bit 31] seen by guest is different from > host? Yes, bu

[PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext

2020-09-25 Thread Eric Blake
'qemu-img map' provides a way to determine which extents of an image come from the top layer vs. inherited from a backing chain. This is useful information worth exposing over NBD. There is a proposal to add a QMP command block-dirty-bitmap-populate which can create a dirty bitmap that reflects a

[PATCH 0/3] Exposing backing-chain allocation over NBD

2020-09-25 Thread Eric Blake
I'm working on preparing my KVM Forum presentation on NBD, and ran into a situation where I really wanted to do the equivalent of 'qemu-img map' over NBD for determining which portions of an overlay image are changed from the backing layer. So after less than 24 hours hacking, I'm pretty pleased w

[PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth

2020-09-25 Thread Eric Blake
Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using nbd-server-add. qemu as client can be hacked into viewing this

[PATCH 1/3] nbd: Simplify meta-context parsing

2020-09-25 Thread Eric Blake
We had a premature optimization of trying to read as little from the wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. But in reality, we HAVE to read the entire string from the client before we can get to the next command, and it is easier to just read it all at once than it is t

Re: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-25 Thread Eduardo Habkost
On Fri, Sep 25, 2020 at 10:23:49PM +0200, Paolo Bonzini wrote: > On 25/09/20 18:54, Eduardo Habkost wrote: > > On Fri, Sep 25, 2020 at 04:42:26PM +, Strong, Beeman wrote: > >> LIP=0 will differ from LIP=1 behavior only when CSbase is non-zero, which > >> requires 32-bit code. In that case a L

Re: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-25 Thread Paolo Bonzini
On 25/09/20 18:54, Eduardo Habkost wrote: > On Fri, Sep 25, 2020 at 04:42:26PM +, Strong, Beeman wrote: >> LIP=0 will differ from LIP=1 behavior only when CSbase is non-zero, which >> requires 32-bit code. In that case a LIP=0 implementation will provide only >> the EIP offset from CSbase in

Re: [PATCH v26 04/17] vfio: Add migration region initialization and finalize function

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:06 +0530 Kirti Wankhede wrote: > Whether the VFIO device supports migration or not is decided based of > migration region query. If migration region query is successful and migration > region initialization is successful then migration is supported else > migration is bl

Re: [PATCH] hw/scsi/lsi53c895a: Sanitize some trace events format

2020-09-25 Thread Paolo Bonzini
On 15/09/20 19:46, Philippe Mathieu-Daudé wrote: > Make some lsi53c895a trace events more understandable. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/scsi/trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/scsi/trace-events b/hw/scsi/trace-even

[PULL v6 00/87] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-09-24 18:48:45 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

[PULL 30/87] meson: move libmpathpersist test

2020-09-25 Thread Paolo Bonzini
This is the first compiler/linker test that has been moved to Meson. Add more section headings to keep things clearer. This also fixes static linking to libmpathpersist, which has a dependency on libmultipath but no pkg-config file to describe it. Signed-off-by: Paolo Bonzini --- configure

[PULL 29/87] meson: move libudev test

2020-09-25 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 14 -- meson.build | 7 --- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 01fce2e94b..c05d1a04e9 100755 --- a/configure +++ b/configure @@ -908,7 +908,6 @@ Linux) linux_user="yes" k

[PULL 09/87] target/i386: support KVM_FEATURE_ASYNC_PF_INT

2020-09-25 Thread Paolo Bonzini
From: Vitaly Kuznetsov Linux-5.8 introduced interrupt based mechanism for 'page ready' events delivery and disabled the old, #PF based one (see commit 2635b5c4a0e4 "KVM: x86: interrupt based APF 'page ready' event delivery"). Linux guest switches to using in in 5.9 (see commit b1d405751cd5 "KVM:

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Paolo Bonzini
On 25/09/20 21:30, 罗勇刚(Yonggang Luo) wrote: > >> You'd have to create a .lib for qemu-system-aarch64.exe, one for >> qemu-system-arm.exe, etc.  On Linux the same plugin will work for all >> emulators. >> > OK, this made the things clear, the possible solution is to using > function pointer to expo

Re: [PATCH v1 03/15] meson: move libmpathpersist test

2020-09-25 Thread Alex Bennée
Paolo Bonzini writes: > On 25/09/20 17:40, Alex Bennée wrote: >> From: Paolo Bonzini >> >> This is the first compiler/linker test that has been moved to Meson. >> Add more section headings to keep things clearer. >> >> [thuth: Add check for mpathpersist.found() before showing >> mpathpersis

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 3:25 AM Paolo Bonzini wrote: > > On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: > > That's what I am tring to fixes? what does one import library per > > emulator, can we do this like NodeJS does? > > NodeJS have NAPI support across platform. They create a windows .lib from

Re: [PATCH 00/10] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925172604.2142227-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200925172604.2142227-1-pbonz...@redhat.com Subject: [PATCH 00/10] Fix scsi devices pl

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925162316.21205-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925162316.21205-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Paolo Bonzini
On 25/09/20 21:23, 罗勇刚(Yonggang Luo) wrote: > That's what I am tring to fixes? what does  one import library per > emulator, can we do this like NodeJS does? >  NodeJS have NAPI support across platform. They create a windows .lib from > node.exe You'd have to create a .lib for qemu-system-aarch64.

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
On Sat, Sep 26, 2020 at 3:20 AM Paolo Bonzini wrote: > > On 25/09/20 21:12, 罗勇刚(Yonggang Luo) wrote: > > currently the empty.c plugin are failed of linkage error > > > > The fowlloing are the failing message: > > Compiling C object tests/plugin/libbb.dll.p/bb.c.obj > > Linking target tests/plugin/

Re: [PATCH] target/i386: support KVM_FEATURE_ASYNC_PF_INT

2020-09-25 Thread Paolo Bonzini
On 12/09/20 08:02, Paolo Bonzini wrote: > @@ -4209,6 +4209,7 @@ static PropValue kvm_default_props[] = { > { "kvmclock", "on" }, > { "kvm-nopiodelay", "on" }, > { "kvm-asyncpf", "on" }, > +{ "kvm-asyncpf-int", "on" }, > { "kvm-steal-time", "on" }, > { "kvm-pv-eoi", "on"

Re: I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Paolo Bonzini
On 25/09/20 21:12, 罗勇刚(Yonggang Luo) wrote: > currently the empty.c plugin are failed of linkage error > > The fowlloing are the failing message: > Compiling C object tests/plugin/libbb.dll.p/bb.c.obj > Linking target tests/plugin/libempty.dll > Linking target tests/plugin/libinsn.dll > Linking ta

[PATCH v4 0/6] Qemu SEV-ES guest support

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky This patch series provides support for launching an SEV-ES guest. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Program

I wanna fixes plugin on windows, any suggestion

2020-09-25 Thread Yonggang Luo
currently the empty.c plugin are failed of linkage error The fowlloing are the failing message: Compiling C object tests/plugin/libbb.dll.p/bb.c.obj Linking target tests/plugin/libempty.dll Linking target tests/plugin/libinsn.dll Linking target tests/plugin/libmem.dll ../tests/plugin/bb.c: In func

Re: [PATCH v4 0/6] Qemu SEV-ES guest support

2020-09-25 Thread Tom Lendacky
On 9/25/20 2:03 PM, Tom Lendacky wrote: > From: Tom Lendacky > > This patch series provides support for launching an SEV-ES guest. > > Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the > SEV support to protect the guest register state from the hypervisor. See > "AMD64 Arc

[PATCH v4 6/6] sev/i386: Enable an SEV-ES guest based on SEV policy

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Tom Lendacky --- target/i38

[PATCH v4 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky In prep for AP booting, require the use of in-kernel irqchip support. This lessens the Qemu support burden required to boot APs. Signed-off-by: Tom Lendacky --- target/i386/sev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c

Re: [PULL v5 00/87] Misc patches for 2020-09-24

2020-09-25 Thread Paolo Bonzini
Il ven 25 set 2020, 20:44 Peter Maydell ha scritto: > On Fri, 25 Sep 2020 at 14:20, Paolo Bonzini wrote: > > > > The following changes since commit > 8c1c07929feae876202ba26f07a540c5115c18cd: > > > > Merge remote-tracking branch > 'remotes/stefanha/tags/block-pull-request' into staging (2020-0

[PATCH v4 5/6] kvm/i386: Use a per-VM check for SMM capability

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky SMM is not currently supported for an SEV-ES guest by KVM. Change the SMM capability check from a KVM-wide check to a per-VM check in order to have a finer-grained SMM capability check. Suggested-by: Sean Christopherson Signed-off-by: Tom Lendacky --- target/i386/kvm.c | 2

[PATCH v4 1/6] sev/i386: Add initial support for SEV-ES

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest CPU state is measured as part of the laun

[PATCH v4 3/6] sev/i386: Allow AP booting under SEV-ES

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate this because it cannot update the AP regi

[PATCH v4 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest

2020-09-25 Thread Tom Lendacky
From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When an SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES. Prevent that from occuring by introducing an arch-spe

Re: [PATCH v10 7/7] Versal: Connect DWC3 controller with virt-versal

2020-09-25 Thread Edgar E. Iglesias
On Thu, Sep 24, 2020 at 07:50:56PM +0530, Sai Pavan Boddu wrote: > From: Vikram Garhwal > > Connect dwc3 controller and usb2-reg module to xlnx-versal SOC, its placed > in iou of lpd domain and configure it as dual port host controller. Add the > respective guest dts nodes for "xlnx-versal-virt"

Re: virtiofs vs 9p performance(Re: tools/virtiofs: Multi threading seems to hurt performance)

2020-09-25 Thread Dr. David Alan Gilbert
* Christian Schoenebeck (qemu_...@crudebyte.com) wrote: > On Freitag, 25. September 2020 15:05:38 CEST Dr. David Alan Gilbert wrote: > > > > 9p ( mount -t 9p -o trans=virtio kernel /mnt > > > > -oversion=9p2000.L,cache=mmap,msize=1048576 ) test: (g=0): rw=randrw, > > > > > > Bottleneck ---

Re: [PULL 7/8] gitlab: create a build-deprecated target

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 19:34, Richard Henderson wrote: > > On 9/25/20 8:54 AM, Peter Maydell wrote: > > On Wed, 16 Sep 2020 at 14:52, Philippe Mathieu-Daudé > > wrote: > >> Should we stop building the ppc64abi32 target instead? > >> > >> From c609274b853 ("docs/system/deprecated: mark > >> ppc64

Re: [PULL v5 00/87] Misc patches for 2020-09-24

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 14:20, Paolo Bonzini wrote: > > The following changes since commit 8c1c07929feae876202ba26f07a540c5115c18cd: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-09-24 18:48:45 +0100) > > are available in the Git repository at:

Re: [PATCH V1 03/32] savevm: QMP command for cprsave

2020-09-25 Thread Steven Sistare
On 9/11/2020 12:43 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> To enable live reboot, provide the cprsave QMP command and the VMS_REBOOT >> vmstate-saving operation, which saves the state of the virtual machine in a >> simple file. >> >> Syntax: >> {'

Re: [PULL 7/8] gitlab: create a build-deprecated target

2020-09-25 Thread Richard Henderson
On 9/25/20 8:54 AM, Peter Maydell wrote: > On Wed, 16 Sep 2020 at 14:52, Philippe Mathieu-Daudé wrote: >> Should we stop building the ppc64abi32 target instead? >> >> From c609274b853 ("docs/system/deprecated: mark >> ppc64abi32-linux-user for deprecation"): >> >> The ppc64abi32 architecture has

Re: [RFC v4 53/70] target/riscv: rvv-1.0: floating-point slide instructions

2020-09-25 Thread Richard Henderson
On 9/25/20 1:21 AM, Frank Chang wrote: > I'm happy to reuse vslide1up_vx helper functions. > > However, opfvf_trans() takes helper prototype of: > /typedef void gen_helper_opfvf(TCGv_ptr, TCGv_ptr, TCGv_i64, TCGv_ptr, >                               TCGv_env, TCGv_i32);/ > but vslide1up_vx helper

Re: [RFC v4 17/70] target/riscv: rvv-1.0: configure instructions

2020-09-25 Thread Richard Henderson
On 9/25/20 1:51 AM, Frank Chang wrote: > trans_vsetvli() uses gen_goto_tb() to save the computation in the link to the > next TB. > I know there was a discussion about this back in RVV v0.7.1: > https://patchew.org/QEMU/20200103033347.20909-1-zhiwei_...@c-sky.com/20200103033347.20909-5-zhiwei_...@c

Re: [PATCH v4 09/14] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-25 Thread Klaus Jensen
On Sep 24 03:20, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Handlers for three new NVMe commands introduced in Zoned Namespace > Command Set specifica

Re: [PATCH v2 07/20] block/block-copy: add ratelimit to block-copy

2020-09-25 Thread Vladimir Sementsov-Ogievskiy
22.07.2020 14:05, Max Reitz wrote: On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: We are going to directly use one async block-copy operation for backup job, so we need rate limitator. %s/limitator/limiter/g, I think. We want to maintain current backup behavior: only background copyi

Re: [PATCH v5] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Philippe Mathieu-Daudé
On 9/25/20 7:17 PM, McMillan, Erich wrote: > Additionally HPi is not a mistake, corporate requires that we refer to > ourselves as Hewlett Packard Inc since the split in 2015. I will perhaps > update this to be the full name for clarity. Maybe worth be explicit, else it is confusing (since your em

Re: [PATCH V1 10/32] kvmclock: restore paused KVM clock

2020-09-25 Thread Steven Sistare
On 9/11/2020 1:50 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> If the VM is paused when the KVM clock is serialized to a file, record >> that the clock is valid, so the value will be reused rather than >> overwritten after cprload with a new call to KVM_

RE: [PATCH v1 1/3] i386: Remove the limitation of IP payloads for Intel PT

2020-09-25 Thread Strong, Beeman
LIP=0 will differ from LIP=1 behavior only when CSbase is non-zero, which requires 32-bit code. In that case a LIP=0 implementation will provide only the EIP offset from CSbase in IP packets (like TIP or FUP), while LIP=1 implementation will provide the full LIP (CSbase + EIP offset). -Ori

Re: [PATCH v5] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Dr. David Alan Gilbert
* McMillan, Erich (erich.mcmil...@hp.com) wrote: > Additionally HPi is not a mistake, corporate requires that we refer to > ourselves as Hewlett Packard Inc since the split in 2015. I will perhaps > update this to be the full name for clarity. Please note that no one outside of HP knows what HPi

[PATCH v6] hw/i386/pc: add max combined fw size as machine configuration option

2020-09-25 Thread Erich Mcmillan
From: Erich McMillan At Hewlett Packard Inc. we have a need for increased fw size to enable testing of our custom fw. Move return statement for early return Signed-off-by: Erich McMillan --- Changes since v5: Move return statement for pc_machine_set_max_fw_size() to follow error_setg()

Re: [PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

2020-09-25 Thread Greg Kurz
Cc'ing Jason since this was detected using vhost-net. On Fri, 25 Sep 2020 19:29:43 +0200 Greg Kurz wrote: > When a vIOMMU is present, any address comming from the guest is an IO > virtual address, including those of the vrings. The backend's accesses > to the vrings happen through vIOMMU transla

Re: Minix 1.1 with QEMU

2020-09-25 Thread John Snow
On 9/23/20 1:00 PM, Will Senn wrote: On 9/23/20 11:53 AM, Philippe Mathieu-Daudé wrote: Hi Will, On 9/23/20 6:45 PM, Will Senn wrote: Long time user, first time poster :) So, I'd like to be able to run Minix 1.1 on my Macbook Pro mid-2012 w/16gb RAM (MacOS 10.14.6 Mojave). Qemu will run prett

[PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

2020-09-25 Thread Greg Kurz
When a vIOMMU is present, any address comming from the guest is an IO virtual address, including those of the vrings. The backend's accesses to the vrings happen through vIOMMU translation : the backend hence only logs the final guest physical address, not the IO virtual one. It thus doesn't make s

Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

2020-09-25 Thread Klaus Jensen
On Sep 25 17:06, Dmitry Fomichev wrote: > > From: Klaus Jensen > > > > * Standard blockdev-based approach to persistent state. The > > > > implementation uses a plain blockdev associated with the nvme-ns > > > > device for storing state persistently. This same 'pstate' blockdev > > >

[PATCH 10/10] scsi/scsi_bus: fix races in REPORT LUNS

2020-09-25 Thread Paolo Bonzini
From: Maxim Levitsky Currently scsi_target_emulate_report_luns iterates over the child device list twice, and there is no guarantee that this list is the same in both iterations. The reason for iterating twice is that the first iteration calculates how much memory to allocate. However if we use

[PATCH 09/10] virtio-scsi: use scsi_device_get

2020-09-25 Thread Paolo Bonzini
From: Maxim Levitsky This will help us to avoid the scsi device disappearing after we took a reference to it. It doesn't by itself forbid case when we try to access an unrealized device Suggested-by: Stefan Hajnoczi Signed-off-by: Maxim Levitsky Reviewed-by: Stefan Hajnoczi Message-Id: <2020

[PATCH 08/10] scsi/scsi_bus: Add scsi_device_get

2020-09-25 Thread Paolo Bonzini
From: Maxim Levitsky Add scsi_device_get which finds the scsi device and takes a reference to it. Suggested-by: Stefan Hajnoczi Signed-off-by: Maxim Levitsky Message-Id: <20200913160259.32145-8-mlevi...@redhat.com> Signed-off-by: Paolo Bonzini --- Compared to Maxim's patch, I am avoid

  1   2   3   4   5   >