Re: [PATCH V2] qtest: Fix bad printf format specifiers

2020-11-04 Thread Thomas Huth
On 05/11/2020 07.50, AlexChen wrote: > We should use printf format specifier PRIu32 instead of "%d" for > argument of type 'uint32_t'. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > tests/qtest/arm-cpu-features.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [RFC PATCH] hw/arm/virt: use sbsa-ec for reboot and poweroff in secure mode

2020-11-04 Thread Maxim Uvarov
On Mon, 2 Nov 2020 at 16:53, Graeme Gregory wrote: > > On Thu, Oct 29, 2020 at 11:19:39AM +, Leif Lindholm wrote: > > Hi Peter, (+Ard) > > > > Graeme is on holiday this week, and I would like his input. > > > > On Wed, Oct 28, 2020 at 20:31:41 +, Peter Maydell wrote: > > > On Wed, 28 Oct

Re: [PATCH v9 0/8] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-11-04 Thread Gerd Hoffmann
Hi, Looking at the whole series for the first time after being Cc'ed on one of the patches. > Currently pxb-pcie is not supported by arm, > the reason for it is pxb-pcie is not described in DSDT table > and only one main host bridge is described in acpi tables, > which means it is not

Re: [RFC PATCH 0/9] gitlab-ci: Allow forks to skip some build jobs

2020-11-04 Thread Philippe Mathieu-Daudé
On 11/4/20 11:45 PM, Philippe Mathieu-Daudé wrote: > Hi, > > 2 months ago GitLab added time limit to their free CI offer [1]. > This series provide developers with the possibility to not run > all jobs. By default all jobs are started, but we can disable > a subset of them. > > I think this

Re: [PATCH 1/4] bsd-user: space required after semicolon

2020-11-04 Thread shiliyang
On 2020/11/4 19:13, Philippe Mathieu-Daudé wrote: > On 11/4/20 12:08 PM, Thomas Huth wrote: >> On 04/11/2020 11.20, shiliyang wrote: >>> This patch fixes error style problems found by checkpatch.pl: >>> ERROR: space required after that ';' >>> >>> Signed-off-by: Liyang Shi >>> >>> --- >>>

Re: [PULL 0/4] Linux user for 5.2 patches

2020-11-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201105070837.558332-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201105070837.558332-1-laur...@vivier.eu Subject: [PULL 0/4] Linux user for 5.2 patches

[PULL 3/4] linux-user/syscall: Fix missing target_to_host_timespec64() check

2020-11-04 Thread Laurent Vivier
From: Alistair Francis Coverity pointed out (CID 1432339) that target_to_host_timespec64() can fail with -TARGET_EFAULT but we never check the return value. This patch checks the return value and handles the error. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé

[PULL 0/4] Linux user for 5.2 patches

2020-11-04 Thread Laurent Vivier
The following changes since commit 8680d6e36468f1ca00e2fe749bef50585d632401: Merge remote-tracking branch 'remotes/nvme/tags/pull-nvme-20201102' into st= aging (2020-11-02 17:17:29 +) are available in the Git repository at: git://github.com/vivier/qemu.git

[PULL 1/4] linux-user/mips/cpu_loop: silence the compiler warnings

2020-11-04 Thread Laurent Vivier
From: Chen Qun When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: linux-user/mips/cpu_loop.c: In function ‘cpu_loop’: linux-user/mips/cpu_loop.c:104:24: warning: this statement may fall through [-Wimplicit-fallthrough=] 104 | if ((ret =

[PULL 4/4] linux-user: Check copy_from_user() return value in vma_dump_size()

2020-11-04 Thread Laurent Vivier
From: Peter Maydell Coverity points out that we don't check the return value from copy_from_user() in vma_dump_size(). This is to some extent a "can't happen" error since we've already checked the page with an access_ok() call earlier, but it's simple enough to handle the error anyway. Fixes:

[PULL 2/4] linux-user: Use "!= 0" when checking if MAP_FIXED_NOREPLACE is non-zero

2020-11-04 Thread Laurent Vivier
From: Peter Maydell In pgd_find_hole_fallback(), Coverity doesn't like the use of "if (MAP_FIXED_NOREPLACE || ...)" because it's using a logical operator on a constant other than 0 or 1 and its heuristic thinks we might have intended a bitwise operator instead. The logic is correct (we are

[PATCH] hw/intc: fix heap-buffer-overflow in rxicu_realize()

2020-11-04 Thread Chen Qun
When 'j = icu->nr_sense – 1', the 'j < icu->nr_sense' condition is true, then 'j = icu->nr_sense', the'icu->init_sense[j]' has out-of-bounds access. Maybe this could lead to some security problems. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60404d7d at

Re: [PATCH 2/2] plugins: Fix two resource leaks in connect_socket()

2020-11-04 Thread AlexChen
Kindly ping. On 2020/10/28 21:45, AlexChen wrote: > Either accept() fails or exits normally, we need to close the fd. > > Reported-by: Euler Robot > Signed-off-by: AlexChen > --- > contrib/plugins/lockstep.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()

2020-11-04 Thread AlexChen
Kindly ping. On 2020/10/28 21:45, AlexChen wrote: > Close the fd when connect() fails. > > Reported-by: Euler Robot > Signed-off-by: AlexChen > --- > contrib/plugins/lockstep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c >

[PATCH V2] qtest: Fix bad printf format specifiers

2020-11-04 Thread AlexChen
We should use printf format specifier PRIu32 instead of "%d" for argument of type 'uint32_t'. Reported-by: Euler Robot Signed-off-by: Alex Chen --- tests/qtest/arm-cpu-features.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c

Re: VFIO Migration

2020-11-04 Thread Gerd Hoffmann
Hi, > > > Yes. If you are creating a custom device that no one else needs to > > > emulate then you can simply pick a unique URL: > > > > > > https://vendor.com/my-dev > > > > > > There doesn't need to be anything at the URL. It's just a unique string > > > that no one else will use and

Re: [PATCH v9 02/12] hw/block/nvme: Generate namespace UUIDs

2020-11-04 Thread Klaus Jensen
On Nov 5 11:53, Dmitry Fomichev wrote: > In NVMe 1.4, a namespace must report an ID descriptor of UUID type > if it doesn't support EUI64 or NGUID. Add a new namespace property, > "uuid", that provides the user the option to either specify the UUID > explicitly or have a UUID generated

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Markus Armbruster
Thomas Huth writes: > On 04/11/2020 15.16, BALATON Zoltan wrote: >> On Wed, 4 Nov 2020, Thomas Huth wrote: >>> On 26/09/2020 16.02, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level.

Re: Migrating to the gitlab issue tracker

2020-11-04 Thread Thomas Huth
On 05/11/2020 01.06, John Snow wrote: > On 10/30/20 6:57 AM, Peter Maydell wrote: >> On Fri, 30 Oct 2020 at 10:10, Daniel P. Berrangé wrote: >>> This >>> makes it more appealing to leave existing bugs in the LP tracker until >>> they are resolved, auto-closed, or there is a compelling reason to

[PATCH] replay: remove some dead code

2020-11-04 Thread Pavel Dovgalyuk
This patch removes dead code in replay_continue_stop() function. Signed-off-by: Pavel Dovgalyuk Reported-by: Philippe Mathieu-Daudé --- replay/replay-debugging.c |3 --- 1 file changed, 3 deletions(-) diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c index

Re: [PATCH] qtest: Fix bad printf format specifiers

2020-11-04 Thread Thomas Huth
On 05/11/2020 06.14, AlexChen wrote: > On 2020/11/4 18:44, Thomas Huth wrote: >> On 04/11/2020 11.23, AlexChen wrote: >>> We should use printf format specifier "%u" instead of "%d" for >>> argument of type "unsigned int". >>> >>> Reported-by: Euler Robot >>> Signed-off-by: Alex Chen >>> --- >>>

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-04 Thread Pavel Dovgalyuk
On 04.11.2020 20:31, Cornelia Huck wrote: On Mon, 02 Nov 2020 12:26:59 +0300 Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Signed-off-by: Pavel

[PATCH v3] target/s390x: fix execution with icount

2020-11-04 Thread Pavel Dovgalyuk
This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Signed-off-by: Pavel Dovgalyuk Suggested-by: Richard Henderson Acked-by: David Hildenbrand Reviewed-by: Richard Henderson ---

Re: [PATCH 1/5] file-posix: split hdev_refresh_limits from raw_refresh_limits

2020-11-04 Thread Tom Yan
Actually I made a mistake in this. BLKSECTGET (the one in the block layer) returns the number of "sectors", which is "defined" as 512-byte block. So we shouldn't use BLKSSZGET here, but simply 512 (1 << 9). See logical_to_sectors() in sd.h of the kernel. On Thu, 5 Nov 2020 at 01:32, Maxim

RE: [PATCH] block: Return the real error code in bdrv_getlength

2020-11-04 Thread Tuguoyi
Sorry, please ignore this patch, it's not a right fix -- Best regards, Guoyi > -Original Message- > From: tuguoyi (Cloud) > Sent: Thursday, November 05, 2020 11:11 AM > To: 'Kevin Wolf' ; 'Max Reitz' ; > 'qemu-bl...@nongnu.org' > Cc: 'qemu-devel@nongnu.org' > Subject: [PATCH] block:

[PATCH] block: Fix integer promotion error in bdrv_getlength()

2020-11-04 Thread Tuguoyi
As BDRV_SECTOR_SIZE is of type uint64_t, the expression will automatically convert the @ret to uint64_t. When an error code returned from bdrv_nb_sectors(), the promoted @ret will be a very large number, as a result the -EFBIG will be returned which is not the real error code. Signed-off-by:

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Thomas Huth
On 04/11/2020 20.29, Mark Cave-Ayland wrote: > On 04/11/2020 12:47, Thomas Huth wrote: > >> On 26/09/2020 16.02, Mark Cave-Ayland wrote: >>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the >>> Mac Old World and New World machine level. >>> >>> Also remove the now

Re: [PATCH] qtest: Fix bad printf format specifiers

2020-11-04 Thread AlexChen
On 2020/11/4 18:44, Thomas Huth wrote: > On 04/11/2020 11.23, AlexChen wrote: >> We should use printf format specifier "%u" instead of "%d" for >> argument of type "unsigned int". >> >> Reported-by: Euler Robot >> Signed-off-by: Alex Chen >> --- >> tests/qtest/arm-cpu-features.c | 8 >>

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-04 Thread Ying Fang
On 11/5/2020 5:46 AM, Laszlo Ersek wrote: +Ard, +Drew On 11/03/20 13:39, Igor Mammedov wrote: On Fri, 30 Oct 2020 10:50:01 +0800 Ying Fang wrote: Hi, I have a question on UEFI/ACPI tables setup and probing on arm64 platform. CCing Laszlo, who might know how it's implemented.

[Bug 1708617] Re: qemu2.9 meet a question using reconnect about ovs+dpdk

2020-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1708617 Title: qemu2.9

[Bug 1715162] Re: qemu-user crashing when writing core dump

2020-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715162 Title: qemu-user

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

2020-11-04 Thread Stefano Stabellini
On Wed, 4 Nov 2020, Thomas Huth wrote: > On 04/11/2020 03.27, Stefano Stabellini wrote: > [...] > > Actually I care about Xen and 9pfs support, it is one of the few > > combinations that I use regularly and it is even enabled in the Xilinx > > product I look after. But admittedly I don't test QEMU

[Bug 1715715] Re: [qemu-ppc] Segfault when booting from HD after MacOS9 install

2020-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715715 Title: [qemu-ppc]

[Bug 1712818] Re: live migration with storage encounter assert(!(bs->open_flags & BDRV_O_INACTIVE)) crashes

2020-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1712818 Title: live

[Bug 1708442] Re: Crash(assert) during reading image from http url through qemu-nbd

2020-11-04 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1708442 Title:

Re: [RFC PATCH 6/6] docs: Added eBPF documentation.

2020-11-04 Thread Jason Wang
On 2020/11/3 上午2:51, Andrew Melnychenko wrote: From: Andrew Also, added maintainers information. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 6 +++ docs/ebpf.rst | 29 +++ docs/ebpf_rss.rst | 129

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Jason Wang
On 2020/11/5 上午11:46, Jason Wang wrote: It's probably ok if we treat the bytecode as a kind of firmware. That is explicitly *not* OK for inclusion in Fedora. They require that BPF is compiled from source, and rejected my suggestion that it could be considered a kind of firmware and thus have

[PULL 0/3] ppc-for-5.2 patch queue 2020-11-05

2020-11-04 Thread David Gibson
The following changes since commit 3c8c36c9087da957f580a9bb5ebf7814a753d1c6: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201104-pull-request' into staging (2020-11-04 16:52:17 +) are available in the Git repository at: https://gitlab.com/dgibson/qemu.git tags/ppc-for-5.2

[PULL 2/3] spapr: Drop dead code in spapr_reallocate_hpt()

2020-11-04 Thread David Gibson
From: Greg Kurz Sometimes QEMU needs to allocate the HPT in userspace, namely with TCG or PR KVM. This is performed with qemu_memalign() because of alignment requirements. Like glib's allocators, its behaviour is to abort on OOM instead of returning NULL. This could be changed to

[PULL 1/3] target/ppc/excp_helper: Add a fallthrough for fix compiler warning

2020-11-04 Thread David Gibson
From: Chen Qun When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: ../target/ppc/excp_helper.c: In function ‘powerpc_excp’: ../target/ppc/excp_helper.c:529:13: warning: this statement may fall through [-Wimplicit-fallthrough=] 529 | msr |= env->error_code;

[PULL 3/3] spapr: Convert hpt_prepare_thread() to use qemu_try_memalign()

2020-11-04 Thread David Gibson
From: Greg Kurz HPT resizing is asynchronous: the guest first kicks off the creation of a new HPT, then it waits for that new HPT to be actually created and finally it asks the current HPT to be replaced by the new one. In the case of a userland allocated HPT, this currently relies on calling

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-04 Thread Jason Wang
On 2020/11/4 下午5:31, Daniel P. Berrangé wrote: On Wed, Nov 04, 2020 at 10:07:52AM +0800, Jason Wang wrote: On 2020/11/3 下午6:32, Yuri Benditovich wrote: On Tue, Nov 3, 2020 at 11:02 AM Jason Wang mailto:jasow...@redhat.com>> wrote: On 2020/11/3 上午2:51, Andrew Melnychenko wrote: >

Re: [RFC PATCH 5/6] virtio-net: Added eBPF RSS to virtio-net.

2020-11-04 Thread Jason Wang
On 2020/11/4 下午7:07, Yuri Benditovich wrote: On Wed, Nov 4, 2020 at 5:09 AM Jason Wang > wrote: On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > From: Andrew mailto:and...@daynix.com>> > > When RSS is enabled the device tries to load the eBPF

[PATCH] block: Return the real error code in bdrv_getlength

2020-11-04 Thread Tuguoyi
The return code from bdrv_nb_sectors() should be checked before doing the following sanity check. Signed-off-by: Guoyi Tu --- block.c | 4 1 file changed, 4 insertions(+) diff --git a/block.c b/block.c index 430edf7..19ebbc0 100644 --- a/block.c +++ b/block.c @@ -5082,6 +5082,10 @@

Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-04 Thread Jiahui Cen
Hi Phil, On 2020/11/5 5:11, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 11/4/20 9:05 PM, Laszlo Ersek wrote: >> +Phil, +Gerd >> >> On 11/04/20 20:54, Laszlo Ersek wrote: >>> +Marcel >>> >>> On 11/03/20 13:01, Jiahui Cen wrote: From: Yubo Miao Write the extra roots into the

Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-04 Thread Jiahui Cen
On 2020/11/5 4:05, Laszlo Ersek wrote: > +Phil, +Gerd > > On 11/04/20 20:54, Laszlo Ersek wrote: >> +Marcel >> >> On 11/03/20 13:01, Jiahui Cen wrote: >>> From: Yubo Miao >>> >>> Write the extra roots into the fw_cfg, therefore the uefi could >>> get the extra roots. Only if the uefi knows

[PATCH v9 12/12] hw/block/nvme: Document zoned parameters in usage text

2020-11-04 Thread Dmitry Fomichev
Added brief descriptions of the new device properties that are now available to users to configure features of Zoned Namespace Command Set in the emulator. This patch is for documentation only, no functionality change. Signed-off-by: Dmitry Fomichev Reviewed-by: Niklas Cassel ---

[PATCH v9 11/12] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-11-04 Thread Dmitry Fomichev
ZNS specification defines two zone conditions for the zones that no longer can function properly, possibly because of flash wear or other internal fault. It is useful to be able to "inject" a small number of such zones for testing purposes. This commit defines two optional device properties,

[PATCH v9 06/12] hw/block/nvme: Support allocated CNS command variants

2020-11-04 Thread Dmitry Fomichev
From: Niklas Cassel Many CNS commands have "allocated" command variants. These include a namespace as long as it is allocated, that is a namespace is included regardless if it is active (attached) or not. While these commands are optional (they are mandatory for controllers supporting the

[PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-04 Thread Dmitry Fomichev
The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. Define

[PATCH v9 10/12] hw/block/nvme: Support Zone Descriptor Extensions

2020-11-04 Thread Dmitry Fomichev
Zone Descriptor Extension is a label that can be assigned to a zone. It can be set to an Empty zone and it stays assigned until the zone is reset. This commit adds a new optional module property, "zoned.descr_ext_size". Its value must be a multiple of 64 bytes. If this value is non-zero, it

[PATCH v9 09/12] hw/block/nvme: Introduce max active and open zone limits

2020-11-04 Thread Dmitry Fomichev
Add two module properties, "zoned.max_active" and "zoned.max_open" to control the maximum number of zones that can be active or open. Once these variables are set to non-default values, these limits are checked during I/O and Too Many Active or Too Many Open command status is returned if they are

[PATCH v9 07/12] block/nvme: Make ZNS-related definitions

2020-11-04 Thread Dmitry Fomichev
Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053). Signed-off-by: Dmitry Fomichev --- include/block/nvme.h | 114 ++- 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/include/block/nvme.h

[PATCH v9 05/12] hw/block/nvme: Add support for Namespace Types

2020-11-04 Thread Dmitry Fomichev
From: Niklas Cassel Define the structures and constants required to implement Namespace Types support. Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable

[PATCH v9 02/12] hw/block/nvme: Generate namespace UUIDs

2020-11-04 Thread Dmitry Fomichev
In NVMe 1.4, a namespace must report an ID descriptor of UUID type if it doesn't support EUI64 or NGUID. Add a new namespace property, "uuid", that provides the user the option to either specify the UUID explicitly or have a UUID generated automatically every time a namespace is initialized.

[PATCH v9 03/12] hw/block/nvme: Separate read and write handlers

2020-11-04 Thread Dmitry Fomichev
With ZNS support in place, the majority of code in nvme_rw() has become read- or write-specific. Move these parts to two separate handlers, nvme_read() and nvme_write() to make the code more readable and to remove multiple is_write checks that so far existed in the i/o path. This is a refactoring

[PATCH v9 00/12] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-11-04 Thread Dmitry Fomichev
v8 -> v9: - Move the modifications to "include/block/nvme.h" made to introduce ZNS-related definitions into a separate patch. - Add a new struct, NvmeZonedResult, along the same lines as the existing NvmeAerResult, to carry Zone Append LBA returned to the host. Now, there is no need

[PATCH v9 01/12] hw/block/nvme: Add Commands Supported and Effects log

2020-11-04 Thread Dmitry Fomichev
This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series. All

[PATCH v9 04/12] hw/block/nvme: Merge nvme_write_zeroes() with nvme_write()

2020-11-04 Thread Dmitry Fomichev
nvme_write() now handles WRITE, WRITE ZEROES and ZONE_APPEND. Signed-off-by: Dmitry Fomichev Reviewed-by: Niklas Cassel Acked-by: Klaus Jensen --- hw/block/nvme.c | 72 +-- hw/block/trace-events | 1 - 2 files changed, 28 insertions(+), 45

Re: [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config

2020-11-04 Thread Stefano Stabellini
On Wed, 4 Nov 2020, Paolo Bonzini wrote: > Il mer 4 nov 2020, 03:27 Stefano Stabellini ha > scritto: > FYI I tried to build the latest QEMU on Alpine Linux 3.12 ARM64 and I > get: > >   ninja: unknown tool 'query' > > Even after rebuilding ninja master by hand. Any

[Bug 1901981] Re: assert issue locates in hw/usb/dev-storage.c:248: usb_msd_send_status

2020-11-04 Thread Gaoning Pan
OK, It seems to be fixed now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1901981 Title: assert issue locates in hw/usb/dev-storage.c:248: usb_msd_send_status Status in QEMU: New Bug

[Bug 1902975] [NEW] qemu.org/docs/ contains some old docs

2020-11-04 Thread Jonathan Watt
Public bug reported: When I searched for QEMU docs in a search engine I ended up on this page: https://www.qemu.org/docs/master/qemu-doc.html That is 4.2.50 documentation. It took me some time to realize that there is actually 5.1.50 documentation under https://www.qemu.org/docs/master/ and

Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write()

2020-11-04 Thread chen huacai
Hi, Philippe, On Wed, Nov 4, 2020 at 12:17 PM chen huacai wrote: > > Hi, Philippe and Jiaxun, > > On Wed, Nov 4, 2020 at 1:17 AM Philippe Mathieu-Daudé wrote: > > > > On 11/3/20 4:40 PM, Jiaxun Yang wrote: > > > 于 2020年11月3日 GMT+08:00 下午8:28:27, "Philippe Mathieu-Daudé" > > > 写到: > > >> On

[PULL for-5.2 2/2] tcg: Revert "tcg/optimize: Flush data at labels not TCG_OPF_BB_END"

2020-11-04 Thread Richard Henderson
This reverts commit cd0372c515c4732d8bd3777cdd995c139c7ed7ea. The patch is incorrect in that it retains copies between globals and non-local temps, and non-local temps still die at the end of the BB. Failing test case for hppa: .globl _start _start: cmpiclr,=

[PULL for-5.2 1/2] tcg: Remove assert from set_jmp_reset_offset

2020-11-04 Thread Richard Henderson
Since 6e6c4efed99, there has been a more appropriate range check done later at the end of tcg_gen_code. There, a failing range check results in a returned error code, which causes the TB to be restarted at half the size. Reported-by: Sai Pavan Boddu Tested-by: Sai Pavan Boddu Reviewed-by:

[PULL for-5.2 0/2] tcg patch queue

2020-11-04 Thread Richard Henderson
The following changes since commit 3c8c36c9087da957f580a9bb5ebf7814a753d1c6: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201104-pull-request' into staging (2020-11-04 16:52:17 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg

Re: Migrating to the gitlab issue tracker

2020-11-04 Thread John Snow
On 10/30/20 6:57 AM, Peter Maydell wrote: On Fri, 30 Oct 2020 at 10:10, Daniel P. Berrangé wrote: This makes it more appealing to leave existing bugs in the LP tracker until they are resolved, auto-closed, or there is a compelling reason to move to gitlab. The compelling reason is that there

[Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

2020-11-04 Thread John Snow
TLDR: I am not actively working on this, because the problem extends well below IDE and I don't have the bandwidth to take point on this at the moment. Here's a writeup I sent to qemu-devel on 2020-07-30: First, the (partially bogus, fuzzer-generated) IDE command wants to: 1. dma write 259

Re: [QEMU] Question regarding user mode support for ARM syscalls

2020-11-04 Thread Laurent Vivier
Le 04/11/2020 à 11:57, Lukasz Majewski a écrit : > Hi Alistair, > >> On Tue, Nov 3, 2020 at 8:55 AM Lukasz Majewski wrote: >>> >>> Hi Alistair, >>> On Tue, Nov 3, 2020 at 3:03 AM Lukasz Majewski wrote: > > Dear Qemu Community, Hey Lukasz, + QEMU Dev

[Bug 1872237] Re: SysTick reload behavior emulated incorrectly

2020-11-04 Thread John Snow
Merged: https://patchew.org/QEMU/20201015151829.14656-1-peter.mayd...@linaro.org/ Commits: https://gitlab.com/qemu-project/qemu/-/commit/68d59c6d8d85ae176d3cb2cd20a48d6a090ba288 https://gitlab.com/qemu-project/qemu/-/commit/32bd322a0134ed89db00f2b9b3894982db3dedcb ** Changed in: qemu

[Bug 1878043] Re: memcpy param-overlap in Slirp ip_stripoptions through e1000e

2020-11-04 Thread John Snow
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878043 Title: memcpy param-overlap in Slirp ip_stripoptions through e1000e Status in

[Bug 1835865] Re: piix crashes on mips when accessing acpi-pci-hotplug

2020-11-04 Thread John Snow
** Changed in: qemu Status: In Progress => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835865 Title: piix crashes on mips when accessing acpi-pci-hotplug Status in QEMU:

Re: locking option doesn't work as expected

2020-11-04 Thread Masayoshi Mizuma
On Wed, Nov 04, 2020 at 04:48:53PM +, Daniel P. Berrangé wrote: > On Wed, Nov 04, 2020 at 11:35:56AM -0500, Masayoshi Mizuma wrote: > > Hello, > > > > It seems that locking option doesn't work as expected. > > When I run qemu as following options, then I got an error and failed to > > boot

[Bug 1817239] Re: add '--targets' option to qemu-binfmt-conf.sh

2020-11-04 Thread John Snow
This series appears to have stalled as of v7: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04241.html -- moving back to 'New' status. ** Changed in: qemu Status: In Progress => New -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1826200] Re: RFE: populate "OEM Strings" (type 11) SMBIOS table strings from regular files

2020-11-04 Thread John Snow
Merged: https://patchew.org/QEMU/20200923133804.2089190-1-berra...@redhat.com/ Commits: https://gitlab.com/qemu-project/qemu/-/commit/bb99f4772f54017490e3356ecbb3df25c5d4537f https://gitlab.com/qemu-project/qemu/-/commit/10c358f53c5ec8fd9ec27cdf5c393ff814a0

Re: [Bug 1879672] Re: QEMU installer with WHPX support

2020-11-04 Thread Philippe Mathieu-Daudé
Hi John, On 11/4/20 9:01 PM, John Snow wrote: > Removing 'Opinion' and moving back to 'New'; as 'Opinion' is essentially > the same as "WONTFIX" but allows discussion to continue. I believe you > want a Feature Request tag instead. > > If there is still work for us to do, let's move this to >

[Bug 1611394] Re: qemu-ppc: Scalar Single-Precision Floating-Point instructions should not test MSR[SPV]

2020-11-04 Thread John Snow
Assuming that this commit: https://gitlab.com/qemu-project/qemu/-/commit/8dcdb535d7cc4ba6270bb756e12e1d323254ed4e is sufficient to mark this bug as Fix Committed. Please re-open if I am mistaken. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug

[Bug 1888918] Re: qemu-system-ppc: Floating point instructions do not properly generate the SPE/Embedded Floating-Point Unavailable interrupt

2020-11-04 Thread John Snow
Assuming that this commit: https://gitlab.com/qemu-project/qemu/-/commit/8dcdb535d7cc4ba6270bb756e12e1d323254ed4e is sufficient to mark this bug as Fix Committed. Please re-open if I am mistaken. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug

[Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl

2020-11-04 Thread John Snow
Moving this bug back to Confirmed to move it out of "In progress" state. We still check for only -1 upstream. ** Changed in: qemu Status: In Progress => Confirmed ** Changed in: qemu Assignee: Christoffer Dall (cdall) => (unassigned) -- You received this bug notification because

[RFC PATCH 7/9] gitlab-ci: Extract common job definition as 'native_common_job'

2020-11-04 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.native_build_job' and '.native_test_job' to '.native_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[RFC PATCH 8/9] gitlab-ci: Add rules to skip building cross-jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Add rules to skip some crossbuild jobs. The following tags are available to skip CI jobs: - cross (skip all cross-jobs) - system (skip all cross-system jobs) - user (skip all cross-user jobs) Developers can combine tags in the SKIP_BUILD variable when pushing a branch (or tag) to

[RFC PATCH 9/9] gitlab-ci: Add rules to skip building/testing native jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Add rules to skip various build/test jobs. The following tags are available to skip CI jobs: - user(user-mode jobs) - system (system-mode jobs) - centos (jobs based on CentOS distribution image) - debian (... Debian) - fedora (... Fedora) - ubuntu

[RFC PATCH 1/9] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 40 ++-- 1 file changed, 20 insertions(+), 20

[RFC PATCH 6/9] gitlab-ci: Extract common job definition as 'cross_common_job'

2020-11-04 Thread Philippe Mathieu-Daudé
Extract the common definitions shared by '.cross_system_build_job' and '.cross_user_build_job' to '.cross_common_job'. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/crossbuilds.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml

[RFC PATCH 5/9] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-04 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 5c64e477c9d..0b77a90dd73 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -48,7 +48,7 @@ include: - find .

[RFC PATCH 3/9] gitlab-ci: Replace YAML anchors by extends (native_test_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[RFC PATCH 4/9] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[RFC PATCH 2/9] gitlab-ci: Replace YAML anchors by extends (native_build_job)

2020-11-04 Thread Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors and is a little more flexible and readable. See: https://docs.gitlab.com/ee/ci/yaml/#extends Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff

[RFC PATCH 0/9] gitlab-ci: Allow forks to skip some build jobs

2020-11-04 Thread Philippe Mathieu-Daudé
Hi, 2 months ago GitLab added time limit to their free CI offer [1]. This series provide developers with the possibility to not run all jobs. By default all jobs are started, but we can disable a subset of them. I think this should be the other way around (enable features one wants to test, with

[Bug 1893667] Re: Btrfs commands don't work when using user-space emulation of other architectures

2020-11-04 Thread John Snow
Laurent, I am assuming that the commits here: https://gitlab.com/qemu-project/qemu/-/commits/master?utf8=%E2%9C%93=Filip+Bozuta are sufficient to mark this issue as Fix Committed. It looks like the Downstream bug tracker for Fedora has marked the related bug as CLOSED ERRATA already. If I'm

[Bug 1900779] Re: xp /16i on arm mixes DWords

2020-11-04 Thread John Snow
https://gitlab.com/qemu- project/qemu/-/commit/437588d81d99ac91cb1e4ff060610458e67852d5 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900779 Title: xp /16i on arm mixes DWords Status in QEMU:

[Bug 1900779] Re: xp /16i on arm mixes DWords

2020-11-04 Thread John Snow
Staged: 437588d81d99ac91cb1e4ff060610458e67852d5 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900779 Title: xp /16i on arm mixes

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-04 Thread Ard Biesheuvel
On 11/4/20 10:46 PM, Laszlo Ersek wrote: ... (9) (Ard, please correct the below if necessary; thanks.) The UEFI stub of the guest kernel (which is a UEFI application) uses a device tree as its main communication channel to the (later-started) kernel entry point, AIUI. The UEFI stub basically

Re: [PULL v3 05/12] qga: add command guest-get-disks

2020-11-04 Thread Eric Blake
[Adding Markus in CC] On 11/2/20 8:43 PM, Michael Roth wrote: > From: Tomáš Golembiovský > > Add API and stubs for new guest-get-disks command. > > The command guest-get-fsinfo can be used to list information about disks > and partitions but it is limited only to mounted disks with filesystem.

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-04 Thread Laszlo Ersek
+Ard, +Drew On 11/03/20 13:39, Igor Mammedov wrote: > On Fri, 30 Oct 2020 10:50:01 +0800 > Ying Fang wrote: > >> Hi, >> >> I have a question on UEFI/ACPI tables setup and probing on arm64 platform. > > CCing Laszlo, > who might know how it's implemented. > >> Currently on arm64 platform

Re: [PATCH] ssi: Fix bad printf format specifiers

2020-11-04 Thread Chubb, Peter (Data61, Kensington NSW)
> "AlexChen" == AlexChen writes: AlexChen> We should use printf format specifier "%u" instead of "%d" AlexChen> for argument of type "unsigned int". AlexChen> Reported-by: Euler Robot AlexChen>Signed-off-by: Alex Chen --- LGTM, add Reviewed-By: Peter Chubb -- Peter Chubb

Re: [PATCH V2] vl: pause option

2020-11-04 Thread Alex Bennée
Eric Blake writes: > On 11/2/20 9:50 AM, Steve Sistare wrote: >> Provide the -pause command-line parameter and the QEMU_PAUSE environment >> variable to pause QEMU during process startup using SIGSTOP and allow a >> developer to attach a debugger, or observe the process using tools such as >>

Re: [PATCH] linux-user: Check copy_from_user() return value in vma_dump_size()

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 15:15, Peter Maydell a écrit : > Coverity points out that we don't check the return value from > copy_from_user() in vma_dump_size(). This is to some extent > a "can't happen" error since we've already checked the page > with an access_ok() call earlier, but it's simple enough to >

Re: [PATCH v1 1/1] linux-user/syscall: Fix missing target_to_host_timespec64() check

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 20:48, Alistair Francis a écrit : > Coverity pointed out (CID 1432339) that target_to_host_timespec64() can > fail with -TARGET_EFAULT but we never check the return value. This patch > checks the return value and handles the error. > > Signed-off-by: Alistair Francis > --- >

Re: [PATCH] linux-user: Use "!= 0" when checking if MAP_FIXED_NOREPLACE is non-zero

2020-11-04 Thread Laurent Vivier
Le 03/11/2020 à 15:26, Peter Maydell a écrit : > In pgd_find_hole_fallback(), Coverity doesn't like the use > of "if (MAP_FIXED_NOREPLACE || ...)" because it's using a > logical operator on a constant other than 0 or 1 and its > heuristic thinks we might have intended a bitwise operator > instead.

  1   2   3   4   5   >