Re: [RFC PATCH V2 00/11] hw/block/nvme: support multi-path for ctrl/ns

2021-01-18 Thread Minwoo Im
On 21-01-19 07:04:04, Klaus Jensen wrote: > On Jan 19 12:21, Minwoo Im wrote: > > On 21-01-18 22:14:45, Klaus Jensen wrote: > > > On Jan 17 23:53, Minwoo Im wrote: > > > > Hello, > > > > > > > > This patch series introduces NVMe subsystem device to support multi-path > > > > I/O in NVMe device

Re: [RFC PATCH V2 02/11] hw/block/nvme: open code for volatile write cache

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > Volatile Write Cache(VWC) feature is set in nvme_ns_setup() in the > initial time. This feature is related to block device backed, but this > feature is controlled in controller level via Set/Get Features command. > > This patch removed dependency between

Re: [PATCH] tests/acceptance: Test PMON with Loongson-3A1000 CPU

2021-01-18 Thread Philippe Mathieu-Daudé
On 1/19/21 7:59 AM, Jiaxun Yang wrote: > On Tue, Jan 19, 2021, at 1:57 PM, Philippe Mathieu-Daudé wrote: >> On 1/18/21 5:54 PM, Alex Bennée wrote: >>> Philippe Mathieu-Daudé writes: On 1/12/21 3:07 AM, Jiaxun Yang wrote: > Test booting of PMON bootloader on loongson3-virt platform. >

Re: [RFC Qemu PATCH v2 1/2] spapr: drc: Add support for async hcalls at the drc level

2021-01-18 Thread Shivaprasad G Bhat
Thanks for the comments! On 12/28/20 2:08 PM, David Gibson wrote: On Mon, Dec 21, 2020 at 01:08:53PM +0100, Greg Kurz wrote: ... The overall idea looks good but I think you should consider using a thread pool to implement it. See below. I am not convinced, however. Specifically, attaching

[Bug 1811711] Re: qemu-img can not convert virtualbox virtual disk formats qcow

2021-01-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1811653] Re: usbredir slow when multi bulk packet per second

2021-01-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1811862] Re: microcode version stays 0x1 even if -cpu host is used

2021-01-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1811916] Re: SDL2 interface didn't follow the current X11 keyboard layout for hotkeys

2021-01-18 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

Re: [PATCH] tests/acceptance: Test PMON with Loongson-3A1000 CPU

2021-01-18 Thread Jiaxun Yang
On Tue, Jan 19, 2021, at 1:57 PM, Philippe Mathieu-Daudé wrote: > On 1/18/21 5:54 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 1/12/21 3:07 AM, Jiaxun Yang wrote: > >>> Test booting of PMON bootloader on loongson3-virt platform. > >>> > >>> $ (venv)

[PATCH] target/arm/m_helper: Silence GCC 10 maybe-uninitialized error

2021-01-18 Thread Philippe Mathieu-Daudé
When building with GCC 10.2 configured with --extra-cflags=-Os, we get: target/arm/m_helper.c: In function ‘arm_v7m_cpu_do_interrupt’: target/arm/m_helper.c:1811:16: error: ‘restore_s16_s31’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1811 | if

[Bug 1269628] Re: Feature Request: Please add TCG OPAL 2 emulation support to the virtio disk emulation

2021-01-18 Thread Christ Schlacta
** Changed in: qemu Status: Expired => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1269628 Title: Feature Request: Please add TCG OPAL 2 emulation support to the virtio disk

[Bug 1605123] Re: PEXT returns wrong values, seemingly switches arguments

2021-01-18 Thread Thomas Huth
Fix has been committed: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=75b208c28316095c4685 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PULL 13/13] spapr_cpu_core.c: use g_auto* in spapr_create_vcpu()

2021-01-18 Thread David Gibson
From: Daniel Henrique Barboza Use g_autoptr() with Object and g_autofree with the string to avoid the need of a cleanup path. Signed-off-by: Daniel Henrique Barboza Message-Id: <20210114180628.1675603-6-danielhb...@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 12

[PULL 11/13] spapr_hcall.c: make do_client_architecture_support static

2021-01-18 Thread David Gibson
From: Daniel Henrique Barboza The function is called only inside spapr_hcall.c. Signed-off-by: Daniel Henrique Barboza Message-Id: <20210114180628.1675603-3-danielhb...@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_hcall.c | 1 + include/hw/ppc/spapr.h | 5 - 2 files changed,

[PULL 10/13] spapr.h: fix trailing whitespace in phb_placement

2021-01-18 Thread David Gibson
From: Daniel Henrique Barboza This whitespace was messing with lots of diffs if you happen to use an editor that eliminates trailing whitespaces on file save. Signed-off-by: Daniel Henrique Barboza Message-Id: <20210114180628.1675603-2-danielhb...@gmail.com> Signed-off-by: David Gibson ---

[PULL 07/13] Revert "ppc4xx: Move common dependency on serial to common option"

2021-01-18 Thread David Gibson
From: BALATON Zoltan This reverts commit e6d5106786 which was added mistakenly. While this change works it was suggested during review that keeping dependencies explicit for each board may be better than listing them in a common option so keep the previous version and revert this change.

[PULL 08/13] sam460ex: Use type cast macro instead of simple cast

2021-01-18 Thread David Gibson
From: BALATON Zoltan Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus(). Also remove the check for NULL afterwards which should not be needed because sysbus_create_simple() uses error_abort and we create the PCI host object here that's expected to have a PCI bus so this

[PULL 05/13] hw/ppc: Remove unused ppcuic_init()

2021-01-18 Thread David Gibson
From: Peter Maydell Now we've converted all the callsites to directly create the QOM UIC device themselves, the ppcuic_init() function is unused and can be removed. The enum defining PPCUIC symbolic constants can be moved to the ppc-uic.h header where it more naturally belongs. Signed-off-by:

[PULL 09/13] spapr: Improve handling of memory unplug with old guests

2021-01-18 Thread David Gibson
From: Greg Kurz Since commit 1e8b5b1aa16b ("spapr: Allow memory unplug to always succeed") trying to unplug memory from a guest that doesn't support it (eg. rhel6) no longer generates an error like it used to. Instead, it leaves the memory around : only a subsequent reboot or manual use of drmgr

[PULL 00/13] ppc-for-6.0 queue 20210119

2021-01-18 Thread David Gibson
The following changes since commit e43d564fa3a0d1e133935c8180ad4f4ccf699f33: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging (2021-01-18 15:19:06 +) are available in the Git repository at: https://gitlab.com/dgibson/qemu.git

[PULL 02/13] hw/ppc: Delete unused ppc405cr_init() code

2021-01-18 Thread David Gibson
From: Peter Maydell The function ppc405cr_init() has apparently been unused since it was added in commit 8ecc7913525ecb in 2007. Remove this dead code, so we don't have to convert it away from using ppcuic_init(). Signed-off-by: Peter Maydell Message-Id:

[PULL 06/13] Revert "sam460ex: Remove FDT_PPC dependency from KConfig"

2021-01-18 Thread David Gibson
From: BALATON Zoltan This reverts commit 038da2adf that was mistakenly added, this dependency is still needed to get libfdt dependencies even if fdt.o is not needed by sam460ex. Signed-off-by: BALATON Zoltan Message-Id:

[PULL 12/13] spapr_rtas.c: fix identation of rtas_ibm_suspend_me() args

2021-01-18 Thread David Gibson
From: Daniel Henrique Barboza Signed-off-by: Daniel Henrique Barboza Message-Id: <20210114180628.1675603-5-danielhb...@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_rtas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_rtas.c

[PULL 03/13] hw/intc/ppc-uic: Make default dcr-base 0xc0, not 0x30

2021-01-18 Thread David Gibson
From: Peter Maydell In commit 34d0831f38fd8 the ppc-uic device was added, with a dcr-base property. The intention was that the default value of dcr-base should be the one that most of our boards need, so that in the common case they don't need to specify a property value. All QEMU boards with a

[PULL 04/13] hw/ppc/ppc405_uc: Drop use of ppcuic_init()

2021-01-18 Thread David Gibson
From: Peter Maydell Switch the ppc405_uc boards to directly creating and configuring the UIC, rather than doing it via the old ppcuic_init() helper function. We retain the API feature of ppc405ep_init() where it passes back something allowing the callers to wire up devices to the UIC if they

[PULL 01/13] hw/ppc/sam460ex: Drop use of ppcuic_init()

2021-01-18 Thread David Gibson
From: Peter Maydell Switch the sam460ex board to directly creating and configuring the UIC, rather than doing it via the old ppcuic_init() helper function. Signed-off-by: Peter Maydell Message-Id: <20210108171212.16500-2-peter.mayd...@linaro.org> Signed-off-by: David Gibson ---

Re: [RFC PATCH V2 00/11] hw/block/nvme: support multi-path for ctrl/ns

2021-01-18 Thread Klaus Jensen
On Jan 19 12:21, Minwoo Im wrote: > On 21-01-18 22:14:45, Klaus Jensen wrote: > > On Jan 17 23:53, Minwoo Im wrote: > > > Hello, > > > > > > This patch series introduces NVMe subsystem device to support multi-path > > > I/O in NVMe device model. Two use-cases are supported along with this > > >

Re: [PATCH] tests/acceptance: Test PMON with Loongson-3A1000 CPU

2021-01-18 Thread Philippe Mathieu-Daudé
On 1/18/21 5:54 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> On 1/12/21 3:07 AM, Jiaxun Yang wrote: >>> Test booting of PMON bootloader on loongson3-virt platform. >>> >>> $ (venv) AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ >>> avocado --show=app,console \ >>> run -t

[RFC PATCH] tests/docker: Allow passing --network option when building images

2021-01-18 Thread Philippe Mathieu-Daudé
When using the Docker engine, build fails because the container is unable to resolve hostnames: $ make docker-image-debian-s390x-cross NETWORK=host ENGINE=docker BUILD debian10 #6 9.679 Err:1 http://deb.debian.org/debian buster InRelease #6 9.679 Temporary failure resolving

[PATCH] tests/docker: Fix typo in help message

2021-01-18 Thread Philippe Mathieu-Daudé
To have the variable properly passed, we need to set it, ie. NOUSER=1. Fix the message displayed by 'make docker'. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include

Re: Re: [PATCH v4 0/3] support NVMe smart critial warning injection

2021-01-18 Thread Klaus Jensen
On Jan 19 10:05, zhenwei pi wrote: > On 1/18/21 5:34 PM, Klaus Jensen wrote: > > On Jan 15 11:26, zhenwei pi wrote: > > > v3 -> v4: > > > - Drop "Fix overwritten bar.cap". (Already fixed) > > > > > > - Avoid to enqueue the duplicate event. > > > > > > - Several minor changes for coding style &

[PATCH] tests/docker: Fix _get_so_libs() for docker-binfmt-image

2021-01-18 Thread Philippe Mathieu-Daudé
Fix a variable rename mistake from commit 5e33f7fead5: Traceback (most recent call last): File "./tests/docker/docker.py", line 710, in sys.exit(main()) File "./tests/docker/docker.py", line 706, in main return args.cmdobj.run(args, argv) File

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-18 Thread Bharata B Rao
On Fri, Jan 15, 2021 at 06:30:05PM +0100, Greg Kurz wrote: > On Fri, 15 Jan 2021 14:01:28 +0530 > Bharata B Rao wrote: > > > On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > > > Hi Bharata, > > > > > > On Wed, 6 Jan 2021 14:29:10 +0530 > > > Bharata B Rao wrote: > > > > > > > If

[Bug 393569] Re: qemu cannot load multiple initramfs archives

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/393569 Title: qemu cannot

[Bug 1518969] Re: Instance of QEMU doesn't unplug virtio scsi disk after device_del and drive_del commands

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1518969 Title: Instance

[Bug 1377163] Re: Does not add usb-host devices as they are hotplugged

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1377163 Title: Does not

[Bug 1531352] Re: QEMU_LD_PREFIX not load correct library order in the PATH

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1531352 Title:

[Bug 1381846] Re: Data sent to parallel port in guest is lost if host buffer fills up

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1381846 Title: Data sent

[Bug 1391942] Re: Unnecessary events option of the trace argument with UST backend

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1391942 Title:

[Bug 1554451] Re: unable to create preallocated image with gluster network protocol

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1554451 Title: unable to

[Bug 1530278] Re: vhost-user: can not detach chardev which is used by vhost-user backend

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1530278 Title:

[Bug 1296882] Re: add next free device option to qemu-img

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1296882 Title: add next

[Bug 1529764] Re: No video output with the official Windows XP VMWare VGA driver

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529764 Title: No video

[Bug 1269628] Re: Feature Request: Please add TCG OPAL 2 emulation support to the virtio disk emulation

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1269628 Title: Feature

[Bug 1534683] Re: no mouse cursor / qxl / windows seven guest

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1534683 Title: no mouse

[Bug 1563152] Re: general protection fault running VirtualBox in KVM guest

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563152 Title: general

[Bug 1530035] Re: usb-host: ATI Technologies, Inc. TV Wonder acts as a different device if used

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1530035 Title: usb-host:

[Bug 1557057] Re: Windows 10 guest under qemu cannot wake up from S3 using rtc wake with -no_hpet

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1557057 Title: Windows 10

[Bug 1555452] Re: GDB server does not work in Windows

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1555452 Title: GDB server

[Bug 1563152] Re: general protection fault running VirtualBox in KVM guest

2021-01-18 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563152

[Bug 1549298] Re: Add missing MSRs for powertop

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1549298 Title: Add

[Bug 1563612] Re: pulseaudio applications crash under linux-user-x86_64

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563612 Title: pulseaudio

[Bug 1579645] Re: [XEN/KVM] pch audio doesn't work on both Windows and linux guest with soundhw="ac97"

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1579645 Title: [XEN/KVM]

[Bug 1576347] Re: Only one NVMe device is usable in Windows (10) guest

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1576347 Title: Only one

[Bug 1579306] Re: usb-uas does not work in Windows (10) guest

2021-01-18 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1579306 Title: usb-uas

Re: [PATCH] hw/misc: sifive_u_otp: Use error_report() when block operation fails

2021-01-18 Thread Philippe Mathieu-Daudé
On 1/19/21 4:23 AM, Bin Meng wrote: > From: Bin Meng > > At present when blk_pread() / blk_pwrite() fails, a guest error > is logged, but this is not really a guest error. Change to use > error_report() instead. > > Signed-off-by: Bin Meng > --- > > hw/misc/sifive_u_otp.c | 13 +

[PATCH] hw/misc: sifive_u_otp: Use error_report() when block operation fails

2021-01-18 Thread Bin Meng
From: Bin Meng At present when blk_pread() / blk_pwrite() fails, a guest error is logged, but this is not really a guest error. Change to use error_report() instead. Signed-off-by: Bin Meng --- hw/misc/sifive_u_otp.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

Re: [RFC PATCH V2 00/11] hw/block/nvme: support multi-path for ctrl/ns

2021-01-18 Thread Minwoo Im
On 21-01-18 22:14:45, Klaus Jensen wrote: > On Jan 17 23:53, Minwoo Im wrote: > > Hello, > > > > This patch series introduces NVMe subsystem device to support multi-path > > I/O in NVMe device model. Two use-cases are supported along with this > > patch: Multi-controller, Namespace Sharing. > >

Re: [PATCH] target/riscv: Declare csr_ops[] with a known size

2021-01-18 Thread Philippe Mathieu-Daudé
On 1/19/21 3:52 AM, Bin Meng wrote: > From: Bin Meng > > csr_ops[] is currently declared with an unknown size in cpu.h. > Since the array size is known, let's do a complete declaration. > > Signed-off-by: Bin Meng > --- > > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] target/riscv: Declare csr_ops[] with a known size

2021-01-18 Thread Bin Meng
From: Bin Meng csr_ops[] is currently declared with an unknown size in cpu.h. Since the array size is known, let's do a complete declaration. Signed-off-by: Bin Meng --- target/riscv/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu.h

Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external

2021-01-18 Thread Bin Meng
On Tue, Jan 19, 2021 at 1:55 AM Richard Henderson wrote: > > On 1/11/21 6:52 PM, Bin Meng wrote: > > +extern riscv_csr_operations csr_ops[]; > > You might as well use CSR_TABLE_SIZE here. > OK, I will send a patch for this. Thanks! > Otherwise, > Reviewed-by: Richard Henderson Regards, Bin

Re: [PATCH] npcm7xx_adc-test: Fix memleak in adc_qom_set

2021-01-18 Thread wuhaotsh--- via
On Sun, Jan 17, 2021 at 10:59 PM Gan Qixin wrote: > The adc_qom_set function didn't free "response", which caused an indirect > memory leak. So use qobject_unref() to fix it. > > ASAN shows memory leak stack: > > Indirect leak of 593280 byte(s) in 144 object(s) allocated from: > #0

Re: [RFC PATCH V2 10/11] hw/block/nvme: add NMIC enum value for Identify Namespace

2021-01-18 Thread Minwoo Im
> Let's keep convention (or should be convention...) of using NvmeIdNs > prefix for identify data structure fields on the enum. Okay!

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Minwoo Im
On 21-01-18 20:23:30, Klaus Jensen wrote: > On Jan 18 14:22, Klaus Jensen wrote: > > On Jan 18 22:12, Minwoo Im wrote: > > > On 21-01-18 14:10:50, Klaus Jensen wrote: > > > > On Jan 18 22:09, Minwoo Im wrote: > > > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to > > > > > >

Re: [PATCH v2 02/12] hw/block/nvme: fix 64 bit register hi/lo split writes

2021-01-18 Thread Minwoo Im
On 21-01-18 20:53:24, Klaus Jensen wrote: > On Jan 18 21:59, Minwoo Im wrote: > > > The spec requires aligned 32 bit accesses (or the size of the register), > > > so maybe it's about time we actually ignore instead of falling through. > > > > Agreed. > > > > On the other hand. > > The spec

Re: Re: [PATCH v4 0/3] support NVMe smart critial warning injection

2021-01-18 Thread zhenwei pi
On 1/18/21 5:34 PM, Klaus Jensen wrote: On Jan 15 11:26, zhenwei pi wrote: v3 -> v4: - Drop "Fix overwritten bar.cap". (Already fixed) - Avoid to enqueue the duplicate event. - Several minor changes for coding style & function/variable name. v2 -> v3: - Introduce "Persistent Memory Region

[PATCH v4 3/5] tests/acpi: add OEM ID and OEM TABLE ID test

2021-01-18 Thread Marian Postevca
Add support for testing the fields OEM ID and OEM TABLE ID in all ACPI tables for PC,Q35,MICROVM,AARCH64 Full diff of changed files disassembly: Table tests/data/acpi/virt/FACP diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel

[PATCH v4 5/5] tests/acpi: disallow updates for expected data files

2021-01-18 Thread Marian Postevca
Signed-off-by: Marian Postevca --- tests/qtest/bios-tables-test-allowed-diff.h | 94 - 1 file changed, 94 deletions(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index b20ae72949..dfb8523c8b 100644 ---

[PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-18 Thread Marian Postevca
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game

[PATCH v4 0/5] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-18 Thread Marian Postevca
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game

[PATCH v4 4/5] tests/acpi: update expected data files

2021-01-18 Thread Marian Postevca
Signed-off-by: Marian Postevca --- tests/data/acpi/microvm/APIC | Bin 70 -> 70 bytes tests/data/acpi/microvm/APIC.ioapic2 | Bin 82 -> 82 bytes tests/data/acpi/microvm/APIC.pcie| Bin 110 -> 110 bytes tests/data/acpi/microvm/DSDT | Bin 365 -> 365 bytes

[PATCH v4 1/5] tests/acpi: allow updates for expected data files

2021-01-18 Thread Marian Postevca
Signed-off-by: Marian Postevca --- tests/qtest/bios-tables-test-allowed-diff.h | 94 + 1 file changed, 94 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..b20ae72949 100644 ---

Re: [PATCH v3] hvf: guard xgetbv call.

2021-01-18 Thread Hill Ma
gentle bump :) On Tue, Jan 12, 2021 at 10:07 PM Hill Ma wrote: > > This prevents illegal instruction on cpus do not support xgetbv. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > Signed-off-by: Hill Ma > --- > v3: addressed feedback. > v2: xgetbv() modified based on feedback. > >

Re: [PATCH 7/7] block/rbd: change request alignment to 1 byte

2021-01-18 Thread Jason Dillaman
On Fri, Jan 15, 2021 at 10:39 AM Peter Lieven wrote: > > Am 15.01.21 um 16:27 schrieb Jason Dillaman: > > On Thu, Jan 14, 2021 at 2:59 PM Peter Lieven wrote: > >> Am 14.01.21 um 20:19 schrieb Jason Dillaman: > >>> On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote: > since we implement

Re: [RFC PATCH V2 00/11] hw/block/nvme: support multi-path for ctrl/ns

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > Hello, > > This patch series introduces NVMe subsystem device to support multi-path > I/O in NVMe device model. Two use-cases are supported along with this > patch: Multi-controller, Namespace Sharing. > > V1 RFC has been discussed with Klaus and Keith, I

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-01-18 Thread Richard Henderson
On 1/18/21 10:17 AM, Laurent Vivier wrote: > This commit breaks the build of my hello world test program with > mips64el/stretch guest > (and I guess some others too). > > cat > $CHROOT/tmp/hello.c < #include > int main(void) > { > printf("Hello World!\n"); > return 0; > } > EOF > >

Re: [PULL 11/24] tcg/optimize: Use tcg_constant_internal with constant folding

2021-01-18 Thread Laurent Vivier
On 16/01/2021 18:24, Richard Henderson wrote: > On 1/15/21 1:03 PM, Alistair Francis wrote: >> I run QEMU with these arguments: >> >> ./build/riscv32-softmmu/qemu-system-riscv32 \ >> -machine virt -serial mon:stdio -serial null -nographic \ >> -append "root=/dev/vda rw highres=off

Re: [RFC PATCH v2 10/20] hw/usb/hcd-ohci: Mark the device with no migratable fields

2021-01-18 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Add a more descriptive comment to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe

Re: [RFC PATCH V2 05/11] hw/block/nvme: remove unused argument in nvme_ns_setup

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > nvme_ns_setup() finally does not have nothing to do with NvmeCtrl > instance. > > Signed-off-by: Minwoo Im I also think this *could* be squashed into [04/11] without too much strain on the eye, but Reviewed-by: Klaus Jensen signature.asc Description: PGP

Re: [RFC PATCH V2 10/11] hw/block/nvme: add NMIC enum value for Identify Namespace

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) > field to support shared namespace from controller(s). > > This field is in Identify Namespace data structure in [30]. > > Signed-off-by: Minwoo Im > --- > include/block/nvme.h | 4

Re: [RFC PATCH V2 04/11] hw/block/nvme: split setup and register for namespace

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > In NVMe, namespace is being attached to process I/O. We register NVMe > namespace to a controller via nvme_register_namespace() during > nvme_ns_setup(). This is main reason of receiving NvmeCtrl object > instance to this function to map the namespace to a

Re: [PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

2021-01-18 Thread Stefan
Hi Laurent! Thanks for your response. > Why don't you simply replace STRUCT_sockaddr_ifreq by STRUCT_ifmap_ifreq > rather than introducing a > new constant? Because STRUCT_sockaddr_ifreq is the union part to be filled and is needed as an argument to thunk_convert() in this loop below:

Re: [RFC PATCH V2 03/11] hw/block/nvme: remove unused argument in nvme_ns_init_blk

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > Removed no longer used aregument NvmeCtrl object in nvme_ns_init_blk(). > > Signed-off-by: Minwoo Im I don't think it's too unwieldy for this to be squashed into [02/11], but Reviewed-by: Klaus Jensen signature.asc Description: PGP signature

Re: [RFC PATCH V2 02/11] hw/block/nvme: open code for volatile write cache

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > Volatile Write Cache(VWC) feature is set in nvme_ns_setup() in the > initial time. This feature is related to block device backed, but this > feature is controlled in controller level via Set/Get Features command. > > This patch removed dependency between

Re: [RFC PATCH V2 01/11] hw/block/nvme: remove unused argument in nvme_ns_init_zoned

2021-01-18 Thread Klaus Jensen
On Jan 17 23:53, Minwoo Im wrote: > nvme_ns_init_zoned() has no use for given NvmeCtrl object. > > Signed-off-by: Minwoo Im Reviewed-by: Klaus Jensen signature.asc Description: PGP signature

Re: [PATCH v2 02/12] hw/block/nvme: fix 64 bit register hi/lo split writes

2021-01-18 Thread Klaus Jensen
On Jan 18 21:59, Minwoo Im wrote: > > The spec requires aligned 32 bit accesses (or the size of the register), > > so maybe it's about time we actually ignore instead of falling through. > > Agreed. > On the other hand. The spec just allows undefined behavior if the alignment or size

Re: [PATCH v7 07/13] confidential guest support: Introduce cgs "ready" flag

2021-01-18 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > The platform specific details of mechanisms for implementing > confidential guest support may require setup at various points during > initialization. Thus, it's not really feasible to have a single cgs > initialization hook, but instead each

[PATCH v2 1/1] spapr.c: always pulse guest IRQ in spapr_core_unplug_request()

2021-01-18 Thread Daniel Henrique Barboza
Commit 47c8c915b162 fixed a problem where multiple spapr_drc_detach() requests were breaking QEMU. The solution was to just spapr_drc_detach() once, and use spapr_drc_unplug_requested() to filter whether we already detached it or not. The commit also tied the hotplug request to the guest in the

[PATCH v2 0/1] pseries: allow CPU unplug after failed attempt

2021-01-18 Thread Daniel Henrique Barboza
Hi, This is a different approach to the problem after reviews from David and Greg. See the commit msg for the reasoning behind it. changes from v1: - Patches 1,2,4 and 5: applied to ppc-for-6.0 - Patches 3, 6 and 7: removed - new patch: always pulse guest IRQ in spapr_core_unplug_request() v1

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
On Jan 18 14:22, Klaus Jensen wrote: > On Jan 18 22:12, Minwoo Im wrote: > > On 21-01-18 14:10:50, Klaus Jensen wrote: > > > On Jan 18 22:09, Minwoo Im wrote: > > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move > > > > > > onto > > > > > > the CMB v1.4 from v1.3

Re: [Bug 1912065] Re: Segfaults in tcg/optimize.c:212 after commit 7c79721606be11b5bc556449e5bcbc331ef6867d

2021-01-18 Thread Richard Henderson
On 1/18/21 8:00 AM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/161099084144.30067.897245088295398204.mal...@chaenomeles.canonical.com/ Can we get patchew to not respond to launchpad threads? r~

Re: Fwd: VirtioSound device emulation implementation

2021-01-18 Thread Shreyansh Chouhan
I will make it an in-QEMU pci device. After it is done and the device is working, I can write a vhost-user daemon and move the device out of QEMU should it be needed. This way I'd already have the virtio-pci device tested out by the time I get to the vhost-user daemon. Also I'll be a lot more

Re: [PATCH v7 02/13] confidential guest support: Introduce new confidential guest support class

2021-01-18 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > Several architectures have mechanisms which are designed to protect guest > memory from interference or eavesdropping by a compromised hypervisor. AMD > SEV does this with in-chip memory encryption and Intel's MKTME can do

Re: [PULL 05/30] Makefile: wrap ctags in quiet-command calls

2021-01-18 Thread Philippe Mathieu-Daudé
Hi Alex, On Fri, Jan 15, 2021 at 2:08 PM Alex Bennée wrote: > > For prettier output. > > Signed-off-by: Alex Bennée > Reviewed-by: Willian Rampazzo > Reviewed-by: Philippe Mathieu-Daudé > Message-Id: <20210114165730.31607-6-alex.ben...@linaro.org> > > diff --git a/Makefile b/Makefile > index

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-18 Thread Eduardo Habkost
On Thu, Jan 14, 2021 at 02:39:35PM +0100, Markus Armbruster wrote: > John Snow writes: > > > On 1/13/21 10:39 AM, Markus Armbruster wrote: > >> Spelling nitpick: s/builtin/built-in/ in the title. > >> > > > > Sure. > > > >> John Snow writes: > >> > >>> We use None to represent an object that

[PATCH] docker: Bump Fedora images to release 33

2021-01-18 Thread Philippe Mathieu-Daudé
Fedora 33 was released on October 27, 2020. Update all the Fedora 32 images to this new release. Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20210118181115.313742-1-phi...@redhat.com> hw/usb/hcd-xhci: Fix extraneous format-truncation error on 32-bit hosts

[PATCH] hw/usb/hcd-xhci: Fix extraneous format-truncation error on 32-bit hosts

2021-01-18 Thread Philippe Mathieu-Daudé
For some reason the assert() added in commit ccb799313a5 ("hw/usb: avoid format truncation warning when formatting port name") does not fix when building with GCC 10. KISS and expand the buffer by 4 bytes to silent the following error when using GCC 10.2.1 on Fedora 33: hw/usb/hcd-xhci.c: In

Re: [PATCH] target/mips: fetch code with translator_ld

2021-01-18 Thread Richard Henderson
On 1/16/21 8:13 AM, Philippe Mathieu-Daudé wrote: > +++ b/target/mips/tlb_helper.c > @@ -21,7 +21,7 @@ > #include "cpu.h" > #include "internal.h" > #include "exec/exec-all.h" > -#include "exec/cpu_ldst.h" > +#include "exec/translator.h" > #include "exec/log.h" > #include "hw/mips/cpudevs.h" >

Re: [Bug 1912065] Re: Segfaults in tcg/optimize.c:212 after commit 7c79721606be11b5bc556449e5bcbc331ef6867d

2021-01-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/161099084144.30067.897245088295398204.mal...@chaenomeles.canonical.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id:

Re: [PATCH v2 03/36] block: bdrv_append(): don't consume reference

2021-01-18 Thread Kevin Wolf
Am 18.01.2021 um 18:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > 18.01.2021 17:18, Kevin Wolf wrote: > > Am 27.11.2020 um 15:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > We have too much comments for this feature. It seems better just don't > > > do it. Most of real users (tests

  1   2   3   4   >