Currently, our check-system-* jobs are recompiling the whole sources
again. This happens due to the fact that the jobs are checking out
the whole source tree and required submodules again, and only try
to use the "build" directory with the binaries and object files
as an artifact from the previous
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893040
Title:
External modules retreval using Go1.15 on s390x appears to have
checksum and
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1886793
Title:
"go install" command fails while running inside s390x docker container
on x86_64
On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote:
> Use the cs_base field, because it happens to be the same
> size as hflags (and MSR, from which hflags is derived).
>
> In translate, extract most bits from a local hflags variable.
> Mark several cases where code generation is
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1745354
Title:
CDOS ps/2
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1752646
Title:
Freezing
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1774853
Title:
claims
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/186
Title:
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1777235
Title:
NVME is
Use the cs_base field, because it happens to be the same
size as hflags (and MSR, from which hflags is derived).
In translate, extract most bits from a local hflags variable.
Mark several cases where code generation is *not* derived from
data stored within the hashed elements of the
On 1/23/21 4:03 PM, Ivan Warren wrote:
> Hello people,
>
> I have the following issue : I'm using an OS (not linux) on a
> qemu-system-ppc64. (in my case a Power8 qemu target with a x86_64 TCG target)
>
> This OS provides a set of NARROW/WIDE (MSR[SF]) agnostic code snippets in the
> 1st 64K of
nvme-ns device is registered to a nvme controller device during the
initialization in nvme_register_namespace() in case that 'bus' property
is given which means it's mapped to a single controller.
This patch introduced a new property 'subsys' just like the controller
device instance did to map a
Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC)
field to support shared namespace from controller(s).
This field is in Identify Namespace data structure in [30].
Signed-off-by: Minwoo Im
---
include/block/nvme.h | 4
1 file changed, 4 insertions(+)
diff --git
Patchew URL: https://patchew.org/QEMU/20210124025306.3949-1-l...@nuviainc.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210124025306.3949-1-l...@nuviainc.com
Subject: [RFC PATCH 0/4] hw/intc: enable GICv4
We have nvme-subsys and nvme devices mapped together. To support
multi-controller scheme to this setup, controller identifier(id) has to
be managed. Earlier, cntlid(controller id) used to be always 0 because
we didn't have any subsystem scheme that controller id matters.
This patch introduced
Added Controller Multi-path I/O and Namespace Sharing Capabilities
(CMIC) field to support multi-controller in the following patches.
This field is in Identify Controller data structure in [76].
Signed-off-by: Minwoo Im
---
include/block/nvme.h | 4
1 file changed, 4 insertions(+)
diff
To support multi-path in QEMU NVMe device model, We need to have NVMe
subsystem hierarchy to map controllers and namespaces to a NVMe
subsystem.
This patch introduced a simple nvme-subsys device model. The subsystem
will be prepared with subsystem NQN with provided in
nvme-subsys device:
ex)
Hello,
This is sixth patch series for the support of NVMe subsystem scheme with
multi-controller and namespace sharing in a subsystem.
This version has a fix in nvme_init_ctrl() when 'cntlid' is set to the
Identify Controller data structure by making it by cpu_to_le16() as
Keith reviewed.
The VLPI frames are what make the redistributor size change, so ensure
we state in GICD_TYPER that we have them.
Signed-off-by: Leif Lindholm
---
hw/intc/arm_gicv3_dist.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
index
GICv3 sets aside 128K for each redistributor block, whereas GICv4 sets
aside 256K. To enable use of the gicv3 model for gicv4, abstract this
away as the helper function gicv3_redist_size() and replace the current
hardcoded locations with calls to this function.
Signed-off-by: Leif Lindholm
---
nvme controller(nvme) can be mapped to a NVMe subsystem(nvme-subsys).
This patch maps a controller to a subsystem by adding a parameter
'subsys' to the nvme device.
To map a controller to a subsystem, we need to put nvme-subsys first and
then maps the subsystem to the controller:
-device
Make gicv3_idreg() able to return either gicv3 or gicv4 data.
Add a parameter to specify gic version.
Signed-off-by: Leif Lindholm
---
hw/intc/arm_gicv3_dist.c | 2 +-
hw/intc/arm_gicv3_redist.c | 2 +-
hw/intc/gicv3_internal.h | 12 ++--
3 files changed, 12 insertions(+), 4
GICv4 sets aside 256K per redistributor configuration block, whereas GICv3
only uses 128K. However, some codebases (like TF-A, EDK2) will happily use
the GICv3 functionality only.
This set aims at enabling these codebases to run, without actually enabling
full support for GICv4.
This creates a
As a first step towards GICv4 compatibility, add support for gic revision 4
to GICv3 driver (i.e. don't bail out if revision 4 is encountered).
Signed-off-by: Leif Lindholm
---
hw/intc/arm_gicv3_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
A full solution to the problem:
https://patchew.org/QEMU/20210123230105.2076270-1-richard.hender...@linaro.org/
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1912065
Title:
Segfaults in
Hello people,
I have the following issue : I'm using an OS (not linux) on a
qemu-system-ppc64. (in my case a Power8 qemu target with a x86_64 TCG
target)
This OS provides a set of NARROW/WIDE (MSR[SF]) agnostic code snippets
in the 1st 64K of addresses (so they can be called using the PPC
On 1/23/21 7:10 PM, Paolo Bonzini wrote:
> On 22/01/21 21:44, Philippe Mathieu-Daudé wrote:
>> Beside a CPU device, user-mode emulation doesn't access
>> anything else from qdev subsystem.
>>
>> Tools don't need anything from qdev.
>
> I prefer to avoid stubs. So if this patch can simply be
On 1/24/21 12:01 AM, Richard Henderson wrote:
> Some large translation blocks can generate so many unique
> constants that we run out of temps to hold them. In this
> case, longjmp back to the start of code generation and
> restart with a smaller translation block.
Clever and way nicer.
On 12/20/20 12:26 PM, Laurent Vivier wrote:
> The machine is based on Goldfish interfaces defined by Google
> for Android simulator. It uses Goldfish-rtc (timer and RTC),
> Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty).
>
> The machine is created with 128 virtio-mmio bus,
On 12/20/20 12:26 PM, Laurent Vivier wrote:
> After a migration the clock offset is updated, but we also
> need to re-arm the alarm if needed.
>
> Signed-off-by: Laurent Vivier
> Reviewed-by: Alistair Francis
> ---
> hw/rtc/goldfish_rtc.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by:
On 12/20/20 12:26 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> include/hw/char/goldfish_tty.h | 36 +
> hw/char/goldfish_tty.c | 266 +
> hw/char/Kconfig| 3 +
> hw/char/meson.build| 2 +
>
On 12/20/20 12:26 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> include/hw/intc/goldfish_pic.h | 33 +
> hw/intc/goldfish_pic.c | 214 +
> hw/intc/Kconfig| 3 +
> hw/intc/meson.build| 1 +
>
Some large translation blocks can generate so many unique
constants that we run out of temps to hold them. In this
case, longjmp back to the start of code generation and
restart with a smaller translation block.
Buglink: https://bugs.launchpad.net/bugs/1912065
Signed-off-by: Richard Henderson
Richard, thanks for providing the workaround. It helps.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1912065
Title:
Segfaults in tcg/optimize.c:212 after commit
On Sat, 23 Jan 2021 at 20:30, Luc Michel wrote:
>
> On 19:06 Thu 21 Jan , Peter Maydell wrote:
> > Use the MAINCLK Clock input to set the system_clock_scale variable
> > rather than using the mainclk_frq property.
> >
> > Signed-off-by: Peter Maydell
> > ---
> > At some point we should make
On 1/23/21 9:36 AM, Laurent Vivier wrote:
>>> -#define TCG_MAX_TEMPS 512
>>> +#define TCG_MAX_TEMPS 1024
>>
>> This seems not enough, I have:
>>
>> ERROR:.../tcg/tcg.c:1210:tcg_temp_alloc: assertion failed: (n <
>> TCG_MAX_TEMPS)
>> Bail out! ERROR:.../tcg/tcg.c:1210:tcg_temp_alloc: assertion
On 22/01/21 22:26, Laszlo Ersek wrote:
That seems bogus, per POSIX, given that all signals except SIGUSR2 are
included in the mask passed to sigsuspend().
What happens if you get a SIGSTOP at exactly the wrong time? (Yeah I
know how incredibly unlikely that would be).
BTW if we are in a
available in the Git repository at:
>
> https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20210123
>
> for you to fetch changes up to 2e34067e9959f149a904cf1255985d3b68b52566:
>
> tcg: Toggle page execution for A
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Drop common.env: now check is in python, and for tests we use same
python interpreter that runs the check itself. Use build environment
PYTHON in
Add TestRunner class, which will run tests in a new python iotests
running framework.
There are some differences with current ./check behavior, most
significant are:
- Consider all tests self-executable, just run them, don't run python
by hand.
- Elapsed time is cached in json file
- Elapsed
Rename bitmaps migration tests and move them to tests subdirectory to
demonstrate new human-friendly test naming.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0
.../{199.out => tests/migrate-bitmaps-postcopy-test.out}
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/testenv.py | 278 ++
1 file
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
to any group, like 142)
Behavior of findtests.py:
- group file is dropped
- tests are all files in
v8:
about linters:
I didn't modify 297, as Max already staged 297 modifications to test all files.
Also, now I have two complains:
+* Module testenv
+testenv.py:158:4: R0915: Too many statements (53/50) (too-many-statements)
+* Module testrunner
+testrunner.py:222:4:
The following changes since commit fef80ea073c4862bc9eaddb6ddb0ed970b8ad7c4:
Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-01-20' into
staging (2021-01-21 10:44:28 +)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you
On 19:06 Thu 21 Jan , Peter Maydell wrote:
> Now no users are setting the frq properties on the CMSDK timer,
> dualtimer, watchdog or ARMSSE SoC devices, we can remove the
> properties and the struct fields that back them.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Luc Michel
> ---
>
On 19:06 Thu 21 Jan , Peter Maydell wrote:
> Now that the watchdog device uses its Clock input rather than being
> passed the value of system_clock_scale at creation time, we can
> remove the hack where we reset the STELLARIS_SYS at board creation
> time to force it to set system_clock_scale.
On 19:06 Thu 21 Jan , Peter Maydell wrote:
> Remove all the code that sets frequency properties on the CMSDK
> timer, dualtimer and watchdog devices and on the ARMSSE SoC device:
> these properties are unused now that the devices rely on their Clock
> inputs instead.
>
> Signed-off-by: Peter
On 19:06 Thu 21 Jan , Peter Maydell wrote:
> Use the MAINCLK Clock input to set the system_clock_scale variable
> rather than using the mainclk_frq property.
>
> Signed-off-by: Peter Maydell
> ---
> At some point we should make the SysTick take a Clock itself so
> that we can get rid of the
Sorry to rephrase this, we would like a single binary to work on both
macOS 10.15 and macOS 11 as well as on both iOS 13 and iOS 14 while
ALSO supporting preadv/pwritev when running on the newer OS.
-j
On Sat, Jan 23, 2021 at 12:00 PM Joelle van Dyne wrote:
>
> The problem here is that we would
The problem here is that we would like to compile on macOS 11 and be
able to run the built binaries on macOS 10.15 or lower. Without the
runtime checks, you'll have a crash when calling preadv/pwritev.
-j
On Sat, Jan 23, 2021 at 5:53 AM Peter Maydell wrote:
>
> On Sat, 23 Jan 2021 at 05:03,
On 21:41 Fri 22 Jan , Peter Maydell wrote:
> On Fri, 22 Jan 2021 at 20:48, Luc Michel wrote:
> >
> > On 19:06 Thu 21 Jan , Peter Maydell wrote:
> > > Switch the CMSDK APB dualtimer device over to using its Clock input;
> > > the pclk-frq property is now ignored.
> > >
> > > Signed-off-by:
On Sat, 23 Jan 2021 at 14:36, Paolo Bonzini wrote:
>
> The following changes since commit fef80ea073c4862bc9eaddb6ddb0ed970b8ad7c4:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-01-20' into
> staging (2021-01-21 10:44:28 +)
>
> are available in the Git repository at:
>
Le 23/01/2021 à 17:19, Laurent Vivier a écrit :
> Le 21/01/2021 à 03:54, Richard Henderson a écrit :
>> This isn't a total or permanent solution to the problem of running
>> out of temporaries, but it puts off the issue for a bit.
>>
>> Make the assert in tcg_temp_alloc unconditional. If we do
On Fri, 22 Jan 2021 at 17:53, Gerd Hoffmann wrote:
>
> The following changes since commit 0e32462630687a18039464511bd0447ada5709c3:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
> request' into staging (2021-01-22 10:35:55 +)
>
> are available in the Git
From: Philippe Mathieu-Daudé
As cpu_io_recompile() is only called within TCG accelerator
in cputlb.c, declare it locally.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210117164813.4101761-6-f4...@amsat.org>
[rth: Adjust vs changed tb_flush_jmp_cache patch.]
Signed-off-by: Richard
From: Philippe Mathieu-Daudé
tb_gen_code() is only called within TCG accelerator, declare it locally.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210117164813.4101761-4-f4...@amsat.org>
[rth: Adjust vs changed tb_flush_jmp_cache patch.]
Signed-off-by: Richard Henderson
---
From: Roman Bolshakov
Pages can't be both write and executable at the same time on Apple
Silicon. macOS provides public API to switch write protection [1] for
JIT applications, like TCG.
1.
https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon
From: Philippe Mathieu-Daudé
cpu_gen_init() is TCG specific, only used in tcg/translate-all.c.
No need to export it to other accelerators, declare it statically.
Reviewed-by: Claudio Fontana
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210117164813.4101761-2-f4...@amsat.org>
Provide a symbol that can always be used to signal an error,
regardless of optimization. Usage of this should be protected
by e.g. __builtin_constant_p, which guards for optimization.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/qemu/compiler.h | 5 +++--
1
From: Philippe Mathieu-Daudé
cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c,
and are not available when TCG accelerator is not built. Add stubs so
linking without TCG succeed.
Problematic files:
- hw/semihosting/console.c in qemu_semihosting_console_inc()
-
Move and make the function static, as the only users
are here in cputlb.c.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 3 ---
accel/tcg/cputlb.c| 18 ++
accel/tcg/translate-all.c | 17 -
3 files
This isn't a total or permanent solution to the problem of running
out of temporaries, but it puts off the issue for a bit.
Make the assert in tcg_temp_alloc unconditional. If we do run out
of temps, this can fail much later as a weird SIGSEGV, due to the
buffer overrun of the temp array.
From: Douglas Crosher
The cpu_exec_step_atomic() function is called with the cpu->running
clear and proceeds to run target code without setting this flag. If
this target code generates an exception then handle_cpu_signal() will
unnecessarily abort. For example if atomic code generates a memory
-tcg-20210123
for you to fetch changes up to 2e34067e9959f149a904cf1255985d3b68b52566:
tcg: Toggle page execution for Apple Silicon (2021-01-22 12:48:01 -1000)
Fix tcg constant segv.
Optimize inline dup_const for MO_64.
Update
Avoid the out-of-line function call for immediate MO_64.
In addition, diagnose all invalid constants at compile-time.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/tcg/tcg.h
On Sat, Jan 23, 2021 at 07:33:37PM +0100, BALATON Zoltan wrote:
> On Sat, 23 Jan 2021, Roman Bolshakov wrote:
> > On Sat, Jan 23, 2021 at 02:53:49PM +0300, Roman Bolshakov wrote:
> > > On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote:
> > > > From: Roman Bolshakov
> > > >
> > >
On Sat, 23 Jan 2021, Roman Bolshakov wrote:
On Sat, Jan 23, 2021 at 02:53:49PM +0300, Roman Bolshakov wrote:
On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote:
From: Roman Bolshakov
Pages can't be both write and executable at the same time on Apple
Silicon. macOS provides
On 19/01/21 13:39, Pavel Dovgalyuk wrote:
Sometimes interrupt event comes at the same time with
the virtual timers. In this case replay tries to proceed
the timers, because deadline for them is zero.
This patch allows processing interrupts and exceptions
by entering the vCPU execution loop, when
On 22/01/21 14:30, Philippe Mathieu-Daudé wrote:
Since v2:
- Included Thomas suggestions
Some new users get confused between 'TCG' and 'TCI' and enable
TCI when TCG is better for they needs. Try to clarify it is
better to not use TCI when native backend is available.
Note, before Meson,
On 22/01/21 21:44, Philippe Mathieu-Daudé wrote:
In this series we deselect a bunch of features when they
not required, so less objects are built.
While this reduce pressure on CI and slow systems, this is
particularly helpful for developers regularly testing multiple
build configurations.
All
On 22/01/21 14:30, Philippe Mathieu-Daudé wrote:
Users might want to enable all features, without realizing some
features have negative effect. Rename '--enable-tcg-interpreter'
as '--disable-native-tcg' to avoid user selecting this feature
without understanding it. '--enable-tcg-interpreter' is
On 22/01/21 21:44, Philippe Mathieu-Daudé wrote:
Beside a CPU device, user-mode emulation doesn't access
anything else from qdev subsystem.
Tools don't need anything from qdev.
I prefer to avoid stubs. So if this patch can simply be dropped with no
effects on 10-12, that's nicer for me.
On 23/01/21 03:05, Brian Norris wrote:
It turns out that Paolo inadvertently (?) fixed this issue by
refactoring, in v5.2.0:
ea1edcd7da1a vl: relocate paths to data directories
On Sat, Jan 23, 2021 at 02:53:49PM +0300, Roman Bolshakov wrote:
> On Thu, Jan 21, 2021 at 08:47:52AM -1000, Richard Henderson wrote:
> > From: Roman Bolshakov
> >
> > Pages can't be both write and executable at the same time on Apple
> > Silicon. macOS provides public API to switch write
On 23/01/21 04:30, 罗勇刚(Yonggang Luo) wrote:
> We could and I did it in the first version. However it's ugly that
the user has to use --python on some setups in order to get a full help
message.
Yeap, but finally configure should gone, so I think --python are
acceptable by user, just need
On 210123 1247, Alexander Bulekov wrote:
> Hello,
> Here is a reproducer for this bug found by the OSS-Fuzz fuzzer:
>
> cat << EOF | qemu-system-i386 -display none -machine accel=qtest \
> -m 512M -machine pc -device floppy,unit=1,id=floppy0,drive=disk0 \
> -drive
Hello,
Here is a reproducer for this bug found by the OSS-Fuzz fuzzer:
cat << EOF | qemu-system-i386 -display none -machine accel=qtest \
-m 512M -machine pc -device floppy,unit=1,id=floppy0,drive=disk0 \
-drive id=disk0,file=null-co://,file.read-zeroes=on,if=none,format=raw \
-qtest stdio
outw
Le 21/01/2021 à 03:54, Richard Henderson a écrit :
> This isn't a total or permanent solution to the problem of running
> out of temporaries, but it puts off the issue for a bit.
>
> Make the assert in tcg_temp_alloc unconditional. If we do run out
> of temps, this can fail much later as a weird
22.01.2021 19:16, Kevin Wolf wrote:
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
Hi all!
These series has 3 goals:
- get rid of group file (to forget about rebase and in-list conflicts)
- introduce human-readable names for tests
- rewrite check into python
v7:
22.01.2021 19:08, Kevin Wolf wrote:
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben:
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Drop common.env: now check is in
Is there someone to merge this?
Thanks,
Laurent
Le 20/12/2020 à 12:26, Laurent Vivier a écrit :
> After a migration the clock offset is updated, but we also
> need to re-arm the alarm if needed.
>
> Signed-off-by: Laurent Vivier
> Reviewed-by: Alistair Francis
> ---
> hw/rtc/goldfish_rtc.c |
Anyone to merge this?
Thanks,
Laurent
Le 20/12/2020 à 17:35, Laurent Vivier a écrit :
> In the kernel, virtio_gpu_init() uses virtio_get_shm_region()
> since
> commit 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host
> visible region")
> but vm_get_shm_region() unconditionally
Patchew URL:
https://patchew.org/QEMU/20210123143128.1167797-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210123143128.1167797-1-pbonz...@redhat.com
Subject: [PULL 00/31] Misc patches for
Looking at all merge-lists QemuOptsList, here is how they access their
QemuOpts:
reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o")
qemu_opts_find(_opts, NULL)
empty_opts in qemu-io.c ("qemu-io open -o")
qemu_opts_find(_opts, NULL)
qemu_rtc_opts ("-rtc")
Right now, help options are parsed normally and then checked
specially in opt_validate, but only if coming from
qemu_opts_parse_noisily. has_help_option does the check on its own.
opt_validate() has two callers: qemu_opt_set(), which passes null and is
therefore unaffected, and opts_do_parse(),
The HMP command \"change vnc TARGET\" is messy:
- it takes an ugly shortcut to determine if the option has an "id",
with incorrect results if "id=" is not preceded by an unescaped
comma.
- it deletes the existing QemuOpts and does not try to rollback
if the parsing fails (which is not causing
22.01.2021 19:54, Eric Blake wrote:
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210121095616.1471869-9-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index abd2c05a82..bd6ad06d58
Options such as "server" or "nowait", that are commonly found in -chardev,
are sugar for "server=on" and "wait=off". This is quite surprising and
also does not have any notion of typing attached. It is even possible to
do "-device e1000,noid" and get a device with "id=off".
Deprecate it and
Signed-off-by: Paolo Bonzini
---
tests/acceptance/vnc.py | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc.py
index 3f40bc2be1..22656bbcc2 100644
--- a/tests/acceptance/vnc.py
+++ b/tests/acceptance/vnc.py
@@
From: Philippe Mathieu-Daudé
Display block layer information altogether,
when it is relevant.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210121095616.1471869-7-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build | 43 +--
1 file
Signed-off-by: Paolo Bonzini
Reviewed-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210120144235.345983-3-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
docs/system/deprecated.rst | 5
docs/system/removed-features.rst | 5
monitor/qmp-cmds.c
From: Philippe Mathieu-Daudé
Display accelerators and selected targets altogether,
avoid to display unuseful information when not relevant.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210121095616.1471869-6-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build | 38
Use qemu_opts_parse_noisily now that HMP does not call
vnc_parse anymore.
Signed-off-by: Paolo Bonzini
Reviewed-by: Eric Blake
Reviewed-by: Gerd Hoffmann
Message-Id: <20210120144235.345983-4-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
include/ui/console.h | 2 +-
softmmu/vl.c
From: Philippe Mathieu-Daudé
The --enable-bzip2/--disable-bzip2 configure arguments are
somehow misleading, they check for the bzip2 library, not
the bzip2 program.
We need the bzip2 program to install the EDK2 firmware blobs
(see commit 623ef637a2e "configure: Check bzip2 is available").
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210121095616.1471869-2-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index
From: Philippe Mathieu-Daudé
Globally declare in the main meson.build:
- the list of EDK2 targets,
- whether the EDK2 blobs have to be installed.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210114174509.2944817-2-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210121095616.1471869-8-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
meson.build | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/meson.build
From: Marc-André Lureau
git cherry-diff:
Commits on bacb71f1c3ed5f40e393afd8be81bedfba13a401 branch that is not on
8f43a99191afb47ca3f3c6972f6306209f367ece branch
+ 1021b0dc38d39f1dc95a296fe3e05a24a087cdc6 disable_dns option
+ 0f94ceec752592e4ac632a24e3c64a97dd09bf4c limit vnameserver_addr to
1 - 100 of 179 matches
Mail list logo