From: Akihiko Odaki
Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com>
Signed-off-by: Akihiko Odaki
Message-Id: <20210312133212.3131-1-akihiko.od...@gmail.com>
Signed-off-by: Gerd Hoffmann
---
ui/cocoa.m | 38 +-
1 file changed, 37 insertions(+), 1
From: Marc-André Lureau
A minor code simplification.
Signed-off-by: Marc-André Lureau
Message-Id: <20210312100108.2706195-2-marcandre.lur...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
ui/console.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git
From: Daniel P. Berrangé
The WMVi message is supposed to provide the same width/height
information as the regular desktop resize and extended desktop
resize messages. There can be times where the client width and
height are different from the pixman surface dimensions.
Signed-off-by: Daniel P.
From: Daniel P. Berrangé
This adds trace points for desktop size and audio related messages.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Marc-André Lureau
Message-Id: <20210311182957.486939-2-berra...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c| 21 +++--
From: Akihiko Odaki
ui/cocoa used to call exit immediately after calling
qemu_system_shutdown_request, which prevents QEMU from actually
perfoming system shutdown. Just sleep forever, and wait QEMU to call
exit and kill the Cocoa thread.
Signed-off-by: Akihiko Odaki
Message-Id:
The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
request' into staging (2021-03-14 17:47:49 +)
are available in the Git repository at:
git://git.kraxel.org/qemu
From: Daniel P. Berrangé
Currently when using VNC the "password" flag turns on password based
authentication. The actual password has to be provided separately via
the monitor.
This introduces a "password-secret" option which lets the password be
provided up front.
$QEMU --object
From: Daniel P. Berrangé
A long time ago the VNC server code had some memory corruption
fixes done in:
commit bea60dd7679364493a0d7f5b54316c767cf894ef
Author: Peter Lieven
Date: Mon Jun 30 10:57:51 2014 +0200
ui/vnc: fix potential memory corruption issues
One of the implications
From: Daniel P. Berrangé
With the new "password-secret" option, there is no reason to use the old
inecure "password" option with -spice, so it can be deprecated.
Signed-off-by: Daniel P. Berrangé
Message-Id: <2021034343.439820-4-berra...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
From: Akihiko Odaki
OpenGL ES does not support conversion from the given data format
to the internal format with glTexImage2D.
Use the given data format as the internal format, and ignore
the given alpha channels with GL_TEXTURE_SWIZZLE_A in case the
format contains alpha channels.
From: Daniel P. Berrangé
Currently when using SPICE the "password" option provides the password
in plain text on the command line. This is insecure as it is visible
to all processes on the host. As an alternative, the password can be
provided separately via the monitor.
This introduces a
From: Daniel P. Berrangé
We plan framebuffer update rects based on the VNC server surface. If the
client doesn't support desktop resize, then the client bounds may differ
from the server surface bounds. VNC clients may become upset if we then
send an update message outside the bounds of the
I noticed the following in tlbi_aa64_vae2is_write: it appears that when
calling tlbbits_for_regime the ARMMMUIdx values are swapped?
static void tlbi_aa64_vae2is_write(CPUARMState *env, const ARMCPRegInfo *ri,
uint64_t value)
{
CPUState *cs = env_cpu(env);
On 15/03/2021 19.24, Eric Blake wrote:
On 3/15/21 8:54 AM, Thomas Huth wrote:
We are generating a lot of target-specific defines in the *-config-devices.h
and *-config-target.h files. Using them in common code is wrong and leads
to very subtle bugs since a "#ifdef CONFIG_SOMETHING" is not
On 15/03/2021 22.05, Philippe Mathieu-Daudé wrote:
Hi Thomas,
+Alex
On 3/15/21 8:07 PM, Thomas Huth wrote:
The CONFIG_VFIO switch only works in target specific code. Since
migration/migration.c is common code, the #ifdef does not have
the intended behavior here. Move the related code to a
On 15.03.2021 23:13, Dr. David Alan Gilbert wrote:
* Pavel Dovgalyuk (pavel.dovgal...@ispras.ru) wrote:
QEMU timer of channel 0 in i8254 is used to raise irq
at the specified moment of time. This irq can be disabled
with irq_disabled flag. But when vmstate of the pit is
loaded, timer may be
On 2021/3/16 5:25, Alistair Francis wrote:
On Fri, Feb 12, 2021 at 10:16 AM LIU Zhiwei wrote:
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 9 ++
target/riscv/insn32.decode | 17
target/riscv/insn_trans/trans_rvp.c.inc | 115
在 2021/3/15 下午3:57, Bin Meng 写道:
The minimum Ethernet frame length is 60 bytes. For short frames with
smaller length like ARP packets (only 42 bytes), on a real world NIC
it can choose either padding its length to the minimum required 60
bytes, or sending it out directly to the wire. Such
On Mon, Mar 15, 2021 at 11:27:29PM +0100,
Reinoud Zandijk wrote:
> On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote:
> > Windows 10 1607x64 boots fine when I test it with default machine.
> >
> > So
> > 1) can you provide full QEMU command line used
> > 2) What Windows build do
On Thu, Mar 11, 2021 at 4:18 PM Bin Meng wrote:
>
> On Sat, Mar 6, 2021 at 2:01 PM Bin Meng wrote:
> >
> > From: Bin Meng
> >
> > Per SST25VF016B datasheet [1], SST flash requires a dummy byte after
> > the address bytes. Note only SPI mode is supported by SST flashes.
> >
> > [1]
From: David Edmondson
Rather than having a device specific debug implementation in
pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility.
Signed-off-by: David Edmondson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210216142721.1985543-2-david.edmond...@oracle.com>
[PMD:
Use the 'mode_read_array' event when we set the device in such
mode, and use the 'reset' event in DeviceReset handler.
Reviewed-by: Bin Meng
Reviewed-by: David Edmondson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210310170528.1184868-10-phi...@redhat.com>
---
hw/block/pflash_cfi01.c
There is multiple places resetting the internal state machine.
Factor the code out in a new pflash_reset_state_machine() method.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Edmondson
Reviewed-by: Bin Meng
Message-Id: <20210310170528.1184868-8-phi...@redhat.com>
---
From: David Edmondson
PFlashCFI01.ro is a bool, declare it as such.
Signed-off-by: David Edmondson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210216142721.1985543-3-david.edmond...@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Bin Meng
---
hw/block/pflash_cfi01.c |
The same pattern is used when setting the flash in READ_ARRAY mode:
- Set the state machine command to READ_ARRAY
- Reset the write_cycle counter
- Reset the memory region in ROMD
Refactor the current code by extracting this pattern.
It is used three times:
- When the timer expires and not in
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Edmondson
Reviewed-by: Bin Meng
Message-Id: <20210310170528.1184868-9-phi...@redhat.com>
---
hw/block/pflash_cfi02.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index
On Sun, Mar 14, 2021 at 03:26:58PM -0600, Richard Henderson wrote:
> Instead of delaying tcg_region_init until after tcg_prologue_init
> is complete, do tcg_region_init first and let tcg_prologue_init
> shrink the first region by the size of the generated prologue.
>
> Signed-off-by: Richard
There is only one call to pflash_setup_mappings(). Convert 'rom_mode'
to boolean and set it to true directly within pflash_setup_mappings().
Reviewed-by: Bin Meng
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Edmondson
Message-Id: <20210310170528.1184868-5-phi...@redhat.com>
---
There is only one call to pflash_register_memory() with
rom_mode == false. As we want to modify pflash_register_memory()
in the next patch, open-code this trivial function in place for
the 'rom_mode == false' case.
Reviewed-by: Bin Meng
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David
Fill the CFI table in out of DeviceRealize() in a new function:
pflash_cfi02_fill_cfi_table().
Reviewed-by: Bin Meng
Reviewed-by: David Edmondson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210310170528.1184868-4-phi...@redhat.com>
---
hw/block/pflash_cfi02.c | 193
We are going to move this code, fix its style first.
Reviewed-by: Bin Meng
Reviewed-by: David Edmondson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210310170528.1184868-2-phi...@redhat.com>
---
hw/block/pflash_cfi01.c | 36
hw/block/pflash_cfi02.c
Fill the CFI table in out of DeviceRealize() in a new function:
pflash_cfi01_fill_cfi_table().
Reviewed-by: Bin Meng
Reviewed-by: David Edmondson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210310170528.1184868-3-phi...@redhat.com>
---
hw/block/pflash_cfi01.c | 140
The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
Merge remote-tracking branch
'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15
19:23:00 +)
are available in the Git repository at:
https://github.com/philmd/qemu.git
On 3/10/21 6:05 PM, Philippe Mathieu-Daudé wrote:
> I remembered this almost 2 years old series while reviewing
> David Edmondson's patches... (which are included at the end).
>
> Basically we move things around to make the code easier to maintain.
>
> David Edmondson (2):
>
On Sun, Mar 14, 2021 at 03:26:56PM -0600, Richard Henderson wrote:
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
Reviewed-by: Roman Bolshakov
Thanks,
Roman
> meson.build | 9 ++---
> tcg/meson.build | 13 +
> 2 files changed, 15
Make pick_default_qemu_bin() generic to find qemu-system or
qemu-user binaries.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
Add a very quick test that runs a busybox binary in bFLT format:
$ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py
JOB ID : db94d5960ce564c50904d666a7e259148c27e88f
JOB LOG: ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job.log
(1/1)
Move the useful has_cmd()/has_cmds() helpers from the virtiofs
test to the avocado_qemu public class.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 57 ++
tests/acceptance/virtiofs_submounts.py| 59 +--
2 files
Since v2:
- rebased tests/acceptance/avocado_qemu/__init__.py patches
- extract has_cmd() from virtiofs_submounts.py
- check cpio availability with has_cmd()
Philippe Mathieu-Daudé (5):
tests/acceptance: Extract QemuBaseTest from Test
tests/acceptance: Make pick_default_qemu_bin() more
On Sun, Mar 14, 2021 at 03:26:57PM -0600, Richard Henderson wrote:
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
> ---
Reviewed-by: Roman Bolshakov
Thanks,
Roman
> meson.build | 4 +---
> fpu/meson.build | 1 +
> 2 files changed, 2 insertions(+), 3
Similarly to the 'System' Test base class with methods for testing
system emulation, the QemuUserTest class contains methods useful to
test user-mode emulation.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 14 ++
1 file changed, 14
The Avocado Test::fetch_asset() is handy to download artifacts
before running tests. The current class is named Test but only
tests system emulation. As we want to test user emulation,
refactor the common code as QemuBaseTest.
Signed-off-by: Philippe Mathieu-Daudé
---
On Sun, Mar 14, 2021 at 03:26:55PM -0600, Richard Henderson wrote:
> Changes for v2:
> * Move tcg_init_ctx someplace more private (patch 29)
> * Round result of tb_size based on qemu_get_host_physmem (patch 26)
>
> Blurb for v1:
> It took a few more patches than imagined to unify the two
>
On 3/15/21 10:33 PM, Peter Maydell wrote:
> On Sat, 13 Mar 2021 at 19:58, Philippe Mathieu-Daudé wrote:
>>
>> Extract 1600+ lines from the big translate.c into a new file.
>>
>> Reviewed-by: Richard Henderson
>> Signed-off-by: Philippe Mathieu-Daudé
>
> This code motion caused Coverity to
Coverity reported (CID 1450831) an array overrun in
gen_mxu_D16MAX_D16MIN():
1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
1112 if (opc == OPC_MXU_D16MAX) {
1113 tcg_gen_smax_i32(mxu_gpr[XRa - 1], t0, t1);
1114 } else {
1115
On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote:
> Windows 10 1607x64 boots fine when I test it with default machine.
>
> So
> 1) can you provide full QEMU command line used
> 2) What Windows build do you use
> 3) is it existing guest image (i.e. installed in older QEMU
On Mar 10 10:53, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This is v5 of a series that adds support for metadata and end-to-end
> data protection.
>
> First, on the subject of metadata, in v1, support was restricted to
> extended logical blocks, which was pretty trivial to implement, but
>
> -Original Message-
> From: Richard Henderson
> Sent: Monday, March 15, 2021 8:32 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu;
> a...@rev.ng; Brian Cain
> Subject: Re: [PATCH v8 29/35] Hexagon (target/hexagon)
On Mon, Mar 15, 2021 at 05:58:04PM +0100,
Reinoud Zandijk wrote:
> I think its better to revert this and fix Linux ;) or make it a selectable
> feature as a workaround that's by default OFF :)
Anyway here is a patch to flip the default.
At the moment, this is compile-only tested to provide the
On Mon, 15 Mar 2021 at 17:47, Paolo Bonzini wrote:
>
> The following changes since commit 51204c2f188ec1e2a38f14718d38a3772f850a4b:
>
> Merge remote-tracking branch
> 'remotes/bkoppelmann2/tags/pull-tricore-20210314' into staging (2021-03-15
> 15:34:27 +)
>
> are available in the Git
On Mon, 15 Mar 2021 at 09:51, Stefan Hajnoczi wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
> request' into staging (2021-03-14 17:47:49 +)
>
> are available in the Git
Simplify TCG generation of hex_reg_written
Address feedback from Richard Henderson
Signed-off-by: Taylor Simpson
---
target/hexagon/genptr.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index
On Mon, Mar 15, 2021 at 05:58:04PM +0100, Reinoud Zandijk wrote:
> Hi,
>
> with the introduction of the following patch from 17th of February, Win10
> won't boot anymore without explicitly setting the machine to be 5.2 compatible
> like pc-1440fx-5.2. The default 6.0 will cause it to panic and
Public bug reported:
It used to be that building QEMU 5.1.0 twice in a row, using Guix, would
result in bit-for-bit identical results.
Starting with 5.2.0, this is no longer true. Here's a summary of which
files have non-determinism:
Here's a summary of the differing files:
$ diff -r
> -Original Message-
> From: Richard Henderson
> Sent: Monday, March 15, 2021 8:40 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com
> Subject: Re: [PATCH] Hexagon (target/hexagon) TCG generation cleanup
>
> On 3/14/21 10:54 PM, Taylor Simpson wrote:
> > Simplify
On Fri, Feb 12, 2021 at 10:28 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 12 ++
> target/riscv/insn32.decode | 13 ++
> target/riscv/insn_trans/trans_rvp.c.inc | 42 ++
>
On Fri, Feb 12, 2021 at 10:22 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 6
> target/riscv/insn32.decode | 6
> target/riscv/insn_trans/trans_rvp.c.inc | 7
>
On Fri, Feb 12, 2021 at 10:26 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 7 ++
> target/riscv/insn32.decode | 7 ++
> target/riscv/insn_trans/trans_rvp.c.inc | 8 +++
>
On Sat, 13 Mar 2021 at 19:58, Philippe Mathieu-Daudé wrote:
>
> Extract 1600+ lines from the big translate.c into a new file.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
This code motion caused Coverity to rescan this code, and
it thinks there's a problem in this
On Mon, Mar 15, 2021 at 05:19:17PM +,
"Daniel P. Berrangé" wrote:
> On Mon, Mar 15, 2021 at 05:58:04PM +0100, Reinoud Zandijk wrote:
> > Hi,
> >
> > with the introduction of the following patch from 17th of February, Win10
> > won't boot anymore without explicitly setting the machine to be
On Fri, Feb 12, 2021 at 10:20 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 6
> target/riscv/insn32.decode | 6
> target/riscv/insn_trans/trans_rvp.c.inc | 7
>
On Fri, Feb 12, 2021 at 10:18 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 9 +++
> target/riscv/insn32.decode | 17
> target/riscv/insn_trans/trans_rvp.c.inc | 16
>
On Fri, Feb 12, 2021 at 10:16 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
> ---
> target/riscv/helper.h | 9 ++
> target/riscv/insn32.decode | 17
> target/riscv/insn_trans/trans_rvp.c.inc | 115
>
On Tue, Dec 25, 2018 at 8:35 PM Richard Henderson
wrote:
>
> Sorry I missed the original post, but:
>
> > +} else if (unlikely((XRb == 0) && (XRc == 0))) {
> > +/* both operands zero registers -> just set destination to zero */
> > +tcg_gen_movi_i32(mxu_gpr[XRa - 1], 0);
> > +
On Fri, Feb 12, 2021 at 10:14 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 9 +++
> target/riscv/insn32.decode | 11
> target/riscv/insn_trans/trans_rvp.c.inc | 79
On Mon, Mar 15, 2021 at 1:15 PM Philippe Mathieu-Daudé
wrote:
>
> Add a Kconfig entry for guest-loader so we can optionally deselect
> it (default is built in), and add a Meson dependency on libfdt.
>
> This fixes when building with --disable-fdt:
>
> /usr/bin/ld:
On 3/15/21 8:46 PM, Richard Henderson wrote:
> On 3/14/21 10:55 PM, Taylor Simpson wrote:
>> Signed-of-by: Taylor Simpson
>> ---
>> target/hexagon/op_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Queued.
Can you s/Signed-of-by/Signed-off-by/ ? ;)
Le 15/03/2021 à 21:40, Richard Henderson a écrit :
> Partially revert 09f679b62dff, but only for the length arguments.
> Instead of reverting to long, use ssize_t. Reinstate the > 0 check
> in unlock_user.
>
> Fixes: 09f679b62dff
> Reported-by: Coverity (CID 1446711)
> Signed-off-by: Richard
Hi Thomas,
+Alex
On 3/15/21 8:07 PM, Thomas Huth wrote:
> The CONFIG_VFIO switch only works in target specific code. Since
> migration/migration.c is common code, the #ifdef does not have
> the intended behavior here. Move the related code to a separate
> file now which gets compiled via
A (generic) copy of the GLUE device we already have for q800 to use with
the m68k-virt machine.
The q800 one would disappear in the future as q800 uses actually the djMEMC
controller.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by:
Patchew URL:
https://patchew.org/QEMU/20210315204004.2025219-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210315204004.2025219-1-richard.hender...@linaro.org
Subject: [PATCH]
The machine is based on Goldfish interfaces defined by Google
for Android simulator. It uses Goldfish-rtc (timer and RTC),
Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty).
The machine is created with 128 virtio-mmio bus, and they can
be used to use serial console, GPU, disk,
Implement the goldfish tty device as defined in
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
and based on the kernel driver code:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/goldfish.c
Signed-off-by:
Add a system controller for the m68k-virt machine.
This controller allows the kernel to power off or reset the machine.
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Message-Id:
Implement the goldfish pic device as defined in
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
Signed-off-by: Laurent Vivier
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Message-Id:
The following changes since commit e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c:
Merge remote-tracking branch 'remotes/philmd/tags/avr-20210315' into stagin=
g (2021-03-15 16:59:55 +)
are available in the Git repository at:
git://github.com/vivier/qemu-m68k.git tags/m68k-for-6.0-pull
Partially revert 09f679b62dff, but only for the length arguments.
Instead of reverting to long, use ssize_t. Reinstate the > 0 check
in unlock_user.
Fixes: 09f679b62dff
Reported-by: Coverity (CID 1446711)
Signed-off-by: Richard Henderson
---
linux-user/qemu.h| 15 +--
On Mon, 15 Mar 2021 17:07:50 +0100
Christian Schoenebeck wrote:
> On Samstag, 13. März 2021 08:51:21 CET Greg Kurz wrote:
> > On Sat, 13 Mar 2021 07:43:38 +0200
> >
> > Mahmoud Mandour wrote:
> > > Thanks for the fast review. I asked on the QEMU IRC channel
> > > before committing whether to
From: Mahmoud Mandour
Replaced various qemu_mutex_lock calls and their respective
qemu_mutex_unlock calls with QEMU_LOCK_GUARD macro. This simplifies
the code by eliminating the respective qemu_mutex_unlock calls.
Signed-off-by: Mahmoud Mandour
Message-Id:
On Mon, 15 Mar 2021 11:36:49 -0700 (PDT)
no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20210315180102.3008391-1-imamm...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
>
From: Hao Wang
Function multifd_channel_connect() return "true" to indicate failure,
which is rather confusing. Fix that.
Signed-off-by: Hao Wang
Message-Id: <20210209104237.2250941-2-wanghao...@huawei.com>
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Chuan Zheng
Signed-off-by: Dr. David
* Pavel Dovgalyuk (pavel.dovgal...@ispras.ru) wrote:
> QEMU timer of channel 0 in i8254 is used to raise irq
> at the specified moment of time. This irq can be disabled
> with irq_disabled flag. But when vmstate of the pit is
> loaded, timer may be rearmed despite the disabled interrupts.
> This
From: Mahmoud Mandour
Removed various qemu_mutex_lock and their respective qemu_mutex_unlock
calls and used lock guard macros (QEMU_LOCK_GUARD and
WITH_QEMU_LOCK_GUARD). This simplifies the code by
eliminating qemu_mutex_unlock calls.
Signed-off-by: Mahmoud Mandour
Message-Id:
From: Hao Wang
If any error happens during multifd send thread creating (e.g. channel broke
because new domain is destroyed by the dst), multifd_tls_handshake_thread
may exit silently, leaving main migration thread hanging (ram_save_setup ->
multifd_send_sync_main -> qemu_sem_wait(>sem_sync)).
From: Greg Kurz
When passed an empty filename, lookup_name() returns the inode of
the parent directory, unless the parent is the root in which case
the st_dev doesn't match and lo_find() returns NULL. This is
because lookup_name() passes AT_EMPTY_PATH down to fstatat() or
statx().
This behavior
15.03.2021 09:06, Roman Kagan wrote:
As the reconnect logic no longer interferes with drained sections, it
appears unnecessary to explicitly manipulate the in_flight counter.
Fixes: 5ad81b4946 ("nbd: Restrict connection_co reentrance")
And here you actually allow qemu_aio_coroutine_enter()
From: Greg Kurz
Both currently only return 0 or 1.
Signed-off-by: Greg Kurz
Message-Id: <20210312141003.819108-3-gr...@kaod.org>
Reviewed-by: Connor Kuehl
Reviewed-by: Vivek Goyal
Signed-off-by: Dr. David Alan Gilbert
---
tools/virtiofsd/passthrough_ll.c | 6 +++---
1 file changed, 3
From: Vivek Goyal
Option "-V" currently displays the fuse protocol version virtiofsd is
using. For example, I see this.
$ ./virtiofsd -V
"using FUSE kernel interface version 7.33"
People also want to know software version of virtiofsd so that they can
figure out if a certain fix is part of
From: Greg Kurz
POSIX.1-2017 clearly stipulates that empty filenames aren't
allowed ([1] and [2]). Since virtiofsd is supposed to mirror
the host file system hierarchy and the host can be assumed to
be linux, we don't really expect clients to pass requests with
an empty path in it. If they do so
From: "Dr. David Alan Gilbert"
The following changes since commit e7c6a8cf9f5c82aa152273e1c9e80d07b1b0c32c:
Merge remote-tracking branch 'remotes/philmd/tags/avr-20210315' into staging
(2021-03-15 16:59:55 +)
are available in the Git repository at:
https://gitlab.com/dagr
From: Greg Kurz
QEMU can stop a virtqueue by sending a VHOST_USER_GET_VRING_BASE request
to virtiofsd. As with all other vhost-user protocol messages, the thread
that runs the main event loop in virtiofsd takes the vu_dispatch lock in
write mode. This ensures that no other thread can access
15.03.2021 09:06, Roman Kagan wrote:
The reconnection logic doesn't need to stop while in a drained section.
Moreover it has to be active during the drained section, as the requests
that were caught in-flight with the connection to the server broken can
only usefully get drained if the
On Mon, Mar 15, 2021 at 07:41:32PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 15.03.2021 09:06, Roman Kagan wrote:
> > Document (via a comment and an assert) that
> > nbd_client_detach_aio_context and nbd_client_attach_aio_context_bh run
> > in the desired aio_context
> >
> > Signed-off-by:
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 7df98fc43f..e3879a4622 100644
---
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 68ed0f2740..7df98fc43f 100644
---
On 3/14/21 10:55 PM, Taylor Simpson wrote:
Address feedback from Richard Henderson <
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_tcg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Queued.
r~
It reports the shadow virtqueue address from qemu virtual address space
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-shadow-virtqueue.h | 2 ++
hw/virtio/vhost-shadow-virtqueue.c | 24 +++-
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git
Initial version of shadow virtqueue that actually forward buffers.
It reuses the VirtQueue code for the device part. The driver part is
based on Linux's virtio_ring driver, but with stripped functionality
and optimizations so it's easier to review.
These will be added in later commits.
Check if all descriptors of the queue are available. In other words, is
the complete opposite of virtio_queue_empty: If the queue is full, the
driver cannot transfer more buffers to the device until the latter
make some as used.
In Shadow vq this situation happens with the correct guest network
On one hand it uses a mutex to synchronize guest masking with SVQ start
and stop, because otherwise guest mask could race with the SVQ
stop code, sending an incorrect call notifier to vhost device. This
would prevent further communication.
On the other hand it needs to add an event to synchronize
1 - 100 of 505 matches
Mail list logo
