Re: [RFC PATCH v2 4/5] Add migration support for KVM guest with MTE

2021-03-17 Thread Haibo Xu
On Thu, 18 Mar 2021 at 04:11, Dr. David Alan Gilbert wrote: > > * Haibo Xu (haibo...@linaro.org) wrote: > > To make it easier to keep the page tags sync with > > the page data, tags for one page are appended to > > the data during ram save iteration. > > > > This patch only add the pre-copy migrat

RE: Microsoft and Intel NVDIMM ACPI _DSM interfaces status?

2021-03-17 Thread Dexuan Cui
> From: Laszlo Ersek > Sent: Wednesday, March 17, 2021 3:45 PM > > The specs for the Intel interface are available here: > > ... > > This is the interface that QEMU emulates. It has been reported that > > Windows 2016 Server and 2019 Server guests do not recognize QEMU's > > emulated NVDIMM device

RE: [RFC PATCH 0/3] vfio/migration: Support manual clear vfio dirty log

2021-03-17 Thread Tian, Kevin
> From: Kunkun Jiang > Sent: Wednesday, March 10, 2021 5:41 PM > > Hi all, > > In the past, we clear dirty log immediately after sync dirty log to > userspace. This may cause redundant dirty handling if userspace > handles dirty log iteratively: > > After vfio clears dirty log, new dirty log sta

RE: [RFC 0/1] Use dmabufs for display updates instead of pixman

2021-03-17 Thread Zhang, Tina
> -Original Message- > From: Qemu-devel > On Behalf Of Gerd Hoffmann > Sent: Tuesday, March 2, 2021 8:04 PM > To: Kasireddy, Vivek > Cc: Daniel Vetter ; Kim, Dongwon > ; qemu-devel@nongnu.org; Marc-André Lureau > > Subject: Re: [RFC 0/1] Use dmabufs for display updates instead of pixm

Re: [RFC PATCH 0/3] vfio/migration: Support manual clear vfio dirty log

2021-03-17 Thread Kunkun Jiang
kindly ping, Any comments and reviews are welcome.😁 Thanks, Kunkun Jiang On 2021/3/10 17:41, Kunkun Jiang wrote: Hi all, In the past, we clear dirty log immediately after sync dirty log to userspace. This may cause redundant dirty handling if userspace handles dirty log iteratively: After vfi

Re: [PATCH] docs/devel/testing.rst: Fix referencies to unit tests

2021-03-17 Thread Thomas Huth
On 17/03/2021 20.48, Wainer dos Santos Moschetta wrote: With the recent move of the unit tests to tests/unit directory some instructions under the "Unit tests" section became imprecise, which are fixed by this change. Related-to: da668aa15b99 (tests: Move unit tests into a separate directory) Si

Re: [PATCH 2/2] utils: Work around mingw strto*l bug with 0x

2021-03-17 Thread Thomas Huth
On 17/03/2021 15.33, Eric Blake wrote: Mingw recognizes that "0x" has value 0 without setting errno, but fails to advance endptr to the trailing garbage 'x'. This in turn showed up in our recent testsuite additions for qemu_strtosz (commit 1657ba44b4 utils: Enhance testsuite for do_strtosz()); a

[PULL 2/2] net/colo-compare.c: Optimize removal of secondary packet

2021-03-17 Thread Zhang Chen
From: Lukas Straub g_queue_remove needs to look up the list entry first, but we already have it as result and can remove it directly with g_queue_delete_link. Signed-off-by: Lukas Straub Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insert

[PULL 1/2] net/colo-compare.c: Fix memory leak for non-tcp packet

2021-03-17 Thread Zhang Chen
From: Lukas Straub Additional to removing the packet from the secondary queue, we also need to free it. Signed-off-by: Lukas Straub Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/colo-compare.c b/net/colo-compa

[PULL 0/2] 2021-03-18 COLO proxy patches

2021-03-17 Thread Zhang Chen
Hi Jason, please merge this series to net queue. Lukas Straub (2): net/colo-compare.c: Fix memory leak for non-tcp packet net/colo-compare.c: Optimize removal of secondary packet net/colo-compare.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1

Re: [PATCH v2] net/macos: implement vmnet-based netdev

2021-03-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210318035427.13436-1-akihiko.od...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210318035427.13436-1-akihiko.od...@gmail.com Subject: [PATCH v2] net/macos: impleme

RE: [PATCH v8 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-03-17 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 2:13 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 15/35] Hexagon (target/hexagon/arc

RE: [PATCH v8 16/35] Hexagon (target/hexagon/conv_emu.[ch]) utility functions

2021-03-17 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 2:57 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 16/35] Hexagon (target/hexagon/con

RE: [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions

2021-03-17 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 5:15 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 17/35] Hexagon (target/hexagon/fma

[PATCH v2] net/macos: implement vmnet-based netdev

2021-03-17 Thread Akihiko Odaki
From: Phillip Tennen This patch implements a new netdev device, reachable via -netdev vmnet-macos, that’s backed by macOS’s vmnet framework. The vmnet framework provides native bridging support, and its usage in this patch is intended as a replacement for attempts to use a tap device via the tun

RE: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet

2021-03-17 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, March 18, 2021 10:41 AM > To: Zhang, Chen ; Lukas Straub > > Cc: qemu-devel ; Li Zhijian > > Subject: Re: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet > > > 在 2021/3/18 上午9:22, Zhang, Chen 写道: > > Sorry for th

Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding

2021-03-17 Thread Jason Wang
在 2021/3/17 下午10:38, Eugenio Perez Martin 写道: On Wed, Mar 17, 2021 at 3:51 AM Jason Wang wrote: 在 2021/3/17 上午12:05, Eugenio Perez Martin 写道: On Tue, Mar 16, 2021 at 9:15 AM Jason Wang wrote: 在 2021/3/16 上午3:48, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward

[PATCH V3 6/7] net/colo-compare: Add passthrough list to CompareState

2021-03-17 Thread Zhang Chen
Add passthrough list for each CompareState. Signed-off-by: Zhang Chen --- net/colo-compare.c | 29 + net/colo-compare.h | 11 +++ 2 files changed, 40 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index a803f8b888..40af8cd501 100644 --- a/

[PATCH V3 4/7] hmp-commands: Add new HMP command for COLO passthrough

2021-03-17 Thread Zhang Chen
Add hmp_colo_passthrough_add and hmp_colo_passthrough_del make user can maintain COLO network passthrough list in human monitor. Signed-off-by: Zhang Chen --- hmp-commands.hx | 26 ++ include/monitor/hmp.h | 2 ++ monitor/hmp-cmds.c| 34

Re: [RFC v2 05/13] vhost: Route guest->host notification through shadow virtqueue

2021-03-17 Thread Jason Wang
在 2021/3/18 上午12:47, Eugenio Perez Martin 写道: On Wed, Mar 17, 2021 at 3:05 AM Jason Wang wrote: 在 2021/3/16 下午6:31, Eugenio Perez Martin 写道: On Tue, Mar 16, 2021 at 8:18 AM Jason Wang wrote: 在 2021/3/16 上午3:48, Eugenio Pérez 写道: Shadow virtqueue notifications forwarding is disabled when

[PATCH V3 7/7] net/net.c: Add handler for COLO passthrough connection

2021-03-17 Thread Zhang Chen
Use connection protocol,src port,dst port,src ip,dst ip as the key to bypass certain network traffic in COLO compare. Signed-off-by: Zhang Chen --- net/net.c | 153 ++ 1 file changed, 153 insertions(+) diff --git a/net/net.c b/net/net.c index

[PATCH V3 2/7] qapi/net.json: Add L4_Connection definition

2021-03-17 Thread Zhang Chen
Add L4_Connection struct for other QMP commands. Except protocol field is necessary, other fields are optional. Signed-off-by: Zhang Chen --- qapi/net.json | 26 ++ 1 file changed, 26 insertions(+) diff --git a/qapi/net.json b/qapi/net.json index dc4c87dc7b..b4958447f2 1

[PATCH V3 1/7] qapi/net.json: Add IP_PROTOCOL definition

2021-03-17 Thread Zhang Chen
Add IP_PROTOCOL as enum include TCP,UDP, ICMP... for other QMP commands. Signed-off-by: Zhang Chen --- qapi/net.json | 30 ++ 1 file changed, 30 insertions(+) diff --git a/qapi/net.json b/qapi/net.json index c31748c87f..dc4c87dc7b 100644 --- a/qapi/net.json +++ b/qap

[PATCH V3 5/7] net/colo-compare: Move data structure and define to .h file.

2021-03-17 Thread Zhang Chen
Make other modules can reuse COLO code. Signed-off-by: Zhang Chen --- net/colo-compare.c | 106 - net/colo-compare.h | 106 + 2 files changed, 106 insertions(+), 106 deletions(-) diff --git a/net/colo-compar

[PATCH V3 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-03-17 Thread Zhang Chen
Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. QMP demo usage: {'execute': 'colo-passthrough-add', 'arguments': {'protocol': 'tcp', 'id': 'comp0', 'src_ip':'10.239.48.105', 'dst

[PATCH V3 0/7] Bypass specific network traffic in COLO

2021-03-17 Thread Zhang Chen
Due to some real user scenarios don't need to monitor all traffic. And qemu net-filter also need function to more detailed flow control. This series give user ability to bypass kinds of COLO network stream. For example, windows guest user want to enable windows remote desktop to touch guest(UDP/

How to create vhdx differencing disk using qemu-img

2021-03-17 Thread qi zhou
When I create vhdx differencing disk using qemu-img, It says  qemu-img: xxx.vhd Backing file not supported for file format 'vhdx' The command I used is qemu-img create -f vhdx -b test.vhdx test-snapshot.vhdx Here is my questions 1. Is vhdx format [full] supported by qemu ? 2. If not, is there any

Re: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet

2021-03-17 Thread Jason Wang
在 2021/3/18 上午9:22, Zhang, Chen 写道: Sorry for the delay. Current COLO tree just merged this series, I originally wanted to merge other COLO related patches(Lei or me) and submit it together to Jason. Hi Jason, do you need me to send this series first or do you want to do it together? We'r

[PATCH] hw/arm/virt: Disable pl011 clock migration if needed

2021-03-17 Thread Gavin Shan
A clock is added by commit aac63e0e6ea3 ("hw/char/pl011: add a clock input") since v5.2.0 which corresponds to virt-5.2 machine type. It causes backwards migration failure from upstream to downstream (v5.1.0) when the machine type is specified with virt-5.1. This fixes the issue by following instr

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Gavin Shan
Hi Drew, On 3/17/21 11:54 PM, Andrew Jones wrote: On Wed, Mar 17, 2021 at 11:14:56AM +, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:59, Gavin Shan wrote: On 3/17/21 9:40 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: On 3/17/21 8:09 PM, Peter Maydell wrote:

Re: [PATCH v1 1/5] target/riscv: Convert the RISC-V exceptions to an enum

2021-03-17 Thread Bin Meng
On Thu, Mar 18, 2021 at 1:41 AM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu_bits.h | 44 --- > target/riscv/cpu.c| 2 +- > target/riscv/cpu_helper.c | 4 ++-- > 3 files changed, 26 insertions(+), 24 deletion

Re: Serious doubts about Gitlab CI

2021-03-17 Thread Bin Meng
On Thu, Mar 18, 2021 at 4:32 AM Philippe Mathieu-Daudé wrote: > > Hi, > > For some (unclear) reason I got my free tier Gitlab account renewed and > lost the privilege for users opening account before the quota limit. > > I pushed a single branch to my namespace repo to trigger a pipeline. > 1h lat

RE: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet

2021-03-17 Thread Zhang, Chen
Sorry for the delay. Current COLO tree just merged this series, I originally wanted to merge other COLO related patches(Lei or me) and submit it together to Jason. Hi Jason, do you need me to send this series first or do you want to do it together? Thanks Chen > -Original Message- > Fr

RE: [PATCH V2 6/7] net/colo-compare: Add passthrough list to CompareState

2021-03-17 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, March 18, 2021 5:16 AM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Zhang Chen > Subject: Re: [PATCH V2 6/7] net/colo-compare: Add passthrough

Re: [PATCH v2 6/6] tests/qtest: add tests for am53c974 device

2021-03-17 Thread Alexander Bulekov
On 210317 2302, Mark Cave-Ayland wrote: > Use the autogenerated fuzzer test cases as the basis for a set of am53c974 > regression tests. > > Signed-off-by: Mark Cave-Ayland > --- Reviewed-by: Alexander Bulekov Thanks

Re: [PATCH v2 5/6] esp: always check current_req is not NULL before use in DMA callbacks

2021-03-17 Thread Alexander Bulekov
On 210317 2302, Mark Cave-Ayland wrote: > After issuing a SCSI command the SCSI layer can call the SCSIBusInfo .cancel > callback which resets both current_req and current_dev to NULL. If any data > is left in the transfer buffer (async_len != 0) then the next TI (Transfer > Information) command wi

Re: [PATCH v2 4/6] esp: don't underflow fifo when writing to the device

2021-03-17 Thread Alexander Bulekov
On 210317 2302, Mark Cave-Ayland wrote: > When writing to the device make sure that the fifo is not empty, otherwise the > fifo will underflow triggering an assert. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1909247 > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 28

Re: [PATCH v2 3/6] esp: ensure cmdfifo is not empty and current_dev is non-NULL\

2021-03-17 Thread Alexander Bulekov
On 210317 2302, Mark Cave-Ayland wrote: > When about to execute a SCSI command, ensure that cmdfifo is not empty and > current_dev is non-NULL. This can happen if the guest tries to execute a TI > (Transfer Information) command without issuing one of the select commands > first. > > Buglink: https

Re: [PATCH v2 1/6] esp: don't underflow cmdfifo if no message out/command data is present

2021-03-17 Thread Alexander Bulekov
On 210317 2302, Mark Cave-Ayland wrote: > If a guest sends a TI (Transfer Information) command without previously > sending > any message out/command phase data then cmdfifo will underflow triggering an > assert reading the IDENTIFY byte. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1919035

Re: Microsoft and Intel NVDIMM ACPI _DSM interfaces status?

2021-03-17 Thread Dan Williams
On Wed, Mar 17, 2021 at 4:49 AM Stefan Hajnoczi wrote: > > Hi, > Microsoft and Intel developed two different ACPI NVDIMM _DSM interfaces. > > The specs for the Intel interface are available here: > https://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > This is the interface that QEMU emula

Re: [PATCH v5 0/4] target/arm: Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

2021-03-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210317233301.4130-1-rebe...@nuviainc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210317233301.4130-1-rebe...@nuviainc.com Subject: [PATCH v5 0/4] target/arm: Add suppor

[PATCH v5 3/4] target/arm: Add support for FEAT_TLBIOS

2021-03-17 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI maintenance instructions that extend to the Outer Shareable domain. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 5 ++ target/arm/helper.c | 75 2 files changed, 80 insertions(+) diff --git a/target/arm/cpu.

[PATCH v5 4/4] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

2021-03-17 Thread Rebecca Cran
Indicate support for FEAT_TLBIOS and FEAT_TLBIRANGE by setting ID_AA64ISAR0.TLB to 2 for the max AARCH64 CPU type. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index

[PATCH v5 2/4] target/arm: Add support for FEAT_TLBIRANGE

2021-03-17 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI maintenance instructions that apply to a range of input addresses. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 5 + target/arm/helper.c | 294 2 files changed, 299 insertions(+) diff --git a/target/arm/

[PATCH v5 1/4] accel/tcg: Add TLB invalidation support for ranges of addresses

2021-03-17 Thread Rebecca Cran
Add functions to support the FEAT_TLBIRANGE ARMv8.4 feature that adds TLB invalidation instructions to invalidate ranges of addresses. Signed-off-by: Rebecca Cran --- accel/tcg/cputlb.c | 130 +++- include/exec/exec-all.h | 45 +++ 2 files changed, 172 insertions(+), 3

[PATCH v5 0/4] target/arm: Add support for FEAT_TLBIOS and FEAT_TLBIRANGE

2021-03-17 Thread Rebecca Cran
ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE. They provides TLBI maintenance instructions that extend to the Outer Shareable domain and that apply to a range of input addresses. Changes from v4 to v5: o Split changes to cputlb.c and exec_all.c into a separate commit. o Return a bool

Re: iotests failing on gitlab CI check-system-fedora job

2021-03-17 Thread Paolo Bonzini
On 17/03/21 23:23, Peter Maydell wrote: The check-system-fedora job in the gitlab CI seems to have started reliably failing on iotests 040 041 127 256 267: https://gitlab.com/qemu-project/qemu/-/jobs/1106977551 Could somebody have a look at what's happening, please? (This is probably a regress

Re: [PATCH V3] file-posix: allow -EBUSY -EINVAL errors during write zeros on block

2021-03-17 Thread John Snow
On 3/9/21 7:16 PM, ChangLimin wrote: Since Linux 5.10, write zeros to a multipath device using ioctl(fd, BLKZEROOUT, range) with cache none or directsync return -EBUSY permanently. When do we get -EINVAL? Both of the commits referenced below don't specifically mention it, so I am not sure in

[PATCH v2 5/6] esp: always check current_req is not NULL before use in DMA callbacks

2021-03-17 Thread Mark Cave-Ayland
After issuing a SCSI command the SCSI layer can call the SCSIBusInfo .cancel callback which resets both current_req and current_dev to NULL. If any data is left in the transfer buffer (async_len != 0) then the next TI (Transfer Information) command will attempt to reference the NULL pointer causing

[PATCH v2 4/6] esp: don't underflow fifo when writing to the device

2021-03-17 Thread Mark Cave-Ayland
When writing to the device make sure that the fifo is not empty, otherwise the fifo will underflow triggering an assert. Buglink: https://bugs.launchpad.net/qemu/+bug/1909247 Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 28 1 file changed, 16 insertions(+), 12

[PATCH v2 6/6] tests/qtest: add tests for am53c974 device

2021-03-17 Thread Mark Cave-Ayland
Use the autogenerated fuzzer test cases as the basis for a set of am53c974 regression tests. Signed-off-by: Mark Cave-Ayland --- tests/qtest/am53c974-test.c | 122 tests/qtest/meson.build | 1 + 2 files changed, 123 insertions(+) create mode 100644 tes

[PATCH v2 2/6] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size

2021-03-17 Thread Mark Cave-Ayland
If a guest transfers the message out/command phase data using DMA with a TC that is larger than the cmdfifo size then the cmdfifo overflows triggering an assert. Limit the size of the transfer to the free space available in cmdfifo. Buglink: https://bugs.launchpad.net/qemu/+bug/1919036 Signed-off-

[PATCH v2 3/6] esp: ensure cmdfifo is not empty and current_dev is non-NULL

2021-03-17 Thread Mark Cave-Ayland
When about to execute a SCSI command, ensure that cmdfifo is not empty and current_dev is non-NULL. This can happen if the guest tries to execute a TI (Transfer Information) command without issuing one of the select commands first. Buglink: https://bugs.launchpad.net/qemu/+bug/1910723 Buglink: htt

[PATCH v2 1/6] esp: don't underflow cmdfifo if no message out/command data is present

2021-03-17 Thread Mark Cave-Ayland
If a guest sends a TI (Transfer Information) command without previously sending any message out/command phase data then cmdfifo will underflow triggering an assert reading the IDENTIFY byte. Buglink: https://bugs.launchpad.net/qemu/+bug/1919035 Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c |

[PATCH v2 0/6] esp: fix asserts/segfaults discovered by fuzzer

2021-03-17 Thread Mark Cave-Ayland
Recently there have been a number of issues raised on Launchpad as a result of fuzzing the am53c974 (ESP) device. I spent some time over the past couple of days checking to see if anything had improved since my last patchset: from what I can tell the issues are still present, but the cmdfifo relate

Re: Can not use hmp block_resize command with -blockdev option

2021-03-17 Thread John Snow
On 3/16/21 11:43 PM, zhao xiaojun wrote: Hi, I use -blockdev option to specify a drive when qemu boot and i want to resize it with hmp block_resize command. The hmp block_resize comand's arguments: block_resize device new_size. So I query the device by qmp query_block command, but the device fi

Re: Microsoft and Intel NVDIMM ACPI _DSM interfaces status?

2021-03-17 Thread Laszlo Ersek
(Adding Dexuan Cui to the CC list, comments below.) On 03/17/21 12:49, Stefan Hajnoczi wrote: > Hi, > Microsoft and Intel developed two different ACPI NVDIMM _DSM > interfaces. > > The specs for the Intel interface are available here: > https://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf >

Re: "make check" broken with everything but tools disabled

2021-03-17 Thread John Snow
On 3/16/21 9:28 AM, Markus Armbruster wrote: Watch this: $ mkdir bld-tools $ cd bld-tools $ ../configure --disable-system --disable-user --enable-tools $ make check [...] make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-bloc

Re: of AVR target page size

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 20:17, Dr. David Alan Gilbert wrote: > > Hi Michael, > I noticed your AVR code defines: > > #define TARGET_PAGE_BITS 8 > > and has an explanation of why. > > Note however that's not going to work with the current live > migration/snapshotting code, since you're a couple

iotests failing on gitlab CI check-system-fedora job

2021-03-17 Thread Peter Maydell
The check-system-fedora job in the gitlab CI seems to have started reliably failing on iotests 040 041 127 256 267: https://gitlab.com/qemu-project/qemu/-/jobs/1106977551 Could somebody have a look at what's happening, please? (This is probably a regression that's got into master because I stoppe

Re: [RFC PATCH 32/42] docker: Add gentoo-mipsr5900el-cross image

2021-03-17 Thread Maciej W. Rozycki
On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote: > Maciej, I tried your suggestion as follow: > > $ mipsel-linux-gnu-gcc --version > mipsel-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0 > Copyright (C) 2018 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. T

Re: [PULL 0/1] qemu-openbios queue 20210316

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 20:39, Mark Cave-Ayland wrote: > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are available in the Git repository at:

Re: [PATCH] docs/devel/testing.rst: Fix referencies to unit tests

2021-03-17 Thread John Snow
typo in the commit summary; "references to" On 3/17/21 3:48 PM, Wainer dos Santos Moschetta wrote: With the recent move of the unit tests to tests/unit directory some instructions under the "Unit tests" section became imprecise, which are fixed by this change. Related-to: da668aa15b99 (tests: M

[PATCH] acpi:piix4, vt82c686: reinitialize acpi PM device on reset

2021-03-17 Thread isaku . yamahata
From: Isaku Yamahata Commit 6be8cf56bc8b made sure that SCI is enabled in PM1.CNT on reset in acpi_only mode by modifying acpi_pm1_cnt_reset() and that worked for q35 as expected. The function was introduced by commit eaba51c573a (acpi, acpi_piix, vt82c686: factor out PM1_CNT logic) that forgo

CXL 2.0 memory device design

2021-03-17 Thread Ben Widawsky
Phil, Igor, Markus TL;DR: What to do about multiple capacities in a single device, and what to do about interleave? I've hacked together a basic CXL 2.0 implementation which exposes a CXL "Type 3" memory device (CXL 2.0 Chapter 2.3). For what we were trying to do this was sufficient. There are tw

Re: of AVR target page size

2021-03-17 Thread Michael Rolnik
Hi Dave. What is the smallest supported page size? On Wed, Mar 17, 2021 at 10:14 PM Dr. David Alan Gilbert wrote: > Hi Michael, > I noticed your AVR code defines: > > #define TARGET_PAGE_BITS 8 > > and has an explanation of why. > > Note however that's not going to work with the current li

Re: Win10 always takes 100% cpu power even when idle

2021-03-17 Thread Reinoud Zandijk
Hi, On Wed, Mar 17, 2021 at 05:05:39PM +, Daniel P. Berrangé wrote: > Possibly you need some of the hyperv enlightenments enabled too. Though > I can't recall the precise command line offhand, as I just rely on > virt-install virt-manager to do the right thing for Windows guests. HuperV suppo

Re: [PATCH 0/2] colo-compare: Fix memory leak for non-tcp packet

2021-03-17 Thread Lukas Straub
Hi, This hasn't been merged yet. Regards, Lukas Straub On Mon, 16 Nov 2020 07:32:22 + "Zhang, Chen" wrote: > Queued this series to COLO tree. > > Thanks > Chen > > > -Original Message- > > From: Lukas Straub > > Sent: Sunday, November 15, 2020 7:19 PM > > To: qemu-devel > > Cc:

Re: [PATCH V2 6/7] net/colo-compare: Add passthrough list to CompareState

2021-03-17 Thread Lukas Straub
On Wed, 3 Mar 2021 12:15:38 +0800 Zhang Chen wrote: > From: Zhang Chen > > Add passthrough list for each CompareState. > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 25 + > net/colo-compare.h | 10 ++ > 2 files changed, 35 insertions(+) > > diff

Re: [PATCH 1/2] Fix the segment fault when calling yank_register_instance

2021-03-17 Thread Lukas Straub
On Mon, 15 Mar 2021 18:06:35 +0100 Li Zhang wrote: > From: Li Zhang > > When executing the QMP commands "chardev-change" to change the > backend device to socket, it will cause a segment fault because > it assumes chr->label as non-NULL in function yank_register_instance. > The function qmp_cha

Re: [PULL v2 0/6] QOM and fdc patches patches for 2021-03-16

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 19:23, Markus Armbruster wrote: > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are available in the Git repository at

Re: [PULL v3 00/42] Block layer patches and object-add QAPIfication

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 18:12, Kevin Wolf wrote: > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are available in the Git repository at: > >

Re: [PULL 00/10] VFIO updates for QEMU 6.0

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 17:21, Alex Williamson wrote: > > This is a resend of the same sent on 2021-03-11 where 00/10 and 02/10 > were eaten by the mail server. Rebased to current staging and re-tagged. > > The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: > > Merge re

Re: [PATCH] yank: Avoid linking into executables that don't want it

2021-03-17 Thread Lukas Straub
On Tue, 16 Mar 2021 14:59:07 +0100 Markus Armbruster wrote: > util/yank.c and stubs/yank.c are both in libqemuutil.a, even though > their external symbols conflict. The linker happens to pick the > former. This links a bunch of unneeded code into the executables that > actually want the latter:

Re: [PATCH 06/38] target/riscv: SIMD 16-bit Shift Instructions

2021-03-17 Thread Alistair Francis
On Tue, Mar 16, 2021 at 10:31 PM LIU Zhiwei wrote: > > > > On 2021/3/17 3:54, Alistair Francis wrote: > > On Mon, Mar 15, 2021 at 10:40 PM LIU Zhiwei wrote: > >> > >> > >> On 2021/3/16 5:25, Alistair Francis wrote: > >>> On Fri, Feb 12, 2021 at 10:16 AM LIU Zhiwei wrote: > Signed-off-by: LI

Serious doubts about Gitlab CI

2021-03-17 Thread Philippe Mathieu-Daudé
Hi, For some (unclear) reason I got my free tier Gitlab account renewed and lost the privilege for users opening account before the quota limit. I pushed a single branch to my namespace repo to trigger a pipeline. 1h later I was surprised to see the pipeline was stuck, having completed 99 jobs of

of AVR target page size

2021-03-17 Thread Dr. David Alan Gilbert
Hi Michael, I noticed your AVR code defines: #define TARGET_PAGE_BITS 8 and has an explanation of why. Note however that's not going to work with the current live migration/snapshotting code, since you're a couple of bits smaller than the smallest page size we had so far, and for many years

Re: [RFC PATCH v2 4/5] Add migration support for KVM guest with MTE

2021-03-17 Thread Dr. David Alan Gilbert
* Haibo Xu (haibo...@linaro.org) wrote: > To make it easier to keep the page tags sync with > the page data, tags for one page are appended to > the data during ram save iteration. > > This patch only add the pre-copy migration support. > Post-copy and compress as well as zero page saving > are no

[PATCH] docs/devel/testing.rst: Fix referencies to unit tests

2021-03-17 Thread Wainer dos Santos Moschetta
With the recent move of the unit tests to tests/unit directory some instructions under the "Unit tests" section became imprecise, which are fixed by this change. Related-to: da668aa15b99 (tests: Move unit tests into a separate directory) Signed-off-by: Wainer dos Santos Moschetta --- docs/devel/

Re: [PATCH v1 2/5] target/riscv: Use the RiscVException enum for CSR predicates

2021-03-17 Thread Richard Henderson
On 3/17/21 11:39 AM, Alistair Francis wrote: @@ -1312,8 +1320,8 @@ int riscv_csrrw(CPURISCVState *env, int csrno, target_ulong *ret_value, return -RISCV_EXCP_ILLEGAL_INST; } ret = csr_ops[csrno].predicate(env, csrno); -if (ret < 0) { -return ret; +if (ret >

Re: [PULL 0/1] 9p queue 2021-03-16

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 11:00, Christian Schoenebeck wrote: > > The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15 > 19:23:00 +) > > are available in the G

Re: [PULL 00/13] misc patches removing deprecated features

2021-03-17 Thread Peter Maydell
On Tue, 16 Mar 2021 at 16:55, Daniel P. Berrangé wrote: > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are available in the Git repository a

[PATCH 1/2] plugins: Update qemu-plugins.symbols to match qemu-plugins.h

2021-03-17 Thread Yonggang Luo
Reorder the function symbols that consistence with qemu-plugins.h Signed-off-by: Yonggang Luo --- plugins/qemu-plugins.symbols | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index 4bdb381

Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

2021-03-17 Thread Cédric Le Goater
On 3/17/21 8:00 PM, Philippe Mathieu-Daudé wrote: > On 3/17/21 7:30 PM, Cédric Le Goater wrote: >> On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: >>> The flash mmio region is exposed as an AddressSpace. >>> AddressSpaces must not be sysbus-mapped, therefore map >>> the region using an alias. >>>

Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it

2021-03-17 Thread BALATON Zoltan
On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote: On 3/17/21 2:17 AM, BALATON Zoltan wrote: To allow reusing ISA bridge emulation for vt8231_isa move the device state of vt82c686b_isa emulation in an abstract via_isa class. This change breaks migration back compatibility but this is not an issu

Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

2021-03-17 Thread Cédric Le Goater
On 3/13/21 1:05 PM, Philippe Mathieu-Daudé wrote: > Incorrect subject prefix, should be "hw/ssi/aspeed_smc" Is this just good practice or something that was agreed upon ? We should update checkpatch if so. Thanks, C. > > On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: >> The flash mmio re

Re: [PATCH 0/3] tests/acceptance: Handle tests with "cpu" tag

2021-03-17 Thread Wainer dos Santos Moschetta
Added John and Eduardo, On 3/9/21 3:52 PM, Cleber Rosa wrote: On Wed, Feb 24, 2021 at 06:26:51PM -0300, Wainer dos Santos Moschetta wrote: Currently the acceptance tests tagged with "machine" have the "-M TYPE" automatically added to the list of arguments of the QEMUMachine object. In other wor

Re: [RFC PATCH 32/42] docker: Add gentoo-mipsr5900el-cross image

2021-03-17 Thread Philippe Mathieu-Daudé
Hi Maciej, Alex, On 3/12/21 9:04 PM, Maciej W. Rozycki wrote: > On Fri, 12 Mar 2021, Philippe Mathieu-Daudé wrote: > >>> but your two options to >>> choose from are: >>> >>> 1. Build for the soft-float ABI (`-msoft-float') where any FP calculations >>>are compiled such as to be made by the

[RFC v9 48/50] target/arm: tcg: restrict ZCR cpregs to TARGET_AARCH64

2021-03-17 Thread Claudio Fontana
restrict zcr_el1, zcr_el2, zcr_no_el2, zcr_el3 reginfo, as well as related SVE functions. Signed-off-by: Claudio Fontana --- target/arm/cpu.h | 7 --- target/arm/tcg/cpu-sve.h | 7 +++ linux-user/syscall.c | 4 target/arm/cpu-exceptions-aa64.c

[PATCH 0/2] *** This is based on pull request from Alex Bennée ***

2021-03-17 Thread Yonggang Luo
*** BLURB HERE *** The pull request https://patchew.org/QEMU/20210317072216.16316-1-alex.ben...@linaro.org/ Yonggang Luo (2): plugins: Update qemu-plugins.symbols to match qemu-plugins.h plugins: Move all typedef and type declaration to the front of the qemu-plugin.h include/qemu/qemu-pl

[PATCH 2/2] plugins: Move all typedef and type declaration to the front of the qemu-plugin.h

2021-03-17 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 187 ++--- 1 file changed, 92 insertions(+), 95 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 97cdfd7761..2cb17f3051 100644 --- a/include/qemu/qemu-plugin.h +++

[RFC v9 43/50] target/arm: cpu-sve: new module

2021-03-17 Thread Claudio Fontana
extract the SVE-related cpu object properties and functions, and move them to a separate module. Disentangle SVE from pauth that is a separate, TCG-only feature. Signed-off-by: Claudio Fontana --- target/arm/cpu-sve.h | 40 + target/arm/cpu.h | 22 +-- target/arm/cpu-sve.c

Re: [RFC v9 29/50] target/arm: cleanup cpu includes

2021-03-17 Thread Philippe Mathieu-Daudé
On 3/17/21 7:29 PM, Claudio Fontana wrote: > cpu.c, > cpu32.c, > cpu64.c, > tcg/sysemu/tcg-cpu.c, > > all need a good cleanup when it comes to included header files. > > Signed-off-by: Claudio Fontana > --- > target/arm/cpu.c| 8 ++-- > target/arm/cpu32.c | 14

Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

2021-03-17 Thread Philippe Mathieu-Daudé
On 3/17/21 7:30 PM, Cédric Le Goater wrote: > On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: >> The flash mmio region is exposed as an AddressSpace. >> AddressSpaces must not be sysbus-mapped, therefore map >> the region using an alias. >> >> Signed-off-by: Philippe Mathieu-Daudé > > That does

[RFC v9 44/50] target/arm: cpu-sve: split TCG and KVM functionality

2021-03-17 Thread Claudio Fontana
put the KVM-specific and TCG-specific functionality in the respective subdirectories kvm/ and tcg/ Signed-off-by: Claudio Fontana --- target/arm/cpu-sve.h | 2 +- target/arm/kvm/cpu-sve.h | 30 +++ target/arm/tcg/cpu-sve.h | 24 ++ target/arm/cpu-sve.c | 166 +

[RFC v9 47/50] target/arm: cpu-exceptions: new module

2021-03-17 Thread Claudio Fontana
extract the exception handling code from cpu-sysemu, and split it into general arm code and an AArch64-specific part. Signed-off-by: Claudio Fontana --- target/arm/cpu-exceptions-aa64.h | 32 + target/arm/cpu.h | 4 - target/arm/arch_dump.c | 1 + target/arm/cpu-ex

[RFC v9 46/50] target/arm: arch_dump: restrict ELFCLASS64 to AArch64

2021-03-17 Thread Claudio Fontana
this will allow us to restrict more code to TARGET_AARCH64 Signed-off-by: Claudio Fontana --- target/arm/helper-a64.h | 2 ++ target/arm/helper.h | 1 - target/arm/arch_dump.c | 12 +++- target/arm/cpu.c| 1 - target/arm/cpu64.c | 4 target/arm/tcg/helper.c | 1

[RFC v9 34/50] tests: device-introspect-test: cope with ARM TCG-only devices

2021-03-17 Thread Claudio Fontana
Skip the test_device_intro_concrete for now for ARM KVM-only build, as on ARM we currently build devices for ARM that are not compatible with a KVM-only build. We can remove this workaround when we fix this in KConfig etc, and we only list and build machines that are compatible with KVM for KVM-on

[RFC v9 49/50] target/arm: cpu-pauth: new module for ARMv8.3 Pointer Authentication

2021-03-17 Thread Claudio Fontana
Pointer Authentication is an AARCH64-only ARMv8.3 optional extension, whose cpu properties can be separated out in its own module. Signed-off-by: Claudio Fontana --- target/arm/cpu.h | 13 +--- target/arm/tcg/cpu-pauth.h | 38 ++ target/arm/cpu.c | 3

[RFC v9 50/50] target/arm: refactor arm_cpu_finalize_features into cpu64

2021-03-17 Thread Claudio Fontana
all the features in arm_cpu_finalize_features are actually TARGET_AARCH64-only, since KVM is now only supported on 64bit. Therefore move the function to cpu64, and rename it to aarch64_cpu_finalize_features. Signed-off-by: Claudio Fontana --- target/arm/cpu.h | 3 +- target/arm/kvm/kvm

  1   2   3   4   5   >