Re: [PATCH v2] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-30 Thread Thomas Huth
On 30/03/2021 12.53, Paolo Bonzini wrote: On 30/03/21 11:08, Thomas Huth wrote:   I've picked the Django Code of Conduct as a base, since it sounds rather   friendly and still welcoming to me, but I'm open for other suggestions, too   (but we should maybe pick one where the conflict resolution

RE: [PATCH 00/11] Add support for Blob resources feature

2021-03-30 Thread Zhang, Tina
Hi Gerd, Since the udmabuf and blob supports are on their way, can we reconsider the display-drm ui support which was list in https://git.kraxel.org/cgit/qemu/refs/heads as a branch before. I did some rebasing work and can help to send them out for review if possible. BR, Tina >

Re: Planning wiki page is outdated (says 5.0 is currently in development)

2021-03-30 Thread Thomas Huth
On 31/03/2021 04.53, Rebecca Cran wrote: I noticed https://wiki.qemu.org/Planning is outdated: 6.0 is listed under Planning Pages, but at the top it says 5.0 is the release that's currently in development. Thanks for the hint! I've simply removed that link now since we apparently forgot to

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-30 Thread Michael Ellerman
David Gibson writes: > On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: ... > >> We assign ibm,chip-id=0x0 to CPUs 0-3, but CPUs 2-3 are located in a >> different NUMA node than 0-1. This would mean that the same socket >> would belong to different NUMA nodes at the same

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread Greg Kurz
On Wed, 31 Mar 2021 11:09:06 +1100 David Gibson wrote: > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > On 3/29/21 10:54 PM, David Gibson wrote: > > >B) Just the hflags patches from my / Richard's tree > > > https://gitlab.com/dgibson/qemu/-/pipelines/278497244

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Vaibhav Jain
Thanks for looking into this patch, David Gibson writes: >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in

Re: [PATCH 00/11] Add support for Blob resources feature

2021-03-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210331031001.1564125-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210331031001.1564125-1-vivek.kasire...@intel.com Subject: [PATCH 00/11] Add

[PATCH 11/11] virtio-gpu: Update cursor data using blob

2021-03-30 Thread Vivek Kasireddy
If a blob is available for the cursor, copy the data from the blob. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/display/virtio-gpu.c

[PATCH 10/11] virtio-gpu: Add virtio_gpu_set_scanout_blob

2021-03-30 Thread Vivek Kasireddy
This API allows Qemu to set the blob allocated by the Guest as the scanout buffer. If Opengl support is available, then the scanout buffer would be submitted as a dmabuf to the UI; if not, a pixman image is created from the scanout buffer and is submitted to the UI via the display surface.

[PATCH 09/11] virtio-gpu: Add helpers to create and destroy dmabuf objects

2021-03-30 Thread Vivek Kasireddy
These helpers can be useful for creating dmabuf objects from blobs and submitting them to the UI. Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-udmabuf.c | 88 + include/hw/virtio/virtio-gpu.h | 15 ++ 2 files changed, 103 insertions(+) diff

[PATCH 08/11] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-03-30 Thread Vivek Kasireddy
This API allows Qemu to register the blob allocated by the Guest as a new resource and map its backing storage. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/trace-events | 1 + hw/display/virtio-gpu-udmabuf.c | 9 +++-

[PATCH 04/11] virtio-gpu: Add virtio_gpu_find_check_resource

2021-03-30 Thread Vivek Kasireddy
Move finding the resource and validating its backing storage into one function. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu.c | 66 + 1 file changed, 47 insertions(+), 19 deletions(-) diff --git

[PATCH 06/11] virtio-gpu: Refactor virtio_gpu_create_mapping_iov

2021-03-30 Thread Vivek Kasireddy
Instead of passing the attach_backing object to extract nr_entries and offset, explicitly pass these as arguments to this function. This will be helpful when adding create_blob API. Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-3d.c | 3 ++- hw/display/virtio-gpu.c| 22

[PATCH 00/11] Add support for Blob resources feature

2021-03-30 Thread Vivek Kasireddy
Enabling this feature would eliminate data copies from the resource object in the Guest to the shadow resource in Qemu. This patch series however adds support only for Blobs of type VIRTIO_GPU_BLOB_MEM_GUEST with property VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE. Most of the patches in this series are

[PATCH 07/11] virtio-gpu: Add initial definitions for blob resources

2021-03-30 Thread Vivek Kasireddy
Add the property bit, configuration flag and other relevant macros and definitions associated with this feature. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu.c| 27 +++

[PATCH 05/11] virtio-gpu: Refactor virtio_gpu_set_scanout

2021-03-30 Thread Vivek Kasireddy
Store the meta-data associated with a FB in a new object (struct virtio_gpu_framebuffer) and pass the object to set_scanout. Also move code in set_scanout into a do_set_scanout function. This will be helpful when adding set_scanout_blob API. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek

[PATCH 03/11] virtio-gpu: Add udmabuf helpers

2021-03-30 Thread Vivek Kasireddy
Add helper functions to create a dmabuf for a resource and mmap it. To be able to create a dmabuf using the udmabuf driver, Qemu needs to be lauched with the memfd memory backend like this: qemu-system-x86_64 -m 8192m -object memory-backend-memfd,id=mem1,size=8192M -machine memory-backend=mem1

[PATCH 01/11] ui: Get the fd associated with udmabuf driver

2021-03-30 Thread Vivek Kasireddy
Try to open the udmabuf dev node for the first time or return the fd if the device was previously opened. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/console.h | 3 +++ ui/meson.build | 1 + ui/udmabuf.c | 40

[PATCH 02/11] ui/pixman: Add qemu_pixman_to_drm_format()

2021-03-30 Thread Vivek Kasireddy
This new function to get the drm_format associated with a pixman format will be useful while creating a dmabuf. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/ui/qemu-pixman.h | 1 + ui/qemu-pixman.c | 35 --- 2 files

Planning wiki page is outdated (says 5.0 is currently in development)

2021-03-30 Thread Rebecca Cran
I noticed https://wiki.qemu.org/Planning is outdated: 6.0 is listed under Planning Pages, but at the top it says 5.0 is the release that's currently in development. -- Rebecca Cran

[PATCH qemu v18] spapr: Implement Open Firmware client interface

2021-03-30 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a

[PATCH qemu] spapr: Rename RTAS_MAX_ADDR to FDT_MAX_ADDR

2021-03-30 Thread Alexey Kardashevskiy
SLOF instantiates RTAS since 744a928ccee9 ("spapr: Stop providing RTAS blob") so the max address applies to the FDT only. This renames the macro and fixes up the comment. This should not cause any behavioral change. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr.c | 8 1 file

[PATCH 2/2] target/riscv: csr: Remove redundant check in fp csr read/write routines

2021-03-30 Thread Bin Meng
The following check: if (!env->debugger && !riscv_cpu_fp_enabled(env)) { return -RISCV_EXCP_ILLEGAL_INST; } is redundant in fflags/frm/fcsr read/write routines, as the check was already done in fs(). Signed-off-by: Bin Meng --- target/riscv/csr.c | 24

[PATCH 1/2] target/riscv: csr: Fix hmode32() for RV64

2021-03-30 Thread Bin Meng
hmode32() should return -RISCV_EXCP_ILLEGAL_INST for RV64. Signed-off-by: Bin Meng --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index d2585395bf..2bad396f64 100644 --- a/target/riscv/csr.c +++

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-30 Thread David Gibson
On Thu, Mar 25, 2021 at 02:25:33PM +1100, Alexey Kardashevskiy wrote: > > > On 25/03/2021 13:52, David Gibson wrote: > > On Tue, Mar 23, 2021 at 01:58:30PM +1100, Alexey Kardashevskiy wrote: > > > The PAPR platform which describes an OS environment that's presented by > > > a combination of a

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-30 Thread David Gibson
On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: > > > On 3/29/21 12:32 PM, Cédric Le Goater wrote: > > On 3/29/21 6:20 AM, David Gibson wrote: > > > On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote: > > > > On 3/25/21 3:10 AM, David Gibson wrote: > > > >

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > On 3/29/21 10:54 PM, David Gibson wrote: > >B) Just the hflags patches from my / Richard's tree > > https://gitlab.com/dgibson/qemu/-/pipelines/278497244 > > Look closer at this one -- it's an s390x test that's

Re: [PATCH v3 2/3] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-03-30 Thread David Gibson
On Mon, Mar 29, 2021 at 02:53:47PM +0530, Shivaprasad G Bhat wrote: > > On 3/24/21 8:37 AM, David Gibson wrote: > > On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote: > > > machine vmstate. > > > > > > Signed-off-by: Shivaprasad G Bhat > > An overal question: surely the same

Re: [PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 06:48:38PM +0200, Greg Kurz wrote: > On Tue, 30 Mar 2021 15:23:50 +0530 > Ravi Bangoria wrote: > > > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > > DAWR is present, otherwise

Re: [PATCH v3 2/3] ppc: Rename current DAWR macros and variables

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 03:23:49PM +0530, Ravi Bangoria wrote: > Power10 is introducing second DAWR. Use real register names (with > suffix 0) from ISA for current macros and variables used by Qemu. > > One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel > uapi header and thus not

Re: [PATCH v2 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-30 Thread David Gibson
On Mon, Mar 29, 2021 at 07:04:24PM +0530, Ravi Bangoria wrote: > Hi David, > > > > @@ -241,6 +241,31 @@ static void spapr_dt_pa_features(SpaprMachineState > > > *spapr, > > > /* 60: NM atomic, 62: RNG */ > > > 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ > > > }; >

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: > On Wed, 24 Mar 2021 16:09:59 -0300 > Daniel Henrique Barboza wrote: > > > On 3/23/21 10:40 PM, David Gibson wrote: > > > On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: > > >> > > >> > > >> On 3/22/21

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 10:37:06PM +0530, Vaibhav Jain wrote: > > Thanks for looking into this patch Greg. My responses below inline. > > > Greg Kurz writes: > > > Hi Vaibhav, > > > > Great to see you around :-) > > :-) > > > > > On Mon, 29 Mar 2021 21:52:59 +0530 > > Vaibhav Jain wrote: >

[Bug 1921948] Re: MTE tags not checked properly for unaligned accesses at EL1

2021-03-30 Thread Peter Collingbourne
The flags that you need to pass to FVP to enable MTE are listed near the end of the README here: https://cs.android.com/android/platform/superproject/+/master:device/generic/goldfish/fvpbase/README.md -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1921948] Re: MTE tags not checked properly for unaligned accesses at EL1

2021-03-30 Thread Richard Henderson
I believe that you're correct, and that I mis-read the MTE specification. I believed that exactly one mte tag check was made for any single memory access. But I missed that unaligned accesses are as-if a sequence of byte accesses -- in the Arm ARM, see aarch64/functions/memory/Mem[]. I'm still

Re: [PATCH] target/xtensa: fix core import to meson.build

2021-03-30 Thread Max Filippov
On Tue, Mar 30, 2021 at 1:32 PM Richard Henderson wrote: > On 3/30/21 1:30 AM, Max Filippov wrote: > > -grep -q core-${NAME}.o "$BASE"/Makefile.objs || \ > > -echo "obj-y += core-${NAME}.o" >> "$BASE"/Makefile.objs > > +grep -q core-${NAME}.c "$BASE"/meson.build || \ > > +echo

[ANNOUNCE] QEMU 6.0.0-rc1 is now available

2021-03-30 Thread Michael Roth
'remotes/pmaydell/tags/pull-target-arm-20210330' into staging (Peter Maydell) 4a0ba67c77: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-03-30' into staging (Peter Maydell) b9e3f1579a: hw/timer/renesas_tmr: Add default-case asserts in read_tcnt() (Peter Maydell) f7fb73b8cd: target

Re: [PATCH] target/openrisc: fix icount handling for timer instructions

2021-03-30 Thread Stafford Horne
Hi Pavel, Thanks for the patch. On Mon, Mar 29, 2021 at 10:42:41AM +0300, Pavel Dovgalyuk wrote: > This patch adds icount handling to mfspr/mtspr instructions > that may deal with hardware timers. > > Signed-off-by: Pavel Dovgalyuk > --- > target/openrisc/translate.c | 15 +++ >

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-30 Thread Daniel Henrique Barboza
On 3/29/21 8:51 PM, Igor Mammedov wrote: On Tue, 23 Mar 2021 12:03:58 +1100 David Gibson wrote: On Fri, Mar 19, 2021 at 03:34:52PM -0300, Daniel Henrique Barboza wrote: Kernel commit 4bce545903fa ("powerpc/topology: Update topology_core_cpumask") cause a regression in the pseries machine

RE: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

2021-03-30 Thread Vince Del Vecchio
[Sorry for the resend; original seems to have been corrupted] On 11/2/20 12:27 PM, Philippe Mathieu-Daudé wrote: > The nanoMIPS ISA has been announced in 2018 for various projects: > > GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html > Linux: https://lwn.net/Articles/753605/ >

Re: [PATCH v1 6/6] tests/i386/test-i386: try and correct constrain 16 bit call (WIP)

2021-03-30 Thread Richard Henderson
On 3/30/21 2:46 PM, Peter Maydell wrote: On Tue, 30 Mar 2021 at 21:27, Richard Henderson wrote: On 3/30/21 12:20 PM, Alex Bennée wrote: Hmm actually the fedora-i386-cross image is: gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9) with CROSS_CC_GUEST_CFLAGS=-m32 so I wonder what the

Re: [PATCH v1 6/6] tests/i386/test-i386: try and correct constrain 16 bit call (WIP)

2021-03-30 Thread Peter Maydell
On Tue, 30 Mar 2021 at 21:27, Richard Henderson wrote: > > On 3/30/21 12:20 PM, Alex Bennée wrote: > > Hmm actually the fedora-i386-cross image is: > > > >gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9) > > > > with CROSS_CC_GUEST_CFLAGS=-m32 so I wonder what the difference is > > between that

Re: [PATCH] target/xtensa: fix core import to meson.build

2021-03-30 Thread Richard Henderson
On 3/30/21 1:30 AM, Max Filippov wrote: import_core.sh was not updated to change meson.build when new xtensa core is imported. Fix that. Cc: qemu-sta...@nongnu.org # v5.2.0 Signed-off-by: Max Filippov --- target/xtensa/import_core.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v1 6/6] tests/i386/test-i386: try and correct constrain 16 bit call (WIP)

2021-03-30 Thread Richard Henderson
On 3/30/21 12:20 PM, Alex Bennée wrote: Hmm actually the fedora-i386-cross image is: gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9) with CROSS_CC_GUEST_CFLAGS=-m32 so I wonder what the difference is between that and: i686-linux-gnu-gcc -m32 i686-linux-gnu-gcc --version i686-linux-gnu-gcc

Re: [RFC PATCH] docs: rst-ify the record/replay documentation

2021-03-30 Thread Richard Henderson
On 3/29/21 8:59 AM, Alex Bennée wrote: No changes to the text, just plain rst-ification of the original source text. Notably: - fixed up indentation of bullet points - proper :: escapes for code samples - added titles to paper links - moved events into a table Signed-off-by: Alex

Re: AUTIA authentication sometimes fails

2021-03-30 Thread Richard Henderson
On 3/29/21 3:04 PM, Peter Maydell wrote: On Mon, 29 Mar 2021 at 21:07, Derrick McKee wrote: Hi, I am running across a scenario where a PAC signed code pointer (using pacia) sometimes does not successfully authenticate despite the signed pointer and the salt used to sign the pointer are

[Bug 1921948] [NEW] MTE tags not checked properly for unaligned accesses at EL1

2021-03-30 Thread Andrey Konovalov
Public bug reported: For kernel memory accesses that span across two memory granules, QEMU's MTE implementation only checks the tag of the first granule but not of the second one. To reproduce this, build the Linux kernel with CONFIG_KASAN_HW_TAGS enabled, apply the patch below, and boot the

[Bug 1898490] Re: gtk with virtio and opengl black screen

2021-03-30 Thread Paul Donohue
The problem is that Xfwm's built-in compositor and virgl don't play nice together. Work-around: Boot the VM with virgl=off (on the video device) or gl=off (on the display), run xfwm4-tweaks-settings in the VM, select the "Compositor" tab, and uncheck "Enable display compositing". Then shut down

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
30.03.2021 19:39, Max Reitz wrote: On 30.03.21 15:25, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 15:51, Max Reitz wrote: On 30.03.21 12:51, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 12:49, Max Reitz wrote: On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it

Re: [PATCH V4] target/riscv: Align the data type of reset vector address

2021-03-30 Thread Alistair Francis
On Sun, Mar 28, 2021 at 11:39 PM Dylan Jhong wrote: > > Use target_ulong to instead of uint64_t on reset vector address > to adapt on both 32/64 machine. > > Signed-off-by: Dylan Jhong > Signed-off-by: Ruinland ChuanTzu Tsai Thanks! Applied to riscv-to-apply.next Alistair > --- >

Re: [PATCH v1 6/6] tests/i386/test-i386: try and correct constrain 16 bit call (WIP)

2021-03-30 Thread Alex Bennée
Hmm actually the fedora-i386-cross image is: gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9) with CROSS_CC_GUEST_CFLAGS=-m32 so I wonder what the difference is between that and: i686-linux-gnu-gcc -m32 i686-linux-gnu-gcc --version i686-linux-gnu-gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0

[PATCH v8 4/4] tests: Add tests for yank with the chardev-change case

2021-03-30 Thread Lukas Straub
Add tests for yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- MAINTAINERS| 1 + tests/unit/meson.build | 3 +- tests/unit/test-yank.c | 249 + 3 files changed, 252

[PATCH v8 3/4] chardev: Fix yank with the chardev-change case

2021-03-30 Thread Lukas Straub
When changing from chardev-socket (which supports yank) to chardev-socket again, it fails, because the new chardev attempts to register a new yank instance. This in turn fails, as there still is the yank instance from the current chardev. Also, the old chardev shouldn't unregister the yank

[PATCH v8 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new

2021-03-30 Thread Lukas Straub
Move object_property_try_add_child out of chardev_new into it's callers. This is a preparation for the next patches to fix yank with the chardev-change case. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Tested-by: Li Zhang --- chardev/char.c | 42

[PATCH v8 0/4] yank: Add chardev tests and fixes

2021-03-30 Thread Lukas Straub
Hello Everyone, These patches increase test coverage for yank, add tests and fix bugs and crashes in yank in combination with chardev-change. Please Review. Regards, Lukas Straub Changes: -v8: -test: use custom thread to accept() instead of qio_net_listener -v7: -test: fix patchew error by

Re: [PATCH] nvme: expose 'bootindex' property

2021-03-30 Thread Klaus Jensen
On Mar 22 01:24, Joelle van Dyne wrote: > The check for `n->namespace.blkconf.blk` always fails because > this is in the initialization function. > > Signed-off-by: Joelle van Dyne > --- > hw/block/nvme.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git

[PATCH v8 2/4] chardev/char.c: Always pass id to chardev_new

2021-03-30 Thread Lukas Straub
Always pass the id to chardev_new, since it is needed to register the yank instance for the chardev. Also, after checking that nothing calls chardev_new with id=NULL, assert() that id!=NULL. This fixes a crash when using chardev-change to change a chardev to chardev-socket, which attempts to

Re: [PATCH v6 0/6] coroutine rwlock downgrade fix, minor VDI changes

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 12:29:35PM +0100, Paolo Bonzini wrote: > This is a resubmit of David Edmondson's series at > https://patchew.org/QEMU/20210309144015.557477-1-david.edmond...@oracle.com/. > After closer analysis on IRC, the CoRwlock's attempt to ensure > fairness turned out to be flawed.

Re: [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
30.03.2021 20:18, Max Reitz wrote: On 30.03.21 18:47, Vladimir Sementsov-Ogievskiy wrote: 29.03.2021 16:26, Max Reitz wrote: pylint complains that discards1_sha256 and all_discards_sha256 are first set in non-__init__ methods.  Let's make it happy. Signed-off-by: Max Reitz ---  

[PATCH v2 5/8] qapi/error.py: move QAPIParseError to parser.py

2021-03-30 Thread John Snow
Keeping it in error.py will create some cyclic import problems when we add types to the QAPISchemaParser. Callers don't need to know the details of QAPIParseError unless they are parsing or dealing directly with the parser, so this won't create any harsh new requirements for callers in the general

[PATCH v2 3/8] qapi/error: Make QAPISourceError 'col' parameter optional

2021-03-30 Thread John Snow
It's already treated as optional, with some callers and subclasses passing 'None'. Make it officially optional, which requires moving the position of the argument to come after all required parameters. QAPISemError becomes functionally identical to QAPISourceError. Keep the name to preserve its

[PATCH v2 8/8] qapi/error.py: enable mypy checks

2021-03-30 Thread John Snow
Signed-off-by: John Snow --- (This can be squashed with the previous commit when staged.) Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 7797c83432..54ca4483d6 100644 ---

Re: [PULL 0/1] Linux user for 6.0 patches

2021-03-30 Thread Peter Maydell
gth is 0 (202= > 1-03-29 21:56:18 +0200) > > ---- > linux-user Pull request 20210330 > > Fix NETLINK_LIST_MEMBERSHIPS with NULL/invalid pointer and 0 length > > > > Fr=

[PATCH v2 0/8] qapi: static typing conversion, pt4

2021-03-30 Thread John Snow
Hi, this series adds static type hints to the QAPI module. This is part four, and focuses on error.py. Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 Requirements: - Python 3.6+ - mypy >= 0.770 - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) Every commit should pass

[PATCH v2 4/8] qapi/error: Change assertion

2021-03-30 Thread John Snow
Eventually, we'll be able to prove that 'info.line' must be an int and is never None at static analysis time, and this assert can go away. Until then, it's a type error to assume that self.info is not None. Signed-off-by: John Snow --- scripts/qapi/error.py | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-03-30 Thread John Snow
Rename QAPIError to QAPISourceError, and then create a new QAPIError class that serves as the basis for all of our other custom exceptions. Add docstrings to explain the intended function of each error class. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 3 ++- scripts/qapi/error.py

[PATCH v2 6/8] qapi/error.py: enable pylint checks

2021-03-30 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index fb0386d529..88efbf71cb 100644 --- a/scripts/qapi/pylintrc +++ b/scripts/qapi/pylintrc @@ -2,8 +2,7 @@ # Add files or

[PATCH v2 7/8] qapi/error: Add type hints

2021-03-30 Thread John Snow
No functional change. Signed-off-by: John Snow --- scripts/qapi/error.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/error.py b/scripts/qapi/error.py index 2183b8c6b7..6ba54821c9 100644 --- a/scripts/qapi/error.py +++ b/scripts/qapi/error.py @@

[PATCH v2 2/8] qapi/error: Use Python3-style super()

2021-03-30 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/error.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/error.py b/scripts/qapi/error.py index 126dda7c9b..38bd7c4dd6 100644 --- a/scripts/qapi/error.py +++ b/scripts/qapi/error.py @@ -19,7 +19,7 @@ class

Re: [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

2021-03-30 Thread Max Reitz
On 30.03.21 18:47, Vladimir Sementsov-Ogievskiy wrote: 29.03.2021 16:26, Max Reitz wrote: pylint complains that discards1_sha256 and all_discards_sha256 are first set in non-__init__ methods.  Let's make it happy. Signed-off-by: Max Reitz ---  

Re: [PULL 0/5] target-arm queue

2021-03-30 Thread Peter Maydell
are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git pull-target-arm-20210330 > > for you to fetch changes up to b9e3f1579a4b06fc63dfa8cdb68df1c58eeb0cf1: > > hw/timer/renesas_tmr: Add default-case asserts in

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-30 Thread Vaibhav Jain
Thanks for looking into this patch Greg. My responses below inline. Greg Kurz writes: > Hi Vaibhav, > > Great to see you around :-) :-) > > On Mon, 29 Mar 2021 21:52:59 +0530 > Vaibhav Jain wrote: > >> Add support for H_SCM_HEALTH hcall described at [1] for spapr >> nvdimms. This enables

Re: [PATCH 4/4] iotests/297: Cover tests/

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
29.03.2021 16:26, Max Reitz wrote: 297 so far does not check the named tests, which reside in the tests/ directory (i.e. full path tests/qemu-iotests/tests). Fix it. Thanks to the previous two commits, all named tests pass its scrutiny, so we do not have to add anything to SKIP_FILES.

Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
29.03.2021 16:26, Max Reitz wrote: There are a couple of things pylint takes issue with: - The "time" import is unused - The import order (iotests should come last) - get_bitmap_hash() doesn't use @self and so should be a function - Semicolons at the end of some lines Wow that's funny :) My

Re: [PATCH v6 4/6] coroutine-lock: Reimplement CoRwlock to fix downgrade bug

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 12:29:39PM +0100, Paolo Bonzini wrote: > An invariant of the current rwlock is that if multiple coroutines hold a > reader lock, all must be runnable. The unlock implementation relies on > this, choosing to wake a single coroutine when the final read lock > holder exits the

Re: [PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-30 Thread Greg Kurz
On Tue, 30 Mar 2021 15:23:50 +0530 Ravi Bangoria wrote: > As per the PAPR, bit 0 of byte 64 in pa-features property indicates > availability of 2nd DAWR registers. i.e. If this bit is set, 2nd > DAWR is present, otherwise not. Use KVM_CAP_PPC_DAWR1 capability to > find whether kvm supports 2nd

Re: [PATCH 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
29.03.2021 16:26, Max Reitz wrote: pylint complains that discards1_sha256 and all_discards_sha256 are first set in non-__init__ methods. Let's make it happy. Signed-off-by: Max Reitz --- tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [RFC PATCH 10/13] blobs: Only install s390x firmwares if s390x system target is built

2021-03-30 Thread Cornelia Huck
On Tue, 23 Mar 2021 16:51:29 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: qemu-s3...@nongnu.org > --- > meson.build | 2 ++ > pc-bios/meson.build | 9 +++-- > 2 files changed, 9 insertions(+), 2

Re: [PATCH 1/4] iotests/297: Drop 169 and 199 from the skip list

2021-03-30 Thread Vladimir Sementsov-Ogievskiy
29.03.2021 16:26, Max Reitz wrote: 169 and 199 have been renamed and moved to tests/ (commit a44be0334be: "iotests: rename and move 169 and 199 tests"), so we can drop them from the skip list. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 1/1] Remove flatview_simplify()

2021-03-30 Thread Paolo Bonzini
On 30/03/21 18:33, Richard Henderson wrote: Flatview_simplify() can merge many small memory ranges into a large one and contains EHCI dma buffers. For example,the merged range maybe0xc-0xbfff. When seabios write PAM register to change the properties of part of the merged range from RW

Re: [PATCH v4 for-6.0? 0/3] qcow2: fix parallel rewrite and discard (rw-lock)

2021-03-30 Thread Max Reitz
On 30.03.21 15:25, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 15:51, Max Reitz wrote: On 30.03.21 12:51, Vladimir Sementsov-Ogievskiy wrote: 30.03.2021 12:49, Max Reitz wrote: On 25.03.21 20:12, Vladimir Sementsov-Ogievskiy wrote: ping. Do we want it for 6.0? I’d rather wait.  I think

Re: [PATCH 1/1] Remove flatview_simplify()

2021-03-30 Thread Richard Henderson
On 3/29/21 6:14 AM, FelixCuioc wrote: Flatview_simplify() can merge many small memory ranges into a large one and contains EHCI dma buffers. For example,the merged range maybe0xc-0xbfff. When seabios write PAM register to change the properties of part of the merged range from RW to

Re: [PATCH V5] target/riscv: Align the data type of reset vector address

2021-03-30 Thread Alistair Francis
On Sun, Mar 28, 2021 at 11:48 PM Dylan Jhong wrote: > > Use target_ulong to instead of uint64_t on reset vector address > to adapt on both 32/64 machine. > > Signed-off-by: Dylan Jhong > Signed-off-by: Ruinland ChuanTzu Tsai Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c

Re: Serious doubts about Gitlab CI

2021-03-30 Thread Warner Losh
On Tue, Mar 30, 2021 at 10:11 AM Peter Maydell wrote: > On Tue, 30 Mar 2021 at 17:00, Warner Losh wrote: > > submodules have caused me significant pain in rebasing the bsd-user work. > > The way QEMU does things, you wind up with unclean trees after a build, > > which causes grief at times... I

Re: [PATCH] nsis: Install *.elf images

2021-03-30 Thread Alistair Francis
On Fri, Mar 26, 2021 at 2:22 AM Bin Meng wrote: > > As of today, the QEMU Windows installer does not include the > following two RISC-V BIOS images: > > - opensbi-riscv64-generic-fw_dynamic.elf > - opensbi-riscv32-generic-fw_dynamic.elf > > Update the installer script to include them. > >

Re: Serious doubts about Gitlab CI

2021-03-30 Thread Peter Maydell
On Tue, 30 Mar 2021 at 17:00, Warner Losh wrote: > submodules have caused me significant pain in rebasing the bsd-user work. > The way QEMU does things, you wind up with unclean trees after a build, > which causes grief at times... I for one, would shed no tears at the number of > submodules

Re: Serious doubts about Gitlab CI

2021-03-30 Thread Thomas Huth
On 30/03/2021 15.27, Daniel P. Berrangé wrote: On Tue, Mar 30, 2021 at 03:19:49PM +0200, Paolo Bonzini wrote: On 30/03/21 15:12, Daniel P. Berrangé wrote: Now, but that may change already in 6.1 in order to add CFI support. We can bundle a newer version, but we don't need to require a newer

Re: Serious doubts about Gitlab CI

2021-03-30 Thread Warner Losh
On Tue, Mar 30, 2021 at 7:33 AM Daniel P. Berrangé wrote: > The use of submodules has imposed significant pain on QEMU developers over > the years, and as such I think our general goal should be to have zero git > submodules over the long term. Usage of submodules ought to be considered > a

Re: [PATCH v1 6/6] tests/i386/test-i386: try and correct constrain 16 bit call (WIP)

2021-03-30 Thread Richard Henderson
On 3/29/21 5:03 AM, Alex Bennée wrote: Newer compilers complain about non-matching constraints: test-i386.c:1393:5: error: asm operand 2 probably doesn’t match constraints [-Werror] 1393 | asm volatile ("lcall %1, %2" | ^~~ The problem is that the newer compiler is

Re: [PATCH v3 00/12] target/hexagon: introduce idef-parser

2021-03-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210330143750.3037824-1-ale.q...@rev.ng/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210330143750.3037824-1-ale.q...@rev.ng Subject: [PATCH v3 00/12] target/hexagon:

Re: [PATCH] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting

2021-03-30 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > Commit 561dbb41b1d7 "i386: Make migration fail when Hyper-V reenlightenment > was enabled but 'user_tsc_khz' is unset" forbade migrations with when guest > has opted for reenlightenment notifications but 'tsc-frequency' wasn't set > explicitly on

Re: [PULL 0/9] Block patches for 6.0-rc1

2021-03-30 Thread Peter Maydell
On Tue, 30 Mar 2021 at 13:40, Max Reitz wrote: > > The following changes since commit ec2e6e016d24bd429792d08cf607e4c5350dcdaa: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging > (2021-03-28 19:49:57 +0100) > > are available in the Git

Re: [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 12:29:37PM +0100, Paolo Bonzini wrote: > From: David Edmondson > > Given that the block size is read from the header of the VDI file, a > wide variety of sizes might be seen. Rather than re-using a block > sized memory region when writing the VDI header, allocate an >

Re: [PATCH v6 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 12:29:38PM +0100, Paolo Bonzini wrote: > From: David Edmondson > > When taking the slow path for mutex acquisition, set the coroutine > value in the CoWaitRecord in push_waiter(), rather than both there and > in the caller. > > Reviewed-by: Paolo Bonzini > Reviewed-by:

Re: [PATCH v6 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer

2021-03-30 Thread Stefan Hajnoczi
On Thu, Mar 25, 2021 at 12:29:36PM +0100, Paolo Bonzini wrote: > From: David Edmondson > > If a new bitmap entry is allocated, requiring the entire block to be > written, avoiding leaking the buffer allocated for the block should > the write fail. > > Reviewed-by: Philippe Mathieu-Daudé >

Re: [PATCH v1 5/6] tests/tcg/i386: expand .data sections for system tests

2021-03-30 Thread Richard Henderson
On 3/29/21 5:03 AM, Alex Bennée wrote: Newer compilers might end up putting some data in .data.rel.local which was getting skipped resulting in hilarious confusion on some tests. Fix that. Signed-off-by: Alex Bennée --- tests/tcg/i386/system/kernel.ld | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v1 1/6] tests/tcg: update the defaults for x86 compilers

2021-03-30 Thread Richard Henderson
On 3/29/21 5:02 AM, Alex Bennée wrote: You don't usually notice this is broken on developer system on x86 as we use the normal host compiler. However on other systems the -pc was extraneous. Also for 32 bit only i686 packages exist now so we should use those when available. Signed-off-by: Alex

Re: [PATCH v1 2/6] tests/docker: don't set DOCKER_REGISTRY on non-x86_64

2021-03-30 Thread Richard Henderson
On 3/29/21 5:02 AM, Alex Bennée wrote: Currently our gitlab registry is x86_64 only so attempting to pull an image from it on something else will end in tears. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread Richard Henderson
On 3/29/21 10:54 PM, David Gibson wrote: B) Just the hflags patches from my / Richard's tree https://gitlab.com/dgibson/qemu/-/pipelines/278497244 Look closer at this one -- it's an s390x test that's failing: make: *** [/builds/dgibson/qemu/tests/Makefile.include:63:

Re: [PATCH v3 2/3] ppc: Rename current DAWR macros and variables

2021-03-30 Thread Greg Kurz
On Tue, 30 Mar 2021 15:23:49 +0530 Ravi Bangoria wrote: > Power10 is introducing second DAWR. Use real register names (with > suffix 0) from ISA for current macros and variables used by Qemu. > > One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel > uapi header and thus not

  1   2   3   >