[Bug 1873335] Re: Dos Keypad is not working for numbers - numlock is not working

2021-04-01 Thread promeneur
I use this qemu invocation [CODE] #!/bin/bash qemu-kvm \ -enable-kvm \ -k fr \ -m 2048 \ -smp 2 \ -cpu host \ -vga qxl \ -device usb-ehci \ -device usb-mouse \ -device usb-kbd \ -device usb-tablet \ -device ich9-intel-hda \ -device hda-duplex,audiodev=snd0 \ -audiodev pa,id=snd0 \ -device usb-hos

[Bug 1873335] Re: Dos Keypad is not working for numbers - numlock is not working

2021-04-01 Thread promeneur
I made the following experiments openSuse 15.2 kde environment qemu 4.2.1 and 5.2.0 VM: android-x86-7.1-r5 (www.android-x86.org) 1. i add a standard 102 keys PC keyboard with "-device usb-kbd" for host numlock is "on" i launch the VM for host numlock is on. We can use the numeric keypad. for g

[Bug 1922325] [NEW] s390x-virtio-gpu-ccw module unnecessary?

2021-04-01 Thread Toolybird
Public bug reported: Hi Test building latest 6.0.0 release candidate on x86_64 host. A new module has appeared: /usr/lib/qemu/hw-s390x-virtio-gpu-ccw.so Unless I'm missing something obvious, it would appear to be only useful on s390x platform. Why would I need this? For me it doesn't seem to d

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-04-01 Thread Sedat Dilek
On Thu, Feb 25, 2021 at 10:25 PM Kees Cook wrote: > > On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > > which violates clang's CFI checking because fw_cfg_showrev()'s second > > parameter is 'struct attribute',

Re: [PATCH 0/2] target/arm: Fix unaligned mte checks

2021-04-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210402053728.265173-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210402053728.265173-1-richard.hender...@linaro.org Subject: [PATCH 0/2] targe

[PATCH 2/2] target/arm: Fix unaligned mte checks

2021-04-01 Thread Richard Henderson
We were incorrectly assuming that only the first byte of an MTE access is checked against the tags. But per the ARM, unaligned accesses are pre-decomposed into single-byte accesses. So by the time we reach the actual MTE check in the ARM pseudocode, all accesses are aligned. Therefore, drop mte_

[PATCH 1/2] target/arm: Check PAGE_WRITE_ORG for MTE writeability

2021-04-01 Thread Richard Henderson
We can remove PAGE_WRITE when (internally) marking a page read-only because it contains translated code. This can be triggered by tests/tcg/aarch64/bti-2, after having serviced SIGILL trampolines on the stack. Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 2 +- 1 file changed,

[PATCH 0/2] target/arm: Fix unaligned mte checks

2021-04-01 Thread Richard Henderson
I was incorrectly assuming that only the first byte of an MTE access is checked against the tags. But per the ARM, unaligned accesses are pre-decomposed into single-byte accesses. So by the time we reach the actual MTE check in the ARM pseudocode, all accesses are aligned. There's probably more

Re: [1/1] tcg/mips: Fix SoftTLB comparison on mips backend

2021-04-01 Thread Richard Henderson
On 4/1/21 3:04 AM, Kele Huang wrote: The addrl used to compare with SoftTLB entry should be sign-extended in common case, and it will cause constant failing in SoftTLB comparisons for the addrl whose address is over 0x8000 on the emulation of 32-bit guest on 64-bit host. This is an important

Re: [PATCH v5 0/7] eBPF RSS support for virtio-net

2021-04-01 Thread Yuri Benditovich
More correctly, https://bugzilla.redhat.com/show_bug.cgi?id=1865786 On Fri, Apr 2, 2021 at 8:21 AM Yuri Benditovich wrote: > > Hi Jason, > > Yes, the work to support RSS in the Linux virtio-net driver is in progress. > https://bugzilla.redhat.com/show_bug.cgi?id=1912082 > > On Fri, Apr 2, 2021 at

Re: [PATCH v5 0/7] eBPF RSS support for virtio-net

2021-04-01 Thread Yuri Benditovich
Hi Jason, Yes, the work to support RSS in the Linux virtio-net driver is in progress. https://bugzilla.redhat.com/show_bug.cgi?id=1912082 On Fri, Apr 2, 2021 at 5:57 AM Jason Wang wrote: > > > 在 2021/3/25 下午11:35, Andrew Melnychenko 写道: > > This set of patches introduces the usage of eBPF for pa

Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP

2021-04-01 Thread Jason Wang
在 2021/3/26 下午5:18, Jason Wang 写道: ? I assume that  both src and dest started with vhost=on. As driver B supports both packed and split, you can switch from driver A to driver B after migration and driver B will work with split. Exactly as it does today. The key question is what is more impo

[Question] qemu-img convert block alignment

2021-04-01 Thread Zhenyu Ye
Hi all, commit 8dcd3c9b91 ("qemu-img: align result of is_allocated_sectors") introduces block alignment when doing qemu-img convert. However, the alignment is: s.alignment = MAX(pow2floor(s.min_sparse), DIV_ROUND_UP(out_bs->bl.request_alignment,

Re: [PATCH] hw/virtio: remove redundant code

2021-04-01 Thread Jason Wang
在 2021/4/1 下午8:58, Wentao Fan 写道: From: Fan Wentao Signed-off-by: Wentao Fan Acked-by: Jason Wang --- hw/virtio/virtio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 07f4e60b30..aa5c283102 100644 --- a/hw/virtio

Re: [PATCH 0/6] Add debug interface to kick/call on purpose

2021-04-01 Thread Jason Wang
在 2021/3/30 下午3:29, Dongli Zhang 写道: On 3/28/21 8:56 PM, Jason Wang wrote: 在 2021/3/27 上午5:16, Dongli Zhang 写道: Hi Jason, On 3/26/21 12:24 AM, Jason Wang wrote: 在 2021/3/26 下午1:44, Dongli Zhang 写道: The virtio device/driver (e.g., vhost-scsi or vhost-net) may hang due to the loss of doorbe

Re: [PATCH v5 0/7] eBPF RSS support for virtio-net

2021-04-01 Thread Jason Wang
在 2021/3/25 下午11:35, Andrew Melnychenko 写道: This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage

Re: [PATCH V2 4/6] tools/vhost-user-i2c: Add backend driver

2021-04-01 Thread Jie Deng
On 2021/4/1 20:12, Viresh Kumar wrote: + +/* vhost-user-i2c definitions */ + +#define MAX_I2C_VDEV(1 << 7) +#define MAX_I2C_ADAPTER 16 Generally speaking, 16 is big enough for most cases. But comparing with static configuration, I think it is better if we

[1/1] tcg/mips: Fix SoftTLB comparison on mips backend

2021-04-01 Thread Kele Huang
The addrl used to compare with SoftTLB entry should be sign-extended in common case, and it will cause constant failing in SoftTLB comparisons for the addrl whose address is over 0x8000 on the emulation of 32-bit guest on 64-bit host. This is an important performance bug fix. Spec2000 gzip rat

Re: [PATCH v2] hw/scsi/scsi-disk: Fix out of bounds access in mode_sense_page()

2021-04-01 Thread Alexander Bulekov
By the way, this is also triggerable from the am53c974 device.. Should I provide a reproducer patch for this one? On 210204 2350, Philippe Mathieu-Daudé wrote: > Per the "SCSI Commands Reference Manual" (Rev. J) chapter 5.3 > "Mode parameters" and table 359 "Mode page codes and subpage > codes", t

Re: [BUG FIX][PATCH v3 0/3] vhost-user-blk: fix bug on device disconnection during initialization

2021-04-01 Thread Valentin Sinitsyn
On 01.04.2021 14:21, Denis Plotnikov wrote: This is a series fixing a bug in host-user-blk. More specifically, it's not just a bug but crasher. Valentine Is there any chance for it to be considered for the next rc? Thanks! Denis On 29.03.2021 16:44, Denis Plotnikov wrote: ping! On 25.03

Re: [PULL v2 0/9] For 6.0 patches

2021-04-01 Thread Peter Maydell
On Thu, 1 Apr 2021 at 12:55, wrote: > > From: Marc-André Lureau > > The following changes since commit 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210331' > into staging (2021-03-31 13:14:18 +0100) > > are available in the Gi

Re: [RFC PATCH] block: always update auto_backing_file to full path

2021-04-01 Thread Joe Jin
Hi Max, Thanks very much for your replies. On 4/1/21 2:57 AM, Max Reitz wrote: > On 01.04.21 06:22, Joe Jin wrote: >> Some time after created snapshot, auto_backing_file only has filename, >> this confused overridden check, update it to full path if it is not. >> >> Signed-off-by: Joe Jin >> ---

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Igor Mammedov
On Thu, 01 Apr 2021 23:07:06 +0200 Vincent Bernat wrote: > ❦ 1 avril 2021 22:58 +02, Igor Mammedov: > > >> This can be invoked with: > >> > >> $QEMU -netdev user,id=internet > >> -device > >> virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \ > >>

General question about parsing an rbd filename

2021-04-01 Thread Connor Kuehl
Hi, block/rbd.c hints that: * Configuration values containing :, @, or = can be escaped with a * leading "\". Right now, much of the parsing code will allow anyone to escape _anything_ so long as it's preceded by '\'. Is this the intended behavior? Or should the parser be updated to allo

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Vincent Bernat
❦ 1 avril 2021 22:58 +02, Igor Mammedov: >> This can be invoked with: >> >> $QEMU -netdev user,id=internet >> -device >> virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \ >> -smbios type=41,designation='Onboard >> LAN',instance=1,kind=ethernet,pcid

[PATCH v2 2/2] block/rbd: Add an escape-aware strchr helper

2021-04-01 Thread Connor Kuehl
Sometimes the parser needs to further split a token it has collected from the token input stream. Right now, it does a cursory check to see if the relevant characters appear in the token to determine if it should break it down further. However, qemu_rbd_next_tok() will escape characters as it remo

[PATCH v2 1/2] iotests/231: Update expected deprecation message

2021-04-01 Thread Connor Kuehl
The deprecation message in the expected output has technically been wrong since the wrong version of a patch was applied to it. Because of this, the test fails. Correct the expected output so that it passes. Signed-off-by: Connor Kuehl Reviewed-by: Max Reitz --- Reworded the commit log and added

[PATCH v2 0/2] Fix segfault in qemu_rbd_parse_filename

2021-04-01 Thread Connor Kuehl
Replaced the change to qemu_rbd_next_tok with a standalone escape-aware helper for patch 2. Connor Kuehl (2): iotests/231: Update expected deprecation message block/rbd: Add an escape-aware strchr helper block/rbd.c| 20 ++-- tests/qemu-iotests/231 | 4 ++

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Igor Mammedov
On Thu, 1 Apr 2021 14:26:58 +0200 Vincent Bernat wrote: > Type 41 defines the attributes of devices that are onboard. The > original intent was to imply the BIOS had some level of control over > the enablement of the associated devices. > > If network devices are present in this table, by defau

[PATCH v4 1/1] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-04-01 Thread Marian Postevca
Introduces structure AcpiBuildOem to hold the value of OEM fields and uses dedicated helper functions to initialize/set the values. Unnecessary dynamically allocated OEM fields are re-factored to static allocation. Signed-off-by: Marian Postevca --- hw/acpi/hmat.h | 2 +- hw/i

[PATCH v4 0/1] Rework ACPI OEM fields handling to simplify code (was: acpi: Remove duplicated code handling OEM ID and OEM table ID fields)

2021-04-01 Thread Marian Postevca
This patch consolidates ACPI OEM fields handling by: - Moving common code in PC and MICROVM to X86. - Changes unnecessary dynamic memory allocation to static allocation - Uses dedicated structure to keep values of fields instead of two separate strings - Adds helper functions to initialize the st

Re: [1/1] tcg/mips: Fix SoftTLB comparison on mips backend

2021-04-01 Thread Philippe Mathieu-Daudé
On 4/1/21 12:04 PM, Kele Huang wrote: > The addrl used to compare with SoftTLB entry should be sign-extended > in common case, and it will cause constant failing in SoftTLB > comparisons for the addrl whose address is over 0x8000 on the > emulation of 32-bit guest on 64-bit host. Apparently mi

[qemu-web PATCH] add link to the code of conduct

2021-04-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- contribute.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contribute.md b/contribute.md index bcb048e..d7e295f 100644 --- a/contribute.md +++ b/contribute.md @@ -16,3 +16,5 @@ permalink: /contribute/ “[Contributor FAQ](https://wiki.qemu.org/Contribute

[PATCH v3 0/4] Add support for Shakti SoC from IIT-M

2021-04-01 Thread Vijai Kumar K
Changes in v3: - Drop SHAKTI_C_DEBUG register Changes in v2: - Moved CPU addition to a separate patch(P1) - Use riscv_setup_rom_resetvec API to setup reset vector - Dropped unused DPRINTF and unwanted break statements - Fixed uart_can_receive logic - Reused sifive_u_cpu_init routine for shak

[PATCH v3 3/4] hw/char: Add Shakti UART emulation

2021-04-01 Thread Vijai Kumar K
This is the initial implementation of Shakti UART. Signed-off-by: Vijai Kumar K --- MAINTAINERS | 2 + hw/char/meson.build | 1 + hw/char/shakti_uart.c | 185 ++ hw/char/trace-events | 4 + include/hw/char/shakti_

Re: [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf()

2021-04-01 Thread Philippe Mathieu-Daudé
On 4/1/21 12:51 PM, Mark Cave-Ayland wrote: > On 01/04/2021 10:34, Philippe Mathieu-Daudé wrote: >> On 4/1/21 9:49 AM, Mark Cave-Ayland wrote: >>> The const pointer returned by fifo8_pop_buf() lies directly within >>> the array used >>> to model the FIFO. Building with address sanitisers enabled sh

[PATCH v3 2/4] riscv: Add initial support for Shakti C machine

2021-04-01 Thread Vijai Kumar K
Add support for emulating Shakti reference platform based on C-class running on arty-100T board. https://gitlab.com/shaktiproject/cores/shakti-soc/-/blob/master/README.rst Signed-off-by: Vijai Kumar K --- MAINTAINERS | 7 + default-configs/devices/riscv64-softm

[PATCH v3 4/4] hw/riscv: Connect Shakti UART to Shakti platform

2021-04-01 Thread Vijai Kumar K
Connect one shakti uart to the shakti_c machine. Signed-off-by: Vijai Kumar K --- hw/riscv/shakti_c.c | 8 include/hw/riscv/shakti_c.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c index c8205d3f22..e207fa83dd 100644 --- a/hw/r

[PULL 9/9] pci: sprinkle assert in PCI pin number

2021-04-01 Thread Michael S. Tsirkin
From: Isaku Yamahata If a device model (a) doesn't set the value to a correct interrupt number and then (b) triggers an interrupt for itself, it's device model bug. Add assert on interrupt pin number to catch this kind of bug more obviously. Suggested-by: Peter Maydell Signed-off-by: Isaku Yama

[PATCH v3 1/4] target/riscv: Add Shakti C class CPU

2021-04-01 Thread Vijai Kumar K
C-Class is a member of the SHAKTI family of processors from IIT-M. It is an extremely configurable and commercial-grade 5-stage in-order core supporting the standard RV64GCSUN ISA extensions. Signed-off-by: Vijai Kumar K --- target/riscv/cpu.c | 1 + target/riscv/cpu.h | 1 + 2 files changed, 2

[PULL 6/9] acpi/piix4: reinitialize acpi PM device on reset

2021-04-01 Thread Michael S. Tsirkin
From: Isaku Yamahata Commit 6be8cf56bc8b made sure that SCI is enabled in PM1.CNT on reset in acpi_only mode by modifying acpi_pm1_cnt_reset() and that worked for q35 as expected. The function was introduced by commit eaba51c573a (acpi, acpi_piix, vt82c686: factor out PM1_CNT logic) that forgo

[PULL 7/9] vt82c686.c: don't raise SCI when PCI_INTERRUPT_PIN isn't setup

2021-04-01 Thread Michael S. Tsirkin
From: Isaku Yamahata Without this patch, the following patch will triger clan runtime sanitizer warnings as follows. This patch proactively works around it. I leave a correct fix to v582c686.c maintainerfix as I'm not sure about fuloong2e device model. > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${

Re: [PATCH 2/2] block/rbd: Don't unescape in qemu_rbd_next_tok()

2021-04-01 Thread Connor Kuehl
On 4/1/21 12:24 PM, Max Reitz wrote: On 01.04.21 17:52, Connor Kuehl wrote: That's qemu_rbd_unescape()'s job! No need to duplicate the labor. Furthermore, this was causing some confusion in the parsing logic to where the caller might test for the presence of a character to split on like so: if

[PULL 3/9] vhost-user-blk: add immediate cleanup on shutdown

2021-04-01 Thread Michael S. Tsirkin
From: Denis Plotnikov Qemu crashes on shutdown if the chardev used by vhost-user-blk has been finalized before the vhost-user-blk. This happens with char-socket chardev operating in the listening mode (server). The char-socket chardev emits "close" event at the end of finalizing when its interna

[PULL 5/9] virtio-pci: remove explicit initialization of val

2021-04-01 Thread Michael S. Tsirkin
From: Yuri Benditovich The value is assigned later in this procedure. Signed-off-by: Yuri Benditovich Message-Id: <20210315115937.14286-3-yuri.benditov...@daynix.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 7 +-- 1 file changed, 5 i

[PULL 4/9] virtio-pci: add check for vdev in virtio_pci_isr_read

2021-04-01 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1743098 This commit completes the solution of segfault in hot unplug flow (by commit ccec7e9603f446fe75c6c563ba335c00cfda6a06). Added missing check for vdev in virtio_pci_isr_read. Typical stack of crash: virtio_pci_isr_read ../hw

[PULL 8/9] isa/v582c686: Reinitialize ACPI PM device on reset

2021-04-01 Thread Michael S. Tsirkin
From: Isaku Yamahata Commit 6be8cf56bc8b made sure that SCI is enabled in PM1.CNT on reset in acpi_only mode by modifying acpi_pm1_cnt_reset() and that worked for q35 as expected. This patch adds reset ACPI PM related registers on vt82c686 reset time and de-assert sci. via_pm_realize() initializ

[PULL 1/9] vhost-user-blk: use different event handlers on initialization

2021-04-01 Thread Michael S. Tsirkin
From: Denis Plotnikov It is useful to use different connect/disconnect event handlers on device initialization and operation as seen from the further commit fixing a bug on device initialization. This patch refactors the code to make use of them: we don't rely any more on the VM state for choosi

[PULL 0/9] pc,virtio,pci: bugfixes

2021-04-01 Thread Michael S. Tsirkin
The following changes since commit 1bd16067b652cce41a9214d0c62c73d5b45ab4b1: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-31 16:38:49 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git ta

[PULL 2/9] vhost-user-blk: perform immediate cleanup if disconnect on initialization

2021-04-01 Thread Michael S. Tsirkin
From: Denis Plotnikov Commit 4bcad76f4c39 ("vhost-user-blk: delay vhost_user_blk_disconnect") introduced postponing vhost_dev cleanup aiming to eliminate qemu aborts because of connection problems with vhost-blk daemon. However, it introdues a new problem. Now, any communication errors during ex

Re: [PATCH RESEND v2 0/6] target/arm: Add nested virtualization support

2021-04-01 Thread Andrea Bolognani
On Thu, 2021-04-01 at 12:55 +, Haibo Xu wrote: > v2: > - Move the NV to a CPU feature flag(Andrea&Andrew) > - Add CPU feature 'el2' test(Andrew) > > Many thanks to Andrea and Andrew for their comments! > > This series add support for ARMv8.3/8.4 nested virtualization support > in KVM mode

Re: [PATCH v2 2/4] riscv: Add initial support for Shakti C machine

2021-04-01 Thread Vijai Kumar K
On Thu, 01 Apr 2021 22:51:42 +0530 Alistair Francis wrote > On Thu, Apr 1, 2021 at 1:18 PM Vijai Kumar K wrote: > > > > > > > > > > On Wed, 31 Mar 2021 21:05:47 +0530 Alistair Francis > > wrote > > > > > On Sun, Mar 21, 2021 at 1:09 AM Vijai Kumar K

[PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-04-01 Thread Brad Smith
OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround. Signed-off-by: Brad Smith diff --git a/util/oslib-posix.c b

Re: [PATCH 2/2] block/rbd: Don't unescape in qemu_rbd_next_tok()

2021-04-01 Thread Max Reitz
On 01.04.21 17:52, Connor Kuehl wrote: That's qemu_rbd_unescape()'s job! No need to duplicate the labor. Furthermore, this was causing some confusion in the parsing logic to where the caller might test for the presence of a character to split on like so: if (strchr(image_name, '/')) {

Re: [PATCH v2 2/4] riscv: Add initial support for Shakti C machine

2021-04-01 Thread Alistair Francis
On Thu, Apr 1, 2021 at 1:18 PM Vijai Kumar K wrote: > > > > > On Wed, 31 Mar 2021 21:05:47 +0530 Alistair Francis > wrote > > > On Sun, Mar 21, 2021 at 1:09 AM Vijai Kumar K > wrote: > > > > > > Add support for emulating Shakti reference platform based on C-class > > > running on

Re: [PATCH v2 2/4] riscv: Add initial support for Shakti C machine

2021-04-01 Thread Vijai Kumar K
On Wed, 31 Mar 2021 21:05:47 +0530 Alistair Francis wrote > On Sun, Mar 21, 2021 at 1:09 AM Vijai Kumar K wrote: > > > > Add support for emulating Shakti reference platform based on C-class > > running on arty-100T board. > > > > https://gitlab.com/shaktiproject/cores/s

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-04-01 Thread Brad Smith
On 4/1/2021 4:14 AM, Daniel P. Berrangé wrote: On Wed, Mar 31, 2021 at 03:26:16PM -0400, Brad Smith wrote: On 3/13/2021 6:33 PM, Brad Smith wrote: On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur...@

[PATCH v4] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Vincent Bernat
Type 41 defines the attributes of devices that are onboard. The original intent was to imply the BIOS had some level of control over the enablement of the associated devices. If network devices are present in this table, by default, udev will name the corresponding interfaces enoX, X being the ins

Re: [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.

2021-04-01 Thread Maxim Levitsky
On Thu, 2021-04-01 at 18:09 +0200, Paolo Bonzini wrote: > On 01/04/21 16:45, Maxim Levitsky wrote: > > + > > +for (i = 0; i < 4; i++) { > > +sregs.pdptrs[i] = env->pdptrs[i]; > > +} > > + > > +sregs.flags = 0; > > +sregs.padding = 0; > > + > > +return kvm_vcpu_ioctl(CPU(

Re: [PATCH 1/2] iotests/231: Update expected deprecation message

2021-04-01 Thread Connor Kuehl
On 4/1/21 12:07 PM, Max Reitz wrote: On 01.04.21 18:52, Max Reitz wrote: On 01.04.21 17:52, Connor Kuehl wrote: The deprecation message changed slightly at some point in the past but the expected output wasn't updated along with it; causing it to fail. Fix it, so it passes. Signed-off-by: Conn

Re: [PATCH 1/2] iotests/231: Update expected deprecation message

2021-04-01 Thread Max Reitz
On 01.04.21 18:52, Max Reitz wrote: On 01.04.21 17:52, Connor Kuehl wrote: The deprecation message changed slightly at some point in the past but the expected output wasn't updated along with it; causing it to fail. Fix it, so it passes. Signed-off-by: Connor Kuehl ---   tests/qemu-iotests/231

Re: [PATCH v3 00/11] esp: fix asserts/segfaults discovered by fuzzer

2021-04-01 Thread Alexander Bulekov
On 210401 0849, Mark Cave-Ayland wrote: > Recently there have been a number of issues raised on Launchpad as a result of > fuzzing the am53c974 (ESP) device. I spent some time over the past couple of > days checking to see if anything had improved since my last patchset: from > what I can tell the

Re: [PATCH v3 11/11] tests/qtest: add tests for am53c974 device

2021-04-01 Thread Alexander Bulekov
On 210401 0849, Mark Cave-Ayland wrote: > Use the autogenerated fuzzer test cases as the basis for a set of am53c974 > regression tests. > > Signed-off-by: Mark Cave-Ayland > --- > MAINTAINERS | 1 + > tests/qtest/am53c974-test.c | 216 > te

Re: [PATCH 1/2] iotests/231: Update expected deprecation message

2021-04-01 Thread Max Reitz
On 01.04.21 17:52, Connor Kuehl wrote: The deprecation message changed slightly at some point in the past but the expected output wasn't updated along with it; causing it to fail. Fix it, so it passes. Signed-off-by: Connor Kuehl --- tests/qemu-iotests/231.out | 4 +--- 1 file changed, 1 ins

Re: [PATCH v2 2/2] hw/smbios: retrieve PCI address from specified device for Type 41

2021-04-01 Thread Michael S. Tsirkin
On Thu, Apr 01, 2021 at 04:26:50PM +0200, Vincent Bernat wrote: > ❦ 1 avril 2021 09:59 -04, Michael S. Tsirkin: > > >> +/* > >> + * TODO: Extract the appropriate value. Most of the > >> + * time, this will be 0. > >> + */ > >> +

[PATCH v2] iotests: add test for removing persistent bitmap from backing file

2021-04-01 Thread Vladimir Sementsov-Ogievskiy
Just demonstrate one of x-blockdev-reopen usecases. We can't simply remove persistent bitmap from RO node (for example from backing file), as we need to remove it from the image too. So, we should reopen the node first. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: [by Max's review] - mor

Re: [PATCH] iotests/qsd-jobs: Filter events in the first test

2021-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2021 18:30, Max Reitz wrote: On 01.04.21 16:37, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 17:37, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 16:28, Max Reitz wrote: The job may or may not be ready before the 'quit' is issued.  Whether it is is irrelevant; for the purpose of the t

Re: [PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.

2021-04-01 Thread Paolo Bonzini
On 01/04/21 16:45, Maxim Levitsky wrote: + +for (i = 0; i < 4; i++) { +sregs.pdptrs[i] = env->pdptrs[i]; +} + +sregs.flags = 0; +sregs.padding = 0; + +return kvm_vcpu_ioctl(CPU(cpu), KVM_SET_SREGS2, &sregs); +} + This breaks when migrating from old to new kernel, bec

Re: [PULL 00/12] Misc patches for QEMU 6.0-rc2

2021-04-01 Thread Peter Maydell
On Thu, 1 Apr 2021 at 12:25, Paolo Bonzini wrote: > > The following changes since commit 6ee55e1d10c25c2f6bf5ce2084ad2327e17affa5: > > Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.0-20210331' > into staging (2021-03-31 13:14:18 +0100) > > are available in the Git repository at

Re: [PATCH for-6.0] hw/timer/renesas_tmr: Add default-case asserts in read_tcnt()

2021-04-01 Thread Yoshinori Sato
On Sat, 20 Mar 2021 01:24:58 +0900, Peter Maydell wrote: > > In commit 81b3ddaf8772ec we fixed a use of uninitialized data > in read_tcnt(). However this change wasn't enough to placate > Coverity, which is not smart enough to see that if we read a > 2 bit field and then handle cases 0, 1, 2 and 3

Re: [PATCH v3 2/2] block: Add backend_defaults property

2021-04-01 Thread Stefan Hajnoczi
On Thu, Mar 11, 2021 at 12:39:16AM +0900, Akihiko Odaki wrote: > backend_defaults property allow users to control if default block > properties should be decided with backend information. > > If it is off, any backend information will be discarded, which is > suitable if you plan to perform live m

Re: [PATCH 0/2] i386: Fix interrupt based Async PF enablement

2021-04-01 Thread Paolo Bonzini
On 01/04/21 17:19, Vitaly Kuznetsov wrote: I noticed two issues with 'kvm-asyncpf-int' enablement: 1) We forgot to add to to kvm_default_props[] so it doesn't get enabled automatically (unless '-cpu host' is used or the feature is enabled manually on the command line) 2) We forgot to disable

[PATCH 1/2] iotests/231: Update expected deprecation message

2021-04-01 Thread Connor Kuehl
The deprecation message changed slightly at some point in the past but the expected output wasn't updated along with it; causing it to fail. Fix it, so it passes. Signed-off-by: Connor Kuehl --- tests/qemu-iotests/231.out | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tes

[PATCH 2/2] block/rbd: Don't unescape in qemu_rbd_next_tok()

2021-04-01 Thread Connor Kuehl
That's qemu_rbd_unescape()'s job! No need to duplicate the labor. Furthermore, this was causing some confusion in the parsing logic to where the caller might test for the presence of a character to split on like so: if (strchr(image_name, '/')) { found_str = qemu_rbd_next_tok(image_name,

[PATCH 0/2] Fix segfault in qemu_rbd_parse_filename

2021-04-01 Thread Connor Kuehl
Connor Kuehl (2): iotests/231: Update expected deprecation message block/rbd: Don't unescape in qemu_rbd_next_tok() block/rbd.c| 3 --- tests/qemu-iotests/231 | 4 tests/qemu-iotests/231.out | 7 --- 3 files changed, 8 insertions(+), 6 deletions(-) -- 2.30.2

Re: [Virtio-fs] [PATCH] virtiofsd: Fix security.capability comparison

2021-04-01 Thread Connor Kuehl
On 4/1/21 9:58 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" My security fix for the security.capability remap has a silly early segfault in a simple case where there is an xattrmapping but it doesn't remap the securty.capability. s/securty/security Fixes: e586edcb

Re: [PATCH v3 1/2] block/file-posix: Optimize for macOS

2021-04-01 Thread Stefan Hajnoczi
On Thu, Mar 11, 2021 at 12:39:15AM +0900, Akihiko Odaki wrote: > @@ -1586,6 +1589,7 @@ out: > } > } > > +G_GNUC_UNUSED Why isn't translate_err() used in the F_PUNCHHOLE case below? If you really want to avoid using it on macOS, please add a #if with the necessary conditions here so it's c

Re: [PATCH] iotests/qsd-jobs: Filter events in the first test

2021-04-01 Thread Max Reitz
On 01.04.21 16:37, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 17:37, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 16:28, Max Reitz wrote: The job may or may not be ready before the 'quit' is issued.  Whether it is is irrelevant; for the purpose of the test, it only needs to still be there

Re: [PATCH 2/2] iotests/qsd-jobs: Use common.qemu for the QSD

2021-04-01 Thread Max Reitz
On 01.04.21 16:44, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 16:28, Max Reitz wrote: Using common.qemu allows us to wait for specific replies, so we can for example wait for events.  This allows starting the active commit job and then wait for it to be ready before quitting the QSD, so we t

[Bug 1880518] Re: issue while installing docker inside s390x container

2021-04-01 Thread Laurent Vivier
insmod/modprobe inside the container cannot load the modules because they are the one for the target architecture while the kernel is the one of the host. If you need functionalities in the container provided by some modules you need to load these modules using modprobe/insmod on the host. -- You

[RFC PATCH] block: always update auto_backing_file to full path

2021-04-01 Thread Joe Jin
Some time after created snapshot, auto_backing_file only has filename, this confused overridden check, update it to full path if it is not. Signed-off-by: Joe Jin ---  block.c | 13 +  1 file changed, 13 insertions(+) diff --git a/block.c b/block.c index c5b887cec1..8f9a027dee 100644

[PATCH 1/2] i386: Add 'kvm-asyncpf-int' to kvm_default_props array

2021-04-01 Thread Vitaly Kuznetsov
Just like all other KVM PV features, 'kvm-asyncpf-int' needs to be added to all CPU models when KVM is enabled or the feature will always remain 'off' unless specified explicitly on the command line. Signed-off-by: Vitaly Kuznetsov --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) dif

[PATCH 2/2] i386: Disable 'kvm-asyncpf-int' feature for machine types <= 5.1

2021-04-01 Thread Vitaly Kuznetsov
'kvm-asyncpf-int' was implemented in QEMU-5.2 so older machine types should have it disabled to make migration to an older QEMU which does not support this feature possible. The issue went unnoticed probably because we also forgot to add 'kvm-asyncpf-int' to 'kvm_default_props[]' so it was rarely

[PATCH v2 5/5] target/riscv: Use RISCVException enum for CSR access

2021-04-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 11 +++ target/riscv/csr.c | 37 ++--- target/riscv/gdbstub.c | 8 target/riscv/op_helper.c | 18 +- 4 files changed, 38 insertions(+), 36 deletions(-) diff --

[PATCH 0/2] i386: Fix interrupt based Async PF enablement

2021-04-01 Thread Vitaly Kuznetsov
I noticed two issues with 'kvm-asyncpf-int' enablement: 1) We forgot to add to to kvm_default_props[] so it doesn't get enabled automatically (unless '-cpu host' is used or the feature is enabled manually on the command line) 2) We forgot to disable it for older machine types to preserve migratio

[PATCH v2 0/5] RISC-V: Convert the CSR access functions to use

2021-04-01 Thread Alistair Francis
V2: - Renmae the enum - Rebase on master - Fix a few incorrect returns Alistair Francis (5): target/riscv: Convert the RISC-V exceptions to an enum target/riscv: Use the RISCVException enum for CSR predicates target/riscv: Fix 32-bit HS mode access permissions target/riscv:

[PATCH v2 2/5] target/riscv: Use the RISCVException enum for CSR predicates

2021-04-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 3 +- target/riscv/csr.c | 80 +- 2 files changed, 46 insertions(+), 37 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 0a33d387ba..1291ddc381 100644 --- a/target/riscv/c

[PATCH v2 4/5] target/riscv: Use the RISCVException enum for CSR operations

2021-04-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.h | 14 +- target/riscv/csr.c | 643 +++-- 2 files changed, 390 insertions(+), 267 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 1291ddc381..7b9b9da6b7 100644 --- a/target/risc

[PATCH v2 1/5] target/riscv: Convert the RISC-V exceptions to an enum

2021-04-01 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu_bits.h | 44 --- target/riscv/cpu.c| 2 +- target/riscv/cpu_helper.c | 4 ++-- 3 files changed, 26 insertions(+), 24 deletions(-) diff --git a/target/riscv/cpu_bits.h b/tar

[PATCH v2 3/5] target/riscv: Fix 32-bit HS mode access permissions

2021-04-01 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/csr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 5dc2aa9845..a82a98061b 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -181,7 +181,11 @@ static RISCVException

[PATCH] virtiofsd: Fix security.capability comparison

2021-04-01 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" My security fix for the security.capability remap has a silly early segfault in a simple case where there is an xattrmapping but it doesn't remap the securty.capability. Fixes: e586edcb41054 ("virtiofs: drop remapped security.capability xattr as needed") Signed-of

[PATCH 0/2] kvm: use KVM_{GET|SET}_SREGS2 when available

2021-04-01 Thread Maxim Levitsky
clone of "starship_unstable" Maxim Levitsky (2): kvm: update kernel headers for KVM_{GET|SET}_SREGS2 KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm. accel/kvm/kvm-all.c | 4 ++ include/sysemu/kvm.h| 4 ++ linux-headers/asm-x86/kvm.h | 13 + linux-headers/linux/k

[PATCH 2/2] KVM: use KVM_{GET|SET}_SREGS2 when supported by kvm.

2021-04-01 Thread Maxim Levitsky
This allows qemu to make PDPTRs be part of the migration stream and thus not reload them after a migration which is against X86 spec. Signed-off-by: Maxim Levitsky --- accel/kvm/kvm-all.c | 4 ++ include/sysemu/kvm.h | 4 ++ target/i386/cpu.h | 1 + target/i386/kvm/kvm.c | 101 +

[PATCH 1/2] kvm: update kernel headers for KVM_{GET|SET}_SREGS2

2021-04-01 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- linux-headers/asm-x86/kvm.h | 13 + linux-headers/linux/kvm.h | 5 + 2 files changed, 18 insertions(+) diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h index 8e76d3701d..8c604e6bb1 100644 --- a/linux-headers/asm-x86/kvm.h

[Bug 1922252] [NEW] [feature request] webcam support

2021-04-01 Thread promeneur
Public bug reported: Please I am impatient to get something as "-device usb-webcam" to share dynamically the webcam between host and guest. Thanks ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml,

[PATCH 0/2] gdbstub: implement support for blocking interrupts on single stepping

2021-04-01 Thread Maxim Levitsky
clone of "starship_unstable" Maxim Levitsky (2): kvm: update kernel headers for KVM_GUESTDBG_BLOCKEVENTS gdbstub: implement NOIRQ support for single step on KVM, when kvm's KVM_GUESTDBG_BLOCKIRQ debug flag is supported. accel/kvm/kvm-all.c | 25 gdbstub.c

Re: [PATCH 2/2] iotests/qsd-jobs: Use common.qemu for the QSD

2021-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2021 16:28, Max Reitz wrote: Using common.qemu allows us to wait for specific replies, so we can for example wait for events. This allows starting the active commit job and then wait for it to be ready before quitting the QSD, so we the output is always the same. (Strictly speaking, this

[PATCH 1/2] kvm: update kernel headers for KVM_GUESTDBG_BLOCKEVENTS

2021-04-01 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- linux-headers/asm-x86/kvm.h | 2 ++ linux-headers/linux/kvm.h | 1 + 2 files changed, 3 insertions(+) diff --git a/linux-headers/asm-x86/kvm.h b/linux-headers/asm-x86/kvm.h index 8e76d3701d..33878cdc34 100644 --- a/linux-headers/asm-x86/kvm.h +++ b/linux-heade

[PATCH 2/2] gdbstub: implement NOIRQ support for single step on KVM, when kvm's KVM_GUESTDBG_BLOCKIRQ debug flag is supported.

2021-04-01 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- accel/kvm/kvm-all.c | 25 +++ gdbstub.c| 59 include/sysemu/kvm.h | 13 ++ 3 files changed, 87 insertions(+), 10 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c

Re: [PATCH] iotests/qsd-jobs: Filter events in the first test

2021-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2021 17:37, Vladimir Sementsov-Ogievskiy wrote: 01.04.2021 16:28, Max Reitz wrote: The job may or may not be ready before the 'quit' is issued.  Whether it is is irrelevant; for the purpose of the test, it only needs to still be there.  Filter the job status change and READY events from th

  1   2   3   >