Re: [PATCH v2 5/8] target/riscv: Implementation of enhanced PMP (ePMP)

2021-04-10 Thread Alistair Francis
On Fri, Apr 9, 2021 at 10:33 AM Bin Meng wrote: > > Hi Alistair, > > On Fri, Apr 9, 2021 at 8:23 PM Alistair Francis > wrote: > > > > From: Hou Weiying > > > > This commit adds support for ePMP v0.9.1. > > > > The ePMP spec can be found in: > >

[PATCH] target/riscv: fix wfi exception behavior

2021-04-10 Thread Jose Martins
The wfi exception trigger behavior was not taking into account the fact that user mode is not allowed to execute wfi instructions or the effect of the hstatus.vtw bit. It was also always generating virtual instruction exceptions when this should only happen when the wfi instruction is executed

Re: [PATCH 1/1] Set TARGET_PAGE_BITS to be 10 instead of 8 bits

2021-04-10 Thread Michael Rolnik
Please review. On Tue, Mar 23, 2021 at 10:28 PM Michael Rolnik wrote: > If I set TARGET_PAGE_BITS to 12 this *assert assert(v_l2_levels >= 0);* > will fail (page_table_config_init function) because > TARGET_PHYS_ADDR_SPACE_BITS is 24 bits, because AVR has 24 is the longest > pointer AVR has. I

Re: [RFC PATCH-for-6.1 0/9] hw/clock: Strengthen machine (non-qdev) clock propagation

2021-04-10 Thread Philippe Mathieu-Daudé
+Mark & Igor On 4/10/21 5:15 PM, Peter Maydell wrote: > On Sat, 10 Apr 2021 at 14:53, Philippe Mathieu-Daudé wrote: >> On 4/10/21 3:19 PM, Luc Michel wrote: >>> Note that clock propagation during reset has always been a complicated >>> problem. Calling clock_propagate is forbidden during the

Re: [PULL 00/10] Block layer fixes for 6.0-rc3

2021-04-10 Thread Peter Maydell
On Fri, 9 Apr 2021 at 17:16, Kevin Wolf wrote: > > The following changes since commit ce69aa92d71e13db9c3702a8e8305e8d2463aeb8: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-04-08 16:45:31 +0100) > > are available in the Git repository at: > >

Re: [RFC PATCH-for-6.1 0/9] hw/clock: Strengthen machine (non-qdev) clock propagation

2021-04-10 Thread Peter Maydell
On Sat, 10 Apr 2021 at 14:53, Philippe Mathieu-Daudé wrote: > > Hi Luc, > > On 4/10/21 3:19 PM, Luc Michel wrote: > > Note that clock propagation during reset has always been a complicated > > problem. Calling clock_propagate is forbidden during the reset's enter > > phase because of the side

Re: [RFC PATCH-for-6.1 v2 6/6] hw/mips/loongson3_virt: Raise CPU clock to 2 GHz

2021-04-10 Thread Philippe Mathieu-Daudé
Hi Huacai, On 4/10/21 4:43 AM, Huacai Chen wrote: > Hi, Philippe, > > On Fri, Apr 9, 2021 at 5:36 PM Philippe Mathieu-Daudé wrote: >> >> Commit cd3a53b727d ("clock: Add clock_ns_to_ticks() function") >> removed the limitation of using clock with a frequency of 1 GHz >> or more. >> >> The

Re: [PATCH for-6.0] esp: fix setting of ESPState mig_version_id when launching QEMU with -S option

2021-04-10 Thread Philippe Mathieu-Daudé
On 4/10/21 10:31 AM, Mark Cave-Ayland wrote: > On 10/04/2021 06:56, Thomas Huth wrote: > >> On 07/04/2021 14.48, Mark Cave-Ayland wrote: >>> If QEMU is launched with the -S option then the ESPState >>> mig_version_id property >>> is left unset due to the ordering of the VMState fields in the >>>

Re: [RFC PATCH-for-6.1 0/9] hw/clock: Strengthen machine (non-qdev) clock propagation

2021-04-10 Thread Philippe Mathieu-Daudé
Hi Luc, On 4/10/21 3:19 PM, Luc Michel wrote: > On 08:23 Fri 09 Apr , Philippe Mathieu-Daudé wrote: >> I've been debugging some odd issue with the clocks: >> a clock created in the machine (IOW, not a qdev clock) isn't >> always resetted, thus propagating its value. >> "not always" is the odd

Re: [RFC PATCH-for-6.1 0/9] hw/clock: Strengthen machine (non-qdev) clock propagation

2021-04-10 Thread Luc Michel
Hi Philippe, On 08:23 Fri 09 Apr , Philippe Mathieu-Daudé wrote: > Hi Damian, Luc, Peter. > > I've been debugging some odd issue with the clocks: > a clock created in the machine (IOW, not a qdev clock) isn't > always resetted, thus propagating its value. > "not always" is the odd part. In

Re: [PATCH for-6.0 2/2] block/nbd: ensure ->connection_thread is always valid

2021-04-10 Thread Roman Kagan
On Sat, Apr 10, 2021 at 12:56:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 10.04.2021 11:38, Vladimir Sementsov-Ogievskiy wrote: > > 10.04.2021 11:06, Vladimir Sementsov-Ogievskiy wrote: > > > 09.04.2021 19:04, Roman Kagan wrote: > > > > Simplify lifetime management of

Re: Mac OS real USB device support issue

2021-04-10 Thread BALATON Zoltan
On Sat, 10 Apr 2021, Howard Spoelstra wrote: On Fri, Apr 9, 2021 at 9:37 PM Programmingkid wrote: Have you tried the proposed changes yet for libusb? Hi, Yes, I experimented with the current libusb from brew, the latest libusb code from github and a patched version based on that. I couldn't

Re: [PATCH for-6.0 2/2] block/nbd: ensure ->connection_thread is always valid

2021-04-10 Thread Vladimir Sementsov-Ogievskiy
10.04.2021 11:38, Vladimir Sementsov-Ogievskiy wrote: 10.04.2021 11:06, Vladimir Sementsov-Ogievskiy wrote: 09.04.2021 19:04, Roman Kagan wrote: Simplify lifetime management of BDRVNBDState->connection_thread by delaying the possible cleanup of it until the BDRVNBDState itself goes away. This

Re: [RFC PATCH 5/5] sockets: Support multipath TCP

2021-04-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Apr 08, 2021 at 08:11:59PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> Multipath TCP allows combining multiple interfaces/routes into a single >> socket, with very little work for the user/admin. >> >> It's enabled by

Re: gitlab-ci check-dco test

2021-04-10 Thread Philippe Mathieu-Daudé
On 4/10/21 4:58 AM, Richard Henderson wrote: > On development branches, it's not uncommon to push > temporary --fixup patches, and normally one doesn't > sign those.  But then of course one get hate-mail > from the gitlab-ci job about the failing test. > > Is there a way to make it fatal on

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-10 Thread Markus Armbruster
Greg Kurz writes: > Despite its simple name and common usage of "getting a pointer to > the machine" in system-mode emulation, qdev_get_machine() has some > subtilities. > > First, it can be called when running user-mode emulation : this is > because user-mode partly relies on qdev to

Re: [PATCH for-6.0 2/2] block/nbd: ensure ->connection_thread is always valid

2021-04-10 Thread Vladimir Sementsov-Ogievskiy
10.04.2021 11:06, Vladimir Sementsov-Ogievskiy wrote: 09.04.2021 19:04, Roman Kagan wrote: Simplify lifetime management of BDRVNBDState->connection_thread by delaying the possible cleanup of it until the BDRVNBDState itself goes away. This also fixes possible use-after-free in

Re: [PATCH for-6.0] esp: fix setting of ESPState mig_version_id when launching QEMU with -S option

2021-04-10 Thread Mark Cave-Ayland
On 10/04/2021 06:56, Thomas Huth wrote: On 07/04/2021 14.48, Mark Cave-Ayland wrote: If QEMU is launched with the -S option then the ESPState mig_version_id property is left unset due to the ordering of the VMState fields in the VMStateDescription for sysbusespscsi and pciespscsi. If the VM

[PATCH] accel/tcg: Logs num_insns in translate_block trace events.

2021-04-10 Thread Nathan Ringo
This makes it easier to figure out whether a particular instruction was actually translated. Signed-off-by: Nathan Ringo --- accel/tcg/trace-events| 2 +- accel/tcg/translate-all.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/tcg/trace-events

Re: [PATCH for-6.0 2/2] block/nbd: ensure ->connection_thread is always valid

2021-04-10 Thread Vladimir Sementsov-Ogievskiy
09.04.2021 19:04, Roman Kagan wrote: Simplify lifetime management of BDRVNBDState->connection_thread by delaying the possible cleanup of it until the BDRVNBDState itself goes away. This also fixes possible use-after-free in nbd_co_establish_connection when it races with

Re: [PATCH for-6.0 1/2] block/nbd: fix channel object leak

2021-04-10 Thread Vladimir Sementsov-Ogievskiy
09.04.2021 19:04, Roman Kagan wrote: nbd_free_connect_thread leaks the channel object if it hasn't been stolen. Unref it and fix the leak. Signed-off-by: Roman Kagan Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: Mac OS real USB device support issue

2021-04-10 Thread Howard Spoelstra
On Fri, Apr 9, 2021 at 9:37 PM Programmingkid wrote: > > > > > On Apr 7, 2021, at 1:28 AM, Howard Spoelstra wrote: > > > > On Wed, Apr 7, 2021 at 7:26 AM Howard Spoelstra wrote: > >> > >> On Wed, Apr 7, 2021 at 3:53 AM Programmingkid > >> wrote: > >>> > >>> > >>> > On Apr 6, 2021, at

Re: [PATCH 15/24] aspeed/smc: Add extra controls to request DMA

2021-04-10 Thread Cédric Le Goater
On 4/9/21 8:54 AM, Joel Stanley wrote: > On Wed, 7 Apr 2021 at 17:17, Cédric Le Goater wrote: >> >> The AST2600 SPI controllers have a set of bits to request/grant DMA >> access. Add a new SMC feature for these controllers and use it to >> check access to the DMA registers. > > Ah this is why

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-10 Thread Greg Kurz
On Fri, 9 Apr 2021 16:14:41 -0400 Eduardo Habkost wrote: > On Fri, Apr 09, 2021 at 06:03:38PM +0200, Greg Kurz wrote: > [...] > > In order to avoid further subtle breakages like this, change the > > implentation of qdev_get_machine() to: > > - keep the existing behaviour of creating the dummy

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-04-10 Thread Thomas Huth
On 07/04/2021 18.03, Daniel P. Berrangé wrote: On Wed, Apr 07, 2021 at 05:42:01PM +0200, Kevin Wolf wrote: Am 07.04.2021 um 15:35 hat Alex Bennée geschrieben: Kevin Wolf writes: Am 31.03.2021 um 17:05 hat Paolo Bonzini geschrieben: +respectful. Examples of unacceptable behavior by