Re: [RFC PATCH 4/5] ppc/pegasos2: Use Virtual Open Firmware as firmware replacement

2021-06-15 Thread Alexey Kardashevskiy
On 6/15/21 19:44, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: On 6/7/21 01:46, BALATON Zoltan wrote: The pegasos2 board comes with an Open Firmware compliant ROM based on SmartFirmware but it has some changes that are not open source therefore the ROM binary

Re: [RFC] GitLab issue tracker labeling process: arch/target, os, and accel labels

2021-06-15 Thread David Gibson
On Tue, Jun 15, 2021 at 03:56:46PM +0200, Philippe Mathieu-Daudé wrote: > On 6/15/21 4:08 AM, David Gibson wrote: > > On Mon, Jun 14, 2021 at 01:32:11PM -0400, John Snow wrote: > > In general, what's the convention when a bug is independent of (say) > > the accel: does it get none of the accel

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

2021-06-15 Thread LIU Zhiwei
On 6/13/21 6:10 PM, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道: The Core-Local Interrupt Controller (CLIC) provides low-latency, vectored, pre-emptive interrupts for RISC-V systems. The CLIC also supports a new Selective Hardware Vectoring

RE: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-15 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Tuesday, June 15, 2021 10:43 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Daniel P.Berrangé ; > Gerd Hoffmann ; Li Zhijian ; > Lukas Straub ; Zhang Chen > Subject:

Re: tb_flush() calls causing long Windows XP boot times

2021-06-15 Thread Richard Henderson
On 6/15/21 6:58 AM, Programmingkid wrote: Ahh I misread - so those are the addresses of the routines and not where it's sticking the breakpoint? I notice from a bit of googling that there is a boot debugger. I wonder if /nodebug in boot.ini stops this behaviour?

[PATCH v3 2/4] s390x/css: Split out the IRB sense data

2021-06-15 Thread Eric Farman
Let's move this logic into its own routine, so it can be reused later. Signed-off-by: Eric Farman --- hw/s390x/css.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index 8be21efb13..554c9083fd 100644 --- a/hw/s390x/css.c

[PATCH v3 4/4] s390x/css: Add passthrough IRB

2021-06-15 Thread Eric Farman
Wire in the subchannel callback for building the IRB ESW and ECW space for passthrough devices, and copy the hardware's ESW into the IRB we are building. If the hardware presented concurrent sense, then copy that sense data into the IRB's ECW space. Signed-off-by: Eric Farman ---

Re: [PULL 0/8] configure: Change to -std=gnu11

2021-06-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210616013629.1458790-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210616013629.1458790-1-richard.hender...@linaro.org Subject: [PULL 0/8]

[PATCH v3 0/4] s390x: Fix IRB sense data

2021-06-15 Thread Eric Farman
Conny, et al, Here is a (significantly larger) set of patches to address the problem with building passsthrough sense data in an IRB, using a subchannel-specific callback. The first three patches are primarily code refactoring. But, since patch 3 doesn't implement the callback for vfio-ccw

[PATCH v3 3/4] s390x/css: Refactor IRB construction

2021-06-15 Thread Eric Farman
Currently, all subchannel types have "sense data" copied into the IRB.ECW space, and a couple flags enabled in the IRB.SCSW and IRB.ESW. But for passthrough (vfio-ccw) subchannels, this data isn't populated in the first place, so enabling those flags leads to unexpected behavior if the guest tries

[PATCH v3 1/4] s390x/css: Introduce an ESW struct

2021-06-15 Thread Eric Farman
The Interrupt Response Block is comprised of several other structures concatenated together, but only the 12-byte Subchannel-Status Word (SCSW) is defined as a proper struct. Everything else is a simple array of 32-bit words. Let's define a proper struct for the 20-byte Extended-Status Word (ESW)

[PULL 8/8] configure: Remove probe for _Static_assert

2021-06-15 Thread Richard Henderson
_Static_assert is part of C11, which is now required. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id: <20210614233143.1221879-9-richard.hender...@linaro.org> --- configure | 18 -- include/qemu/compiler.h | 11

[PULL 5/8] util: Use unique type for QemuRecMutex in thread-posix.h

2021-06-15 Thread Richard Henderson
We will shortly convert lockable.h to _Generic, and we cannot have two compatible types in the same expansion. Wrap QemuMutex in a struct, and unwrap in qemu-thread-posix.c. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id:

[PULL 1/8] configure: Use -std=gnu11

2021-06-15 Thread Richard Henderson
Now that the minimum gcc version is 7.5, we can use C11. This will allow lots of cleanups to the code, currently hidden behind macros in include/qemu/compiler.h. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id:

[PULL 3/8] util: Use real functions for thread-posix QemuRecMutex

2021-06-15 Thread Richard Henderson
Move the declarations from thread-win32.h into thread.h and remove the macro redirection from thread-posix.h. This will be required by following cleanups. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id:

[PULL 6/8] include/qemu/lockable: Use _Generic instead of QEMU_GENERIC

2021-06-15 Thread Richard Henderson
This is both more and less complicated than our expansion using __builtin_choose_expr and __builtin_types_compatible_p. The expansion through QEMU_MAKE_LOCKABLE_ doesn't work because we're not emumerating all of the types within the same _Generic, which results in errors about unhandled cases.

[PULL 7/8] qemu/compiler: Remove QEMU_GENERIC

2021-06-15 Thread Richard Henderson
All previous users now use C11 _Generic. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-Id: <20210614233143.1221879-8-richard.hender...@linaro.org> --- include/qemu/compiler.h | 40 1 file changed, 40 deletions(-) diff --git

RE: [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

2021-06-15 Thread Khor, Swee Aun
Thanks for review and feedback. I shall rework those in v2. Regards, SweeAun -Original Message- From: Markus Armbruster Sent: Monday, June 14, 2021 11:01 PM To: Eric Blake Cc: Khor, Swee Aun ; Romli, Khairul Anuar ; qemu-devel@nongnu.org; Kasireddy, Vivek Subject: Re: [PATCH]

[PULL 4/8] util: Pass file+line to qemu_rec_mutex_unlock_impl

2021-06-15 Thread Richard Henderson
Create macros for file+line expansion in qemu_rec_mutex_unlock like we have for qemu_mutex_unlock. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210614233143.1221879-5-richard.hender...@linaro.org> --- include/qemu/thread.h|

[PULL 2/8] softfloat: Use _Generic instead of QEMU_GENERIC

2021-06-15 Thread Richard Henderson
Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id: <20210614233143.1221879-3-richard.hender...@linaro.org> --- fpu/softfloat.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c

[RFC PATCH v2 5/7] nvdimm: add PPC64 'device-node' property

2021-06-15 Thread Daniel Henrique Barboza
The spapr-nvdimm driver is able to operate in two ways. The first one is as a regular memory in which the NUMA node of the parent pc-dimm class is used. The second mode, as persistent memory, allows for a different NUMA node to be used based on the locality of the device. At this moment we don't

RE: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Tuesday, June 15, 2021 11:02 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan > Gilbert ; Markus Armbruster ; > Daniel P. Berrangé ; Gerd Hoffmann > ; Li Zhijian ; Zhang Chen > >

[PULL 0/8] configure: Change to -std=gnu11

2021-06-15 Thread Richard Henderson
-c11-20210615 for you to fetch changes up to c7a7cb5692690ad621b6eb2d1c7256907ff45d67: configure: Remove probe for _Static_assert (2021-06-15 18:31:00 -0700) Change to -std=gnu11. Replace QEMU_GENERIC with _Generic. Remove configure

[RFC PATCH v2 7/7] spapr: move memory/cpu less check to spapr_numa_FORM1_affinity_init()

2021-06-15 Thread Daniel Henrique Barboza
FORM2 NUMA affinity is prepared to deal with memory/cpu less NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM device that has a different latency than the original NUMA node from the regular memory. Move this verification to FORM1 affinity code. Signed-off-by: Daniel Henrique

[PATCH 21/21] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE

2021-06-15 Thread Richard Henderson
All targets now define TARGET_ARCH_HAS_SIGTRAMP_PAGE. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 4 1 file changed, 4 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 7bc67ac9cb..c0236a0b09 100644 --- a/linux-user/elfload.c +++

[RFC PATCH v2 6/7] spapr_numa, spapr_nvdimm: write secondary NUMA domain for nvdimms

2021-06-15 Thread Daniel Henrique Barboza
Using the new 'device-node' property, write it in the nvdimm DT to set a secondary domain for the persistent memory operation mode. If 'device-node' isn't set, secondary domain is equal to the primary domain. Note that this is only available in FORM2 affinity. FORM1 affinity NVDIMMs aren't

[PATCH 20/21] linux-user/xtensa: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Cc: Max Filippov Signed-off-by: Richard Henderson --- linux-user/xtensa/target_signal.h | 2 ++ linux-user/xtensa/signal.c| 50 ++- 2 files changed, 32

[RFC PATCH v2 4/7] spapr: simplify spapr_numa_associativity_init params

2021-06-15 Thread Daniel Henrique Barboza
When spapr_numa_associativity_init() was introduced it was being called from spapr_machine_init(), where we have pointers to a SpaprMachineState and a MachineState. Having both being passed as params spared us from calling a macro to get the MachineState. Previous patches moved the function away

[RFC PATCH v2 3/7] spapr_numa.c: base FORM2 NUMA affinity support

2021-06-15 Thread Daniel Henrique Barboza
The main feature of FORM2 affinity support is the separation of NUMA distances from ibm,associativity information. This allows for a more flexible and straightforward NUMA distance assignment without relying on complex associations between several levels of NUMA via ibm,associativity matches.

[RFC PATCH v2 2/7] spapr: move NUMA data init to post-CAS

2021-06-15 Thread Daniel Henrique Barboza
The pSeries machine will support a new NUMA affinity form, FORM2. This new FORM will be negotiated via ibm,architecture-vec5 during CAS. All artifacts and assumptions that are currently on use for FORM1 affinity will be deprecated in a guest that chooses to use FORM2. This means that we're going

[PATCH 18/21] linux-user/sh4: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: Yoshinori Sato Signed-off-by: Richard Henderson --- linux-user/sh4/target_signal.h | 2 ++ linux-user/sh4/signal.c| 40 +++--- 2 files changed, 24

[RFC PATCH v2 1/7] spapr_numa.c: split FORM1 code into helpers

2021-06-15 Thread Daniel Henrique Barboza
The upcoming FORM2 NUMA affinity will support asymmetric NUMA topologies and doesn't need be concerned with all the legacy support for older pseries FORM1 guests. We're also not going to calculate associativity domains based on numa distance (via spapr_numa_define_associativity_domains) since the

[PATCH 17/21] linux-user/s390x: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: qemu-s3...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/s390x/target_signal.h | 2 ++ linux-user/s390x/signal.c| 24 2 files changed, 18

[RFC PATCH v2 0/7] pSeries base FORM2 NUMA affinity support

2021-06-15 Thread Daniel Henrique Barboza
Hi, This new version contains changes made after reviews from Aneesh and David in v1. changes from v1: - patches 1 and 2: switched places - patch 3: folded into patch 2 - patch 2: * only make CAS related changes when using the newest machine version - patch 3 (former 4): * only

[PATCH 15/21] linux-user/ppc: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/ppc/target_signal.h | 2 ++ linux-user/ppc/signal.c| 34 ++ 2 files changed, 20 insertions(+), 16 deletions(-) diff --git

[PATCH 06/21] linux-user/cris: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Split out setup_sigreturn so that we can continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- linux-user/cris/target_signal.h | 2 ++ linux-user/cris/signal.c| 29

[PATCH 19/21] linux-user/sparc: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- linux-user/sparc/target_signal.h | 4 linux-user/sparc/signal.c| 32 ++-- 2 files changed, 22

[PATCH 13/21] linux-user/nios2: Document non-use of setup_sigtramp

2021-06-15 Thread Richard Henderson
Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Richard Henderson --- linux-user/nios2/target_signal.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/nios2/target_signal.h b/linux-user/nios2/target_signal.h index aebf749f12..fe266c4c51 100644 ---

[PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp

2021-06-15 Thread Richard Henderson
We cannot use a raw sigtramp page for hppa, but must wait for full vdso support. Signed-off-by: Richard Henderson --- linux-user/hppa/target_signal.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h index

[PATCH 11/21] linux-user/microblaze: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the rt signal trampoline. Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- linux-user/microblaze/target_signal.h | 2 ++ linux-user/microblaze/signal.c| 24 +--- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git

[PATCH 16/21] linux-user/riscv: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the rt signal trampoline. This fixes a bug wrt libgcc fallback unwinding. It expects the stack pointer to point to the siginfo_t, whereas we had inexplicably placed our private signal trampoline at the start of the signal frame instead of the end. Now moot because we have

[PATCH 09/21] linux-user/i386: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Note that x86_64 does not use this code. Signed-off-by: Richard Henderson --- linux-user/i386/target_signal.h | 2 ++ linux-user/x86_64/target_signal.h | 3 +++ linux-user/i386/signal.c

[PATCH 05/21] linux-user/alpha: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Use them when the guest does not use ka_restorer. Signed-off-by: Richard Henderson --- linux-user/alpha/target_signal.h | 1 + linux-user/alpha/signal.c| 34 +++- 2 files changed, 21 insertions(+), 14

[PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Taylor Simpson Signed-off-by: Richard Henderson --- linux-user/hexagon/target_signal.h | 2 ++ linux-user/hexagon/signal.c| 19 +-- 2 files changed, 19

[PATCH 10/21] linux-user/m68k: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Signed-off-by: Richard Henderson --- linux-user/m68k/target_signal.h | 2 ++ linux-user/m68k/signal.c| 47 +++-- 2 files changed, 24 insertions(+), 25 deletions(-) diff --git a/linux-user/m68k/target_signal.h

[PATCH 14/21] linux-user/openrisc: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the rt signal trampoline. Cc: Stafford Horne Signed-off-by: Richard Henderson --- linux-user/openrisc/target_signal.h | 2 ++ linux-user/openrisc/signal.c| 24 2 files changed, 18 insertions(+), 8 deletions(-) diff --git

[PATCH v4 5/6] migration/dirtyrate: move init step of calculation to main thread

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) since main thread could "query dirty rate" at any time, then it's better to move init step into main thead so that synchronization overhead of dirty stat can be reduced. since not sure whether "only one QMP iothread" will still keep true forever, always introduce a mutex

[PATCH 01/21] linux-user: Add infrastructure for a signal trampoline page

2021-06-15 Thread Richard Henderson
Allocate a page to hold the signal trampoline(s). Invoke a guest-specific hook to fill in the contents of the page before marking it read-execute again. Signed-off-by: Richard Henderson --- linux-user/qemu.h| 7 +++ linux-user/elfload.c | 17 + linux-user/signal.c | 3

[PATCH 12/21] linux-user/mips: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the two signal trampolines. Cc: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/mips/target_signal.h | 1 + linux-user/mips64/target_signal.h | 2 ++ linux-user/mips/signal.c | 39 --- 3 files changed, 28

[PATCH 00/21] linux-user: Move signal trampolines to new page

2021-06-15 Thread Richard Henderson
It is my guess that the majority of the flakiness with the linux-user signals.c test is due to a race condition between translation and page writes. I vaguely recall a bug report about this, but I cannot find it now. Since the vast majority of "self-modifying code" is due to signal delivery,

[PATCH v4 2/6] memory: make global_dirty_log a bitmask

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) dirty rate measurement may start or stop dirty logging during calculation. this conflict with migration because stop dirty log make migration leave dirty pages out then that'll be a problem. make global_dirty_log a bitmask can let both migration and dirty rate measurement

[PATCH 02/21] linux-user/aarch64: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/aarch64/target_signal.h | 2 ++ linux-user/aarch64/signal.c| 28 ++-- 2 files changed, 20

[PATCH 04/21] linux-user/arm: Implement setup_sigtramp

2021-06-15 Thread Richard Henderson
ARM is more complicated than the others, in that we also have trampolines for using SA_RESTORER with FDPIC, and we need to create trampolines for both ARM and Thumb modes. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/arm/target_signal.h | 2 +

[PATCH 03/21] linux-user/arm: Force v2 frames for fdpic

2021-06-15 Thread Richard Henderson
The value of get_os_release may be controlled by a command line option. Since fdpic was added in v4.14, and v2 frame were added in v2.6.12, this makes no change under normal conditions. Split out a helper function to perform the test. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson

[PATCH v4 0/6] support dirtyrate at the granualrity of vcpu

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) v4: - make global_dirty_log a bitmask: 1. add comments about dirty log bitmask 2. use assert statement to check validity of flags 3. add trace to log bitmask changes - introduce mode option to show what method calculation should be used, also, export mode option

[PATCH v4 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. introduce mode option in qmp calc_dirty_rate to specify what method should be used when calculating dirtyrate, either page-sampling or dirty-ring should be passed. introduce "dirty_ring:-r" option in hmp

[PATCH v4 4/6] migration/dirtyrate: adjust order of registering thread

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) registering get_dirtyrate thread in advance so that both page-sampling and dirty-ring mode can be covered. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c

[PATCH v4 1/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) dirty_pages is used to calculate dirtyrate via dirty ring, when enabled, kvm-reaper will increase the dirty pages after gfns being dirtied. kvm_dirty_ring_enabled shows if kvm-reaper is working. dirtyrate thread could use it to check if measurement can base on dirty ring

[PATCH v4 3/6] migration/dirtyrate: introduce struct and adjust DirtyRateStat

2021-06-15 Thread huangy81
From: Hyman Huang(黄勇) introduce "DirtyRateMeasureMode" to specify what method should be used to calculate dirty rate, introduce "DirtyRateVcpu" to store dirty rate fore each vcpu. use union to store stat data of specific mode Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 47

Re: [PATCH v7 0/4] Add support for ipv6 host forwarding

2021-06-15 Thread max7255
Hi! Looking good for me. Thanks for finishing this! The whole patchset also looks simpler now. On 6/15/21 2:24 PM, Doug Evans wrote: Ping. On Wed, Jun 9, 2021 at 9:41 PM Doug Evans > wrote: Ping. On Fri, May 28, 2021 at 4:53 PM Doug Evans

RE: [PATCH v2 8/8] virtio-gpu: Add gl_flushed callback

2021-06-15 Thread Kasireddy, Vivek
Hi Gerd, > > > -if (!cmd->finished) { > > +if (!cmd->finished && !(cmd->cmd_hdr.flags & VIRTIO_GPU_FLAG_FENCE)) { > > virtio_gpu_ctrl_response_nodata(g, cmd, cmd->error ? cmd->error : > > VIRTIO_GPU_RESP_OK_NODATA); > > } > > My

Re: [RFC PATCH 4/5] qmp: Added qemu-ebpf-rss-path command.

2021-06-15 Thread Andrew Melnichenko
Hi all, > Seems like this function is duplicating what glib should already be > able to do. > Yea, but it's required a Linux specific header - without it, qemu builds but crashes. Could we use a compile-time determination of where we were (supposed) > to be installed, and therefore where our

RE: [PATCH v2 2/8] ui/egl: Add egl helpers to help with synchronization

2021-06-15 Thread Kasireddy, Vivek
Hi Gerd, > > +void egl_dmabuf_create_fence(QemuDmaBuf *dmabuf) > > +{ > > +if (dmabuf->sync) { > > +dmabuf->fence_fd = eglDupNativeFenceFDANDROID(qemu_egl_display, > > + dmabuf->sync); > > +

Re: [PATCH] tests/vm/freebsd: Increase code coverage

2021-06-15 Thread Warner Losh
> On Jun 15, 2021, at 2:09 PM, Warner Losh wrote: > > > >> On Jun 15, 2021, at 10:55 AM, Philippe Mathieu-Daudé wrote: >> >> On 5/31/21 10:53 PM, Wainer dos Santos Moschetta wrote: >>> Hi, >>> >>> On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: Install more dependencies to increase

Re: [PATCH] tests/vm/freebsd: Increase code coverage

2021-06-15 Thread Warner Losh
> On Jun 15, 2021, at 10:55 AM, Philippe Mathieu-Daudé wrote: > > On 5/31/21 10:53 PM, Wainer dos Santos Moschetta wrote: >> Hi, >> >> On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: >>> Install more dependencies to increase code coverage. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>>

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-15 Thread Andrew Melnichenko
Hi, > I may miss something. > > But RSS requires to update the map. This won't work if you don't grant > any permission to qemu. > > Thanks > Partly - with "kernel.unprivileged_bpf_disabled=0" capabilities is not required to update maps. With "kernel.unprivileged_bpf_disabled=1" - setting maps

Re: [PATCH v2 3/3] docs/system: arm: Add stm32 boards description

2021-06-15 Thread Alistair Francis
On Wed, Jun 16, 2021 at 1:35 AM Alexandre Iooss wrote: > > This adds the target guide for Netduino 2, Netduino Plus 2 and > STM32VLDISCOVERY. > > Signed-off-by: Alexandre Iooss Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 1 + > docs/system/arm/stm32.rst |

Re: [RFC PATCH v2 2/2] target/ppc: make gdb able to translate priviledged addresses

2021-06-15 Thread Fabiano Rosas
Richard Henderson writes: > On 6/15/21 4:32 AM, Bruno Piazera Larsen wrote: >> On 14/06/2021 19:37, Richard Henderson wrote: >>> On 6/14/21 12:16 PM, Bruno Larsen (billionai) wrote: This patch changes ppc_cpu_get_phys_page_debug so that it is now able to translate both, priviledged and

Re: [PATCH v2 2/3] stm32vldiscovery: Add the STM32VLDISCOVERY Machine

2021-06-15 Thread Alistair Francis
On Wed, Jun 16, 2021 at 1:35 AM Alexandre Iooss wrote: > > This is a Cortex-M3 based machine. Information can be found at: > https://www.st.com/en/evaluation-tools/stm32vldiscovery.html > > Signed-off-by: Alexandre Iooss Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS

Re: [PATCH v2 1/3] stm32f100: Add the stm32f100 SoC

2021-06-15 Thread Alistair Francis
On Wed, Jun 16, 2021 at 1:35 AM Alexandre Iooss wrote: > > This SoC is similar to stm32f205 SoC. > This will be used by the STM32VLDISCOVERY to create a machine. > > Signed-off-by: Alexandre Iooss Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 6 ++ >

[PULL 34/34] block/nbd: safer transition to receiving request

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy req->receiving is a flag of request being in one concrete yield point in nbd_co_do_receive_one_chunk(). Such kind of boolean flag is always better to unset before scheduling the coroutine, to avoid double scheduling. So, let's be more careful. Signed-off-by:

[PULL 33/34] block/nbd: add nbd_client_connected() helper

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We already have two similar helpers for other state. Let's add another one for convenience. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20210610100802.5888-32-vsement...@virtuozzo.com> Signed-off-by: Eric Blake ---

[PULL 29/34] block-coroutine-wrapper: allow non bdrv_ prefix

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We are going to reuse the script to generate a nbd_ function in further commit. Prepare the script now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20210610100802.5888-28-vsement...@virtuozzo.com> Signed-off-by: Eric

Re: [PULL 1/9] yank: Unregister function when using TLS migration

2021-06-15 Thread Leonardo Brás
On Mon, 2021-06-14 at 07:14 +0200, Philippe Mathieu-Daudé wrote: > Hi Leonardo, > > On 6/9/21 4:45 PM, Dr. David Alan Gilbert (git) wrote: > > From: Leonardo Bras > > > > After yank feature was introduced in migration, whenever migration > > is started using TLS, the following error happens in

[PULL 32/34] block/nbd: reuse nbd_co_do_establish_connection() in nbd_open()

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy The only last step we need to reuse the function is coroutine-wrapper. nbd_open() may be called from non-coroutine context. So, generate the wrapper and use it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

[PULL 26/34] block/nbd: don't touch s->sioc in nbd_teardown_connection()

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Negotiation during reconnect is now done in a thread, and s->sioc is not available during negotiation. Negotiation in thread will be cancelled by nbd_client_connection_release() called from nbd_clear_bdrvstate(). So, we don't need this code chunk anymore.

Re: [PATCH v6 cxl2.0-v6-doe 4/6] cxl/compliance: CXL Compliance Data Object Exchange implementation

2021-06-15 Thread Jonathan Cameron
On Thu, 10 Jun 2021 09:16:20 -0400 Chris Browy wrote: > From: hchkuo > > The Data Object Exchange implementation of CXL Compliance Mode is > referring to "Compute Express Link (CXL) Specification, Rev. 2.0, Oct. > 2020". > > The data structure of CXL compliance request and response is added

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-15 Thread BALATON Zoltan
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of

[PULL 24/34] block/nbd: split nbd_handle_updated_info out of nbd_client_handshake()

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy To be reused in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Roman Kagan Reviewed-by: Eric Blake Message-Id: <20210610100802.5888-23-vsement...@virtuozzo.com> Signed-off-by: Eric Blake --- block/nbd.c | 112

[PULL 19/34] nbd: move connection code from block/nbd to nbd/client-connection

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We now have bs-independent connection API, which consists of four functions: nbd_client_connection_new() nbd_client_connection_release() nbd_co_establish_connection() nbd_co_establish_connection_cancel() Move them to a separate file together with

[PULL 23/34] nbd/client-connection: shutdown connection on release

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Now, when a thread can do negotiation and retry, it may run relatively long. We need a mechanism to stop it, when the user is not interested in a result any more. So, on nbd_client_connection_release() let's shutdown the socket, and do not retry connection if

[PULL 30/34] block/nbd: split nbd_co_do_establish_connection out of nbd_reconnect_attempt

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Split out the part that we want to reuse for nbd_open(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210610100802.5888-29-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- block/nbd.c | 82

[PULL 31/34] nbd/client-connection: add option for non-blocking connection attempt

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We'll need a possibility of non-blocking nbd_co_establish_connection(), so that it returns immediately, and it returns success only if a connections was previously established in background. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[PULL 16/34] block/nbd: rename NBDConnectThread to NBDClientConnection

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We are going to move the connection code to its own file, and want clear names and APIs first. The structure is shared between user and (possibly) several runs of connect-thread. So it's wrong to call it "thread". Let's rename to something more generic.

[PULL 21/34] nbd/client-connection: add possibility of negotiation

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Add arguments and logic to support nbd negotiation in the same thread after successful connection. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210610100802.5888-20-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake

[PULL 25/34] block/nbd: use negotiation of NBDClientConnection

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Now that we can opt in to negotiation as part of the client connection thread, use that to simplify connection_co. This is another step on the way to moving all reconnect code into NBDClientConnection. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

[PULL 28/34] nbd/client-connection: return only one io channel

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy block/nbd doesn't need underlying sioc channel anymore. So, we can update nbd/client-connection interface to return only one top-most io channel, which is more straight forward. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

[PULL 15/34] block/nbd: make nbd_co_establish_connection_cancel() bs-independent

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy nbd_co_establish_connection_cancel() actually needs only pointer to NBDConnectThread. So, make it clean. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Roman Kagan Reviewed-by: Eric Blake Message-Id:

[PULL 13/34] block/nbd: drop thr->state

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We don't need all these states. The code refactored to use two boolean variables looks simpler. While moving the comment in nbd_co_establish_connection() rework it to give better information. Also, we are going to move the connection code to separate file and

[PULL 27/34] block/nbd: drop BDRVNBDState::sioc

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Currently sioc pointer is used just to pass from socket-connection to nbd negotiation. Drop the field, and use local variables instead. With next commit we'll update nbd/client-connection.c to behave appropriately (return only top-most ioc, not two channels).

[PULL 22/34] nbd/client-connection: implement connection retry

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Add an option for a thread to retry connecting until it succeeds. We'll use nbd/client-connection both for reconnect and for initial connection in nbd_open(), so we need a possibility to use same NBDClientConnection instance to connect once in nbd_open() and

[PULL 06/34] block/nbd: connect_thread_func(): do qio_channel_set_delay(false)

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy nbd_open() does it (through nbd_establish_connection()). Actually we lost that call on reconnect path in 1dc4718d849e1a1fe "block/nbd: use non-blocking connect: fix vm hang on connect()" when we have introduced reconnect thread. Fixes:

[PULL 20/34] nbd/client-connection: use QEMU_LOCK_GUARD

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We don't update connect_thread_func() to use QEMU_LOCK_GUARD, as it will get more complex critical sections logic in further commit, where QEMU_LOCK_GUARD doesn't help. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:

[PULL 18/34] block/nbd: introduce nbd_client_connection_release()

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy This is a last step of creating bs-independent nbd connection interface. With next commit we can finally move it to separate file. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210610100802.5888-17-vsement...@virtuozzo.com> Reviewed-by: Eric

[PULL 05/34] block/nbd: fix how state is cleared on nbd_open() failure paths

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy We have two "return error" paths in nbd_open() after nbd_process_options(). Actually we should call nbd_clear_bdrvstate() on these paths. Interesting that nbd_process_options() calls nbd_clear_bdrvstate() by itself. Let's fix leaks and refactor things to be

[PULL 11/34] block/nbd: BDRVNBDState: drop unused connect_err and connect_status

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy These fields are write-only. Drop them. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Roman Kagan Reviewed-by: Eric Blake Message-Id: <20210610100802.5888-10-vsement...@virtuozzo.com> Signed-off-by: Eric Blake --- block/nbd.c | 12 ++--

[PULL 17/34] block/nbd: introduce nbd_client_connection_new()

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy This is a step of creating bs-independent nbd connection interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Roman Kagan Reviewed-by: Eric Blake Message-Id: <20210610100802.5888-16-vsement...@virtuozzo.com> Signed-off-by: Eric Blake ---

[PULL 09/34] block/nbd: ensure ->connection_thread is always valid

2021-06-15 Thread Eric Blake
From: Roman Kagan Simplify lifetime management of BDRVNBDState->connect_thread by delaying the possible cleanup of it until the BDRVNBDState itself goes away. This also reverts 0267101af6 "block/nbd: fix possible use after free of s->connect_thread" as now s->connect_thread can't be cleared

[PULL 08/34] block/nbd: call socket_address_parse_named_fd() in advance

2021-06-15 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Detecting monitor by current coroutine works bad when we are not in coroutine context. And that's exactly so in nbd reconnect code, where qio_channel_socket_connect_sync() is called from thread. Monitor is needed only to parse named file descriptor. So, let's

[PULL 02/34] tests: cover aio_co_enter from a worker thread without BQL taken

2021-06-15 Thread Eric Blake
From: Paolo Bonzini Add a testcase for the test fixed by commit 'async: the main AioContext is only "current" if under the BQL. Signed-off-by: Paolo Bonzini Message-Id: <20210614110214.726722-1-pbonz...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy

  1   2   3   4   5   >