Re: [PATCH v3 2/3] target/ppc: change ppc_hash32_xlate to use mmu_idx

2021-06-25 Thread Richard Henderson
On 6/24/21 1:21 PM, Bruno Larsen (billionai) wrote: -static int ppc_hash32_pte_prot(PowerPCCPU *cpu, +static int ppc_hash32_pte_prot(PowerPCCPU *cpu, int mmu_idx, target_ulong sr, ppc_hash_pte32_t pte) { -CPUPPCState *env = >env; unsigned pp, key;

Re: [PATCH v3 3/3] target/ppc: changed ppc_hash64_xlate to use mmu_idx

2021-06-25 Thread Richard Henderson
On 6/24/21 1:21 PM, Bruno Larsen (billionai) wrote: /* Check Basic Storage Protection */ -static int ppc_hash64_pte_prot(PowerPCCPU *cpu, +static int ppc_hash64_pte_prot(PowerPCCPU *cpu, int mmu_idx, ppc_slb_t *slb, ppc_hash_pte64_t pte) { -CPUPPCState

Re: [PATCH v2 1/1] tcg: Use correct trap number for page faults on *BSD systems

2021-06-25 Thread Richard Henderson
On 6/24/21 9:57 PM, Warner Losh wrote: The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe is used by Linux and represents the intel hardware trap vector. The BSD kernels, however, translate this to T_PAGEFLT in their Xpage, Xtrap0e, Xtrap14, etc fault handlers. This is

Re: [PATCH v4 00/16] tcg/s390x: host vector support

2021-06-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210626050307.2408505-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210626050307.2408505-1-richard.hender...@linaro.org Subject: [PATCH v4

[PATCH v4 15/16] tcg/s390x: Implement TCG_TARGET_HAS_bitsel_vec

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 1 + tcg/s390x/tcg-target.h | 2 +- tcg/s390x/tcg-target.c.inc | 20 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target-con-set.h

[PATCH v4 16/16] tcg/s390x: Implement TCG_TARGET_HAS_cmpsel_vec

2021-06-25 Thread Richard Henderson
This is via expansion; don't actually set TCG_TARGET_HAS_cmpsel_vec. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index

[PATCH v4 08/16] tcg/s390x: Implement minimal vector operations

2021-06-25 Thread Richard Henderson
Implementing add, sub, and, or, xor as the minimal set. This allows us to actually enable vectors in query_s390_facilities. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 154 - 1 file changed, 150 insertions(+), 4 deletions(-) diff --git

[PATCH v4 12/16] tcg/s390x: Implement TCG_TARGET_HAS_minmax_vec

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.h | 2 +- tcg/s390x/tcg-target.c.inc | 25 + 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h index 8dce6af5af..275f980cee 100644 ---

[PATCH v4 09/16] tcg/s390x: Implement andc, orc, abs, neg, not vector operations

2021-06-25 Thread Richard Henderson
These logical and arithmetic operations are optional but trivial. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 1 + tcg/s390x/tcg-target.h | 10 +- tcg/s390x/tcg-target.c.inc | 34 +- 3 files changed, 39

[PATCH v4 10/16] tcg/s390x: Implement TCG_TARGET_HAS_mul_vec

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.h | 2 +- tcg/s390x/tcg-target.c.inc | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h index a3d4b5111f..cb14a011c7 100644 --- a/tcg/s390x/tcg-target.h +++

[PATCH v4 13/16] tcg: Expand usadd/ussub with umin/umax

2021-06-25 Thread Richard Henderson
For usadd, we only have to consider overflow. Since ~B + B == -1, the maximum value for A that saturates is ~B. For ussub, we only have to consider underflow. The minimum value that saturates to 0 from A - B is B. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 37

[PATCH v4 04/16] tcg/s390x: Add host vector framework

2021-06-25 Thread Richard Henderson
Add registers and function stubs. The functionality is disabled via squashing s390_facilities[2] to 0. We must still include results for the mandatory opcodes in tcg_target_op_def, as all opcodes are checked during tcg init. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h

[PATCH v4 11/16] tcg/s390x: Implement vector shift operations

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target-con-set.h | 1 + tcg/s390x/tcg-target.h | 12 ++--- tcg/s390x/tcg-target.c.inc | 93 +- 3 files changed, 99 insertions(+), 7 deletions(-) diff --git a/tcg/s390x/tcg-target-con-set.h

[PATCH v4 05/16] tcg/s390x: Implement tcg_out_ld/st for vector types

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 122 + 1 file changed, 110 insertions(+), 12 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 18233c628d..b6ea129e14 100644 ---

[PATCH v4 14/16] tcg/s390x: Implement TCG_TARGET_HAS_sat_vec

2021-06-25 Thread Richard Henderson
The unsigned saturations are handled via generic code using min/max. The signed saturations are expanded using double-sized arithmetic and a saturating pack. Since all operations are done via expansion, do not actually set TCG_TARGET_HAS_sat_vec. Signed-off-by: Richard Henderson ---

[PATCH v4 07/16] tcg/s390x: Implement tcg_out_dup*_vec

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 122 - 1 file changed, 119 insertions(+), 3 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index c4e12a57f3..76216eb5bc 100644 ---

[PATCH v4 03/16] tcg/s390x: Merge TCG_AREG0 and TCG_REG_CALL_STACK into TCGReg

2021-06-25 Thread Richard Henderson
They are rightly values in the same enumeration. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.h | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/tcg/s390x/tcg-target.h b/tcg/s390x/tcg-target.h index

[PATCH v4 06/16] tcg/s390x: Implement tcg_out_mov for vector types

2021-06-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 72 +++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index b6ea129e14..c4e12a57f3 100644 --- a/tcg/s390x/tcg-target.c.inc

[PATCH v4 01/16] tcg/s390x: Rename from tcg/s390

2021-06-25 Thread Richard Henderson
This emphasizes that we don't support s390, only 64-bit s390x hosts. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- meson.build | 2 -- tcg/{s390 => s390x}/tcg-target-con-set.h | 0 tcg/{s390 => s390x}/tcg-target-con-str.h | 0 tcg/{s390 =>

[PATCH v4 00/16] tcg/s390x: host vector support

2021-06-25 Thread Richard Henderson
Changes for v4: * Fix bug in RXB (david). r~ Richard Henderson (16): tcg/s390x: Rename from tcg/s390 tcg/s390x: Change FACILITY representation tcg/s390x: Merge TCG_AREG0 and TCG_REG_CALL_STACK into TCGReg tcg/s390x: Add host vector framework tcg/s390x: Implement tcg_out_ld/st for

[PATCH v4 02/16] tcg/s390x: Change FACILITY representation

2021-06-25 Thread Richard Henderson
We will shortly need to be able to check facilities beyond the first 64. Instead of explicitly masking against s390_facilities, create a HAVE_FACILITY macro that indexes an array. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- v2: Change name to HAVE_FACILITY (david) ---

[Bug 1437970] Re: qemu-system-x86_64 - two mouse pointers & fast scrolling problem

2021-06-25 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1437970 Title:

Re: [RFC PATCH 0/9] hw/sd: Allow card size not power of 2 again

2021-06-25 Thread Alexander Bulekov
On 210624 1012, Philippe Mathieu-Daudé wrote: > On 6/24/21 4:50 AM, Alexander Bulekov wrote: > > On 210623 2000, Philippe Mathieu-Daudé wrote: > >> Hi Ubi-Wan Kenubi and Tom, > >> > >> In commit a9bcedd (SD card size has to be power of 2) we decided > >> to restrict SD card size to avoid security

Re: [PATCH 0/5] tcg: Add 32-bit vector operations

2021-06-25 Thread Richard Henderson
On 6/24/21 3:50 AM, LIU Zhiwei wrote: This patch set is split from RISC-V Packed extension where needs some i32 vector operations, accorind to Richard Henderson's suggestion. The original implementation is on https://www.mail-archive.com/qemu-devel@nongnu.org/msg814538.html. LIU Zhiwei (5):

Re: [RFC PATCH 06/10] hw/sd: Add sd_cmd_unimplemented() handler

2021-06-25 Thread Bin Meng
On Sat, Jun 26, 2021 at 1:17 AM Philippe Mathieu-Daudé wrote: > > On 6/25/21 3:49 PM, Bin Meng wrote: > > On Thu, Jun 24, 2021 at 10:28 PM Philippe Mathieu-Daudé > > wrote: > >> > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> hw/sd/sd.c | 21 - > >> 1 file

Re: Qemu on Haiku

2021-06-25 Thread Warner Losh
On Fri, Jun 25, 2021 at 8:45 PM Richard Zak wrote: > Hello and thanks for the detailed response! I wasn't aware that a Linux > host could compile for Haiku as a target, that's interesting. > > Seems like the big tasks are: > 1) Haiku VM for continuous integration. Is this hosted in Amazon or

Re: Qemu on Haiku

2021-06-25 Thread Richard Zak
Hello and thanks for the detailed response! I wasn't aware that a Linux host could compile for Haiku as a target, that's interesting. Seems like the big tasks are: 1) Haiku VM for continuous integration. Is this hosted in Amazon or other cloud infrastructure? 2) Supporting aspects of the qemu

Re: [PATCH 1/1] target/arm: Check NaN mode before silencing NaN

2021-06-25 Thread Richard Henderson
On 6/25/21 4:02 PM, Joe Komlodi wrote: If the CPU is running in default NaN mode (FPCR.DN == 1) and we execute FRSQRTE, FRECPE, or FRECPX with a signaling NaN, parts_silence_nan_frac() will assert due to fpst->default_nan_mode being set. To avoid this, we check to see what NaN mode we're

Re: Guidance on emulating "sparse" address spaces

2021-06-25 Thread Richard Henderson
On 6/23/21 5:53 PM, Jason Thorpe wrote: Thanks for the pointer! Yes, it seems like that might be similar to what I need... create new address spaces (rather than using the "system" address space) for the PCI memory and I/O regions (I need to do this for PCI configuration space, too,

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-25 Thread Richard Henderson
On 6/23/21 7:50 AM, Ulrich Weigand wrote: @@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, uint32_t m34) { int old_mode = s390_swap_bfp_rounding_mode(env, round_from_m34(m34)); int64_t ret = float32_to_int64(v2, >fpu_status); +env->cc_op =

[PATCH v1 QEMU CXL modifications for openspdm 1/1] pcie/spdm: PCIe CMA implementation

2021-06-25 Thread Chris Browy
From: hchkuo The Data Object Exchange implementation of Component Measurement and Authentication (CMA). This patch is basically based on Openspdm: https://github.com/jyao1/openspdm.git. Openspdm is an emulator composed of an SPDM requester and an SPDM responder. The requester and responder

[PATCH v1 QEMU CXL modifications for openspdm 0/1] Testing PCIe DOE in QEMU CXL/PCIe Device using openspdm

2021-06-25 Thread Chris Browy
This patch series provides an implementation of the the Data Object Exchange (DOE) for Component Measurement and Authentication (CMA) of the Security Protocol and Data Model (SPDM). This patch is based on [1] [PATCH v1 openspdm on QEMU CXL/PCIe Device 0/2] Testing PCIe DOE in QEMU CXL/PCIe

[PATCH v1 openspdm on QEMU CXL/PCIe Device 2/2] requester: Modified for QEMU emulation

2021-06-25 Thread Chris Browy
From: hchkuo The requester should be used as a PCIe app to access the SPDM object in the PCEe device. Signed-off-by: Chris Browy --- Include/IndustryStandard/PciDoeBinding.h| 27 +++ SpdmEmu/SpdmEmuCommon/SpdmEmu.c | 85 ++

[PATCH v1 openspdm on QEMU CXL/PCIe Device 1/2] build: gcc to CC in GNUMakefile

2021-06-25 Thread Chris Browy
From: hchkuo Modified gcc to CC in GNUMakefile, so that we can specify the gcc version Signed-off-by: Chris Browy --- GNUmakefile.Flags | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GNUmakefile.Flags b/GNUmakefile.Flags index 3586284..33baceb 100644 ---

Re: [PATCH v5 13/14] target/hexagon: import additional tests

2021-06-25 Thread Taylor Simpson
On Sat, Jun 19, 2021 at 4:49 AM Alessandro Di Federico via < qemu-devel@nongnu.org> wrote: > From: Niccolò Izzo > > Signed-off-by: Alessandro Di Federico > Signed-off-by: Niccolò Izzo > --- > > diff --git a/tests/tcg/hexagon/crt.S b/tests/tcg/hexagon/crt.S > new file mode 100644 > index

[PATCH v1 openspdm on QEMU CXL/PCIe Device 0/2] Testing PCIe DOE in QEMU CXL/PCIe Device using openspdm

2021-06-25 Thread Chris Browy
This patch series provides an implementation of the the Data Object Exchange (DOE) for Component Measurement and Authentication (CMA) of the Security Protocol and Data Model (SPDM). This patch is based on [1] Openspdm: https://github.com/jyao1/openspdm.git Openspdm is an emulator composed of

[PATCH 1/1] target/arm: Check NaN mode before silencing NaN

2021-06-25 Thread Joe Komlodi
If the CPU is running in default NaN mode (FPCR.DN == 1) and we execute FRSQRTE, FRECPE, or FRECPX with a signaling NaN, parts_silence_nan_frac() will assert due to fpst->default_nan_mode being set. To avoid this, we check to see what NaN mode we're running in before we call

[PATCH 0/1] target/arm: Check NaN mode before silencing NaN

2021-06-25 Thread Joe Komlodi
Hi all, This fixes an assertion that occurs when executing FRSQRTE, FRECPE, or FRECPX on a signaling NaN when the CPU has default NaN mode enabled. When attempting to silence the NaN, we hit an assertion that ensures that the CPU FPU status does not have default_nan_mode set. To avoid this, we

Re: [PATCH v5 12/14] target/hexagon: remove unused macros and functions

2021-06-25 Thread Taylor Simpson
Don't do this. Keeping these around makes it easy to fall back to the helper implementations for debugging. Also, some of them are needed for future HVX support. Thanks, Taylor On Sat, Jun 19, 2021 at 4:48 AM Alessandro Di Federico via < qemu-devel@nongnu.org> wrote: > From: Paolo Montesel >

RE: [PATCH v5 11/14] target/hexagon: call idef-parser functions

2021-06-25 Thread Taylor Simpson
> -Original Message- > From: Alessandro Di Federico > Sent: Saturday, June 19, 2021 3:37 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain > ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: [PATCH v5

[PATCH v3] Add basic power management to raspi.

2021-06-25 Thread Nolan Leake
This is just enough to make reboot and poweroff work. Works for linux, u-boot, and the arm trusted firmware. Not tested, but should work for plan9, and bare-metal/hobby OSes, since they seem to generally do what linux does for reset. The watchdog timer functionality is not yet implemented.

Re: [PATCH v4 05/22] tests/docker: remove FEATURES env var from templates

2021-06-25 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 11:23 AM Daniel P. Berrangé wrote: > > In preparation for switching to auto-generated dockerfiles, remove the > FEATURES env variable. The equivalent functionality can be achieved in > most cases by just looking for existance of a binary. s/existance/existence/ > > The

Re: [PATCH v4 03/22] tests/docker: use project specific container registries

2021-06-25 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 11:23 AM Daniel P. Berrangé wrote: > > Since Docker Hub has started to enforce pull rate limits on clients, it > is preferrable to use project specific container registries where they s/preferrable/preferable/ > are available. Fedora and OpenSUSE projects provide

Re: [PATCH v4 02/22] tests/docker: don't use BUILDKIT in GitLab either

2021-06-25 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 11:23 AM Daniel P. Berrangé wrote: > > Using BUILDKIT breaks with certain container registries such as CentOS, > with docker build reporting an error such as > > failed to solve with frontend dockerfile.v0: > failed to build LLB: failed to load cache key: >

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
On 6/25/21 3:01 PM, Willian Rampazzo wrote: On Fri, Jun 25, 2021 at 3:38 PM John Snow wrote: On 6/25/21 2:36 PM, Willian Rampazzo wrote: Maybe, it may confuse people using `make check-venv` under `tests`. Anyway, I'm not opposed to it. Reviewed-by: Willian Rampazzo I have to admit there's

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 3:38 PM John Snow wrote: > > On 6/25/21 2:36 PM, Willian Rampazzo wrote: > > Maybe, it may confuse people using `make check-venv` under `tests`. > > Anyway, I'm not opposed to it. > > > > Reviewed-by: Willian Rampazzo > > I have to admit there's much about Python packaging

Re: [PATCH v2 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-25 Thread Keith Busch
On Thu, Jun 17, 2021 at 09:06:46PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > This series reimplements flush, dsm, copy, zone reset and format nvm to > allow cancellation. I posted an RFC back in March ("hw/block/nvme: > convert ad-hoc aio tracking to aiocb") and I've applied some

Re: [PATCH 11/11] python: remove auto-generated pyproject.toml file

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > For reasons that at-present escape me, pipenv insists on creating a stub > pyproject.toml file. This file is a nuisance, because its mere presence > changes the behavior of various tools. > > For instance, this stub file will cause "pip

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
On 6/25/21 2:36 PM, Willian Rampazzo wrote: Maybe, it may confuse people using `make check-venv` under `tests`. Anyway, I'm not opposed to it. Reviewed-by: Willian Rampazzo I have to admit there's much about Python packaging that is confusing :) Can you elaborate on your point for me,

Re: [PULL 0/7] misc fixes (docs, plugins, tests)

2021-06-25 Thread Peter Maydell
On Fri, 25 Jun 2021 at 10:14, Alex Bennée wrote: > > A few miscellaneous fixes > > - tweak tcg/kvm based GIC tests > - add header to MTTCG docs > - cleanup checkpatch handling > - GitLab feature and bug request templates >

Re: [PATCH 10/11] python: Update help text on 'make clean', 'make distclean'

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > Just for visual parity with everything else. > > Signed-off-by: John Snow > --- > python/Makefile | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 09/11] python: Update help text on 'make check', 'make develop'

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > Update for visual parity with the other targets. > > Signed-off-by: John Snow > --- > python/Makefile | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > This is a *third* way to run the Python tests. Unlike the first two > (check-pipenv, check-tox), this version does not require any specific > interpreter version -- making it a lot easier to tell people to run it > as a quick smoketest prior

Re: [PATCH 05/11] python: Add no-install usage instructions

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > It's not encouraged, but it's legitimate to want to know how to do. > > Signed-off-by: John Snow > --- > python/README.rst | 28 > 1 file changed, 28 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH 07/11] python: update help text for check-tox

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > Move it up near the check-pipenv help text, and update it to suggest parity. > > (At the time I first added it, I wasn't sure if I would be keeping it, > but I've come to appreciate it as it has actually helped uncover bugs I > would not have

Re: [PATCH 04/11] python: README.rst touchups

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > Clarifying a few points; removing the reference to 'setuptools' because > it referenced anywhere else in this document and doesn't really provide > any useful information to a Python newcomer. > > Adjusting the language elsewhere to be less

Re: [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv'

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > Well, Cleber was right, this is a better name. > > In preparation for adding a different kind of virtual environment check > (One that simply uses whichever version of Python you happen to have), > rename this test 'check-pipenv' so that it

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > tox is already testing the most recent versions. Let's use pipenv to > test the oldest versions we claim to support. This matches the stylistic > choice to have pipenv always test our oldest supported Python version, 3.6. > > The effect of

[PATCH 10/10] python: Add iotest linters to test suite

2021-06-25 Thread John Snow
As a convenience, since iotests is an extremely prominent user of the qemu.qmp and qemu.machine packages and already implements a linting regime, run those tests as well so that it's very hard to miss regressions caused by changes to the python library. Signed-off-by: John Snow ---

Re: [PATCH 04/11] python: README.rst touchups

2021-06-25 Thread John Snow
On 6/25/21 2:23 PM, Willian Rampazzo wrote: On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: Clarifying a few points; removing the reference to 'setuptools' because it referenced anywhere else in this document and doesn't really provide ^ isn't Noticed the typo when adding your RB.

[PATCH 02/10] iotests/297: Add get_files() function

2021-06-25 Thread John Snow
Split out file discovery into its own method to begin separating out the "environment setup" and "test execution" phases. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/297

[PATCH 09/10] iotests/linters: Add entry point for Python CI linters

2021-06-25 Thread John Snow
Add a main() function to linters.py so that the Python CI infrastructure has something it can run. Now, linters.py represents an invocation of the linting scripts that more resembles a "normal" execution of pylint/mypy, like you'd expect to use if 'qemu' was a bona-fide package you obtained from

[PATCH 07/10] iotests/297: return error code from run_linters()

2021-06-25 Thread John Snow
This turns run_linters() into a bit of a hybrid test; returning non-zero on failed execution while also printing diffable information. This is done for the benefit of the avocado simple test runner, which will soon be attempting to execute this test from a different environment. (Note:

[PATCH 08/10] iotests/297: split linters.py off from 297

2021-06-25 Thread John Snow
Split the linter execution itself out from 297, leaving just environment setup in 297. This is done so that non-iotest code can invoke the linters without needing to worry about imports of unpackaged iotest code. Eventually, it should be possible to replace linters.py with mypy.ini and pylintrc

[PATCH 05/10] iotests/297: Separate environment setup from test execution

2021-06-25 Thread John Snow
Move environment setup into main(), leaving pure test execution behind in run_linters(). Signed-off-by: John Snow --- tests/qemu-iotests/297 | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297

[PATCH 01/10] iotests/297: modify is_python_file to work from any CWD

2021-06-25 Thread John Snow
Add a directory argument to is_python_file to allow it to work correctly no matter what CWD we happen to run it from. This is done in anticipation of running the iotests from another directory (./python/). Signed-off-by: John Snow --- tests/qemu-iotests/297 | 8 +--- 1 file changed, 5

[PATCH 00/10] python/iotests: Run iotest linters during Python CI

2021-06-25 Thread John Snow
Based-on: <20210625154540.783306-1-js...@redhat.com> GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest CI: https://gitlab.com/jsnow/qemu/-/pipelines/327413868 Since iotests are such a heavy and prominent user of the Python qemu.qmp and qemu.machine packages, it would be

[PATCH 03/10] iotests/297: Don't rely on distro-specific linter binaries

2021-06-25 Thread John Snow
'pylint-3' is another Fedora-ism. Use "python3 -m pylint" or "python3 -m mypy" to access these scripts instead. This style of invocation will prefer the "correct" tool when run in a virtual environment. Note that we still check for "pylint-3" before the test begins -- this check is now "overly

[PATCH 04/10] iotests/297: Create main() function

2021-06-25 Thread John Snow
Instead of running "run_linters" directly, create a main() function that will be responsible for environment setup, leaving run_linters() responsible only for execution of the linters. (That environment setup will be moved over in forthcoming commits.) Signed-off-by: John Snow ---

[PATCH 06/10] iotests/297: Add 'directory' argument to run_linters

2021-06-25 Thread John Snow
Allow run_linters to work well if it's executed from a different directory. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index c7428af901..1e8334d1d4 100755 --- a/tests/qemu-iotests/297

Re: [PATCH 02/11] python: Remove global pylint suppressions

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > These suppressions only apply to a small handful of places. Instead of > disabling them globally, disable them just in the cases where we > need. The design of the machine class grew quite organically with tons > of constructor and class

Re: [PATCH 01/11] python: expose typing information via PEP 561

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 12:46 PM John Snow wrote: > > https://www.python.org/dev/peps/pep-0561/#specification > > Create 'py.typed' files in each subpackage that indicate to mypy that > this is a typed module, so that users of any of these packages can use > mypy to check their code as well. > >

Re: [PATCH v4 01/22] hw/usb/ccid: remove references to NSS

2021-06-25 Thread Willian Rampazzo
On Wed, Jun 23, 2021 at 11:23 AM Daniel P. Berrangé wrote: > > The NSS package was previously pre-requisite for building CCID related > features, however, this became obsolete when the libcacard library was > spun off to a separate project: > > commit 7b02f5447c64d1854468f758398c9f6fe9e5721f

Re: [RFC PATCH] tcg/plugins: enable by default for TCG builds

2021-06-25 Thread Willian Rampazzo
On Fri, Jun 25, 2021 at 8:27 AM Alex Bennée wrote: > > Aside from a minor bloat to file size the ability to have TCG plugins > has no real impact on performance unless a plugin is actively loaded. > Even then the libempty.so plugin shows only a minor degradation in > performance caused by the

Re: [PULL 0/7] riscv-to-apply queue

2021-06-25 Thread Peter Maydell
On Thu, 24 Jun 2021 at 13:02, Alistair Francis wrote: > > The following changes since commit d0ac9a61474cf594d19082bc8976247e984ea9a3: > > Merge remote-tracking branch > 'remotes/thuth-gitlab/tags/pull-request-2021-06-21' into staging (2021-06-24 > 09:31:26 +0100) > > are available in the Git

[PATCH 2/3] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-06-25 Thread Daniel P . Berrangé
This adds support for running 4 jobs via Cirrus CI runners: * FreeBSD 12 * FreeBSD 13 * macOS 11 with default XCode * macOS 11 with latest XCode The gitlab job uses a container published by the libvirt-ci project (https://gitlab.com/libvirt/libvirt-ci) that contains the 'cirrus-run' command.

[PATCH 3/3] cirrus: delete FreeBSD and macOS jobs

2021-06-25 Thread Daniel P . Berrangé
The builds for these two platforms can now be performed from GitLab CI using cirrus-run. Signed-off-by: Daniel P. Berrangé --- .cirrus.yml | 55 - 1 file changed, 55 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH 0/3] ci: use cirrus-run to utilize Cirrus CI from GitLab CI

2021-06-25 Thread Daniel P . Berrangé
Currently the Cirrus CI pipelines are completely separate from the GitLab CI pipelines. This means contributors/maintainers have to monitor two distinct places. This series uses the 'cirrus-run' tool from within a GitLab CI job to invoke a Cirrus CI job. Effectively Cirrus CI becomes a custom

[PATCH 1/3] build: validate that system capstone works before using it

2021-06-25 Thread Daniel P . Berrangé
Some versions of capstone have shipped a broken pkg-config file which puts the -I path without the trailing '/capstone' suffix. This breaks the ability to "#include ". Upstream and most distros have fixed this, but a few stragglers remain, notably FreeBSD. Signed-off-by: Daniel P. Berrangé ---

Re: [PATCH 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines)

2021-06-25 Thread Philippe Mathieu-Daudé
On 6/25/21 6:37 PM, Mark Cave-Ayland wrote: > On 25/06/2021 08:38, Mark Cave-Ayland wrote: > >> I noticed whilst testing the previous dp8393x patchset that I would >> always >> get a segfault whilst attempting to migrate the MIPS magnum machine. >> >> A bit of detective work shows that the

Re: [PATCH RFC 4/6] i386/pc: Keep PCI 64-bit hole within usable IOVA space

2021-06-25 Thread Joao Martins
On 6/23/21 5:33 PM, Laszlo Ersek wrote: > Adding Marcel and Dave. > > Adding Alex (seriously, a vfio- / iommu-related patch set without Alex on CC?) > > comments below > > On 06/23/21 14:30, Igor Mammedov wrote: >> On Tue, 22 Jun 2021 16:49:03 +0100 >> Joao Martins wrote: >> >>> pci_memory

Re: [RFC PATCH 06/10] hw/sd: Add sd_cmd_unimplemented() handler

2021-06-25 Thread Philippe Mathieu-Daudé
On 6/25/21 3:49 PM, Bin Meng wrote: > On Thu, Jun 24, 2021 at 10:28 PM Philippe Mathieu-Daudé > wrote: >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/sd.c | 21 - >> 1 file changed, 12 insertions(+), 9 deletions(-) >> qemu_log_mask(LOG_GUEST_ERROR, "SD:

Re: [PATCH v2 2/2] g364fb: add VMStateDescription for G364SysBusState

2021-06-25 Thread Philippe Mathieu-Daudé
On 6/25/21 6:35 PM, Mark Cave-Ayland wrote: > Currently when QEMU attempts to migrate the MIPS magnum machine it crashes due > to a mistake in the g364fb VMStateDescription configuration which expects a > G364SysBusState and not a G364State. > > Resolve the issue by adding a new

tests: ReverseDebugging_AArch64.test_aarch64_virt -> InvalidPacketError

2021-06-25 Thread Philippe Mathieu-Daudé
Hi Pavel, FYI as of commit 050cee12315 ("Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-updates-250621-1' into staging") the ReverseDebugging_AArch64 test is failing: (28/37) tests/acceptance/reverse_debugging.py:ReverseDebugging_AArch64.test_aarch64_virt: ERROR (0.96 s) INFO

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-25 Thread Joao Martins
On 6/23/21 8:27 PM, Alex Williamson wrote: > On Wed, 23 Jun 2021 10:30:29 +0100 > Joao Martins wrote: > >> On 6/22/21 10:16 PM, Alex Williamson wrote: >>> On Tue, 22 Jun 2021 16:48:59 +0100 >>> Joao Martins wrote: >>> Hey, This series lets Qemu properly spawn i386 guests

Re: [PATCH 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines)

2021-06-25 Thread Mark Cave-Ayland
On 25/06/2021 08:38, Mark Cave-Ayland wrote: I noticed whilst testing the previous dp8393x patchset that I would always get a segfault whilst attempting to migrate the MIPS magnum machine. A bit of detective work shows that the problem is an incorrect VMStateDescription in the g364fb device

[PATCH v2 2/2] g364fb: add VMStateDescription for G364SysBusState

2021-06-25 Thread Mark Cave-Ayland
Currently when QEMU attempts to migrate the MIPS magnum machine it crashes due to a mistake in the g364fb VMStateDescription configuration which expects a G364SysBusState and not a G364State. Resolve the issue by adding a new VMStateDescription for G364SysBusState and embedding the existing

[PATCH v2 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines)

2021-06-25 Thread Mark Cave-Ayland
I noticed whilst testing the previous dp8393x patchset that I would always get a segfault whilst attempting to migrate the MIPS magnum machine. A bit of detective work shows that the problem is an incorrect VMStateDescription in the g364fb device which expects a G364State but instead receives a

[PATCH v2 1/2] g364fb: use RAM memory region for framebuffer

2021-06-25 Thread Mark Cave-Ayland
Since the migration stream is already broken, we can use this opportunity to change the framebuffer so that it is migrated as a RAM memory region rather than as an array of bytes. In particular this helps the output of the analyze-migration.py tool which no longer contains a huge array

Re: [PATCH] tests/migration: fix unix socket migration

2021-06-25 Thread Hyman
在 2021/4/29 1:26, Wainer dos Santos Moschetta 写道: Cleber, Maybe you could review then queue this one? Ping it seems that this patch has been left out :) - Wainer On 4/20/21 10:16 PM, Hyman Huang wrote: 在 2021/3/10 0:55, Philippe Mathieu-Daudé 写道: On 3/9/21 5:00 PM,

Re: [PULL 0/1] Block patch

2021-06-25 Thread Peter Maydell
On Thu, 24 Jun 2021 at 12:43, Max Reitz wrote: > > The following changes since commit b22726abdfa54592d6ad88f65b0297c0e8b363e2: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.1-pull-request' into staging > (2021-06-22 16:07:53 +0100) > > are available in the Git

[PATCH 08/11] python: add 'make check-venv' invocation

2021-06-25 Thread John Snow
This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to GitLab CI. Summary: Checked via GitLab

[PATCH 10/11] python: Update help text on 'make clean', 'make distclean'

2021-06-25 Thread John Snow
Just for visual parity with everything else. Signed-off-by: John Snow --- python/Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/python/Makefile b/python/Makefile index 4ed37c29f0..06f78f760a 100644 --- a/python/Makefile +++ b/python/Makefile @@ -37,11

[PATCH 05/11] python: Add no-install usage instructions

2021-06-25 Thread John Snow
It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow --- python/README.rst | 28 1 file changed, 28 insertions(+) diff --git a/python/README.rst b/python/README.rst index 107786ffdc..d4502fdb60 100644 --- a/python/README.rst

[PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv'

2021-06-25 Thread John Snow
Well, Cleber was right, this is a better name. In preparation for adding a different kind of virtual environment check (One that simply uses whichever version of Python you happen to have), rename this test 'check-pipenv' so that it matches the CI job 'check-python-pipenv'. Remove the "If you

[PATCH 11/11] python: remove auto-generated pyproject.toml file

2021-06-25 Thread John Snow
For reasons that at-present escape me, pipenv insists on creating a stub pyproject.toml file. This file is a nuisance, because its mere presence changes the behavior of various tools. For instance, this stub file will cause "pip install --user -e ." to fail in spectacular fashion with misleading

[PATCH 07/11] python: update help text for check-tox

2021-06-25 Thread John Snow
Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without it. It should stay.) Signed-off-by: John Snow

[PATCH 01/11] python: expose typing information via PEP 561

2021-06-25 Thread John Snow
https://www.python.org/dev/peps/pep-0561/#specification Create 'py.typed' files in each subpackage that indicate to mypy that this is a typed module, so that users of any of these packages can use mypy to check their code as well. Note: Theoretically it's possible to ditch MANIFEST.in in favor

[PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

2021-06-25 Thread John Snow
tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. The effect of this is that the python-check-pipenv CI job on gitlab will now

[PATCH 04/11] python: README.rst touchups

2021-06-25 Thread John Snow
Clarifying a few points; removing the reference to 'setuptools' because it referenced anywhere else in this document and doesn't really provide any useful information to a Python newcomer. Adjusting the language elsewhere to be less ambiguous and have fewer run-on sentences. Signed-off-by: John

  1   2   3   4   >