Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-15 Thread Christian Borntraeger
On 12.07.21 14:26, Alex Bennée wrote: Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation in performance caused by the extra book keeping the T

Re: [PULL 00/23] pc,pci,virtio: lots of new features

2021-07-15 Thread Peter Maydell
On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote: > > On Wed, Jul 14, 2021 at 09:31:21PM +0100, Peter Maydell wrote: > > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 708f50199b59476ec4b45ebcdf171550086d6292: > > > > > > Merg

RE: [PATCH v2] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-15 Thread Wang, Wei W
On Thursday, July 15, 2021 5:29 PM, David Hildenbrand wrote: > On 15.07.21 09:53, Wei Wang wrote: > > When skipping free pages to send, their corresponding dirty bits in > > the memory region dirty bitmap need to be cleared. Otherwise the > > skipped pages will be sent in the next round after the m

[Bug 1926996] Re: qemu-user clone syscall fails

2021-07-15 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926996 Title: qemu-user c

Re: About two-dimensional page translation (e.g., Intel EPT) and shadow page table in Linux QEMU/KVM

2021-07-15 Thread harry harry
Hi Sean, Thanks for the explanations. Please see my comments below. Thanks! > When TDP (EPT) is used, the > hardware MMU has two parts: the TDP PTEs that are controlled by KVM, and the > IA32 > PTEs that are controlled by the guest. And there's still a KVM MMU for the > guest; > the KVM MMU i

Re: About two-dimensional page translation (e.g., Intel EPT) and shadow page table in Linux QEMU/KVM

2021-07-15 Thread Sean Christopherson
On Thu, Jul 15, 2021, harry harry wrote: > Hi Sean, > > > No, each vCPU has its own MMU instance, where an "MMU instance" is (mostly) > > a KVM > > construct. Per-vCPU MMU instances are necessary because each vCPU has its > > own > > relevant state, e.g. CR0, CR4, EFER, etc..., that affects the

[PATCH v3 0/2] SIGSEGV fixes

2021-07-15 Thread Taylor Simpson
The Hexagon target was silently failing the SIGSEGV test because the signal handler was not called. Patch 1/2 fixes the Hexagon target Patch 2/2 adds a check that the signal handler is called Changes in v2 Address feedback from Richard Henderson - Replace put_user_* with cpu_st*_data_r

[PATCH v3 1/2] Hexagon (target/hexagon) remove put_user_*/get_user_*

2021-07-15 Thread Taylor Simpson
Replace put_user_* with cpu_st*_data_ra Replace get_user_* with cpu_ld*_data_ra Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/target/hexag

[PATCH v3 2/2] linux-test (tests/tcg/multiarch/linux-test.c) add check

2021-07-15 Thread Taylor Simpson
Add a check that the SIGSEGV handler is called Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- tests/tcg/multiarch/linux-test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index c8c6aed..e2d88f8

Re: [PULL 00/23] pc,pci,virtio: lots of new features

2021-07-15 Thread Michael S. Tsirkin
On Wed, Jul 14, 2021 at 09:31:21PM +0100, Peter Maydell wrote: > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: > > > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' > > into

Re: [PATCH v3 0/3] support dirtyrate measurement with dirty bitmap

2021-07-15 Thread Peter Xu
On Thu, Jul 15, 2021 at 11:51:30PM +0800, huang...@chinatelecom.cn wrote: > Hyman Huang(黄勇) (3): > KVM: introduce kvm_get_manual_dirty_log_protect > memory: introduce DirtyRateDirtyPages and util function > migration/dirtyrate: implement dirty-bitmap dirtyrate calculation > > accel/kvm/kvm-

Re: [PATCH v3 3/3] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

2021-07-15 Thread Peter Xu
On Thu, Jul 15, 2021 at 11:51:33PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > introduce dirty-bitmap mode as the third method of calc-dirty-rate. > implement dirty-bitmap dirtyrate calculation, which can be used > to measuring dirtyrate in the absence of dirty-ring. > > i

Re: [PATCH v5 0/2] cocoa: keyboard quality of life

2021-07-15 Thread Programmingkid
> From: Gustavo Noronha Silva > > v5 addresses the casting issue pointed out by Akihiko Odaki. > Sorry it took me so long to update the patches, but here > they are! Hopefully we can get them in now ;D > > Btw I also changed my email address slightly (.dev.br > instead of .eti.br). > > -

Re: [PULL 04/11] i386: expand Hyper-V features during CPU feature expansion time

2021-07-15 Thread Peter Maydell
On Tue, 13 Jul 2021 at 17:19, Eduardo Habkost wrote: > > From: Vitaly Kuznetsov > > To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we > need to expand and set the corresponding CPUID leaves early. Modify > x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V

Re: [PATCH v3 2/3] memory: introduce DirtyRateDirtyPages and util function

2021-07-15 Thread Peter Xu
On Thu, Jul 15, 2021 at 11:51:32PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > introduce DirtyRateDirtyPages and use it to the dirty pages > along with memory_global_dirty_log_sync. > introduce cpu_physical_memory_dirtyrate_reset_protect to > clear dirty bitmap within slot

Re: [PULL v2 00/26] Crypto and more patches

2021-07-15 Thread Peter Maydell
On Wed, 14 Jul 2021 at 15:12, Daniel P. Berrangé wrote: > > The following changes since commit 4aa2454d94cca99d86aa32e71bd7c8159df91c59: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-07-14 > 12:00:56 +0100) > > are available in the Git r

Re: [PATCH] hw/net/net_tx_pkt: Fix crash detected by fuzzer

2021-07-15 Thread Philippe Mathieu-Daudé
On 7/15/21 9:32 PM, Thomas Huth wrote: > QEMU currently crashes when it's started like this: > > cat << EOF | ./qemu-system-i386 -device vmxnet3 -nodefaults -qtest stdio > outl 0xcf8 0x80001014 > outl 0xcfc 0xe0001000 > outl 0xcf8 0x80001018 > outl 0xcf8 0x80001004 > outw 0xcfc 0x7 > outl 0xcf8 0x

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
03.07.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: +Permission bytes. If permission byte is rd-locked, it means that some process +uses corresponding permission on that file. + +ByteOperation +100 read + Lock holder can read +101 write + Lock holder can write +102

[PATCH] hw/net/net_tx_pkt: Fix crash detected by fuzzer

2021-07-15 Thread Thomas Huth
QEMU currently crashes when it's started like this: cat << EOF | ./qemu-system-i386 -device vmxnet3 -nodefaults -qtest stdio outl 0xcf8 0x80001014 outl 0xcfc 0xe0001000 outl 0xcf8 0x80001018 outl 0xcf8 0x80001004 outw 0xcfc 0x7 outl 0xcf8 0x80001083 write 0x0 0x1 0xe1 write 0x1 0x1 0xfe write 0x2

Re: [PATCH 0/1] target/arm: Check NaN mode before silencing NaN

2021-07-15 Thread Peter Maydell
On Mon, 28 Jun 2021 at 16:05, Richard Henderson wrote: > > On 6/28/21 7:54 AM, Peter Maydell wrote: > > Richard, Alex: what is the assertion trying to achieve ? It doesn't > > seem entirely obvious to me that because we're in default-NaN mode > > (which is a property of the *output* of FPU insns)

Re: Question on memory commit during MR finalize()

2021-07-15 Thread Peter Xu
On Thu, Jul 15, 2021 at 02:27:48PM +, Thanos Makatos wrote: > Hi Peter, Hi, Thanos, > We're hitting this issue using a QEMU branch where JJ is using vfio-user as > the transport for multiprocess-qemu > (https://github.com/oracle/qemu/issues/9). We can reproduce it fairly > reliably by migr

Re: [PATCH] target/arm: Remove duplicate 'plus1' function from Neon and SVE decode

2021-07-15 Thread Philippe Mathieu-Daudé
On 7/15/21 11:53 AM, Peter Maydell wrote: > The Neon and SVE decoders use private 'plus1' functions to implement > "add one" for the !function decoder syntax. We have a generic > "plus_1" function in translate.h, so use that instead. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-ls.d

Re: [PULL v5 00/44] testing, build and plugin updates

2021-07-15 Thread Peter Maydell
On Wed, 14 Jul 2021 at 16:00, Alex Bennée wrote: > > The following changes since commit 4aa2454d94cca99d86aa32e71bd7c8159df91c59: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/x86-next-pull-request' into staging (2021-07-14 > 12:00:56 +0100) > > are available in the Git reposito

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-15 Thread Daniel P . Berrangé
On Thu, Jul 15, 2021 at 08:13:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 03.07.2021 17:50, Nir Soffer wrote: > > On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy > > wrote: > > [..] > > > > + > > > +Important notice: Qemu may fallback to POSIX file locks only if OFD locks > > >

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
03.07.2021 17:50, Nir Soffer wrote: On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy wrote: [..] + +Important notice: Qemu may fallback to POSIX file locks only if OFD locks +unavailable. Other programs should behave similarly: use POSIX file locks +only if OFD locks unavailable a

[PATCH 0/2] Misc pegasos2 fixes

2021-07-15 Thread BALATON Zoltan
Some misc fixes that suppress a spurious warning and allows pegasos2 firmware version 1.2 (another version available on line) to work with the board emulation. BALATON Zoltan (2): ppc/pegasos2: Fix spurious warning with -bios i2c/smbus_eeprom: Add feature bit to SPD data hw/i2c/smbus_eeprom.

[PATCH 2/2] i2c/smbus_eeprom: Add feature bit to SPD data

2021-07-15 Thread BALATON Zoltan
Add the differential clock input feature bit to the generated SPD data. Most guests don't seem to care but pegasos2 firmware version 1.2 checks for this bit and stops with unsupported module type error if it's not present. Since this feature is likely present on real memory modules add it in the ge

[PATCH 1/2] ppc/pegasos2: Fix spurious warning with -bios

2021-07-15 Thread BALATON Zoltan
The -append option is currently not compatible with -bios (as we don't yet emulate nvram so we can only put it in the environment with VOF). Therefore a warning is printed if -append is used with -bios but because the default value of kernel_cmdline seems to be an empty string instead of NULL this

Re: QEMU System and User targets

2021-07-15 Thread Kenneth Adam Miller
Oh I didn't know that there was a i386_user_ss in order to see that it was intended that they were shared that way, so I initially thought that i386_ss was user only until I saw it in the build. On Thu, Jul 15, 2021 at 11:35 AM Peter Maydell wrote: > On Thu, 15 Jul 2021 at 17:25, Kenneth Adam Mi

Re: QEMU System and User targets

2021-07-15 Thread Peter Maydell
On Thu, 15 Jul 2021 at 17:25, Kenneth Adam Miller wrote: > > Well certainly, I know they are different executables. I'm just trying to > understand how the different targets work. > > By subsumes, I mean that just looking at the meson.build for i386, you can > see that there are files added to t

Re: QEMU System and User targets

2021-07-15 Thread Kenneth Adam Miller
Well certainly, I know they are different executables. I'm just trying to understand how the different targets work. By subsumes, I mean that just looking at the meson.build for i386, you can see that there are files added to the i386_ss, but not visibly added to the softmmu target. But the softmm

Re: QEMU System and User targets

2021-07-15 Thread Peter Maydell
On Thu, 15 Jul 2021 at 16:59, Kenneth Adam Miller wrote: > > If I am right, the softmmu/system build target for each architecture subsumes > the source of the user target. I'm not sure what you mean by "subsumes" here. Some code in QEMU is compiled into both the system and usermode emulators (eg

Re: [PATCH 00/17] target/riscv: Use tcg_constant_*

2021-07-15 Thread Richard Henderson
On 7/15/21 4:21 AM, LIU Zhiwei wrote: Also on a side note, could you give me some advice for the following question? I have been supporting  running 32bit application on qemu-riscv64. After this patch set, it is hard to define a  method,  such as gpr_dst_s or gpr_dst_u, to extend the destinati

Re: [PATCH] block/vvfat: fix: drop backing

2021-07-15 Thread Programmingkid
> On Jul 15, 2021, at 8:48 AM, Vladimir Sementsov-Ogievskiy > wrote: > > Most probably this fake backing child doesn't work anyway (see notes > about it in a8a4d15c1c34d). > > Still, since 25f78d9e2de528473d52 drivers are required to set > .supports_backing if they want to call bdrv_set_back

QEMU System and User targets

2021-07-15 Thread Kenneth Adam Miller
If I am right, the softmmu/system build target for each architecture subsumes the source of the user target. It's what I see in the build of i386. But then, I think the user targets have some dedicated user layer which allow a foreign architecture user binary to be relayed through in order to map t

Re: inline expressions for decodetree !function syntax

2021-07-15 Thread Richard Henderson
On 7/15/21 2:33 AM, Peter Maydell wrote: I have found myself wondering whether it would be a good idea for decodetree to support some minimal syntax for defining constant-modifying functions inline in the decode file, so that instead of writing %imm4_16_p1 16:4 !function=plus_1 and then hav

Re: [PATCH] hw/net/vmxnet3: Do not abort if the guest is trying to use an invalid TX queue

2021-07-15 Thread Richard Henderson
On 7/15/21 3:37 AM, Thomas Huth wrote: QEMU should never abort just because the guest is doing something odd. Let's simply log the error and ignore the bad transmit queue instead. Buglink:https://bugs.launchpad.net/qemu/+bug/1926111 Signed-off-by: Thomas Huth --- hw/net/vmxnet3.c | 9 +++--

Re: [PATCH] target/arm: Remove duplicate 'plus1' function from Neon and SVE decode

2021-07-15 Thread Richard Henderson
On 7/15/21 2:53 AM, Peter Maydell wrote: The Neon and SVE decoders use private 'plus1' functions to implement "add one" for the !function decoder syntax. We have a generic "plus_1" function in translate.h, so use that instead. Signed-off-by: Peter Maydell --- target/arm/neon-ls.decode | 4

[PATCH v3 2/3] memory: introduce DirtyRateDirtyPages and util function

2021-07-15 Thread huangy81
From: Hyman Huang(黄勇) introduce DirtyRateDirtyPages and use it to the dirty pages along with memory_global_dirty_log_sync. introduce cpu_physical_memory_dirtyrate_reset_protect to clear dirty bitmap within slot in kvm Signed-off-by: Hyman Huang(黄勇) --- include/exec/ram_addr.h | 19

[PATCH v3 3/3] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

2021-07-15 Thread huangy81
From: Hyman Huang(黄勇) introduce dirty-bitmap mode as the third method of calc-dirty-rate. implement dirty-bitmap dirtyrate calculation, which can be used to measuring dirtyrate in the absence of dirty-ring. introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to indicate dirty bitmap method

[PATCH v3 1/3] KVM: introduce kvm_get_manual_dirty_log_protect

2021-07-15 Thread huangy81
From: Hyman Huang(黄勇) introduce kvm_get_manual_dirty_log_protect for measureing dirtyrate via dirty bitmap. calculation of dirtyrate need to sync dirty log and depends on the features of dirty log. Signed-off-by: Hyman Huang(黄勇) --- accel/kvm/kvm-all.c | 6 ++ include/sysemu/kvm.h | 1 +

[PATCH v3 0/3] support dirtyrate measurement with dirty bitmap

2021-07-15 Thread huangy81
From: Hyman Huang(黄勇) v3: - do not touch cpu_physical_memory_sync_dirty_bitmap - rename global var DirtyRateIncreasedPages to DirtyRateDirtyPages - stat dirty pages in cpu_physical_memory_set_dirty_lebitmap, which is on the execution path of memory_global_dirty_log_sync and can be used f

Re: [PATCH v4 1/5] configure,meson: add option to enable LTO

2021-07-15 Thread Thomas Huth
On 11/07/2021 12.22, Thomas Huth wrote: On 05/12/2020 00.06, Daniele Buono wrote: This patch allows to compile QEMU with link-time optimization (LTO). Compilation with LTO is handled directly by meson. This patch only adds the option in configure and forwards the request to meson Tested with al

Re: [PATCH for-6.1] configure: Fix endianess test with LTO

2021-07-15 Thread Richard Henderson
On 7/15/21 1:39 AM, Thomas Huth wrote: If a user is trying to compile QEMU with link-time optimization enabled by running the configure script like this: .../configure --extra-cflags="-flto" then the endianess test is failing since the magic values do not show up in the intermediate object fi

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-15 Thread Cole Robinson
On 7/13/21 12:56 PM, Richard Henderson wrote: > On 7/13/21 8:18 AM, Cole Robinson wrote: >>>    https://bugs.llvm.org/show_bug.cgi?id=51076 > ... >> Richard can you clarify, do you think the errors are a clang bug as >> well, or strictly a qemu issue? If it's clang maybe I can get Red Hat >> llvm d

Re: [PATCH v2 17/21] contrib/gitdm: add domain-map for NVIDIA

2021-07-15 Thread Kirti Wankhede
On 7/14/2021 11:50 PM, Alex Bennée wrote: Signed-off-by: Alex Bennée Cc: Kirti Wankhede Cc: Yishai Hadas Message-Id: <20210714093638.21077-18-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/

Re: [PULL 0/5] OVMF patches for 2021-07-14

2021-07-15 Thread Peter Maydell
On Wed, 14 Jul 2021 at 21:45, Philippe Mathieu-Daudé wrote: > > The following changes since commit a9649a719a44894b81f38dc1c5c1888ee684acef: > > Merge remote-tracking branch > 'remotes/cleber-gitlab/tags/python-next-pull-request' into staging > (2021-07-14 18:09:09 +0100) > > are available in

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Tue, Jul 13, 2021 at 10:37:23AM +0100, Stefan Hajnoczi wrote: On Tue, Jul 13, 2021 at 06:30:28AM +0100, Christoph Hellwig wrote: On Tue, Jul 13, 2021 at 06:30:28AM +0100, Christoph Hellwig wrote: On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote: > Why did you decide to implemen

Re: tests/acceptance/multiprocess.py test failure

2021-07-15 Thread Jag Raman
> On Jul 15, 2021, at 9:16 AM, Cleber Rosa wrote: > > > David Hildenbrand writes: > >> >> Hi, >> >> maybe >> >> https://lkml.kernel.org/r/20210709052800.63588-1-yang.zh...@intel.com >> >> resolves your issue. If not, pleas let me know and I'll try >> reproducing (will have to install avoc

Re: [PULL 00/23] pc,pci,virtio: lots of new features

2021-07-15 Thread Michael S. Tsirkin
On Thu, Jul 15, 2021 at 11:54:17AM +0300, Marcel Apfelbaum wrote: > Hi,  > > On Wed, Jul 14, 2021 at 11:33 PM Peter Maydell > wrote: > > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > The following changes since commit > 708f50199b59476ec4b45ebcdf171550086d6292:

Re: [PATCH v2 20/21] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work

2021-07-15 Thread Mahmoud Mandour
On Wed, Jul 14, 2021 at 8:28 PM Alex Bennée wrote: > It makes sense to put our various interns in a group so we can see the > overall impact of GSoC and Outreachy on the project. > > Signed-off-by: Alex Bennée > Cc: Ahmed Karaman > Cc: Mahmoud Mandour > Cc: César Belley > Message-Id: <2021071

Re: [PATCH] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-15 Thread Matheus K. Ferst
On 15/07/2021 10:14, BALATON Zoltan wrote: [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de e-mail suspeito entre imediatamente em contato com o DTI. On Thu, 15 Jul 2021, matheus.fe...@eldorado.org.br

RE: Question on memory commit during MR finalize()

2021-07-15 Thread Thanos Makatos
Hi Peter, > -Original Message- > From: Qemu-devel bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of Peter > Xu > Sent: 21 April 2020 11:44 > To: Paolo Bonzini > Cc: Markus Armbruster ; QEMU Devel Mailing List > > Subject: Re: Question on memory commit during MR finalize() > >

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Mon, Jul 12, 2021 at 12:03:27PM +0100, Stefan Hajnoczi wrote: On Fri, Jul 09, 2021 at 07:25:45PM +0530, Padmakar Kalghatgi wrote: The enclosed patch contains the implementation of certain commands of nvme-mi specification.The MI commands are useful to manage/configure/monitor the device.Event

Re: [PATCH v5 5/5] replication: Remove workaround

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
12.07.2021 14:54, Lukas Straub wrote: Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It is not needed anymore since s->hidden_disk is guaranteed to be writable when secondary_do_checkpoint() runs. Beca

Re: [PATCH v8 00/16] qemu_iotests: improve debugging options

2021-07-15 Thread Max Reitz
On 05.07.21 08:56, Emanuele Giuseppe Esposito wrote: This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file. Patches 1-9 introduce the -gdb o

spapr_events: Sure we may ignore migrate_add_blocker() failure?

2021-07-15 Thread Markus Armbruster
Commit 2500fb423a "migration: Include migration support for machine check handling" adds this: ret = migrate_add_blocker(spapr->fwnmi_migration_blocker, &local_err); if (ret == -EBUSY) { /* * We don't want to abort so we let the migration to continue. * In a rare

Re: [PATCH v8 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

2021-07-15 Thread Max Reitz
On 05.07.21 08:57, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 719accdb1e..e5311c

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-15 Thread Stefan Hajnoczi
On Thu, Jul 15, 2021 at 03:35:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 13.07.2021 19:38, Stefan Hajnoczi wrote: > > On Tue, Jul 13, 2021 at 06:18:39PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 13.07.2021 16:10, Stefan Hajnoczi wrote: > > > > On Mon, Jul 12, 2021 at 10:41:46AM +

Re: [RFC PATCH 3/6] i386/sev: initialize SNP context

2021-07-15 Thread Brijesh Singh
On 7/15/21 4:32 AM, Dov Murik wrote: Just making sure I understand: * sev_enabled() returns true for SEV or newer (SEV or SEV-ES or SEV-SNP). * sev_es_enabled() returns true for SEV-ES or newer (SEV-ES or SEV-SNP). * sev_snp_enabled() returns true for SEV-SNP or newer (currently only S

[PATCH] target/i386/cpu: Use the KVM reported value for the number of ASIDs

2021-07-15 Thread Like Xu
From: Like Xu If KVM is enabled, use the supported number of address space identifiers (ASIDs) by the CPUID Fn8000_000A_EBX instead of hard-coding it to 0x10. Signed-off-by: Like Xu --- target/i386/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu

Re: [PATCH v5 4/5] replication: Assert that children are writable

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
12.07.2021 14:54, Lukas Straub wrote: Assert that the children are writable where it's needed. While there is no test-case for the BLOCK_REPLICATION_FAILOVER_FAILED state, this at least ensures that s->secondary_disk is always writable in case replication might go into that state. Signed-off-by:

Re: tests/acceptance/multiprocess.py test failure

2021-07-15 Thread Cleber Rosa
David Hildenbrand writes: > > Hi, > > maybe > > https://lkml.kernel.org/r/20210709052800.63588-1-yang.zh...@intel.com > > resolves your issue. If not, pleas let me know and I'll try > reproducing (will have to install avocado). Hi David, Yes, that fixes it. Sorry for missing that patch on the

Re: [PATCH] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-15 Thread BALATON Zoltan
On Thu, 15 Jul 2021, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst In commit 8f0a4b6a9, we started to require L=0 for ppc32 to match what The Programming Environments Manual say: "For 32-bit implementations, the L field must be cleared, otherwise the instruction form is invalid." F

Re: [PATCH] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-15 Thread BALATON Zoltan
On Thu, 15 Jul 2021, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst In commit 8f0a4b6a9, we started to require L=0 for ppc32 to match what The Programming Environments Manual say: "For 32-bit implementations, the L field must be cleared, otherwise the instruction form is invalid." F

[Bug 1907952] Re: qemu-system-aarch64: with "-display gtk" arrow keys are received as just ^[ on ttyAMA0

2021-07-15 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:6.0+dfsg-1~ubuntu3 --- qemu (1:6.0+dfsg-1~ubuntu3) impish; urgency=medium * d/p/u/lp-1935617-target-ppc-Fix-load-endianness-for-lxvwsx-lxvdsx.patch: fix TCG emulation for ppc64 (LP: #1935617) qemu (1:6.0+dfsg-1~ubuntu2) impish; urgency

[PATCH] block: Fix deadlock in bdrv_set_aio_context_ignore()

2021-07-15 Thread Zhiyong Ye
When bdrv_set_aio_context_ignore() is called in the main loop to change the AioContext onto the IO thread, the bdrv_drain_invoke_entry() never gets to run and the IO thread hangs at co_schedule_bh_cb(). This is because the AioContext is occupied by the main thread after being attached to the IO th

Re: [PATCH v8 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests

2021-07-15 Thread Max Reitz
On 05.07.21 08:57, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9d6a8f863

Re: [PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too

2021-07-15 Thread Max Reitz
On 05.07.21 08:57, Emanuele Giuseppe Esposito wrote: Remove read timer in test script when GDB_OPTIONS are set, so that the bash tests won't timeout while running gdb. The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, m

[PATCH] block/vvfat: fix: drop backing

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
Most probably this fake backing child doesn't work anyway (see notes about it in a8a4d15c1c34d). Still, since 25f78d9e2de528473d52 drivers are required to set .supports_backing if they want to call bdrv_set_backing_hd, so now vvfat just doesn't work because of this check. Let's finally drop this

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
13.07.2021 19:38, Stefan Hajnoczi wrote: On Tue, Jul 13, 2021 at 06:18:39PM +0300, Vladimir Sementsov-Ogievskiy wrote: 13.07.2021 16:10, Stefan Hajnoczi wrote: On Mon, Jul 12, 2021 at 10:41:46AM +0200, Emanuele Giuseppe Esposito wrote: On 08/07/2021 15:04, Stefan Hajnoczi wrote: On Thu, Jul

[PULL 0/1] QAPI patches patches for 2021-07-15

2021-07-15 Thread Markus Armbruster
The following changes since commit a9649a719a44894b81f38dc1c5c1888ee684acef: Merge remote-tracking branch 'remotes/cleber-gitlab/tags/python-next-pull-request' into staging (2021-07-14 18:09:09 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2

[PULL 1/1] qapi: Fix crash on missing enum member name

2021-07-15 Thread Markus Armbruster
New test case enum-dict-no-name.json crashes: $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json Traceback (most recent call last): [...] File "/work/armbru/qemu/scripts/qapi/expr.py", line 458, in check_enum member_name = member['name'] KeyError:

[PATCH] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-15 Thread matheus . ferst
From: Matheus Ferst In commit 8f0a4b6a9, we started to require L=0 for ppc32 to match what The Programming Environments Manual say: "For 32-bit implementations, the L field must be cleared, otherwise the instruction form is invalid." Further digging, however, shown that older CPUs have differen

Re: [RFC PATCH 1/2] hw/nvme: add mi device

2021-07-15 Thread Padmakar Kalghatgi
On Fri, Jul 09, 2021 at 08:58:42AM -0700, Keith Busch wrote: On Fri, Jul 09, 2021 at 07:25:45PM +0530, Padmakar Kalghatgi wrote: The following commands are tested with nvme-cli by hooking to the cid of the vsock as shown above and use the socket send/recieve commands to issue the commands and ge

Re: [PATCH v2 2/5] hw/intc: sifive_clint: Use RISC-V CPU GPIO lines

2021-07-15 Thread LIU Zhiwei
On 2021/7/14 下午3:24, Alistair Francis wrote: Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the timer and soft MIP bits. Signed-off-by: Alistair Francis --- include/hw/intc/sifive_clint.h | 2 + hw/intc/sifive_clint.c | 68 ++

Re: [PATCH 00/17] target/riscv: Use tcg_constant_*

2021-07-15 Thread LIU Zhiwei
On 2021/7/9 下午12:25, Richard Henderson wrote: Replace use of tcg_const_*, which makes a copy into a temp which must be freed, with direct use of the constant. Reorg handling of $zero, with different accessors for source and destination. Reorg handling of csrs, passing the actual write_mask in

Re: [PATCH v2 3/3] qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps'

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
09.07.2021 18:39, Eric Blake wrote: The point of 'qemu-img convert --bitmaps' is to be a convenience for actions that are already possible through a string of smaller 'qemu-img bitmap' sub-commands. One situation not accounted for already is that if a source image contains an inconsistent bitmap

[Bug 1926111] Re: Assertion `tx_queue_idx <= s->txq_num' failed in vmxnet3_io_bar0_write

2021-07-15 Thread Thomas Huth
Suggested fix: https://lore.kernel.org/qemu- devel/20210715103755.1035566-1-th...@redhat.com/ ** Changed in: qemu Status: Confirmed => In Progress ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) -- You received this bug notification because you are a member of qe

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-15 Thread Markus Armbruster
Pierre Morel writes: > On 7/15/21 8:16 AM, Markus Armbruster wrote: >> Pierre Morel writes: >> >>> Drawers and Books are levels 4 and 3 of the S390 CPU >>> topology. >>> We allow the user to define these levels and we will >>> store the values inside the S390CcwMachineState. >> >> Double-check

[PATCH] hw/net/vmxnet3: Do not abort if the guest is trying to use an invalid TX queue

2021-07-15 Thread Thomas Huth
QEMU should never abort just because the guest is doing something odd. Let's simply log the error and ignore the bad transmit queue instead. Buglink: https://bugs.launchpad.net/qemu/+bug/1926111 Signed-off-by: Thomas Huth --- hw/net/vmxnet3.c | 9 +++-- 1 file changed, 7 insertions(+), 2 del

Re: [PATCH v2 2/3] qemu-img: Fail fast on convert --bitmaps with inconsistent bitmap

2021-07-15 Thread Vladimir Sementsov-Ogievskiy
09.07.2021 18:39, Eric Blake wrote: Waiting until the end of the convert operation (a potentially time-consuming task) to finally detect that we can't copy a bitmap is bad, comparing to failing fast up front. Furthermore, this prevents us from leaving a file behind with a bitmap that is not mark

[Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-07-15 Thread Thomas Huth
This was the fix: https://gitlab.com/qemu-project/qemu/-/commit/bb9feea43179ef8aba2 ** Changed in: qemu Status: Invalid => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923497

[Bug 1910696] Re: Qemu fails to start with error " There is no option group 'spice'"

2021-07-15 Thread Thomas Huth
Fixed here: https://gitlab.com/qemu-project/qemu/-/commit/632a8873500d27022c ** Changed in: qemu Status: Expired => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910696 Title:

[Bug 1878641] Re: Abort() in mch_update_pciexbar

2021-07-15 Thread Thomas Huth
Fix has been included here: https://gitlab.com/qemu-project/qemu/-/commit/9b0ca75e0196a725232 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [PATCH v5 0/6] blkdebug: fix racing condition when iterating on

2021-07-15 Thread Max Reitz
On 14.06.21 10:29, Emanuele Giuseppe Esposito wrote: When qemu_coroutine_enter is executed in a loop (even QEMU_FOREACH_SAFE), the new routine can modify the list, for example removing an element, causing problem when control is given back to the caller that continues iterating on the same list.

Re: [PATCH v2 03/21] docs: add a section on the generalities of vhost-user

2021-07-15 Thread Stefan Hajnoczi
On Wed, Jul 14, 2021 at 07:20:38PM +0100, Alex Bennée wrote: > While we do mention some of this stuff in the various daemons and > manuals the subtleties of the socket and memory sharing are sometimes > missed. This document attempts to give some background on vhost-user > daemons in general terms.

Re: [PATCH v5 3/6] blkdebug: track all actions

2021-07-15 Thread Max Reitz
On 14.06.21 10:29, Emanuele Giuseppe Esposito wrote: Add a counter for each action that a rule can trigger. This is mainly used to keep track of how many coroutine_yield() we need to perform after processing all rules in the list. Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe E

Re: [PATCH v5 2/6] blkdebug: move post-resume handling to resume_req_by_tag

2021-07-15 Thread Max Reitz
On 14.06.21 10:29, Emanuele Giuseppe Esposito wrote: We want to move qemu_coroutine_yield() after the loop on rules, because QLIST_FOREACH_SAFE is wrong if the rule list is modified while the coroutine has yielded. Therefore move the suspended request to the heap and clean it up from the remove

[PATCH] target/arm: Remove duplicate 'plus1' function from Neon and SVE decode

2021-07-15 Thread Peter Maydell
The Neon and SVE decoders use private 'plus1' functions to implement "add one" for the !function decoder syntax. We have a generic "plus_1" function in translate.h, so use that instead. Signed-off-by: Peter Maydell --- target/arm/neon-ls.decode | 4 ++-- target/arm/neon-shared.decode | 2 +-

inline expressions for decodetree !function syntax

2021-07-15 Thread Peter Maydell
I have found myself wondering whether it would be a good idea for decodetree to support some minimal syntax for defining constant-modifying functions inline in the decode file, so that instead of writing %imm4_16_p1 16:4 !function=plus_1 and then having to define a "plus_1" function somewhere

Re: [RFC PATCH 3/6] i386/sev: initialize SNP context

2021-07-15 Thread Dov Murik
Hi Brijesh, On 10/07/2021 0:55, Brijesh Singh wrote: > When SEV-SNP is enabled, the KVM_SNP_INIT command is used to initialize > the platform. The command checks whether SNP is enabled in the KVM, if > enabled then it allocate a new ASID from the SNP pool and calls the s/allocate/allocates/ > fi

Re: [PATCH v2] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-15 Thread David Hildenbrand
On 15.07.21 09:53, Wei Wang wrote: When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap need to be cleared. Otherwise the skipped pages will be sent in the next round after the migration thread syncs dirty bits from the memory region dirty bitmap. Cc

Re: [PATCH v2 10/21] contrib/gitdm: add domain-map/group-map mappings for Samsung

2021-07-15 Thread Alex Bennée
Klaus Jensen writes: > [[PGP Signed Part:Undecided]] > On Jul 14 19:20, Alex Bennée wrote: >> Minwoo's work from their personal address are treated as personal >> contributions. >> >> Signed-off-by: Alex Bennée >> Acked-by: Klaus Jensen >> Cc: Gollu Appalanaidu >> Cc: Minwoo Im >> Message-

[PATCH v2] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-15 Thread Wei Wang
When skipping free pages to send, their corresponding dirty bits in the memory region dirty bitmap need to be cleared. Otherwise the skipped pages will be sent in the next round after the migration thread syncs dirty bits from the memory region dirty bitmap. Cc: David Hildenbrand Cc: Peter Xu Cc

Re: [PULL 00/23] pc,pci,virtio: lots of new features

2021-07-15 Thread Marcel Apfelbaum
Hi, On Wed, Jul 14, 2021 at 11:33 PM Peter Maydell wrote: > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > The following changes since commit > 708f50199b59476ec4b45ebcdf171550086d6292: > > > > Merge remote-tracking branch > 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into st

[PATCH for-6.1] configure: Fix endianess test with LTO

2021-07-15 Thread Thomas Huth
If a user is trying to compile QEMU with link-time optimization enabled by running the configure script like this: .../configure --extra-cflags="-flto" then the endianess test is failing since the magic values do not show up in the intermediate object files there. If the host is a big endian mac

[Bug 1878057] Re: null-ptr dereference in megasas_command_complete

2021-07-15 Thread Thomas Huth
If I get https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29192#c4 right, this has been fixed some days later in June? Or is it still reproducible? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, wh

Re: [PATCH v2 5/5] hw/intc: ibex_timer: Convert the timer to use RISC-V CPU GPIO lines

2021-07-15 Thread Bin Meng
On Wed, Jul 14, 2021 at 3:25 PM Alistair Francis wrote: > > Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V > CPU GPIO lines to set the timer MIP bits. > > Signed-off-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > --- > in

Re: [PATCH v2 4/5] hw/intc: sifive_plic: Convert the PLIC to use RISC-V CPU GPIO lines

2021-07-15 Thread Bin Meng
On Wed, Jul 14, 2021 at 3:25 PM Alistair Francis wrote: > > Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V > CPU GPIO lines to set the external MIP bits. > > Signed-off-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > --- >

  1   2   >