[PATCH for-6.2 13/23] target/mips: Fix single stepping

2021-07-20 Thread Richard Henderson
As per an ancient comment in mips_tr_translate_insn about the expectations of gdb, when restarting the insn in a delay slot we also re-execute the branch. Which means that we are expected to execute two insns in this case. This has been broken since 8b86d6d2580, where we forced max_insns to 1 whi

[PATCH for-6.2 20/23] target/s390x: Drop check for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 0632b0374b..1894ed7a66 100644 --- a/targ

[PATCH for-6.2 12/23] target/microblaze: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7e465b629a..437bbed6d6 100644

[PATCH for-6.2 21/23] target/sh4: Drop check for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/sh4/helper.h| 1 - target/sh4/op_helper.c | 5 - target/sh4/translate.c | 14 +++--- 3 files changed, 3 insertions(+), 17 deletions(-) diff --git a/target/sh4/helper.h b/target/sh4/help

[PATCH for-6.2 17/23] target/riscv: Remove dead code after exception

2021-07-20 Thread Richard Henderson
We have already set DISAS_NORETURN in generate_exception, which makes the exit_tb unreachable. Signed-off-by: Richard Henderson --- target/riscv/insn_trans/trans_privileged.c.inc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/riscv/insn_trans/trans_privileged.c.i

[PATCH for-6.2 11/23] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP

2021-07-20 Thread Richard Henderson
We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/t

[PATCH for-6.2 16/23] target/ppc: Drop exit checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Reuse gen_debug_exception to handle architectural debug exceptions. Signed-off-by: Richard Henderson --- target/ppc/translate.c | 38 -- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/target/ppc/t

[PATCH for-6.2 14/23] target/mips: Drop exit checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 50 + 1 file changed, 18 insertions(+), 32 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 4d1e08cfb1.

[PATCH for-6.2 19/23] target/rx: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/rx/helper.h| 1 - target/rx/op_helper.c | 8 target/rx/translate.c | 12 ++-- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/target/rx/helper.h b/target/rx/helper.h

[PATCH for-6.2 18/23] target/riscv: Remove exit_tb and lookup_and_goto_ptr

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically, which means we don't need to do anything in the wrappers. Signed-off-by: Richard Henderson --- target/riscv/translate.c | 29 +-- .../riscv/insn_trans/trans_privileged.c.inc | 4 +-- target/riscv/insn_trans/t

[PATCH for-6.2 09/23] target/i386: Drop check for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/i386/helper.h | 1 - target/i386/tcg/misc_helper.c | 8 target/i386/tcg/translate.c | 4 +--- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/target/i386/helper.h b/targ

[PATCH for-6.2 06/23] target/arm: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 10 ++ target/arm/translate.c | 36 ++-- 2 files changed, 8 insertions(+), 38 deletions(-) diff --git a/target/arm/translate-a64.c b/targ

[PATCH for-6.2 08/23] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt

2021-07-20 Thread Richard Henderson
We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/transl

[PATCH for-6.2 05/23] target/hexagon: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/hexagon/translate.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 54fdcaa5e8..606fae6b06 100644 --- a/targ

[PATCH for-6.2 03/23] target/avr: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/avr/translate.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index e08b83..0403470dd8 100644 --- a/target/av

[PATCH for-6.2 04/23] target/cris: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/cris/translate.c | 16 1 file changed, 16 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index a84b753349..59325b388a 100644 --- a/target/cris/translate.c ++

[PATCH for-6.2 02/23] target/alpha: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index de6c0a8439..cfb0c3d675 100644 --- a/target/al

[PATCH for-6.2 10/23] target/m68k: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 44 + 1 file changed, 9 insertions(+), 35 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index c34d9aed61..c3d281a5

[PATCH for-6.2 07/23] target/hppa: Drop checks for singlestep_enabled

2021-07-20 Thread Richard Henderson
GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b18150ef8d..9e0524efef 100644 --- a/target/h

[PATCH for-6.2 01/23] accel/tcg: Handle gdb singlestep in cpu_tb_exec

2021-07-20 Thread Richard Henderson
Currently the change in cpu_tb_exec is masked by the debug exception being raised by the translators. But this allows us to remove that code. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/accel/tcg/cpu-exec.c b/accel/t

[PATCH for-6.2 00/23] tcg: gdb singlestep reorg

2021-07-20 Thread Richard Henderson
Based-on: <20210720195439.626594-1-richard.hender...@linaro.org> ("tcg: breakpoint reorg") Consolidate all handling for gdb singlestep to 4 lines in cpu_tb_exec. Drop all of the code from target/*. Note that nios2 and sparc, lacked support for gdb singlestep entirely, which was a bit of a surpris

Re: -only-migrate and the two different uses of migration blockers

2021-07-20 Thread David Gibson
On Tue, Jul 20, 2021 at 07:30:16AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> We appear to use migration blockers in two ways: > >> > >> (1) Prevent migration for an indefinite time, typically due to use of > >> so

Re: spapr_events: Sure we may ignore migrate_add_blocker() failure?

2021-07-20 Thread David Gibson
On Mon, Jul 19, 2021 at 12:41:09PM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Mon, Jul 19, 2021 at 09:18:07AM +0200, Markus Armbruster wrote: > >> David Gibson writes: > >> > >> > On Thu, Jul 15, 2021 at 03:32:06PM +0200, Markus Armbruster wrote: > >> >> Commit 2500fb423a "

Re: [PATCH v2] target/ppc: Ease L=0 requirement on cmp/cmpi/cmpl/cmpli for ppc32

2021-07-20 Thread David Gibson
On Tue, Jul 20, 2021 at 10:55:07AM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > In commit 8f0a4b6a9b, we started to require L=0 for ppc32 to match what > The Programming Environments Manual say: > > "For 32-bit implementations, the L field must be cleared, otherwise > th

Re: [PATCH for-6.2 v6 7/7] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

2021-07-20 Thread David Gibson
On Mon, Jul 19, 2021 at 05:13:44PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 19, 2021 at 05:08:27PM -0300, Daniel Henrique Barboza wrote: > > MEM_UNPLUG_ERROR is deprecated since the introduction of > > DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of > > MEM_UNPLUG_ERROR is pe

Re: [PATCH qemu v2] ppc/vof: Fix Coverity issues

2021-07-20 Thread David Gibson
On Tue, Jul 20, 2021 at 03:07:26PM +1000, Alexey Kardashevskiy wrote: > Coverity reported issues which are caused by mixing of signed return codes > from DTC and unsigned return codes of the client interface. > > This introduces PROM_ERROR and makes distinction between the error types. > > This f

Re: [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly

2021-07-20 Thread David Gibson
On Tue, Jul 20, 2021 at 02:53:55PM +0200, Markus Armbruster wrote: > spapr_mce_req_event() makes an effort to prevent migration from > degrading the reporting of FWNMIs. It adds a migration blocker when > it receives one, and deletes it when it's done handling it. This is a > best effort. > > Co

Re: [PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event

2021-07-20 Thread David Gibson
On Mon, Jul 19, 2021 at 05:08:20PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and > has a few simple changes based on Greg's review. Tentatively applied to ppc-for-6.2. > > changes from v5: > - patch 1: > * fixed function n

Re: [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-20 Thread Kirti Wankhede
On 7/20/2021 6:23 PM, Markus Armbruster wrote: When migrate_add_blocker(blocker, &errp) is followed by error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). This is the case in vfio_migration_probe(). Prior art: commit 386f6c07d2 "error: Avoid error_propaga

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Richard Henderson
On 7/20/21 11:53 AM, Philippe Mathieu-Daudé wrote: Practically, this is working around what I'd call a gdb bug wrt avr. Which may even have been fixed -- I haven't looked. This is not a bug but a feature to deal with the Harvard architecture. QEMU AVR model is based on GCC sources so uses the s

Re: [PATCH 0/1]

2021-07-20 Thread Thomas Huth
On 21/07/2021 00.13, Jose R. Ziviani wrote: Hello! This patch gives the ability to build TCG builtin even if --enable-modules is selected. This is useful to have a base QEMU with TCG native product but still using the benefits of modules. Could you please elaborate why this is required? Did yo

[PATCH v3 3/3] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor

2021-07-20 Thread Bin Meng
From: Christina Wang In the legacy RX descriptor mode, VLAN tag was saved to d->special by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but it was then zeroed out again at the end of the call, which is wrong. Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx descri

[PATCH v3 2/3] hw/net: e1000e: Correct the initial value of VET register

2021-07-20 Thread Bin Meng
From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000e driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value of VET won't be able to transmit and

[PATCH v3 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-20 Thread Bin Meng
From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000 driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value of VET won't be able to transmit and

RE: [PATCH 1/2] ui/gtk: detach_all option for making all VCs detached upon starting

2021-07-20 Thread Romli, Khairul Anuar
I've tried and this patch is able to detach all the virtual console after we launch the qemu. However, I think we need to filter out other terminal that are not related to view such as compatmonitor(), serial and parallel. Also, I think we can have the detach specific to virtio-pci view without

[PATCH 1/2 v5] Configure script for Haiku

2021-07-20 Thread Richard Zak
Signed-off-by: Richard Zak --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 232c54dcc1..163af793e9 100755 --- a/configure +++ b/configure @@ -768,7 +768,8 @@ SunOS) ;; Haiku) haiku="yes" - QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERR

[PATCH 4/5] migration: Teach QEMUFile to be QIOChannel-aware

2021-07-20 Thread Peter Xu
migration uses QIOChannel typed qemufiles. In follow up patches, we'll need the capability to identify this fact, so that we can get the backing QIOChannel from a QEMUFile. We can also define types for QEMUFile but so far since we only need to be able to identify QIOChannel, introduce a boolean w

[PATCH 3/5] migration: Introduce migration_ioc_[un]register_yank()

2021-07-20 Thread Peter Xu
There're plenty of places in migration/* that checks against either socket or tls typed ioc for yank operations. Provide two helpers to hide all these information. Signed-off-by: Peter Xu --- migration/channel.c | 15 ++- migration/multifd.c | 8 ++-- migrat

[PATCH 2/5] migration: Shutdown src in await_return_path_close_on_source()

2021-07-20 Thread Peter Xu
We have a logic in await_return_path_close_on_source() that we will explicitly shutdown the socket when migration encounters errors. However it could be racy because from_dst_file could have been reset right after checking it but before passing it to qemu_file_shutdown() by the rp_thread. Fix it

[PATCH 0/5] migrations: Fix potential rare race of migration-test after yank

2021-07-20 Thread Peter Xu
Patch 1 fixes a possible race that migration thread can accidentally skip join() of rp_thread even if the return thread is enabled. Patch 1 is suspected to also be the root cause of the recent hard-to-reproduce migration-test failure here reported by PMM: https://lore.kernel.org/qemu-devel/YPamXA

[PATCH 5/5] migration: Move the yank unregister of channel_close out

2021-07-20 Thread Peter Xu
It's efficient, but hackish to call yank unregister calls in channel_close(), especially it'll be hard to debug when qemu crashed with some yank function leaked. Remove that hack, but instead explicitly unregister yank functions at the places where needed, they are: (on src) - migrate_fd_clea

[PATCH 1/5] migration: Fix missing join() of rp_thread

2021-07-20 Thread Peter Xu
It's possible that the migration thread skip the join() of the rp_thread in below race and crash on src right at finishing migration: migration_thread rp_thread - migration_completion()

[PATCH 1/3] docs: convert qapi-code-gen.txt to ReST

2021-07-20 Thread John Snow
This is a very rudimentary conversion from .txt to .rst changing as little as possible, but getting it to render somewhat nicely; without using any Sphinx directives. (It is 'native' ReST.) Further patches will add cross-references and Sphinx-specific extensions to make it sparkle. Signed-off-by:

[PATCH v1 26/29] tests/tcg/configure.sh: add handling for assembler only builds

2021-07-20 Thread Alex Bennée
Up until this point we only handled local compilers or assumed we had everything in the container. This falls down when we are building QEMU inside the container. This special handling only affects tricore for now but I put it in a case just in case we add any other "special" targets. Setting CROS

[PATCH v1 02/29] docs: collect the disparate device emulation docs into one section

2021-07-20 Thread Alex Bennée
While we are at it add a brief preamble that explains some of the common concepts in QEMU's device emulation which will hopefully lead to less confusing about our dizzying command line options. Signed-off-by: Alex Bennée Message-Id: <20210714182056.25888-3-alex.ben...@linaro.org> Cc: Markus Armbr

[PATCH 2/3] docs/qapi-code-gen: Beautify formatting

2021-07-20 Thread John Snow
Mostly, add ``literal`` markers to a lot of things like C types, add code blocks, and fix the way a few things render. Signed-off-by: John Snow --- docs/devel/qapi-code-gen.rst | 172 ++- 1 file changed, 90 insertions(+), 82 deletions(-) diff --git a/docs/devel/q

[PATCH 3/3] docs/qapi-code-gen: add cross-references

2021-07-20 Thread John Snow
Add clickables to many places. Signed-off-by: John Snow --- docs/devel/qapi-code-gen.rst | 107 +++ 1 file changed, 58 insertions(+), 49 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 4a28118d951..8c77af2d076 100644 --

[PATCH v1 28/29] gitlab-ci: Remove the second superfluous macos task

2021-07-20 Thread Alex Bennée
From: Thomas Huth While there might have been bigger differnces between the -base and the -xcode images in the beginning, they almost vanished in the current builds, e.g. when comparing the output of the "configure" step after cleaning up the differences due to temporary path names, I only get:

[PATCH v1 17/29] contrib/gitdm: add an explicit academic entry for BU

2021-07-20 Thread Alex Bennée
For some reason Alexander's contributions were not getting grouped from the plain "edu" mapping. Signed-off-by: Alex Bennée Reviewed-by: Alexander Bulekov Message-Id: <20210714182056.25888-20-alex.ben...@linaro.org> --- contrib/gitdm/group-map-academics | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v1 16/29] contrib/gitdm: add group-map for Netflix

2021-07-20 Thread Alex Bennée
Warner confirmed he works for Netflix on IRC. Signed-off-by: Alex Bennée Reviewed-by: Warner Losh Message-Id: <20210714182056.25888-19-alex.ben...@linaro.org> --- contrib/gitdm/group-map-netflix | 5 + gitdm.config| 1 + 2 files changed, 6 insertions(+) create mode 1006

[PATCH 0/3] docs: convert qapi-code-gen.txt to qapi-code-gen.rst

2021-07-20 Thread John Snow
Patch 1 does (roughly) the bare minimum, patch 2 adds some formatting, and patch 3 adds cross-references. John Snow (3): docs: convert qapi-code-gen.txt to ReST docs/qapi-code-gen: Beautify formatting docs/qapi-code-gen: add cross-references docs/devel/index.rst |

[PATCH v1 29/29] gitlab-ci: Extract OpenSBI job rules to reusable section

2021-07-20 Thread Alex Bennée
From: Philippe Mathieu-Daudé All jobs depending on 'docker-opensbi' job must use at most all the rules that triggers it. The simplest way to ensure that is to always use the same rules. Extract all the rules to a reusable section, and include this section (with the 'extends' keyword) in both 'doc

[PATCH v1 20/29] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-20 Thread Alex Bennée
In user-mode emulation there is a small race between preexit_cleanup and exit_group() which means we may end up calling instrumented instructions before the kernel reaps child threads. To solve this we implement a new helper which ensures the callbacks are flushed along with any translations before

[PATCH v1 09/29] gitdm.config: sort the corporate GroupMap entries

2021-07-20 Thread Alex Bennée
Lets try and keep them that way. Signed-off-by: Alex Bennée Message-Id: <20210714182056.25888-10-alex.ben...@linaro.org> --- gitdm.config | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitdm.config b/gitdm.config index 7378238c20..a3542d2fc7 100644 --- a/gitdm.config +

[PULL 3/7] tests/acceptance/virtio-gpu.py: combine CPU tags

2021-07-20 Thread Cleber Rosa
Like previously done with the arch tags, all tests use the same CPU value so it's possible to combine them at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-4-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-g

[PULL 1/7] tests/acceptance/virtio-gpu.py: use require_accelerator()

2021-07-20 Thread Cleber Rosa
Since efe30d501 there's a shorthand for requiring specific accelerators, and canceling the test if it's not available. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-2-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py |

[PULL 2/7] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags

2021-07-20 Thread Cleber Rosa
The test class in question is x86_64 specific, so it's possible to set the tags at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-3-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +-- 1 file chang

[PULL 4/7] tests/acceptance/virtio-gpu.py: combine kernel command line

2021-07-20 Thread Cleber Rosa
Both tests use the same kernel command line arguments, so there's no need to have a common and then an additional set of arguments. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-5-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/vir

[PULL 5/7] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-20 Thread Cleber Rosa
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-6-cr...@redhat.com> Reviewed-by: Willian Rampazzo Review

[PATCH v1 19/29] contrib/gitdm: add more individual contributor entries.

2021-07-20 Thread Alex Bennée
Also ensure Li's canonical gmail address is used. Signed-off-by: Alex Bennée Acked-by: Li Qiang Acked-by: Chetan Pant Acked-by: Akihiko Odaki Message-Id: <20210714182056.25888-22-alex.ben...@linaro.org> --- contrib/gitdm/aliases | 3 +++ contrib/gitdm/group-map-individuals | 3 +

[PATCH v1 21/29] plugins/cache: Fixed a bug with destroying FIFO metadata

2021-07-20 Thread Alex Bennée
From: Mahmoud Mandour This manifests itself when associativity degree is greater than the number of sets and FIFO is used, otherwise it's also a memory leak whenever FIFO was used. Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-2-ma.mando...@gmail.com>

[PATCH v1 24/29] plugins: Fix physical address calculation for IO regions

2021-07-20 Thread Alex Bennée
From: Aaron Lindsay The address calculation for IO regions introduced by commit 787148bf928a54b5cc86f5b434f9399e9737679c Author: Aaron Lindsay plugins: Expose physical addresses instead of device offsets is not always accurate. Use the more correct MemoryRegionSection.offset_within_address

[PATCH v1 25/29] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
We inadvertently added a symbol clash causing the build not to include the testboard needed for check-tcg. Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Mes

[PATCH v1 14/29] contrib/gitdm: add domain-map for Crudebyte

2021-07-20 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Christian Schoenebeck Message-Id: <20210714182056.25888-15-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 5ac8288716..e42861cd11 100644 ---

[PATCH v1 27/29] gitlab: enable a very minimal build with the tricore container

2021-07-20 Thread Alex Bennée
Rather than base of the shared Debian 10 container which would require us to bring in even more dependencies just bring in what is needed for building tricore-softmmu in GitLab. We don't even remove the container from the DOCKER_PARTIAL_IMAGES lest we cause more confusion. Signed-off-by: Alex Benn

[PATCH v1 22/29] plugins/cache: limited the scope of a mutex lock

2021-07-20 Thread Alex Bennée
From: Mahmoud Mandour It's not necessary to lock the address translation portion of the vcpu_mem_access callback. Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-3-ma.mando...@gmail.com> Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 3 +--

[PATCH v1 03/29] docs: add a section on the generalities of vhost-user

2021-07-20 Thread Alex Bennée
While we do mention some of this stuff in the various daemons and manuals the subtleties of the socket and memory sharing are sometimes missed. This document attempts to give some background on vhost-user daemons in general terms. Signed-off-by: Alex Bennée Reviewed-by: Stefan Hajnoczi Message-I

[PULL 7/7] remote/memory: Replace share parameter with ram_flags

2021-07-20 Thread Cleber Rosa
From: Yang Zhong Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd()") Signed-off-by: Yang Zhong Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pankaj Gupta Reviewed-by: Peter Xu Message-Id: <20210709052800.63588-1-yang.zh...@int

[PULL 6/7] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes

2021-07-20 Thread Cleber Rosa
By providing kernel and initrd hashes, the test guarantees the integrity of the images used and avoids the warnings set by fetch_asset() when hashes are lacking. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-7-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber R

[PATCH v1 23/29] plugins/cache: Fixed "function decl. is not a prototype" warnings

2021-07-20 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée Message-Id: <20210714172151.8494-7-ma.mando...@gmail.com> Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/plugins/cache.c b/co

[PATCH v1 13/29] contrib/gitdm: un-ironically add a mapping for LWN

2021-07-20 Thread Alex Bennée
I think this mainly comes from kernel-doc stuff imported into the QEMU tree. Signed-off-by: Alex Bennée Cc: Jonathan Corbet Message-Id: <20210714182056.25888-14-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/co

[PULL for 6.1 0/7] Python and Acceptance Tests

2021-07-20 Thread Cleber Rosa
The following changes since commit c04b4d9e6b596ead3cf6046a9243fbfee068ef33: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-07-20 16:59:33 +0100) are available in the Git repository at: https://gitlab.com/cleber.gnu/qemu.git/ tags/python-next-pull-request

[PATCH v1 04/29] configure: remove needless if leg

2021-07-20 Thread Alex Bennée
It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <

[PATCH v1 15/29] contrib/gitdm: add domain-map for NVIDIA

2021-07-20 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Kirti Wankhede Cc: Yishai Hadas Message-Id: <20210714182056.25888-18-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index e42861cd11..2800d9f986

[PATCH v1 18/29] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work

2021-07-20 Thread Alex Bennée
It makes sense to put our various interns in a group so we can see the overall impact of GSoC and Outreachy on the project. Signed-off-by: Alex Bennée Reviewed-by: Mahmoud Mandour Cc: Ahmed Karaman Cc: César Belley Message-Id: <20210714182056.25888-21-alex.ben...@linaro.org> --- contrib/gitdm

[PATCH v1 11/29] contrib/gitdm: add domain-map for Eldorado

2021-07-20 Thread Alex Bennée
Luis acked on IRC: #qemu@znc-oftc_2021-07-13.txt:[15:00:02] stsquad: "eldorado.org.br Eldorado" is fine Signed-off-by: Alex Bennée Acked-by: Luis Pires Cc: Bruno Larsen (billionai) Message-Id: <20210714182056.25888-12-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file chan

[PATCH v1 08/29] contrib/gitdm: add a group mapping for robot scanners

2021-07-20 Thread Alex Bennée
This mostly affects Reported-by: tags Signed-off-by: Alex Bennée Message-Id: <20210714182056.25888-9-alex.ben...@linaro.org> --- contrib/gitdm/group-map-robots | 7 +++ gitdm.config | 3 +++ 2 files changed, 10 insertions(+) create mode 100644 contrib/gitdm/group-map-robot

Re: [PATCH 2/2] ui/gtk-egl: blitting partial guest fb to the proper scanout surface

2021-07-20 Thread Dongwon Kim
On Sun, Jul 18, 2021 at 11:35:35PM -0700, Kasireddy, Vivek wrote: > Hi DW, > > > eb_fb_blit needs more parameters which describe x and y offsets and width > > and height of the actual scanout to specify the size and cordination of > > partial image to blit in the guest fb in case the guest fb cont

[PATCH v1 12/29] contrib/gitdm: add domain-map/group-map for Wind River

2021-07-20 Thread Alex Bennée
As per discussion at: http://patchwork.ozlabs.org/project/qemu-devel/patch/20201004180443.2035359-19-f4...@amsat.org/ I've added Bin's personal email as an individual contributor. Signed-off-by: Alex Bennée Acked-by: Bin Meng Cc: Ruimei Yan Cc: Xuzhou Cheng Message-Id: <20210714182056.2588

[PATCH v1 07/29] contrib/gitdm: add domain-map for MontaVista

2021-07-20 Thread Alex Bennée
Signed-off-by: Alex Bennée Acked-by: Corey Minyard Message-Id: <20210714182056.25888-8-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 0074da618f..efbbb15643 100644 --- a/contrib/gi

[PATCH v1 01/29] gitignore: Update with some filetypes

2021-07-20 Thread Alex Bennée
From: Viresh Kumar Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <79262dbe1f7888eb02e1911501eebafa6f2f6400.1616583806.git.viresh.ku...@linaro.org> Message-Id: <20210714182056.25888-2-alex.ben...@

[PATCH v1 06/29] .mailmap: fix up some broken commit authors

2021-07-20 Thread Alex Bennée
Fixes: 49a6f3bffb ("target/arm: Correct the encoding of MDCCSR_EL0 and DBGDSCRint") Fixes: 5a07192a04 ("target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub") Signed-off-by: Alex Bennée Cc: Nick Hudson Cc: Marek Dolata Message-Id: <20210714182056.25888-7-alex.ben...@linaro

[PATCH v1 05/29] contrib/gitdm: add some new aliases to fix up commits

2021-07-20 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: Yuval Shaia Message-Id: <20210714182056.25888-6-alex.ben...@linaro.org> --- contrib/gitdm/aliases | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/gitdm/aliases b/contrib/gitdm/aliases index c1e744312f..c6ed215e68 10064

[PATCH v1 10/29] contrib/gitdm: add domain-map/group-map mappings for Samsung

2021-07-20 Thread Alex Bennée
Minwoo's work from their personal address are treated as personal contributions. Signed-off-by: Alex Bennée Acked-by: Klaus Jensen Cc: Gollu Appalanaidu Cc: Minwoo Im Message-Id: <20210714182056.25888-11-alex.ben...@linaro.org> --- vPrePr - removed extraneous groupmap --- contrib/gitdm/dom

[PATCH for 6.1-rc1 v1 00/29] various fixes pre-PR (metadata, docs, plugins, testing)

2021-07-20 Thread Alex Bennée
Hi, This is a roll-up of all the various patches I've been posting targeting the 6.1 bug fixes. So far they include: - gitdm metadata updates (dropped un-acked mappings) - documentation on driver/device configuration - some miscellaneous plugin bug fixes - fix and CI test for Tricore (pos

Re: [PATCH 1/2] virtio-gpu: splitting one extended mode guest fb into n-scanouts

2021-07-20 Thread Dongwon Kim
On Sun, Jul 18, 2021 at 11:17:00PM -0700, Kasireddy, Vivek wrote: > Hi DW, > > > When guest is running Linux/X11 with extended multiple displays mode > > enabled, > > the guest shares one scanout resource each time containing whole surface > > rather than sharing individual display output separat

[PATCH 1/2] modules: Implement new helper functions

2021-07-20 Thread Jose R. Ziviani
The function module_load_one() fills a hash table with modules that were successfuly loaded. However, that table is a static variable of module_load_one(). This patch changes it and creates a function that informs whether a given module was loaded or not. It also creates a function that returns th

[PATCH 2/2] qom: Improve error message in module_object_class_by_name()

2021-07-20 Thread Jose R. Ziviani
module_object_class_by_name() calls module_load_qom_one if the object is provided by a dynamically linked library. Such library might not be available at this moment - for instance, it can be a package not yet installed. Thus, instead of assert error messages, this patch outputs more friendly messa

[PATCH 0/2] Improve module accelerator error message

2021-07-20 Thread Jose R. Ziviani
The main objective here is to fix an user issue when trying to load TCG that was built as module, but it's not installed or found in the library path. For example: $ ./qemu-system-x86_64 -machine q35 -accel tcg -kernel /boot/vmlinuz ... ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces:

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 11:53 PM, Philippe Mathieu-Daudé wrote: > On 7/20/21 11:08 PM, Richard Henderson wrote: >> On 7/20/21 10:56 AM, Peter Maydell wrote: >>> On Tue, 20 Jul 2021 at 20:54, Richard Henderson >>> wrote: This will allow a breakpoint hack to move out of AVR's translator. Sign

Re: [PATCH 1/2] ui/gtk: detach_all option for making all VCs detached upon starting

2021-07-20 Thread Dongwon Kim
On Tue, Jul 20, 2021 at 03:42:16PM +0200, Thomas Huth wrote: > On 19/07/2021 23.41, Dongwon Kim wrote: > > With "detach-all=on" for display, all VCs are detached from the beginning. > > This is useful when there are multiple displays assigned to a guest OS. > > Can you elaborate? (i.e. why is it u

Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable section

2021-07-20 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > All jobs depending on 'docker-opensbi' job must use at most all > the rules that triggers it. The simplest way to ensure that > is to always use the same rules. Extract all the rules to a > reusable section, and include this section (with the 'extends' > keyword

Re: [PATCH] plugins: Fix physical address calculation for IO regions

2021-07-20 Thread Alex Bennée
Aaron Lindsay writes: > The address calculation for IO regions introduced by > > commit 787148bf928a54b5cc86f5b434f9399e9737679c > Author: Aaron Lindsay > plugins: Expose physical addresses instead of device offsets Queued to for-6.1/fixes-for-rc1, thanks. > > is not always accurate. Use

Re: [PATCH] gitlab-ci: Remove the second superfluous macos task

2021-07-20 Thread Alex Bennée
Thomas Huth writes: > While there might have been bigger differnces between the -base and > the -xcode images in the beginning, they almost vanished in the > current builds, e.g. when comparing the output of the "configure" > step after cleaning up the differences due to temporary path names, >

[PATCH 1/1] modules: Option to build native TCG with --enable-modules

2021-07-20 Thread Jose R. Ziviani
Adds an option (--enable-tcg-builtin) to build TCG natively when --enable-modules argument is passed to the build system. It gives the opportunity to have this important accelerator built-in and still take advantage of the new modular system. Signed-off-by: Jose R. Ziviani --- configure

[PATCH 0/1]

2021-07-20 Thread Jose R. Ziviani
Hello! This patch gives the ability to build TCG builtin even if --enable-modules is selected. This is useful to have a base QEMU with TCG native product but still using the benefits of modules. Thank you! Jose R. Ziviani (1): modules: Option to build native TCG with --enable-modules configu

Re: [PATCH for-6.1 v6 15/17] accel/tcg: Remove TranslatorOps.breakpoint_check

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 9:54 PM, Richard Henderson wrote: > The hook is now unused, with breakpoints checked outside translation. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 11 --- > target/arm/helper.h | 2 -- > target/alpha/translate.c | 16

Re: [PATCH for-6.1 v6 12/17] target/avr: Implement gdb_adjust_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 9:54 PM, Richard Henderson wrote: > Ensure at registration that all breakpoints are in > code space, not data space. > > Signed-off-by: Richard Henderson > --- > target/avr/cpu.h | 1 + > target/avr/cpu.c | 1 + > target/avr/gdbstub.c | 13 + > target/avr/t

Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Pankaj Gupta
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine > type". > > Cc: Sergio Lopez > Signed-off-by: Markus Armbruster > --- > hw/i386/microvm.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c > index aba0c83219..f257ec5a0b 10

Re: [PATCH 16/16] vl: Don't continue after -smp help.

2021-07-20 Thread Pankaj Gupta
> We continue after -smp help: > > $ qemu-system-x86_64 -smp help -display none -monitor stdio > smp-opts options: > cores= > cpus= > dies= > maxcpus= > sockets= > threads= > QEMU 6.0.50 monitor - type 'help' for more information > (qemu) > > Othe

  1   2   3   4   5   >