[PULL 6/6] hw/display: fix virgl reset regression

2021-07-22 Thread Gerd Hoffmann
From: Marc-André Lureau Before commit 49afbca3b00e8e517d54964229a794b51768deaf ("virtio-gpu: drop use_virgl_renderer"), use_virgl_renderer was preventing calling GL functions from non-GL context threads. The innocuously looking g->parent_obj.use_virgl_renderer = false; was set the first time

[PULL 5/6] vl: add virtio-vga-gl to the default_list

2021-07-22 Thread Gerd Hoffmann
From: Marc-André Lureau Do not instantiate an extra default VGA device if -device virtio-vga-gl is provided. Related to commit b36eb8860f8f4a9c6f131c3fd380116a3017e022 ("virtio-gpu: add virtio-vga-gl") Signed-off-by: Marc-André Lureau Message-Id:

[PULL 4/6] hw/display: fail early when multiple virgl devices are requested

2021-07-22 Thread Gerd Hoffmann
From: Marc-André Lureau This avoids failing to initialize virgl and crashing later on, and clear the user expectations. Signed-off-by: Marc-André Lureau Reviewed-by: Mark Cave-Ayland Message-Id: <20210705104218.1161101-1-marcandre.lur...@redhat.com> Signed-off-by: Gerd Hoffmann ---

[PULL 3/6] Revert "qxl: add migration blocker to avoid pre-save assert"

2021-07-22 Thread Gerd Hoffmann
This reverts commit 86dbcdd9c7590d06db89ca256c5eaf0b4aba8858. The pre-save assert is gone now, so the migration blocker is not needed any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-Id: <20210721093347.338536-3-kra...@redhat.com> --- hw/display/qxl.h | 1 -

[PULL 2/6] qxl: remove assert in qxl_pre_save.

2021-07-22 Thread Gerd Hoffmann
Since commit 551dbd0846d2 ("migration: check pre_save return in vmstate_save_state") the pre_save hook can fail. So lets finally use that to drop the guest-triggerable assert in qxl_pre_save(). Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-Id:

[PULL 0/6] Vga 20210723 patches

2021-07-22 Thread Gerd Hoffmann
The following changes since commit e77c8b8b8e933414ef07dbed04e02973fccffeb0: Update version for v6.1.0-rc0 release (2021-07-21 17:10:15 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20210723-pull-request for you to fetch changes up to

[PULL 1/6] hw/display/virtio-gpu: Fix memory leak (CID 1453811)

2021-07-22 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé To avoid leaking memory on the error path, reorder the code as: - check the parameters first - check resource already existing - finally allocate memory Reported-by: Coverity (CID 1453811: RESOURCE_LEAK) Fixes: e0933d91b1c ("virtio-gpu: Add

Re: [PATCH v2 13/22] target/loongarch: Add floating point arithmetic instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +uint64_t helper_fp_sqrt_d(CPULoongArchState *env, uint64_t fp) +{ +fp = float64_sqrt(fp, >active_fpu.fp_status); +update_fcsr0(env, GETPC()); +return fp; +} + +uint32_t helper_fp_sqrt_s(CPULoongArchState *env, uint32_t fp) +{ +fp =

Re: [PATCH v3 0/2] Add more 64-bit utilities

2021-07-22 Thread Alistair Francis
On Wed, Jul 21, 2021 at 4:31 AM Joe Komlodi wrote: > > Changelog: > v2 -> v3 > - 1/2: register block init should also be uint64_t > v1 -> v2 > - 2/2: Use uint64_t for 64-bit value > > Hi all, > > This adds more utilities for 64-bit registers. > As part of it, it also fixes FIELD_DP64 to work

Re: [PATCH v2 12/22] target/loongarch: Add fixed point extra instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +target_ulong helper_cpucfg(CPULoongArchState *env, target_ulong rj) +{ +target_ulong r = 0; + +switch (rj) { +case 0: +r = env->CSR_MCSR0 & 0x; +break; +case 1: +r = (env->CSR_MCSR0 & 0x) >> 32;

Re: [PATCH v3 1/2] hw/core/register: Add more 64-bit utilities

2021-07-22 Thread Alistair Francis
On Wed, Jul 21, 2021 at 4:31 AM Joe Komlodi wrote: > > We already have some utilities to handle 64-bit wide registers, so this just > adds some more for: > - Initializing 64-bit registers > - Extracting and depositing to an array of 64-bit registers > > Signed-off-by: Joe Komlodi Reviewed-by:

Re: [PATCH 14/17] target/riscv: Tidy trans_rvh.c.inc

2021-07-22 Thread Alistair Francis
On Fri, Jul 9, 2021 at 2:52 PM Richard Henderson wrote: > > Exit early if check_access fails. > Split out do_hlv, do_hsv, do_hlvx subroutines. > Use gpr_src, gpr_dst in the new subroutines. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 09/17] target/riscv: Reorg csr instructions

2021-07-22 Thread Alistair Francis
On Fri, Jul 9, 2021 at 2:46 PM Richard Henderson wrote: > > Introduce csrr and csrw helpers, for read-only and write-only insns. > > Note that we do not properly implement this in riscv_csrrw, in that > we cannot distinguish true read-only (rs1 == 0) from any other zero > write_mask another

[PATCH] misc/pca9552: Fix LED status register indexing in pca955x_get_led()

2021-07-22 Thread Andrew Jeffery
There was a bit of a thinko in the state calculation where every odd pin in was reported in e.g. "pwm0" mode rather than "off". This was the result of an incorrect bit shift for the 2-bit field representing each LED state. Fixes: a90d8f84674d ("misc/pca9552: Add qom set and get") Signed-off-by:

Re: [PATCH v1 2/5] hw/intc: sifive_clint: Use RISC-V CPU GPIO lines

2021-07-22 Thread Anup Patel
On Wed, Jul 14, 2021 at 11:41 AM Alistair Francis wrote: > > On Tue, Jul 13, 2021 at 2:06 PM Anup Patel wrote: > > > > On Fri, Jul 9, 2021 at 9:01 AM Alistair Francis > > wrote: > > > > > > Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V > > > CPU GPIO lines to set the

Re: [PULL V3 for 6.2 0/6] COLO-Proxy patches for 2021-06-25

2021-07-22 Thread Jason Wang
在 2021/7/19 下午5:00, Zhang Chen 写道: Hi Jason, Please help to queue COLO-proxy patches to net branch. Thanks Chen Queued for 6.2 Thanks The following changes since commit fd79f89c76c8e2f409dd9db5d7a367b1f64b6dc6: Merge remote-tracking branch

[PATCH for-6.1 v3 1/1] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so

[PATCH for-6.1 v3 0/1] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread wangyanan (Y)
Hi Cleber, On 2021/7/23 6:25, Cleber Rosa wrote: Yanan Wang writes: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify

Re: [PATCH v2 11/22] target/loongarch: Add fixed point atomic instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +#define TRANS_AM_W(name, op) \ +static bool trans_ ## name(DisasContext *ctx, arg_ ## name * a) \ +{ \ +TCGv addr, val, ret;

Re: [PATCH v2 10/22] target/loongarch: Add fixed point load/store instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: This patch implement fixed point load/store instruction translation. This includes: - LD.{B[U]/H[U]/W[U]/D}, ST.{B/H/W/D} - LDX.{B[U]/H[U]/W[U]/D}, STX.{B/H/W/D} - LDPTR.{W/D}, STPTR.{W/D} - PRELD - LD{GT/LE}.{B/H/W/D}, ST{GT/LE}.{B/H/W/D} - DBAR, IBAR

Re: [PATCH v2 09/22] target/loongarch: Add fixed point bit instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: This patch implement fixed point bit instruction translation. This includes: - EXT.W.{B/H} - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} - BYTEPICK.{W/D} - REVB.{2H/4H/2W/D} - REVH.{2W/D} - BITREV.{4B/8B}, BITREV.{W/D} - BSTRINS.{W/D}, BSTRPICK.{W/D} - MASKEQZ, MASKNEZ

Re: [PATCH v2 08/22] target/loongarch: Add fixed point shift instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +/* Fixed point shift operation instruction translation */ +static bool trans_sll_w(DisasContext *ctx, arg_sll_w *a) +{ +TCGv t0, t1; +TCGv Rd = cpu_gpr[a->rd]; + +if (a->rd == 0) { +/* Nop */ +return true; +} + +t0 =

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +/* Fixed point arithmetic operation instruction translation */ +static bool trans_add_w(DisasContext *ctx, arg_add_w *a) +{ +TCGv Rd = cpu_gpr[a->rd]; +TCGv Rj = cpu_gpr[a->rj]; +TCGv Rk = cpu_gpr[a->rk]; + +if (a->rd == 0) { +/* Nop

Re: [PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +/* General purpose registers moves. */ +void gen_load_gpr(TCGv t, int reg) +{ +if (reg == 0) { +tcg_gen_movi_tl(t, 0); +} else { +tcg_gen_mov_tl(t, cpu_gpr[reg]); +} +} Please have a look at

Re: [PATCH v2 05/22] target/loongarch: Add memory management support

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: This patch introduces one memory-management-related functions - loongarch_cpu_tlb_fill() Signed-off-by: Song Gao --- target/loongarch/cpu.c| 1 + target/loongarch/cpu.h| 9 target/loongarch/tlb_helper.c | 103

Re: [PATCH v2 04/22] target/loongarch: Add interrupt handling support

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +bool loongarch_cpu_exec_interrupt(CPUState *cs, int interrupt_request) +{ +if (interrupt_request & CPU_INTERRUPT_HARD) { +LoongArchCPU *cpu = LOONGARCH_CPU(cs); +CPULoongArchState *env = >env; + +if

Re: [PATCH v2 03/22] target/loongarch: Add core definition

2021-07-22 Thread Richard Henderson
On 7/20/21 11:52 PM, Song Gao wrote: This patch add target state header, target definitions and initialization routines. Signed-off-by: Song Gao --- target/loongarch/cpu-param.h | 21 target/loongarch/cpu-qom.h | 40 ++ target/loongarch/cpu.c | 293

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Cleber Rosa
Yanan Wang writes: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the topology parameters > as zero like

Re: [PATCH v2 1/1] hmp: synchronize cpu state for lapic info

2021-07-22 Thread Dongli Zhang
May I get feedback for this bugfix? So far the "info lapic " returns stale data and could not accurate reflect the status in KVM. Thank you very much! Dongli Zhang On 7/1/21 2:40 PM, Dongli Zhang wrote: > While the default "info lapic" always synchronizes cpu state ... > > mon_get_cpu() > ->

[PATCH v2 1/1] modules: Improve error message when module is not found

2021-07-22 Thread Jose R. Ziviani
When a module is not found, specially accelerators, QEMU displays a error message that not easy to understand[1]. This patch improves the readability by offering a user-friendly message[2]. This patch also moves the accelerator ops check to runtine (instead of the original g_assert) because it

[PATCH v2 0/1] Improve module accelerator error message

2021-07-22 Thread Jose R. Ziviani
v1 -> v2: * Moved the code to module.c * Simplified a lot by using current module DB to get info The main objective is to improve the error message when trying to load a not found/not installed module TCG. For example: $ qemu-system-x86_64 -accel tcg

Re: [PATCH-for-6.1 v2] gitlab-ci: Extract OpenSBI job rules and fix 'when' condition

2021-07-22 Thread Cleber Rosa
Philippe Mathieu-Daudé writes: > First, all jobs depending on 'docker-opensbi' job must use at most > all the rules that triggers it. The simplest way to ensure that is > to always use the same rules. Extract all the rules to a reusable > section, and include this section (with the 'extends'

Re: [PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-22 Thread Cleber Rosa
Peter Maydell writes: > Our built HTML documentation now has a standard footer which > gives the license for QEMU (and its documentation as a whole). > In almost all pages, we either don't bother to state the > copyright/license for the individual rST sources, or we put > it in an rST comment.

Re: [PATCH for-6.1 1/2] docs: Remove stale TODO comments about license and version

2021-07-22 Thread Cleber Rosa
Peter Maydell writes: > Since commits 13f934e79fa and 3a50c8f3067aaf, our HTML docs include a > footer to all pages stating the license and version. We can > therefore delete the TODO comments suggesting we should do that from > our .rst files. > > Signed-off-by: Peter Maydell > --- >

Re: [PATCH for-6.1 0/3] docs: Document arm mainstone, kzm, imx25-pdk

2021-07-22 Thread Richard Henderson
On 7/22/21 7:52 AM, Peter Maydell wrote: Peter Maydell (3): docs: Add documentation of Arm 'mainstone' board docs: Add documentation of Arm 'kzm' board docs: Add documentation of Arm 'imx25-pdk' board Reviewed-by: Richard Henderson r~

Re: [PATCH] MAINTAINERS: Don't list Andrzej Zaborowski for various components

2021-07-22 Thread Richard Henderson
On 7/22/21 8:09 AM, Peter Maydell wrote: Andrzej Zaborowski is listed as an "Odd Fixes" maintainer for the nSeries, Palm and PXA2XX boards, as well as the "Maintained" status Arm 32-bit TCG backend. Andrzej's last email to qemu-devel was back in 2017, and the email before that was all the way

Re: [PATCH for-6.1 0/2] docs license footer followon cleanups

2021-07-22 Thread Marc-André Lureau
On Thu, Jul 22, 2021 at 11:23 PM Peter Maydell wrote: > This patchset makes a couple of followon cleanups now that > commits 13f934e79fa and 3a50c8f3067aaf are in master and our HTML > documentation has a footer to all pages stating the QEMU license > and version: > * it removes the TODO

Re: [PATCH v3 2/5] migration: Make from_dst_file accesses thread-safe

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 01:58:38PM -0400, Peter Xu wrote: > Accessing from_dst_file is potentially racy in current code base like below: > > if (s->from_dst_file) > do_something(s->from_dst_file); > > Because from_dst_file can be reset right after the check in another > thread (rp_thread).

[PATCH for-6.1 0/2] docs license footer followon cleanups

2021-07-22 Thread Peter Maydell
This patchset makes a couple of followon cleanups now that commits 13f934e79fa and 3a50c8f3067aaf are in master and our HTML documentation has a footer to all pages stating the QEMU license and version: * it removes the TODO comments, because we've now done them * three .rst files were rendering

[PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-22 Thread Peter Maydell
Our built HTML documentation now has a standard footer which gives the license for QEMU (and its documentation as a whole). In almost all pages, we either don't bother to state the copyright/license for the individual rST sources, or we put it in an rST comment. There are just three pages which

[PATCH for-6.1 1/2] docs: Remove stale TODO comments about license and version

2021-07-22 Thread Peter Maydell
Since commits 13f934e79fa and 3a50c8f3067aaf, our HTML docs include a footer to all pages stating the license and version. We can therefore delete the TODO comments suggesting we should do that from our .rst files. Signed-off-by: Peter Maydell --- docs/interop/qemu-ga-ref.rst |

Re: Prefetches in buffer_zero_*

2021-07-22 Thread Dr. David Alan Gilbert
* Richard Henderson (richard.hender...@linaro.org) wrote: > On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: > > Hi Richard, > >I think you were the last person to fiddle with the prefetching > > in buffer_zero_avx2 and friends; Joe (cc'd) wondered if explicit > > prefetching still made

[PATCH 1/1] hw/i2c: add remote I2C device

2021-07-22 Thread Shengtan Mao
This patch adds the remote I2C device, which supports the usage of external I2C devices. Signed-off-by: Shengtan Mao --- hw/arm/Kconfig| 1 + hw/i2c/Kconfig| 4 + hw/i2c/meson.build| 1 + hw/i2c/remote-i2c.c | 117 ++

[PATCH 0/1] Add remote I2C device to support external I2C device

2021-07-22 Thread Shengtan Mao
This patch implements the remote I2C device. The remote I2C device allows an external I2C device to communicate with the I2C controller in QEMU through the remote I2C protocol. Users no longer have to directly modify QEMU to add new I2C devices and can instead implement the emulated device

Re: Prefetches in buffer_zero_*

2021-07-22 Thread Richard Henderson
On 7/22/21 12:02 AM, Dr. David Alan Gilbert wrote: Hi Richard, I think you were the last person to fiddle with the prefetching in buffer_zero_avx2 and friends; Joe (cc'd) wondered if explicit prefetching still made sense on modern CPUs, and that their hardware generally figures stuff out

Re: [PATCH v3 5/5] migration: Move the yank unregister of channel_close out

2021-07-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It's efficient, but hackish to call yank unregister calls in channel_close(), > especially it'll be hard to debug when qemu crashed with some yank function > leaked. > > Remove that hack, but instead explicitly unregister yank functions at the > places

[PATCH] MAINTAINERS: Don't list Andrzej Zaborowski for various components

2021-07-22 Thread Peter Maydell
Andrzej Zaborowski is listed as an "Odd Fixes" maintainer for the nSeries, Palm and PXA2XX boards, as well as the "Maintained" status Arm 32-bit TCG backend. Andrzej's last email to qemu-devel was back in 2017, and the email before that was all the way back in 2013. We don't really need to fill

[PATCH v3 5/5] migration: Move the yank unregister of channel_close out

2021-07-22 Thread Peter Xu
It's efficient, but hackish to call yank unregister calls in channel_close(), especially it'll be hard to debug when qemu crashed with some yank function leaked. Remove that hack, but instead explicitly unregister yank functions at the places where needed, they are: (on src) -

Re: [PATCH for-6.1? 3/6] jobs: Give Job.force_cancel more meaning

2021-07-22 Thread Vladimir Sementsov-Ogievskiy
22.07.2021 15:26, Max Reitz wrote: We largely have two cancel modes for jobs: First, there is actual cancelling. The job is terminated as soon as possible, without trying to reach a consistent result. Second, we have mirror in the READY state. Technically, the job is not really cancelled,

[PATCH v3 2/5] migration: Make from_dst_file accesses thread-safe

2021-07-22 Thread Peter Xu
Accessing from_dst_file is potentially racy in current code base like below: if (s->from_dst_file) do_something(s->from_dst_file); Because from_dst_file can be reset right after the check in another thread (rp_thread). One example is migrate_fd_cancel(). Use the same qemu_file_lock to

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-22 Thread Laurent Vivier
On 22/07/2021 19:49, Michael S. Tsirkin wrote: > On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: ... >> >> Fixes: 17858a169508609ca9063c544833e5a1adeb7b52 > > use short hash and include subject within ("subject here") please Tips: some people use .gitconfig [pretty]

[PATCH-for-6.1 v2] gitlab-ci: Extract OpenSBI job rules and fix 'when' condition

2021-07-22 Thread Philippe Mathieu-Daudé
First, all jobs depending on 'docker-opensbi' job must use at most all the rules that triggers it. The simplest way to ensure that is to always use the same rules. Extract all the rules to a reusable section, and include this section (with the 'extends' keyword) in both 'docker-opensbi' and

[PATCH v3 1/5] migration: Fix missing join() of rp_thread

2021-07-22 Thread Peter Xu
It's possible that the migration thread skip the join() of the rp_thread in below race and crash on src right at finishing migration: migration_thread rp_thread - migration_completion()

[PATCH v3 0/5] migrations: Fix potential rare race of migration-test after yank

2021-07-22 Thread Peter Xu
v3: - Use WITH_QEMU_LOCK_GUARD() for patch 2 [Eric] (potentially I can also replace other existing uses of qemu_file_lock into WITH_QEMU_LOCK_GUARD, but I decided to took Dave's r-b first and leave that for later) - Added r-bs for Dave on patch 2/4 - Add a comment in patch 5 to explain why

Re: [PATCH 1/2] acpi: x86: pcihp: cleanup devfn usage in build_append_pci_bus_devices()

2021-07-22 Thread Michael S. Tsirkin
I would add a description: we want to scan all functions not just function 0 to describe hotplug into bridges at function != 0. in preparation for this, refactor code to not skip functions != 0. On Thu, Jul 22, 2021 at 06:59:44AM -0400, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- >

Re: -only-migrate and the two different uses of migration blockers

2021-07-22 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Tue, Jul 20, 2021 at 07:30:16AM +0200, Markus Armbruster wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > >> We appear to use migration blockers in two ways: > > >> > > >> (1)

Re: [PATCH v3 3/4] vhost-user-rng: backend: Add RNG vhost-user daemon implementation

2021-07-22 Thread Mathieu Poirier
On Wed, Jul 21, 2021 at 09:14:31PM +0100, Alex Bennée wrote: > > Mathieu Poirier writes: > > > This patch provides the vhost-user backend implementation to work > > in tandem with the vhost-user-rng implementation of the QEMU VMM. > > > > It uses the vhost-user API so that other VMM can re-use

Re: [RFC PATCH v2 11/44] i386/tdx: Implement user specified tsc frequency

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Xiaoyao Li Reuse -cpu,tsc-frequency= to get user wanted tsc frequency and pass it to KVM_TDX_INIT_VM. Besides, sanity check the tsc frequency to be in the legal range and legal granularity (required by SEAM module). Signed-off-by:

Re: [PATCH-for-6.1] gitlab-ci: Extract OpenSBI job rules to reusable section

2021-07-22 Thread Philippe Mathieu-Daudé
On 7/22/21 5:49 PM, Daniel P. Berrangé wrote: > On Tue, Jul 20, 2021 at 06:48:29PM +0200, Philippe Mathieu-Daudé wrote: >> All jobs depending on 'docker-opensbi' job must use at most all >> the rules that triggers it. The simplest way to ensure that >> is to always use the same rules. Extract all

[PATCH v3 4/5] migration: Teach QEMUFile to be QIOChannel-aware

2021-07-22 Thread Peter Xu
migration uses QIOChannel typed qemufiles. In follow up patches, we'll need the capability to identify this fact, so that we can get the backing QIOChannel from a QEMUFile. We can also define types for QEMUFile but so far since we only need to be able to identify QIOChannel, introduce a boolean

Re: [RFC PATCH v2 12/44] target/i386/tdx: Finalize the TD's measurement when machine is done

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Xiaoyao Li Invoke KVM_TDX_FINALIZEMR to finalize the TD's measurement and make the TD vCPUs runnable once machine initialization is complete. Signed-off-by: Xiaoyao Li Signed-off-by: Isaku Yamahata --- target/i386/kvm/kvm.c | 7

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Xiaoyao Li Introduce a machine property, kvm-type, to allow the user to create a Trusted Domain eXtensions (TDX) VM, a.k.a. a Trusted Domain (TD), e.g.: # $QEMU \ -machine ...,kvm-type=tdx \ ... Only two types are

Re: [PATCH for-6.1? 4/6] job: Add job_cancel_requested()

2021-07-22 Thread Vladimir Sementsov-Ogievskiy
22.07.2021 15:26, Max Reitz wrote: Most callers of job_is_cancelled() actually want to know whether the job is on its way to immediate termination. For example, we refuse to pause jobs that are cancelled; but this only makes sense for jobs that are really actually cancelled. A mirror job that

[PATCH v3 3/5] migration: Introduce migration_ioc_[un]register_yank()

2021-07-22 Thread Peter Xu
There're plenty of places in migration/* that checks against either socket or tls typed ioc for yank operations. Provide two helpers to hide all these information. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/channel.c | 15 ++-

Re: [RFC PATCH v2 09/44] target/i386: kvm: don't synchronize guest tsc for TD guest

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata Make kvm_synchronize_all_tsc() nop for TD-guest. s/nop/noop TDX module specification, 9.11.1 TSC Virtualization This appears in 9.12.1 of the latest revision as of this writing.

Re: [PATCH 0/2] acpi: pcihp: fix hotplug when bridge is wired to function > 0

2021-07-22 Thread Michael S. Tsirkin
On Thu, Jul 22, 2021 at 06:59:43AM -0400, Igor Mammedov wrote: > For full description see 2/2. > Tested hotplug on Q35 (see 2/2 for reproducer) and PC (with pci-bridge) > machines > > Igor Mammedov (2): > acpi: x86: pcihp: cleanup devfn usage in > build_append_pci_bus_devices() > acpi:

Re: [PATCH for-6.2 34/34] target/arm: Implement MVE interleaving loads/stores

2021-07-22 Thread Richard Henderson
On 7/13/21 3:37 AM, Peter Maydell wrote: +const int off[4] = { O1, O2, O3, O4 }; \ static? uint8_t? Otherwise, with the help of your little print program, I can confirm that these offsets match what the pseudocode produces. I hope this while beat execution

Re: [RFC PATCH v2 32/44] tdx: add kvm_tdx_enabled() accessor for later use

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:55 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- include/sysemu/tdx.h | 1 + target/i386/kvm/kvm.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/sysemu/tdx.h b/include/sysemu/tdx.h index 70eb01348f..f3eced10f9

[PATCH for-6.1 2/3] docs: Add documentation of Arm 'kzm' board

2021-07-22 Thread Peter Maydell
Add brief documentation of the Arm 'kzm' board. Signed-off-by: Peter Maydell --- docs/system/arm/kzm.rst| 18 ++ docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 20 insertions(+) create mode 100644 docs/system/arm/kzm.rst diff --git

Re: [RFC PATCH v2 34/44] target/i386/tdx: set reboot action to shutdown when tdx

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:55 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata In TDX CPU state is also protected, thus vcpu state can't be reset by VMM. It assumes -action reboot=shutdown instead of silently ignoring vcpu reset. TDX module spec version 344425-002US doesn't support vcpu reset by

Re: [RFC PATCH v2 04/44] vl: Introduce machine_init_done_late notifier

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata Introduce a new notifier, machine_init_done_late, that is notified after machine_init_done. This will be used by TDX to generate the HOB for its virtual firmware, which needs to be done after all guest memory has been

Re: [RFC PATCH v2 01/44] target/i386: Expose x86_cpu_get_supported_feature_word() for TDX

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Sean Christopherson Expose x86_cpu_get_supported_feature_word() outside of cpu.c so that it can be used by TDX to setup the VM-wide CPUID configuration. Signed-off-by: Sean Christopherson Signed-off-by: Isaku Yamahata Reviewed-by:

[PATCH for-6.1 1/3] docs: Add documentation of Arm 'mainstone' board

2021-07-22 Thread Peter Maydell
Add brief documentation of the Arm 'mainstone' board. Signed-off-by: Peter Maydell --- docs/system/arm/mainstone.rst | 25 + docs/system/target-arm.rst| 1 + MAINTAINERS | 1 + 3 files changed, 27 insertions(+) create mode 100644

Re: [RFC PATCH v2 02/44] kvm: Switch KVM_CAP_READONLY_MEM to a per-VM ioctl()

2021-07-22 Thread Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote: From: Isaku Yamahata Switch to making a VM ioctl() call for KVM_CAP_READONLY_MEM, which may be conditional on VM type in recent versions of KVM, e.g. when TDX is supported. kvm_vm_check_extension() has fallback from kvm_vm_ioctl() to

[PATCH for-6.1 0/3] docs: Document arm mainstone, kzm, imx25-pdk

2021-07-22 Thread Peter Maydell
This patchset adds brief documentation for another set of Arm boards. As usual, people familiar with these boards are welcome to provide more detail for the docs -- I just did the minimum "name the board and list emulated devices identified from a quick scan through the source code". (After this

[PATCH for-6.1 3/3] docs: Add documentation of Arm 'imx25-pdk' board

2021-07-22 Thread Peter Maydell
Add brief documentation of the Arm 'imx25-pdk' board. Signed-off-by: Peter Maydell --- docs/system/arm/imx25-pdk.rst | 19 +++ docs/system/target-arm.rst| 1 + MAINTAINERS | 1 + 3 files changed, 21 insertions(+) create mode 100644

Re: [PATCH 2/2] acpi: x86: pcihp: add support hotplug on multifunction bridges

2021-07-22 Thread Michael S. Tsirkin
On Thu, Jul 22, 2021 at 06:59:45AM -0400, Igor Mammedov wrote: > Commit 17858a1695 (hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35) > switched PCI hotplug from native to ACPI one by default. > > That however breaks ihotplug on following CLI that used to work: s/ihotplug/hotplug/ ? >

[PATCH v2 3/5] s390x: topology: CPU topology objects and structures

2021-07-22 Thread Pierre Morel
We use new objects to have a dynamic administration of the CPU topology. The highier level object is the S390 book. In a first implementation we will have only a single S390 book. The book is built as a SYSBUS bridge during the CPU initialisation. Every object under this single book will be build

[PATCH v2 1/5] s390x: kvm: topology: Linux header update

2021-07-22 Thread Pierre Morel
Just as information, the linux header update patch is inside the Linux patch series. Signed-off-by: Pierre Morel --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index bcaf66cc4d..38e96ea6f7 100644 ---

[PATCH v2 0/5] s390x: CPU Topology

2021-07-22 Thread Pierre Morel
Hi, This series is a first part of the implementation of CPU topology for S390 greatly reduced from the first spin. In particular, we reduced the scope to the S390x specificities, removing all code touching to SMP or NUMA, with the goal to: - facilitate review and acceptance - let for later the

Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 04:51:48PM +0200, David Hildenbrand wrote: > I'll give it a churn. Thanks, David. -- Peter Xu

[PATCH v2 4/5] s390x: topology: Topology list entries and SYSIB 15.x.x

2021-07-22 Thread Pierre Morel
We define the CPU type Topology List Entry and the Container type Topology List Entry to implement SYSIB 15.1.x This patch will be squatched with the next patch. Signed-off-by: Pierre Morel --- target/s390x/cpu.h | 44 1 file changed, 44

[PATCH v2 5/5] s390x: topology: implementating Store Topology System Information

2021-07-22 Thread Pierre Morel
The handling of STSI is enhenced with the interception of the function code 15 for storing CPU topology. Using the objects built during the pluging of CPU, we build the SYSIB 15_1_x structures. With this patch the maximum MNEST level is 2, this is also the only level allowed and only SYSIB

[PATCH v2 2/5] s390x: kvm: topology: interception of PTF instruction

2021-07-22 Thread Pierre Morel
Interception of the PTF instruction depending on the new KVM_CAP_S390_CPU_TOPOLOGY KVM extension. Signed-off-by: Pierre Morel --- hw/s390x/s390-virtio-ccw.c | 45 ++ include/hw/s390x/s390-virtio-ccw.h | 7 + target/s390x/kvm/kvm.c | 21

Re: [PATCH v2 5/5] migration: Move the yank unregister of channel_close out

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 06:09:03PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Jul 22, 2021 at 04:27:35PM +0100, Dr. David Alan Gilbert wrote: > > > > @@ -3352,6 +3355,8 @@ static MigThrError postcopy_pause(MigrationState > > > > *s) > > > > > > > >

Re: [PULL 04/15] chardev-spice: add missing module_obj directive

2021-07-22 Thread Philippe Mathieu-Daudé
On 7/22/21 5:36 PM, Paolo Bonzini wrote: > The chardev-spicevmc class was not listed in chardev/spice.c, causing > "-chardev spicevmc" to fail when modules are enabled. > > Reported-by: Frederic Bezies > Fixes: 9f4a0f0978 ("modules: use modinfo for qom load", 2021-07-09) > Resolves:

Re: [PULL 0/3] SIGSEGV fixes

2021-07-22 Thread Peter Maydell
On Wed, 21 Jul 2021 at 22:19, Taylor Simpson wrote: > > The following changes since commit 7457b407edd6e8555e4b46488aab2f13959fccf8: > > Merge remote-tracking branch > 'remotes/thuth-gitlab/tags/pull-request-2021-07-19' into staging (2021-07-19 > 11:34:08 +0100) > > are available in the git

Re: [PATCH v2 5/5] migration: Move the yank unregister of channel_close out

2021-07-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Jul 22, 2021 at 04:27:35PM +0100, Dr. David Alan Gilbert wrote: > > > @@ -3352,6 +3355,8 @@ static MigThrError postcopy_pause(MigrationState *s) > > > > > > /* Current channel is possibly broken. Release it. */ > > >

Re: [PATCH for-6.1? 2/6] job: @force parameter for job_cancel_sync{,_all}()

2021-07-22 Thread Vladimir Sementsov-Ogievskiy
22.07.2021 15:26, Max Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass

Re: [PATCH v3 1/4] vhost-user-rng: Add vhost-user-rng implementation

2021-07-22 Thread Mathieu Poirier
Hi Alex, On Wed, Jul 21, 2021 at 09:52:50AM +0100, Alex Bennée wrote: > > Mathieu Poirier writes: > > > Following in the footsteps of what whas done for vhost-user-i2c > > and virtiofsd, introduce a random number generator (RNG) backend > > that communicates with a vhost-user server to

Re: [PATCH] nbd/server: Add --selinux-label option

2021-07-22 Thread Daniel P . Berrangé
On Thu, Jul 22, 2021 at 05:32:40PM +0100, Richard W.M. Jones wrote: > Under SELinux, Unix domain sockets have two labels. One is on the > disk and can be set with commands such as chcon(1). There is a > different label stored in memory (called the process label). This can > only be set by the

[PATCH] nbd/server: Add --selinux-label option

2021-07-22 Thread Richard W.M. Jones
Under SELinux, Unix domain sockets have two labels. One is on the disk and can be set with commands such as chcon(1). There is a different label stored in memory (called the process label). This can only be set by the process creating the socket. When using SELinux + SVirt and wanting qemu to

[PATCH] nbd/server: Add --selinux-label option

2021-07-22 Thread Richard W.M. Jones
https://bugzilla.redhat.com/show_bug.cgi?id=1984938 The purpose of the patch is explained in the commit message / bug. In the cover I want to explain a couple of design choices. If libselinux isn't available at build time then the --selinux-label option is still present. It does not appear in

Re: [PATCH for-6.1 0/2] gitlab: misc tweaks to job execution rules

2021-07-22 Thread Daniel P . Berrangé
Self-nack. Sent the wrong version of the code - this one is broken, ignore it. On Thu, Jul 22, 2021 at 05:20:33PM +0100, Daniel P. Berrangé wrote: > - Fixes a problem with acceptance jobs running when build jobs fail > - Fixes a problem with pages job publishing website from undesirable >

Re: [PATCH for-6.1? 1/6] mirror: Keep s->synced on error

2021-07-22 Thread Vladimir Sementsov-Ogievskiy
22.07.2021 15:26, Max Reitz wrote: An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only

[PATCH 1/2] gitlab: only let pages be published from default branch

2021-07-22 Thread Daniel P . Berrangé
GitLab will happily publish pages generated by the latest CI pipeline from any branch: https://docs.gitlab.com/ee/user/project/pages/introduction.html "Remember that GitLab Pages are by default branch/tag agnostic and their deployment relies solely on what you specify in .gitlab-ci.yml.

[PATCH for-6.1 0/2] gitlab: misc tweaks to job execution rules

2021-07-22 Thread Daniel P . Berrangé
- Fixes a problem with acceptance jobs running when build jobs fail - Fixes a problem with pages job publishing website from undesirable branches. Daniel P. Berrangé (2): gitlab: only let pages be published from default branch gitlab: don't run acceptance jobs if build jobs fail

[PATCH 2/2] gitlab: don't run acceptance jobs if build jobs fail

2021-07-22 Thread Daniel P . Berrangé
The 'when: always' clause tells gitlab to run the job even if the dependant jobs have failed. This is wrong for the acceptance jobs, since we need the build artifacts from the dependant jobs. This results in the acceptance jobs given extra failures with wierd messages about missing files.

Re: [PATCH v2 5/5] migration: Move the yank unregister of channel_close out

2021-07-22 Thread Peter Xu
On Thu, Jul 22, 2021 at 04:27:35PM +0100, Dr. David Alan Gilbert wrote: > > @@ -3352,6 +3355,8 @@ static MigThrError postcopy_pause(MigrationState *s) > > > > /* Current channel is possibly broken. Release it. */ > > assert(s->to_dst_file); > > +/* Unregister yank for

  1   2   3   >