Re: [PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-08-16 Thread Jason Wang
On Mon, Aug 16, 2021 at 7:58 PM Yuri Benditovich wrote: > > Jason, > Can you please review the series? WIll do it this week. Thanks > > Thanks, > Yuri > > On Thu, Jul 22, 2021 at 11:38 AM Andrew Melnichenko wrote: > > > > ping > > > > On Tue, Jul 13, 2021 at 6:38 PM Andrew Melnychenko > >

Re: [PATCH v2] hw/i386/acpi-build: Get NUMA information from struct NumaState

2021-08-16 Thread Liu, Jingqi
On 8/16/2021 6:05 PM, Philippe Mathieu-Daudé wrote: On 8/6/21 5:19 AM, Jingqi Liu wrote: Maybe prepend with: Since commits aa57020774b ("numa: move numa global variable nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move numa global variable numa_info into MachineState"), we can

Re: [PATCH v3 09/13] python/aqmp-tui: Add QMP connection manager

2021-08-16 Thread John Snow
On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu wrote: > Instead of manually connecting and disconnecting from the > server. We now rely on the runstate to manage the QMP > connection. > > Along with this the ability to reconnect on certain exceptions > has also been added. > > Signed-off-by: G

Re: [PATCH] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG explicitly

2021-08-16 Thread Ani Sinha
ping ... On Thu, 12 Aug 2021, Ani Sinha wrote: > ACPI_MEMORY_HOTPLUG is implicitly turned on when ACPI_HW_REDUCED is selected. > ACPI_HW_REDUCED is already enabled. No need to turn on ACPI_MEMORY_HOTPLUG > explicitly. This is a minor cleanup. > > Signed-off-by: Ani Sinha > --- > hw/arm/Kconfig

[PATCH RFC v6 11/12] target/riscv: Implement virtual time adjusting with vm state changing

2021-08-16 Thread Yifei Jiang
We hope that virtual time adjusts with vm state changing. When a vm is stopped, guest virtual time should stop counting and kvm_timer should be stopped. When the vm is resumed, guest virtual time should continue to count and kvm_timer should be restored. Signed-off-by: Yifei Jiang Signed-off-by:

[PATCH RFC v6 04/12] target/riscv: Implement kvm_arch_get_registers

2021-08-16 Thread Yifei Jiang
Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 150 - 1 file changed, 149 insertions(+), 1 deletion(-) diff --git

[PATCH RFC v6 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

2021-08-16 Thread Yifei Jiang
Add target/riscv/kvm.c to place kvm_arch_* function needed by kvm/kvm-all.c. Meanwhile, add kvm support in meson.build file. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- meson.build | 2 + target/riscv/kvm.c | 133

[PATCH RFC v6 06/12] target/riscv: Support start kernel directly by KVM

2021-08-16 Thread Yifei Jiang
Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- hw/riscv/boot.c | 11 +++ hw/riscv/virt.c

[PATCH RFC v6 00/12] Add riscv kvm accel support

2021-08-16 Thread Yifei Jiang
This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux (lastest version v19). This series depends on above pending changes which haven't yet been accepted, so this QEMU patch

[PATCH RFC v6 05/12] target/riscv: Implement kvm_arch_put_registers

2021-08-16 Thread Yifei Jiang
Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 141 - 1 file changed, 140 insertions(+), 1 deletion(-) diff --git

[PATCH RFC v6 07/12] target/riscv: Support setting external interrupt by KVM

2021-08-16 Thread Yifei Jiang
Extend riscv_cpu_update_mip() to support setting external interrupt by KVM. It will call kvm_riscv_set_irq() to change the IRQ state in the KVM module When kvm is enabled and the MIP_SEIP bit is set in "mask" In addition, bacause target/riscv/cpu_helper.c is used to TCG, so move

[PATCH RFC v6 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer

2021-08-16 Thread Yifei Jiang
Add kvm_riscv_get/put_regs_timer to synchronize virtual time context from KVM. To set register of RISCV_TIMER_REG(state) will occur a error from KVM on kvm_timer_state == 0. It's better to adapt in KVM, but it doesn't matter that adaping in QEMU. Signed-off-by: Yifei Jiang Signed-off-by:

[PATCH RFC v6 12/12] target/riscv: Support virtual time context synchronization

2021-08-16 Thread Yifei Jiang
Add virtual time context description to vmstate_riscv_cpu. After cpu being loaded, virtual time context is updated to KVM. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li --- target/riscv/machine.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/riscv/machine.c

[PATCH RFC v6 03/12] target/riscv: Implement function kvm_arch_init_vcpu

2021-08-16 Thread Yifei Jiang
Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index

Re: [PATCH v2] hw/intc/sifive_clint: Fix overflow in sifive_clint_write_timecmp()

2021-08-16 Thread Alistair Francis
On Tue, Aug 17, 2021 at 4:39 AM David Hoppenbrouwers wrote: > > `next` is an `uint64_t` value, but `timer_mod` takes an `int64_t`. This > resulted in high values such as `UINT64_MAX` being converted to `-1`, > which caused an immediate timer interrupt. > > By limiting `next` to `INT64_MAX` no

[PATCH RFC v6 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit

2021-08-16 Thread Yifei Jiang
Use char-fe to handle console sbi call, which implement early console io while apply 'earlycon=sbi' into kernel parameters. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li --- target/riscv/kvm.c | 42 - target/riscv/sbi_ecall_interface.h | 72

[PATCH RFC v6 01/12] linux-header: Update linux/kvm.h

2021-08-16 Thread Yifei Jiang
Update linux-headers/linux/kvm.h from https://github.com/avpatel/linux/tree/riscv_kvm_v19. Only use this header file, so here do not update all linux headers by update-linux-headers.sh until above KVM series is accepted. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li ---

[PATCH RFC v6 09/12] target/riscv: Add host cpu type

2021-08-16 Thread Yifei Jiang
'host' type cpu is set isa to RV32 or RV64 simply, more isa info will obtain from KVM in kvm_arch_init_vcpu() Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 15 +++ target/riscv/cpu.h | 1 + 2 files changed, 16

Re: [PATCH] hw: ppc: sam460ex: Disable Ethernet devicetree nodes

2021-08-16 Thread David Gibson
On Mon, Aug 16, 2021 at 12:21:33PM +0200, BALATON Zoltan wrote: > On Mon, 16 Aug 2021, David Gibson wrote: > > On Sun, Aug 15, 2021 at 07:59:15PM -0700, Guenter Roeck wrote: > > > IBM EMAC Ethernet controllers are not emulated by qemu. If they are > > > enabled in devicetree files, they are

Re: [PATCH] hw: ppc: sam460ex: Disable Ethernet devicetree nodes

2021-08-16 Thread David Gibson
On Mon, Aug 16, 2021 at 01:58:08PM +0200, BALATON Zoltan wrote: > On Mon, 16 Aug 2021, Philippe Mathieu-Daudé wrote: > > On 8/16/21 12:26 PM, Peter Maydell wrote: > > > On Mon, 16 Aug 2021 at 06:46, David Gibson > > > wrote: > > > > > > > > On Sun, Aug 15, 2021 at 07:59:15PM -0700, Guenter

Re: [PULL 24/30] spapr_pci: populate ibm,loc-code

2021-08-16 Thread David Gibson
On Mon, Aug 16, 2021 at 10:07:12AM +0100, Peter Maydell wrote: > On Mon, 16 Aug 2021 at 06:41, David Gibson > wrote: > > > > Indeed. Revised version below. I'll only attempt to push this to 6.1 > > if we're going to rc4 for other reasons though. > > We are doing an rc4, but I don't think we

Re: [PATCH 04/19] target/ppc: PMU Book3s basic insns count for pseries TCG

2021-08-16 Thread David Gibson
On Mon, Aug 16, 2021 at 02:53:13PM -0300, Daniel Henrique Barboza wrote: > > > On 8/10/21 12:39 AM, David Gibson wrote: > > On Mon, Aug 09, 2021 at 10:10:42AM -0300, Daniel Henrique Barboza wrote: > > > The PMCC (PMC Control) bit in the MMCR0 register controls whether the > > > counters PMC5 and

Re: [PATCH for-6.2 v5 3/5] hw/arm/virt: Add cpu-map to device tree

2021-08-16 Thread wangyanan (Y)
Hi, On 2021/8/5 20:39, Yanan Wang wrote: From: Andrew Jones Support device tree CPU topology descriptions. In accordance with the Devicetree Specification, the Linux Doc "arm/cpus.yaml" requires that cpus and cpu nodes in the DT are present. And we have already met the requirement by

[PATCH RESEND 1/2] memory: Name all the memory listeners

2021-08-16 Thread Peter Xu
Provide a name field for all the memory listeners. It can be used to identify which memory listener is which. Signed-off-by: Peter Xu --- accel/hvf/hvf-accel-ops.c | 1 + accel/kvm/kvm-all.c | 7 +-- hw/i386/xen/xen-hvm.c | 2 ++ hw/intc/openpic_kvm.c

[PATCH RESEND 2/2] memory: Add tracepoint for dirty sync

2021-08-16 Thread Peter Xu
Trace at memory_region_sync_dirty_bitmap() for log_sync() or global_log_sync() on memory regions. One trace line should suffice when it finishes, so as to estimate the time used for each log sync process. Signed-off-by: Peter Xu --- softmmu/memory.c | 2 ++ softmmu/trace-events | 1 + 2

[PATCH RESEND 0/2] memory: Add tracepoints for log_sync

2021-08-16 Thread Peter Xu
[this is a resend to hopefully drop '\r' in cover letter caused by git-publish that I should have just fixed; nothing changed inside] It can help to identify which step is slow for migration dirty sync process. We have migration_bitmap_sync_* trace events but it's still a bit coarse. This

[PATCH 2/2] memory: Add tracepoint for dirty sync

2021-08-16 Thread Peter Xu
Trace at memory_region_sync_dirty_bitmap() for log_sync() or global_log_sync() on memory regions. One trace line should suffice when it finishes, so as to estimate the time used for each log sync process. Signed-off-by: Peter Xu --- softmmu/memory.c | 2 ++ softmmu/trace-events | 1 + 2

[PATCH 0/2] memory: Add tracepoints for log_sync

2021-08-16 Thread Peter Xu
It can help to identify which step is slow for migration dirty sync process. We have migration_bitmap_sync_* trace events but it's still a bit coarse. This should help us to cut migration_bitmap_sync() into finer grained small steps when measurement is needed. Please review, thanks. Peter Xu

[PATCH 1/2] memory: Name all the memory listeners

2021-08-16 Thread Peter Xu
Provide a name field for all the memory listeners. It can be used to identify which memory listener is which. Signed-off-by: Peter Xu --- accel/hvf/hvf-accel-ops.c | 1 + accel/kvm/kvm-all.c | 7 +-- hw/i386/xen/xen-hvm.c | 2 ++ hw/intc/openpic_kvm.c

Re: [RFC PATCH 00/13] Add support for Mirror VM.

2021-08-16 Thread Steve Rutherford
On Mon, Aug 16, 2021 at 6:37 AM Ashish Kalra wrote: > > From: Ashish Kalra > > This is an RFC series for Mirror VM support that are > essentially secondary VMs sharing the encryption context > (ASID) with a primary VM. The patch-set creates a new > VM and shares the primary VM's encryption

Re: [PATCH 0/7] floppy: build as modules.

2021-08-16 Thread John Snow
On Thu, Aug 5, 2021 at 3:12 AM Gerd Hoffmann wrote: > On Wed, Aug 04, 2021 at 05:19:02PM +0200, Philippe Mathieu-Daudé wrote: > > +Mark > > > > On 8/4/21 4:27 PM, Gerd Hoffmann wrote: > > > Some code shuffling needed beforehand due to floppy being part of > > > several platforms. While being at

Re: [PATCH v3 00/25] python: introduce Asynchronous QMP package

2021-08-16 Thread John Snow
On Tue, Aug 3, 2021 at 2:29 PM John Snow wrote: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-async-qmp-aqmp > CI: https://gitlab.com/jsnow/qemu/-/pipelines/347375602 > Docs: https://people.redhat.com/~jsnow/sphinx/html/qemu.aqmp.html > > Hi! > > This patch series adds an Asynchronous

Re: [PULL 0/1] Last minute fix for -rc4

2021-08-16 Thread Paolo Bonzini
AIUI this behavior existed before in 6.0 and therefore should be deprecated first. Paolo Il lun 16 ago 2021, 23:06 Eduardo Habkost ha scritto: > The following changes since commit > bd44d64a3879bb6b0ca19bff3be16e0093502fac: > > Merge remote-tracking branch >

Re: [PATCH v3 2/6] block: block-status cache for data regions

2021-08-16 Thread Eric Blake
On Thu, Aug 12, 2021 at 10:41:44AM +0200, Hanna Reitz wrote: > As we have attempted before > (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, > "file-posix: Cache lseek result for data regions"; > https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg00934.html, >

Re: [PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-16 Thread Paolo Bonzini
How do we know that no one has ever used such configuration? The conversion was meant to be bug-compatible. Paolo Il lun 16 ago 2021, 23:06 Eduardo Habkost ha scritto: > From: Yanan Wang > > In the SMP configuration, we should either provide a topology > parameter with a reasonable value

Re: [RFC PATCH 01/13] machine: Add mirrorvcpus=N suboption to -smp

2021-08-16 Thread Eric Blake
On Mon, Aug 16, 2021 at 01:26:45PM +, Ashish Kalra wrote: > From: Dov Murik > > Add a notion of mirror vcpus to CpuTopology, which will allow to > designate a few vcpus (normally 1) for running the guest > migration handler (MH). > > Example usage for starting a 4-vcpu guest, of which 1

Re: [PATCH v3 08/13] python/aqmp-tui: add syntax highlighting

2021-08-16 Thread Niteesh G. S.
On Tue, Aug 17, 2021 at 1:14 AM John Snow wrote: > > > On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu > wrote: > >> Add syntax highlighting for the incoming and outgoing QMP messages. >> This is achieved using the pygments module which was added in a >> previous commit. >> >> The current

[PULL 1/1] machine: Disallow specifying topology parameters as zero

2021-08-16 Thread Eduardo Habkost
From: Yanan Wang In the SMP configuration, we should either provide a topology parameter with a reasonable value (greater than zero) or just omit it and QEMU will compute the missing value. Users should have never provided a configuration with parameters as zero (e.g. -smp 8,sockets=0) which

[PULL 0/1] Last minute fix for -rc4

2021-08-16 Thread Eduardo Habkost
The following changes since commit bd44d64a3879bb6b0ca19bff3be16e0093502fac: Merge remote-tracking branch 'remotes/thuth-gitlab/tags/pull-request-2021-08-11' into staging (2021-08-15 16:46:23 +0100) are available in the Git repository at: https://gitlab.com/ehabkost/qemu.git

Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in

2021-08-16 Thread Eric Blake
On Mon, Aug 16, 2021 at 08:04:42PM +0200, Philippe Mathieu-Daudé wrote: > When configuring QEMU with --disable-fuse, the qemu-storage-daemon > still reports FUSE command line options in its help: > > $ qemu-storage-daemon -h > Usage: qemu-storage-daemon [options] > QEMU storage daemon > >

Re: [RFC PATCH 00/13] Add support for Mirror VM.

2021-08-16 Thread Paolo Bonzini
Il lun 16 ago 2021, 19:23 Dr. David Alan Gilbert ha scritto: > > However, I am not sure if the in-guest migration helper vCPUs should use > the > > existing KVM support code. For example, they probably can just always > work > > with host CPUID (copied directly from KVM_GET_SUPPORTED_CPUID), >

Re: [PATCH-for-6.1 v2] softmmu/physmem: fix wrong assertion in qemu_ram_alloc_internal()

2021-08-16 Thread Peter Xu
On Thu, Aug 05, 2021 at 11:23:50AM +0200, David Hildenbrand wrote: > When adding RAM_NORESERVE, we forgot to remove the old assertion when > adding the updated one, most probably when reworking the patches or > rebasing. We can easily crash QEMU by adding > -object

Re: Picture missing in About dialog on cocoa ui

2021-08-16 Thread Programmingkid
> On Jul 8, 2021, at 2:38 PM, Programmingkid wrote: > > > >> On Jul 8, 2021, at 1:50 PM, Peter Maydell wrote: >> >> On Thu, 8 Jul 2021 at 17:28, Programmingkid >> wrote: >>> The problem with e31746ecf8dd2f25f687c94ac14016a3ba5debfc is it requires a >>> picture file to be found in a

[PATCH 5/8] target/mips: Inline gen_helper_1e1i() call in op_ld_INSN() macros

2021-08-16 Thread Philippe Mathieu-Daudé
gen_helper_1e1i() is one-line long and is used in one place: simply inline it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index

[PATCH 8/8] target/mips: Define gen_helper() macros in translate.h

2021-08-16 Thread Philippe Mathieu-Daudé
To be able to split some code calling the gen_helper() macros out of the huge translate.c, we need to define them in the 'translate.h' local header. Signed-off-by: Philippe Mathieu-Daudé --- Will be used in following series. Can resend there as first patch. --- target/mips/tcg/translate.h | 12

[PATCH 2/8] target/mips: Remove gen_helper_1e2i()

2021-08-16 Thread Philippe Mathieu-Daudé
gen_helper_1e2i() is unused since commit 33a07fa2db6 ("target/mips: reimplement SC instruction emulation and use cmpxchg"), remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/translate.c

[PATCH 4/8] target/mips: Simplify gen_helper() macros by using tcg_constant_i32()

2021-08-16 Thread Philippe Mathieu-Daudé
In all call sites the last argument is always used as a read-only value, so we can replace tcg_const_i32() temporary by tcg_constant_i32(). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff

[PATCH 7/8] target/mips: Use tcg_constant_i32() in generate_exception_err()

2021-08-16 Thread Philippe Mathieu-Daudé
excp/err are temporaries input, so we can replace tcg_const_i32() calls by tcg_constant_i32() equivalent. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target/mips/tcg/translate.c

[PATCH 6/8] target/mips: Inline gen_helper_0e0i()

2021-08-16 Thread Philippe Mathieu-Daudé
gen_helper_0e0i() is one-line long and is only used twice: simply inline it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index

[PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_helper_0e2i()

2021-08-16 Thread Philippe Mathieu-Daudé
$rt register is used read-only, so we can replace tcg_const_i32() temporary by tcg_constant_i32(). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/translate.c

[PATCH 1/8] target/mips: Remove gen_helper_0e3i()

2021-08-16 Thread Philippe Mathieu-Daudé
gen_helper_0e3i() is unused since commit 895c2d04359 ("target-mips: switch to AREG0 free mode"), remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/translate.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c

[PATCH 0/8] target/mips: Housekeeping in gen_helper() macros

2021-08-16 Thread Philippe Mathieu-Daudé
Trivial patches: - Remove unused macros - Use tcg_constant_i32() - Inline the macros when few uses - Move macro definitions in translate.h Philippe Mathieu-Daudé (8): target/mips: Remove gen_helper_0e3i() target/mips: Remove gen_helper_1e2i() target/mips: Use tcg_constant_i32() in

Re: [PATCH 3/3] hw/mips/boston: Add FDT generator

2021-08-16 Thread Philippe Mathieu-Daudé
Hi Jiaxun, Cc'ing David (FDT) / Huacai for review help. On 7/29/21 5:39 AM, Jiaxun Yang wrote: > Generate FDT on our own if no dtb argument supplied. > Avoid introduce unused device in FDT with user supplied dtb. "Avoid introducing" > > Signed-off-by: Jiaxun Yang > --- > hw/mips/boston.c |

Re: [PATCH 2/3] hw/mips/boston: Allow loading elf kernel and dtb

2021-08-16 Thread Philippe Mathieu-Daudé
On 7/29/21 10:02 AM, Philippe Mathieu-Daudé wrote: > On 7/29/21 5:39 AM, Jiaxun Yang wrote: >> ELF kernel allows us debugging much easier with DWARF symbols. > > You can load the symbols using the 'loader' device: > docs/system/generic-loader.rst. > >> Signed-off-by: Jiaxun Yang >> --- >>

Re: [PATCH 1/3] hw/mips/boston: Massage memory map information

2021-08-16 Thread Philippe Mathieu-Daudé
On 7/29/21 9:55 AM, Philippe Mathieu-Daudé wrote: > On 7/29/21 5:39 AM, Jiaxun Yang wrote: >> Use memmap array to unfiy address of memory map. Typo 'unify'. >> That would allow us reuse address information for FDT generation. >> >> Signed-off-by: Jiaxun Yang >> --- >> hw/mips/boston.c | 95

Re: [PATCH v3 09/10] virtiofsd: Optionally fill lo_inode.fhandle

2021-08-16 Thread Vivek Goyal
On Wed, Aug 11, 2021 at 08:41:18AM +0200, Hanna Reitz wrote: [..] > > > But given the inotify complications, there’s really a good reason we > > > should > > > use mountinfo. > > > > > > > > It’s a bit tricky because our sandboxing prevents easy access to > > > > > mountinfo, > > > > > but if

Re: [PATCH v3 08/13] python/aqmp-tui: add syntax highlighting

2021-08-16 Thread John Snow
On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu wrote: > Add syntax highlighting for the incoming and outgoing QMP messages. > This is achieved using the pygments module which was added in a > previous commit. > > The current implementation is a really simple one which doesn't > allow for any

Re: [PATCH v3 07/13] python: add optional pygments dependency

2021-08-16 Thread John Snow
On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu wrote: > Added pygments as optional dependency for AQMP TUI. > This is required for the upcoming syntax highlighting feature > in AQMP TUI. > The dependency has also been added in the devel optional group. > > Added mypy 'ignore_missing_imports'

[PATCH for-6.2 2/2] target/ppc: Don't swap 64-bit elements of AVR in gdbstub for user mode

2021-08-16 Thread matheus . ferst
From: Matheus Ferst As vector registers are stored in host endianness, we shouldn't swap its 64-bit elements in user mode to call gdb_get_reg128. Add a 16-byte case in ppc_maybe_bswap_register to handle the reordering of elements in softmmu and remove avr_need_swap which is now unused.

[PATCH for-6.2 1/2] include/qemu/int128.h: introduce bswap128s

2021-08-16 Thread matheus . ferst
From: Matheus Ferst Introduces bswap128s based on bswap128. Since bswap128 is defined using int128_* methods available in either CONFIG_INT128 or !CONFIG_INT128 builds, place both outside of #ifdef CONFIG_INT128. Signed-off-by: Matheus Ferst --- include/qemu/int128.h | 16 +++- 1

[PATCH for-6.2 0/2] target/ppc: Fix vector registers access in gdbstub for little-endian

2021-08-16 Thread matheus . ferst
From: Matheus Ferst PPC gdbstub code has two possible swaps of the 64-bit elements of AVR registers: in gdb_get_avr_reg/gdb_set_avr_reg (based on msr_le) and in gdb_get_reg128/ldq_p (based on TARGET_WORDS_BIGENDIAN). In softmmu, only the first is done, because TARGET_WORDS_BIGENDIAN is always

[PATCH 3/3] MAINTAINERS: Split Audio backends sections

2021-08-16 Thread Philippe Mathieu-Daudé
Split the Audio backends into multiple sections (OS / framework / library), allowing developers with different interests to add their contact to the relevant entries. Suggested-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 42

[PATCH 2/3] MAINTAINERS: Remove SPICE from Audio backends section

2021-08-16 Thread Philippe Mathieu-Daudé
SPICE audio is already covered in the SPICE section, so remove it from the Audio backends one. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ec6baa7e4c..f18fcd76450 100644 --- a/MAINTAINERS +++

[PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

2021-08-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6b3697962c1..9ec6baa7e4c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c

[PATCH 0/3] MAINTAINERS: Split Audio section

2021-08-16 Thread Philippe Mathieu-Daudé
Split the current 'Audio' entry in multiple ones, allowing developers with different interests to add their contact to the relevant entries. Philippe Mathieu-Daudé (3): MAINTAINERS: Split Audio backends VS frontends MAINTAINERS: Remove SPICE from Audio backends section MAINTAINERS: Split

Re: [PATCH v4 01/14] doc: update AMD SEV API spec web link

2021-08-16 Thread Dr. David Alan Gilbert
* Ashish Kalra (ashish.ka...@amd.com) wrote: > From: Brijesh Singh > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Brijesh Singh > Signed-off-by: Ashish Kalra Lets get this little change out the way; please resend just this patch to qemu-triv...@nongnu.org and we can have one less

[PATCH v2] hw/intc/sifive_clint: Fix overflow in sifive_clint_write_timecmp()

2021-08-16 Thread David Hoppenbrouwers
`next` is an `uint64_t` value, but `timer_mod` takes an `int64_t`. This resulted in high values such as `UINT64_MAX` being converted to `-1`, which caused an immediate timer interrupt. By limiting `next` to `INT64_MAX` no overflow will happen while the timer will still be effectively set to

[PATCH] include/block.h: remove outdated comment in bdrv_drained_begin

2021-08-16 Thread Emanuele Giuseppe Esposito
There are a couple of errors in bdrv_drained_begin header comment: - block_job_pause does not exist anymore, it has been replaced with job_pause in b15de82867 - job_pause is automatically invoked as a .drained_begin callback (child_job_drained_begin) by the child_job BdrvChildClass struct in

Re: [PATCH v3] accel/tcg: Clear PAGE_WRITE before translation

2021-08-16 Thread Richard Henderson
On 8/5/21 10:48 AM, Ilya Leoshkevich wrote: translate_insn() implementations fetch instruction bytes piecemeal, which can cause qemu-user to generate inconsistent translations if another thread modifies them concurrently [1]. Fix by making pages containing translated instruction non-writable

Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

2021-08-16 Thread Wainer dos Santos Moschetta
Hi, On 8/3/21 4:34 PM, Cleber Rosa wrote: The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation. But the avocado_qemu.Test class is currently missing the same clean up, as it

[PATCH] hw/intc/sifive_clint: Fix overflow in sifive_clint_write_timecmp()

2021-08-16 Thread David Hoppenbrouwers
`next` is an `uint64_t` value, but `timer_mod` takes an `int64_t`. This resulted in high values such as `UINT64_MAX` being converted to `-1`, which caused an immediate timer interrupt. By limiting `next` to `INT64_MAX` no overflow will happen while the timer will still be effectively set to

[PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in

2021-08-16 Thread Philippe Mathieu-Daudé
When configuring QEMU with --disable-fuse, the qemu-storage-daemon still reports FUSE command line options in its help: $ qemu-storage-daemon -h Usage: qemu-storage-daemon [options] QEMU storage daemon --export [type=]fuse,id=,node-name=,mountpoint=

[PATCH 2/2] target/arm: Implement HSTR.TJDBX

2021-08-16 Thread Peter Maydell
In v7A, the HSTR register has a TJDBX bit which traps NS EL0/EL1 access to the JOSCR and JMCR trivial Jazelle registers, and also BXJ. Implement these traps. In v8A this HSTR bit doesn't exist, so don't trap for v8A CPUs. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 1 +

[PATCH 1/2] target/arm: Implement HSTR.TTEE

2021-08-16 Thread Peter Maydell
In v7, the HSTR register has a TTEE bit which allows EL0/EL1 accesses to the Thumb2EE TEECR and TEEHBR registers to be trapped to the hypervisor. Implement these traps. Signed-off-by: Peter Maydell --- target/arm/cpu.h| 2 ++ target/arm/helper.c | 18 -- 2 files changed, 18

[PATCH 0/2] target/arm: Implement remaining HSTR functionality

2021-08-16 Thread Peter Maydell
I was going through some old todo items from years back, and one of them was "implement HSTR traps". We actually already do the interesting part of this (traps of coprocessor register access), but there are a couple of small loose ends: v7A (but not v8A!) defines HSTR.TTEE and HSTR.TJDBX trap

Re: [PATCH 0/3] arm: Avoid asserting in cpu_address_space_init()

2021-08-16 Thread Richard Henderson
On 8/16/21 3:58 AM, Peter Maydell wrote: Peter Maydell (3): raspi: Use error_fatal for SoC realize errors, not error_abort target/arm: Avoid assertion trying to use KVM and multiple ASes hw/arm/virt: Delete EL3 error checksnow provided in CPU realize Reviewed-by: Richard Henderson

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

2021-08-16 Thread Wainer dos Santos Moschetta
Hi, On 8/3/21 4:34 PM, Cleber Rosa wrote: The tests/acceptance directory is currently lacking a maintainer entry, even though I've been performing that role (of course with help from many others). Thus, its status is, even more now, Maintained. yay! This also removes the currently broken

Re: [PATCH 04/19] target/ppc: PMU Book3s basic insns count for pseries TCG

2021-08-16 Thread Daniel Henrique Barboza
On 8/10/21 12:39 AM, David Gibson wrote: On Mon, Aug 09, 2021 at 10:10:42AM -0300, Daniel Henrique Barboza wrote: The PMCC (PMC Control) bit in the MMCR0 register controls whether the counters PMC5 and PMC6 are being part of the performance monitor facility in a specific time. If PMCC allows

Re: [PATCH] tcg: Remove tcg_global_reg_new defines

2021-08-16 Thread Richard Henderson
On 8/16/21 4:35 AM, Bin Meng wrote: Since commit 1c2adb958fc0 ("tcg: Initialize cpu_env generically"), these tcg_global_reg_new_ macros are not used anywhere. Signed-off-by: Bin Meng --- include/tcg/tcg-op.h| 2 -- target/hppa/translate.c | 3 --- 2 files changed, 5 deletions(-)

Re: [PATCH] accel/tcg: remove redundant TCG_KICK_PERIOD define

2021-08-16 Thread Richard Henderson
On 8/11/21 4:12 AM, Luc Michel wrote: The TCG_KICK_PERIOD macro is already defined in tcg-accel-ops-rr.h. Remove it from tcg-accel-ops-rr.c. Signed-off-by: Luc Michel --- accel/tcg/tcg-accel-ops-rr.c | 2 -- 1 file changed, 2 deletions(-) Queued. r~

Re: [PATCH] Acceptance tests: add myself as a reviewer for the acceptance tests.

2021-08-16 Thread Wainer dos Santos Moschetta
Hi Willian, The "Acceptance (Integration) Testing with the Avocado framework" section hasn't any formal maintainer but I always considered Cleber the de-facto one. In this case I don't know whether my acknowledgement is taken in account or not; anyway, you got it from me: Acked-by: Wainer

Re: [PATCH] tests/acceptance: Allow overwrite smp and memory

2021-08-16 Thread Wainer dos Santos Moschetta
Hi Ahmed, Sorry for taking longer to reply you as I just returned from vacation. On 8/2/21 7:22 PM, Ahmed Abouzied wrote: Removes the hard-coded values in setUp(). Class inheriting from avocado_qemu.LinuxTest can overwrite the default smp and memory instead. Resolves:

Re: [PATCH for-6.2 5/7] linux-user: Provide new force_sig_fault() function

2021-08-16 Thread Richard Henderson
On 8/15/21 11:03 PM, Peter Maydell wrote: On Sun, 15 Aug 2021 at 21:10, Richard Henderson wrote: On 8/13/21 3:18 AM, Peter Maydell wrote: +void force_sig_fault(int sig, int code, abi_ulong addr) Better as abi_ptr? I followed the same type used for 'addr' in the target_siginfo_t struct

Re: [RFC PATCH 00/13] Add support for Mirror VM.

2021-08-16 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 16/08/21 15:25, Ashish Kalra wrote: > > From: Ashish Kalra > > > > This is an RFC series for Mirror VM support that are > > essentially secondary VMs sharing the encryption context > > (ASID) with a primary VM. The patch-set creates a new > > VM

Re: [PATCH] tests/acceptance: Test powernv machines

2021-08-16 Thread Wainer dos Santos Moschetta
Hi Cédric, On 8/11/21 11:54 AM, Cédric Le Goater wrote: On 8/11/21 11:07 AM, Thomas Huth wrote: On 10/08/2021 11.09, Cédric Le Goater wrote: On 8/10/21 10:36 AM, Joel Stanley wrote: On Tue, 10 Aug 2021 at 08:34, Cédric Le Goater wrote: Fetch the OpenPOWER images to boot the powernv8 and

[PATCH RFC v2 16/16] vfio-user: migration support

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 18 + hw/vfio/user.h | 3 +++ hw/vfio/common.c| 23 - hw/vfio/migration.c | 34

[PATCH RFC v2 12/16] vfio-user: proxy container connect/disconnect

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/vfio/vfio-common.h | 3 ++ hw/vfio/common.c | 84 +++ hw/vfio/pci.c | 22 + 3 files changed,

[PATCH RFC v2 13/16] vfio-user: dma map/unmap operations

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson --- hw/vfio/user-protocol.h | 32 + hw/vfio/user.h| 6 ++ include/hw/vfio/vfio-common.h | 1 + hw/vfio/common.c | 71

[PATCH RFC v2 01/16] vfio-user: introduce vfio-user protocol specification

2021-08-16 Thread Elena Ufimtseva
From: Thanos Makatos This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and concepts. This patch is sourced

[PATCH RFC v2 10/16] vfio-user: pci_user_realize PCI setup

2021-08-16 Thread Elena Ufimtseva
From: John Johnson PCI BARs read from remote device PCI config reads/writes sent to remote server Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.c | 210 +- 1 file changed, 175

[PATCH RFC v2 02/16] vfio-user: add VFIO base abstract class

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Add an abstract base class both the kernel driver and user socket implementations can use to share code. Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h | 16 +++-- hw/vfio/pci.c | 63

[PATCH RFC v2 08/16] vfio-user: get region info

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 14 +++ hw/vfio/user.h| 2 + include/hw/vfio/vfio-common.h | 3 ++ hw/vfio/common.c | 76

[PATCH RFC v2 14/16] vfio-user: dma read/write operations

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 11 +++ hw/vfio/user.h | 1 + hw/vfio/pci.c | 63 - hw/vfio/user.c | 7

[PATCH RFC v2 15/16] vfio-user: pci reset

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user.h | 1 + hw/vfio/pci.c | 29 ++--- hw/vfio/user.c | 12 3 files changed, 39 insertions(+), 3 deletions(-) diff --git

[PATCH RFC v2 11/16] vfio-user: get and set IRQs

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 25 ++ hw/vfio/user.h | 2 + hw/vfio/common.c| 26 -- hw/vfio/pci.c | 31 ++-- hw/vfio/user.c

[PATCH RFC v2 06/16] vfio-user: negotiate version with remote server

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson --- hw/vfio/user-protocol.h | 23 hw/vfio/user.h | 1 + hw/vfio/pci.c | 9 ++ hw/vfio/user.c | 267

[PATCH RFC v2 07/16] vfio-user: get device info

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 13 + hw/vfio/user.h | 1 + hw/vfio/pci.c | 13 + hw/vfio/user.c | 20 4

[PATCH RFC v2 05/16] vfio-user: define VFIO Proxy and communication functions

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 62 + hw/vfio/user.h | 8 ++ hw/vfio/pci.c | 6 + hw/vfio/user.c | 289

[PATCH RFC v2 03/16] vfio-user: Define type vfio_user_pci_dev_info

2021-08-16 Thread Elena Ufimtseva
From: John Johnson New class for vfio-user with its class and instance constructors and destructors, and its pci ops. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h | 9 ++ hw/vfio/pci.c | 86

[PATCH RFC v2 04/16] vfio-user: connect vfio proxy to remote server

2021-08-16 Thread Elena Ufimtseva
From: John Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user.h| 66 ++ include/hw/vfio/vfio-common.h | 2 + hw/vfio/pci.c | 29 ++ hw/vfio/user.c| 160

  1   2   3   >