[PATCH v2] target/ppc: Fix the test raising the decrementer exception

2021-10-04 Thread Cédric Le Goater
Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Reported-by: Coverity CID 1464061 Fixes: 4d9b8ef9b5ab ("target/ppc: Fix

Re: [PATCH v2 1/2] hw/adc: Add basic Aspeed ADC model

2021-10-04 Thread Peter Delevoryas
> On Oct 4, 2021, at 12:49 AM, Cédric Le Goater wrote: > > On 10/3/21 21:18, p...@fb.com wrote: >> From: Andrew Jeffery >> This model implements enough behaviour to do basic functionality tests >> such as device initialisation and read out of dummy sample values. The >> sample value

[PATCH v3 1/2] hw/adc: Add basic Aspeed ADC model

2021-10-04 Thread pdel
From: Andrew Jeffery This model implements enough behaviour to do basic functionality tests such as device initialisation and read out of dummy sample values. The sample value generation strategy is similar to the STM ADC already in the tree. Signed-off-by: Andrew Jeffery [clg : support for

[PATCH v3 0/2] hw/adc: Add basic Aspeed ADC model

2021-10-04 Thread pdel
From: Peter Delevoryas v1: https://lore.kernel.org/qemu-devel/20211002214414.2858382-1-p...@fbc.om/ v2: https://lore.kernel.org/qemu-devel/20211003191850.513658-1-p...@fb.com/ v3: - Reduced the minimum access size to 2, to allow 16-bit reads - Shifted the read value down 16 bits when

[PATCH v3 2/2] hw/arm: Integrate ADC model into Aspeed SoC

2021-10-04 Thread pdel
From: Andrew Jeffery Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater Signed-off-by: Peter Delevoryas --- hw/arm/aspeed_ast2600.c | 11 +++ hw/arm/aspeed_soc.c | 11 +++ include/hw/arm/aspeed_soc.h | 2 ++ 3 files changed, 24 insertions(+) diff

Re: [PATCH] target/ppc: Fix test the decrementer exception

2021-10-04 Thread Cédric Le Goater
in Subject: s/test// On 10/4/21 23:45, BALATON Zoltan wrote: On Mon, 4 Oct 2021, Cédric Le Goater wrote: Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-04 Thread Christophe Leroy
Le 05/10/2021 à 02:48, David Gibson a écrit : On Fri, Oct 01, 2021 at 04:18:49PM +0200, Thomas Huth wrote: On 01/10/2021 15.04, Christophe Leroy wrote: Le 01/10/2021 à 14:04, Thomas Huth a écrit : On 01/10/2021 13.12, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote:

Re: [PATCH v2 1/2] tcg: add dup_const_tl wrapper

2021-10-04 Thread Richard Henderson
On 10/3/21 2:42 PM, Philipp Tomsich wrote: dup_const always generates a uint64_t, which may exceed the size of a target_long (generating warnings with recent-enough compilers). To ensure that we can use dup_const both for 64bit and 32bit targets, this adds dup_const_tl, which either maps back

Re: [PATCH 0/2] tests/docker: Fix fedora-i386-cross

2021-10-04 Thread Richard Henderson
On 9/30/21 9:36 AM, Richard Henderson wrote: Richard Henderson (2): tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES tests/docker: Fix fedora-i386-cross Queuing to tcg-next, just because I'm preparing a PR. r~

Re: [PATCH] MAINTAINERS: Split HPPA TCG vs HPPA machines/hardware

2021-10-04 Thread Richard Henderson
On 10/4/21 1:38 AM, Philippe Mathieu-Daudé wrote: Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to the 'HP-PARISC Machines' section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [PULL 0/5] Trivial branch for 6.2 patches

2021-10-04 Thread Richard Henderson
On 10/4/21 1:30 AM, Laurent Vivier wrote: The following changes since commit 30bd1db58b09c12b68c35f041f919014b885482d: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2021-10-03 08:45:19 -0400) are available in the Git repository at:

Re: [PATCH] spapr/xive: Add source status helpers

2021-10-04 Thread David Gibson
On Mon, Oct 04, 2021 at 11:21:41PM +0200, Cédric Le Goater wrote: > and use them to set and test the ASSERTED bit of LSI sources. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-6.2, thanks. > --- > include/hw/ppc/xive.h| 24 > hw/intc/spapr_xive.c | 2

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-04 Thread David Gibson
On Fri, Oct 01, 2021 at 04:18:49PM +0200, Thomas Huth wrote: > On 01/10/2021 15.04, Christophe Leroy wrote: > > > > > > Le 01/10/2021 à 14:04, Thomas Huth a écrit : > > > On 01/10/2021 13.12, Peter Maydell wrote: > > > > On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: > > > > > Nevertheless, as

Re: [PATCH 1/2] target/ppc: Use tcg_constant_i32() in gen_setb()

2021-10-04 Thread David Gibson
On Sun, Oct 03, 2021 at 04:17:10PM +0200, Philippe Mathieu-Daudé wrote: > Avoid using TCG temporaries for the -1 and 8 constant values. > > Signed-off-by: Philippe Mathieu-Daudé Both patches applied to ppc-for-6.2, thanks. > --- > target/ppc/translate.c | 8 ++-- > 1 file changed, 2

Re: [PULL 00/26] Linux user for 6.2 patches

2021-10-04 Thread Richard Henderson
) Pull request linux-user 20211004 Move signal trampolines to new page Richard Henderson (26): linux-user: Add infrastructure for a signal trampoline page linux-user/aarch64: Implement setup_sigtramp linux-user/arm: Drop v1

Re: [PATCH v0 0/2] virtio-blk and vhost-user-blk cross-device migration

2021-10-04 Thread Roman Kagan
On Mon, Oct 04, 2021 at 11:11:00AM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 04, 2021 at 06:07:29PM +0300, Denis Plotnikov wrote: > > It might be useful for the cases when a slow block layer should be replaced > > with a more performant one on running VM without stopping, i.e. with very > >

Re: Rust in Qemu BoF followup 2: Rust toolchain availability

2021-10-04 Thread David Gibson
On Thu, Sep 30, 2021 at 11:30:20AM +0100, Peter Maydell wrote: > On Thu, 30 Sept 2021 at 03:21, David Gibson > wrote: > > > > Hi again all, > > > > I've now done.. or at least started... the second part of my followup > > from the KVM Forum BoF on Rust in Qemu. > > > > I've extended the page at

[PATCH v4 1/3] docs: remove non-reference uses of single backticks

2021-10-04 Thread John Snow
The single backtick markup in ReST is the "default role". Currently, Sphinx's default role is called "content". Sphinx suggests you can use the "Any" role instead to turn any single-backtick enclosed item into a cross-reference. This is useful for things like autodoc for Python docstrings, where

[PATCH v4 3/3] docs/sphinx: change default role to "any"

2021-10-04 Thread John Snow
This interprets single-backtick syntax in all of our Sphinx docs as a cross-reference to *something*, including Python symbols. >From here on out, new uses of `backticks` will cause a build failure if the target cannot be referenced. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost

[PATCH v4 2/3] docs: (further) remove non-reference uses of single backticks

2021-10-04 Thread John Snow
The series rotted already. Here's the new changes. Signed-off-by: John Snow --- docs/system/i386/sgx.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/i386/sgx.rst b/docs/system/i386/sgx.rst index f103ae2a2fd..9aa161af1a1 100644 ---

[PATCH v4 0/3] docs/sphinx: change default `role` to "any"

2021-10-04 Thread John Snow
V4: Fixed more occurrences that have occurred since V3. V3: Removed bad rebase confetti fixed the OSS-Fuzz link to ... actually be a link. (Patch 2 can be squashed into patch 1 on merge, but this keeps the diff easy to see and review.) --js John Snow (3): docs: remove non-reference uses

Re: [PATCH] target/ppc: Fix test the decrementer exception

2021-10-04 Thread BALATON Zoltan
On Mon, 4 Oct 2021, Cédric Le Goater wrote: Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Fixes: Coverity CID 1464061

[PATCH] target/ppc: Fix test the decrementer exception

2021-10-04 Thread Cédric Le Goater
Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Fixes: Coverity CID 1464061 Signed-off-by: Cédric Le Goater ---

[PATCH v2 10/12] macfb: fix 24-bit RGB pixel encoding

2021-10-04 Thread Mark Cave-Ayland
According to Apple Technical Note HW26: "Macintosh Quadra Built-In Video" the in-built framebuffer encodes each 24-bit pixel into 4 bytes. Adjust the 24-bit RGB pixel encoding accordingly which agrees with the encoding expected by MacOS when changing into 24-bit colour mode. Signed-off-by: Mark

[PATCH v2 09/12] macfb: fix up 1-bit pixel encoding

2021-10-04 Thread Mark Cave-Ayland
The MacOS driver expects the RGB values for the pixel to be in entries 0 and 1 of the colour palette. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/display/macfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/display/macfb.c

[PATCH v2 04/12] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer

2021-10-04 Thread Mark Cave-Ayland
Currently macfb_common_realize() defines the framebuffer RAM memory region as being non-migrateable but then immediately registers it for migration. Replace memory_region_init_ram_nomigrate() with memory_region_init_ram() which is clearer and does exactly the same thing. Signed-off-by: Mark

Re: [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 2:32 PM John Snow wrote: > > > On Mon, Oct 4, 2021 at 6:12 AM Hanna Reitz wrote: > >> On 18.09.21 04:14, John Snow wrote: >> > >> > >> > On Fri, Sep 17, 2021 at 8:58 PM John Snow > > > wrote: >> > >> > >> > >> > On Fri, Sep 17, 2021 at 10:30

[PATCH v2 03/12] macfb: fix overflow of color_palette array

2021-10-04 Thread Mark Cave-Ayland
The palette_current index counter has a maximum size of 256 * 3 to cover a full color palette of 256 RGB entries. Linux assumes that the palette_current index wraps back around to zero after writing 256 RGB entries so ensure that palette_current is reset at this point to prevent data corruption

[PATCH v2 00/12] macfb: fixes for booting MacOS

2021-10-04 Thread Mark Cave-Ayland
This is the next set of patches to allow users to boot MacOS in QEMU's q800 machine. Patches 1 to 3 are fixes for existing bugs that I discovered whilst developing the remainder of the patchset whilst patch 4 simplifies the registration of the framebuffer RAM. Patch 5 adds trace events to the

[PATCH] spapr/xive: Add source status helpers

2021-10-04 Thread Cédric Le Goater
and use them to set and test the ASSERTED bit of LSI sources. Signed-off-by: Cédric Le Goater --- include/hw/ppc/xive.h| 24 hw/intc/spapr_xive.c | 2 +- hw/intc/spapr_xive_kvm.c | 10 +++--- hw/intc/xive.c | 8 4 files changed, 32

[PATCH v2 11/12] macfb: add vertical blank interrupt

2021-10-04 Thread Mark Cave-Ayland
The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by the framebuffer which in turn schedules the mouse driver via the Vertical Retrace Manager. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/display/macfb.c | 83

Re: [PATCH v6 09/10] ACPI ERST: bios-tables-test testcase

2021-10-04 Thread Eric DeVolder
On 9/21/21 6:32 AM, Igor Mammedov wrote: On Thu, 5 Aug 2021 18:30:38 -0400 Eric DeVolder wrote: This change implements the test suite checks for the ERST table. Signed-off-by: Eric DeVolder --- tests/qtest/bios-tables-test.c | 43 ++ 1 file

[PATCH v2 12/12] q800: wire macfb IRQ to separate video interrupt on VIA2

2021-10-04 Thread Mark Cave-Ayland
Whilst the in-built Quadra 800 framebuffer exists within the Nubus address space for slot 9, it has its own dedicated interrupt on VIA2. Force the macfb device to occupy slot 9 in the q800 machine and wire its IRQ to the separate video interrupt since this is what is expected by the MacOS

[PATCH v2 08/12] macfb: add common monitor modes supported by the MacOS toolbox ROM

2021-10-04 Thread Mark Cave-Ayland
The monitor modes table is found by experimenting with the Monitors Control Panel in MacOS and analysing the reads/writes. From this it can be found that the mode is controlled by writes to the DAFB_MODE_CTRL1 and DAFB_MODE_CTRL2 registers. Implement the first block of DAFB registers as a

[PATCH v2 06/12] macfb: implement mode sense to allow display type to be detected

2021-10-04 Thread Mark Cave-Ayland
The MacOS toolbox ROM uses the monitor sense to detect the display type and then offer a fixed set of resolutions and colour depths accordingly. Implement the monitor sense using information found in Apple Technical Note HW26: "Macintosh Quadra Built-In Video" along with some local experiments.

[PATCH v2 07/12] macfb: add qdev property to specify display type

2021-10-04 Thread Mark Cave-Ayland
Since the available resolutions and colour depths are determined by the attached display type, add a qdev property to allow the display type to be specified. The main resolutions of interest are high resolution 1152x870 with 8-bit colour and SVGA resolution up to 800x600 with 32-bit colour so

[PATCH 12/13] python: Add iotest linters to test suite

2021-10-04 Thread John Snow
Run mypy and pylint on the iotests files directly from the Python CI test infrastructure. This ensures that any accidental breakages to the qemu.[qmp|aqmp|machine|utils] packages will be caught by that test suite. It also ensures that these linters are run with well-known versions and test

[PATCH v2 01/12] macfb: handle errors that occur during realize

2021-10-04 Thread Mark Cave-Ayland
Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan Reviewed-by: Laurent Vivier --- hw/display/macfb.c

[PATCH v2 05/12] macfb: add trace events for reading and writing the control registers

2021-10-04 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/display/macfb.c | 8 +++- hw/display/trace-events | 4 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index

[PATCH v2 02/12] macfb: fix invalid object reference in macfb_common_realize()

2021-10-04 Thread Mark Cave-Ayland
During realize memory_region_init_ram_nomigrate() is used to initialise the RAM memory region used for the framebuffer but the owner object reference is incorrect since MacFbState is a typedef and not a QOM type. Change the memory region owner to be the corresponding DeviceState to fix the issue

[PATCH 10/13] iotests/linters: Add entry point for linting via Python CI

2021-10-04 Thread John Snow
We need at least a tiny little shim here to join test file discovery with test invocation. This logic could conceivably be hosted somewhere in python/, but I felt it was strictly the least-rude thing to keep the test logic here in iotests/, even if this small function isn't itself an iotest. Note

Re: [PATCH 09/13] virtiofsd: Specify size of notification buffer using config space

2021-10-04 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 03:33:47PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:33AM -0400, Vivek Goyal wrote: > > Daemon specifies size of notification buffer needed and that should be > > done using config space. > > > > Only ->notify_buf_size value of config space comes from

Re: [PATCH v6 10/10] ACPI ERST: step 6 of bios-tables-test

2021-10-04 Thread Eric DeVolder
On 9/21/21 6:24 AM, Igor Mammedov wrote: On Thu, 5 Aug 2021 18:30:39 -0400 Eric DeVolder wrote: Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6, the re-generated ACPI tables binary blobs. commit message should include ASL diff for new/changed content for

Re: [PATCH v6 05/10] ACPI ERST: support for ACPI ERST feature

2021-10-04 Thread Eric DeVolder
Igor, thanks for the close examination. Inline responses below. eric On 9/21/21 10:30 AM, Igor Mammedov wrote: On Thu, 5 Aug 2021 18:30:34 -0400 Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by

[PATCH 13/13] iotests: [RFC] drop iotest 297

2021-10-04 Thread John Snow
(This is highlighting a what-if, which might make it clear why any special infrastructure is still required at all. It's not intended to actually be merged at this step -- running JUST the iotest linters from e.g. 'make check' is not yet accommodated, so there's no suitable replacement for 297 for

[PATCH 11/13] iotests/linters: Add workaround for mypy bug #9852

2021-10-04 Thread John Snow
This one is insidious: if you write an import as "from {namespace} import {subpackage}" as mirror-top-perms (now) does, mypy will fail on every-other invocation *if* the package being imported is a typed, installed, namespace-scoped package. Upsettingly, that's exactly what

[PATCH 06/13] iotests/297: Separate environment setup from test execution

2021-10-04 Thread John Snow
Move environment setup into main(), leaving pure test execution behind in run_linters(). Signed-off-by: John Snow --- tests/qemu-iotests/297 | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index

[PATCH 07/13] iotests/297: Split run_linters apart into run_pylint and run_mypy

2021-10-04 Thread John Snow
Signed-off-by: John Snow --- Note, this patch really ought to be squashed with the next one, but I am performing a move known as "Hedging my bets." It's easier to squash than de-squash :) Signed-off-by: John Snow --- tests/qemu-iotests/297 | 19 --- 1 file changed, 12

[PATCH 03/13] iotests/297: Add get_files() function

2021-10-04 Thread John Snow
Split out file discovery into its own method to begin separating out configuration/setup and test execution. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index

[PATCH 09/13] iotests: split linters.py out from 297

2021-10-04 Thread John Snow
Now, 297 is just the iotests-specific incantations and linters.py is as minimal as I can think to make it. The only remaining element in here that ought to be configuration and not code is the list of skip files, but they're still numerous enough that repeating them for mypy and pylint

[PATCH 05/13] iotests/297: Create main() function

2021-10-04 Thread John Snow
Instead of running "run_linters" directly, create a main() function that will be responsible for environment setup, leaving run_linters() responsible only for execution of the linters. (That environment setup will be moved over in forthcoming commits.) Signed-off-by: John Snow Reviewed-by:

[PATCH 01/13] iotests/297: Move pylint config into pylintrc

2021-10-04 Thread John Snow
Move --score=n and --notes=XXX,FIXME into pylintrc. This pulls configuration out of code, which I think is probably a good thing in general. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 4 +--- tests/qemu-iotests/pylintrc | 16 2 files changed, 17 insertions(+),

[PATCH 08/13] iotests/297: refactor run_[mypy|pylint] as generic execution shim

2021-10-04 Thread John Snow
There's virtually nothing special here anymore; we can combine these into a single, rather generic function. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 46 +++--- 1 file changed, 25 insertions(+), 21 deletions(-) diff --git

[PATCH 02/13] iotests/297: Split mypy configuration out into mypy.ini

2021-10-04 Thread John Snow
More separation of code and configuration. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 14 +- tests/qemu-iotests/mypy.ini | 12 2 files changed, 13 insertions(+), 13 deletions(-) create mode 100644 tests/qemu-iotests/mypy.ini diff --git

[PATCH 00/13] python/iotests: Run iotest linters during Python CI

2021-10-04 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt2 CI: https://gitlab.com/jsnow/qemu/-/pipelines/382320226 Based-on: <20210923180715.4168522-1-js...@redhat.com> [PATCH v2 0/6] iotests: update environment and linting configuration (Staged at kwolf/block

[PATCH 04/13] iotests/297: Don't rely on distro-specific linter binaries

2021-10-04 Thread John Snow
'pylint-3' is another Fedora-ism. Use "python3 -m pylint" or "python3 -m mypy" to access these scripts instead. This style of invocation will prefer the "correct" tool when run in a virtual environment. Note that we still check for "pylint-3" before the test begins -- this check is now "overly

Invitation: QAPI Sync meeting @ Thu Oct 7, 2021 9am - 10am (EDT) (qemu-devel@nongnu.org)

2021-10-04 Thread jsnow
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20211007T13Z DTEND:20211007T14Z DTSTAMP:20211004T210146Z ORGANIZER;CN=js...@redhat.com:mailto:js...@redhat.com UID:72pav8a9ib0m49k8qr9hjib...@google.com

Re: [PATCH 08/13] virtiofsd: Create a notification queue

2021-10-04 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 03:30:38PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:32AM -0400, Vivek Goyal wrote: > > Add a notification queue which will be used to send async notifications > > for file lock availability. > > > > Signed-off-by: Vivek Goyal > > Signed-off-by:

Re: [PATCH v6 02/10] ACPI ERST: specification for ERST support

2021-10-04 Thread Eric DeVolder
On 9/20/21 8:38 AM, Igor Mammedov wrote: On Thu, 5 Aug 2021 18:30:31 -0400 Eric DeVolder wrote: Information on the implementation of the ACPI ERST support. Signed-off-by: Eric DeVolder modulo missing parts documentation looks good to but I'm tainted at this point (after so many

Re: [PATCH v6 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-10-04 Thread Eric DeVolder
On 9/20/21 8:05 AM, Igor Mammedov wrote: On Thu, 5 Aug 2021 18:30:30 -0400 Eric DeVolder wrote: Following the guidelines in tests/qtest/bios-tables-test.c, this change adds empty placeholder files per step 1 for the new ERST table, and excludes resulting changed files in

Re: virtio 4M limit

2021-10-04 Thread Christian Schoenebeck
On Montag, 4. Oktober 2021 21:59:18 CEST Michael S. Tsirkin wrote: > On Mon, Oct 04, 2021 at 12:44:21PM +0200, Christian Schoenebeck wrote: > > On Sonntag, 3. Oktober 2021 22:27:03 CEST Michael S. Tsirkin wrote: > > > On Sun, Oct 03, 2021 at 08:14:55PM +0200, Christian Schoenebeck wrote: > > > >

[PATCH v2 2/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

2021-10-04 Thread Christian Schoenebeck
Raise the maximum possible virtio transfer size to 128M (more precisely: 32k * PAGE_SIZE). See previous commit for a more detailed explanation for the reasons of this change. For not breaking any virtio user, all virtio users transition to using the new macro VIRTQUEUE_LEGACY_MAX_SIZE instead of

Re: [PATCH 3/4] MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware

2021-10-04 Thread Jiaxun Yang
在 2021/10/4 10:25, Philippe Mathieu-Daudé 写道: Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to a new 'Overall MIPS Machines' section in the 'MIPS Machines' group. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Thanks. - Jiaxun ---

[PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

2021-10-04 Thread Christian Schoenebeck
At the moment the maximum transfer size with virtio is limited to 4M (1024 * PAGE_SIZE). This series raises this limit to its maximum theoretical possible transfer size of 128M (32k pages) according to the virtio specs:

[PATCH v2 1/3] virtio: turn VIRTQUEUE_MAX_SIZE into a variable

2021-10-04 Thread Christian Schoenebeck
Refactor VIRTQUEUE_MAX_SIZE to effectively become a runtime variable per virtio user. Reasons: (1) VIRTQUEUE_MAX_SIZE should reflect the absolute theoretical maximum queue size possible. Which is actually the maximum queue size allowed by the virtio protocol. The appropriate value

Re: [PATCH 4/4] MAINTAINERS: Agree to maintain nanoMIPS TCG frontend

2021-10-04 Thread Jiaxun Yang
在 2021/10/4 10:25, Philippe Mathieu-Daudé 写道: As of this commit, the nanoMIPS toolchains haven't been merged in mainstream projects. However MediaTek provides a toolchain: https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01 Since I now have spent more

[PATCH v2 3/3] virtio-9p-device: switch to 32k max. transfer size

2021-10-04 Thread Christian Schoenebeck
9pfs supports the new maximum virtio queue size of 32k, so let's switch the 9pfs virtio transport from 1k to 32k. This will allow a maximum 'msize' option (maximum message size) by 9p client of approximately 128M (assuming 4k page size, in practice slightly smaller, e.g. with Linux client minus 2

Re: [PATCH 2/4] MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware

2021-10-04 Thread Jiaxun Yang
在 2021/10/4 10:25, Philippe Mathieu-Daudé 写道: MIPS CPS and GIC models are unrelated to the TCG frontend. Move them as new sections under the 'Devices' group. Cc: Paul Burton Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Thanks. - Jiaxun --- MAINTAINERS | 22

Re: [PATCH 1/4] MAINTAINERS: Add MIPS general architecture support entry

2021-10-04 Thread Jiaxun Yang
在 2021/10/4 10:25, Philippe Mathieu-Daudé 写道: The architecture is covered in TCG (frontend and backend) and hardware models. Add a generic section matching the 'mips' word in patch subjects. Cc: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Thanks. - Jiaxun

Re: virtio 4M limit

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 12:44:21PM +0200, Christian Schoenebeck wrote: > On Sonntag, 3. Oktober 2021 22:27:03 CEST Michael S. Tsirkin wrote: > > On Sun, Oct 03, 2021 at 08:14:55PM +0200, Christian Schoenebeck wrote: > > > On Freitag, 1. Oktober 2021 13:21:23 CEST Christian Schoenebeck wrote: > > >

Re: [PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-10-04 Thread Vivek Goyal
On Mon, Oct 04, 2021 at 02:54:17PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 30, 2021 at 11:30:30AM -0400, Vivek Goyal wrote: > > Add helpers to create/cleanup virtuqueues and use those helpers. I will > > s/virtuqueues/virtqueues/ > > > need to reconfigure queues in later patches and using

Re: Moving QEMU downloads to GitLab Releases?

2021-10-04 Thread Michael Roth
Quoting Stefan Hajnoczi (2021-10-04 04:01:22) > On Fri, Oct 01, 2021 at 09:39:13AM +0200, Philippe Mathieu-Daudé wrote: > > On 9/30/21 15:40, Stefan Hajnoczi wrote: > > > Hi Mike, > > > QEMU downloads are currently hosted on qemu.org's Apache web server. > > > Paolo and I were discussing ways to

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 3:45 AM Hanna Reitz wrote: > On 22.09.21 22:18, John Snow wrote: > > > > > > On Fri, Sep 17, 2021 at 7:00 AM Hanna Reitz > > wrote: > > [...] > > > > > As you say, run_linters() to me seems very iotests-specific still: It > > emits a

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Michael S. Tsirkin
On Mon, Oct 04, 2021 at 05:50:44PM +0200, Cornelia Huck wrote: > On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > > > On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote: > >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > >> > >> > On Mon, Oct 04, 2021 at 02:19:55PM +0200,

Re: [PATCH v3 07/16] iotests/297: Don't rely on distro-specific linter binaries

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 4:17 AM Hanna Reitz wrote: > On 22.09.21 21:53, John Snow wrote: > > (This email just explains python packaging stuff. No action items in > > here. Skim away.) > > > > On Fri, Sep 17, 2021 at 5:43 AM Hanna Reitz > > wrote: > > > > On 16.09.21

Re: [PATCH 11/12] macfb: add vertical blank interrupt

2021-10-04 Thread Mark Cave-Ayland
On 04/10/2021 17:32, Laurent Vivier wrote: Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by the framebuffer which in turn schedules the mouse driver via the Vertical Retrace Manager. Signed-off-by: Mark

Re: [PATCH 03/12] macfb: fix overflow of color_palette array

2021-10-04 Thread Mark Cave-Ayland
On 04/10/2021 09:53, Laurent Vivier wrote: Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : The palette_current index counter has a maximum size of 256 * 3 to cover a full color palette of 256 RGB entries. Linux assumes that the palette_current index wraps back around to zero after writing

Re: [PATCH 07/12] macfb: add qdev property to specify display type

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 15:04, Philippe Mathieu-Daudé wrote: On 10/2/21 13:00, Mark Cave-Ayland wrote: Since the available resolutions and colour depths are determined by the attached display type, add a qdev property to allow the display type to be specified. The main resolutions of interest are high

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-10-04 Thread Luis Machado
Hi, On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: Claudio Fontana writes: On 1/19/21 3:50 PM, Alex Bennée wrote: Claudio Fontana writes: qemu-system-aarch64: -gdb unix:path=/tmp/tmp9ru5tgk8qemu-gdbstub/gdbstub.socket,server: info: QEMU

Re: [PATCH 01/12] macfb: handle errors that occur during realize

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 14:47, Philippe Mathieu-Daudé wrote: On 10/2/21 12:59, Mark Cave-Ayland wrote: Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by:

Re: [PATCH 01/12] macfb: handle errors that occur during realize

2021-10-04 Thread Mark Cave-Ayland
On 02/10/2021 12:36, BALATON Zoltan wrote: On Sat, 2 Oct 2021, Mark Cave-Ayland wrote: Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark

Re: [PATCH v3 05/19] docs/devel: document expectations for HMP commands in the future

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:35PM +0100, Daniel P. Berrangé wrote: > We no longer wish to have commands implemented in HMP only. All commands > should start with a QMP implementation and the HMP merely be a shim > around this. To reduce the burden of implementing QMP commands where > there is low

Re: [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes

2021-10-04 Thread John Snow
On Mon, Oct 4, 2021 at 6:12 AM Hanna Reitz wrote: > On 18.09.21 04:14, John Snow wrote: > > > > > > On Fri, Sep 17, 2021 at 8:58 PM John Snow > > wrote: > > > > > > > > On Fri, Sep 17, 2021 at 10:30 AM Hanna Reitz > > wrote: > > > >

Re: [PATCH v3 04/19] docs/devel: add example of command returning unstructured text

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:34PM +0100, Daniel P. Berrangé wrote: > This illustrates how to add a QMP command returning unstructured text, > following the guidelines added in the previous patch. The example uses > a simplified version of 'info roms'. > > Signed-off-by: Daniel P. Berrangé > ---

Re: [PULL 00/12] jobs: mirror: Handle errors after READY cancel

2021-10-04 Thread Vladimir Sementsov-Ogievskiy
10/4/21 19:47, Hanna Reitz wrote: On 24.09.21 00:01, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 22:19, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 19:05, Richard Henderson wrote: On 9/21/21 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit

RE: [PATCH v3 0/9] hw/nvram: hw/arm: Introduce Xilinx eFUSE and BBRAM

2021-10-04 Thread Tong Ho
Hi Peter, I will follow up with patches to fix the memory leaks. Where can I get a copy of the Coverity reports that have the 10 issues you indicated? Thanks, Tong -Original Message- From: Peter Maydell Sent: Saturday, October 2, 2021 3:28 AM To: Tong Ho Cc: qemu-arm ; QEMU

Re: [PATCH v4 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

2021-10-04 Thread Dov Murik
On 04/10/2021 11:03, Paolo Bonzini wrote: > Queued, thanks. However, it would be nice to have a documentation of > all our SEV firmware interfaces somewhere in docs/specs/. Thanks Paolo. I'll try to arrange a skeleton for such document. So far I think we have the following interfaces: 1.

Re: [PULL 00/12] jobs: mirror: Handle errors after READY cancel

2021-10-04 Thread Hanna Reitz
On 24.09.21 00:01, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 22:19, Vladimir Sementsov-Ogievskiy wrote: 22.09.2021 19:05, Richard Henderson wrote: On 9/21/21 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 326ff8dd09556fc2e257196c49f35009700794ac:   

Re: [PATCH 11/12] macfb: add vertical blank interrupt

2021-10-04 Thread Laurent Vivier
Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > The MacOS driver expects a 60.15Hz vertical blank interrupt to be generated by > the framebuffer which in turn schedules the mouse driver via the Vertical > Retrace > Manager. > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/macfb.c

Re: [RFC] hw/arm/virt-acpi-build: Add IORT RMR regions to handle MSI nested binding

2021-10-04 Thread Eric Auger
Hi, On 9/28/21 7:44 PM, Eric Auger wrote: > To handle SMMUv3 nested stage support it is practical to > expose the guest with reserved memory regions (RMRs) > covering the IOVAs used by the host kernel to map > physical MSI doorbells. > > Those IOVAs belong to [0x800, 0x810] matching >

Re: [RFC PATCH] .github: move repo lockdown to the v2 configuration

2021-10-04 Thread Willian Rampazzo
On Mon, Oct 4, 2021 at 12:45 PM Alex Bennée wrote: > > I was getting prompted by GitHub for new permissions but it turns out > per https://github.com/dessant/repo-lockdown/issues/6: > > Repo Lockdown has been rewritten for GitHub Actions, offering new > features and better control over your

Re: [PATCH v3 01/19] docs/devel: rename file for writing monitor commands

2021-10-04 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:23:31PM +0100, Daniel P. Berrangé wrote: > The file already covers writing HMP commands, in addition to > the QMP commands, so it deserves a more general name. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/index.rst|

[PATCH 0/4] aspeed/smc: Improve support for the alternate boot function

2021-10-04 Thread Cédric Le Goater
Hello, The Aspeed SoCs have a dual boot function for firmware fail-over recovery. The system auto-reboots from the second flash if the main flash does not boot successfully within a certain amount of time. This function is called alternate boot (ABR) in the FMC controllers. On the AST2600, the

Re: [PATCH v3 07/19] qapi: introduce x-query-roms QMP command

2021-10-04 Thread Daniel P . Berrangé
On Mon, Oct 04, 2021 at 01:32:14PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > This is a counterpart to the HMP "info roms" command. It is being > > added with an "x-" prefix because this QMP command is intended as an > > adhoc debugging tool and

[PATCH 4/4] aspeed/smc: Improve support for the alternate boot function

2021-10-04 Thread Cédric Le Goater
Map the WDT2 registers in the AST2600 FMC memory region by creating a local address space on top of WDT2 memory region. The model only implements the enable bit of the control register. The reload register uses a 0.1s unit instead of a 1us. Values are converted on the fly when doing the accesses.

Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP

2021-10-04 Thread Damien Hedde
Hi, This is both a ping and a small update. It would be great to have some feedback about patches 1 and 3. Right now the device part of this series conflicts with Kevin 's work about replacing the QemuOpts by a QemuDict in device_add:

[PATCH 3/4] aspeed/wdt: Add an alias for the MMIO region

2021-10-04 Thread Cédric Le Goater
Initialize the region in the instance_init handler because we will want to link this region in the FMC object before the WDT object is realized. Cc: Peter Delevoryas Signed-off-by: Cédric Le Goater --- include/hw/watchdog/wdt_aspeed.h | 1 + hw/watchdog/wdt_aspeed.c | 15

Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 04:33:21PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 02:19:55PM +0200, Cornelia Huck wrote: >> >> >> >> [cc:qemu-devel] >> >> >> >> On Sat, Oct 02

Re: [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2

2021-10-04 Thread Alex Bennée
Alex Bennée writes: > From: Philippe Mathieu-Daudé > > The BCM2711 is improvement of the BCM2837: > - Cortex-A72 instead of the A53 > - peripheral block and local soc controller are mapped differently, > - GICv2 > - PCIe block > - exhanced MMU to address over 4GiB of SDRAM > > --- > vAJB: >

[PATCH 2/4] aspeed/smc: Dump address offset in trace events

2021-10-04 Thread Cédric Le Goater
The register index is currently printed and this is confusing. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 7129341c129e..8a988c167604 100644 ---

  1   2   3   >