Re: [PATCH v2] vl: Add support to set properties when using JSON syntax for -device via -set option

2022-01-11 Thread MkfsSion
ping https://lore.kernel.org/qemu-devel/20211224072511.63894-1-mkfss...@mkfssion.com

Re: [PULL 00/13] Net patches

2022-01-11 Thread Jason Wang
On Wed, Jan 12, 2022 at 3:10 PM Roman Bolshakov wrote: > > On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote: > > > > 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: > > > > > > > > > вт, 11 янв. 2022 г., 5:10 AM Jason Wang : > > > > > > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell >

Re: [PATCH v10 0/7] Add vmnet.framework based network backend

2022-01-11 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote: > macOS provides networking API for VMs called 'vmnet.framework': > https://developer.apple.com/documentation/vmnet > > We can provide its support as the new QEMU network backends which > represent three different

Re: [PULL 00/13] Net patches

2022-01-11 Thread Jason Wang
On Wed, Jan 12, 2022 at 2:19 PM Vladislav Yaroshchuk wrote: > > > > ср, 12 янв. 2022 г., 8:39 AM Jason Wang : >> >> >> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: >> > >> > >> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang : >> > >> > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell >> >

Re: [PATCH] clock-vmstate: Add missing END_OF_LIST

2022-01-11 Thread Luc Michel
On 10:19 Tue 11 Jan , Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv > > Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider") > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Luc Michel > ---

Re: [PULL 00/13] Net patches

2022-01-11 Thread Roman Bolshakov
On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote: > > 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: > > > > > > вт, 11 янв. 2022 г., 5:10 AM Jason Wang : > > > > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell > > wrote: > > > > > > On Mon, 10 Jan 2022 at 03:40, Jason

Re: [RFC PATCH v3 5/7] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Roman Bolshakov
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote: > When building on macOS 12 we get: > > audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] >

Re: [PULL 00/13] Net patches

2022-01-11 Thread Vladislav Yaroshchuk
ср, 12 янв. 2022 г., 8:39 AM Jason Wang : > > 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: > > > > > > вт, 11 янв. 2022 г., 5:10 AM Jason Wang : > > > > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell > > wrote: > > > > > > On Mon, 10 Jan 2022 at 03:40, Jason Wang > > wrote:

Re: [PULL 00/13] Net patches

2022-01-11 Thread Jason Wang
在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道: вт, 11 янв. 2022 г., 5:10 AM Jason Wang : On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell wrote: > > On Mon, 10 Jan 2022 at 03:40, Jason Wang wrote: > > > > The following changes since commit

[PATCH v2 4/5] target/s390x: Fix shifting 32-bit values for more than 31 bits

2022-01-11 Thread Ilya Leoshkevich
According to PoP, both 32- and 64-bit shifts use lowest 6 address bits. The current code special-cases 32-bit shifts to use only 5 bits, which is not correct. For example, shifting by 32 bits currently preserves the initial value, however, it's supposed zero it out instead. Fix by merging sh32

Re: [PATCH] target/s390x: Fix 32-bit shifts

2022-01-11 Thread Ilya Leoshkevich
On Tue, 2022-01-11 at 15:22 +0100, David Hildenbrand wrote: > On 10.01.22 19:59, Ilya Leoshkevich wrote: > > Both 32- and 64-bit shifts use lowest 6 address bits. The current > > code > > special-cases 32-bit shifts to use only 5 bits, which is not > > correct. > > > > I assume for 32-bit

[PATCH v2 3/5] target/s390x: Fix cc_calc_sla_64() missing overflows

2022-01-11 Thread Ilya Leoshkevich
An overflow occurs for SLAG when at least one shifted bit is not equal to sign bit. Therefore, we need to check that `shift + 1` bits are neither all 0s nor all 1s. The current code checks only `shift` bits, missing some overflows. Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE")

[PATCH v2 5/5] tests/tcg/s390x: Test shift instructions

2022-01-11 Thread Ilya Leoshkevich
Add a test for each shift instruction in order to to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/shift.c | 258 2 files changed, 259 insertions(+) create mode 100644

[PATCH v2 2/5] target/s390x: Fix SRDA CC calculation

2022-01-11 Thread Ilya Leoshkevich
SRDA uses r1_D32 for binding the first operand and s64 for setting CC. cout_s64() relies on o->out being the shift result, however, wout_r1_D32() clobbers it. Fix by using a temporary. Fixes: a79ba3398a0a ("target-s390: Convert SHIFT DOUBLE") Signed-off-by: Ilya Leoshkevich ---

[PATCH v2 0/5] target/s390x: Fix shift instructions

2022-01-11 Thread Ilya Leoshkevich
v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html v1 -> v2: Fix cc_calc_sla_32(). Fix cc_calc_sla_64(). Fix SLDA sign bit index. Inline help_l2_shift(). Fix wout_r1_D32(). Add all shift instructions to the test.

[PATCH v2 1/5] target/s390x: Fix SLDA sign bit index

2022-01-11 Thread Ilya Leoshkevich
David Hildenbrand noticed that sign bit index for SLDA is wrong: since SLDA operates on 64-bit values, it should be 63, not 31. Fixes: a79ba3398a0a ("target-s390: Convert SHIFT DOUBLE") Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1

RE: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling

2022-01-11 Thread Wang, Wei W
On Wednesday, January 12, 2022 10:51 AM, Zeng, Guang wrote: > To: Tian, Kevin ; Zhong, Yang ; > qemu-devel@nongnu.org > Cc: pbonz...@redhat.com; Christopherson,, Sean ; > jing2@linux.intel.com; Wang, Wei W > Subject: Re: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling > > On 1/11/2022

Re: [PATCH v6 09/23] target/riscv: Implement AIA local interrupt priorities

2022-01-11 Thread Frank Chang
On Wed, Jan 12, 2022 at 1:18 AM Anup Patel wrote: > > > On Mon, Jan 10, 2022 at 6:38 PM Frank Chang > wrote: > > > > Anup Patel 於 2021年12月30日 週四 下午8:38寫道: > >> > >> From: Anup Patel > >> > >> The AIA spec defines programmable 8-bit priority for each local > interrupt > >> at M-level, S-level

Re: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling

2022-01-11 Thread Zeng Guang
On 1/11/2022 10:30 AM, Tian, Kevin wrote: From: Zeng, Guang Sent: Monday, January 10, 2022 5:47 PM On 1/10/2022 4:40 PM, Tian, Kevin wrote: From: Zhong, Yang Sent: Friday, January 7, 2022 5:32 PM From: Jing Liu Extended feature has large state while current kvm_xsave only allows 4KB. Use

[PATCH v2] usb: allow max 8192 bytes for desc

2022-01-11 Thread zhenwei pi
A device of USB video class usually uses larger desc structure, so use larger buffer to avoid failure. (dev-video.c is ready) This is an unlikely code path: 1, during guest startup, guest tries to probe device. 2, run 'lsusb' command in guest(or other similar commands). Reviewed-by: Daniel P.

Re: [PATCH] tests: Fix typo in check-help output

2022-01-11 Thread wangyanan (Y)
On 2022/1/12 1:55, Philippe Mathieu-Daudé wrote: Fix typo in 'make check-help' output. Signed-off-by: Philippe Mathieu-Daudé --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index

Re: [PATCH v1 1/2] hw/i386: Make pit a property of common x86 base machine type

2022-01-11 Thread Xiaoyao Li
+ Paolo On 1/11/2022 3:35 PM, Xiaoyao Li wrote: Both pc and microvm have pit property individually. Let's just make it the property of common x86 base machine type. Signed-off-by: Xiaoyao Li --- hw/i386/microvm.c | 27 +-- hw/i386/pc.c | 24

Re: [PATCH v1 2/2] hw/i386: Make pic a property of common x86 base machine type

2022-01-11 Thread Xiaoyao Li
+ Paolo On 1/11/2022 3:35 PM, Xiaoyao Li wrote: Legacy PIC (8259) cannot be supported for TDX guests since TDX module doesn't allow directly interrupt injection. Using posted interrupts for the PIC is not a viable option as the guest BIOS/kernel will not do EOI for PIC IRQs, i.e. will leave

Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ

2022-01-11 Thread wangyanan (Y)
On 2022/1/12 1:26, Peter Maydell wrote: Fix a comment in qdev-core.h where we incorrectly referred to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. Signed-off-by: Peter Maydell --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC v4 16/21] vfio-user: dma map/unmap operations

2022-01-11 Thread John Johnson
Add ability to do async operations during memory transactions Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson --- hw/vfio/user-protocol.h | 32 +++ include/hw/vfio/vfio-common.h | 9 +- hw/vfio/common.c | 63 +---

Re: [PATCH v3 00/10] hw/dma: Use dma_addr_t type definition when relevant

2022-01-11 Thread Peter Xu
On Tue, Jan 11, 2022 at 07:42:59PM +0100, Philippe Mathieu-Daudé wrote: > Since v2: > - Split meson patch restricting fw_cfg (Richard) > - Reorder pci_dma_map() docstring (Peter, Richard) > - Move QEMUSGList in previous patch (David) > - Have dma_buf_read/dma_buf_write return dma_addr_t (Peter) >

[RFC v4 20/21] vfio-user: migration support

2022-01-11 Thread John Johnson
Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 18 + hw/vfio/migration.c | 30 +-- hw/vfio/pci.c | 7 +++ hw/vfio/user.c | 54

[RFC v4 14/21] vfio-user: get and set IRQs

2022-01-11 Thread John Johnson
Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 25 + hw/vfio/pci.c | 9 +++- hw/vfio/user.c | 131 3 files changed, 163 insertions(+), 2

Re: [PATCH v2 3/4] scripts/qapi-gen.py: add --add-trace-points option

2022-01-11 Thread John Snow
On Thu, Dec 23, 2021 at 6:08 AM Vladimir Sementsov-Ogievskiy wrote: > > Add and option to generate trace points. We should generate both trace > points and trace-events files for further trace point code generation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Philippe

[RFC v4 10/21] vfio-user: get device info

2022-01-11 Thread John Johnson
Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 14 ++ hw/vfio/user.h | 2 ++ hw/vfio/pci.c | 26 ++ hw/vfio/user.c | 44

[RFC v4 15/21] vfio-user: proxy container connect/disconnect

2022-01-11 Thread John Johnson
Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user.h| 1 + include/hw/vfio/vfio-common.h | 3 ++ hw/vfio/common.c | 105 ++ hw/vfio/pci.c | 25

[RFC v4 08/21] vfio-user: define socket receive functions

2022-01-11 Thread John Johnson
Add infrastructure needed to receive incoming messages Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 54 hw/vfio/user.h | 6 + hw/vfio/pci.c | 6 + hw/vfio/user.c | 327

[RFC v4 03/21] vfio-user: add container IO ops vector

2022-01-11 Thread John Johnson
Used for communication with VFIO driver (prep work for vfio-user, which will communicate over a socket) Signed-off-by: John G Johnson --- include/hw/vfio/vfio-common.h | 33 +++ hw/vfio/common.c | 126 -- 2 files changed, 117

[RFC v4 17/21] vfio-user: secure DMA support

2022-01-11 Thread John Johnson
Secure DMA forces the remote process to use DMA r/w messages instead of directly mapping guest memeory. Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h | 1 + hw/vfio/user.h | 1 + hw/vfio/pci.c | 4 hw/vfio/user.c | 2 +-

[RFC v4 19/21] vfio-user: pci reset

2022-01-11 Thread John Johnson
Message to tell the server to reset the device. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user.h | 1 + hw/vfio/pci.c | 15 +++ hw/vfio/user.c | 12 3 files changed, 28 insertions(+) diff --git

[RFC v4 21/21] Only set qemu file error if saving state so the file exists

2022-01-11 Thread John Johnson
Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index df63f5c..e72241d 100644 --- a/hw/vfio/migration.c +++

[RFC v4 07/21] vfio-user: connect vfio proxy to remote server

2022-01-11 Thread John Johnson
add user.c & user.h files for vfio-user code add proxy struct to handle comms with remote server Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/user.h| 78 +++ include/hw/vfio/vfio-common.h | 2 +

[RFC v4 18/21] vfio-user: dma read/write operations

2022-01-11 Thread John Johnson
Messages from server to client that peform device DMA. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 11 + hw/vfio/user.h | 4 ++ hw/vfio/pci.c | 105

[RFC v4 01/21] vfio-user: introduce vfio-user protocol specification

2022-01-11 Thread John Johnson
From: Thanos Makatos This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and concepts. It has been earlier

[RFC v4 13/21] vfio-user: pci_user_realize PCI setup

2022-01-11 Thread John Johnson
PCI BARs read from remote device PCI config reads/writes sent to remote server Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.c | 275 -- 1 file changed, 172 insertions(+),

[RFC v4 00/21] vfio-user client

2022-01-11 Thread John Johnson
Hello, This is the 4th revision of the vfio-user client implementation. First of all, thank you for your time reviewing the previous versions. The vfio-user framework consists of 3 parts: 1) The VFIO user protocol specification. 2) A client - the VFIO device in QEMU that encapsulates VFIO

[RFC v4 11/21] vfio-user: get region info

2022-01-11 Thread John Johnson
Add per-region FD to support mmap() of remote device regions Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/user-protocol.h | 14 ++ include/hw/vfio/vfio-common.h | 8 +++--- hw/vfio/common.c | 32

[RFC v4 04/21] vfio-user: add region cache

2022-01-11 Thread John Johnson
cache VFIO_DEVICE_GET_REGION_INFO results to reduce memory alloc/free cycles and as prep work for vfio-user Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/ccw.c | 5 -

[RFC v4 05/21] vfio-user: add device IO ops vector

2022-01-11 Thread John Johnson
Used for communication with VFIO driver (prep work for vfio-user, which will communicate over a socket) Signed-off-by: John G Johnson --- include/hw/vfio/vfio-common.h | 27 hw/vfio/common.c | 107 +++- hw/vfio/pci.c | 140

[RFC v4 06/21] vfio-user: Define type vfio_user_pci_dev_info

2022-01-11 Thread John Johnson
New class for vfio-user with its class and instance constructors and destructors, and its pci ops. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h| 8 + hw/vfio/common.c | 5 hw/vfio/pci.c| 90

[RFC v4 12/21] vfio-user: region read/write

2022-01-11 Thread John Johnson
Add support for posted writes on remote devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h | 1 + hw/vfio/user-protocol.h | 12 + hw/vfio/user.h| 1 +

[RFC v4 09/21] vfio-user: define socket send functions

2022-01-11 Thread John Johnson
Also negotiate protocol version with remote server Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson --- hw/vfio/pci.h | 1 + hw/vfio/user-protocol.h | 41 + hw/vfio/user.h | 2 + hw/vfio/pci.c | 16 ++

[RFC v4 02/21] vfio-user: add VFIO base abstract class

2022-01-11 Thread John Johnson
Add an abstract base class both the kernel driver and user socket implementations can use to share code. Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- hw/vfio/pci.h | 16 +++-- hw/vfio/pci.c | 106

Re: [PATCH v2 2/4] scripts/qapi/commands: gen_commands(): add add_trace_points argument

2022-01-11 Thread John Snow
On Tue, Jan 11, 2022 at 6:53 PM John Snow wrote: > > On Thu, Dec 23, 2021 at 6:08 AM Vladimir Sementsov-Ogievskiy > wrote: > > > > Add possibility to generate trace points for each qmp command. > > > > We should generate both trace points and trace-events file, for further > > trace point code

[PATCH 3/3] hw/arm: kudo add max31790 behind bus 1 switch at 75

2022-01-11 Thread Titus Rwantare
From: Patrick Venture Signed-off-by: Patrick Venture Reviewed-by: Titus Rwantare --- hw/arm/npcm7xx_boards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 7d0f3148be..6fea2e161f 100644 --- a/hw/arm/npcm7xx_boards.c +++

[PATCH 2/3] tests/qtest: add tests for MAX31790 fan controller

2022-01-11 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- tests/qtest/max31790_fan_ctrl-test.c | 171 +++ tests/qtest/meson.build | 1 + 2 files changed, 172 insertions(+) create mode 100644 tests/qtest/max31790_fan_ctrl-test.c diff --git

[PATCH 1/3] hw/sensor: add MAX31790 fan controller

2022-01-11 Thread Titus Rwantare
Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu --- MAINTAINERS | 8 +- hw/arm/Kconfig| 1 + hw/sensor/Kconfig | 4 + hw/sensor/max31790_fan_ctrl.c | 454 ++ hw/sensor/meson.build

RE: [PATCH 03/11] softfloat: Introduce float_flag_inorm_denormal

2022-01-11 Thread Michael Morrell
Richard, It's been 6 months so I thought I'd check in again. Do you have an estimate of when this will go in? Michael -Original Message- From: Michael Morrell Sent: Wednesday, July 14, 2021 10:50 AM To: 'Richard Henderson' ; qemu-devel@nongnu.org Subject: RE: [PATCH 03/11]

Re: [PATCH v2 2/4] scripts/qapi/commands: gen_commands(): add add_trace_points argument

2022-01-11 Thread John Snow
On Thu, Dec 23, 2021 at 6:08 AM Vladimir Sementsov-Ogievskiy wrote: > > Add possibility to generate trace points for each qmp command. > > We should generate both trace points and trace-events file, for further > trace point code generation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > ---

Re: [PATCH v2 1/4] jobs: drop qmp_ trace points

2022-01-11 Thread John Snow
On Mon, Jan 10, 2022 at 11:06 AM Stefan Hajnoczi wrote: > > On Thu, Dec 23, 2021 at 12:07:53PM +0100, Vladimir Sementsov-Ogievskiy wrote: > > diff --git a/block/trace-events b/block/trace-events > > index 549090d453..5be3e3913b 100644 > > --- a/block/trace-events > > +++ b/block/trace-events > >

Re: test_isa_retry_flush() in ide-test.c

2022-01-11 Thread John Snow
On Fri, Jan 7, 2022, 12:27 PM Paolo Bonzini wrote: > On 1/7/22 17:01, Thomas Huth wrote: > > Hi John! > > > > I just notice that test_isa_retry_flush() is not doing anything useful > > anymore: It likely was supposed to run the test_retry_flush() function > > with the "isapc" machine type, but

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-11 Thread Patrick Venture
On Tue, Jan 11, 2022 at 12:50 PM Laurent Vivier wrote: > Hi Patrick, > > Le 11/01/2022 à 21:14, Patrick Venture a écrit : > > > > > > On Sat, Jan 8, 2022 at 10:16 AM Laurent Vivier > wrote: > > > > Le 06/01/2022 à 23:00, Patrick Venture a écrit : > > > From:

Re: [PATCH] tests/qtest/hd-geo-test: Check for the lsi53c895a controller before using it

2022-01-11 Thread Philippe Mathieu-Daudé
On 22/12/21 16:36, Thomas Huth wrote: The lsi53c895a SCSI controller might have been disabled in the target binary, so let's check for its availability first before using it. Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests

2022-01-11 Thread Philippe Mathieu-Daudé
On 20/12/21 09:10, Thomas Huth wrote: Devices might not always be compiled into the QEMU target binaries. We already have the libqos framework that is good for handling such situations, but some of the qtests are not a real good fit for the libqos framework. This patch series adds a new function

Re: [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them

2022-01-11 Thread Philippe Mathieu-Daudé
On 20/12/21 09:10, Thomas Huth wrote: Downstream users might want to disable legacy devices in their binaries, so we should not blindly assume that they are available. Add some proper checks before using them. Signed-off-by: Thomas Huth --- tests/qtest/cdrom-test.c | 60

Re: [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices

2022-01-11 Thread Philippe Mathieu-Daudé
On 20/12/21 09:10, Thomas Huth wrote: The users might have built QEMU with less machines or without the i82378 superio device. Add some checks to the endianess-test so that it is able to deal with such stripped down QEMU versions, too. Signed-off-by: Thomas Huth ---

Re: [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available

2022-01-11 Thread Philippe Mathieu-Daudé
On 20/12/21 09:10, Thomas Huth wrote: Devices might not always be compiled into the QEMU target binaries. We already have the libqos framework that is good for handling such situations, but some of the qtests are not a real good fit for the libqos framework. Let's add a qtest_has_device()

Re: [PULL 00/13] Net patches

2022-01-11 Thread Vladislav Yaroshchuk
вт, 11 янв. 2022 г., 5:10 AM Jason Wang : > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell > wrote: > > > > On Mon, 10 Jan 2022 at 03:40, Jason Wang wrote: > > > > > > The following changes since commit > df722e33d5da26ea8604500ca8f509245a0ea524: > > > > > > Merge tag

[PATCH v10 6/7] net/vmnet: update qemu-options.hx

2022-01-11 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- qemu-options.hx | 25 + 1 file changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index ec90505d84..81dd34f550 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2732,6 +2732,25 @@ DEF("netdev", HAS_ARG,

[PATCH v10 7/7] net/vmnet: update MAINTAINERS list

2022-01-11 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c98a61caee..638d129305 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2641,6 +2641,11 @@ W: http://info.iet.unipi.it/~luigi/netmap/ S: Maintained F:

[PATCH v10 5/7] net/vmnet: implement bridged mode (vmnet-bridged)

2022-01-11 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-bridged.m | 98 ++--- 1 file changed, 92 insertions(+), 6 deletions(-) diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m index 4e42a90391..3c9da9dc8b 100644 --- a/net/vmnet-bridged.m +++

[PATCH v10 3/7] net/vmnet: implement shared mode (vmnet-shared)

2022-01-11 Thread Vladislav Yaroshchuk
Interaction with vmnet.framework in different modes differs only on configuration stage, so we can create common `send`, `receive`, etc. procedures and reuse them. vmnet.framework supports iov, but writing more than one iov into vmnet interface fails with 'VMNET_INVALID_ARGUMENT'. Collecting

[PATCH v10 4/7] net/vmnet: implement host mode (vmnet-host)

2022-01-11 Thread Vladislav Yaroshchuk
Signed-off-by: Vladislav Yaroshchuk --- net/vmnet-host.c | 93 1 file changed, 87 insertions(+), 6 deletions(-) diff --git a/net/vmnet-host.c b/net/vmnet-host.c index 4a5ef99dc7..9c2e760ed1 100644 --- a/net/vmnet-host.c +++ b/net/vmnet-host.c @@

[PATCH v10 1/7] net/vmnet: add vmnet dependency and customizable option

2022-01-11 Thread Vladislav Yaroshchuk
vmnet.framework dependency is added with 'vmnet' option to enable or disable it. Default value is 'auto'. vmnet features to be used are available since macOS 11.0, corresponding probe is created into meson.build. Signed-off-by: Vladislav Yaroshchuk --- meson.build | 16

[PATCH v10 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-11 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m |

[PATCH v10 0/7] Add vmnet.framework based network backend

2022-01-11 Thread Vladislav Yaroshchuk
macOS provides networking API for VMs called 'vmnet.framework': https://developer.apple.com/documentation/vmnet We can provide its support as the new QEMU network backends which represent three different vmnet.framework interface usage modes: * `vmnet-shared`: allows the guest to

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-11 Thread Laurent Vivier
Hi Patrick, Le 11/01/2022 à 21:14, Patrick Venture a écrit : On Sat, Jan 8, 2022 at 10:16 AM Laurent Vivier mailto:laur...@vivier.eu>> wrote: Le 06/01/2022 à 23:00, Patrick Venture a écrit : > From: Shu-Chun Weng mailto:s...@google.com>> > > Linux kernel does it this way

Re: [PATCH] nbd/server.c: Remove unused field

2022-01-11 Thread Philippe Mathieu-Daudé
On 1/11/22 20:43, Nir Soffer wrote: > NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that > this field exists since the first git commit and was never used. > > Signed-off-by: Nir Soffer > --- > nbd/server.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe

Re: [PATCH] tests/qtest/hd-geo-test: Check for the lsi53c895a controller before using it

2022-01-11 Thread John Snow
On Wed, Dec 22, 2021 at 10:36 AM Thomas Huth wrote: > > The lsi53c895a SCSI controller might have been disabled in the target > binary, so let's check for its availability first before using it. > > Signed-off-by: Thomas Huth > --- > tests/qtest/hd-geo-test.c | 8 +--- > 1 file changed, 5

[PATCH 0/1] ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

2022-01-11 Thread Daniel Henrique Barboza
Hi, This is something that caught my eye when I was looking into the instances where we need stack properties versus phb4 properties. I tested this fix and it doesn't seem to impact the boot process whatsoever. Tracing pnv_pec_stk_pci_xscom_write() shows that the writes are being done at early

[PATCH 1/1] ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

2022-01-11 Thread Daniel Henrique Barboza
pnv_pec_stk_pci_xscom_write() is pnv_pec_stk_pci_xscom_ops write callback. It writes values into regs in the stack->nest_regs[] array. The pnv_pec_stk_pci_xscom_read read callback, on the other hand, returns values of the stack->pci_regs[]. In fact, at this moment, the only use of

Re: [PATCH v4 05/23] migration: simplify do_compress_ram_page

2022-01-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > The goto is not needed at all. Another dupe, Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/ram.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/migration/ram.c

Re: [PATCH v4 04/23] migration: Remove masking for compression

2022-01-11 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Remove the mask in the call to ram_release_pages(). Nothing else does > it, and if the offset has that bits set, we have a lot of trouble. > > Signed-off-by: Juan Quintela Yeh same as in the other branch Reviewed-by: Dr. David Alan Gilbert >

Re: [PATCH v4 07/11] target/riscv: Support mcycle/minstret write operation

2022-01-11 Thread Atish Patra
On Sun, Jan 9, 2022 at 11:51 PM Bin Meng wrote: > > On Fri, Jan 7, 2022 at 10:14 AM Atish Patra wrote: > > > > From: Atish Patra > > > > mcycle/minstret are actually WARL registers and can be written with any > > given value. With SBI PMU extension, it will be used to store a initial > > value

Re: [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them

2022-01-11 Thread John Snow
On Mon, Dec 20, 2021 at 3:11 AM Thomas Huth wrote: > Downstream users might want to disable legacy devices in their binaries, > so we should not blindly assume that they are available. Add some proper > checks before using them. > > Signed-off-by: Thomas Huth > --- > tests/qtest/cdrom-test.c |

[PULL 30/30] linux-user: Implement capability prctls

2022-01-11 Thread Laurent Vivier
From: Richard Henderson This is PR_CAPBSET_READ, PR_CAPBSET_DROP and the "legacy" PR_CAP_AMBIENT PR_GET_SECUREBITS, PR_SET_SECUREBITS. All of these arguments are integer values only, and do not require mapping of values between host and guest. Signed-off-by: Richard Henderson Reviewed-by:

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-11 Thread Patrick Venture
On Sat, Jan 8, 2022 at 10:16 AM Laurent Vivier wrote: > Le 06/01/2022 à 23:00, Patrick Venture a écrit : > > From: Shu-Chun Weng > > > > Linux kernel does it this way (checks read permission before validating > `how`) > > and the latest version of ABSL's `AddressIsReadable()` depends on this >

[PULL 25/30] linux-user/arm: Move target_oabi_flock64 out of target_structs.h

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Place it next to copy_from/to_user_oabi_flock64, the only users, inside the existing target-specific ifdef. This leaves only generic ipc structs in target_structs.h. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier

[PULL 16/30] target/mips: Extract break code into env->error_code

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Simplify cpu_loop by doing all of the decode in translate. This fixes a bug in that cpu_loop was not handling the different layout of the R6 version of break16. This fixes a bug in that cpu_loop extracted the wrong bits for the mips16e break16 instruction. Reviewed-by:

[PULL 26/30] linux-user: Move target_struct.h generic definitions to generic/

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Most targets share the same generic ipc structure definitions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20220107042600.149852-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 29/30] linux-user: Implement PR_SET_PDEATHSIG

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220106225738.103012-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c

[PULL 28/30] linux-user: Map signal number in PR_GET_PDEATHSIG

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Convert the host signal number to guest signal number before returning the value to the guest. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220106225738.103012-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 27/30] linux-user: Do not special-case NULL for PR_GET_PDEATHSIG

2022-01-11 Thread Laurent Vivier
From: Richard Henderson The kernel does not special-case arg2 != NULL, so neither should we. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20220106225738.103012-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 2 +- 1 file

[PULL 14/30] linux-user/mips: Improve do_break

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Rename to do_tr_or_bp, as per the kernel function. Add a 'trap' argument, akin to the kernel's si_code, but clearer. The return value is always 0, so change the return value to void. Use force_sig and force_sig_fault. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by:

[PULL 22/30] linux-user/sh4: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-23-richard.hender...@linaro.org> Signed-off-by:

[PULL 23/30] linux-user/sparc: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-24-richard.hender...@linaro.org> Signed-off-by:

[PULL 19/30] linux-user/ppc: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. The fault address for POWERPC_EXCP_ISI is nip exactly, not nip - 4. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id:

[PULL 08/30] linux-user/hppa: Set FPE_CONDTRAP for COND

2022-01-11 Thread Laurent Vivier
From: Richard Henderson This si_code was changed in 75abf64287cab, for linux 4.17. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-9-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/hppa/cpu_loop.c | 2 ++

[PULL 15/30] linux-user/mips: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP and SIGFPE; use force_sig (SI_KERNEL) for EXCP_DSPDIS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id:

[PULL 24/30] linux-user/xtensa: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-25-richard.hender...@linaro.org> Signed-off-by:

[PULL 18/30] linux-user/openrisc: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Stafford Horne Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-19-richard.hender...@linaro.org> Signed-off-by:

[PULL 20/30] linux-user/riscv: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fix missing PC from EXCP_DEBUG by merging the case with EXCP_BREAKPOINT. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id:

[PULL 09/30] linux-user/i386: Split out maybe_handle_vm86_trap

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Reduce the number of ifdefs within cpu_loop(). Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/i386/cpu_loop.c | 31

[PULL 21/30] linux-user/s390x: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-22-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 12/30] linux-user/microblaze: Use force_sig_fault

2022-01-11 Thread Laurent Vivier
From: Richard Henderson Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20220107213243.212806-13-richard.hender...@linaro.org> Signed-off-by:

  1   2   3   4   >