Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread Liav Albani
On 2/19/22 02:50, BALATON Zoltan wrote: +/* + * QEMU IDE Emulation: PCI ICH6/ICH7 IDE support. This is a small thing, but if these two are the same maybe keeping this comment but using the ich7 name everywhere else would make it less likely to get it confused with ich9. I mean ich6 and

[PATCH v3 6/6] hw/openrisc/openrisc_sim: Add support for initrd loading

2022-02-18 Thread Stafford Horne
The initrd passed via the command line is loaded into memory. It's location and size is then added to the device tree so the kernel knows where to find it. Signed-off-by: Stafford Horne Reviewed-by: Peter Maydell --- hw/openrisc/openrisc_sim.c | 31 +++ 1 file

Re: [PATCH v2 1/2] hw/ide: split bmdma read and write functions from piix.c

2022-02-18 Thread Liav Albani
On 2/19/22 02:12, BALATON Zoltan wrote: On Fri, 18 Feb 2022, Liav Albani wrote: This is a preparation before implementing another PCI IDE controller that relies on these functions, so these can be shared between both implementations. Signed-off-by: Liav Albani --- hw/ide/bmdma.c |

[PATCH v3 2/6] hw/openrisc/openrisc_sim: Parameterize initialization

2022-02-18 Thread Stafford Horne
Move magic numbers to variables and enums. These will be reused for upcoming fdt initialization. Signed-off-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé --- hw/openrisc/openrisc_sim.c | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff

[PATCH v3 3/6] hw/openrisc/openrisc_sim: Use IRQ splitter when connecting UART

2022-02-18 Thread Stafford Horne
Currently the OpenRISC SMP configuration only supports 2 cores due to the UART IRQ routing being limited to 2 cores. As was done in commit 1eeffbeb11 ("hw/openrisc/openrisc_sim: Use IRQ splitter when connecting IRQ to multiple CPUs") we can use a splitter to wire more than 2 CPUs. This patch

[PATCH v3 5/6] hw/openrisc/openrisc_sim: Add automatic device tree generation

2022-02-18 Thread Stafford Horne
Using the device tree means that qemu can now directly tell the kernel what hardware is configured rather than use having to maintain and update a separate device tree file. This patch adds automatic device tree generation support for the OpenRISC simulator. A device tree is built up based on

[PATCH v3 1/6] hw/openrisc/openrisc_sim: Create machine state for or1ksim

2022-02-18 Thread Stafford Horne
This will allow us to attach machine state attributes like the device tree fdt. Signed-off-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé --- hw/openrisc/openrisc_sim.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git

[PATCH v3 0/6] OpenRISC Device Tree Generation

2022-02-18 Thread Stafford Horne
Changes since v2: - Fix description to say devicetree "generation" not "support" - Fix up various indentation issues. - Use HWADDR_PRIx string formatting. - Split device tree population out to device init. - Do not load device tree or initrd if we have no kernel. - Added patches to split

[PATCH v3 4/6] hw/openrisc/openrisc_sim: Increase max_cpus to 4

2022-02-18 Thread Stafford Horne
Now that we no longer have a limit of 2 CPUs due to fixing the IRQ routing issues we can increase the max. Here we increase the limit to 4, we could go higher, but currently OMPIC has a limit of 4, so we align with that. Signed-off-by: Stafford Horne --- hw/openrisc/openrisc_sim.c | 8 +---

[PATCH v2] hvf: Fix OOB write in RDTSCP instruction decode

2022-02-18 Thread Cameron Esfahani
A guest could craft a specific stream of instructions that will have QEMU write 0xF9 to inappropriate locations in memory. Add additional asserts to check for this. Generate a #UD if there are more than 14 prefix bytes. Found by Julian Stecklina Signed-off-by: Cameron Esfahani Signed-off-by:

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread BALATON Zoltan
On Fri, 18 Feb 2022, Liav Albani wrote: This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. There's no x86 chipset in QEMU that will try to attach this device by default. It is considered a legacy-free

[PATCH v5 06/12] target/riscv: Add support for hpmcounters/hpmevents

2022-02-18 Thread Atish Patra
From: Atish Patra With SBI PMU extension, user can use any of the available hpmcounters to track any perf events based on the value written to mhpmevent csr. Add read/write functionality for these csrs. Reviewed-by: Bin Meng Signed-off-by: Atish Patra Signed-off-by: Atish Patra ---

[PATCH v5 12/12] target/riscv: Update the privilege field for sscofpmf CSRs

2022-02-18 Thread Atish Patra
The sscofpmf extension was ratified as a part of priv spec v1.12. Mark the csr_ops accordingly. Signed-off-by: Atish Patra --- target/riscv/csr.c | 90 ++ 1 file changed, 60 insertions(+), 30 deletions(-) diff --git a/target/riscv/csr.c

[PATCH v5 11/12] hw/riscv: virt: Add PMU DT node to the device tree

2022-02-18 Thread Atish Patra
Qemu virt machine can support few cache events and cycle/instret counters. It also supports counter overflow for these events. Add a DT node so that OpenSBI/Linux kernel is aware of the virt machine capabilities. There are some dummy nodes added for testing as well. Signed-off-by: Atish Patra

[PATCH v5 09/12] target/riscv: Simplify counter predicate function

2022-02-18 Thread Atish Patra
All the hpmcounters and the fixed counters (CY, IR, TM) can be represented as a unified counter. Thus, the predicate function doesn't need handle each case separately. Simplify the predicate function so that we just handle things differently between RV32/RV64 and S/HS mode. Reviewed-by: Bin Meng

[PATCH v5 04/12] target/riscv: pmu: Make number of counters configurable

2022-02-18 Thread Atish Patra
The RISC-V privilege specification provides flexibility to implement any number of counters from 29 programmable counters. However, the QEMU implements all the counters. Make it configurable through pmu config parameter which now will indicate how many programmable counters should be implemented

[PATCH v5 10/12] target/riscv: Add few cache related PMU events

2022-02-18 Thread Atish Patra
From: Atish Patra Qemu can monitor the following cache related PMU events through tlb_fill functions. 1. DTLB load/store miss 3. ITLB prefetch miss Increment the PMU counter in tlb_fill function. Signed-off-by: Atish Patra Signed-off-by: Atish Patra --- target/riscv/cpu_helper.c | 26

[PATCH v5 01/12] target/riscv: Fix PMU CSR predicate function

2022-02-18 Thread Atish Patra
From: Atish Patra The predicate function calculates the counter index incorrectly for hpmcounterx. Fix the counter index to reflect correct CSR number. Fixes: e39a8320b088 ("target/riscv: Support the Virtual Instruction fault") Reviewed-by: Alistair Francis Reviewed-by: Bin Meng

[PATCH v5 07/12] target/riscv: Support mcycle/minstret write operation

2022-02-18 Thread Atish Patra
From: Atish Patra mcycle/minstret are actually WARL registers and can be written with any given value. With SBI PMU extension, it will be used to store a initial value provided from supervisor OS. The Qemu also need prohibit the counter increment if mcountinhibit is set. Support mcycle/minstret

[PATCH v5 08/12] target/riscv: Add sscofpmf extension support

2022-02-18 Thread Atish Patra
The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) extension allows the perf to handle overflow interrupts and filtering support. This patch provides a framework for programmable counters to leverage the extension.

[PATCH v5 05/12] target/riscv: Implement mcountinhibit CSR

2022-02-18 Thread Atish Patra
From: Atish Patra As per the privilege specification v1.11, mcountinhibit allows to start/stop a pmu counter selectively. Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Atish Patra Signed-off-by: Atish Patra --- target/riscv/cpu.h | 2 ++ target/riscv/cpu_bits.h |

[PATCH v5 02/12] target/riscv: Implement PMU CSR predicate function for S-mode

2022-02-18 Thread Atish Patra
From: Atish Patra Currently, the predicate function for PMU related CSRs only works if virtualization is enabled. It also does not check mcounteren bits before before cycle/minstret/hpmcounterx access. Support supervisor mode access in the predicate function as well. Reviewed-by: Alistair

[PATCH v5 00/12] Improve PMU support

2022-02-18 Thread Atish Patra
The latest version of the SBI specification includes a Performance Monitoring Unit(PMU) extension[1] which allows the supervisor to start/stop/configure various PMU events. The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, and 'cofpmf' for Count OverFlow and Privilege Mode

[PATCH v5 03/12] target/riscv: pmu: Rename the counters extension to pmu

2022-02-18 Thread Atish Patra
From: Atish Patra The PMU counters are supported via cpu config "Counters" which doesn't indicate the correct purpose of those counters. Rename the config property to pmu to indicate that these counters are performance monitoring counters. This aligns with cpu options for ARM architecture as

Re: [PATCH v2 1/2] hw/ide: split bmdma read and write functions from piix.c

2022-02-18 Thread BALATON Zoltan
On Fri, 18 Feb 2022, Liav Albani wrote: This is a preparation before implementing another PCI IDE controller that relies on these functions, so these can be shared between both implementations. Signed-off-by: Liav Albani --- hw/ide/bmdma.c | 84

[PATCH v5 00/12] Improve PMU support

2022-02-18 Thread Atish Patra
The latest version of the SBI specification includes a Performance Monitoring Unit(PMU) extension[1] which allows the supervisor to start/stop/configure various PMU events. The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, and 'cofpmf' for Count OverFlow and Privilege Mode

Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-02-18 Thread Edgar E. Iglesias
On Fri, Feb 18, 2022 at 01:37:51PM +, Peter Maydell wrote: > On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Add a model of the Xilinx ZynqMP CRF. At the moment this > > is mostly a stub model. > > > > Reviewed-by: Philippe Mathieu-Daudé >

Re: 'make check-acceptance' failing on s390 tests?

2022-02-18 Thread Richard Henderson
On 2/19/22 02:04, Peter Maydell wrote: Hi; is anybody else seeing 'make check-acceptance' fail on some of the s390 tests? (009/183) tests/avocado/boot_linux.py:BootLinuxS390X.test_s390_ccw_virtio_tcg: INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal

Re: configure: How to pass flags to the Objective-C compiler?

2022-02-18 Thread Philippe Mathieu-Daudé via
Hi Joshua, On 18/2/22 22:58, Joshua Seaton wrote: Hi all, How does one pass Objective-C compilation flags (e.g., a sysroot specification) when configuring/building? `configure` exposes `--extra-cflags` and `--extra-cxxflags` for C/C++ compilation, but there isn't an equivalent for Objective-C.

configure: How to pass flags to the Objective-C compiler?

2022-02-18 Thread Joshua Seaton
Hi all, How does one pass Objective-C compilation flags (e.g., a sysroot specification) when configuring/building? `configure` exposes `--extra-cflags` and `--extra-cxxflags` for C/C++ compilation, but there isn't an equivalent for Objective-C. In my particular case, I'd like to specify a

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-18 Thread Alexander Bulekov
On 220128 1547, Stefan Hajnoczi wrote: > Dear QEMU, KVM, and rust-vmm communities, > QEMU will apply for Google Summer of Code 2022 > (https://summerofcode.withgoogle.com/) and has been accepted into > Outreachy May-August 2022 (https://www.outreachy.org/). You can now > submit internship project

[PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread Liav Albani
This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. There's no x86 chipset in QEMU that will try to attach this device by default. It is considered a legacy-free device in the aspect of PCI bus resource

[PATCH v2 1/2] hw/ide: split bmdma read and write functions from piix.c

2022-02-18 Thread Liav Albani
This is a preparation before implementing another PCI IDE controller that relies on these functions, so these can be shared between both implementations. Signed-off-by: Liav Albani --- hw/ide/bmdma.c | 84 ++ hw/ide/meson.build | 2 +-

[PATCH v2 0/2] hw/ide: implement ich6 ide controller support

2022-02-18 Thread Liav Albani
This is version 2 of this patch, this time a patch series, after following the suggestions from BALATON Zoltan. I implemented this device because I have an old machine from 2009 which has the ICH7 south bridge in it, so when I tried to run Linux on it, it booted just fine (as you might expect),

[PATCH] ppc/pnv: fix default PHB4 QOM hierarchy

2022-02-18 Thread Daniel Henrique Barboza
Commit 3f4c369ea63e ("ppc/pnv: make PECs create and realize PHB4s") changed phb4_pec code to create the default PHB4 objects in pnv_pec_default_phb_realize(). In this process the stacks[] PEC array was removed and each PHB4 object is tied together with its PEC via the phb->pec pointer. This

Re: [PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 19:55, Peter Maydell wrote: On Sun, 2 Jan 2022 at 17:42, Carwyn Ellis wrote: When switching between guest and host on a Mac using command-tab the command key is sent to the guest which can trigger functionality in the guest OS. Specifying left-command-key=off disables forwarding

Re: [PULL 00/10] Misc next patches

2022-02-18 Thread Peter Maydell
On Thu, 17 Feb 2022 at 12:01, Daniel P. Berrangé wrote: > > The following changes since commit ad38520bdeb2b1e0b487db317f29119e94c1c88d: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2022-02-15 > 19:30:33 +) > > are available in the Git

Re: [PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

2022-02-18 Thread Peter Maydell
On Sun, 2 Jan 2022 at 17:42, Carwyn Ellis wrote: > > When switching between guest and host on a Mac using command-tab the > command key is sent to the guest which can trigger functionality in the > guest OS. Specifying left-command-key=off disables forwarding this key > to the guest. Defaults to

Re: [PATCH 1/1] ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab

2022-02-18 Thread Akihiko Odaki
On 2022/01/03 20:45, Carwyn Ellis wrote: The menu bar is only accessible when the Cocoa UI is windowed. In order to allow the menu bar to be accessible in fullscreen mode, this change makes the menu visible when the mouse is ungrabbed. When the mouse is grabbed the menu is hidden again.

Re: [PATCH 2/2] ui/cocoa: release mouse when user switches away from QEMU window

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/01/03 2:41, Carwyn Ellis wrote: This resolves an issue where using command-tab to switch between QEMU and other windows on the host can leave the mouse pointer visible. By releasing the mouse when the user switches away, the user must left click on the QEMU

Re: [PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/01/03 2:41, Carwyn Ellis wrote: When switching between guest and host on a Mac using command-tab the command key is sent to the guest which can trigger functionality in the guest OS. Specifying left-command-key=off disables forwarding this key to the guest.

Re: [PATCH v6 10/15] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/15 17:03, Philippe Mathieu-Daudé via wrote: setAllowedFileTypes is deprecated in macOS 12. Per Akihiko Odaki [*]: An image file, which is being chosen by the panel, can be a raw file and have a variety of file extensions

Re: [PATCH v6 08/15] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/15 17:03, Philippe Mathieu-Daudé via wrote: When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0

Re: [PATCH 04/31] vdpa: Add vhost_svq_set_svq_kick_fd

2022-02-18 Thread Eugenio Perez Martin
On Tue, Feb 8, 2022 at 9:48 AM Jason Wang wrote: > > > 在 2022/1/31 下午6:18, Eugenio Perez Martin 写道: > > On Fri, Jan 28, 2022 at 7:29 AM Jason Wang wrote: > >> > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > >>> This function allows the vhost-vdpa backend to override kick_fd. > >>> > >>>

Re: [PATCH v6 11/15] ui/cocoa: Add Services menu

2022-02-18 Thread Christian Schoenebeck
On Freitag, 18. Februar 2022 18:49:55 CET Akihiko Odaki wrote: > On Sat, Feb 19, 2022 at 2:33 AM Peter Maydell wrote: > > On Tue, 15 Feb 2022 at 08:26, Philippe Mathieu-Daudé via > > > > wrote: > > > From: Akihiko Odaki > > > > > > Services menu functionality of Cocoa is described at: > > >

Re: [PATCH v6 00/43] CXl 2.0 emulation Support

2022-02-18 Thread Jonathan Cameron via
On Fri, 11 Feb 2022 12:07:04 + Jonathan Cameron wrote: > This version is mainly a reorganization of v5 patch ordering to make for > more sensible stepwise review and merging. I took the opportunity to add > a few more tests and introduce an overview document. In case anyone is interested

Re: [PATCH v6 07/15] block/file-posix: Remove a deprecation warning on macOS 12

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/15 17:02, Philippe Mathieu-Daudé via wrote: When building on macOS 12 we get: block/file-posix.c:3335:18: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations] kernResult =

Re: [PATCH v6 03/15] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/15 17:02, Philippe Mathieu-Daudé via wrote: Since we already use -Wno-unknown-pragmas, we can also use -Wno-ignored-pragmas. This silences hundred of warnings using clang 13 on macOS Monterey: [409/771] Compiling C object

Re: [PATCH v6 02/15] configure: Allow passing extra Objective C compiler flags

2022-02-18 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On 2022/02/15 17:02, Philippe Mathieu-Daudé via wrote: We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment variables, or via configure --extra-cflags / --extra-cxxflags / --extra-ldflags options. Provide similar behavior for

Re: [PATCH v2 7/7] aspeed/sdmc: Add trace events

2022-02-18 Thread Cédric Le Goater
On 2/18/22 18:56, Philippe Mathieu-Daudé wrote: On 18/2/22 09:18, Cédric Le Goater wrote: This is useful to analyze changes in the U-Boot RAM driver when SDRAM training is performed. Signed-off-by: Cédric Le Goater ---   hw/misc/aspeed_sdmc.c | 2 ++   hw/misc/trace-events  | 4   2 files

Re: [PATCH v2 7/7] aspeed/sdmc: Add trace events

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 09:18, Cédric Le Goater wrote: This is useful to analyze changes in the U-Boot RAM driver when SDRAM training is performed. Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_sdmc.c | 2 ++ hw/misc/trace-events | 4 2 files changed, 6 insertions(+) diff --git

Re: [PATCH v2 5/7] aspeed: Introduce a create_pca9552() helper

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 09:18, Cédric Le Goater wrote: This unifies the way we create the pca9552 devices on the different boards. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 +++-- 1 file changed, 27

Re: [PATCH v7 00/11] 9p: Add support for darwin

2022-02-18 Thread Will Cohen
Excellent, thanks so much for the update. I'll wait till the other 9p pull gets integrated, then rebase and test! On Fri, Feb 18, 2022 at 12:45 PM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Freitag, 18. Februar 2022 18:04:24 CET Will Cohen wrote: > > On Tue, Feb 15, 2022 at 2:04

Re: [PATCH v2 5/7] aspeed: Introduce a create_pca9552() helper

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 09:18, Cédric Le Goater wrote: This unifies the way we create the pca9552 devices on the different boards. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 +++-- 1 file changed, 27

Re: [PATCH v6 11/15] ui/cocoa: Add Services menu

2022-02-18 Thread Akihiko Odaki
On Sat, Feb 19, 2022 at 2:33 AM Peter Maydell wrote: > > On Tue, 15 Feb 2022 at 08:26, Philippe Mathieu-Daudé via > wrote: > > > > From: Akihiko Odaki > > > > Services menu functionality of Cocoa is described at: > >

Re: [PATCH 1/5] hw/riscv/riscv_hart: free the harts array when the object is finalized

2022-02-18 Thread Peter Maydell
On Fri, 18 Feb 2022 at 17:39, Damien Hedde wrote: > You're right. I was confused when re-writing the message. > This leaks happen on > init -> realize-failure -> finalize > Because the array is allocated, then every cpu is initialized (and an > error failure may happen for any of them). "Failure

Re: [PATCH v7 00/11] 9p: Add support for darwin

2022-02-18 Thread Christian Schoenebeck
On Freitag, 18. Februar 2022 18:04:24 CET Will Cohen wrote: > On Tue, Feb 15, 2022 at 2:04 PM Will Cohen wrote: > > This is a followup to > > https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg02313.html, > > adding 9p server support for Darwin. > > > > Since v6, the following changes have

Re: [PATCH 1/5] hw/riscv/riscv_hart: free the harts array when the object is finalized

2022-02-18 Thread Damien Hedde
On 2/18/22 18:23, Peter Maydell wrote: On Fri, 18 Feb 2022 at 16:53, Damien Hedde wrote: The array is dynamically allocated by realize() depending on the number of harts. This clean-up removes memory leaks which would happen in the 'init->finalize' life-cycle use-case (happening when user

Re: [PATCH v3] arm: Remove swift-bmc machine

2022-02-18 Thread Philippe Mathieu-Daudé via
On 17/2/22 11:31, Joel Stanley wrote: It was scheduled for removal in 7.0. Signed-off-by: Joel Stanley -- v2: also remove from docs/about/deprecated.rst v3: remove strap define, add note to removed-features.rst --- docs/about/deprecated.rst | 7 docs/about/removed-features.rst |

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-18 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > Hello Peter, thanks for reviewing! > > On Mon, Feb 7, 2022 at 11:22 PM Peter Xu wrote: >> >> On Tue, Feb 01, 2022 at 03:29:03AM -0300, Leonardo Bras wrote: >> > -void multifd_send_sync_main(QEMUFile *f) >> > +int multifd_send_sync_main(QEMUFile *f) >> > { >>

Re: [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 15:55, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qapi/qapi-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v6 11/15] ui/cocoa: Add Services menu

2022-02-18 Thread Peter Maydell
On Tue, 15 Feb 2022 at 08:26, Philippe Mathieu-Daudé via wrote: > > From: Akihiko Odaki > > Services menu functionality of Cocoa is described at: > https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ > I tested this, and while it does create a Services menu,

Re: [PATCH 1/5] hw/riscv/riscv_hart: free the harts array when the object is finalized

2022-02-18 Thread Peter Maydell
On Fri, 18 Feb 2022 at 16:53, Damien Hedde wrote: > > The array is dynamically allocated by realize() depending on the > number of harts. > > This clean-up removes memory leaks which would happen in the > 'init->finalize' life-cycle use-case (happening when user creation > is allowed). If the

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-18 Thread Joao Martins
On 2/14/22 15:31, Igor Mammedov wrote: > On Mon, 14 Feb 2022 15:05:00 + > Joao Martins wrote: >> On 2/14/22 14:53, Igor Mammedov wrote: >>> On Mon, 7 Feb 2022 20:24:20 + >>> Joao Martins wrote: +{ +PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(pcms); +

Re: [PATCH v8 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-02-18 Thread Juan Quintela
Leonardo Bras wrote: > Implement zero copy send on nocomp_send_write(), by making use of QIOChannel > writev + flags & flush interface. > > Change multifd_send_sync_main() so flush_zero_copy() can be called > after each iteration in order to make sure all dirty pages are sent before > a new

Re: [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices

2022-02-18 Thread Stefano Garzarella
On Fri, Feb 18, 2022 at 11:24:23AM +0100, Eugenio Perez Martin wrote: On Thu, Feb 17, 2022 at 3:29 PM Stefano Garzarella wrote: On Thu, Feb 17, 2022 at 02:32:48AM -0500, Michael S. Tsirkin wrote: >On Tue, Feb 15, 2022 at 12:52:31PM +0530, Gautam Dawar wrote: >> This patch adds the ability to

Re: [PATCH v7 00/11] 9p: Add support for darwin

2022-02-18 Thread Will Cohen
On Tue, Feb 15, 2022 at 2:04 PM Will Cohen wrote: > This is a followup to > https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg02313.html, > adding 9p server support for Darwin. > > Since v6, the following changes have been made to the following patches: > > Patch 9/11: 9p: darwin:

[PATCH 4/5] hw/intc/riscv_aclint: swi: report errors and free allocated memory

2022-02-18 Thread Damien Hedde
Add the instance_finalize() method to free the allocated arrays and make realize() method report errors instead of exiting. This commit also move the 'num-harts' property check from riscv_aclint_swi_create() to realize(). Code in realize() is re-ordered to first check for errors and leave the

[PATCH 5/5] hw/intc/riscv_aclint: mtimer: report errors and free allocated memory

2022-02-18 Thread Damien Hedde
Add the instance_finalize() method to free the allocated arrays and make realize() method report errors instead of exiting. This commit also move the properties check from riscv_aclint_mtimer_create() to realize(). code in realize() is re-ordered to first check for errors and leave the object in

[PATCH 3/5] hw/intc/sifive_plic: report errors and free allocated memory

2022-02-18 Thread Damien Hedde
Add the instance_finalize() method to free the allocated arrays and make realize() method report errors instead of exiting. code in realize() is re-ordered to first check for errors and leave the object in a clean state. To achieve this, we do the following: + parse_hart_config and char_to_mode

[PATCH 0/5] RiscV cleanups for user-related life cycles

2022-02-18 Thread Damien Hedde
Hi, This is a few cleanups regarding user oriented life-cycle use cases. When a device is accessible to user creation, there are a few life-cycle use cases to consider: + init -> finalize (happen when introspection the object). + init -> realize-failure -> finalize (realize must report errors due

[PATCH 2/5] target/riscv: add riscv_cpu_release_claimed_interrupts function

2022-02-18 Thread Damien Hedde
This function will be used to undo an interrupt claim made by a previous call to riscv_cpu_claim_interrupts(). Signed-off-by: Damien Hedde --- target/riscv/cpu.h| 7 +++ target/riscv/cpu_helper.c | 8 2 files changed, 15 insertions(+) diff --git a/target/riscv/cpu.h

[PATCH 1/5] hw/riscv/riscv_hart: free the harts array when the object is finalized

2022-02-18 Thread Damien Hedde
The array is dynamically allocated by realize() depending on the number of harts. This clean-up removes memory leaks which would happen in the 'init->finalize' life-cycle use-case (happening when user creation is allowed). Signed-off-by: Damien Hedde --- hw/riscv/riscv_hart.c | 8 1

Re: [PATCH v8 3/5] migration: Add zero-copy-send parameter for QMP/HMP for Linux

2022-02-18 Thread Juan Quintela
Leonardo Bras wrote: > Add property that allows zero-copy migration of memory pages > on the sending side, and also includes a helper function > migrate_use_zero_copy_send() to check if it's enabled. > > No code is introduced to actually do the migration, but it allow > future implementations to

Re: [PATCH v8 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-02-18 Thread Juan Quintela
Leonardo Bras wrote: > For CONFIG_LINUX, implement the new zero copy flag and the optional callback > io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY > feature is available in the host kernel, which is checked on > qio_channel_socket_connect_sync() > >

Re: [PATCH v8 1/5] QIOChannel: Add flags on io_writev and introduce io_flush callback

2022-02-18 Thread Juan Quintela
Leonardo Bras wrote: > Add flags to io_writev and introduce io_flush as optional callback to > QIOChannelClass, allowing the implementation of zero copy writes by > subclasses. > > How to use them: > - Write data using qio_channel_writev*(...,QIO_CHANNEL_WRITE_FLAG_ZERO_COPY), > - Wait write

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-02-18 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > On Wed, Jan 19, 2022 at 3:16 PM Daniel P. Berrangé > wrote: >> >> On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leonardo Bras Soares Passos wrote: >> > Hello Daniel, >> > >> > On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé >> > wrote: >> > > >> > > On

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-18 Thread Paolo Bonzini
On 2/18/22 12:39, Michal Prívozník wrote: On 2/17/22 18:52, Paolo Bonzini wrote: I would like to co-mentor one or more projects about adding more statistics to Mark Kanda's newly-born introspectable statistics subsystem in QEMU

Re: [PATCH] build: fix build failure with gcc 11.2 by disabling -fcf-protection

2022-02-18 Thread Paolo Bonzini
On 2/8/22 22:19, Vineet Gupta wrote: When doing RV qemu builds with host gcc 11.2, ran into following build failure | cc -MMD -MP -MT linuxboot_dma.o -MF ./linuxboot_dma.d -O2 -g -march=i486 -Wall \ | -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes \ |

Re: [PATCH v2 6/8] configure: Pass filtered QEMU_OBJCFLAGS to meson

2022-02-18 Thread Paolo Bonzini
On 2/15/22 18:01, Philippe Mathieu-Daudé via wrote: Filter unsupported Objective-C options, to avoid 'unknown-warning-option' warnings when using Clang: [34/373] Compiling Objective-C object libcommon.fa.p/audio_coreaudio.m.o warning: unknown warning option '-Wold-style-declaration'; did

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-18 Thread Paolo Bonzini
On 2/15/22 18:01, Philippe Mathieu-Daudé via wrote: + +case "$cpu" in + aarch64) +write_c_skeleton; +if compile_prog "$CPU_CFLAGS -Werror -mno-outline-atomics" "" ; then + CPU_CFLAGS="-mno-outline-atomics $CPU_CFLAGS" +fi +;; Apart from the question of whether/how to work

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-18 Thread Paolo Bonzini
On 2/18/22 02:46, Richard Henderson wrote: I don't have gobjc/g++ installed, so ./configure defaulted to Clang to compile these languages, but compiled C files using GCC. At the end the Clang linker is used (the default c++ symlink). This is another form of compiler mis-configuration. If you

Re: [PATCH v5 00/16] host: Support macOS 12

2022-02-18 Thread Peter Maydell
On Mon, 14 Feb 2022 at 18:56, Philippe Mathieu-Daudé wrote: > > Few patches to be able to build QEMU on macOS 12 (Monterey). > > This basically consists of adapting deprecated APIs. > > CI job added to avoid bitrotting. Hi; I'm going to take the "obviously correct (to me)" cocoa patches from

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 9:49 AM, Jag Raman wrote: > > > >> On Feb 18, 2022, at 7:13 AM, Paolo Bonzini wrote: >> >> On 2/18/22 04:40, Jag Raman wrote: On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman wrote: >

Re: [PATCH] hw/arm: add initial mori-bmc board

2022-02-18 Thread Peter Maydell
On Tue, 8 Feb 2022 at 23:31, Patrick Venture wrote: > > This is the BMC attached to the OpenBMC Mori board. > > Signed-off-by: Patrick Venture > Reviewed-by: Chris Rauer > Reviewed-by: Ilkyun Choi > --- > docs/system/arm/nuvoton.rst | 1 + > hw/arm/npcm7xx_boards.c | 32

Re: [PATCH v2] scripts/qapi: minor delinting

2022-02-18 Thread Markus Armbruster
Markus Armbruster writes: > John Snow writes: > >> Get isort and pylint tools passing again. >> >> Signed-off-by: John Snow >> --- >> scripts/qapi/commands.py | 2 +- >> scripts/qapi/pylintrc| 15 +-- >> scripts/qapi/types.py| 6 +- >> scripts/qapi/visit.py| 6

'make check-acceptance' failing on s390 tests?

2022-02-18 Thread Peter Maydell
Hi; is anybody else seeing 'make check-acceptance' fail on some of the s390 tests? (009/183) tests/avocado/boot_linux.py:BootLinuxS390X.test_s390_ccw_virtio_tcg: INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status: ERROR\n{'name':

[PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix

2022-02-18 Thread Markus Armbruster
According to the grammar, a key __com.redhat_foo would be parsed as two key fragments __com and redhat_foo. It's actually parsed as a single fragment. Fix the grammar. Signed-off-by: Markus Armbruster --- util/keyval.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment

2022-02-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi/qapi-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c index fda7044539..63596e11c5 100644 --- a/qapi/qapi-util.c +++ b/qapi/qapi-util.c @@ -113,7 +113,7 @@ bool qapi_bool_parse(const char

Re: [PATCH v6 17/19] vfio-user: register handlers to facilitate migration

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 7:20 AM, Paolo Bonzini wrote: > > On 2/17/22 08:49, Jagannathan Raman wrote: >> Store and load the device's state during migration. use libvfio-user's >> handlers for this purpose >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by:

[PATCH 0/2] Minor doc fixes

2022-02-18 Thread Markus Armbruster
Markus Armbruster (2): keyval: Fix grammar comment to cover downstream prefix qapi: Fix stale reference to scripts/qapi.py in a comment qapi/qapi-util.c | 2 +- util/keyval.c| 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.35.1

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 7:13 AM, Paolo Bonzini wrote: > > On 2/18/22 04:40, Jag Raman wrote: >>> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: >>> >>> On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman >>> wrote: The compiler path that cmake gets from meson is corrupted. It

Re: [PATCH v5 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2022-02-18 Thread Lukasz Maniak
On Thu, Feb 17, 2022 at 06:45:01PM +0100, Lukasz Maniak wrote: > From: Łukasz Gieryk > > With four new properties: > - sriov_v{i,q}_flexible, > - sriov_max_v{i,q}_per_vf, > one can configure the number of available flexible resources, as well as > the limits. The primary and secondary

Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

2022-02-18 Thread Lukasz Maniak
On Fri, Feb 18, 2022 at 03:23:15AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > > Changes since v4: > > - Added hello world example for SR-IOV to the docs > > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > > - Fixed

Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

2022-02-18 Thread Peter Maydell
On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add a model of the Xilinx ZynqMP CRF. At the moment this > is mostly a stub model. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Edgar E. Iglesias > --- > +#define TYPE_XLNX_ZYNQMP_CRF

Re: [PATCH V7 00/29] Live Update

2022-02-18 Thread Steven Sistare
Please? - Steve On 1/7/2022 1:45 PM, Steven Sistare wrote: > Hi Dave, > It has been a long time since we chatted about this series. The vfio > patches have been updated with feedback from Alex and are close to being > final (I think). Could you take another look at the patches that you care

Re: [PATCH] hw/timer: fix a9gtimer vmstate

2022-02-18 Thread Peter Maydell
On Mon, 14 Feb 2022 at 07:34, Pavel Dovgalyuk wrote: > > ping > > On 07.02.2022 11:44, Pavel Dovgalyuk wrote: > > A9 gtimer includes global control field and number of per-cpu fields. > > But only per-cpu ones are migrated. This patch adds a subsection for > > global control field migration. > >

Re: [PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-18 Thread Peter Maydell
On Sun, 13 Feb 2022 at 02:12, Akihiko Odaki wrote: > > Signed-off-by: Akihiko Odaki > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) Thanks for volunteering to review cocoa-related patches! Would you mind having a look at these couple of patches from early January?

Re: [PATCH] build: fix build failure with gcc 11.2 by disabling -fcf-protection

2022-02-18 Thread Peter Maydell
On Tue, 8 Feb 2022 at 21:29, Vineet Gupta wrote: > > When doing RV qemu builds with host gcc 11.2, ran into following build failure > > | cc -MMD -MP -MT linuxboot_dma.o -MF ./linuxboot_dma.d -O2 -g -march=i486 > -Wall \ > | -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings >

Re: meson incremental build doesn't handle config file going away

2022-02-18 Thread Peter Maydell
On Fri, 18 Feb 2022 at 12:08, Thomas Huth wrote: > > On 18/02/2022 12.59, Peter Maydell wrote: > > I've noticed that the meson incremental build doesn't seem to > > cleanly handle a config file going away, as ppc64abi32-linux-user > > has recently. The build fails with: > > > >

  1   2   >