The aspeed ast2600 acculumative mode is described in datasheet
ast2600v10.pdf section 25.6.4:
1. Allocationg and initiating accumulative hash digest write buffer
with initial state.
* Since QEMU crypto/hash api doesn't provide the API to set initial
state of hash library, and the
This patch series implements ast2600 hace engine with accumulative mode
and unit test against to it.
Verified with following models
- AST2600 with OpenBmc VERSION_ID=2.12.0-dev-660-g4c7b3e692-dirty
- check hash verification in uboot and check whether qemu crashed
during openbmc web gui
This add two addition test cases for accumulative mode under sg enabled.
The input vector was manually craft with "abc" + bit 1 + padding zeros + L.
The padding length depends on algorithm, i.e. SHA512 (1024 bit),
SHA256 (512 bit).
The result was calculated by command line sha512sum/sha256sum
On 3/10/2022 9:07 PM, Michael S. Tsirkin wrote:
On Thu, Mar 10, 2022 at 08:28:09PM +0800, Xiaoyao Li wrote:
For PIT, it's straightforward to merge microvm::pit and
pc_machine::pit_enabled into x86ms::pit
For PIC, move microvm::pic to x86ms:pic, which gives PC machine the
ability to
>
> > diff --git a/include/hw/core/split-irq.h b/include/hw/core/split-irq.h
> > index ff8852f407..eb485dd7a6 100644
> > --- a/include/hw/core/split-irq.h
> > +++ b/include/hw/core/split-irq.h
> > @@ -42,9 +42,6 @@
> >
> > #define MAX_SPLIT_LINES 16
> >
> > -
> >
I have not done anything on this front, alas.
From: Aaron Lindsay
Sent: Thursday, March 24, 2022 1:17 PM
To: qemu-devel@nongnu.org ; qemu-...@nongnu.org
Cc: Alex Bennée ; richard.hender...@linaro.org
; Robert Henry
Subject: [EXTERNAL] Plugins Not Reporting
The 03/24/2022 17:37, Cédric Le Goater wrote:
> On 3/22/22 03:51, Jamin Lin wrote:
> > From: Steven Lee
> >
> > The embeded core of AST1030 SoC is ARM Coretex M4.
>
> embedded
>
Will fixed
> > It is hard to be integrated in the common Aspeed Soc framework.
>
> Can you explain the difficulties
On Thu, Mar 24, 2022 at 02:30:16PM -0400, John Snow wrote:
> I know we just added it, sorry. This is done in favor of qemu_io() which
> *also* returns the console output and status, but with more robust error
> handling on failure.
>
> Signed-off-by: John Snow
> ---
>
On Thu, Mar 24, 2022 at 02:30:15PM -0400, John Snow wrote:
> This test expects failure ... but only sometimes. When? Why?
>
> It's for reads of a region not defined by a bitmap. Adjust the test to
> be more explicit about what it expects to fail and why.
>
> Signed-off-by: John Snow
> ---
>
On Thu, Mar 24, 2022 at 02:30:14PM -0400, John Snow wrote:
> Modify this test to use assertRaises for its negative testing of
> qemu_io. If the exception raised does not match the one we tell it to
> expect, we get *that* exception unhandled. If we get no exception, we
> get a unittest assertion
On Thu, Mar 24, 2022 at 10:37:25AM +0100,
Gerd Hoffmann wrote:
> > #VE can be triggered in various situations. e.g., CPUID on some leaves, and
> > RD/WRMSR on some MSRs. #VE on pending page is just one of the sources, Linux
> > just wants to disable this kind of #VE since it wants to prevent
On Thu, Mar 24, 2022 at 02:30:06PM -0400, John Snow wrote:
> Without this change, asserting that qemu_io always returns 0 causes this
> test to fail in a way we happened not to be catching previously:
>
> qemu.utils.VerboseProcessError: Command
>
[Updating Vladimir's new preferred address in cc list]
On Thu, Mar 24, 2022 at 07:31:48PM +0200, Wouter Verhelst wrote:
> Hi Eric,
>
> Thanks for the ping; it had slipped my mind.
>
> On Fri, Dec 03, 2021 at 05:14:34PM -0600, Eric Blake wrote:
> > Request message
> >
> > -The request
Thanks for all the insight.
My use case is for embedded programs interfacing with custom fpga
registers, and getting code coverage for these.
My device wouldn't have value for the community.
I'll play around with dlopen, and prototype some stuff on a fork.
Sam
On Thu, Mar 24, 2022 at 4:51 PM
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> Hi,
>
> I've being using the examples as unit tests and found a few that
> doesn't work out-of-the-box, might be inteded in order to be less
> verbose in the qapi documentation but nevertheless I'm sending this
> out in case you want to
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> The member "paging" is not optional
>
> Signed-off-by: Victor Toso
> ---
> qapi/dump.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/dump.json b/qapi/dump.json
> index d3ed79e8cd..0873f16e5c 100644
> ---
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> * Missing the timestamp
> * Missing the "info" object in the "data" member
>
> Signed-off-by: Victor Toso
> ---
> qapi/acpi.json | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/acpi.json b/qapi/acpi.json
>
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> Minor issues found and fixed with the example:
> * The JSON object of EVENT was not closed
> * Missing timestamp
> * Flags are optional but if defined then all members should be
> include so we add "recursive" member.
Oh, yeah. Good call.
On Thu, 24 Mar 2022 at 20:53, Alex Bennée wrote:
> The upstream community isn't really motivated to maintain an API for
> external device models because ultimately we believe they are best
> placed in the QEMU code, if not upstream in a fork. There are some forks
> of QEMU which support things
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> As the websocket is not optional in VncBasicInfo.
>
> Signed-off-by: Victor Toso
> ---
> qapi/ui.json | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> Signed-off-by: Victor Toso
> ---
> qapi/run-state.json | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 1b9f64c9cd..f87b9378ac 100644
> ---
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> As reason member in not optional.
Suggest:
"The 'reason' member is not optional."
I also like how you included the type/structure name in the other
commit messages, can you work "SHUTDOWN" into this one?
>
> Signed-off-by: Victor Toso
>
On 24/03/2022 17:34, Alex Bennée wrote:
Leandro Lupori writes:
Adding a new, "virtual" TCG test target, ppc64le-softmmu, seems to
be the cleanest way to support both BE and LE tests for
ppc64-softmmu.
Signed-off-by: Leandro Lupori
---
tests/Makefile.include| 7 ---
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> * Data is an object, not a string. It generates a qdict.
> * Timestamp is not optional, let's add for completeness.
>
> Signed-off-by: Victor Toso
> ---
> qapi/net.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> * Timestamp is not optional, let's add for completeness.
> * Add '<-' to signalize it is receiving the data
> * Break likes like most of examples do
Oh, I think you meant "break lines like". That took a long minute to parse.
>
>
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> * qom-path is not optional
>
> Signed-off-by: Victor Toso
> ---
> qapi/machine.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 42fc68403d..9c460ec450 100644
> ---
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> * Timestamp is not optional, let's add for completeness.
> * Add '<-' to signalize it is receiving the data
> * While at it, add extra space before "result" and "total"
>
> Signed-off-by: Victor Toso
> ---
> qapi/dump.json | 7 ---
> 1
Sam Price writes:
> Is there a shared library interface in the works for writing firmware
> device models without recompiling all of qemu?
No - but incremental builds should be fairly cheap especially if you
only build the target you care about, possibly with a reduced config.
> I was
On Thu, Mar 24, 2022, 1:50 PM Victor Toso wrote:
> * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING
> * Argument device -> id
>
> Signed-off-by: Victor Toso
> ---
> qapi/block-core.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/block-core.json
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> Reason is not optional.
>
> Signed-off-by: Victor Toso
> ---
> qapi/block-core.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 585a9e020e..5b6c069dd9 100644
On Thu, Mar 24, 2022 at 3:15 PM John Snow wrote:
>
>
>
> On Thu, Mar 24, 2022, 1:50 PM Victor Toso wrote:
>>
>> Fatal is not optional.
>>
>> Signed-off-by: Victor Toso
>> ---
>> qapi/block-core.json | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
Leandro Lupori writes:
> Adding a new, "virtual" TCG test target, ppc64le-softmmu, seems to
> be the cleanest way to support both BE and LE tests for
> ppc64-softmmu.
>
> Signed-off-by: Leandro Lupori
> ---
> tests/Makefile.include| 7 ---
> tests/tcg/configure.sh
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso wrote:
>
> @hide and @soft are potential additions which fits the TODO section
> perfectly.
>
> The main motivation is to avoid this whole block of comment entering
> the wrong section in the python parser.
>
> Signed-off-by: Victor Toso
> ---
>
Hi folks,
I see there has been some previous discussion [1] about 1.5 years ago
around the fact that AArch64 SVE instructions do not emit any memory
operations via the plugin interface, as one might expect them to.
I am interested in being able to more accurately trace the memory
operations of
host atomics (2022-03-23
> 16:53:17 +0100)
>
>
> linux-user pull request 20220324
>
> Fix MIPS n32
> Fix ppoll, epoll_wait, pselect
> Fix error message in elfload.c
> Implement ARM __kernel_memory_barrier/__kernel_cmpxchg/__kernel_cmpxchg64
>
On Thu, Mar 24, 2022, 1:50 PM Victor Toso wrote:
> Fatal is not optional.
>
> Signed-off-by: Victor Toso
> ---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e89f2dfb5b..585a9e020e 100644
> ---
Each Microwatt/PowerNV test use its own head.S file and thus needs
different build rules.
Signed-off-by: Leandro Lupori
---
tests/tcg/ppc64/Makefile.softmmu-target | 33 +++--
tests/tcg/ppc64/system/mmu-head.S | 1 +
2 files changed, 27 insertions(+), 7 deletions(-)
Adding a new, "virtual" TCG test target, ppc64le-softmmu, seems to
be the cleanest way to support both BE and LE tests for
ppc64-softmmu.
Signed-off-by: Leandro Lupori
---
tests/Makefile.include| 7 ---
tests/tcg/configure.sh| 11 ++-
Add MMU test sources, from https://github.com/legoater/pnv-test,
based on Microwatt tests but with some adaptations.
In particular, the tests that check updates to RC bits were
removed, because, apparently, Microwatt never updates RC bits, but
just raise an exception when they must be updated,
From: Cédric Le Goater
Signed-off-by: Cédric Le Goater
Signed-off-by: Leandro Lupori
---
hw/ppc/pnv_core.c | 6 ++
include/hw/ppc/pnv_core.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
index 19e8eb885f..eb59b44a6c 100644
---
Add support to run softmmu tests for ppc64 and ppc64le.
To make it possible, a new "virtual" TCG test target,
ppc64le-softmmu, was created.
Also add the MMU tests from
https://github.com/legoater/pnv-test, that are the Microwatt
tests adapted to use a PowerNV console and to better integrate
with
Add support to build and run the multiarch hello test, that simply
prints a message and exits.
The linker script, console code and related header files were
imported from https://github.com/legoater/pnv-test, that are the
Microwatt tests adapted to use a PowerNV console.
Some other changes were
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/vector_helper.c | 16
1 file changed, 16 insertions(+)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index d654377fc8..3d19b9d141 100644
---
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 11 +
target/riscv/vector_helper.c| 452 ++--
2 files changed, 267 insertions(+), 196 deletions(-)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: Cédric Le Goater
Check the HID0 bit to send signal, currently modeled as a checkstop.
The QEMU implementation adds an exit using the GPR[3] value (that's a
hack for tests)
Signed-off-by: Cédric Le Goater
Signed-off-by: Leandro Lupori
---
target/ppc/cpu.h | 8
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 40 +
target/riscv/vector_helper.c| 28 +
2 files changed, 68 insertions(+)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 20
target/riscv/vector_helper.c| 68 ++---
2 files changed, 82 insertions(+), 6 deletions(-)
diff --git
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 4
target/riscv/vector_helper.c| 32 +
2 files changed, 36 insertions(+)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/vector_helper.c | 220 ++-
1 file changed, 114 insertions(+), 106 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 89927a424f..067095e19a
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 10 ++
target/riscv/vector_helper.c| 14 ++
2 files changed, 24 insertions(+)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 9 +++
target/riscv/vector_helper.c| 32 +
2 files changed, 41 insertions(+)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/insn_trans/trans_rvv.c.inc | 23 ++
target/riscv/vector_helper.c| 312 +---
2 files changed, 197 insertions(+), 138 deletions(-)
diff --git a/target/riscv/insn_trans/trans_rvv.c.inc
From: eopXD
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/vector_helper.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 9dedd1e29d..a972946bc2 100644
---
From: eopXD
According to v-spec (section 5.4):
When vstart ≥ vl, there are no body elements, and no elements are
updated in any destination vector register group, including that
no tail elements are updated with agnostic values.
vmsbf.m, vmsif.m, vmsof.m, viota.m, vcompress instructions
From: eopXD
This is the first commit regarding the tail agnostic behavior.
Added option 'rvv_ta_all_1s' to enable the behavior, the option
is default to false.
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/cpu.c | 1 +
target/riscv/cpu.h
According to v-spec, tail agnostic behavior can be either kept as
undisturbed or set elements' bits to all 1s. To distinguish the
difference of tail policies, QEMU should be able to simulate the tail
agnostic behavior as "set tail elements' bits to all 1s". An option
'rvv_ta_all_1s' is added to
From: eopXD
No functional change intended in this commit.
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/vector_helper.c | 76 ++--
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/target/riscv/vector_helper.c
From: eopXD
No functional change intended in this commit.
Signed-off-by: eop Chen
Reviewed-by: Frank Chang
---
target/riscv/vector_helper.c | 1132 +-
1 file changed, 565 insertions(+), 567 deletions(-)
diff --git a/target/riscv/vector_helper.c
On Thu, Mar 24, 2022 at 10:09 AM Hanna Reitz wrote:
>
> When the stream block job cuts out the nodes between top and base in
> stream_prepare(), it does not drain the subtree manually; it fetches the
> base node, and tries to insert it as the top node's backing node with
> bdrv_set_backing_hd().
On Thu, 24 Mar 2022 at 17:18, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> ---
> hw/arm/exynos4210.c | 26
> hw/intc/exynos4210_combiner.c | 79 +++
> hw/intc/exynos4210_gic.c | 36
> include/hw/arm/exynos4210.h
Like qemu-img, qemu-io returning 0 should be the norm and not the
exception. Remove all calls to qemu_io_silent that just assert the
return code is zero (That's every last call, as it turns out), and
replace them with a normal qemu_io() call.
qemu_io_silent_check() appeared to have been unused
I know we just added it, sorry. This is done in favor of qemu_io() which
*also* returns the console output and status, but with more robust error
handling on failure.
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 3 ---
1 file changed, 3 deletions(-)
diff --git
(Merge into prior patch.)
Signed-off-by: John Snow
---
tests/qemu-iotests/205 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index c0e107328f..15f798288a 100755
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@
(Merge into prior commit)
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/migration-permissions | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/tests/migration-permissions
b/tests/qemu-iotests/tests/migration-permissions
index
Merge with prior.
This is a little more involved, now, but maybe it's a small price to pay
for the better debug information being deployed universally.
Signed-off-by: John Snow
---
tests/qemu-iotests/245 | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
Just like qemu_img_log(), upgrade qemu_io_log() to enforce a return code
of zero by default.
Tests that use qemu_io_log(): 242 245 255 274 303 307 nbd-reconnect-on-open
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py
reimplement qemu_img() in terms of qemu_tool() in preparation for doing
the same with qemu_io().
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
qemu-io fails on read/write beyond end-of-file on raw images, so skip
these invocations when running the zero-length image tests.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
---
tests/qemu-iotests/040 | 14 --
1 file changed, 12 insertions(+), 2
GitLab: https://gitlab.com/jsnow/qemu/-/commits/iotests_qemu_io_diagnostics
CI: https://gitlab.com/jsnow/qemu/-/pipelines/499624472
Howdy,
This series does for qemu_io() what we've done for qemu_img() and makes
it a function that checks the return code by default and raises an
Exception when
Modify this test to use assertRaises for its negative testing of
qemu_io. If the exception raised does not match the one we tell it to
expect, we get *that* exception unhandled. If we get no exception, we
get a unittest assertion failure and the provided emsg printed to
screen.
If we get the
This test expects failure ... but only sometimes. When? Why?
It's for reads of a region not defined by a bitmap. Adjust the test to
be more explicit about what it expects to fail and why.
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/image-fleecing | 28 +
1
A forthcoming commit updates qemu_io() to raise an exception on non-zero
return by default, and changes its return type.
In preparation, simplify some calls to qemu_io() that assert that
specific error message strings do not appear in qemu-io's
output. Asserting that all of these calls return a
This makes these callsites a little simpler, but the real motivation is
a forthcoming commit will change the return type of qemu_io(), so removing
users of the return value now is helpful.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
tests/qemu-iotests/242 | 6 +++---
(Merge into prior patch.)
Signed-off-by: John Snow
---
tests/qemu-iotests/149 | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149
index 9bb96d6a1d..2ae318f16f 100755
--- a/tests/qemu-iotests/149
+++ b/tests/qemu-iotests/149
Rework qemu_io() to be analogous to qemu_img(); a function that requires
a return code of zero by default unless disabled explicitly.
Tests that use qemu_io():
030 040 041 044 055 056 093 124 129 132 136 148 149 151 152 163 165 205
209 219 236 245 248 254 255 257 260 264 280 298 300 302 304
The 'read' commands to qemu-io were malformed, and this invocation only
worked by coincidence because the error messages were identical. Oops.
There's no point in checking the patterning of the reference image, so
just check the empty image by itself instead.
(Note: as of this commit, nothing
Without this change, asserting that qemu_io always returns 0 causes this
test to fail in a way we happened not to be catching previously:
qemu.utils.VerboseProcessError: Command
'('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io',
'--cache', 'writeback', '--aio', 'threads',
(Merge into prior patch.)
Signed-off-by: John Snow
---
tests/qemu-iotests/030 | 85 --
1 file changed, 49 insertions(+), 36 deletions(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 567bf1da67..3a2de920a3 100755
---
Signed-off-by: Zongyuan Li
---
hw/arm/stellaris.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index b6c8a5d609..12c673c917 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -9,6 +9,7 @@
#include
Signed-off-by: Zongyuan Li
---
hw/arm/exynos4210.c | 26 +++
hw/intc/exynos4210_combiner.c | 81 +++
hw/intc/exynos4210_gic.c | 36 +---
include/hw/arm/exynos4210.h | 11 ++---
include/hw/core/split-irq.h | 5 +--
5 files
Signed-off-by: Zongyuan Li
Reviewed-by: Peter Maydell
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/811
---
hw/core/irq.c| 15 ---
include/hw/irq.h | 5 -
2 files changed, 20 deletions(-)
diff --git a/hw/core/irq.c b/hw/core/irq.c
index 741219277b..3623f711fe
On 3/23/22 04:28, Cédric Le Goater wrote:
Hello,
The PSIHB OCC and LPC interrupts are driven by a complex framework
using Object links and class handlers. Simplify the whole with GPIO
lines.
Series LGTM. All patches:
Reviewed-by: Daniel Henrique Barboza
Daniel
Thanks,
C.
This patch set tries to replace 'qemu_irq_split' function with QOM
object 'TYPE_SPLIT_IRQ' and totally remove this call.
If this patch set is applied, issue:
https://gitlab.com/qemu-project/qemu/-/issues/811
can be closed.
Changes since v3:
1. Squash Patch 3 & 4 into one, since they would
Signed-off-by: Zongyuan Li
---
hw/arm/realview.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 7b424e94a5..d2dc8a8952 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -13,9 +13,11 @@
An iotest's 'paused' condition is fickle; it will be reported as true
whenever the job is drained, for example, or when it is in the process
of completing.
030 and 041 contain such checks, we should replace them by checking the
job status instead. (As was done for 129 in commit
Typo in the commit title: s/usless/useless
On 3/23/22 04:28, Cédric Le Goater wrote:
Signed-off-by: Cédric Le Goater
---
hw/ppc/pnv_psi.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
index 950ecca40573..98045ed3d249 100644
---
This version seems to have some code style errors. I will fix that soon.
Sorry for the bother.
Li
On Fri, Mar 25, 2022 at 1:18 AM Zongyuan Li wrote:
>
> This patch set tries to replace 'qemu_irq_split' function with QOM
> object 'TYPE_SPLIT_IRQ' and totally remove this call.
>
> If this patch
Signed-off-by: Victor Toso
---
qapi/run-state.json | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 1b9f64c9cd..f87b9378ac 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@ -426,7 +426,8 @@
# Example:
#
# <-
Minor issues found and fixed with the example:
* The JSON object of EVENT was not closed
* Missing timestamp
* Flags are optional but if defined then all members should be
include so we add "recursive" member.
* Changed string from '' to "" in action-required member.
Signed-off-by: Victor Toso
Fatal is not optional.
Signed-off-by: Victor Toso
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index e89f2dfb5b..585a9e020e 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5008,7 +5008,7
* Data is an object, not a string. It generates a qdict.
* Timestamp is not optional, let's add for completeness.
Signed-off-by: Victor Toso
---
qapi/net.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/net.json b/qapi/net.json
index 7fab2e7cd8..82c0d9e778 100644
* qom-path is not optional
Signed-off-by: Victor Toso
---
qapi/machine.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 42fc68403d..9c460ec450 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1356,7 +1356,8 @@
#
Hi,
I've being using the examples as unit tests and found a few that
doesn't work out-of-the-box, might be inteded in order to be less
verbose in the qapi documentation but nevertheless I'm sending this
out in case you want to cherry-pick them.
Cheers,
Victor Toso (14):
qapi:
As the websocket is not optional in VncBasicInfo.
Signed-off-by: Victor Toso
---
qapi/ui.json | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 664da9e462..a810ed680c 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -710,10 +710,10
* Missing the timestamp
* Missing the "info" object in the "data" member
Signed-off-by: Victor Toso
---
qapi/acpi.json | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qapi/acpi.json b/qapi/acpi.json
index 51f0d55db7..d148f6db9f 100644
--- a/qapi/acpi.json
+++
Reason is not optional.
Signed-off-by: Victor Toso
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 585a9e020e..5b6c069dd9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -5059,7
The member "paging" is not optional
Signed-off-by: Victor Toso
---
qapi/dump.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/dump.json b/qapi/dump.json
index d3ed79e8cd..0873f16e5c 100644
--- a/qapi/dump.json
+++ b/qapi/dump.json
@@ -83,7 +83,7 @@
# Example:
#
#
As reason member in not optional.
Signed-off-by: Victor Toso
---
qapi/run-state.json | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/run-state.json b/qapi/run-state.json
index 43d66d700f..1b9f64c9cd 100644
--- a/qapi/run-state.json
+++ b/qapi/run-state.json
@@
* Timestamp is not optional, let's add for completeness.
* Add '<-' to signalize it is receiving the data
* While at it, add extra space before "result" and "total"
Signed-off-by: Victor Toso
---
qapi/dump.json | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
@hide and @soft are potential additions which fits the TODO section
perfectly.
The main motivation is to avoid this whole block of comment entering
the wrong section in the python parser.
Signed-off-by: Victor Toso
---
qapi/block-export.json | 10 +-
1 file changed, 5 insertions(+), 5
1 - 100 of 211 matches
Mail list logo
