[PATCH v9 5/7] config: add check to block layer

2022-09-09 Thread Sam Li
Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- block.c | 14 ++ block/file-posix.c | 14 ++ block/raw-format.c | 1 +

[PATCH v9 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-09-09 Thread Sam Li
Add a new zoned_host_device BlockDriver. The zoned_host_device option accepts only zoned host block devices. By adding zone management operations in this new BlockDriver, users can use the new block layer APIs including Report Zone and four zone management operations (open, close, finish, reset).

[PATCH v9 2/7] file-posix: introduce helper functions for sysfs attributes

2022-09-09 Thread Sam Li
Use get_sysfs_str_val() to get the string value of device zoned model. Then get_sysfs_zoned_model() can convert it to BlockZoneModel type of QEMU. Use get_sysfs_long_val() to get the long value of zoned device information. Signed-off-by: Sam Li Reviewed-by: Hannes Reinecke Reviewed-by: Stefan

[PATCH v9 6/7] qemu-iotests: test new zone operations

2022-09-09 Thread Sam Li
We have added new block layer APIs of zoned block devices. Test it with: Create a null_blk device, run each zone operation on it and see whether reporting right zone information. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/tests/zoned.out | 53 +++

[PATCH v9 7/7] docs/zoned-storage: add zoned device documentation

2022-09-09 Thread Sam Li
Add the documentation about the zoned device support to virtio-blk emulation. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- docs/devel/zoned-storage.rst | 41 ++ docs/system/qemu-block-drivers.rst.inc | 6 2 files changed, 47 insertions(+)

[PATCH v9 4/7] raw-format: add zone operations to pass through requests

2022-09-09 Thread Sam Li
raw-format driver usually sits on top of file-posix driver. It needs to pass through requests of zone commands. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- block/raw-format.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/raw-format.c b/block/raw-format.c

[PATCH v9 1/7] include: add zoned device structs

2022-09-09 Thread Sam Li
Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Damien Le Moal --- include/block/block-common.h | 43 1 file changed, 43 insertions(+) diff --git a/include/block/block-common.h b/include/block/block-common.h index fdb7306e78..36bd0e480e

[PATCH v9 0/7] Add support for zoned device

2022-09-09 Thread Sam Li
Zoned Block Devices (ZBDs) devide the LBA space to block regions called zones that are larger than the LBA size. It can only allow sequential writes, which reduces write amplification in SSD, leading to higher throughput and increased capacity. More details about ZBDs can be found at:

Re: [PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-09-09 Thread Yonggang Luo
How about using github actions, I tried before and it's running fast, there is no resource restriction. Just don't know how to trigger it through gitlab, if that's possible, then it's would be good On Sat, Sep 10, 2022 at 8:33 AM Bin Meng wrote: > > On Sat, Sep 10, 2022 at 12:32 AM Thomas Huth

[PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-09 Thread Nicolin Chen
Its caller vfio_connect_container() assigns a default value to info->iova_pgsizes, even if vfio_get_iommu_info() fails. This would result in a "Segmentation fault" error, when the VFIO_IOMMU_GET_INFO ioctl errors out. Since the caller has g_free already, drop the g_free in its rollback routine

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2022-09-09 Thread Bin Meng
On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: > > On 08/09/2022 14:28, Bin Meng wrote: > > > From: Bin Meng > > > > At present packaging the required DLLs of QEMU executables is a > > manual process, and error prone. > > > > Actually build/config-host.mak contains a GLIB_BINDIR

Re: [PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-09-09 Thread Bin Meng
On Sat, Sep 10, 2022 at 12:32 AM Thomas Huth wrote: > > On 08/09/2022 15.28, Bin Meng wrote: > > From: Bin Meng > > > > At present the prerequisite packages for 64-bit and 32-bit builds > > are slightly different. Let's use the same packages for both. > > Not sure whether that's a good idea ...

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-09 Thread Kirill A . Shutemov
On Fri, Sep 09, 2022 at 12:11:05PM -0700, Andy Lutomirski wrote: > > > On Fri, Sep 9, 2022, at 7:32 AM, Kirill A . Shutemov wrote: > > On Thu, Sep 08, 2022 at 09:48:35PM -0700, Andy Lutomirski wrote: > >> On 8/19/22 17:27, Kirill A. Shutemov wrote: > >> > On Thu, Aug 18, 2022 at 08:00:41PM

virtiofsd: Any reason why there's not an "openat2" sandbox mode?

2022-09-09 Thread Colin Walters
We previously had a chat here https://lore.kernel.org/all/348d4774-bd5f-4832-bd7e-a21491fda...@www.fastmail.com/T/ around virtiofsd and privileges and the case of trying to run virtiofsd inside an unprivileged (Kubernetes) container. Right now we're still using 9p, and it has bugs (basically it

Re: [RFC PATCH 2/3] hw/peci: add PECI support for NPCM7xx BMCs

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:51PM +, Titus Rwantare wrote: > This allows BMC firmware for npcm7xx BMCs to talk to a PECI client > in qemu. > > Signed-off-by: Titus Rwantare > Reviewed-by: Patrick Venture Looks good to me! Reviewed-by: Peter Delevoryas > --- > MAINTAINERS

Re: [RFC PATCH 1/3] hw/peci: add initial support for PECI

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:50PM +, Titus Rwantare wrote: > PECI - Platform Environment Control Interface > > This commit adds support for reading basic sensor values from a client > on the PECI bus. > BMCs can use the PECI wire to get thermal information out of an Intel > cpu.

Re: [RFC PATCH 0/3] Initial PECI bus support

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:49PM +, Titus Rwantare wrote: > The Platform Environment Control Interface (PECI), is a way for Intel > processors to communicate with management controllers. > > This series of patches simulate some PECI subsystem functionality. This > work is currently used

Re: [RFC PATCH 3/3] hw/peci: add support for EndPointConfig reads

2022-09-09 Thread Peter Delevoryas
On Tue, Sep 06, 2022 at 10:05:52PM +, Titus Rwantare wrote: > Signed-off-by: Titus Rwantare > Reviewed-by: Hao Wu > --- > hw/peci/peci-client.c | 63 ++ > hw/peci/peci-core.c| 44 +++-- > include/hw/peci/peci.h | 23

Re: [PATCH 04/20] ppc4xx: Use Ppc4xxSdramBank in ppc4xx_sdram_banks()

2022-09-09 Thread BALATON Zoltan
On Fri, 2 Sep 2022, BALATON Zoltan wrote: On Fri, 2 Sep 2022, Cédric Le Goater wrote: On 8/19/22 18:55, BALATON Zoltan wrote: Change ppc4xx_sdram_banks() to take one Ppc4xxSdramBank array instead of the separate arrays and adjust ppc4xx_sdram_init() and ppc440_sdram_init() accordingly as well

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-09 Thread Andy Lutomirski
On Fri, Sep 9, 2022, at 7:32 AM, Kirill A . Shutemov wrote: > On Thu, Sep 08, 2022 at 09:48:35PM -0700, Andy Lutomirski wrote: >> On 8/19/22 17:27, Kirill A. Shutemov wrote: >> > On Thu, Aug 18, 2022 at 08:00:41PM -0700, Hugh Dickins wrote: >> > > On Thu, 18 Aug 2022, Kirill A . Shutemov wrote:

Re: [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension

2022-09-09 Thread Christoph Müllner
On Thu, Sep 8, 2022 at 9:45 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/6/22 13:22, Christoph Muellner wrote: > > @@ -732,6 +733,7 @@ static int ex_rvc_shifti(DisasContext *ctx, int imm) > > #include "decode-xtheadbs.c.inc" > > #include "decode-xtheadcmo.c.inc" > >

Re: [PATCH 03/11] RISC-V: Adding T-Head SYNC instructions

2022-09-09 Thread Christoph Müllner
On Thu, Sep 8, 2022 at 9:30 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/6/22 13:22, Christoph Muellner wrote: > > +NOP_PRIVCHECK(th_sfence_vmas, REQUIRE_PRIV_MHS) > > +NOP_PRIVCHECK(th_sync, REQUIRE_PRIV_MHSU) > > +NOP_PRIVCHECK(th_sync_i, REQUIRE_PRIV_MHSU) > >

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2022-09-09 Thread Mark Cave-Ayland
On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GLIB_BINDIR variable which is the directory where glib and other DLLs reside. This works for both

Re: [PATCH v9 08/10] target/s390x: interception of PTF instruction

2022-09-09 Thread Janis Schoetterl-Glausch
On Fri, 2022-09-02 at 09:55 +0200, Pierre Morel wrote: > When the host supports the CPU topology facility, the PTF > instruction with function code 2 is interpreted by the SIE, > provided that the userland hypervizor activates the interpretation > by using the KVM_CAP_S390_CPU_TOPOLOGY KVM

Call for Outreachy Dec-Mar internship project ideas

2022-09-09 Thread Stefan Hajnoczi
Dear QEMU & KVM community, The Outreachy open source internship program (https://www.outreachy.org/) is running again from December-March. If you have a project idea you'd like to mentor and are a regular contributor to QEMU or KVM, please reply to this email by September 22nd. I have CCed active

Re: [PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-09-09 Thread Thomas Huth
On 08/09/2022 15.28, Bin Meng wrote: From: Bin Meng At present the prerequisite packages for 64-bit and 32-bit builds are slightly different. Let's use the same packages for both. Not sure whether that's a good idea ... I did that on purpose to save some few time during compilation (since

Re: [PATCH 4/7] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build

2022-09-09 Thread Thomas Huth
On 08/09/2022 16.04, Marc-André Lureau wrote: Hi On Thu, Sep 8, 2022 at 5:33 PM Bin Meng > wrote: From: Bin Meng mailto:bin.m...@windriver.com>> The sed processing of build/config-host.mak seems to be no longer needed, and there is no such in the 32-bit

Re: [PATCH v5 3/3] i386: Add notify VM exit support

2022-09-09 Thread Peter Xu
On Wed, Aug 17, 2022 at 10:08:45AM +0800, Chenyi Qiang wrote: > There are cases that malicious virtual machine can cause CPU stuck (due > to event windows don't open up), e.g., infinite loop in microcode when > nested #AC (CVE-2015-5307). No event window means no event (NMI, SMI and > IRQ) can be

Re: [PATCH v5 2/3] i386: kvm: extend kvm_{get, put}_vcpu_events to support pending triple fault

2022-09-09 Thread Peter Xu
On Wed, Aug 17, 2022 at 10:08:44AM +0800, Chenyi Qiang wrote: > For the direct triple faults, i.e. hardware detected and KVM morphed > to VM-Exit, KVM will never lose them. But for triple faults sythesized > by KVM, e.g. the RSM path, if KVM exits to userspace before the request > is serviced,

Re: [PATCH v3] target/i386: Set maximum APIC ID to KVM prior to vCPU creation

2022-09-09 Thread Peter Xu
On Thu, Aug 25, 2022 at 10:52:46AM +0800, Zeng Guang wrote: > Specify maximum possible APIC ID assigned for current VM session to KVM > prior to the creation of vCPUs. By this setting, KVM can set up VM-scoped > data structure indexed by the APIC ID, e.g. Posted-Interrupt Descriptor > pointer

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-09 Thread Michael Roth
On Wed, Jul 06, 2022 at 04:20:02PM +0800, Chao Peng wrote: > This is the v7 of this series which tries to implement the fd-based KVM > guest private memory. The patches are based on latest kvm/queue branch > commit: > > b9b71f43683a (kvm/queue) KVM: x86/mmu: Buffer nested MMU > split_desc_cache

[PATCH] target/riscv/pmp: fix non-translated page size address checks w/ MPU

2022-09-09 Thread leon
From: Leon Schuermann This commit fixes PMP address access checks with non page-aligned PMP regions on harts with MPU enabled. Without this change, the presence of an MPU in the virtual CPU model would influence the PMP address check behavior when an access size was unknown (`size == 0`),

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-09 Thread Daniel P . Berrangé
On Fri, Sep 09, 2022 at 04:27:34PM +0200, Claudio Fontana wrote: > On 9/9/22 15:50, Daniel P. Berrangé wrote: > > On Fri, Sep 09, 2022 at 03:41:22PM +0200, Claudio Fontana wrote: > >> On 9/9/22 00:05, Paolo Bonzini wrote: > >>> Il gio 8 set 2022, 15:47 Claudio Fontana ha scritto: > >>> > On

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-09-09 Thread Kirill A . Shutemov
On Thu, Sep 08, 2022 at 09:48:35PM -0700, Andy Lutomirski wrote: > On 8/19/22 17:27, Kirill A. Shutemov wrote: > > On Thu, Aug 18, 2022 at 08:00:41PM -0700, Hugh Dickins wrote: > > > On Thu, 18 Aug 2022, Kirill A . Shutemov wrote: > > > > On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-09 Thread Claudio Fontana
On 9/9/22 15:50, Daniel P. Berrangé wrote: > On Fri, Sep 09, 2022 at 03:41:22PM +0200, Claudio Fontana wrote: >> On 9/9/22 00:05, Paolo Bonzini wrote: >>> Il gio 8 set 2022, 15:47 Claudio Fontana ha scritto: >>> On 9/8/22 11:39, Paolo Bonzini wrote: > Queued, thanks. > > Paolo

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-09 Thread Robert Hoo
On Fri, 2022-09-09 at 15:39 +0200, Igor Mammedov wrote: > On Thu, 1 Sep 2022 11:27:20 +0800 > Robert Hoo wrote: > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > which > > deprecates corresponding _DSM Functions defined by PMEM _DSM > > Interface spec > > [2]. > > > >

[PATCH v2 5/8] target/riscv: debug: Introduce tinfo CSR

2022-09-09 Thread Bin Meng
From: Frank Chang tinfo.info: One bit for each possible type enumerated in tdata1. If the bit is set, then that type is supported by the currently selected trigger. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1)

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-09 Thread Daniel P . Berrangé
On Fri, Sep 09, 2022 at 03:41:22PM +0200, Claudio Fontana wrote: > On 9/9/22 00:05, Paolo Bonzini wrote: > > Il gio 8 set 2022, 15:47 Claudio Fontana ha scritto: > > > >> On 9/8/22 11:39, Paolo Bonzini wrote: > >>> Queued, thanks. > >>> > >>> Paolo > >>> > >>> > >> > >> Thanks. When it comes to

[PATCH v2 3/8] target/riscv: debug: Introduce tdata1, tdata2, and tdata3 CSRs

2022-09-09 Thread Bin Meng
From: Frank Chang Replace type2_trigger_t with the real tdata1, tdata2, and tdata3 CSRs, which allows us to support more types of triggers in the future. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1) target/riscv/cpu.h | 6 ++-

[PATCH v2 4/8] target/riscv: debug: Restrict the range of tselect value can be written

2022-09-09 Thread Bin Meng
From: Frank Chang The value of tselect CSR can be written should be limited within the range of supported triggers number. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1) target/riscv/debug.c | 9 +++-- 1 file changed, 3

[PATCH v2 8/8] target/riscv: debug: Add initial support of type 6 trigger

2022-09-09 Thread Bin Meng
From: Frank Chang Type 6 trigger is similar to a type 2 trigger, but provides additional functionality and should be used instead of type 2 in newer implementations. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1) target/riscv/debug.h |

[PATCH v2 0/8] target/riscv: Improve RISC-V Debug support

2022-09-09 Thread Bin Meng
This patchset refactors RISC-V Debug support to allow more types of triggers to be extended. The initial support of type 6 trigger, which is similar to type 2 trigger with additional functionality, is also introduced in this patchset. This is a v2 respin of previous patch originally done by

[PATCH v2 2/8] target/riscv: debug: Introduce build_tdata1() to build tdata1 register content

2022-09-09 Thread Bin Meng
From: Frank Chang Introduce build_tdata1() to build tdata1 register content, which can be shared among all types of triggers. Signed-off-by: Frank Chang Reviewed-by: Bin Meng [bmeng: moved RV{32,64}_DATA_MASK definition to this patch] Signed-off-by: Bin Meng --- Changes in v2: - moved

[PATCH v2 6/8] target/riscv: debug: Create common trigger actions function

2022-09-09 Thread Bin Meng
From: Frank Chang Trigger actions are shared among all triggers. Extract to a common function. Signed-off-by: Frank Chang Reviewed-by: Bin Meng [bmeng: handle the DBG_ACTION_NONE case] Signed-off-by: Bin Meng --- Changes in v2: - add handling of the DBG_ACTION_NONE case in

[PATCH v2 1/8] target/riscv: debug: Determine the trigger type from tdata1.type

2022-09-09 Thread Bin Meng
From: Frank Chang Current RISC-V debug assumes that only type 2 trigger is supported. To allow more types of triggers to be supported in the future (e.g. type 6 trigger, which is similar to type 2 trigger with additional functionality), we should determine the trigger type from tdata1.type.

[PATCH v2 7/8] target/riscv: debug: Check VU/VS modes for type 2 trigger

2022-09-09 Thread Bin Meng
From: Frank Chang Type 2 trigger cannot be fired in VU/VS modes. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1) target/riscv/debug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/riscv/debug.c

Re: [PATCH v3] audio: add help option for -audio and -audiodev

2022-09-09 Thread Claudio Fontana
On 9/9/22 00:05, Paolo Bonzini wrote: > Il gio 8 set 2022, 15:47 Claudio Fontana ha scritto: > >> On 9/8/22 11:39, Paolo Bonzini wrote: >>> Queued, thanks. >>> >>> Paolo >>> >>> >> >> Thanks. When it comes to programmatic checks about what QEMU supports in >> terms of audio, >> >> is there

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-09 Thread Igor Mammedov
On Thu, 1 Sep 2022 11:27:20 +0800 Robert Hoo wrote: > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, which > deprecates corresponding _DSM Functions defined by PMEM _DSM Interface spec > [2]. > > Since the semantics of the new Label Methods are same as old _DSM > methods,

Re: [PATCH v2 4/5] msmouse: Add pnp data

2022-09-09 Thread Marc-André Lureau
On Thu, Sep 8, 2022 at 9:34 PM Arwed Meyer wrote: > Make msmouse send serial pnp data. > Enables you to see nice qemu device name in Win9x. > > Signed-off-by: Arwed Meyer > lgtm Reviewed-by: Marc-André Lureau > --- > chardev/msmouse.c | 58 ++- >

Re: [PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-09 Thread Marc-André Lureau
Hi On Thu, Sep 8, 2022 at 9:38 PM Arwed Meyer wrote: > Make use of fifo8 functions instead of implementing own fifo code. > This makes the code more readable and reduces risk of bugs. > > Signed-off-by: Arwed Meyer > Reviewed-by: Marc-André Lureau > --- > chardev/msmouse.c | 43

Re: [PATCH v2 2/5] chardev: src buffer const for write functions

2022-09-09 Thread Marc-André Lureau
Hi On Thu, Sep 8, 2022 at 9:44 PM Arwed Meyer wrote: > Make source buffers const for char be write functions. > This allows using buffers returned by fifo as buf parameter and source > buffer > should not be changed by write functions anyway. > > Signed-off-by: Arwed Meyer > Reviewed-by:

Re: [PATCH v3] 9pfs: use GHashTable for fid table

2022-09-09 Thread Christian Schoenebeck
On Donnerstag, 8. September 2022 13:23:53 CEST Linus Heckemann wrote: > The previous implementation would iterate over the fid table for > lookup operations, resulting in an operation with O(n) complexity on > the number of open files and poor cache locality -- for every open, > stat, read, write,

Re: [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits

2022-09-09 Thread Ani Sinha
+alexb On Tue, Sep 6, 2022 at 7:00 PM Daniel P. Berrangé wrote: > > On Tue, Sep 06, 2022 at 06:58:02PM +0530, Ani Sinha wrote: > > On Tue, Sep 6, 2022 at 18:45 Daniel P. Berrangé wrote: > > > > > On Thu, Jul 14, 2022 at 02:24:18PM +0100, Peter Maydell wrote: > > > > On Mon, 11 Jul 2022 at

Re: [PATCH v2 10/10] hw/isa/vt82c686: Create rtc-time alias in boards instead

2022-09-09 Thread Bernhard Beschow
Am 30. August 2022 21:46:57 UTC schrieb "Philippe Mathieu-Daudé" : >On 30/8/22 21:00, Bernhard Beschow wrote: >> According to good QOM practice, an object should only deal with objects >> of its own sub tree. Having devices create an alias on the machine >> object doesn't respect this good

Re: [PATCH] tcg/ppc: Optimize 26-bit jumps

2022-09-09 Thread Leandro Lupori
On 9/8/22 18:44, Richard Henderson wrote: On 9/8/22 22:18, Leandro Lupori wrote: PowerPC64 processors handle direct branches better than indirect ones, resulting in less stalled cycles and branch misses. However, PPC's tb_target_set_jmp_target() was only using direct branches for 16-bit jumps,

Re: [PATCH] hw/virtio/vhost-shadow-virtqueue: Silence GCC error "maybe-uninitialized"

2022-09-09 Thread Bernhard Beschow
Am 6. September 2022 17:52:24 UTC schrieb "Philippe Mathieu-Daudé" : >On Tue, Sep 6, 2022 at 7:12 PM Bernhard Beschow wrote: >> >> GCC issues a false positive warning, resulting in build failure with -Werror: >> >> In file included from /usr/include/glib-2.0/glib.h:114, >>

Re: [PATCH] e1000e: set RX desc status with DD flag in a separate operation

2022-09-09 Thread dinghui
On 2022/9/9 10:40, Jason Wang wrote: On Sat, Aug 27, 2022 at 12:06 AM Ding Hui wrote: Like commit 034d00d48581 ("e1000: set RX descriptor status in a separate operation"), there is also same issue in e1000e, which would cause lost packets or stop sending packets to VM with DPDK. Do similar

Re: [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase

2022-09-09 Thread David Hildenbrand
On 09.09.22 10:02, Emanuele Giuseppe Esposito wrote: One thing I forgot to ask: iirc we used to have a workaround to kick all vcpus out, update memory slots, then continue all vcpus. Would that work for us too for the problem you're working on? As reference, here is one such approach for

[RFC PATCH 1/1] kvm/kvm-all.c: implement KVM_SET_USER_MEMORY_REGION_LIST ioctl

2022-09-09 Thread Emanuele Giuseppe Esposito
Instead of sending memslot updates in each callback, kvm listener already takes care of sending them in the commit phase, as multiple ioctls. Using the new KVM_SET_USER_MEMORY_REGION_LIST, we just need a single call containing all memory regions to update. Signed-off-by: Emanuele Giuseppe

[RFC PATCH 0/1] accel/kvm: implement KVM_SET_USER_MEMORY_REGION_LIST

2022-09-09 Thread Emanuele Giuseppe Esposito
Use the new KVM ioctl KVM_SET_USER_MEMORY_REGION_LIST. Based on my QEMU serie "[RFC PATCH v2 0/3] accel/kvm: extend kvm memory listener to support". Based-on: 20220909081150.709060-1-eespo...@redhat.com Requires my KVM serie "[RFC PATCH 0/9] kvm: implement atomic memslot updates"

Re: [PATCH v2 2/2] Update linux headers to v6.0-rc4

2022-09-09 Thread Cornelia Huck
On Fri, Sep 09 2022, Chenyi Qiang wrote: > commit 7e18e42e4b280c85b76967a9106a13ca61c16179 > > Signed-off-by: Chenyi Qiang > --- > include/standard-headers/asm-x86/bootparam.h | 7 +- > include/standard-headers/drm/drm_fourcc.h | 73 +++- > include/standard-headers/linux/ethtool.h

Re: [PATCH v2 1/2] configure: Add -Wno-gnu-variable-sized-type-not-at-end

2022-09-09 Thread Cornelia Huck
On Fri, Sep 09 2022, Chenyi Qiang wrote: > In recent linux headers update to v6.0-rc, it switched GNU Maybe "A Linux headers update to v6.0-rc switches some definitions from the GNU..." ? > 'zero-length-array' extension to the C-standard-defined flexible array > member. e.g. > > struct

Re: [PATCH] hw/nvme: remove param zoned.auto_transition

2022-09-09 Thread Klaus Jensen
On Aug 12 13:01, Niklas Cassel wrote: > The intention of the Zoned Namespace Command Set Specification was > never to make an automatic zone transition optional. > > Excerpt from the nvmexpress.org zns mailing list: > """ > A question came up internally on the differences between ZNS and ZAC/ZBC

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2022 at 10:01:16AM +0200, Eugenio Perez Martin wrote: > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > > > > > To have enabled vlans at device

[RFC PATCH v2 3/3] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase

2022-09-09 Thread Emanuele Giuseppe Esposito
Instead of sending a single ioctl every time ->region_* or ->log_* callbacks are called, "queue" all memory regions in a kvm_userspace_memory_region_list that will be sent only when committing. This allow the KVM kernel API to be extended and support multiple memslots updates in a single call.

[RFC PATCH v2 0/3] accel/kvm: extend kvm memory listener to support

2022-09-09 Thread Emanuele Giuseppe Esposito
The aim of this serie is to prepare kvm memory listener to support atomic memslots update. In order to do that, QEMU should take care of sending all memslot updates in a single ioctl, so that they can all be processed atomically. In order to do that, implement kml->begin() and kml->commit()

[RFC PATCH v2 1/3] linux-headers/linux/kvm.h: introduce kvm_userspace_memory_region_list ioctl

2022-09-09 Thread Emanuele Giuseppe Esposito
Introduce new KVM_SET_USER_MEMORY_REGION_LIST ioctl and kvm_userspace_memory_region_list that will be used to pass multiple memory region updates at once to KVM. Signed-off-by: Emanuele Giuseppe Esposito --- linux-headers/linux/kvm.h | 20 1 file changed, 20 insertions(+)

Re: [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase

2022-09-09 Thread Emanuele Giuseppe Esposito
Am 26/08/2022 um 16:44 schrieb David Hildenbrand: > On 26.08.22 16:32, Emanuele Giuseppe Esposito wrote: >> >> >> Am 26/08/2022 um 16:15 schrieb David Hildenbrand: >>> On 16.08.22 12:12, Emanuele Giuseppe Esposito wrote: Instead of sending a single ioctl every time ->region_* or ->log_*

[RFC PATCH v2 2/3] accel/kvm/kvm-all.c: pass kvm_userspace_memory_region_entry instead

2022-09-09 Thread Emanuele Giuseppe Esposito
It won't change anything from the kernel side, but prepares the logic for KVM_SET_USER_MEMORY_REGION_LIST ioctl, where all requests are sent at once. Because QEMU does not send any memslot MOVE request to KVM, simplify mem.invalidate_slot logic to only detect DELETE requests. Signed-off-by:

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Eugenio Perez Martin
On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > > > To have enabled vlans at device startup may happen in the destination of > > > a live migration, so this configuration

Re: [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase

2022-09-09 Thread Emanuele Giuseppe Esposito
>> One thing I forgot to ask: iirc we used to have a workaround to kick all >> vcpus out, update memory slots, then continue all vcpus. Would that work >> for us too for the problem you're working on? > > As reference, here is one such approach for region resizes only: > >

Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-09-09 Thread Emanuele Giuseppe Esposito
Am 27/08/2022 um 23:03 schrieb Peter Xu: > On Fri, Aug 26, 2022 at 10:13:47AM -0400, Peter Xu wrote: >> On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote: >>> What do you mean "will empty all regions with those listeners"? >>> But yes theoretically vhost-vdpa and

Re: [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase

2022-09-09 Thread Emanuele Giuseppe Esposito
Hi Peter, Apologies for the delay to answer you. [...] >> >> - Doing the above is still not enough, as KVM figures what operation to >> do depending on the current state of the memslots. >> Assuming we already have an already existing MR y, and now we get the >> list DELETE(y) CREATE(y/2) (ie

Re: [PATCH 3/3] vdpa: Support VLAN on nic control shadow virtqueue

2022-09-09 Thread Eugenio Perez Martin
On Fri, Sep 9, 2022 at 8:39 AM Jason Wang wrote: > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > Update the virtio-net device model with each guest's update of vlan > > through control virtqueue, and accept creating a SVQ with a device > > exposing vlan feature bit. > > > > Done

Re: [PATCH 3/6] parallels: Add checking and repairing duplicate offsets in BAT

2022-09-09 Thread Alexander Ivanov
On 08.09.2022 19:45, Denis V. Lunev wrote: On 9/8/22 19:15, Denis V. Lunev wrote: On 9/2/22 10:52, Alexander Ivanov wrote: Cluster offsets must be unique among all BAT entries. Find duplicate offsets in the BAT. If a duplicated offset is found fix it by copying the content of the relevant

[RISU PATCH] risu: Use altermate stack

2022-09-09 Thread Song Gao
We can use altermate stack, so that we can use sp register as intput/ouput register. I had tested aarch64/LoongArch architecture. Signed-off-by: Song Gao --- risu.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/risu.c b/risu.c index 1c096a8..98dba94

Re: [PATCH v3 1/3] util/main-loop: Fix maximum number of wait objects for win32

2022-09-09 Thread Bin Meng
On Fri, Sep 2, 2022 at 12:19 PM Bin Meng wrote: > > On Wed, Aug 24, 2022 at 4:52 PM Bin Meng wrote: > > > > From: Bin Meng > > > > The maximum number of wait objects for win32 should be > > MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. > > > > Signed-off-by: Bin Meng > > --- > > > >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Jason Wang
On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > To have enabled vlans at device startup may happen in the destination of > > a live migration, so this configuration must be restored. > > > > At this moment the code is not

Re: [PATCH 3/3] vdpa: Support VLAN on nic control shadow virtqueue

2022-09-09 Thread Jason Wang
On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > Update the virtio-net device model with each guest's update of vlan > through control virtqueue, and accept creating a SVQ with a device > exposing vlan feature bit. > > Done in the same commit since a malicious guest could send vlan >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Jason Wang
On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > To have enabled vlans at device startup may happen in the destination of > a live migration, so this configuration must be restored. > > At this moment the code is not accessible, since SVQ refuses to start if > vlan feature is exposed by

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2022 at 08:06:53AM +0200, Gerd Hoffmann wrote: > Hi, > > > > > I think we still want to key this one off host_phys_bits > > > > so it works for e.g. hyperv emulation too. > > > > > > I think that should be the case. The chunks above change the > > > host-phys-bits option from

Re: [PATCH v3] audio: Add sndio backend

2022-09-09 Thread Volker Rümelin
Am 07.09.22 um 15:23 schrieb Alexandre Ratchov: sndio is the native API used by OpenBSD, although it has been ported to other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.). Signed-off-by: Brad Smith Signed-off-by: Alexandre Ratchov --- References to the previous patch

Re: [PATCH v2 2/2] [RfC] expose host-phys-bits to guest

2022-09-09 Thread Gerd Hoffmann
Hi, > > > I think we still want to key this one off host_phys_bits > > > so it works for e.g. hyperv emulation too. > > > > I think that should be the case. The chunks above change the > > host-phys-bits option from setting cpu->host_phys_bits to setting > > the FEAT_KVM_HINTS bit. That