Re: [PATCH 27/37] target/i386: Use tcg gvec ops for pmovmskb

2022-09-14 Thread Richard Henderson
On 9/14/22 23:59, Paolo Bonzini wrote: On Tue, Sep 13, 2022 at 10:17 AM Richard Henderson wrote: On 9/12/22 00:04, Paolo Bonzini wrote: +while (vec_len > 8) { +vec_len -= 8; +tcg_gen_shli_tl(s->T0, s->T0, 8); +tcg_gen_ld8u_tl(t, cpu_env, offsetof(CPUX86State, xmm_t

Re: [PATCH 1/1] s390x/tcg: Fix opcode for lzrf

2022-09-14 Thread Thomas Huth
On 14/09/2022 11.57, Christian Borntraeger wrote: Fix the opcode for Load and Zero Rightmost Byte (32). Cc: qemu-sta...@nongnu.org Reported-by: Nathan Chancellor Tested-by: Nathan Chancellor Signed-off-by: Christian Borntraeger --- target/s390x/tcg/insn-data.def | 2 +- 1 file changed, 1 i

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Jason Wang
On Wed, Sep 14, 2022 at 11:44 PM Si-Wei Liu wrote: > > > > On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: > > On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > >> > >> > >> On 9/14/2022 3:20 AM, Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > >>> wrote: >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Jason Wang
On Wed, Sep 14, 2022 at 7:33 PM Si-Wei Liu wrote: > > > > On 9/14/2022 3:20 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > > wrote: > >> On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > On Wed, Sep 7

Re: [PATCH v2 3/6] vhost-net: vhost-user: update vhost_net_virtqueue_reset()

2022-09-14 Thread Jason Wang
On Wed, Sep 14, 2022 at 2:21 PM Xuan Zhuo wrote: > > On Wed, 14 Sep 2022 11:13:29 +0800, Jason Wang wrote: > > > > 在 2022/9/12 11:10, Kangjie Xu 写道: > > > Update vhost_net_virtqueue_reset() for vhost-user scenario. > > > > > > In order to reuse some functions, we process the idx for > > > vhost-u

Re:Re: [PATCH] bugfix:migrate with block-dirty-bitmap (disk size is big enough) can't be finished

2022-09-14 Thread liuhaiwei9699
Hi ,Vladimir sometimes ,post-copy mode is not the best choice. For instance, Supposing migrate process will take ten minutes,but network may be interruptted In this process . If it does happenthe , memory data of VM will be splitted into two parts, and will not be rollback.This is a bad situatio

Re: [PATCH 1/2] target/i386: fix cmpxchg with 32-bit register destination

2022-09-14 Thread Paolo Bonzini
On 9/12/22 09:55, Richard Henderson wrote:  * Compute... Why bother passing NULL, and fixing it up at each use... +static void gen_op_mov_reg_v(DisasContext *s, MemOp ot, int reg, TCGv t0) +{ +    gen_op_deposit_reg_v(s, ot, reg, NULL, t0);   } ... when you can just as easily pass in the

Re: [PATCH 27/37] target/i386: Use tcg gvec ops for pmovmskb

2022-09-14 Thread Paolo Bonzini
On Tue, Sep 13, 2022 at 10:17 AM Richard Henderson wrote: > > On 9/12/22 00:04, Paolo Bonzini wrote: > > +while (vec_len > 8) { > > +vec_len -= 8; > > +tcg_gen_shli_tl(s->T0, s->T0, 8); > > +tcg_gen_ld8u_tl(t, cpu_env, offsetof(CPUX86State, > > xmm_t0.ZMM_B(vec_len - 1

Re: [PATCH 30/37] target/i386: reimplement 0x0f 0x10-0x17, add AVX

2022-09-14 Thread Paolo Bonzini
On Tue, Sep 13, 2022 at 12:14 PM Richard Henderson wrote: > > +static void gen_VMOVLPx(DisasContext *s, CPUX86State *env, X86DecodedInsn > > *decode) > > +{ > > +int vec_len = sse_vec_len(s, decode); > > + > > +tcg_gen_ld_i64(s->tmp1_i64, cpu_env, decode->op[2].offset + > > offsetof(XMMR

Re: [PATCH v2 04/30] tests/avocado: add explicit timeout for s390 TCG tests

2022-09-14 Thread Thomas Huth
On 14/09/2022 16.59, Alex Bennée wrote: We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/a

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Nicolin Chen
On Wed, Sep 14, 2022 at 02:03:25PM -0600, Alex Williamson wrote: > > > > +container->pgsizes = 4096; > > > > > > This might be a separate question/issue: I wonder if we should use > > > "sysconf(_SC_PAGE_SIZE)" here instead of 4096. > > > > > > With a kernel using a larger page size, e.g.

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Alex Williamson
On Wed, 14 Sep 2022 13:53:39 -0600 Alex Williamson wrote: > On Wed, 14 Sep 2022 12:02:56 -0700 > Nicolin Chen wrote: > > > Hi Alex, > > > > On Wed, Sep 14, 2022 at 12:10:29PM -0600, Alex Williamson wrote: > > > > > > > > Its caller vfio_connect_container() assigns a default value > > > > >

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Alex Williamson
On Wed, 14 Sep 2022 12:02:56 -0700 Nicolin Chen wrote: > Hi Alex, > > On Wed, Sep 14, 2022 at 12:10:29PM -0600, Alex Williamson wrote: > > > > > > Its caller vfio_connect_container() assigns a default value > > > > > to info->iova_pgsizes, even if vfio_get_iommu_info() fails. > > > > > This wou

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Nicolin Chen
Hi Alex, On Wed, Sep 14, 2022 at 12:10:29PM -0600, Alex Williamson wrote: > > > > Its caller vfio_connect_container() assigns a default value > > > > to info->iova_pgsizes, even if vfio_get_iommu_info() fails. > > > > This would result in a "Segmentation fault" error, when the > > > > VFIO_IOMMU_

Re: [PATCH v8 11/14] qemu-sockets: move and rename SocketAddress_to_str()

2022-09-14 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > Rename SocketAddress_to_str() to socket_uri() and move it to > util/qemu-sockets.c close to socket_parse(). > > socket_uri() generates a string from a SocketAddress while > socket_parse() generates a SocketAddress from a string. > > Signed-off-by: La

Re: [PATCH v8 12/14] qemu-sockets: update socket_uri() and socket_parse() to be consistent

2022-09-14 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > To be consistent with socket_uri(), add 'tcp:' prefix for inet type in > socket_parse(), by default socket_parse() use tcp when no prefix is > provided (format is host:port). > > In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:' >

[PATCH v2] tcg/ppc: Optimize 26-bit jumps

2022-09-14 Thread Leandro Lupori
PowerPC64 processors handle direct branches better than indirect ones, resulting in less stalled cycles and branch misses. However, PPC's tb_target_set_jmp_target() was only using direct branches for 16-bit jumps, while PowerPC64's unconditional branch instructions are able to handle displacements

Re: [PATCH v3 03/20] ppc4xx_sdram: Get rid of the init RAM hack

2022-09-14 Thread BALATON Zoltan
On Wed, 14 Sep 2022, BALATON Zoltan wrote: On Wed, 14 Sep 2022, Cédric Le Goater wrote: On 9/14/22 13:44, BALATON Zoltan wrote: On Wed, 14 Sep 2022, Cédric Le Goater wrote: On 9/13/22 21:52, BALATON Zoltan wrote: The do_init parameter of ppc4xx_sdram_init() is used to map memory regions that

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Alex Williamson
On Wed, 14 Sep 2022 12:10:29 -0600 Alex Williamson wrote: > On Mon, 12 Sep 2022 13:51:30 -0700 > Nicolin Chen wrote: > > > On Mon, Sep 12, 2022 at 02:38:52PM +0200, Cornelia Huck wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Fri, Sep 09 2022, Nic

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 9/14/22 13:55, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable machine. Also table in json or csv format should be used

Re: [PATCH v3 03/20] ppc4xx_sdram: Get rid of the init RAM hack

2022-09-14 Thread BALATON Zoltan
On Wed, 14 Sep 2022, Cédric Le Goater wrote: On 9/14/22 13:44, BALATON Zoltan wrote: On Wed, 14 Sep 2022, Cédric Le Goater wrote: On 9/13/22 21:52, BALATON Zoltan wrote: The do_init parameter of ppc4xx_sdram_init() is used to map memory regions that is normally done by the firmware by programm

Re: [PATCH] vfio/common: Do not g_free in vfio_get_iommu_info

2022-09-14 Thread Alex Williamson
On Mon, 12 Sep 2022 13:51:30 -0700 Nicolin Chen wrote: > On Mon, Sep 12, 2022 at 02:38:52PM +0200, Cornelia Huck wrote: > > External email: Use caution opening links or attachments > > > > > > On Fri, Sep 09 2022, Nicolin Chen wrote: > > > > > Its caller vfio_connect_container() assigns a d

Re: [PATCH 0/2] target/m68k: fix two writes to %sr

2022-09-14 Thread Howard Spoelstra
On Tue, Sep 13, 2022 at 6:29 PM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 13/09/2022 15:28, Richard Henderson wrote: > > > The second was described by Mark in the lobby of KVM Forum. > > The first was found by inspection of other uses of gen_helper_set_sr. > > > > r~ > > > > Ri

Re: [PATCH 0/2] target/m68k: fix two writes to %sr

2022-09-14 Thread Howard Spoelstra
On Wed, Sep 14, 2022 at 6:48 PM Howard Spoelstra wrote: > > > On Tue, Sep 13, 2022 at 6:29 PM Mark Cave-Ayland < > mark.cave-ayl...@ilande.co.uk> wrote: > >> On 13/09/2022 15:28, Richard Henderson wrote: >> >> > The second was described by Mark in the lobby of KVM Forum. >> > The first was found

Re: [PATCH 28/37] target/i386: reimplement 0x0f 0x38, add AVX

2022-09-14 Thread Paolo Bonzini
On Tue, Sep 13, 2022 at 11:31 AM Richard Henderson wrote: > > +void glue(helper_vpmaskmovq_st, SUFFIX)(CPUX86State *env, > > +Reg *v, Reg *s, target_ulong a0) > > +{ > > +int i; > > + > > +for (i = 0; i < (1 << SHIFT); i++) { > > +if (v->Q(i)

Re: [PATCH] target/m68k: Implement atomic test-and-set

2022-09-14 Thread Laurent Vivier
Le 29/08/2022 à 07:17, Richard Henderson a écrit : This is slightly more complicated than cas, because tas is allowed on data registers. Signed-off-by: Richard Henderson --- target/m68k/translate.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(

[RFC PATCH 2/4] qtest: make read/write operation appear to be from CPU

2022-09-14 Thread Alex Bennée
The point of qtest is to simulate how running code might interact with the system. However because it's not a real system we have places in the code which especially handle check qtest_enabled() before referencing current_cpu. Now we can encode these details in the MemTxAttrs lets do that so we can

Re: [PATCH 23/37] target/i386: reimplement 0x0f 0x78-0x7f, add AVX

2022-09-14 Thread Paolo Bonzini
On Mon, Sep 12, 2022 at 3:56 PM Richard Henderson wrote: > > +static void gen_SSE4a_I(DisasContext *s, CPUX86State *env, X86DecodedInsn > > *decode) > > +{ > > +TCGv_i32 length = tcg_const_i32(decode->immediate & 255); > > +TCGv_i32 index = tcg_const_i32(decode->immediate >> 8); > > + >

[PATCH v2 23/30] tests/docker: update and flatten debian-all-test-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We also need to ensure we install clang as it is used for those builds as well. It would be nice to port this to lcitool but for now this will do. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message

[RFC PATCH 0/4] use MemTxAttrs to signal cpu index

2022-09-14 Thread Alex Bennée
Hi, This ostensibly fixes a bug with gdbstub when accessing the GIC state (via system registers). It also proposes a pattern for removing current_cpu/qtest_enabled() hacks in hw/ by passing the cpu index via MemTxAttrs. For the ARM timer code we also assert that those accesses do come from a CPU (

[PATCH v2 18/30] configure: explicitly set cflags for --disable-pie

2022-09-14 Thread Alex Bennée
This is working around current limitation of Meson's handling of --disable-pie. Signed-off-by: Alex Bennée Cc: Paolo Bonzini --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 575dde1c1f..6c169b23b5 100755 --- a/configure +++ b/configure @@ -1394

[RFC PATCH 4/4] hw/timer: convert mptimer access to attrs to derive cpu index

2022-09-14 Thread Alex Bennée
This removes the hacks to deal with empty current_cpu. Signed-off-by: Alex Bennée --- hw/timer/arm_mptimer.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c index cdfca3000b..a7fe6ddc0d 100644 --- a/h

[PATCH v2 22/30] tests/docker: flatten debian-riscv64-test-cross

2022-09-14 Thread Alex Bennée
Flatten into a single dockerfile and update to match the rest of the test cross compile dockerfiles. Signed-off-by: Alex Bennée Message-Id: <20220826172128.353798-17-alex.ben...@linaro.org> --- v2 - minor reword of commit msg --- .gitlab-ci.d/container-cross.yml | 1 -

[RFC PATCH 1/4] hw: encode accessing CPU index in MemTxAttrs

2022-09-14 Thread Alex Bennée
We currently have hacks across the hw/ to reference current_cpu to work out what the current accessing CPU is. This breaks in some cases including using gdbstub to access HW state. As we have MemTxAttrs to describe details about the access lets extend it to mention if this is a CPU access and which

[PATCH v2 11/30] tests/docker: update and flatten debian-mips64-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-7-alex.ben...@linaro.or

[RFC PATCH 3/4] hw/intc/gic: use MxTxAttrs to divine accessing CPU

2022-09-14 Thread Alex Bennée
Now that MxTxAttrs encodes a CPU we should use that to figure it out. This solves edge cases like accessing via gdbstub or qtest. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/124 --- hw/intc/arm_gic.c | 39 ++- 1 file chan

[PATCH v2 30/30] tests/docker: remove the Debian base images

2022-09-14 Thread Alex Bennée
We no longer use these in any of our images. Clean-up the remaining comments and documentation that reference them and remove from the build. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-25-alex.ben...@linaro.org> --- docs/devel/testing.rst

[PATCH v2 24/30] tests/lcitool: bump to latest version

2022-09-14 Thread Alex Bennée
We need this to be able to cleanly build the x86 cross images. There are a few minor updates triggered by lcitool-refresh including adding "libslirp" to the freebsd vars and opensuse-leap which will help when we finally drop the slirp submodule from QEMU. Signed-off-by: Alex Bennée Reviewed-by: T

[PATCH v2 20/30] gitlab-ci: update aarch32/aarch64 custom runner jobs

2022-09-14 Thread Alex Bennée
The custom runner is now using 22.04 so we can drop our hacks to deal with broken libssh and glusterfs. The provisioning scripts will be updated in a separate commit. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-15-alex.ben...@linaro.org> --- v2 - fix

[PATCH v2 26/30] tests/docker: update and flatten debian-loongarch-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. In this case it is a binary distribution of the toolchain anyway. Signed-off-by: Alex Bennée Reviewed-by: Thoma

[PATCH v2 27/30] tests/docker: update and flatten debian-hexagon-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not some of the extraneous packages from the base image to build the toolchain. Signed-off-by: Alex Bennée Message-Id: <20220826172128.353798-22-alex.ben...@linaro.org> --- v2 - use debian11 consis

[PATCH v2 25/30] tests/docker: update and flatten debian-amd64-cross

2022-09-14 Thread Alex Bennée
Now lcitool has support for building a x86_64 cross image we can use it for this. Signed-off-by: Alex Bennée Acked-by: Thomas Huth Message-Id: <20220826172128.353798-20-alex.ben...@linaro.org> --- .gitlab-ci.d/container-cross.yml | 1 - tests/docker/Makefile.include

[PATCH v2 28/30] tests/docker: update and flatten debian-toolchain

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile as we do not need anything from the base image to build the toolchain. This is used to build both the nios and microblaze toolchains. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <202208261

[PATCH v2 19/30] gitlab-ci/custom-runners: Disable -static-pie for ubuntu-20.04-aarch64

2022-09-14 Thread Alex Bennée
From: Richard Henderson The project has reached the magic size at which we see /usr/aarch64-linux-gnu/lib/libc.a(init-first.o): in function `__libc_init_first': (.text+0x10): relocation truncated to fit: R_AARCH64_LD64_GOTPAGE_LO15 against \ symbol `__environ' defined in .bss section in /usr/a

[PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

2022-09-14 Thread Alex Bennée
We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a Dockerfile. Signed-off-by: Alex Bennée Acked-by: Thomas Huth Message-Id: <20220826172128.35

[PATCH v2 21/30] Deprecate 32 bit big-endian MIPS

2022-09-14 Thread Alex Bennée
It's becoming harder to maintain a cross-compiler to test this host architecture as the old stable Debian 10 ("Buster") moved into LTS which supports fewer architectures. For now: - mark it's deprecation in the docs - downgrade the containers to build TCG tests only - drop the cross builds f

[PATCH v2 17/30] tests/vm: Remove obsolete Fedora VM test

2022-09-14 Thread Alex Bennée
From: Thomas Huth It's still based on Fedora 30 - which is not supported anymore by QEMU since years. Seems like nobody is using (and refreshing) this, and it's easier to test this via a container anyway, so let's remove this now. Signed-off-by: Thomas Huth Message-Id: <20220822175317.190551-1-

[PATCH v2 15/30] tests/docker: remove tricore qemu/debian10 dependency

2022-09-14 Thread Alex Bennée
We missed removing this dependency when we flattened the build. Fixes: 39ce923732 (gitlab: enable a very minimal build with the tricore container) Signed-off-by: Alex Bennée Fixes: 39ce923732 ("gitlab: enable a very minimal build with the tricore container") Message-Id: <20220826172128.353798-

[PATCH v2 14/30] tests/docker: flatten debian-powerpc-test-cross

2022-09-14 Thread Alex Bennée
Flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-10-alex.ben...@linaro.org> --- .gitlab-ci.d/container-cross.yml

[PATCH v2 13/30] tests/docker: update and flatten debian-sparc64-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-9-alex.ben...@linaro.or

[PATCH v2 05/30] tests/avocado: add explicit timeout for ppc64le TCG tests

2022-09-14 Thread Alex Bennée
We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_li

[PATCH v2 12/30] tests/docker: update and flatten debian-sh4-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-8-alex.ben...@linaro.or

[PATCH v2 08/30] tests/docker: update and flatten debian-alpha-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-4-alex.ben...@linaro.or

[PATCH v2 16/30] tests/docker: remove amd64 qemu/debian10 dependency

2022-09-14 Thread Alex Bennée
We missed removing this dependency when we flattened the build. Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool) Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-12-alex.ben...@linaro.org> --- tests/docker/Makefile.include | 1 - 1 file ch

[PATCH v2 07/30] tests/avocado: reduce the default timeout to 120s

2022-09-14 Thread Alex Bennée
We should be aiming to keep our tests under 2 minutes so lets reduce the default timeout to that. Tests that we know take longer should explicitly set a longer timeout. Signed-off-by: Alex Bennée Message-Id: <20220826172128.353798-3-alex.ben...@linaro.org> --- tests/avocado/avocado_qemu/__init__

[PATCH v2 10/30] tests/docker: update and flatten debian-m68k-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-6-alex.ben...@linaro.or

[PATCH v2 03/30] tests/avocado: add explicit timeout for Aarch64 TCG tests

2022-09-14 Thread Alex Bennée
We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linu

[PATCH v2 09/30] tests/docker: update and flatten debian-hppa-cross

2022-09-14 Thread Alex Bennée
Update to the latest stable Debian. While we are at it flatten into a single dockerfile. We really don't need the rest of the stuff from the QEMU base image just to compile test images. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20220826172128.353798-5-alex.ben...@linaro.or

[PATCH v2 04/30] tests/avocado: add explicit timeout for s390 TCG tests

2022-09-14 Thread Alex Bennée
We don't want to rely on the soon to be reduced default time. These tests are still slow for something we want to run in CI though. Signed-off-by: Alex Bennée --- tests/avocado/boot_linux.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_li

[PATCH v2 06/30] tests/avocado: split the AST2x00Machine classes

2022-09-14 Thread Alex Bennée
The SDK tests take a lot longer to run and hence need a longer timeout. As they run well over the 60 second maximum for CI lets also disable them for CI as well. I suspect they also suffer from the inability to detect the login prompt due to no newlines being processed. Signed-off-by: Alex Bennée

[PATCH v2 00/30] testing/next pre-PR (testing update and mips deprecation)

2022-09-14 Thread Alex Bennée
Hi, This is the current state of the testing tree. It was slightly delayed from the last posting as I was waiting for the libvirt-ci update to get merged. Changes since last post: - added some more avocado timeouts - moved cflags hack in the --disable-pie patch into configure - usual addres

[PATCH v2 02/30] tests/avocado/boot_linux_console: Fix the test_aarch64_xlnx_versal_virt test

2022-09-14 Thread Alex Bennée
From: Thomas Huth The assets that this test tries to download have been removed from the server. Update to a newer version to get it working again. Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Message-Id: <20220829080940.110831-1-th...@redhat.com> Signed-off-by: Alex Bennée --- t

[PATCH v2 01/30] gitlab: reduce targets in cross_user_build_job

2022-09-14 Thread Alex Bennée
We already limit the scope of the cross system build to reduce the cross build times. With the recent addition of more targets we are also running into timeout issues for some of the cross user builds. I've selected a few of those linux-user targets which are less likely to be in common use as dis

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Si-Wei Liu
On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: On 9/14/2022 3:20 AM, Jason Wang wrote: On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin wrote: On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: On Fri, Sep 9, 2022 at 2:38 PM Jason

Re: [PATCH v11 20/21] blockjob: remove unused functions

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:21, Emanuele Giuseppe Esposito wrote: These public functions are not used anywhere, thus can be dropped. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v11 21/21] job: remove unused functions

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:21, Emanuele Giuseppe Esposito wrote: These public functions are not used anywhere, thus can be dropped. Also, since this is the final job API that doesn't use AioContext lock and replaces it with job_lock, adjust all remaining function documentation to clearly specify if the job lo

Re: [PATCH v3 03/20] ppc4xx_sdram: Get rid of the init RAM hack

2022-09-14 Thread Cédric Le Goater
On 9/14/22 13:44, BALATON Zoltan wrote: On Wed, 14 Sep 2022, Cédric Le Goater wrote: On 9/13/22 21:52, BALATON Zoltan wrote: The do_init parameter of ppc4xx_sdram_init() is used to map memory regions that is normally done by the firmware by programming the SDRAM controller. This is needed when

[PULL 11/11] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell The riscv target incorrectly enabled semihosting always, whether the user asked for it or not. Call semihosting_enabled() passing the correct value to the is_userspace argument, which fixes this and also handles the userspace=on argument. Because we do this at translate time

Re: [PATCH v11 13/21] jobs: protect job.aio_context with BQL and job_mutex

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: In order to make it thread safe, implement a "fake rwlock", where we allow reads under BQL *or* job_mutex held, but writes only under BQL *and* job_mutex. The only write we have is in child_job_set_aio_ctx, which always happens under drain (so

[PULL 06/11] target/arm: Honour -semihosting-config userspace=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell Honour the commandline -semihosting-config userspace=on option, instead of never permitting userspace semihosting calls in system emulation mode, by passing the correct value to the is_userspace argument of semihosting_enabled(), instead of manually checking and always forbidd

[PULL 03/11] target/m68k: Use semihosting/syscalls.h

2022-09-14 Thread Richard Henderson
This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Acked-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/m68k-semi.c | 281 +++- 1 file changed, 49 insertions(

[PULL 09/11] target/nios2: Honour -semihosting-config userspace=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell Honour the commandline -semihosting-config userspace=on option, instead of always permitting userspace semihosting calls in system emulation mode, by passing the correct value to the is_userspace argument of semihosting_enabled(). Note that this is a behaviour change: if the

[PULL 00/11] semihosting patch queue

2022-09-14 Thread Richard Henderson
The following changes since commit 79dfa177ae348bb5ab5f97c0915359b13d6186e2: Merge tag 'pull-qapi-2022-09-07' of git://repo.or.cz/qemu/armbru into staging (2022-09-07 13:13:30 -0400) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-semi-202

[PULL 02/11] target/nios2: Convert semihosting errno to gdb remote errno

2022-09-14 Thread Richard Henderson
The semihosting abi used by nios2 uses the gdb remote protocol filesys errnos. Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi

Re: [PATCH v11 17/21] job.h: categorize JobDriver callbacks that need the AioContext lock

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:21, Emanuele Giuseppe Esposito wrote: Some callbacks implementation use bdrv_* APIs that assume the AioContext lock is held. Make sure this invariant is documented. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[PATCH v2 4/4] tests/docker: run script use realpath instead of readlink

2022-09-14 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" The alpine docker image only comes with busybox, which doesn't have the '-e' option on its readlink, so change it to 'realpath' to avoid that problem. Suggested-by: Daniel P. Berrangé Signed-off-by: Lucas Mateus Castro (alqotel) --- tests/docker/run | 2 +

Re: [PATCH v11 16/21] blockjob: protect iostatus field in BlockJob struct

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: iostatus is the only field (together with .job) that needs protection using the job mutex. It is set in the main loop (GLOBAL_STATE functions) but read in I/O code (block_job_error_action). In order to protect it, change block_job_iostatus_set

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Eugenio Perez Martin
On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > > > > On 9/14/2022 3:20 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > > wrote: > >> On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > On Wed, Sep 7

Re: [PATCH v11 11/21] jobs: group together API calls under the same job lock

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: Now that the API offers also _locked() functions, take advantage of it and give also the caller control to take the lock and call _locked functions. This makes sense especially when we have for loops, because it makes no sense to have: for(job

[PULL 10/11] target/xtensa: Honour -semihosting-config userspace=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell Honour the commandline -semihosting-config userspace=on option, instead of always permitting userspace semihosting calls in system emulation mode, by passing the correct value to the is_userspace argument of semihosting_enabled(). Note that this is a behaviour change: if the

[PATCH v2 2/4] scripts/ci/setup: Fix libxen requirements

2022-09-14 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" XEN hypervisor is only available in ARM and x86, but the yaml only checked if the architecture is different from s390x, changed it to a more accurate test. Tested this change on a Ubuntu 20.04 ppc64le. Signed-off-by: Lucas Mateus Castro (alqotel) Reviewed-b

Proposal for a fixed ram migration stream format for file-based migrations

2022-09-14 Thread Nikolay Borisov
Hello, Based on several discussions I've had in the past 2 days and time spent looking at the migration stream code I came up with the following proposal for changes to the stream format. Let me recap what we have right now: ...() Where is put only when the current page we are writing to belo

[PATCH v2 1/4] scripts/ci/setup: ninja missing from build-environment

2022-09-14 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" ninja-build is missing from the RHEL environment, so a system prepared with that script would still fail to compile QEMU. Tested on a Fedora 36 Signed-off-by: Lucas Mateus Castro (alqotel) --- scripts/ci/setup/build-environment.yml | 1 + 1 file changed, 1

[PULL 07/11] target/m68k: Honour -semihosting-config userspace=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell Honour the commandline -semihosting-config userspace=on option, instead of never permitting userspace semihosting calls in system emulation mode, by passing the correct value to the is_userspace argument of semihosting_enabled(), instead of manually checking and always forbidd

[PULL 08/11] target/mips: Honour -semihosting-config userspace=on

2022-09-14 Thread Richard Henderson
From: Peter Maydell Honour the commandline -semihosting-config userspace=on option, instead of always permitting userspace semihosting calls in system emulation mode, by passing the correct value to the is_userspace argument of semihosting_enabled(). Note that this is a behaviour change: if the

[PULL 05/11] semihosting: Allow optional use of semihosting from userspace

2022-09-14 Thread Richard Henderson
From: Peter Maydell Currently our semihosting implementations generally prohibit use of semihosting calls in system emulation from the guest userspace. This is a very long standing behaviour justified originally "to provide some semblance of security" (since code with access to the semihosting A

[PATCH v2 0/4] Patch series to set up a ppc64le CI

2022-09-14 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" This patch series aim to make easier to set up a compilation and CI environment on PPC64 and PPC64LE machines. v2: This patch series are only patches 2-4 of v1 and an alternative to patch 1 suggested by Daniel. Lucas Mateus Castro (alqotel) (4): scripts/c

[PULL 04/11] target/m68k: Convert semihosting errno to gdb remote errno

2022-09-14 Thread Richard Henderson
The semihosting abi used by m68k uses the gdb remote protocol filesys errnos. Acked-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/m68k-semi.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/target/m68k/m68k-semi.c b/ta

[PULL 01/11] target/nios2: Use semihosting/syscalls.h

2022-09-14 Thread Richard Henderson
This separates guest file descriptors from host file descriptors, and utilizes shared infrastructure for integration with gdbstub. Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 296 +++--- 1 file changed, 50 insertions(+), 246 deletions(-) diff

Re: [PATCH] target/arm: Fix alignment for VLD4.32

2022-09-14 Thread Richard Henderson
On 9/14/22 11:50, Clément Chigot wrote: When requested, the alignment for VLD4.32 is 8 and not 16. See ARM documentation about VLD4 encoding: ebytes = 1 << UInt(size); if size == '10' then alignment = if a == '0' then 1 else 8; else alignment = if a == '0' then 1

[PULL 20/20] target/arm: Make boards pass base address to armv7m_load_kernel()

2022-09-14 Thread Richard Henderson
From: Peter Maydell Currently armv7m_load_kernel() takes the size of the block of memory where it should load the initial guest image, but assumes that it should always load it at address 0. This happens to be true of all our M-profile boards at the moment, but it isn't guaranteed to always be s

Re: [PATCH v11 10/21] block/mirror.c: use of job helpers in drivers

2022-09-14 Thread Vladimir Sementsov-Ogievskiy
On 8/26/22 16:20, Emanuele Giuseppe Esposito wrote: Once job lock is used and aiocontext is removed, mirror has to perform job operations under the same critical section, Note: at this stage, job_{lock/unlock} and job lock guard macros are*nop*. Signed-off-by: Emanuele Giuseppe Esposito Review

[PULL 15/20] target/arm: Rename pmu_8_n feature test functions

2022-09-14 Thread Richard Henderson
From: Peter Maydell Our feature test functions that check the PMU version are named isar_feature_{aa32,aa64,any}_pmu_8_{1,4}. This doesn't match the current Arm ARM official feature names, which are FEAT_PMUv3p1 and FEAT_PMUv3p4. Rename these functions to _pmuv3p1 and _pmuv3p4. This commit was

[PATCH v2] e1000e: set RX desc status with DD flag in a separate operation

2022-09-14 Thread Ding Hui
Like commit 034d00d48581 ("e1000: set RX descriptor status in a separate operation"), there is also same issue in e1000e, which would cause lost packets or stop sending packets to VM with DPDK. Do similar fix in e1000e. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/402 Signed-off-by: Di

[PATCH v2 3/4] scripts/ci/setup: spice-server only on x86 aarch64

2022-09-14 Thread Lucas Mateus Castro(alqotel)
From: "Lucas Mateus Castro (alqotel)" Changed build-environment.yml to only install spice-server on x86_64 and aarch64 as this package is only available on those architectures. Signed-off-by: Lucas Mateus Castro (alqotel) --- scripts/ci/setup/build-environment.yml | 12 +++- 1 file cha

[PATCH] target/arm: Do alignment check when translation disabled

2022-09-14 Thread Richard Henderson
If translation is disabled, the default memory type is Device, which requires alignment checking. Document, but defer, the more general case of per-page alignment checking. Reported-by: Idan Horowitz Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1204 Signed-off-by: Richard Henderson -

[PULL 14/20] target/arm: Detect overflow when calculating next PMU interrupt

2022-09-14 Thread Richard Henderson
From: Peter Maydell In pmccntr_op_finish() and pmevcntr_op_finish() we calculate the next point at which we will get an overflow and need to fire the PMU interrupt or set the overflow flag. We do this by calculating the number of nanoseconds to the overflow event and then adding it to qemu_clock

[PULL 19/20] target/arm: Remove useless TARGET_BIG_ENDIAN check in armv7m_load_kernel()

2022-09-14 Thread Richard Henderson
From: Peter Maydell Arm system emulation targets always have TARGET_BIG_ENDIAN clear, so there is no need to have handling in armv7m_load_kernel() for the case when it is defined. Remove the unnecessary code. Side notes: * our M-profile implementation is always little-endian (that is, it ma

[PULL 12/20] target/arm: Ignore PMCR.D when PMCR.LC is set

2022-09-14 Thread Richard Henderson
From: Peter Maydell The architecture requires that if PMCR.LC is set (for a 64-bit cycle counter) then PMCR.D (which enables the clock divider so the counter ticks every 64 cycles rather than every cycle) should be ignored. We were always honouring PMCR.D; fix the bug so we correctly ignore it i

[PULL 18/20] target/arm: Report FEAT_PMUv3p5 for TCG '-cpu max'

2022-09-14 Thread Richard Henderson
From: Peter Maydell Update the ID registers for TCG's '-cpu max' to report a FEAT_PMUv3p5 compliant PMU. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20220822132358.3524971-11-peter.mayd...@linaro.org> Signed-off-by: Richard Henderson --- docs/system/arm/emulation

  1   2   >