Claudio Fontana writes:
> On 9/22/22 16:36, Markus Armbruster wrote:
>> Claudio Fontana writes:
>>
>>> On 9/22/22 15:20, Markus Armbruster wrote:
Claudio Fontana writes:
[...]
> I think it would be better to completely make the return value separate
> from the
On Thu, Sep 22, 2022 at 6:12 PM Tommy Wu wrote:
>
> To the maintainers:
>
> Thank Alistair and Jim for the review.
> Bernhard Beschow sent the same patch :
> https://lists.gnu.org/archive/html/qemu-riscv/2022-09/msg00126.html
>
> It seems that this simple patch is helpful. Could you help us to
On Thu, Aug 18, 2022 at 1:43 AM Yang Liu wrote:
>
> Starting with RVV1.0, the original vf[w]redsum_vs instruction was renamed
> to vf[w]redusum_vs. The distinction between ordered and unordered is also
> more consistent with other instructions, although there is no difference
> in implementation
On Thu, Aug 18, 2022 at 1:57 AM Yang Liu wrote:
>
> Remove duplicate code by wrapping vfwredsum_vs's OP function.
>
> Signed-off-by: Yang Liu
Reviewed-by: Alistair Francis
Alistair
> ---
> target/riscv/vector_helper.c | 56 +++-
> 1 file changed, 10
On Fri, Sep 9, 2022 at 11:48 PM Bin Meng wrote:
>
> This patchset refactors RISC-V Debug support to allow more types of
> triggers to be extended.
>
> The initial support of type 6 trigger, which is similar to type 2
> trigger with additional functionality, is also introduced in this
> patchset.
Marc-André Lureau writes:
> Hi
>
> On Tue, Sep 20, 2022 at 2:47 PM Bin Meng wrote:
>
>> From: Bin Meng
>>
>> Lots of test cases were written to use hardcoded /tmp directory for
>> temporary files. To avoid this, we update them to use g_dir_make_tmp()
>> or g_file_open_tmp() when appropriate.
On Sat, Sep 17, 2022 at 6:12 PM Palmer Dabbelt wrote:
>
> The Ztso extension was recently frozen, this adds it as a CPU property
> and adds various fences throughout the port in order to allow TSO
> targets to function on weaker hosts. We need no fences for AMOs as
> they're already SC, the
On Thu, Sep 1, 2022 at 11:03 AM Wilfred Mallawa
wrote:
>
> From: Wilfred Mallawa
>
> Adds a helper macro that implements the `rw1c`
> behaviour.
>
> Ex:
> uint32_t data = FIELD32_1CLEAR(val, REG, FIELD);
>
> if the specified `FIELD` is set (single/multi bit all fields)
> then the respective
On Fri, Aug 26, 2022 at 1:26 PM Yang Liu wrote:
>
> Tested with https://github.com/ksco/rvv-decoder-tests
>
> Expected checkpatch errors for consistency and brevity reasons:
>
> ERROR: line over 90 characters
> ERROR: trailing statements should be on next line
> ERROR: braces {} are necessary for
From: Alistair Francis
On the OpenTitan hardware the resetvec is fixed at the start of ROM. In
QEMU we don't run the ROM code and instead just jump to the next stage.
This means we need to be a little more flexible about what the resetvec
is.
This patch allows us to set the resetvec from the
On Fri, Sep 9, 2022 at 8:04 AM Tyler Ng wrote:
>
>
>
> On Thu, Sep 8, 2022 at 4:52 AM Alistair Francis wrote:
>>
>> On Fri, Sep 2, 2022 at 3:29 AM Tyler Ng wrote:
>> >
>> > This commit adds most of an implementation of the OpenTitan Always-On
>> > Timer. The documentation for this timer is
From: Alistair Francis
The resetvec for the OpenTitan machine ended up being set to an out of
date value, so let's fix that and bump it to the correct start address
(after the boot ROM)
Fixes: bf8803c64d75 "hw/riscv: opentitan: bump opentitan version"
Signed-off-by: Alistair Francis
From: Bernhard Beschow
SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to
inherit from TYPE_MACHINE. This is an inconsistency which can cause
undefined behavior such as memory corruption.
Change SiFiveEState to inherit from MachineState since it is registered
as a machine.
From: Frank Chang
After RISCVException enum is introduced, riscv_csrrw_debug() returns
RISCV_EXCP_NONE to indicate there's no error. RISC-V vector GDB stub
should check the result against RISCV_EXCP_NONE instead of value 0.
Otherwise, 'E14' packet would be incorrectly reported for vector CSRs
From: Andrew Burgess
The fixed register numbering in the various GDB feature files for
RISC-V only exists because these files were originally copied from the
GDB source tree.
However, the fixed numbering only exists in the GDB source tree so
that GDB, when it connects to a target that doesn't
From: Weiwei Li
- modify check for mcounteren to work in all less-privilege mode
- modify check for scounteren to work only when S mode is enabled
- distinguish the exception type raised by check for scounteren between U
and VU mode
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
From: Andrew Burgess
While testing some changes to GDB's handling for the RISC-V registers
fcsr, fflags, and frm, I spotted that QEMU includes these registers
twice in the target description it sends to GDB, once in the fpu
feature, and once in the csr feature.
Right now things basically work
On Fri, Sep 23, 2022 at 11:55 AM ho...@yusur.tech wrote:
>
> On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote:
>
>
> >On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz
> > wrote:
> >>
> >> If I read your response on the other thread correctly, this change is
> >> intended
> >>
> >> to
From: Alistair Francis
Instead of using our properties to set a config value which then might
be used to set the resetvec (depending on your timing), let's instead
just set the resetvec directly in the env struct.
This allows us to set the reset vec from the command line with:
-global
On Thu, 22 Sep 2022 09:34:41 +0800 Jason Wang wrote:
>On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz
> wrote:
>>
>> If I read your response on the other thread correctly, this change is
>> intended
>>
>> to prioritize the MAC address exposed by DPDK over the one provided by the
>>
>> QEMU
From: Rahul Pathak
sideleg and sedeleg csrs are not part of riscv isa spec
anymore, these csrs were part of N extension which
is removed from the riscv isa specification.
These commits removed all traces of these csrs from
riscv spec (https://github.com/riscv/riscv-isa-manual) -
commit
From: Wilfred Mallawa
Updates the `EVENT_ENABLE` register to offset `0x34` as per
OpenTitan spec [1].
[1] https://docs.opentitan.org/hw/ip/spi_host/doc/#Reg_event_enable
Signed-off-by: Wilfred Mallawa
Reviewed-by: Alistair Francis
Message-Id:
From: Alex Bennée
The example code is rendered slightly mangled due to missing code
block. Properly escape the code block and add shell prompt and qemu to
fit in with the other examples on the page.
Signed-off-by: Alex Bennée
Reviewed-by: Alistair Francis
Message-Id:
From: Wilfred Mallawa
This patch fixes up minor typos in ibex_spi_host
Signed-off-by: Wilfred Mallawa
Reviewed-by: Alistair Francis
Reviewed-by: Andrew Jones
Message-Id: <20220823061201.132342-2-wilfred.mall...@opensource.wdc.com>
Signed-off-by: Alistair Francis
---
hw/ssi/ibex_spi_host.c
On Thu, Sep 22, 2022 at 5:56 PM Bernhard Beschow wrote:
>
> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to
> inherit from TYPE_MACHINE. This is an inconsistency which can cause
> undefined behavior such as memory corruption.
>
> Change SiFiveEState to inherit from
From: Alistair Francis
The following changes since commit 6160d8ff81fb9fba70f5dad88d43ffd0fa44984c:
Merge tag 'edgar/xilinx-next-2022-09-21.for-upstream' of
https://github.com/edgarigl/qemu into staging (2022-09-22 13:24:28 -0400)
are available in the Git repository at:
On 2022/9/22 18:19, Michael S. Tsirkin wrote:
On Thu, Sep 22, 2022 at 11:02:56AM +0100, Alex Bennée wrote:
"Michael S. Tsirkin" writes:
On Wed, Sep 21, 2022 at 07:23:12PM +0100, Alex Bennée wrote:
chenh writes:
From: Hao Chen
When use dpdk-vdpa tests vdpa device. You need to specify
On Fri, Sep 23, 2022 at 11:33 AM 陈浩 wrote:
>
>
> On 2022/9/22 17:56, Michael S. Tsirkin wrote:
> > On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote:
> >> On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz
> >> wrote:
> >>> If I read your response on the other thread correctly, this change
Using memmap table for loongarch virt machine type, this method
comes from arm/riscv architectures.
Signed-off-by: Xiaojuan Yang
---
hw/loongarch/acpi-build.c | 46 ++--
hw/loongarch/fw_cfg.c | 5 +-
hw/loongarch/virt.c | 138 ++--
On 2022/9/22 17:56, Michael S. Tsirkin wrote:
On Thu, Sep 22, 2022 at 09:34:41AM +0800, Jason Wang wrote:
On Thu, Sep 22, 2022 at 1:58 AM Raphael Norwitz
wrote:
If I read your response on the other thread correctly, this change is intended
to prioritize the MAC address exposed by DPDK over
In ipi_send function, it should not to set irq before
writing data to dest cpu iocsr space, as the irq will
trigger after data writing.
Signed-off-by: Xiaojuan Yang
---
hw/intc/loongarch_ipi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c
This series add memmap table and fix extioi, ipi device
emulation for LoongArch virt machine.
Changes for v1:
1. Add memmap table for LoongArch virt machine
2. Fix LoongArch extioi function
3. Fix LoongArch ipi device emulation
Thanks for your reviewing.
Xiaojuan Yang (3):
hw/loongarch: Add
1.When cpu read or write extioi COREISR reg, it should access
the reg belonged to itself, so the index of 's->coreisr' is
current cpu number.
2.Remove the unused extioi system memory region and we only
support the extioi iocsr memory region now.
Signed-off-by: Xiaojuan Yang
---
On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell wrote:
>
> On Thu, 22 Sept 2022 at 00:47, Patrick Venture wrote:
> >
> > The MAC address set from Qemu wasn't being saved into the register space.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Patrick Venture
>
> > @@ -112,6 +115,18 @@ static void
Hi Stefan,
On Wed, Sep 21, 2022 at 8:24 PM Thomas Huth wrote:
>
> On 21/09/2022 14.18, Bin Meng wrote:
> > Hi,
> >
> > On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote:
> >>
> >> At present packaging the required DLLs of QEMU executables is a
> >> manual process, and error prone.
> >>
> >> Improve
On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau
wrote:
>
> Hi
>
> On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote:
>>
>> From: Bin Meng
>>
>> Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces
>> the mkdir() call in the test codes with glib's g_mkdir_with_parents(),
>> but the
On Mon, Sep 19, 2022 at 11:12:46AM +0200, David Hildenbrand wrote:
> > diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> > index 6325d1d0e90f..9d066be3d7e8 100644
> > --- a/include/uapi/linux/magic.h
> > +++ b/include/uapi/linux/magic.h
> > @@ -101,5 +101,6 @@
> > #define
On Thu, Sep 22, 2022 at 07:49:18PM +, Sean Christopherson wrote:
> On Thu, Sep 22, 2022, Wang, Wei W wrote:
> > On Thursday, September 15, 2022 10:29 PM, Chao Peng wrote:
> > > +int inaccessible_get_pfn(struct file *file, pgoff_t offset, pfn_t *pfn,
> > > + int *order)
> >
>
On 9/23/22 7:35 AM, Peter Xu wrote:
Following commit 4802bf910eee9, add the other missing barrier when marking
the PFN as collected. This will also be required just like 4802bf910eee9
on weak ordering architectures like aarch64.
Cc: Marc Zyngier
Cc: Gavin Shan
Cc: Paolo Bonzini
On 2/8/22 11:50, Alex Bennée wrote:
Hangs have been observed in the tests and currently we don't timeout
if a subprocess hangs. Rectify that.
Signed-off-by: Alex Bennée
Reviewed-by: Thomas Huth
---
v3
- expand timeout to 180 at Thomas' suggestion
v4
- fix merge conflict with earlier
On 2/8/22 11:49, Alex Bennée wrote:
Try and explicitly document the various state of feature bits as
related to the vhost_dev structure. Importantly the backend_features
can advertise things like VHOST_USER_F_PROTOCOL_FEATURES which is
never exposed to the driver and is only present in the
On 2/8/22 11:49, Alex Bennée wrote:
These are useful for tracing the lifetime of vhost-user connections.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost.c | 6 ++
hw/virtio/trace-events | 4
2 files changed, 10 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
On 2/8/22 11:49, Alex Bennée wrote:
Signed-off-by: Alex Bennée
Acked-by: Jason Wang
---
hw/virtio/vhost-user.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 2/8/22 11:49, Alex Bennée wrote:
I've noticed asserts firing because we query the status of vdev after
a vhost connection is closed down. Rather than faulting on the NULL
indirect just quietly reply false.
Signed-off-by: Alex Bennée
Message-Id:
On 2/8/22 11:49, Alex Bennée wrote:
There are some extra bits used over a vhost-user connection which are
hidden from the device itself. We need to set them here to ensure we
enable things like the protocol extensions.
Currently net/vhost-user.c has it's own inscrutable way of persisting
this
On 22/9/22 23:35, Peter Xu wrote:
Following commit 4802bf910eee9, add the other missing barrier when marking
the PFN as collected. This will also be required just like 4802bf910eee9
on weak ordering architectures like aarch64.
Cc: Marc Zyngier
Cc: Gavin Shan
Cc: Paolo Bonzini
Signed-off-by:
On 22/9/22 16:58, Alex Bennée wrote:
This removes the final hard coding of kvm_enabled() in gdbstub and
moves the check to an AccelOps.
Signed-off-by: Alex Bennée
Cc: Mads Ynddal
---
accel/kvm/kvm-cpus.h | 1 +
gdbstub/internals.h| 1 +
include/sysemu/accel-ops.h | 1 +
On 22/9/22 16:58, Alex Bennée wrote:
The support of single-stepping is very much dependent on support from
the accelerator we are using. To avoid special casing in gdbstub move
the probing out to an AccelClass function so future accelerators can
put their code there.
Signed-off-by: Alex Bennée
On 22/9/22 17:58, Tyler Ng wrote:
1. Adds fields to hold the value of mtime in timer_upper0 and timer_lower0.
2. Changes the read and write functions to use the mtime fields.
3. Updates the value of mtime in update_mtime() by extrapolating the
time elapsed. This will need to change if/when the
On 22/9/22 17:58, Tyler Ng wrote:
Fixes a bug in which the index of the interrupt priority is off by 1.
For example, using an IRQ number of 3 with a priority of 1 is supposed to set
plic->source_priority[2] = 1, but instead it sets
plic->source_priority[3] = 1. When an interrupt is claimed to
Following commit 4802bf910eee9, add the other missing barrier when marking
the PFN as collected. This will also be required just like 4802bf910eee9
on weak ordering architectures like aarch64.
Cc: Marc Zyngier
Cc: Gavin Shan
Cc: Paolo Bonzini
Signed-off-by: Peter Xu
---
accel/kvm/kvm-all.c
On Thu, Sep 22, 2022 at 02:38:02PM +0200, Paolo Bonzini wrote:
> On Thu, Sep 22, 2022 at 2:21 PM Gerd Hoffmann wrote:
> > No. This will basically inform the guest that host-phys-bits has been
> > enabled (and pass the number of bits). So the firmware can make use of
> > the available address
Hi
On Tue, Sep 20, 2022 at 3:37 PM Bin Meng wrote:
> From: Bin Meng
>
> Now that we have fixed various test case issues as seen when running
> on Windows, let's enable the qtest build on Windows.
>
> Signed-off-by: Bin Meng
> ---
>
> Changes in v2:
> - new patch: "tests/qtest: Enable qtest
Hi
On Tue, Sep 20, 2022 at 3:11 PM Bin Meng wrote:
> From: Bin Meng
>
> Some migration test cases use TLS to communicate, but they fail on
> Windows with the following error messages:
>
> qemu-system-x86_64: TLS handshake failed: Insufficient credentials for
> that request.
>
On Tue, Sep 20, 2022 at 2:56 PM Bin Meng wrote:
> From: Bin Meng
>
> There is no need to do a type cast on ssource->socket as it is
> already declared as a SOCKET.
>
> Suggested-by: Marc-André Lureau
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
---
>
> Changes in v2:
> - new
Hi
On Tue, Sep 20, 2022 at 2:33 PM Bin Meng wrote:
> From: Xuzhou Cheng
>
> The combination of GENERIC_WRITE and FILE_SHARE_READ options does
> not allow the same file to be opened again by CreateFile() from
> another QEMU process with the same options when the previous QEMU
> process still
On Tue, Sep 20, 2022 at 3:04 PM Bin Meng wrote:
> From: Bin Meng
>
> On Windows the QEMU executable is created via CreateProcess() and
> IO redirection does not work, so don't bother adding IO redirection
> to the command line.
>
> Signed-off-by: Bin Meng
> ---
>
> Changes in v2:
> - Change
On Tue, Sep 20, 2022 at 3:28 PM Bin Meng wrote:
> From: Xuzhou Cheng
>
> These tests use the exec migration protocol, which is unsupported
> on Windows as of today. Disable these tests for now.
>
> Signed-off-by: Xuzhou Cheng
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
>
Hi
On Tue, Sep 20, 2022 at 1:50 PM Bin Meng wrote:
> From: Bin Meng
>
> These test cases uses "blkdebug:path/to/config:path/to/image" for
> testing. On Windows, absolute file paths contain the delimiter ':'
> which causes the blkdebug filename parser fail to parse filenames.
>
> Signed-off-by:
Hi
On Tue, Sep 20, 2022 at 1:36 PM Bin Meng wrote:
> From: Bin Meng
>
> At present the libqtest codes were written to depend on several
> POSIX APIs, including fork(), kill() and waitpid(). Unfortunately
> these APIs are not available on Windows.
>
> This commit implements the corresponding
Hi
On Tue, Sep 20, 2022 at 2:32 PM Bin Meng wrote:
> From: Bin Meng
>
> At present the codes uses sigaction() to install signal handler with
> a flag SA_RESETHAND. Such usage can be covered by the signal() API
> that is a simplified interface to the general sigaction() facility.
>
> Update to
On Tue, Sep 20, 2022 at 2:23 PM Bin Meng wrote:
> From: Xuzhou Cheng
>
> Socket communication in the libqtest and libqmp codes uses read()
> and write() which work on any file descriptor on *nix, and sockets
> in *nix are an example of a file descriptor.
>
> However sockets on Windows do not
On Thu, Sep 22, 2022 at 7:13 PM Jim Mattson wrote:
> > Treating 40 as invalid and continue to use the current conservative
> > heuristic, otherwise treat phys-bits as valid might work. Obvious
> > corner case is that it'll not catch broken manual configurations
> >
On Thu, Sep 22, 2022, Wang, Wei W wrote:
> On Thursday, September 15, 2022 10:29 PM, Chao Peng wrote:
> > +int inaccessible_get_pfn(struct file *file, pgoff_t offset, pfn_t *pfn,
> > +int *order)
>
> Better to remove "order" from this interface?
Hard 'no'.
> Some callers
Hi
On Tue, Sep 20, 2022 at 2:47 PM Bin Meng wrote:
> From: Bin Meng
>
> Lots of test cases were written to use hardcoded /tmp directory for
> temporary files. To avoid this, we update them to use g_dir_make_tmp()
> or g_file_open_tmp() when appropriate.
>
> Signed-off-by: Bin Meng
> ---
>
>
On Tue, Sep 20, 2022 at 2:58 PM Bin Meng wrote:
> From: Bin Meng
>
> There is a difference in the mkdir() call for win32 and non-win32
> platforms, and currently is handled in the codes with #ifdefs.
>
> glib provides a portable g_mkdir() API and we can use it to unify
> the codes without
Hi
On Tue, Sep 20, 2022 at 2:17 PM Bin Meng wrote:
> From: Bin Meng
>
> At present get_tmp_filename() has platform specific implementations
> to get the directory to use for temporary files. Switch over to use
> g_get_tmp_dir() which works on all supported platforms.
>
>
As discussed in v1,
Hi
On Tue, Sep 20, 2022 at 12:56 PM Bin Meng wrote:
> From: Bin Meng
>
> Previously request_{bios, pflash} cases were skipped on win32, mainly
> due to create_blob_file() calling mmap() which does not exist on win32.
> This rewirtes create_blob_file() to be portable, so that we can enable
>
On Thu, Sep 22, 2022 at 05:58:25PM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 20, 2022 at 06:37:57PM -0400, Peter Xu wrote:
> > In qemu_file_shutdown(), there's a possible race if with current order of
> > operation. There're two major things to do:
> >
> > (1) Do real shutdown() (e.g.
Hi
On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote:
> From: Bin Meng
>
> Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces
> the mkdir() call in the test codes with glib's g_mkdir_with_parents(),
> but the exact portable replacement for mkdir() should be g_mkdir().
>
> I
On Thu, Sep 22, 2022 at 04:56:21PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > It's not supported since the 1st day, as ram_load_postcopy does not handle
> > RAM_SAVE_FLAG_XBZRLE. Mark it disabled explicitly.
>
> We've already got a check in ram_save_page:
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
This pull request did not show up in the patches tool
(https://github.com/stefanha/patches) that I use. If I miss a pull
request from you in the future, please feel free to ping me after 48
hours.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
From: Yusuke Okada
The "%f" specifier in g_date_time_format() is only available in glib
2.65.2 or later. If combined with older glib, the function returns null
and the timestamp displayed as "(null)".
For backward compatibility, g_date_time_get_microsecond should be used
to retrieve subsecond.
QEMU's avocado and Travis s390x check-tcg CI jobs fail often and I don't
know why. I think it's due to timeouts but maybe there is something
buried in the logs that I missed.
I waste time skimming through logs when merging qemu.git pull requests
and electricity is wasted on tests that don't
Shellcheck warns that in
rm -f */config-devices.mak.d
the glob might expand to something with a '-' in it, which would
then be misinterpreted as an option to rm. Fix this by adding './'.
Signed-off-by: Peter Maydell
Reviewed-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
The following changes since commit 6338c30111d596d955e6bc933a82184a0b910c43:
Merge tag 'm68k-for-7.2-pull-request' of https://github.com/vivier/qemu-m68k
into staging (2022-09-21 13:12:36 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git
Am 22.09.2022 um 17:27 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 22.09.2022 um 14:42 hat Markus Armbruster geschrieben:
>
> [...]
>
> >> If you have callers that need to distinguish between not found, found
> >> but bad, found and good, then return three distinct values.
From: Philippe Mathieu-Daudé
The compiler isn't clever enough to figure 'min_buf_size'
is a constant, so help it by using a definitions instead.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Jason Wang
Reviewed-by: Richard Henderson
Signed-off-by: Peter Maydell
Message-id:
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Reviewed-by: Samuel Thibault
Signed-off-by: Peter Maydell
Message-id:
On 22.09.22 17:55, Thomas Huth wrote:
On 22/09/2022 17.38, David Hildenbrand wrote:
From: "Jason A. Donenfeld"
In order to fully support MSA_EXT_5, we have to support the SHA-512
special instructions. So implement those.
The implementation began as something TweetNacl-like, and then was
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Peter Maydell
Message-id: 20220819153931.3147384-12-peter.mayd...@linaro.org
---
On Thu, Sep 22, 2022 at 03:46:17PM +0200, Igor Mammedov wrote:
> On Wed, 21 Sep 2022 12:12:27 -0400
> Peter Xu wrote:
>
> > It's true that when vcpus<=255 we don't require the length of 32bit APIC
> > IDs. However here since we already have EIM=ON it means the hypervisor
> > will declare the VM
On Thu, Sep 22, 2022 at 7:16 AM Gerd Hoffmann wrote:
>
> On Thu, Sep 22, 2022 at 02:38:02PM +0200, Paolo Bonzini wrote:
> > On Thu, Sep 22, 2022 at 2:21 PM Gerd Hoffmann wrote:
> > > No. This will basically inform the guest that host-phys-bits has been
> > > enabled (and pass the number of
On Thu, Sep 22, 2022 at 5:55 PM Thomas Huth wrote:
>
> On 22/09/2022 17.38, David Hildenbrand wrote:
> > From: "Jason A. Donenfeld"
> >
> > In order to fully support MSA_EXT_5, we have to support the SHA-512
> > special instructions. So implement those.
> >
> > The implementation began as
From: Philippe Mathieu-Daudé
The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in
qio_channel_websock_handshake_send_res_ok() expands to a call
to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't
realize the string is const, so consider combined_key[] being
a variable-length
From: Philippe Mathieu-Daudé
The compiler isn't clever enough to figure 'width' is a constant,
so help it by using a definitions instead.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Peter Maydell
Message-id:
We use the non-POSIX 'local' keyword in just two places in configure;
rewrite to avoid it.
In do_compiler(), just drop the 'local' keyword. The variable
'compiler' is only used elsewhere in the do_compiler_werror()
function, which already uses the variable as a normal non-local one.
In
From: Keqian Zhu
Setup an ARM virtual machine of machine virt and execute qmp
"query-acpi-ospm-status"
causes segmentation fault with following dumpstack:
#1 0xab64235c in qmp_query_acpi_ospm_status
(errp=errp@entry=0xf030) at ../monitor/qmp-cmds.c:312
#2 0xabfc4e20
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: David Gibson
Signed-off-by: Peter Maydell
Reviewed-by: Peter Maydell
Reviewed-by: Daniel Henrique Barboza
Message-id:
From: Richard Henderson
Remove the use of regime_is_secure from get_phys_addr_pmsav7,
using the new parameter instead.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20220822152741.1617527-19-richard.hender...@linaro.org
Reviewed-by: Peter Maydell
Signed-off-by: Peter
On Tue, Sep 20, 2022 at 06:37:57PM -0400, Peter Xu wrote:
> In qemu_file_shutdown(), there's a possible race if with current order of
> operation. There're two major things to do:
>
> (1) Do real shutdown() (e.g. shutdown() syscall on socket)
> (2) Update qemufile's last_error
>
> We must
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length
array on the stack.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Peter Maydell
Message-id: 20220819153931.3147384-11-peter.mayd...@linaro.org
---
ui/curses.c | 2 +-
1
From: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20220822152741.1617527-9-richard.hender...@linaro.org
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/ptw.c | 28 ++--
1 file changed, 14
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length array on
the stack. Replace the snprintf() call by g_strdup_printf().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Peter Maydell
Message-id:
From: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20220822152741.1617527-4-richard.hender...@linaro.org
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/ptw.c | 69 ++--
1 file
On Thu, Sep 22, 2022 at 09:32:54AM +0800, Jason Wang wrote:
> > +if (!kvm_enable_x2apic()) {
> > +error_setg(errp, "eim=on requires support on the KVM side"
> > + "(X2APIC_API, first shipped in v4.7)");
> > +return false;
> > +}
>
From: Philippe Mathieu-Daudé
Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Reviewed-by: Samuel Thibault
Signed-off-by: Peter Maydell
Message-id: 20220819153931.3147384-2-peter.mayd...@linaro.org
---
From: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
Message-id: 20220822152741.1617527-5-richard.hender...@linaro.org
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/ptw.c | 30 ++
1 file changed, 14
From: Philippe Mathieu-Daudé
We know 'x * y' will be at most 'X_MAX * Y_MAX' (which is not
a big value, it is actually 84). Instead of having the compiler
use variable-length array, declare an array able to hold the
maximum 'x * y'.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André
1 - 100 of 325 matches
Mail list logo
