Re: qemu iotest 161 and make check

2022-10-26 Thread Christian Borntraeger
Am 31.03.22 um 10:25 schrieb Christian Borntraeger: Am 31.03.22 um 09:44 schrieb Christian Borntraeger: Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian

Re: [PATCH v3 02/16] hw/i386/amd_iommu: Omit errp for pci_add_capability

2022-10-26 Thread Markus Armbruster
Akihiko Odaki writes: > Omitting errp for pci_add_capability() causes it to abort if > capabilities overlap. This behavior is appropriate heare because all of Typo: here Same for later patches. > the capabilities set in this device are defined in the program and > their overlap should not

[PATCH v1 1/3] update-linux-headers: Version 6.1-rc2

2022-10-26 Thread Mayuresh Chitale
Sync headers with kernel commit 247f34f7b803 Signed-off-by: Mayuresh Chitale --- include/standard-headers/drm/drm_fourcc.h | 34 - include/standard-headers/linux/ethtool.h | 63 +++- include/standard-headers/linux/fuse.h | 6 +- .../linux/input-event-codes.h

[PATCH v1 0/3] target/riscv: Apply KVM policy to ISA extensions

2022-10-26 Thread Mayuresh Chitale
Currently the single and multi letter ISA extensions exposed to the guest vcpu don't confirm to the KVM policies. This patchset updates the kvm headers and applies policies set in KVM to the extensions exposed to the guest. Mayuresh Chitale (3): update-linux-headers: Version 6.1-rc2

[PATCH v1 2/3] target/riscv: Extend isa_ext_data for single letter extensions

2022-10-26 Thread Mayuresh Chitale
Currently the ISA string for a CPU is generated from two different arrays, one for single letter extensions and another for multi letter extensions. Add all the single letter extensions to the isa_ext_data array and use it for generating the ISA string. Also drop 'P' and 'Q' extensions from the

[PATCH v1 3/3] target/riscv: kvm: Support selecting VCPU extensions

2022-10-26 Thread Mayuresh Chitale
Set the state of each ISA extension on the vcpu depending on what is set in the CPU property and what is allowed by KVM for that extension. Signed-off-by: Mayuresh Chitale --- target/riscv/cpu.c | 11 - target/riscv/kvm.c | 88 ++--

Re: [PATCH v4 00/19] Misc ppc/mac machines clean up

2022-10-26 Thread Howard Spoelstra
On Tue, Oct 25, 2022 at 6:49 PM BALATON Zoltan wrote: > Since only one week is left until freeze starts I've included some > more patches in this version that I've intended to submit after the > clean ups but we're running out of time now. The last 3 patches could > be squashed together, I've

Re: [PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-10-26 Thread Jason Wang
在 2022/10/26 17:53, Eugenio Pérez 写道: Now that qemu can handle and emulate it if the vdpa backend does not support it we can offer it always. Signed-off-by: Eugenio Pérez I may miss something but isn't more easier to simply remove the _F_STATUS from vdpa_feature_bits[]? Thanks ---

Re: [PATCH v4] RISC-V: Add Zawrs ISA extension support

2022-10-26 Thread Alistair Francis
On Thu, Oct 6, 2022 at 12:52 AM Christoph Muellner wrote: > > This patch adds support for the Zawrs ISA extension. > Given the current (incomplete) implementation of reservation sets > there seems to be no way to provide a full emulation of the WRS > instruction (wake on reservation set

[PATCH v2 0/4] Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
From: Yicong Yang This series mainly change the policy for building a cluster topology node in PPTT. Previously we'll always build a cluster node in PPTT without asking the user, after this set the cluster node will be built only the the user specify through "-smp clusters=X". One problem is

[PATCH v2 4/4] tests: acpi: aarch64: add *.topology tables

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Add *.topology tables for the aarch64's topology test. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes tests/data/acpi/virt/PPTT.topology | Bin 0 -> 336 bytes 3 files changed,

[PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change. Signed-off-by: Yicong Yang --- tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT index

[PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Add test for aarch64's ACPI topology building for all the supported levels. Signed-off-by: Yicong Yang --- tests/qtest/bios-tables-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/bios-tables-test.c

[PATCH v2 1/4] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platforms. It's unncessary to always build it which cannot

Re: [PATCH v4] RISC-V: Add Zawrs ISA extension support

2022-10-26 Thread Alistair Francis
On Thu, Oct 6, 2022 at 12:52 AM Christoph Muellner wrote: > > This patch adds support for the Zawrs ISA extension. > Given the current (incomplete) implementation of reservation sets > there seems to be no way to provide a full emulation of the WRS > instruction (wake on reservation set

Re: [PATCH 0/4] Only generate cluster node in PPTT when specified

2022-10-26 Thread Yicong Yang via
Hi Michael, On 2022/10/26 22:52, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 09:11:39PM +0800, Yicong Yang wrote: >> From: Yicong Yang >> >> This series mainly change the policy for building a cluster topology node >> in PPTT. Previously we'll always build a cluster node in PPTT without

Re: [PATCH v1 1/3] hw/loongarch: Change FDT base addr to 2 MiB

2022-10-26 Thread maobibo
Xiaojuan, can you modify the tile like "Load FDT table into dram memory space" rather than "change base addr to 2MiB" ? regards bibo,mao 在 2022/10/21 11:54, Xiaojuan Yang 写道: > Change FDT base addr to 2 MiB in lowmem region. Since lowmem > region starts from 0, FDT base address is located at 2

Re: [PATCH 5/7] block/nfs: Fix 32-bit Windows build

2022-10-26 Thread Bin Meng
Hi Kevin, On Sat, Sep 24, 2022 at 9:19 AM Bin Meng wrote: > > Hi, > > On Wed, Sep 21, 2022 at 8:10 PM Meng, Bin wrote: > > > > -Original Message- > > From: Philippe Mathieu-Daudé On Behalf > > Of Philippe Mathieu-Daudé > > Sent: Sunday, September 18, 2022 5:32 AM > > To: Bin Meng ;

RE: [PATCH v6 1/2] Update AVX512 support for xbzrle_encode_buffer

2022-10-26 Thread Xu, Ling1
Hi, All, This is a "ping" email~. It seems that the newest version of our patch has been ignored. So I "ping" this patchset again. All comments and suggestions have been revised and updated in this V6 version patch, and link for the patch is below:

[PATCH 2/6] i386: Remove unused parameter "uint32_t bit" in feature_word_description()

2022-10-26 Thread Wang, Lei
Parameter "uint32_t bit" is not used in function feature_word_description(), so remove it. Signed-off-by: Wang, Lei --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index e98780773c..0083a2a7f7 100644 ---

[PATCH 0/6] Support for new CPU model SapphireRapids

2022-10-26 Thread Wang, Lei
This series aims to add a new CPU model SapphireRapids, and tries to address the problem stated in https://lore.kernel.org/all/20220812055751.14553-1-lei4.w...@intel.com/T/#mcf67dbd1ad37c65d7988c36a2b267be9afd2fb30, so that named CPU model can define its own AMX values, and QEMU won't pass the

[PATCH 4/6] i386: Mask and report unavailable multi-bit feature values

2022-10-26 Thread Wang, Lei
Some feature words, e.g., feature words in AMX-related CPUID leaf 0x1D and 0x1E are not bit-wise but multiple bits represents one value. Handle this situation when the values specified are not the same as which are reported by KVM. The handling includes: - The responsibility of masking bits and

[PATCH 5/6] i386: Initialize AMX CPUID leaves with corresponding env->features[] leaves

2022-10-26 Thread Wang, Lei
The AMX-related CPUID value, i.e., CPUID(0x1D,1):EAX, CPUID(0x1D,1):EBX, CPUID(0x1D,1):ECX and CPUID(0x1E,0):EBX are hard-coded to Sapphire Rapids without considering future platforms. Replace these hard-coded values with env->features[], so QEMU can pass the right value to KVM. Signed-off-by:

[PATCH 3/6] i386: Introduce new struct "MultiBitFeatureInfo" for multi-bit features

2022-10-26 Thread Wang, Lei
Some features use multiple CPUID bits to form a value to be used, e.g., CPUID(0x1E,0):EBX[23:08] is regarded as the tmul_maxn value for AMX. Introduce a new struct "MultiBitFeatureInfo" to hold the information for those features and create a corresponding member in struct FeatureWordInfo, so that

[PATCH 6/6] i386: Add new CPU model SapphireRapids

2022-10-26 Thread Wang, Lei
The new CPU model mostly inherits features from Icelake-Server, while adding new features: - AMX (Advance Matrix eXtensions) - Bus Lock Debug Exception and new instructions: - AVX VNNI (Vector Neural Network Instruction): - VPDPBUS: Multiply and Add Unsigned and Signed Bytes -

[PATCH 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E

2022-10-26 Thread Wang, Lei
CPUID leaf 0x1D and 0x1E enumerate tile and TMUL information for AMX. Introduce FeatureWord FEAT_1D_1_EAX, FEAT_1D_1_EBX, FEAT_1D_1_ECX and FEAT_1E_0_EBX. Thus these features of AMX can be expanded when "-cpu host/max" and can be configured in named CPU model. Signed-off-by: Wang, Lei ---

Re: [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries

2022-10-26 Thread Robert Hoo
On Wed, 2022-10-26 at 10:45 -0400, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2022 at 08:21:55PM +0800, Robert Hoo wrote: > > And empty bios-tables-test-allowed-diff.h. > > > > Diff of ASL form, from qtest testlog.txt: > > > > --- /tmp/asl-RFWZS1.dsl 2022-09-22 18:25:06.191519589 +0800 > >

Re: [RESEND PATCH v2] target/i386: Switch back XFRM value

2022-10-26 Thread Yang, Weijiang
On 10/26/2022 7:57 PM, Zhong, Yang wrote: The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made SGX enclave only supported SSE and x87 feature(xfrm=0x3). Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES

Re: [PATCH v3 14/16] hw/vfio/pci: Omit errp for pci_add_capability

2022-10-26 Thread Alex Williamson
On Thu, 27 Oct 2022 05:15:25 +0900 Akihiko Odaki wrote: > The code generating errors in pci_add_capability has a comment which > says: > > Verify that capabilities don't overlap. Note: device assignment > > depends on this check to verify that the device is not broken. > > Should never trigger

Re: [PATCH v9 7/8] KVM: Handle page fault for private memory

2022-10-26 Thread Isaku Yamahata
On Tue, Oct 25, 2022 at 11:13:43PM +0800, Chao Peng wrote: > A memslot with KVM_MEM_PRIVATE being set can include both fd-based > private memory and hva-based shared memory. Architecture code (like TDX > code) can tell whether the on-going fault is private or not. This patch > adds a

Re: [PATCH v4 0/7] ppc/e500: Add support for two types of flash, cleanup

2022-10-26 Thread Daniel Henrique Barboza
On 10/26/22 16:51, B wrote: Am 26. Oktober 2022 17:18:14 UTC schrieb Daniel Henrique Barboza : Hi, Since this is being sent to qemu-ppc and has to do with e500 I decided to take a look. I acked the e500 related patches, 5 and 7. Patch 6 LGTM as well but I'd rather not ack it it's SD

Re: [PATCH 3/3] hw/isa/piix4: Correct IRQRC[A:D] reset values

2022-10-26 Thread Bernhard Beschow
On Wed, Oct 26, 2022 at 9:46 PM Philippe Mathieu-Daudé wrote: > IRQRC[A:D] registers reset value is 0x80. We were forcing > the MIPS Malta machine routing to be able to boot a Linux > kernel without any bootloader. > We now have these registers initialized in the Malta machine >

Re: [PATCH 1/2] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL

2022-10-26 Thread Gregory Price
On Wed, Oct 26, 2022 at 04:11:29PM -0400, Michael S. Tsirkin wrote: > He does but in the end he sends patches not pull requests. > I don't care really as long as someone will send it up. > Jonathan will submit this, it's not a critical issue so it can wait for the larger feature set.

[PATCH] hw/i386/pc.c: CXL Fixed Memory Window should not reserve e820 in bios

2022-10-26 Thread Gregory Price
Early-boot e820 records will be inserted by the bios/efi/early boot software and be reported to the kernel via insert_resource. Later, when CXL drivers iterate through the regions again, they will insert another resource and make the RESERVED memory area a child. This RESERVED memory area causes

Re: [PATCH 0/4] Shadow VirtQueue event index support

2022-10-26 Thread Michael S. Tsirkin
On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote: > Event idx helps to reduce the number of notifications between the device > and the driver. It allows them to specify an index on the circular > descriptors rings where to issue the notification, instead of a single > binary

Re: [PATCH 0/3] Emulate status feature in vhost-vdpa net

2022-10-26 Thread Michael S. Tsirkin
On Wed, Oct 26, 2022 at 11:53:00AM +0200, Eugenio Pérez wrote: > The net config space is already copied from the device so it can me modified > by qemu. In particular, this is already done to fix cases where the NIC does > not expose the right fields. > > It's trivial to emulate _F_STATE with

Re: [PATCH 0/4 v3] Multi-Region and Volatile Memory support for CXL Type-3 Devices

2022-10-26 Thread Gregory Price
On Wed, Oct 26, 2022 at 04:20:40PM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 25, 2022 at 08:47:33PM -0400, Gregory Price wrote: > > Submitted as an extention to the multi-feature branch maintained > > by Jonathan Cameron at: > > https://gitlab.com/jic23/qemu/-/tree/cxl-2022-10-24 > > > > I

Re: [PATCH 0/4 v3] Multi-Region and Volatile Memory support for CXL Type-3 Devices

2022-10-26 Thread Gregory Price
On Wed, Oct 26, 2022 at 08:13:24PM +, Adam Manzanares wrote: > On Tue, Oct 25, 2022 at 08:47:33PM -0400, Gregory Price wrote: > > Submitted as an extention to the multi-feature branch maintained > > by Jonathan Cameron at: > >

Re: [PATCH 0/7] Guest announce feature emulation using Shadow VirtQueue

2022-10-26 Thread Michael S. Tsirkin
On Thu, Oct 20, 2022 at 12:34:22PM +0200, Eugenio Pérez wrote: > A gratuitous ARP is recommended after a live migration to reduce the amount of > time needed by the network links to be aware of the new location. A hypervisor > may not have the knowledge of the guest network configuration, and this

Re: [PATCH v9 6/8] KVM: Update lpage info when private/shared memory are mixed

2022-10-26 Thread Isaku Yamahata
On Tue, Oct 25, 2022 at 11:13:42PM +0800, Chao Peng wrote: > When private/shared memory are mixed in a large page, the lpage_info may > not be accurate and should be updated with this mixed info. A large page > has mixed pages can't be really mapped as large page since its > private/shared pages

Re: [PATCH v3 1/2] vfio: move the function vfio_get_xlat_addr() to memory.c

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 25, 2022 at 10:55:18AM -0600, Alex Williamson wrote: > On Wed, 26 Oct 2022 00:37:33 +0800 > Cindy Lu wrote: > > diff --git a/softmmu/memory.c b/softmmu/memory.c > > index 7ba2048836..03940c551d 100644 > > --- a/softmmu/memory.c > > +++ b/softmmu/memory.c > ... > > +/* > > +

Re: [PATCH 1/4] hw/i386/pc.c: CXL Fixed Memory Window should not reserve e820 in bios

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 25, 2022 at 08:47:34PM -0400, Gregory Price wrote: > Early-boot e820 records will be inserted by the bios/efi/early boot > software and be reported to the kernel via insert_resource. Later, when > CXL drivers iterate through the regions again, they will insert another > resource and

Re: [PATCH 0/4 v3] Multi-Region and Volatile Memory support for CXL Type-3 Devices

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 25, 2022 at 08:47:33PM -0400, Gregory Price wrote: > Submitted as an extention to the multi-feature branch maintained > by Jonathan Cameron at: > https://gitlab.com/jic23/qemu/-/tree/cxl-2022-10-24 > I am not supposed to merge this patchset yet, right? That branch has a bunch of

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-10-26 Thread Michael S. Tsirkin
On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > During migration the virtio device state can be restored before we > restart the VM. As no devices can be running while the VM is paused it > makes sense to bail out early in that case. > > This returns the order introduced in: > >

[PATCH v3 09/16] pcie: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of a PCIe function which calls pci_add_capability() in turn is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki Acked-by: Jonathan Cameron (for CXL parts) --- docs/pcie_sriov.txt

[PATCH v3 15/16] virtio-pci: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 05/16] eepro100: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH v2 0/2] virtio-net: re-arm/re-schedule when tx_burst stops virtio_net_flush_tx()

2022-10-26 Thread Michael S. Tsirkin
On Fri, Oct 14, 2022 at 03:20:02PM +0200, Laurent Vivier wrote: > When virtio_net_flush_tx() reaches the tx_burst value all the queue is > not flushed and nothing restart the timer or the bottom half function. > > For BH, this is only missing in the virtio_net_tx_complete() function. > For the

[PATCH v3 12/16] pci/slotid: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of slotid_cap_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/slotid_cap.c | 8 ++-- 1 file changed, 2

[PATCH v3 02/16] hw/i386/amd_iommu: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 10/16] pci/shpc: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of shpc_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/pci_bridge_dev.c | 2 +-

RE: [PATCH 1/2] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL

2022-10-26 Thread Gregory Price
I believe this was dropped from my line because Jonathan carried a similar commit on his branch. Happy to push it up again as a separate commit if that is what you want. Noted for the future on upstreams -Original Message- From: Michael S. Tsirkin Sent: Wednesday, October 26, 2022

[PATCH v3 13/16] hw/pci-bridge/pcie_pci_bridge: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 14/16] hw/vfio/pci: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
The code generating errors in pci_add_capability has a comment which says: > Verify that capabilities don't overlap. Note: device assignment > depends on this check to verify that the device is not broken. > Should never trigger for emulated devices, but it's helpful for > debugging these.

[PATCH v3 03/16] ahci: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 06/16] hw/nvme: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

[PATCH v3 11/16] msix: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msix_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msix.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v3 07/16] msi: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of msi_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci/msi.c | 9 + 1 file changed, 1 insertion(+), 8

[PATCH v3 01/16] pci: Allow to omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

[PATCH v3 08/16] hw/pci/pci_bridge: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. A caller of pci_bridge_ssvid_init(), which calls pci_add_capability() in turn, is expected to ensure that will not happen. Signed-off-by: Akihiko Odaki --- hw/pci-bridge/i82801b11.c | 14 ++

[PATCH v3 16/16] pci: Remove legacy errp from pci_add_capability

2022-10-26 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- hw/pci/pci.c | 29 +++-- include/hw/pci/pci.h | 12 ++-- 2 files changed, 9 insertions(+), 32 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8ee2171011..8ff71e4553 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c

[PATCH v3 00/16] pci: Abort if pci_add_capability fails

2022-10-26 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring

[PATCH v3 04/16] e1000e: Omit errp for pci_add_capability

2022-10-26 Thread Akihiko Odaki
Omitting errp for pci_add_capability() causes it to abort if capabilities overlap. This behavior is appropriate heare because all of the capabilities set in this device are defined in the program and their overlap should not happen unless there is a programming error. Signed-off-by: Akihiko Odaki

Re: [PATCH 0/4 v3] Multi-Region and Volatile Memory support for CXL Type-3 Devices

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 25, 2022 at 08:47:33PM -0400, Gregory Price wrote: > Submitted as an extention to the multi-feature branch maintained > by Jonathan Cameron at: > https://gitlab.com/jic23/qemu/-/tree/cxl-2022-10-24 BTW pls set subject prefix for all patches, and put it before the patch #. -v

Re: [PATCH 0/4 v3] Multi-Region and Volatile Memory support for CXL Type-3 Devices

2022-10-26 Thread Adam Manzanares
On Tue, Oct 25, 2022 at 08:47:33PM -0400, Gregory Price wrote: > Submitted as an extention to the multi-feature branch maintained > by Jonathan Cameron at: >

Re: [PATCH 0/4] Replace QERR_PERMISSION_DENIED by better error messages

2022-10-26 Thread Michael S. Tsirkin
On Wed, Oct 12, 2022 at 05:37:57PM +0200, Markus Armbruster wrote: > Markus Armbruster (4): > qom: Improve error messages when property has no getter or setter > backends: Improve error messages when property can no longer be set > qtest: Improve error messages when property can not be set

Re: [PATCH 1/2] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL

2022-10-26 Thread Michael S. Tsirkin
He does but in the end he sends patches not pull requests. I don't care really as long as someone will send it up. On Wed, Oct 26, 2022 at 08:09:45PM +, Gregory Price wrote: > I believe this was dropped from my line because Jonathan carried a similar > commit on his branch. > > Happy to

Re: [PATCH 1/2] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL

2022-10-26 Thread Michael S. Tsirkin
On Thu, Oct 06, 2022 at 07:37:01PM -0400, Gregory Price wrote: > Current code sets to STORAGE_EXPRESS and then overrides it. > > Signed-off-by: Gregory Price If you expect me to merge it you need to CC me. Also, do we need this separately from the series? > --- > hw/mem/cxl_type3.c | 3 +-- >

Re: [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic"

2022-10-26 Thread B
Am 24. Oktober 2022 07:35:48 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Bernhard, > >On 22/10/22 17:04, Bernhard Beschow wrote: >> Having an i8259 proxy allows for ISA PICs to be created and wired up in >> southbridges. This is especially interesting for PIIX3 for two reasons: >> First, the

Re: [PATCH v4 0/7] ppc/e500: Add support for two types of flash, cleanup

2022-10-26 Thread B
Am 26. Oktober 2022 17:18:14 UTC schrieb Daniel Henrique Barboza : >Hi, > >Since this is being sent to qemu-ppc and has to do with e500 I decided to >take a look. I acked the e500 related patches, 5 and 7. Patch 6 LGTM as well >but I'd rather not ack it it's SD specific code. > >I'll send a

[PATCH 3/3] hw/isa/piix4: Correct IRQRC[A:D] reset values

2022-10-26 Thread Philippe Mathieu-Daudé
IRQRC[A:D] registers reset value is 0x80. We were forcing the MIPS Malta machine routing to be able to boot a Linux kernel without any bootloader. We now have these registers initialized in the Malta machine write_bootloader(), so we can use the correct reset values. Signed-off-by: Philippe

[PATCH 1/3] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition

2022-10-26 Thread Philippe Mathieu-Daudé
The PIIX4 PCI-ISA bridge function is always located at 10:0. Since we want to re-use its address, add the PIIX4_PCI_DEVFN definition. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/mips/malta.c

Re: [PATCH 0/3] hw/isa/piix4: Remove MIPS Malta specific bits

2022-10-26 Thread Philippe Mathieu-Daudé
On 26/10/22 21:46, Philippe Mathieu-Daudé wrote: Bernhard posted a series merging both PIIX3/PIIX4 models in one [1]. Due to Malta-specific board code forced into the PIIX4 reset values, Bernhard had to include an array of "register values at reset" as a class property. This is not wrong, but to

[PATCH 0/3] hw/isa/piix4: Remove MIPS Malta specific bits

2022-10-26 Thread Philippe Mathieu-Daudé
Bernhard posted a series merging both PIIX3/PIIX4 models in one [1]. Due to Malta-specific board code forced into the PIIX4 reset values, Bernhard had to include an array of "register values at reset" as a class property. This is not wrong, but to model properly the model, we should simply use the

[PATCH 2/3] hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader

2022-10-26 Thread Philippe Mathieu-Daudé
Linux kernel expects the northbridge & southbridge chipsets configured by the BIOS firmware. We emulate that by writing a tiny bootloader code in write_bootloader(). Upon introduction in commit 5c2b87e34d ("PIIX4 support"), the PIIX4 configuration space included values specific to the Malta

Re: [PULL v3 00/11] Dump patches

2022-10-26 Thread Marc-André Lureau
Hi On Wed, Oct 26, 2022 at 12:55 PM wrote: > From: Marc-André Lureau > > The following changes since commit > e750a7ace492f0b450653d4ad368a77d6f660fb8: > > Merge tag 'pull-9p-20221024' of https://github.com/cschoenebeck/qemu > into staging (2022-10-24 14:27:12 -0400) > > are available in the

Re: [PATCH v11 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-26 Thread Michael S. Tsirkin
On Tue, Oct 11, 2022 at 10:05:22PM +0200, Laurent Vivier wrote: > "-netdev socket" only supports inet sockets. > > It's not a complex task to add support for unix sockets, but > the socket netdev parameters are not defined to manage well unix > socket parameters. Acked-by: Michael S. Tsirkin

Re: [PATCH] tests/qtest/ac97-test: add up-/downsampling tests

2022-10-26 Thread Volker Rümelin
Am 25.10.22 um 09:44 schrieb Marc-André Lureau: Hi On Tue, Oct 25, 2022 at 12:31 AM Volker Rümelin wrote: Am 24.10.22 um 10:13 schrieb Marc-André Lureau: Hi On Mon, Oct 24, 2022 at 9:28 AM Volker Rümelin wrote: Test if the audio subsystem can handle extreme up- and down- sampling

[RFC PATCH v2 5/5] target/ppc: Enable hardfpu for Power

2022-10-26 Thread Víctor Colombo
Change the build conditional from softfloat.c, allowing TARGET_PPC to use hardfpu. For PPC, this is only implemented in linux-user. Signed-off-by: Víctor Colombo --- fpu/softfloat.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c

[RFC PATCH v2 1/5] target/ppc: prepare instructions to work with caching last FP insn

2022-10-26 Thread Víctor Colombo
When enabling hardfpu for Power and adding the instruction caching feature, it will be necessary to uncache when the instruction is garanteed to be executed in softfloat. If the cache is not cleared in this situation, it could lead to a previous instruction being reexecuted and yield a different

[RFC PATCH v2 3/5] target/ppc: Implement instruction caching for muladd

2022-10-26 Thread Víctor Colombo
This patch adds the code necessary to cache muladd instructions for usage with hardfpu in Power. muladd is an instruction that receives four arguments, three f64 and one status, and returns f64. This info will be cached inside the union in env, which grows when other instructions with other

[RFC PATCH v2 4/5] target/ppc: Implement instruction caching for add/sub/mul/div

2022-10-26 Thread Víctor Colombo
This patch adds the code necessary to cache add/sub/mul/div instructions for usage with hardfpu in Power. These instructions receives three arguments, two f64 and one status, and returns f64. This info will be cached inside the union in env, which grows when other instructions with other

[RFC PATCH v2 2/5] target/ppc: Implement instruction caching for fsqrt

2022-10-26 Thread Víctor Colombo
This patch adds the code necessary to cache fsqrt for usage with hardfpu in Power. It is also the first instruction to use the new cache instruction system. fsqrt is an instruction that receives two arguments, one f64 and one status, and returns f64. This info will be cached inside a new union in

[RFC PATCH v2 0/5] Idea for using hardfloat in PPC

2022-10-26 Thread Víctor Colombo
As can be seem in the mailing thread that added hardfloat support in QEMU [1], a requirement for it to work is to have float_flag_inexact set when entering the API in softfloat.c. However, in the same thread, it was explained that PPC target would not work by default with this implementation. The

[PATCH v4 3/3] hw/mips/malta: Use bootloader helper to set BAR registers

2022-10-26 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang Translate embedded assembly into IO writes which is more readable. Signed-off-by: Jiaxun Yang Message-Id: <20210127065424.114125-4-jiaxun.y...@flygoat.com> [PMD: Explode addresses/values to ease review/maintainance] Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c

[RFC PATCH 3/3] ui/gtk: reset visible flag when window is minimized

2022-10-26 Thread Dongwon Kim
Add a callback for window-state-event that resets vc->gfx.visible when associated window is minimized and vice versa. Cc: Gerd Hoffmann Cc: Daniel P. Berrangé Cc: Markus Armbruster Cc: Philippe Mathieu-Daudé Cc: Marc-André Lureau Cc: Thomas Huth Cc: Vivek Kasireddy Signed-off-by: Dongwon

[RFC PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2022-10-26 Thread Dongwon Kim
A new flag "visible" that shows visibility status of the gfx console. The polarity of the flag determines whether the drawing surface should continuously updated upon scanout flush. The flag is set to 'true' as far as it is in visible state but set to 'false' if its tab is inactivated or

[PATCH v4 0/3] MIPS Bootloader helper

2022-10-26 Thread Philippe Mathieu-Daudé
This is a respin of Jiaxun v3 [1] addressing the semihosting review comment [2]. [1] https://lore.kernel.org/qemu-devel/20210127065424.114125-1-jiaxun.y...@flygoat.com/ [2] https://lore.kernel.org/qemu-devel/5a22bbe1-5023-6fc3-a41b-8d72ec2bb...@flygoat.com/ *** BLURB HERE *** Jiaxun Yang (2):

[RFC PATCH 0/3] ui/gtk: no render event when vc is invisible

2022-10-26 Thread Dongwon Kim
This patchset adds a new mechanism in gtk/ui that makes it stop scheduling a render event if VC is invisible and also change the status of guest display to disconnected so that the guest stop further submission of new frames. This prevents the guest (using blob scanout w/ egl fence sync) from

[PATCH v4 1/3] hw/mips/bootloader: Allow bl_gen_jump_kernel to optionally set register

2022-10-26 Thread Philippe Mathieu-Daudé
When one of the $sp/$a[0..3] register is already set, we might want bl_gen_jump_kernel() to NOT set it again. Pass a boolean argument for each register, to allow to optionally set them. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/bootloader.c | 28 +---

[PATCH v4 2/3] hw/mips: Use bl_gen_kernel_jump to generate bootloaders

2022-10-26 Thread Philippe Mathieu-Daudé
From: Jiaxun Yang Replace embedded binary with generated code. Signed-off-by: Jiaxun Yang Message-Id: <20210127065424.114125-3-jiaxun.y...@flygoat.com> [PMD: Pass semihosting_get_argc() to bl_gen_jump_kernel()] Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 43

[RFC PATCH 2/3] ui/gtk: set the ui size to 0 when invisible

2022-10-26 Thread Dongwon Kim
Make guest displays disconnected when not visible. Setting ui size to 0 is used to indicate that the display is disconnected. When the VC is visible again, the ui size is set to associated window's size again which makes the display reconnected and available to the guest. Cc: Gerd Hoffmann Cc:

[PULL 06/13] block: add BDRV_REQ_REGISTERED_BUF request flag

2022-10-26 Thread Stefan Hajnoczi
Block drivers may optimize I/O requests accessing buffers previously registered with bdrv_register_buf(). Checking whether all elements of a request's QEMUIOVector are within previously registered buffers is expensive, so we need a hint from the user to avoid costly checks. Add a

[PULL 13/13] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint

2022-10-26 Thread Stefan Hajnoczi
Register guest RAM using BlockRAMRegistrar and set the BDRV_REQ_REGISTERED_BUF flag so block drivers can optimize memory accesses in I/O requests. This is for vdpa-blk, vhost-user-blk, and other I/O interfaces that rely on DMA mapping/unmapping. Signed-off-by: Stefan Hajnoczi Reviewed-by:

Re: [PULL 00/16] aspeed queue

2022-10-26 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

[PULL 01/13] coroutine: add flag to re-queue at front of CoQueue

2022-10-26 Thread Stefan Hajnoczi
When a coroutine wakes up it may determine that it must re-queue. Normally coroutines are pushed onto the back of the CoQueue, but for fairness it may be necessary to push it onto the front of the CoQueue. Add a flag to specify that the coroutine should be pushed onto the front of the CoQueue. A

[PULL 05/13] block: use BdrvRequestFlags type for supported flag fields

2022-10-26 Thread Stefan Hajnoczi
Use the enum type so GDB displays the enum members instead of printing a numeric constant. Signed-off-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Message-id: 20221013185908.1297568-6-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- include/block/block_int-common.h | 8

[PULL 02/13] blkio: add libblkio block driver

2022-10-26 Thread Stefan Hajnoczi
libblkio (https://gitlab.com/libblkio/libblkio/) is a library for high-performance disk I/O. It currently supports io_uring, virtio-blk-vhost-user, and virtio-blk-vhost-vdpa with additional drivers under development. One of the reasons for developing libblkio is that other applications besides

Re: [PATCH v7 00/13] blkio: add libblkio BlockDriver

2022-10-26 Thread Stefan Hajnoczi
On Thu, Oct 13, 2022 at 02:58:55PM -0400, Stefan Hajnoczi wrote: > v7: > - Add nvme-io_uring and virtio-blk-vhost-user syntax examples to commit > description [Markus] > - Add missing nvme-io_uring QAPI [Markus, Alberto] > - Rename mem-regions-pinned to may-pin-mem-regions [Alberto] > - Fix

[PULL 00/13] Block patches

2022-10-26 Thread Stefan Hajnoczi
The following changes since commit 79fc2fb685f35a5e71e23629760ef4025d6aba31: Merge tag 'trivial-branch-for-7.2-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-10-25 11:37:17 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

  1   2   3   >