Re: [PATCH 0/5] migration: Modified 'migrate' QAPI command for migration

2023-01-01 Thread Het Gala
On 26/12/22 11:03 am, Het Gala wrote: Current QAPI 'migrate' command design (for initiating a migration stream) contains information regarding different migrate transport mechanism (tcp / unix / exec), dest-host IP address, and binding port number in form of a string. Thus the design does seem

Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data

2023-01-01 Thread Borislav Petkov
On Mon, Jan 02, 2023 at 07:01:50AM +0100, Borislav Petkov wrote: > On Sat, Dec 31, 2022 at 07:31:21PM -0800, H. Peter Anvin wrote: > > It would probably be a good idea to add a "maximum physical address for > > initrd/setup_data/cmdline" field to struct kernel_info, though. It appears > > right

Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data

2023-01-01 Thread Borislav Petkov
On Sat, Dec 31, 2022 at 07:31:21PM -0800, H. Peter Anvin wrote: > It would probably be a good idea to add a "maximum physical address for > initrd/setup_data/cmdline" field to struct kernel_info, though. It appears > right now that those fields are being identity-mapped in the decompressor, > and

Re: [PATCH] net: Increase L2TPv3 buffer to fit jumboframes

2023-01-01 Thread Christian Svensson
+qemu-trivial On Fri, Dec 30, 2022, 21:27 Christian Svensson wrote: > Increase the allocated buffer size to fit larger packets. > Given that jumboframes can commonly be up to 9000 bytes the closest > suitable > value seems to be 16 KiB. > > Tested by running qemu towards a Linux L2TPv3 endpoint

Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data

2023-01-01 Thread Borislav Petkov
On Sat, Dec 31, 2022 at 07:21:06PM -0800, H. Peter Anvin wrote: > As far as the decompression itself goes, it should only a problem if we are > using physical KASLR since otherwise the kernel has a guaranteed safe zone > already allocated by the boot loader. However, if physical KASLR is in use,

[PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64

2023-01-01 Thread fanwj
From: fanwenjie On linux user mode, CPUX86State::idt::base and CPUX86State::gdt::base from Different CPUX86State Objects have same value, It is incorrect! Every CPUX86State::idt::base and Every CPUX86State::gdt::base Must points to independent memory space. Resolves:

[PATCH] vmnet: stop recieving events when VM is stopped

2023-01-01 Thread Joelle van Dyne
When the VM is stopped using the HMP command "stop", soon the handler will stop reading from the vmnet interface. This causes a flood of `VMNET_INTERFACE_PACKETS_AVAILABLE` events to arrive and puts the host CPU at 100%. We fix this by removing the event handler from vmnet when the VM is no longer

Re: [PATCH v2 2/3] hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader

2023-01-01 Thread Bernhard Beschow
Am 31. Dezember 2022 13:44:00 UTC schrieb "Philippe Mathieu-Daudé" : >On 31/12/22 10:53, Bernhard Beschow wrote: >> >> >> Am 21. November 2022 15:34:05 UTC schrieb Bernhard Beschow >> : >>> >>> >>> Am 27. Oktober 2022 20:47:19 UTC schrieb "Philippe Mathieu-Daudé" >>> : Linux kernel

[PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-01 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI

[PATCH v5] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-01 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Richard Henderson
On 1/1/23 09:26, Laurent Vivier wrote: Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland ---  

Re: [PATCH 4/4] target/m68k: fix FPSR quotient byte for frem instruction

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : The FPSR quotient byte should be set to the value of the quotient and not the result. Manually calculate the quotient in the frem helper in round to nearest even mode (note this is different from the quotient calculated internally for fmod), and

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file

Re: [PATCH 3/4] target/m68k: fix FPSR quotient byte for fmod instruction

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : The FPSR quotient byte should be set to the value of the quotient and not the result. Switch from using floatx80_mod() to floatx80_modrem() which returns the quotient as a uint64_t which can be used for the quotient byte. Signed-off-by: Mark

Re: [PATCH 1/4] target/m68k: pass quotient directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file

Re: [PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64

2023-01-01 Thread Alex Bennée
fa...@mail.ustc.edu.cn writes: > From 4601a624f40b2c89e7df2dec1adffb4f4308ba2d Mon Sep 17 00:00:00 2001 > From: fanwenjie > Date: Sun, 1 Jan 2023 23:13:34 +0800 > Subject: [PATCH] linux-user: fix bug about incorrect base addresss of idt and > gdt on i386 and x86_64 > > Resolves:

Recall: [PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64

2023-01-01 Thread fanwj
The Patch has some problem, Please RECALL it! -原始邮件- 发件人:fa...@mail.ustc.edu.cn 发送时间:2023-01-01 23:57:06 (星期日) 收件人: qemu-devel@nongnu.org 抄送: qemu-devel@nongnu.org 主题: [PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64 From

[PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64

2023-01-01 Thread fanwj
From 4601a624f40b2c89e7df2dec1adffb4f4308ba2d Mon Sep 17 00:00:00 2001 From: fanwenjie Date: Sun, 1 Jan 2023 23:13:34 +0800 Subject: [PATCH] linux-user: fix bug about incorrect base addresss of idt and gdt on i386 and x86_64 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1405

[PATCH 3/4] target/m68k: fix FPSR quotient byte for fmod instruction

2023-01-01 Thread Mark Cave-Ayland
The FPSR quotient byte should be set to the value of the quotient and not the result. Switch from using floatx80_mod() to floatx80_modrem() which returns the quotient as a uint64_t which can be used for the quotient byte. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 9

[PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Mark Cave-Ayland
This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH 4/4] target/m68k: fix FPSR quotient byte for frem instruction

2023-01-01 Thread Mark Cave-Ayland
The FPSR quotient byte should be set to the value of the quotient and not the result. Manually calculate the quotient in the frem helper in round to nearest even mode (note this is different from the quotient calculated internally for fmod), and use it to set the quotient byte accordingly.

[PATCH 0/4] target/m68k: fix FPSR quotient byte for fmod and frem

2023-01-01 Thread Mark Cave-Ayland
This series is taken from my MacOS branch and fixes setting the FPSR quotient byte for the fmod and frem instructions which was causing the MacOS _Pack5 SANE trancendentals implementation to return incorrect values for sin() and cos(). The first 2 patches update make_quotient() to take separate

[PATCH 1/4] target/m68k: pass quotient directly into make_quotient()

2023-01-01 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index fdc4937e29..0932c464fd 100644 --- a/target/m68k/fpu_helper.c +++

[PATCH] linux-user: add more netlink protocol constants

2023-01-01 Thread Letu Ren
Currently, qemu strace only prints four protocol contants. This patch adds others listed in "linux/netlink.h". Signed-off-by: Letu Ren --- I found this issue when running networkmanager using qemu-user. `socket(PF_NETLINK,SOCK_RAW,16) = -1 errno=93 (Protocol not supported)` I don't know whether

Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data

2023-01-01 Thread Mika Penttilä
On 1.1.2023 6.33, H. Peter Anvin wrote: On 12/31/22 10:22, Jason A. Donenfeld wrote: On Sat, Dec 31, 2022 at 03:24:32PM +0100, Borislav Petkov wrote: On Sat, Dec 31, 2022 at 02:51:28PM +0100, Jason A. Donenfeld wrote: That failure is unrelated to the ident mapping issue Peter and I

Re: [PATCH v3] xio3130_upstream: Add ACS (Access Control Services) capability

2023-01-01 Thread Paul Schlacter
The upstream and downstream of the physical machine also have acs capability. The virtual machine should at least have a way to see the acs On Sun, Jan 1, 2023 at 5:03 PM Paul Schlacter wrote: > > Please help review and merge the code into the master. Thank you very much. > > ping > > On Sat,

Re: [PATCH v3] xio3130_upstream: Add ACS (Access Control Services) capability

2023-01-01 Thread Paul Schlacter
Please help review and merge the code into the master. Thank you very much. ping On Sat, Aug 20, 2022 at 7:31 AM Paul Schlacter wrote: > > ping > > On Thu, Aug 18, 2022 at 10:25 PM Paul Schlacter wrote: > > > > If it is a pcie device, check that all devices on the path from > > the device to