Re: [PATCH v2 01/22] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition

2023-10-04 Thread Cédric Le Goater
On 10/5/23 06:50, Philippe Mathieu-Daudé wrote: Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed,

Re: [PATCH 28/52] migration/rdma: Check negative error values the same way everywhere

2023-10-04 Thread Markus Armbruster
Peter Xu writes: > Sorry Zhijian, I missed this email. > > On Wed, Oct 04, 2023 at 06:32:14PM +0200, Juan Quintela wrote: >> > * Avoid non-negative integer error values. > > Perhaps we need to forbid that if doing this. > > I can see Zhijian's point, where "if (ret)" can also capture unexpected

Re: [PATCH v16 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-10-04 Thread Akihiko Odaki
On 2023/10/05 11:43, Gurchetan Singh wrote: This adds initial support for gfxstream and cross-domain. Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious history in Android graphics

Re: [PATCH v2 0/2] elf2dmp: fixes of code analysis warnings

2023-10-04 Thread Akihiko Odaki
On 2023/10/01 8:53, Viktor Prutyanov wrote: This series tries to fix Coverity warnings. v2: fix commit authorship, add CIDs Viktor Prutyanov (2): elf2dmp: limit print length for sign_rsds elf2dmp: check array bounds in pdb_get_file_size contrib/elf2dmp/main.c | 2 +-

Re: Wshadow: Better name for 'optarg'?

2023-10-04 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/10/23 19:35, Thomas Huth wrote: >> On 04/10/2023 19.23, Richard Henderson wrote: >>> On 10/4/23 03:05, Philippe Mathieu-Daudé wrote: Hi, I'm getting a bunch of errors for 'optarg' declared in : >>> >>> I thought things like this is why we were

Re: [PATCH v2] linux-user: Undo incomplete mmap

2023-10-04 Thread Akihiko Odaki
On 2023/10/04 5:42, Richard Henderson wrote: On 9/21/23 00:09, Akihiko Odaki wrote: On 2023/09/03 14:39, Akihiko Odaki wrote: When the host page size is greater than the target page size and MAP_FIXED or MAP_FIXED_NOREPLACE is requested, mmap will be done for three parts: start, middle, and

Re: [PATCH v3 10/16] ui/cocoa: Clean up global variable shadowing

2023-10-04 Thread Akihiko Odaki
On 2023/10/04 21:00, Philippe Mathieu-Daudé wrote: Fix: ui/cocoa.m:346:20: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] QemuCocoaView *cocoaView = userInfo; ^ ui/cocoa.m:342:16: note: previous declaration is here

Re: [PATCH v2 00/53] migration/rdma: Error handling fixes

2023-10-04 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Oh dear, where to start. There's so much wrong, and in pretty obvious >> ways. This code should never have passed review. I'm refraining from >> saying more; see the commit messages instead. >> >> Issues remaining after this series include:

Re: [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem

2023-10-04 Thread Philippe Mathieu-Daudé
On 27/9/23 15:30, Thomas Huth wrote: This subsystem is said to be in a bad shape (see e.g. [1], [2] and [3]), and nobody seems to feel responsible to pick up patches for this and send them via a pull request. For example there is a patch for a CVE-worthy bug posted more than half a year ago [4]

[PATCH v2 10/22] qapi: Correct error message for 'vcpu_dirty_limit' parameter

2023-10-04 Thread Philippe Mathieu-Daudé
QERR_INVALID_PARAMETER_VALUE is defined as: #define QERR_INVALID_PARAMETER_VALUE \ "Parameter '%s' expects %s" The current error is formatted as: "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s" Replace by: "Parameter 'vcpu_dirty_limit' is invalid, it

[PATCH v2 06/22] qapi: Inline and remove QERR_INVALID_PARAMETER definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using: $ sed -i -e "s/QERR_INVALID_PARAMETER,/\"Invalid parameter

[PATCH v2 20/22] qapi: Inline and remove QERR_QGA_COMMAND_FAILED definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch: @match exists@

[PATCH v2 12/22] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant param)

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch: @match@

[PATCH v2 22/22] qapi: Remove 'qapi/qmp/qerror.h' header

2023-10-04 Thread Philippe Mathieu-Daudé
This file is now empty. Avoid new definitions by killing it, paying off a 8 years old debt (with interests). Mechanical change using: $ git grep -l qapi/qmp/qerror.h | while read f; do \ gawk -i inplace '/#include "qapi\/qmp\/qerror.h"/ && !p {p++;next}1' $f; \ done $ git rm

[PATCH v2 11/22] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value)

2023-10-04 Thread Philippe Mathieu-Daudé
vcpu_dirty_limit Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch:

[PATCH v2 17/22] qapi: Inline and remove QERR_MISSING_PARAMETER definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[PATCH v2 16/22] qapi: Inline QERR_MISSING_PARAMETER definition (constant parameter)

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patches: @match@

[PATCH v2 07/22] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant param)

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch: @match@

[PATCH v2 13/22] qapi: Inline and remove QERR_INVALID_PARAMETER_VALUE definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Manually modify the error_report() call in softmmu/tpm.c, then use sed to mechanically transform

[PATCH v2 19/22] qapi: Inline and remove QERR_PROPERTY_VALUE_OUT_OF_RANGE definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[PATCH v2 01/22] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[RFC PATCH v2 21/22] qapi: Inline and remove QERR_UNSUPPORTED definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using: $ sed -i -e 's/QERR_UNSUPPORTED/"this feature or command is

[PATCH v2 08/22] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value)

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch: @match@

[PATCH v2 14/22] qapi: Inline and remove QERR_IO_ERROR definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using: $ sed -i -e 's/QERR_IO_ERROR/"An IO error has occurred"/' \

[PATCH v2 09/22] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Manual changes (escaping the format in qapi/visit.py). Remove the definition in

[PATCH v2 18/22] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Manual change. Remove the definition in include/qapi/qmp/qerror.h. Signed-off-by: Philippe

[PATCH v2 15/22] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[PATCH v2 04/22] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good

2023-10-04 Thread Philippe Mathieu-Daudé
Since v1: - Fixed checkpatch warnings (Juan) - Added R-b tags - New patch for 'vcpu_dirty_limit' Hi, This is kind of a selfish series. I'm really tired to grep and read this comment from 2015 in qapi/qmp/qerror.h: /* * These macros will go away, please don't use * in new

[PATCH v2 05/22] qapi: Inline QERR_INVALID_PARAMETER definition (constant parameter)

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using the following coccinelle semantic patch: @match@

[PATCH v2 03/22] qapi: Inline and remove QERR_DEVICE_IN_USE definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

[PATCH v2 02/22] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition

2023-10-04 Thread Philippe Mathieu-Daudé
Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical transformation using sed, manually removing the definition in

Re: [PULL 0/9] Python patches

2023-10-04 Thread Philippe Mathieu-Daudé
Hi John, On 4/10/23 21:46, John Snow wrote: The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400) are available in the Git repository at:

Re: [PATCH 10/21] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value)

2023-10-04 Thread Philippe Mathieu-Daudé
On 4/10/23 20:15, Juan Quintela wrote: Philippe Mathieu-Daudé wrote: Address the comment added in commit 4629ed1e98 ("qerror: Finally unused, clean up"), from 2015: /* * These macros will go away, please don't use * in new code, and do not add new ones! */ Mechanical

[PULL v2 18/53] vdpa: move vhost_vdpa_set_vring_ready to the caller

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Doing that way allows CVQ to be enabled before the dataplane vqs, restoring the state as MQ or MAC addresses properly in the case of a migration. The patch does it by defining a ->load NetClientInfo callback also for dataplane. Ideally, this should be done by an independent

[PULL v2 35/53] hw/cxl: Push cxl_decoder_count_enc() and cxl_decode_ig() into .c

2023-10-04 Thread Michael S. Tsirkin
From: Jonathan Cameron There is no strong justification for keeping these in the header so push them down into the associated cxl-component-utils.c file. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron Message-Id:

[PULL v2 32/53] hw/acpi/core: Trace enable and status registers of GPE separately

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow The bit positions of both registers are related. Tracing the registers independently results in the same offsets across these registers which eases debugging. Signed-off-by: Bernhard Beschow Acked-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 52/53] vhost-user: add shared_object msg

2023-10-04 Thread Michael S. Tsirkin
From: Albert Esteve Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add or remove themselves as virtio exporters, or lookup for virtio dma-buf shared

[PULL v2 49/53] virtio: remove unused next argument from virtqueue_split_read_next_desc()

2023-10-04 Thread Michael S. Tsirkin
From: Ilya Maximets The 'next' was converted from a local variable to an output parameter in commit: 412e0e81b174 ("virtio: handle virtqueue_read_next_desc() errors") But all the actual uses of the 'i/next' as an output were removed a few months prior in commit: aa570d6fb6bd ("virtio:

[PULL v2 27/53] hw/acpi/acpi_dev_interface: Remove now unused madt_cpu virtual method

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow This virtual method was always set to the x86-specific pc_madt_cpu_entry(), even in piix4 which is also used in MIPS. The previous changes use pc_madt_cpu_entry() otherwise, so madt_cpu can be dropped. Since pc_madt_cpu_entry() is now only used in x86-specific code, the

[PULL v2 40/53] vdpa net: fix error message setting virtio status

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez It incorrectly prints "error setting features", probably because a copy paste miss. Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa") Reported-by: Peter Maydell Signed-off-by: Eugenio Pérez Message-Id:

[PULL v2 51/53] hw/display: introduce virtio-dmabuf

2023-10-04 Thread Michael S. Tsirkin
From: Albert Esteve This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices, associated to a UUID. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functions that reside in the

[PULL v2 44/53] hw/i386/pc: improve physical address space bound check for 32-bit x86 systems

2023-10-04 Thread Michael S. Tsirkin
From: Ani Sinha 32-bit x86 systems do not have a reserved memory for hole64. On those 32-bit systems without PSE36 or PAE CPU features, hotplugging memory devices are not supported by QEMU as QEMU always places hotplugged memory above 4 GiB boundary which is beyond the physical address space of

[PULL v2 24/53] hw/isa/ich9: Add comment on imperfect emulation of PIC vs. I/O APIC routing

2023-10-04 Thread Michael S. Tsirkin
From: David Woodhouse As noted in the comment, the PCI INTx lines are supposed to be routed to *both* the PIC and the I/O APIC. It's just that we don't cope with the concept of an IRQ being asserted to two *different* pins on the two irqchips. So we have this hack of routing to I/O APIC only if

[PULL v2 50/53] util/uuid: add a hash function

2023-10-04 Thread Michael S. Tsirkin
From: Albert Esteve Add hash function to uuid module using the djb2 hash algorithm. Add a couple simple unit tests for the hash function, checking collisions for similar UUIDs. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Albert Esteve Message-Id:

[PULL v2 47/53] virtio: use shadow_avail_idx while checking number of heads

2023-10-04 Thread Michael S. Tsirkin
From: Ilya Maximets We do not need the most up to date number of heads, we only want to know if there is at least one. Use shadow variable as long as it is not equal to the last available index checked. This avoids expensive qatomic dereference of the RCU-protected memory region cache as well

[PULL v2 17/53] vdpa: rename vhost_vdpa_net_load to vhost_vdpa_net_cvq_load

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Next patches will add the corresponding data load. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20230822085330.3978829-4-epere...@redhat.com> Tested-by: Lei Yang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-vdpa.c |

[PULL v2 41/53] vdpa net: stop probing if cannot set features

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Otherwise it continues the CVQ isolation probing. Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa") Reported-by: Peter Maydell Signed-off-by: Eugenio Pérez Message-Id: <20230915170836.3078172-3-epere...@redhat.com> Tested-by: Lei Yang

[PULL v2 33/53] vdpa: fix gcc cvq_isolated uninitialized variable warning

2023-10-04 Thread Michael S. Tsirkin
From: Stefan Hajnoczi gcc 13.2.1 emits the following warning: net/vhost-vdpa.c: In function ‘net_vhost_vdpa_init.constprop’: net/vhost-vdpa.c:1394:25: error: ‘cvq_isolated’ may be used uninitialized [-Werror=maybe-uninitialized] 1394 | s->cvq_isolated = cvq_isolated; |

[PULL v2 10/53] virtio-net: do not reset vlan filtering at set_features

2023-10-04 Thread Michael S. Tsirkin
From: Hawkins Jiawei This function is called after virtio_load, so all vlan configuration is lost in migration case. Just allow all the vlan-tagged packets if vlan is not configured, and trust device reset to clear all filtered vlans. Fixes: 0b1eaa8803 ("virtio-net: Do not filter VLANs without

[PULL v2 36/53] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-10-04 Thread Michael S. Tsirkin
From: Jonathan Cameron As an encoded version of these key configuration parameters is available in a register, provide functions to extract it again so as to avoid the need for duplicating the storage. Whilst here update the _enc() function to include additional values as defined in the CXL 3.0

[PULL v2 30/53] hw/i386/acpi-build: Determine SMI command port just once

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow The SMI command port is currently hardcoded by means of the ACPI_PORT_SMI_CMD macro. This hardcoding is Intel specific and doesn't match VIA, for example. There is already the AcpiFadtData::smi_cmd attribute which is used when building the FADT. Let's also use it when

[PULL v2 37/53] hw/cxl: Fix and use same calculation for HDM decoder block size everywhere

2023-10-04 Thread Michael S. Tsirkin
From: Jonathan Cameron In order to avoid having the size of the per HDM decoder register block repeated in lots of places, create the register definitions for HDM decoder 1 and use the offset between the first registers in HDM decoder 0 and HDM decoder 1 to establish the offset. Calculate in

[PULL v2 39/53] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

2023-10-04 Thread Michael S. Tsirkin
From: Jonathan Cameron Will be needed so there is a defined serial number for information queries via the Switch CCI. Signed-off-by: Jonathan Cameron Message-Id: <20230913133615.29876-1-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow Now that TYPE_ACPI_GED_X86 doesn't assign AcpiDeviceIfClass::madt_cpu any more it is the same as TYPE_ACPI_GED. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230908084234.17642-6-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 43/53] amd_iommu: Fix APIC address check

2023-10-04 Thread Michael S. Tsirkin
From: Akihiko Odaki An MSI from I/O APIC may not exactly equal to APIC_DEFAULT_ADDRESS. In fact, Windows 17763.3650 configures I/O APIC to set the dest_mode bit. Cover the range assigned to APIC. Fixes: 577c470f43 ("x86_iommu/amd: Prepare for interrupt remap support") Signed-off-by: Akihiko

[PULL v2 48/53] virtio: remove unnecessary thread fence while reading next descriptor

2023-10-04 Thread Michael S. Tsirkin
From: Ilya Maximets It was supposed to be a compiler barrier and it was a compiler barrier initially called 'wmb' when virtio core support was introduced. Later all the instances of 'wmb' were switched to smp_wmb to fix memory ordering issues on non-x86 platforms. However, this one doesn't need

[PULL v2 12/53] vdpa: Restore vlan filtering state

2023-10-04 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch introduces vhost_vdpa_net_load_single_vlan() and vhost_vdpa_net_load_vlan() to restore the vlan filtering state at device's startup. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei Message-Id: Tested-by: Lei Yang

[PULL v2 22/53] qmp: update virtio feature maps, vhost-user-gpio introspection

2023-10-04 Thread Michael S. Tsirkin
From: Jonah Palmer Add new vhost-user protocol feature to vhost-user protocol feature map and enumeration: - VHOST_USER_PROTOCOL_F_STATUS Add new virtio device features for several virtio devices to their respective feature mappings: virtio-blk: - VIRTIO_BLK_F_SECURE_ERASE virtio-net: -

[PULL v2 26/53] hw/acpi/cpu: Have build_cpus_aml() take a build_madt_cpu_fn callback

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow build_cpus_aml() is architecture independent but needs to create architecture- specific CPU AML. So far this was achieved by using a virtual method from TYPE_ACPI_DEVICE_IF. However, build_cpus_aml() would resolve this interface from global (!) state. This makes it quite

[PULL v2 45/53] pcie_sriov: unregister_vfs(): fix error path

2023-10-04 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy local_err must be NULL before calling object_property_set_bool(), so we must clear it on each iteration. Let's also use more convenient error_reportf_err(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:

[PULL v2 42/53] vdpa net: follow VirtIO initialization properly at cvq isolation probing

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez This patch solves a few issues. The most obvious is that the feature set was done previous to ACKNOWLEDGE | DRIVER status bit set. Current vdpa devices are permissive with this, but it is better to follow the standard. Fixes: 152128d646 ("vdpa: move CVQ isolation check to

[PULL v2 14/53] virtio: don't zero out memory region cache for indirect descriptors

2023-10-04 Thread Michael S. Tsirkin
From: Ilya Maximets Lots of virtio functions that are on a hot path in data transmission are initializing indirect descriptor cache at the point of stack allocation. It's a 112 byte structure that is getting zeroed out on each call adding unnecessary overhead. It's going to be correctly

[PULL v2 34/53] vdpa net: zero vhost_vdpa iova_tree pointer at cleanup

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Not zeroing it causes a SIGSEGV if the live migration is cancelled, at net device restart. This is caused because CVQ tries to reuse the iova_tree that is present in the first vhost_vdpa device at the end of vhost_vdpa_net_cvq_start. As a consequence, it tries to access an

[PULL v2 09/53] hw/virtio: add config support to vhost-user-device

2023-10-04 Thread Michael S. Tsirkin
From: Alex Bennée To use the generic device the user will need to provide the config region size via the command line. We also add a notifier so the guest can be pinged if the remote daemon updates the config. With these changes: -device

[PULL v2 31/53] hw/acpi: Trace GPE access in all device models, not just PIIX4

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230908084234.17642-8-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/core.c | 5 + hw/acpi/piix4.c

[PULL v2 53/53] libvhost-user: handle shared_object msg

2023-10-04 Thread Michael S. Tsirkin
From: Albert Esteve In the libvhost-user library we need to handle VHOST_USER_GET_SHARED_OBJECT requests, and add helper functions to allow sending messages to interact with the virtio shared objects hash table. Signed-off-by: Albert Esteve Message-Id:

[PULL v2 23/53] vhost-user: move VhostUserProtocolFeature definition to header file

2023-10-04 Thread Michael S. Tsirkin
From: Jonah Palmer Move the definition of VhostUserProtocolFeature to include/hw/virtio/vhost-user.h. Remove previous definitions in hw/scsi/vhost-user-scsi.c, hw/virtio/vhost-user.c, and hw/virtio/virtio-qmp.c. Previously there were 3 separate definitions of this over 3 different files. Now

[PULL v2 28/53] hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h"

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow The "hw/boards.h" is unused since the previous commit. Since its removal requires include fixes in various unrelated files to keep the code compiling it has been split in a dedicated commit. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL v2 38/53] hw/cxl: Support 4 HDM decoders at all levels of topology

2023-10-04 Thread Michael S. Tsirkin
From: Jonathan Cameron Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP and CXL Type 3 end points. Signed-off-by: Jonathan Cameron Message-Id: <20230913132523.29780-5-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 25/53] hw/i386/acpi-build: Use pc_madt_cpu_entry() directly

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow This is x86-specific code, so there is no advantage in using pc_madt_cpu_entry() behind an architecture-agnostic interface. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230908084234.17642-2-shen...@gmail.com> Reviewed-by: Michael S.

[PULL v2 46/53] libvhost-user.c: add assertion to vu_message_read_default

2023-10-04 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy Explain Coverity that we are not going to overflow vmsg->fds. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20230925194040.68592-5-vsement...@yandex-team.ru> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 06/53] hw/virtio: Build vhost-vdpa.o once

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé The previous commit removed the dependencies on the target-specific TARGET_PAGE_FOO macros. We can now move vhost-vdpa.c to the 'softmmu_virtio_ss' source set to build it once for all our targets. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[PULL v2 07/53] hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[]

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Similarly to commit de6cd7599b ("meson: Replace softmmu_ss -> system_ss"), rename the virtio source set common to all system emulation as 'system_virtio_ss[]'. This is clearer because softmmu can be used for user emulation. Signed-off-by: Philippe Mathieu-Daudé

[PULL v2 19/53] vdpa: remove net cvq migration blocker

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Now that we have add migration blockers if the device does not support all the needed features, remove the general blocker applied to all net devices with CVQ. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Message-Id: <20230822085330.3978829-6-epere...@redhat.com>

[PULL v2 20/53] vhost: Add count argument to vhost_svq_poll()

2023-10-04 Thread Michael S. Tsirkin
From: Hawkins Jiawei Next patches in this series will no longer perform an immediate poll and check of the device's used buffers for each CVQ state load command. Instead, they will send CVQ state load commands in parallel by polling multiple pending buffers at once. To achieve this, this patch

[PULL v2 15/53] vdpa: use first queue SVQ state for CVQ default

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez Previous to this patch the only way CVQ would be shadowed is if it does support to isolate CVQ group or if all vqs were shadowed from the beginning. The second condition was checked at the beginning, and no more configuration was done. After this series we need to check if

[PULL v2 02/53] hw/virtio: Propagate page_mask to vhost_vdpa_listener_skipped_section()

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé In order to make vhost-vdpa.c a target-agnostic source unit, we need to remove the TARGET_PAGE_SIZE / TARGET_PAGE_MASK / TARGET_PAGE_ALIGN uses. TARGET_PAGE_SIZE will be replaced by the runtime qemu_target_page_size(). The other ones will be deduced from

[PULL v2 05/53] hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask()

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Similarly to commit e414ed2c47 ("virtio-iommu: Use target-agnostic qemu_target_page_mask"), Replace the target-specific TARGET_PAGE_SIZE and TARGET_PAGE_MASK definitions by a call to the runtime qemu_target_page_size() helper which is target agnostic. Signed-off-by:

[PULL v2 01/53] pci: SLT must be RO

2023-10-04 Thread Michael S. Tsirkin
current code sets PCI_SEC_LATENCY_TIMER to RW, but for pcie to pcie bridges it must be RO 0 according to pci express spec which says: This register does not apply to PCI Express. It must be read-only and hardwired to 00h. For PCI Express to PCI/PCI-X Bridges, refer to the

[PULL v2 21/53] qmp: remove virtio_list, search QOM tree instead

2023-10-04 Thread Michael S. Tsirkin
From: Jonah Palmer The virtio_list duplicates information about virtio devices that already exist in the QOM composition tree. Instead of creating this list of realized virtio devices, search the QOM composition tree instead. This patch modifies the QMP command qmp_x_query_virtio to instead

[PULL v2 00/53] virtio,pci: features, cleanups

2023-10-04 Thread Michael S. Tsirkin
changes from v1: dropped a bunch of patches with issues minor commit log rewrites The following changes since commit 494a6a2cf7f775d2c20fd6df9601e30606cc2014: Merge tag 'pull-request-2023-09-25' of https://gitlab.com/thuth/qemu into staging (2023-09-25 10:10:30 -0400) are available

[PULL v2 13/53] vdpa: Allow VIRTIO_NET_F_CTRL_VLAN in SVQ

2023-10-04 Thread Michael S. Tsirkin
From: Hawkins Jiawei Enable SVQ with VIRTIO_NET_F_CTRL_VLAN feature. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei Message-Id: <38dc63102a42c31c72fd293d0e6e2828fd54c86e.1690106284.git.yin31...@gmail.com> Tested-by: Lei Yang Reviewed-by: Michael

[PULL v2 16/53] vdpa: export vhost_vdpa_set_vring_ready

2023-10-04 Thread Michael S. Tsirkin
From: Eugenio Pérez The vhost-vdpa net backend needs to enable vrings in a different order than default, so export it. No functional change intended except for tracing, that now includes the (virtio) index being enabled and the return value of the ioctl. Still ignoring return value of this

[PULL v2 04/53] hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Use TARGET_PAGE_SIZE to calculate TARGET_PAGE_ALIGN (see the rationale in previous commits). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230710094931.84402-4-phi...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by:

[PULL v2 11/53] virtio-net: Expose MAX_VLAN

2023-10-04 Thread Michael S. Tsirkin
From: Hawkins Jiawei vhost-vdpa shadowed CVQ needs to know the maximum number of vlans supported by the virtio-net device, so QEMU can restore the VLAN state in a migration. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei Message-Id: Tested-by: Lei

[PULL v2 03/53] hw/virtio: Propagate page_mask to vhost_vdpa_section_end()

2023-10-04 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Propagate TARGET_PAGE_MASK (see the previous commit for rationale). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230710094931.84402-3-phi...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 08/53] virtio: add vhost-user-base and a generic vhost-user-device

2023-10-04 Thread Michael S. Tsirkin
From: Alex Bennée In theory we shouldn't need to repeat so much boilerplate to support vhost-user backends. This provides a generic vhost-user-base QOM object and a derived vhost-user-device for which the user needs to provide the few bits of information that aren't currently provided by the

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-04 Thread Michael S. Tsirkin
On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: > Add a simple _DSM call support for the ACPI0017 device to return a fake QTG > ID value of 0 in all cases. The enabling is for _DSM plumbing testing > from the OS. the enabling -> this > > Following edited for readbility only

[PATCH v16 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options

2023-10-04 Thread Gurchetan Singh
This modifies the common virtio-gpu.h file have the fields and defintions needed by gfxstream/rutabaga, by VirtioGpuRutabaga. Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki Reviewed-by: Emmanouil Pitsidianakis Reviewed-by:

[PATCH v16 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-10-04 Thread Gurchetan Singh
This adds initial support for gfxstream and cross-domain. Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious history in Android graphics paravirtualization. It has been powering graphics in the

[PATCH v16 2/9] virtio-gpu: CONTEXT_INIT feature

2023-10-04 Thread Gurchetan Singh
From: Antonio Caggiano The feature can be enabled when a backend wants it. Signed-off-by: Antonio Caggiano Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Tested-by: Huang Rui Acked-by: Huang Rui Reviewed-by: Marc-André Lureau Reviewed-by: Philippe

[PATCH v16 1/9] virtio: Add shared memory capability

2023-10-04 Thread Gurchetan Singh
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David

[PATCH v16 7/9] gfxstream + rutabaga: meson support

2023-10-04 Thread Gurchetan Singh
- Add meson detection of rutabaga_gfx - Build virtio-gpu-rutabaga.c + associated vga/pci files when present Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki Reviewed-by: Emmanouil Pitsidianakis Reviewed-by: Antonio Caggiano

[PATCH v16 4/9] virtio-gpu: blob prep

2023-10-04 Thread Gurchetan Singh
From: Antonio Caggiano This adds preparatory functions needed to: - decode blob cmds - tracking iovecs Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki

[PATCH v16 0/9] rutabaga_gfx + gfxstream

2023-10-04 Thread Gurchetan Singh
From: Gurchetan Singh Branch containing changes: https://gitlab.com/gurchetansingh/qemu/-/commits/qemu-gfxstream-v16 Changes since v15: - Incorporated review feedback from here: https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg00800.html Antonio Caggiano (2): virtio-gpu:

[PATCH v16 9/9] docs/system: add basic virtio-gpu documentation

2023-10-04 Thread Gurchetan Singh
This adds basic documentation for virtio-gpu. Suggested-by: Akihiko Odaki Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki Reviewed-by: Emmanouil Pitsidianakis Reviewed-by: Antonio Caggiano Reviewed-by: Akihiko Odaki ---

[PATCH v16 8/9] gfxstream + rutabaga: enable rutabaga

2023-10-04 Thread Gurchetan Singh
This change enables rutabaga to receive virtio-gpu-3d hypercalls when it is active. Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki Reviewed-by: Antonio Caggiano Reviewed-by: Emmanouil Pitsidianakis Reviewed-by: Akihiko Odaki

[PATCH v16 3/9] virtio-gpu: hostmem

2023-10-04 Thread Gurchetan Singh
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Tested-by: Huang Rui Acked-by: Huang Rui Acked-by: Michael S. Tsirkin Reviewed-by: Akihiko Odaki --- hw/display/virtio-gpu-pci.c

Re: [PATCH v4 0/5] Risc-V/gdb: replace exit calls with proper shutdown

2023-10-04 Thread Alistair Francis
On Tue, Oct 3, 2023 at 5:14 PM Clément Chigot wrote: > > This series replaces some of the call to exit in hardware used by > Risc-V boards. Otherwise, the gdb connection can be abruptly > disconnected resulting in the last gdb packet "Wxx" being not sent. > > For the gdbstub modification,

  1   2   3   4   5   6   7   >