[RFC] Reducing NEED_CPU_H usage

2022-12-28 Thread Alessandro Di Federico via
Hello everyone, this is a proposal in the libtcg direction, i.e., enabling building a single QEMU executable featuring multiple *targets* (i.e., TCG frontends). This follows what we discussed in recent KVM calls and originally at the KVM Forum Emulation BoF. Note that our commitment to this

Re: [PATCH] target/hexagon/idef-parser: fix two typos in README

2022-12-28 Thread Alessandro Di Federico via
On Tue, 27 Dec 2022 17:49:04 -0300 Matheus Tavares Bernardino wrote: > Signed-off-by: Matheus Tavares Bernardino > --- > target/hexagon/idef-parser/README.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Alessandro Di Federico Thanks for the fixes! --

Re: [PULL 17/21] target/hexagon: prepare input for the idef-parser

2022-12-31 Thread Alessandro Di Federico via
On Thu, 29 Dec 2022 11:41:22 +0100 Thomas Huth wrote: > I'm now seeing changes to scripts/meson-buildoptions.sh after > rebuilding QEMU ... looks like you likely forgot to update that file > with the automatic update after changing meson_options.txt ? Ah, there seems to be another couple of

Re: [PATCH 1/1] target/hexagon: work around unused variable in yyparser

2022-12-31 Thread Alessandro Di Federico via
On Sat, 31 Dec 2022 17:19:35 +0800 Zongyuan Li wrote: > Variable 'yynerrs' is recognized as unused variable in clang15, This issue is already handled by another similar patch (target/hexagon: suppress unused variable warning) that will soon end up in a pull request. Thanks for looking into

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Tue, 20 Dec 2022 08:30:02 +0100 Philippe Mathieu-Daudé wrote: > Do we really need this level? IIUC the problem with -Wextra is using a > newer compiler toolchain it can include warnings we haven't fixed. > Maybe worthwhile but it can break from times to times. I think we just wanted to be

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Mon, 19 Dec 2022 18:54:22 + Taylor Simpson wrote: > > Applied, thanks. > > Thanks!! Thanks from our side too! :) We started this project back in 2015, I'm really happy we finally got it in! -- Alessandro Di Federico rev.ng Labs

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 09:37:51 -0500 Stefan Hajnoczi wrote: > I don't understand the issue. Can you describe the steps that cause > meson-buildoptions.sh to become out-of-sync with meson_options.txt? > > This will continue to be a problem in the future. Is there a way to > fix it permanently? In

Re: [RFC PATCH] docs: add some details about compilation units to coding style

2023-01-03 Thread Alessandro Di Federico via
Makes sense to me. Reviewed-by: Alessandro Di Federico On Tue, 3 Jan 2023 10:47:58 + Alex Bennée wrote: > +"Templates" and generated code > +== > + > +We make heavy use of C's macro facilities combined with multiple > +inclusion to generate code. This tends to

Re: [RFC] Reducing NEED_CPU_H usage

2023-01-12 Thread Alessandro Di Federico via
On Tue, 10 Jan 2023 11:56:50 -0800 Richard Henderson wrote: > However, at some point we do want to keep some target addresses in > the proper size. For instance within the softmmu tlb, where > CPUTLBEntry is either 16 or 32 bytes, depending. So that would be an optimization if `HOST_LONG_BITS

Re: [PATCH] Update scripts/meson-buildoptions.sh

2023-01-03 Thread Alessandro Di Federico via
On Tue, 3 Jan 2023 10:51:36 -0500 Stefan Hajnoczi wrote: > QEMU's Makefile used to a use a technique where it generated > "timestamp" files and used cmp(1) to check if rebuilding was > necessary: > 1. Always generate meson-buildoptions.sh-timestamp. `meson-buildoptions.sh-timestamp` would be

[PATCH] Update scripts/meson-buildoptions.sh

2023-01-02 Thread Alessandro Di Federico via
Note: `Makefile` relies on modification dates in the source tree to detect changes to `meson_options.txt`. However, git does not track those. Therefore, the following was necessary to regenerate `meson-buildoptions.sh`: touch meson_options.txt cd "$BUILD_DIR" make update-buildoptions

[PATCH] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
This patch manually suppresses a warning for an unused variable (yynerrs) emitted by bison. This warning has been triggered for the first time by clang 15. This patch also disables `-Wextra`, which is not usually adopted in QEMU. However, clang 15 triggers the warning fixed in this patch even in

[PATCH v2] target/hexagon: suppress unused variable warning

2022-12-21 Thread Alessandro Di Federico via
This patch manually suppresses a warning for an unused variable (yynerrs) emitted by bison. This warning has been triggered for the first time by clang 15. This patch also disables `-Wextra`, which is not usually adopted in QEMU. However, clang 15 triggers the warning fixed in this patch even in

Re: [PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alessandro Di Federico via
On Wed, 15 Mar 2023 17:43:29 + Alex Bennée wrote: > +rev.ng revng Can we have "rev.ng Labs"? I suggested this in my previous e-mail too, but maybe it slipped away. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH v2 08/10] contrib/gitdm: add revng to domain map

2023-03-10 Thread Alessandro Di Federico via
On Fri, 10 Mar 2023 18:03:30 + Alex Bennée wrote: > +rev.ng revng Please use "rev.ng Labs". Thanks! Reviewed-by: Alessandro Di Federico -- Alessandro Di Federico rev.ng Labs

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-21 Thread Alessandro Di Federico via
On Mon, 20 Mar 2023 10:10:27 + Alex Bennée wrote: > This doesn't save much as cpu-exec-common still needs to be built > per-target for its knowledge of CPUState but this helps with keeping > things organised. > --- /dev/null > +++ b/accel/tcg/cpu-exec-softmmu.c Could

<    1   2