These are just as easy to handle out of the main config read/write
handlers. Also expand cap_map to config_map so we can use it to
track all of config space.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/device-assignment.c | 22 +++-
hw/pci.c
This not only makes pci_find_capability a directly lookup, but also
allows us to better track added capabilities and avoids the proliferation
of random additional capability offset markers.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/msix.c | 15 +++
hw/pci.c
This interface doesn't make much sense, adding a capability can
take care of everything, just provide a means to register
capability read/write handlers.
Device assignment does it's own thing, so requires a couple
ugly hacks that will be cleaned by subsequent patches.
Signed-off-by: Alex
On Sat, 2010-11-13 at 23:05 +0200, Michael S. Tsirkin wrote:
On Fri, Nov 12, 2010 at 10:47:21AM -0700, Alex Williamson wrote:
This not only makes pci_find_capability a directly lookup, but also
allows us to better track added capabilities and avoids the proliferation
of random additional
On Sat, 2010-11-13 at 23:21 +0200, Michael S. Tsirkin wrote:
Device assignment in qemu-kvm wants to update
config array without any side-efects.
Make it easier to do so.
This isn't exactly true. The change is a side-effect of qemu-kvm
capability support currently being broken wrt wmask.
On Tue, 2010-11-16 at 08:58 -0600, Anthony Liguori wrote:
On 11/01/2010 10:14 AM, Alex Williamson wrote:
Register the actual VM RAM using the new API
Signed-off-by: Alex Williamsonalex.william...@redhat.com
---
hw/pc.c | 12 ++--
1 files changed, 6 insertions(+), 6
---
Alex Williamson (2):
RAM API: Make use of it for x86 PC
Minimal RAM API support
Makefile.objs |1 +
cpu-common.h |2 +
hw/pc.c |9 ++---
memory.c | 97 +
memory.h | 44
Register the actual VM RAM using the new API
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/pc.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 69b13bf..fb7ee21 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -912,14 +912,11
read-only/emulated
access. Patches 1-7 are submitted for commit.
---
Alex Williamson (9):
device-assignment: pass through and stub more PCI caps
device-assignment: Make use of config_map
pci: Remove capability specific handlers
device-assignment: Move PCI capabilities
Make use of wmask, just like the rest of config space.
This duplicates code in pci_default_write_config, but we plan to get
rid of this function anyway, so avoid the code churn.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/pci.c | 19 ---
1 files changed
to assigned_dev_pci_read_* because
we're overlaying the capability at the same location as the initial
copy we made of config space. We can therefore just use pci_get_*.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/device-assignment.c | 65
.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/device-assignment.c | 213 +---
1 files changed, 199 insertions(+), 14 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 832c236..cd62b5a 100644
--- a/hw
On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote:
Alex Williamson alex.william...@redhat.com wrote:
The cpu_register_io_memory() value is unique to the VM instance and
should not be restored after migration/save. Doing so means we
could be pointing at arbitrary device's io regions
, then hot remove the added NIC, the 1st NIC stops
working and the VM segfaults on reboot.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/rtl8139.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index d92981d..9c5fc84 100644
On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote:
How about we keep
On Mon, 2010-12-13 at 02:55 +0530, Juan Quintela wrote:
Alex Williamson alex.william...@redhat.com wrote:
On Sun, 2010-12-12 at 20:07 +0530, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote:
Michael S. Tsirkin m
On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote:
So, unfortunately, I stand by my original patch.
What about the one that put -1 in saved index for a hotplugged device?
There are still examples that don't work even
On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote:
So, unfortunately, I stand by my
On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 20:54 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 11:00:44AM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 19:50 +0200
On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote:
On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote:
pcibus_dev_print() was erroneously retrieving the device bus
number from the secondary bus number offset of the device
instead of the bridge above the device
.
---
Alex Williamson (2):
RAM API: Make use of it for x86 PC
Minimal RAM API support
Makefile.objs |1 +
cpu-common.h |2 +
hw/pc.c |9 ++---
memory.c | 97 +
memory.h | 44
This adds a minimum chunk of Anthony's RAM API support so that we
can identify actual VM RAM versus all the other things that make
use of qemu_ram_alloc.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
Makefile.objs |1 +
cpu-common.h |2 +
memory.c | 97
Register the actual VM RAM using the new API
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/pc.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index e1b2667..1554164 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -913,14 +913,11
Required for regions mapped via qemu_ram_alloc_from_ptr(). VFIO
and ivshmem will make use of this to remove mappings when devices
are hot unplugged.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
No comments on original patch. Obvious missing function. Cam has since
requested
to memory.c as it's based on
your initial implementation. I had to add something since the file
in your branch just copies a header with Frabrice's copywrite.
---
Alex Williamson (2):
RAM API: Make use of it for x86 PC
Minimal RAM API support
Makefile.objs |1 +
cpu-common.h |2
On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote:
On Mon, 2010-11-08 at 13:22 +0200, Michael S. Tsirkin wrote:
On Mon, Oct 04, 2010 at 03:53:11PM -0600, Alex Williamson wrote:
pcibus_dev_print() was erroneously
On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 21:06 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 11:59:16AM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 20:54 +0200
On Tue, 2010-12-14 at 06:57 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 09:49:21PM -0700, Alex Williamson wrote:
On Tue, 2010-12-14 at 06:46 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 01:04:23PM -0700, Alex Williamson wrote:
On Mon, 2010-11-08 at 13:22 +0200
On Mon, Dec 13, 2010 at 10:47 PM, Anjali Kulkarni anj...@juniper.net wrote:
Hi,
Which version of Qemu contains the Smbios code? If I have to get the code in
my repo, is there any place I can get the complete set of patches?
We've had SMBIOS support for a couple years, it should be in any of
On Tue, 2010-12-14 at 11:18 +0200, Avi Kivity wrote:
On 12/13/2010 11:24 PM, Alex Williamson wrote:
Register the actual VM RAM using the new API
@@ -913,14 +913,11 @@ void pc_memory_init(ram_addr_t ram_size,
/* allocate RAM */
ram_addr = qemu_ram_alloc(NULL, pc.ram
On Tue, 2010-12-14 at 14:32 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote:
On Tue, 2010-12-14 at 06:43 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 12:15:08PM -0700, Alex Williamson wrote:
On Mon, 2010-12-13 at 21:06 +0200
On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote:
I've only ever seen config[PCI_SECONDARY_BUS] be non-zero for an
assigned device, so I'm pretty sure we're not going to hurt migration,
but the code is clearly
On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote:
On Tue, Dec 14, 2010 at 11:34:53AM -0700, Alex Williamson wrote:
On Tue, 2010-12-14 at 14:26 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:04:24PM -0700, Alex Williamson wrote:
I've only ever seen config
On Wed, 2010-12-15 at 12:07 +0200, Michael S. Tsirkin wrote:
On Tue, Dec 14, 2010 at 08:41:55AM -0700, Alex Williamson wrote:
On Tue, 2010-12-14 at 14:32 +0200, Michael S. Tsirkin wrote:
On Mon, Dec 13, 2010 at 10:00:48PM -0700, Alex Williamson wrote:
On Tue, 2010-12-14 at 06:43 +0200
On Wed, 2010-12-15 at 17:23 +, Paul Brook wrote:
This adds a minimum chunk of Anthony's RAM API support so that we
can identify actual VM RAM versus all the other things that make
use of qemu_ram_alloc.
Why do we care? How are you defining actual VM RAM?
Surely the whole point of
.
So, I hope Juan is happy because this preserves the migration ABI
for the majority of the use cases, and I hope Michael is happy
because it does so using a subsection. Thanks,
Alex
---
Alex Williamson (2):
rtl8139: Use subsection to restrict migration after hotplug
qdev: Track
. For the majority of migrations, where
no hotplug has occured in the machine, this works correctly. Once
the machine is modified, we can use this interface to detect that
and include a subsection for the device to prevent migrations to
rtl8139 versions with this bug.
Signed-off-by: Alex Williamson
this
fix.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/rtl8139.c | 28 +++-
1 files changed, 27 insertions(+), 1 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index d92981d..4decadb 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -494,6 +494,8
On Sat, 2010-12-18 at 18:31 +0530, Kamalesh Babulal wrote:
Hi,
cb1983b880 build fails with
CCx86_64-softmmu/device-assignment.o
/other/srcs/qemu-kvm/hw/device-assignment.c: In function
'assigned_device_pci_cap_init':
/other/srcs/qemu-kvm/hw/device-assignment.c:1463: error:
to a safe target.
This resolves Juan's concerns about maintaining the migration ABI
and Michael's concerns wrt subsections. Acked by both. Please apply.
Thanks,
Alex
---
Alex Williamson (2):
rtl8139: Use subsection to restrict migration after hotplug
qdev: Track runtime machine
. For the majority of migrations, where
no hotplug has occured in the machine, this works correctly. Once
the machine is modified, we can use this interface to detect that
and include a subsection for the device to prevent migrations to
rtl8139 versions with this bug.
Signed-off-by: Alex Williamson
this
fix.
Signed-off-by: Alex Williamson alex.william...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Juan Quintela quint...@redhat.com
---
hw/rtl8139.c | 28 +++-
1 files changed, 27 insertions(+), 1 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139
scenarios, so we might as
well print this error to stderr so it can at least be found in
the log messages.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
savevm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/savevm.c b/savevm.c
index 90aa237..c6b9b01
On Fri, 2011-01-07 at 09:51 +0100, Jan Kiszka wrote:
Am 07.01.2011 08:18, Alex Williamson wrote:
monitor_print only does anything for foreground commands, so we
don't ever see this error message in the case of a 'migrate -d'.
Your change needlessly steals the error from the monitor console
On Fri, 2011-01-07 at 16:46 +0100, Jan Kiszka wrote:
Am 07.01.2011 16:39, Alex Williamson wrote:
On Fri, 2011-01-07 at 09:51 +0100, Jan Kiszka wrote:
Am 07.01.2011 08:18, Alex Williamson wrote:
monitor_print only does anything for foreground commands, so we
don't ever see this error
If migration is done in the background with the -d option, mon is
NULL and this error message is lost. Instead use error_report().
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
savevm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/savevm.c b
On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
Am 07.01.2011 16:58, Alex Williamson wrote:
If migration is done in the background with the -d option, mon is
NULL and this error message is lost. Instead use error_report().
Signed-off-by: Alex Williamson alex.william...@redhat.com
ever connecting to
the target system. This means the target will remain listening
rather than exit from failure.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
Daniel, adding you to see if libvirt cares about the difference in
whether the target exits on migration failure as noted
On Fri, 2011-01-07 at 17:27 +0100, Jan Kiszka wrote:
Am 07.01.2011 17:10, Alex Williamson wrote:
On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
Am 07.01.2011 16:58, Alex Williamson wrote:
If migration is done in the background with the -d option, mon is
NULL and this error message
ever connecting to
the target system. This means the target will remain listening
rather than exit from failure.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
v4:
- fix braces noted by Jan
- return error from qemu_savevm_state_blocked rather than fixed EINVAL
On Mon, 2011-01-10 at 10:24 +, Daniel P. Berrange wrote:
On Fri, Jan 07, 2011 at 03:13:25PM -0700, Alex Williamson wrote:
The no_migrate save state flag is currently only checked in the
last phase of migration. This means that we potentially waste
a lot of time and bandwidth
ever connecting to
the target system. This means the target will remain listening
rather than exit from failure.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
v5:
- change qemu_savevm_state_blocked() to return bool
- Daniel confirmed libvirt will not have a problem
On Wed, 2011-01-12 at 13:09 +0100, Markus Armbruster wrote:
Alex Williamson alex.william...@redhat.com writes:
Create a trivial interface to track whether the machine has been
modified since boot. Adding or removing devices will trigger this
to return true. An example usage scenario
On Mon, 2011-01-17 at 16:14 +0100, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Fix issue with signed char and isspace() as well as clean up switch
statement using toupper().
V2 of the patch fixes some types in the commit messages and spells
Eric correctly. My
On Mon, 2011-01-17 at 08:24 -0700, Alex Williamson wrote:
On Mon, 2011-01-17 at 16:14 +0100, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Fix issue with signed char and isspace() as well as clean up switch
statement using toupper().
V2 of the patch fixes
On Mon, 2011-01-17 at 18:12 +0100, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Another two cleanups to strtosz() suggested by Alex Williamson.
I had reversed the use of the names of the return arguments to modf(),
and use the STRTOSZ_DESUFFIX_ macros
On Tue, 2011-01-18 at 10:20 +0100, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git
On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote:
On 2011-01-18 16:48, Anthony Liguori wrote:
On 01/18/2011 09:43 AM, Jan Kiszka wrote:
On 2011-01-18 16:04, Anthony Liguori wrote:
On 01/18/2011 08:28 AM, Jan Kiszka wrote:
On 2011-01-12 11:31, Jan Kiszka wrote:
On Tue, 2011-01-18 at 18:08 +0100, Jan Kiszka wrote:
On 2011-01-18 18:02, Alex Williamson wrote:
On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote:
On 2011-01-18 16:48, Anthony Liguori wrote:
On 01/18/2011 09:43 AM, Jan Kiszka wrote:
On 2011-01-18 16:04, Anthony Liguori wrote
On Thu, 2011-01-20 at 17:35 +0200, Michael S. Tsirkin wrote:
When MSI is off, each interrupt needs to be bounced through the io
thread when it's set/cleared, so vhost-net causes more context switches and
higher CPU utilization than userspace virtio which handles networking in
the same thread.
On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote:
On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote:
On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony Liguori wrote:
On 01/20/2011 09:35 AM, Michael S. Tsirkin wrote:
When MSI is off, each interrupt needs to be bounced
On Fri, 2011-01-21 at 11:55 +0200, Michael S. Tsirkin wrote:
On Thu, Jan 20, 2011 at 06:35:46PM -0700, Alex Williamson wrote:
On Thu, 2011-01-20 at 18:23 -0600, Anthony Liguori wrote:
On 01/20/2011 10:07 AM, Michael S. Tsirkin wrote:
On Thu, Jan 20, 2011 at 09:43:57AM -0600, Anthony
devices at the same PCI
address? Thanks,
Alex
Cc: Alex Williamson alex.william...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
savevm.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index fcd8db4..cd29eb8 100644
On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote:
When MSI is off, each interrupt needs to be bounced through the io
thread when it's set/cleared, so vhost-net causes more context switches and
higher CPU utilization than userspace virtio which handles networking in
the same thread.
On Tue, 2011-02-01 at 00:02 +0200, Michael S. Tsirkin wrote:
On Mon, Jan 31, 2011 at 02:47:34PM -0700, Alex Williamson wrote:
On Mon, 2011-01-31 at 23:19 +0200, Michael S. Tsirkin wrote:
When MSI is off, each interrupt needs to be bounced through the io
thread when it's set/cleared, so
On Tue, 2011-02-01 at 22:13 +0200, Michael S. Tsirkin wrote:
When MSI is off, each interrupt needs to be bounced through the io
thread when it's set/cleared, so vhost-net causes more context switches and
higher CPU utilization than userspace virtio which handles networking in
the same thread.
On Thu, 2011-02-03 at 17:38 +0200, Michael S. Tsirkin wrote:
e1000 supports multi-buffer packets larger than rxbuf_size.
This fixes the following (on linux):
- in guest: ifconfig eth1 mtu 16110
- in host: ifconfig tap0 mtu 16110
ping -s 16082 guest-ip
Red Hat bugzilla:
://bugzilla.redhat.com/show_bug.cgi?id=602205
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Changes from v1:
removed dead code
hw/e1000.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
Acked-by: Alex Williamson alex.william
descriptors with null buf addr
Acked-by: Alex Williamson alex.william...@redhat.com
to on.
Reported-by: Alex Williamson alex.william...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
So, I think there are two things that need to be agreed on:
- Can we commit to support migration from new qemu version to an old one?
We haven't in the past but downstreams do
| 12 ++--
hw/virtio-serial-bus.c | 16
hw/virtio-serial.h |5 +
hw/virtio.h|3 ++-
4 files changed, 21 insertions(+), 15 deletions(-)
Acked-by: Alex Williamson alex.william...@redhat.com
diff --git a/hw/virtio-pci.c b/hw/virtio
descriptors with null buf addr
Acked-by: Alex Williamson alex.william...@redhat.com
to an older machine working.
The property is named 'flow_control' and defaults to on.
Reported-by: Alex Williamson alex.william...@redhat.com
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/pc_piix.c | 16 ++
hw/virtio-pci.c|2 +
hw/virtio-serial-bus.c
.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
CC: Alex Williamson alex.william...@redhat.com
---
kvm-all.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
Acked-by: Alex Williamson alex.william...@redhat.com
diff --git a/kvm-all.c b/kvm-all.c
index 802c6b8..14b6c1e
about link status change
vhost: disable on tap link down
hw/virtio-net.c |3 ++-
net.c | 11 +++
2 files changed, 13 insertions(+), 1 deletions(-)
Thanks
Acked-by: Alex Williamson alex.william...@redhat.com
e1000: clear EOP for multi-buffer descriptors
e1000: verify we have buffers, upfront
hw/e1000.c | 61 +++
1 files changed, 48 insertions(+), 13 deletions(-)
Acked-by: Alex Williamson alex.william...@redhat.com
On Mon, 2010-07-26 at 18:28 -0500, Anthony Liguori wrote:
On 07/26/2010 05:28 PM, Anthony Liguori wrote:
On 07/26/2010 04:28 PM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
- 0.13 update
I'll pre-empt the 0.13 question with an answer. I'm just
On Mon, 2010-08-02 at 12:42 +0300, Avi Kivity wrote:
On 08/02/2010 12:06 PM, Avi Kivity wrote:
I'm hitting some migration issues merging qemu.git into qemu-kvm.git:
1. Crash in mig_cancel test:
(gdb) bt
#0 0x003a91c83dbb in memcpy () from /lib64/libc.so.6
#1
-by: Alex Williamson alex.william...@redhat.com
---
0.13 candidate?
hw/e1000.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 80b78bc..eb323d2 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1129,6 +1129,10 @@ static int pci_e1000_init
().
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
0.13 candidate?
hw/e1000.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 80b78bc..eb323d2 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1129,6 +1129,10
On Tue, 2010-08-03 at 08:17 -0400, Glauber Costa wrote:
On Mon, Aug 02, 2010 at 03:15:17PM -0600, Alex Williamson wrote:
When we hotplug the device,
we don't go through a reset cycle, which means a hot added e1000 is
useless until the VM reboots.
I do guess, however, that this is true
the device in the expected
state for the guest.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
0.13 candidate?
hw/qdev.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index e99c73f..b156272 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
Bump, this really should make 0.13. Thanks,
Alex
On Tue, 2010-07-20 at 08:19 -0600, Alex Williamson wrote:
If we save more than once we need to reset the last block info or else
only the first save has the actual block info and each subsequent save
will only use continue flags, making them
When the vhost log is resized, we want to sync up to
the size of the old log. With that end address in place,
ignore regions that start after then end rather than
hitting assert.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/vhost.c |7 ---
1 files changed, 4
tamura.yoshi...@lab.ntt.co.jp
Acked-by: Alex Williamson alex.william...@redhat.com
---
exec.c | 84 +++
1 files changed, 26 insertions(+), 58 deletions(-)
diff --git a/exec.c b/exec.c
index 4fc96cb..82bfffc 100644
--- a/exec.c
+++ b
If we save more than once we need to reset the last block info or else
only the first save has the actual block info and each subsequent save
will only use continue flags, making them unloadable independently.
Found-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com
Signed-off-by: Alex Williamson
with a hw_error. Windows
guests seem to like to assign I/O devices to the high end of
the address space, so it's pretty easy to hot add an rtl8139
to a Win2k8 guest and trigger the bug. I can't find any reason
to register these handlers, so let's remove the cruft.
Signed-off-by: Alex Williamson
won't be able
to make use of the device unless reset is called somewhere along the
way.
Acked-by: Alex Williamson alex.william...@redhat.com
Add the ability to configure the tx_timer timeout and add a bottom
half tx handler that typically shows a nice perf boost over the
time based approach. See last patch for perf details. Make this
the new default when the iothread is enabled. Thanks,
Alex
---
Alex Williamson (5):
virtio
would take many, many
minutes to process and it allows us to easily return a negative
value value from virtio_net_flush_tx() to indicate a back-off
or error condition.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/s390-virtio-bus.c |4 +++-
hw/s390-virtio-bus.h |2 ++
hw
is the timeout in ns. We
limit the timeout to a uint32_t, because anything over a 4s timeout
probably doens't make any kind of practical sense.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/s390-virtio-bus.c |3 ++-
hw/s390-virtio-bus.h |2 ++
hw/syborg_virtio.c |5
De-couple this from the timer since we might want to use
different backends to send the packet.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/virtio-net.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio
host-guest 2416.03, 76.67 - 5655.92, 55.52 = 234%, 72%
UDP guest-host 12255.82, 6.11 - 7775.87, 31.32 = 63%, 513%
UDP host-guest 587.92, 245.95 - 611.88, 239.92 = 104%, 98%
interations/s 1975.59, 83.21 - 8935.50, 88.18 = 452%, 106%
Signed-off-by: Alex Williamson alex.william...@redhat.com
.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/virtio-net.c | 81 ++-
1 files changed, 68 insertions(+), 13 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 8b652f2..3288c77 100644
--- a/hw/virtio-net.c
+++ b
On Tue, 2010-08-31 at 11:00 -0700, Chris Wright wrote:
* Alex Williamson (alex.william...@redhat.com) wrote:
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 075f72d..9ef29f0 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -36,6 +36,7 @@ typedef struct VirtIONet
On Tue, 2010-08-31 at 23:14 +0300, Michael S. Tsirkin wrote:
On Fri, Aug 27, 2010 at 04:37:36PM -0600, Alex Williamson wrote:
Based on a patch from Mark McLoughlin, this patch introduces a new
bottom half packet transmitter that avoids the latency imposed by
the tx_timer approach. Rather
On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote:
On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote:
On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote:
Add the ability to configure the tx_timer timeout and add a bottom
half tx handler that typically shows a nice
On Tue, 2010-08-31 at 23:25 +0300, Michael S. Tsirkin wrote:
On Fri, Aug 27, 2010 at 04:37:45PM -0600, Alex Williamson wrote:
The bottom half handler shows big improvements over the timer
with few downsides, default to it when the iothread is enabled.
Using the following tests
.
The bottom half handler becomes the new default and we add a new
tx= option to virtio-net-pci. Usage:
-device virtio-net-pci,tx=timer # select timer mitigation vs bh
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/s390-virtio-bus.c |1 +
hw/syborg_virtio.c |1 +
hw
De-couple this from the timer since we might want to use
different backends to send the packet.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
hw/virtio-net.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio
201 - 300 of 4441 matches
Mail list logo
