Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |9 +++--
hw/qxl.h |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index e51851a5..09382f5 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -125,13 +125,18 @@ static void qxl_reset_memslots
on an added QXLInterface::async_complete
and added QXLWorker::*_async additions, in spice server qxl = 3.1
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl-render.c|2 +-
hw/qxl.c | 236
From: Gerd Hoffmann kra...@redhat.com
Inform guest drivers about the new features I/O commands we have
now (async commands, S3 support) if building with newer spice, i.e.
if SPICE_INTERFACE_QXL_MINOR = 1.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl.c | 25
anything on last_release is put on the
release ring
for the client to free.
Cc: Yonit Halperin yhalp...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
On Fri, Jul 15, 2011 at 09:59:21AM +0200, Gerd Hoffmann wrote:
Hi,
+switch (io_port) {
+case QXL_IO_NOTIFY_CMD:
+return QXL_IO_NOTIFY_CMD;
Wasn't the plan to make this an array?
yes. Somehow I sent the wrong patch. No idea how I managed to do that.
cheers,
Gerd
On Fri, Jul 15, 2011 at 10:19:27AM +0200, Gerd Hoffmann wrote:
On 07/14/11 21:13, Alon Levy wrote:
Some of the QXL port i/o commands are waiting for the spice server to
complete certain actions. Add async versions for these commands, so we
don't block the vcpu while the spice server
On Fri, Jul 15, 2011 at 10:12:14AM +0200, Gerd Hoffmann wrote:
case QXL_IO_DESTROY_PRIMARY:
if (val != 0) {
-qxl_guest_bug(d, QXL_IO_DESTROY_PRIMARY: val != 0);
-break;
+qxl_guest_bug(d, QXL_IO_DESTROY_PRIMARY (async=%d): val != 0,
+
On Fri, Jul 15, 2011 at 10:20:08AM +0200, Gerd Hoffmann wrote:
+#if SPICE_INTERFACE_QXL_MINOR= 1
+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V10
+#else
+#define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V06
+#endif
Does that actually build with old spice-protocol? I don't think so
On Fri, Jul 15, 2011 at 10:15:26AM +0200, Gerd Hoffmann wrote:
+#if SPICE_INTERFACE_QXL_MINOR= 1
+case QXL_IO_FLUSH_RELEASE: {
+QXLReleaseRing *ring =d-ram-release_ring;
+if (ring-prod - ring-cons + 1 == ring-num_items) {
+fprintf(stderr,
+
On Fri, Jul 15, 2011 at 10:23:39AM +0200, Gerd Hoffmann wrote:
Hi,
+#if SPICE_INTERFACE_QXL_MINOR= 1
+qemu_mutex_init(qxl-async_lock);
+qxl-current_async = QXL_UNDEFINED_IO;
+#endif
That surely belongs into another patch ...
yes.
+case QXL_REVISION_STABLE_V04: /* spice
From: Gerd Hoffmann kra...@redhat.com
Add wrapper functions for all spice worker calls.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl-render.c|4 +-
hw/qxl.c | 32 +-
ui/spice-display.c | 95 ---
From: Gerd Hoffmann kra...@redhat.com
Move the wrapper functions which are used by qxl only to qxl.c.
Rename them from qemu_spice_* to qxl_spice_*. Also pass in a
qxl state pointer instead of a SimpleSpiceDisplay pointer.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl-render.c|
anything on last_release is put on the
release ring
for the client to free.
Cc: Yonit Halperin yhalp...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 40 +++-
1 files changed, 39 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index e832d00..7d8b312 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -409,6 +409,43 @@ static const char
v5-v6:
really use array in io_port_to_string
undo merged async io support to revision change
remove QXL_REVISION_* defines usage
move qxl_send_event to async_cancel
fix async_cancel label per patchcheck
Alon Levy (5):
qxl: add io_port_to_string
qxl: make qxl_guest_bug take variable
on an added QXLInterface::async_complete
and added QXLWorker::*_async additions, in spice server qxl = 3.1
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl-render.c|2 +-
hw/qxl.c | 240
Since the driver is still in operation even after moving to UNDEFINED, i.e.
by destroying primary in any way.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index d645c87..b946942 100644
From: Gerd Hoffmann kra...@redhat.com
Surface tracking needs proper locking since it is used from vcpu and spice
worker threads, add it. Also reset the surface counter when zapping all
surfaces.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl.c | 13 -
hw/qxl.h |2
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 25 ++---
hw/qxl.h |6 ++
2 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6d21171..dcdd0df 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1572,9 +1572,14 @@ static int
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |9 +++--
hw/qxl.h |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 68ce409..d645c87 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -125,13 +125,18 @@ static void qxl_reset_memslots
From: Gerd Hoffmann kra...@redhat.com
Factor out SimpleSpiceDisplay initialization into
qemu_spice_display_init_common() and call it from
both qxl.c (for vga mode) and spice-display.c
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl.c |7 +--
ui/spice-display.c | 17
From: Gerd Hoffmann kra...@redhat.com
Add qxl_guest_bug() function which is supposed to be called in case
sanity checks of guest requests fail. It raises an error IRQ and
logs a message in case guest debugging is enabled.
Make PANIC_ON() abort instead of exit. That macro should be used
for
From: Gerd Hoffmann kra...@redhat.com
Add qxl_guest_bug() function which is supposed to be called in case
sanity checks of guest requests fail. It raises an error IRQ and
logs a message in case guest debugging is enabled.
Make PANIC_ON() abort instead of exit. That macro should be used
for
From: Gerd Hoffmann kra...@redhat.com
Factor out SimpleSpiceDisplay initialization into
qemu_spice_display_init_common() and call it from
both qxl.c (for vga mode) and spice-display.c
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl.c |7 +--
ui/spice-display.c | 17
From: Gerd Hoffmann kra...@redhat.com
Surface tracking needs proper locking since it is used from vcpu and spice
worker threads, add it. Also reset the surface counter when zapping all
surfaces.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl.c | 13 -
hw/qxl.h |2
From: Gerd Hoffmann kra...@redhat.com
Move the wrapper functions which are used by qxl only to qxl.c.
Rename them from qemu_spice_* to qxl_spice_*. Also pass in a
qxl state pointer instead of a SimpleSpiceDisplay pointer.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qxl-render.c|
on an added QXLInterface::async_complete
and added QXLWorker::*_async additions, in spice server qxl = 3.1
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl-render.c|2 +-
hw/qxl.c | 240
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 25 ++---
hw/qxl.h |6 ++
2 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 07bd1ae..66ebdfa 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1572,9 +1572,14 @@ static int
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |9 +++--
hw/qxl.h |2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 68ce409..d645c87 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -125,13 +125,18 @@ static void qxl_reset_memslots
v7 changes:
use updated spice api (spice_qxl_update_area_async etc.)
Alon Levy (5):
qxl: add io_port_to_string
qxl: make qxl_guest_bug take variable arguments
qxl: only disallow specific io's in vga mode
qxl: async io support using new spice api
qxl: add QXL_IO_FLUSH_{SURFACES,RELEASE
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 40 +++-
1 files changed, 39 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index e832d00..7d8b312 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -409,6 +409,43 @@ static const char
Since the driver is still in operation even after moving to UNDEFINED, i.e.
by destroying primary in any way.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index d645c87..b946942 100644
anything on last_release is put on the
release ring
for the client to free.
Signed-off-by: Yonit Halperin yhalp...@redhat.com
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b
On Wed, Jul 20, 2011 at 12:25:37PM +0200, Gerd Hoffmann wrote:
Make sure at least one port (port=.. or tls-port=...)
is specified. Also apply range checks to the port numbers.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
ACK.
---
ui/spice-core.c | 11 ++-
1 files changed,
On Thu, Jul 21, 2011 at 06:48:33PM +0200, Gerd Hoffmann wrote:
On 07/20/11 11:20, Alon Levy wrote:
v7 changes:
use updated spice api (spice_qxl_update_area_async etc.)
Looks good, finally hashed out all the issues, great job.
Thanks very much.
I'll go queue it up for early 0.16 merge
On Fri, Jul 22, 2011 at 01:30:49PM +0200, Christophe Fergeau wrote:
Ping?
I'll pick it up in my pull request.
On Mon, Jul 04, 2011 at 06:10:43PM +0200, Christophe Fergeau wrote:
vcard_emul_mirror_card and vcard_emul_init use
vcard_emul_alloc_arrays to allocate memory for temporary arrays
since v2:
- added Reviewed-by: Alon Levy al...@redhat.com to the 4 patches
Changes since v1:
- split first patch into 3 patches, v1 2/2 is unchanged
Christophe Fergeau (4):
libcacard: fix soft=... parsing in vcard_emul_options
libcacard: introduce NEXT_TOKEN macro
libcacard
On Fri, Jul 22, 2011 at 11:40:55AM +0200, Hans de Goede wrote:
Define a state callback and make that generate chardev open/close events when
called by the spice-server. Note the code ignores these events for a spicevmc
with a subtypem of vdagent, this subtype specific knowledge is undesirable,
Hi,
Please pull fixes for AFE smart cards, cleanup and missing frees
by Robert Relyea and Christophe Fergeau. Thanks.
The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
SPARC64: implement addtional MMU faults related to nonfaulting load
(2011-07-21 20:02:22 +)
On Fri, Jul 22, 2011 at 06:08:40PM +0300, Alon Levy wrote:
Hi,
Hi Anthony,
Forgot to mention I would like this to be pulled for 0.15.0.
Alon
Please pull fixes for AFE smart cards, cleanup and missing frees
by Robert Relyea and Christophe Fergeau. Thanks.
The following changes since
On Tue, Jul 26, 2011 at 10:02:52AM +0300, Alon Levy wrote:
On Fri, Jul 22, 2011 at 06:08:40PM +0300, Alon Levy wrote:
Hi,
Hi Anthony,
Forgot to mention I would like this to be pulled for 0.15.0.
Alon
Also, I've added a revised patch for libcacard.pc. The original is
http
This is required for building libcacard which doesn't itself require
zlib without bringing in this requirement to the build environment.
Signed-off-by: Alon Levy al...@redhat.com
---
I'd like this to go into 0.15.0 too, it makes building libcacard possible
without zlib-devel being installed
On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote:
Alon Levy al...@redhat.com writes:
Signed-off-by: Alon Levy al...@redhat.com
---
hw/virtio-serial-bus.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw
passes that bit to the
chardev.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/virtio-serial-bus.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index c5eb931..4a6d932 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio
On Wed, Jul 27, 2011 at 03:50:11PM +0530, Amit Shah wrote:
On (Wed) 27 Jul 2011 [10:07:56], Alon Levy wrote:
On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote:
Alon Levy al...@redhat.com writes:
Signed-off-by: Alon Levy al...@redhat.com
---
hw/virtio-serial
On Wed, Jul 27, 2011 at 05:35:28PM +0530, Amit Shah wrote:
On (Wed) 27 Jul 2011 [14:09:45], Alon Levy wrote:
Also, we'll be lying that a guest opened, since a guest was opened
much earlier, before migration. Nothing has changed as far as the
guest is concerned, this is just some host
On Wed, Jul 27, 2011 at 09:16:33AM -0500, Anthony Liguori wrote:
On 07/27/2011 02:07 AM, Alon Levy wrote:
On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote:
Alon Levyal...@redhat.com writes:
Signed-off-by: Alon Levyal...@redhat.com
---
hw/virtio-serial-bus.c |8
On Wed, Jul 27, 2011 at 10:01:57AM -0500, Anthony Liguori wrote:
On 07/27/2011 09:49 AM, Alon Levy wrote:
On Wed, Jul 27, 2011 at 09:16:33AM -0500, Anthony Liguori wrote:
On 07/27/2011 02:07 AM, Alon Levy wrote:
On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote:
Alon Levyal
Signed-off-by: Alon Levy al...@redhat.com
---
libcacard/Makefile |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 15205b5..33c1302 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -56,9 +56,8 @@ install-libcacard
On Thu, Jul 28, 2011 at 03:22:52PM -0300, Luiz Capitulino wrote:
On Thu, 28 Jul 2011 20:04:58 +0200
Jan Kiszka jan.kis...@web.de wrote:
On 2011-07-28 20:00, Luiz Capitulino wrote:
On Thu, 28 Jul 2011 19:52:31 +0200
Jan Kiszka jan.kis...@web.de wrote:
On 2011-07-28 19:48, Luiz
This reverts commit 22795174a37e02200944c0d093d518e832650686.
Without this patch the windows logo animation during boot time was
correct, with it it jumps backwards and forwards erratically.
---
ui/spice-display.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git
On Mon, Aug 01, 2011 at 09:23:10AM -0500, Anthony Liguori wrote:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Title should be fe_open, not guest_open.
---
qemu-char.c | 10 ++
qemu-char.h |2 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git
On Mon, Aug 01, 2011 at 09:22:58AM -0500, Anthony Liguori wrote:
The char layer has been growing some nasty warts for some time now as we ask
it
to do things it was never intended on doing. It's been long over due for an
overhaul and its become evident to me that we need to address this
-07-31 06:40:13 +0200)
are available in the git repository at:
git://anongit.freedesktop.org/~alon/qemu pull-libcacard.data
Alon Levy (1):
libcacard: use INSTALL_DATA for data
libcacard/Makefile |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
)+3 | 3, 3 | 3, 3
Signed-off-by: Alon Levy al...@redhat.com
---
monitor.c | 27 ---
1 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1b8ba2c..45e2d6c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3889,7 +3889,7
On Wed, Aug 03, 2011 at 02:57:27PM +0300, Alon Levy wrote:
Currently a command that takes two consecutive integer operations, like
client_migrate_info, will be incorrectly parsed by the human monitor if
the second expression begins with a minus ('-') or plus ('+') sign:
client_migrate_info
On Thu, Aug 04, 2011 at 08:33:21AM -, Marcel Hnilka wrote:
Well, I tried to build it with your configuration. It ended with the
same result as I posted, but I found that building was successfull with
option --disable-spice.
Sould you try to build it with --disable-spice option?
I'll
ioport_write's val was changed from uint32_t to uint64_t, this
broke two printfs. Use PRId64 instead of %d.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index db7ae7a..2335e4b 100644
On Tue, Aug 09, 2011 at 03:21:15PM +0300, Alon Levy wrote:
ioport_write's val was changed from uint32_t to uint64_t, this
broke two printfs. Use PRId64 instead of %d.
Nack, missed a 'd' on the second fix. And the subject has a typo.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c
Break is only noticable with newer spice-server library (0.8.2 release
or 0.9.0 and newer on master branch).
ioport_write's val was changed from uint32_t to uint64_t, this
broke two printfs. Use PRId64 instead of %d.
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c |5 +++--
1 files
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..342ed6c 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,10 @@ void do_info_spice_print
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..4fb1b30 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,10 @@ void
On Wed, Aug 10, 2011 at 08:54:36AM +0200, Gerd Hoffmann wrote:
On 08/09/11 22:53, Alon Levy wrote:
Signed-off-by: Alon Levyal...@redhat.com
---
ui/spice-core.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01
}'; echo
'{ execute: quit }') | qemu-system-x86_64 -spice port= -qmp stdio
Signed-off-by: Alon Levy al...@redhat.com
---
monitor.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1b8ba2c..6e3d970 100644
--- a/monitor.c
+++ b/monitor.c
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..f22f1d6 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,10 @@ void
On Wed, Aug 10, 2011 at 10:10:59AM +0200, Gerd Hoffmann wrote:
Hi,
I think it would also be nice to somehow hint this is the spice
sent a second patch (fixing the above), but didn't do any hinting. I'll send
a third.
Saw v2. I would just stick a version string into the dict instead
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..b9d1cd4 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,8 @@ void do_info_spice_print
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..768378e 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,8 @@ void do_info_spice_print
On Wed, Aug 10, 2011 at 06:21:16PM +0300, Alon Levy wrote:
Signed-off-by: Alon Levy al...@redhat.com
NACK, next version uses snprintf.
---
ui/spice-core.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01
Signed-off-by: Alon Levy al...@redhat.com
---
ui/spice-core.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3d77c01..8bb62ea 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -372,6 +372,8 @@ void do_info_spice_print
On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
libcacard: use INSTALL_DATA for data
Signed-off-by: Brad Smith b...@comstyle.com
Thanks, I'll add it to the next pull request.
---
libcacard/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On Sun, Aug 14, 2011 at 03:31:24PM +0200, Diego Elio Pettenò wrote:
Without this change, when using -Wl,--as-needed with GNU linker, the
libraries would be discarded.
Thanks, my bad, didn't know about this switch, makes perfect sense, will add
to the pull request (I should send one by the end
Add an extra optional boolean parameter defaulting to true called auto_switch,
if auto_switch is true the client is requested to switch to the target qemu
upon migration completion. Only implemented for spice, ignored for vnc.
Signed-off-by: Alon Levy al...@redhat.com
---
hmp-commands.hx |6
Takes out the optional ('?') message parsing from the main switch loop
in monitor_parse_command. Adds optional argument option for boolean parameters.
Signed-off-by: Alon Levy al...@redhat.com
---
monitor.c | 79 +++-
1 files changed, 30
before issuing
the switch.
Signed-off-by: Alon Levy al...@redhat.com
---
hmp-commands.hx | 15 +++
monitor.c | 23 +++
qmp-commands.hx | 27 +++
ui/qemu-spice.h |5 +
ui/spice-core.c |4
5 files changed, 74 insertions
On Fri, Aug 26, 2011 at 11:03:38AM +0100, Daniel P. Berrange wrote:
On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote:
On 08/19/11 19:08, Alon Levy wrote:
Fix the ticket expiration on target vm for a spice connection without
introducing
a race between the spice server
On Fri, Aug 26, 2011 at 12:17:58PM +0200, Gerd Hoffmann wrote:
On 08/26/11 12:03, Daniel P. Berrange wrote:
On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote:
On 08/19/11 19:08, Alon Levy wrote:
Fix the ticket expiration on target vm for a spice connection without
introducing
Signed-off-by: Alon Levy al...@redhat.com
---
hw/pci-stub.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci-stub.c b/hw/pci-stub.c
index c5a0aa8..8454c30 100644
--- a/hw/pci-stub.c
+++ b/hw/pci-stub.c
@@ -1,5 +1,5 @@
/*
- * PCI stubs for plathome that doesn't
On Fri, Aug 26, 2011 at 11:17:59PM +0400, malc wrote:
On Fri, 26 Aug 2011, Alon Levy wrote:
Signed-off-by: Alon Levy al...@redhat.com
---
hw/pci-stub.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci-stub.c b/hw/pci-stub.c
index c5a0aa8..8454c30
On Fri, Sep 02, 2011 at 11:10:32AM +0100, Stefan Hajnoczi wrote:
On Mon, Aug 22, 2011 at 01:34:57PM -0400, Brad wrote:
On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote:
libcacard: use INSTALL_DATA for data
Signed-off-by: Brad Smith b...@comstyle.com
---
On Fri, Sep 02, 2011 at 05:19:54PM +0200, Gerd Hoffmann wrote:
reds_stream_free() may call the channel_event callback which is not
supposed to be callsed from worker thread context. This patch moves
the reds_stream_free call for the display channel from the worker to
the dispatcher to fix
On Sat, Sep 03, 2011 at 02:48:25PM +0100, Peter Maydell wrote:
Fix format string errors causing compile failure on 32 bit hosts
when spice is enabled.
Patch looks good.
Reviewed-by: Alon Levy al...@redhat.com
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
This fixes the easy
On Mon, Sep 05, 2011 at 11:02:43AM +0200, Gerd Hoffmann wrote:
Hi,
Hi,
RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that
triggers red_disconnect_channel (and as a result,
reds_stream_free(dispatcher-stream)). red_disconnect_channel is called
also when there is an error
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote:
Hi,
I verified it still calls reds_stream_free from the worker thread, only
now the call itself is done in red_channel.c (via red_channel_disconnect
or something like that), which is called from red_worker.c
Where the code
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote:
Hi,
I verified it still calls reds_stream_free from the worker thread, only
now the call itself is done in red_channel.c (via red_channel_disconnect
or something like that), which is called from red_worker.c
Where the code
On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote:
Hi,
If I select to let my guest XP enter standby mode by clicking the button
manually. qemu will exit with the following message left:
ioport_write: PANIC d-guest_slots[val].active failed
the following is my command to start qemu:
On Fri, Sep 16, 2011 at 02:28:05PM +0800, hkran wrote:
On 09/15/2011 06:42 PM, Alon Levy wrote:
On Thu, Sep 15, 2011 at 05:23:01PM +0800, hkran wrote:
Hi,
If I select to let my guest XP enter standby mode by clicking the button
manually. qemu will exit with the following message left
On Mon, Sep 05, 2011 at 05:39:50PM +0300, Yonit Halperin wrote:
If qxl-ssd.running=true is set after telling spice to start, the spice server
thread can call qxl_send_events while qxl-ssd.running is still false. This
leads to
assert(d-ssd.running).
Looks good.
Acked-by: Alon Levy al
windows cmd window in full screen mode)
and then exiting vga mode back to native mode will cause said panic.
Fixed by doing the slot recreation unconditionally at post_load
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions
On Wed, Sep 21, 2011 at 06:51:18PM +0300, Yonit Halperin wrote:
Signed-off-by: Yonit Halperin yhalp...@redhat.com
---
server/reds.c | 68 +++-
1 files changed, 42 insertions(+), 26 deletions(-)
diff --git a/server/reds.c
On Wed, Sep 21, 2011 at 06:51:19PM +0300, Yonit Halperin wrote:
(1) not sending anything to the client till we recieve SPICE_MSGC_MIGRATE_END
(2) start a new migration (handle client_migrate_info) only after
SPICE_MSGC_MIGRATE_END
from the previous migration has been received
(3) use the
On Wed, Sep 21, 2011 at 06:51:22PM +0300, Yonit Halperin wrote:
Signed-off-by: Yonit Halperin yhalp...@redhat.com
---
server/reds.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 76aa0ed..54c06d1 100644
---
On Wed, Sep 21, 2011 at 06:51:10PM +0300, Yonit Halperin wrote:
same as the previous version with the following changes:
Reviewed-by: Alon Levy al...@redhat.com
Looks good.
(1) I'm sending only the spice-server patches. I will send the client fixes
later.
(and then I will move
On Thu, Sep 22, 2011 at 02:10:04PM -0500, Rick Vernam wrote:
On Friday 16 September 2011 12:42:02 Rick Vernam wrote:
On Friday 16 September 2011 03:52:34 hkran wrote:
[snip]
I have tried many times with many restarts or shutdown-and-boot xp guest
but failed to meet the crashing.
On Wed, Sep 21, 2011 at 06:50:44PM +0300, Yonit Halperin wrote:
- call spice_server_migrate_(start|end|connect).
- register spice_migrate_connect completion callback
Reviewed-by: Alon Levy al...@redhat.com
Will just fix the one place below in the pull request.
Signed-off-by: Yonit Halperin
Hi,
I'm trying to acheive the $subject. Some background: currently spice relies on
a preallocated pci bar for both surfaces and for VGA framebuffer + commands. I
have been trying to get rid of the surfaces bar. To do that I allocate memory
in the guest and then translate it for spice-server
On Sun, Oct 02, 2011 at 03:24:36PM +0200, Alon Levy wrote:
Hi,
Converting qemu's ram allocation to a mmap and using remap_file_pages seems
like it could work. Any ideas why it wouldn't?
Alon
I'm trying to acheive the $subject. Some background: currently spice relies
on a preallocated pci
On Sun, Oct 02, 2011 at 07:12:07PM +0200, Avi Kivity wrote:
On 10/02/2011 04:31 PM, Alon Levy wrote:
On Sun, Oct 02, 2011 at 03:24:36PM +0200, Alon Levy wrote:
Hi,
Converting qemu's ram allocation to a mmap and using remap_file_pages seems
like it could work. Any ideas why it wouldn't
On Mon, Oct 03, 2011 at 10:17:59AM +0200, Yonit Halperin wrote:
On 10/02/2011 03:24 PM, Alon Levy wrote:
Hi,
I'm trying to acheive the $subject. Some background: currently spice
relies on a preallocated pci bar for both surfaces and for VGA framebuffer
+ commands. I have been trying
On Mon, Oct 03, 2011 at 10:37:55AM +0200, Alon Levy wrote:
On Mon, Oct 03, 2011 at 10:17:59AM +0200, Yonit Halperin wrote:
On 10/02/2011 03:24 PM, Alon Levy wrote:
Hi,
I'm trying to acheive the $subject. Some background: currently spice
relies on a preallocated pci bar for both
701 - 800 of 1489 matches
Mail list logo