On (Thu) 14 Mar 2013 [17:36:51], Hans de Goede wrote:
> Signed-off-by: Hans de Goede
Acked-by: Amit Shah
Amit
> series.
>
> Note that this series is based *on top of* Gerd Hoffmann's chardev.5 series
> to avoid conflicts with that series.
Looks good.
Acked-by: Amit Shah
Gerd, will you pick these up via your tree?
Amit
Remove any registered callbacks if a frontend is detached.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index f27fdb6..e235334 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2321,6 +2321,16 @@ typedef
caused a qemu segfault.
https://bugzilla.redhat.com/show_bug.cgi?id=985205
CC:
Reported-by: Sibiao Luo
Signed-off-by: Amit Shah
---
include/sysemu/char.h | 1 +
qemu-char.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index
Signed-off-by: Amit Shah
---
qemu-char.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index d667e8c..2caab95 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2240,10 +2240,7 @@ static gboolean udp_chr_read(GIOChannel *chan
Remove any registered callbacks if a frontend is detached.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 12
1 file changed, 12 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index e235334..91ae1da 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -806,6 +806,17 @@ typedef
This series fixes a segfault when a frontend is detached from a
chardev, and the chardev had a pending callback registered. Further
details in patch 1.
Please review,
Amit Shah (9):
char: remove watch callback on chardev detach from frontend
char: introduce tcp_chr_detach()
char
Signed-off-by: Amit Shah
---
qemu-char.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 4b26ff9..88ed131 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -844,10 +844,7 @@ static gboolean fd_chr_read(GIOChannel *chan
Remove any registered callbacks if a frontend is detached.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 91ae1da..befecf2 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1036,6 +1036,16 @@ typedef
Remove any registered callbacks if a frontend is detached.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index befecf2..4b26ff9 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2198,6 +2198,16 @@ typedef
Signed-off-by: Amit Shah
---
qemu-char.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 88ed131..d667e8c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1141,10 +1141,7 @@ static void pty_chr_state(CharDriverState *chr, int
Signed-off-by: Amit Shah
---
qemu-char.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2caab95..db256f8 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2514,10 +2514,7 @@ static gboolean tcp_chr_read(GIOChannel *chan,
GIOCondition
On (Wed) 28 Aug 2013 [09:09:47], Gerd Hoffmann wrote:
> Hi,
>
> > +static void tcp_chr_detach(CharDriverState *chr)
> > +{
> > +TCPCharDriver *s = chr->opaque;
> > +
> > +if (s->tag) {
> > +io_remove_watch_poll(s->tag);
> > +s->tag = 0;
> > +}
> > +}
>
> Lots of siml
All the backends implement an io watcher tag for callbacks. Move it to
CharDriverState from each backend's struct to make accessing the tag from
backend-neutral functions easier.
This will be used later to cancel a callback on chardev detach from a
frontend.
CC:
Signed-off-by: Amit
This deduplicates code used a lot of times.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 62 +++--
1 file changed, 19 insertions(+), 43 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index cb4a311..44d993a 100644
--- a/qemu-char.c
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Please review.
v2:
* Move tag property to CharDriverState to simplify everything (Gerd)
Amit Shah (3):
char: move backends' io watc
segfault.
https://bugzilla.redhat.com/show_bug.cgi?id=985205
CC:
Reported-by: Sibiao Luo
Signed-off-by: Amit Shah
---
qemu-char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 44d993a..0cba7d4 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -193,6 +193,8
All the backends implement an io watcher tag for callbacks. Move it to
CharDriverState from each backend's struct to make accessing the tag from
backend-neutral functions easier.
This will be used later to cancel a callback on chardev detach from a
frontend.
CC:
Signed-off-by: Amit
This series fixes a segfault when a frontend is detached from a
chardev while the chardev had a pending callback registered. Further
details in patch 3.
Please review.
v3:
* fix whitespace issues in patch 1
v2:
* Move tag property to CharDriverState to simplify everything (Gerd)
Amit Shah (3
segfault.
https://bugzilla.redhat.com/show_bug.cgi?id=985205
CC:
Reported-by: Sibiao Luo
Signed-off-by: Amit Shah
---
qemu-char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 3dcf322..347fa5e 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -193,6 +193,8
On (Wed) 28 Aug 2013 [14:33:13], Gerd Hoffmann wrote:
> On Mi, 2013-08-28 at 17:59 +0530, Amit Shah wrote:
> > This series fixes a segfault when a frontend is detached from a
> > chardev while the chardev had a pending callback registered. Further
> > details in patch 3.
>
This deduplicates code used a lot of times.
CC:
Signed-off-by: Amit Shah
---
qemu-char.c | 62 +++--
1 file changed, 19 insertions(+), 43 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 306d2e1..3dcf322 100644
--- a/qemu-char.c
On (Fri) 30 Aug 2013 [16:35:51], Amos Kong wrote:
> If period is assigned to 0, limit timer will expire immediately.
> This limit is meaningless. This patch forbids to assign 0 to
> period.
>
> Signed-off-by: Amos Kong
Reviewed-by: Amit Shah
Amit
On (Mon) 19 Aug 2013 [16:30:54], Stefan Hajnoczi wrote:
> On Mon, Aug 19, 2013 at 05:28:44PM +0800, yinyin wrote:
> > Hi,all:
> > in func virtqueue_get_avail_bytes， when found a indirect desc, we need
> > loop over it.
> > /* loop over the indirect descriptor table */
> >
On (Tue) 03 Sep 2013 [14:15:55], Michael S. Tsirkin wrote:
> On Tue, Sep 03, 2013 at 04:40:21PM +0530, Amit Shah wrote:
> > On (Mon) 19 Aug 2013 [16:30:54], Stefan Hajnoczi wrote:
> > > On Mon, Aug 19, 2013 at 05:28:44PM +0800, yinyin wrote:
> > > > H
vq element, and adds a new one for the host
to put data in, we can tell users the port is available for more writes,
via the new ->guest_writable() callback.
Signed-off-by: Amit Shah
---
hw/char/virtio-serial-bus.c | 23 +++
include/hw/virtio/virtio-serial.h | 3 +++
vq element, and adds a new one for the host
to put data in, we can tell users the port is available for more writes,
via the new ->guest_writable() callback.
Signed-off-by: Amit Shah
---
v2: check for port != NULL (Peter Maydell)
---
hw/char/virtio-serial-bus.c |
gt; You can checkout my branch here:
>
> git://project.greensocs.com/qemu-virtio.git virtio-serial-v6
>
> Note that it is nearly the same series as virtio-blk and virtio-scsi
> refactoring.
>
> I made basic tests (with linux guests) on:
> * qemu-system-i386
>
>
On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote:
> After attaching the source, we have to remove the reference we hold
> to it, because we do not hold anymore a pointer to the source.
>
> If we do not do this, removing the source will not finalize it and
> will not drop the "real" I/O watch s
On (Thu) 11 Apr 2013 [10:58:30], Paolo Bonzini wrote:
> Il 10/04/2013 19:59, Amit Shah ha scritto:
> > On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote:
> >> After attaching the source, we have to remove the reference we hold
> >> to it, because we do not hold anym
d is rebased on top of virtio-net-v3 I posted before.
>
> I made basic tests (with linux guests) on:
> * qemu-system-i386
Looks OK.
Acked-by: Amit Shah
Thanks,
Amit
/dev/random' on the host.
Reported-by: yunpingzheng
Signed-off-by: Amit Shah
---
backends/rng-random.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/backends/rng-random.c b/backends/rng-random.c
index d5761f2..830360c 100644
--- a/backends/rng-random.c
+++ b/backends/rng-random.c
On (Tue) 16 Apr 2013 [15:51:30], Andreas Färber wrote:
> Am 16.04.2013 12:28, schrieb Amit Shah:
> > Not handling EAGAIN triggers the assert
> >
> > qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len !=
> > -1)
> > Aborted (core dumped)
>
On (Fri) 16 May 2014 [17:00:38], fred.kon...@greensocs.com wrote:
> From: KONRAD Frederic
>
> This makes qemu_savevm_state public for reverse-execution.
>
> Signed-off-by: KONRAD Frederic
Reviewed-by: Amit Shah
Amit
On (Tue) 20 May 2014 [14:01:44], Jason Wang wrote:
> It's hard to track all mac addresses and their configurations (e.g
> vlan or ipv6) in qemu. Without this information, it's impossible to
> build proper garp packet after migration. The only possible solution
> to this is let guest (who knows all
.
>
> Signed-off-by: KONRAD Frederic
Reviewed-by: Amit Shah
> +static bool icount_state_needed(void *opaque)
> +{
> +return (use_icount != 0);
> +}
You can just say 'return use_icount;' here instead.
Amit
On (Wed) 14 May 2014 [16:30:09], Eduardo Habkost wrote:
> From: Marcelo Tosatti
>
> Invariant TSC documentation mentions that "invariant TSC will run at a
> constant rate in all ACPI P-, C-. and T-states".
>
> This is not the case if migration to a host with different TSC frequency
> is allowed,
nt
> to fix this bug.
>
> Signed-off-by: Mo Yuxiang
> Signed-off-by: Gonglei
> Reviewed-by: Michael R. Hines
Reviewed-by: Amit Shah
Amit
On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
> * Peter Lieven (p...@kamp.de) wrote:
> > if a saved vm has unknown flags in the memory data qemu
> > currently simply ignores this flag and continues which
> > yields in an unpredictable result.
> >
> > this patch catches all unknown
vm.
>
> CC: qemu-sta...@nongnu.org
> Signed-off-by: Peter Lieven
Reviewed-by: Amit Shah
> ---
> v2->v3: - reworked last case in the if statement
> - added an error_report in case of an unknown flag [David]
Thanks. Would be nice to get an error_report() for the oth
On (Tue) 10 Jun 2014 [10:47:56], Peter Lieven wrote:
> On 10.06.2014 10:45, Amit Shah wrote:
> >On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote:
> >>if a saved vm has unknown flags in the memory data qemu
> >>currently simply ignores this flag and continues which
>
On (Tue) 10 Jun 2014 [11:43:29], Eduardo Habkost wrote:
> On Tue, Jun 10, 2014 at 12:42:14PM +0530, Amit Shah wrote:
> > On (Wed) 14 May 2014 [16:30:09], Eduardo Habkost wrote:
> > > From: Marcelo Tosatti
> > >
> > > Invariant TSC documentation mentio
On (Wed) 11 Jun 2014 [10:50:04], Jason Wang wrote:
> On 06/10/2014 06:10 PM, Michael S. Tsirkin wrote:
> > On Tue, Jun 10, 2014 at 11:50:33AM +0530, Amit Shah wrote:
> >> On (Tue) 20 May 2014 [14:01:44], Jason Wang wrote:
> >>> It's hard to track all mac addr
On (Mon) 16 Jun 2014 [17:07:01], Greg Kurz wrote:
> Hi,
>
> I've reworked the patch set according to Alex's last remarks. Do any of the
> other maintainers have pending remarks ? Should I wait or send a v9 now ?
I'm yet to go through the series; I'll get to it in a day or two.
Am
cription "ehci-core": expected field "usbsts",
got "usbsts_pending"; skipping rest
Section "intel-hda-generic", Description "intel-hda", Field "pci": missing
description
Section "cfi.pflash01": Entry "Description" missin
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 4ccfd67..f6b52d0 100644
--- a/tests/vmstate-static-checker-data
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 0a8b81d..f405534 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 66ac3bd..05b8fce 100644
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f405534..36a9b4b 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f6b52d0..34bfbf6 100644
--- a/tests/vmstate-static-checker-data
This commit modifies the dump2 data to flag incompatibilities in the
machine types being compared.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 36a9b4b..4ccfd67 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 15 ---
1 file changed, 15 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 6f8a617..b5cb1aa 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump1.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump1.json
b/tests/vmstate-static-checker-data/dump1.json
index 44200fb..786ca0b 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 114 +--
1 file changed, 1 insertion(+), 113 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f69966d..cc0aae3 100644
This shows how the script deals with substructures added to vmstate
descriptions that don't change the on-wire format.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 115 +++
1 file changed, 64 insertions(+), 51 deletions(-)
diff --
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 34bfbf6..f69966d 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 45cccaf..75719f5 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 33 +---
1 file changed, 1 insertion(+), 32 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index cc0aae3..66ac3bd 100644
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 13 -
1 file changed, 13 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 05b8fce..6f8a617 100644
--- a/tests/vmstate-static
fields within substructs.
The script takes -s/--src and -d/--dest parameters, to which filenames
are given as arguments.
Signed-off-by: Amit Shah
---
scripts/vmstate-static-checker.py | 326 ++
1 file changed, 326 insertions(+)
create mode 100755 scripts
On (Tue) 17 Jun 2014 [07:34:07], Eric Blake wrote:
>
>
> On 06/17/2014 07:19 AM, Amit Shah wrote:
> > Hello,
> >
> > v3:
> > - Python script returns an error code: 0 if no errors, positive for
> >the number of errors identified.
>
> Returning
different QEMU versions, specifically to test whether live migration
would break due to changes in the vmstate data.
A Python script that compares the output of such JSON dumps is included
in the following commit.
Signed-off-by: Amit Shah
---
include/migration/vmstate.h | 2 +
qemu-options.hx
usb" version error: 2 > 1
Section "fusbh200-ehci-usb", Description "ehci-core": expected field "usbsts",
got "usbsts_pending"; skipping rest
Section "intel-hda-generic", Description "intel-hda", Field "pci": missing
description
fields within substructs.
The script takes -s/--src and -d/--dest parameters, to which filenames
are given as arguments.
Signed-off-by: Amit Shah
---
scripts/vmstate-static-checker.py | 329 ++
1 file changed, 329 insertions(+)
create mode 100755 scripts
different QEMU versions, specifically to test whether live migration
would break due to changes in the vmstate data.
A Python script that compares the output of such JSON dumps is included
in the following commit.
Signed-off-by: Amit Shah
---
include/migration/vmstate.h | 2 +
qemu-options.hx
This commit modifies the dump2 data to flag incompatibilities in the
machine types being compared.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests
This shows how the script deals with substructures added to vmstate
descriptions that don't change the on-wire format.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 115 +++
1 file changed, 64 insertions(+), 51 deletions(-)
diff --
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f405534..36a9b4b 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f6b52d0..34bfbf6 100644
--- a/tests/vmstate-static-checker-data
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 45cccaf..75719f5 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 0a8b81d..f405534 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 66ac3bd..05b8fce 100644
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 36a9b4b..4ccfd67 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 114 +--
1 file changed, 1 insertion(+), 113 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f69966d..cc0aae3 100644
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 15 ---
1 file changed, 15 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 6f8a617..b5cb1aa 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 4ccfd67..f6b52d0 100644
--- a/tests/vmstate-static-checker-data
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 13 -
1 file changed, 13 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 05b8fce..6f8a617 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 33 +---
1 file changed, 1 insertion(+), 32 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index cc0aae3..66ac3bd 100644
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 34bfbf6..f69966d 100644
--- a/tests/vmstate-static
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump1.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump1.json
b/tests/vmstate-static-checker-data/dump1.json
index 44200fb..786ca0b 100644
--- a/tests/vmstate-static
On (Wed) 18 Jun 2014 [12:24:25], Juan Quintela wrote:
> Amit Shah wrote:
> > This commit adds a new command, '-dump-vmstate', that takes a filename
> > as a parameter. When executed, QEMU will dump the vmstate information
> > for the machine type it'
On (Wed) 18 Jun 2014 [12:44:12], Juan Quintela wrote:
> Amit Shah wrote:
> > This script compares the vmstate dumps in JSON format as output by QEMU
> > with the -dump-vmstate option.
> >
> > It flags various errors, like version mismatch, sections going awa
On (Wed) 18 Jun 2014 [12:49:21], Juan Quintela wrote:
> Amit Shah wrote:
> > Hello,
> >
> > v4:
> > - Return value capped to 255 to prevent wrap-around (Eric Blake)
> >
> > v3:
> > - Python script returns an error code: 0 if no errors, positi
On (Wed) 18 Jun 2014 [13:25:50], Juan Quintela wrote:
> > Do you want to hold off this series till that, or should I just send a
> > follow-up patch (series) once I get something?
>
> No, we can change that later.
>
> Just asked Peter on irc, if nobody complains, as this is new code, I
> would i
On (Fri) 13 Jun 2014 [13:18:42], Greg Kurz wrote:
> The device configuration is set at realize time and never changes. It
> should not be migrated as it is done today. For the sake of compatibility,
> let's just skip them at load time.
>
> Signed-off-by: Alexander Graf
The author field should al
te" not
found
Section "fusbh200-ehci-usb" version error: 2 > 1
Section "fusbh200-ehci-usb", Description "ehci-core": expected field "usbsts",
got "usbsts_pending"; skipping rest
Section "intel-hda-generic", Description "intel-hda&q
-off-by: Amit Shah
---
scripts/vmstate-static-checker.py | 345 ++
1 file changed, 345 insertions(+)
create mode 100755 scripts/vmstate-static-checker.py
diff --git a/scripts/vmstate-static-checker.py
b/scripts/vmstate-static-checker.py
new file mode 100755
Signed-off-by: Amit Shah
Acked-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f405534..36a9b4b 100644
--- a
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 36a9b4b..4ccfd67 100644
This commit modifies the dump2 data to flag incompatibilities in the
machine types being compared.
Signed-off-by: Amit Shah
Acked-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 4ccfd67..f6b52d0 100644
--- a/tests
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index
Signed-off-by: Amit Shah
Acked-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 0a8b81d..f405534 100644
--- a
This shows how the script deals with substructures added to vmstate
descriptions that don't change the on-wire format.
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 115 +++
1 file changed, 64 insertions(+
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f6b52d0..34bfbf6 100644
--- a/tests
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump1.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump1.json
b/tests/vmstate-static-checker-data/dump1.json
index 44200fb..786ca0b 100644
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 45cccaf..75719f5 100644
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 13 -
1 file changed, 13 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 05b8fce..6f8a617 100644
--- a
Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 34bfbf6..f69966d 100644
101 - 200 of 1982 matches
Mail list logo
