Re: [Qemu-devel] [PATCHv3] virtio-serial-bus: use bh for unthrottling

2011-05-02 Thread Amit Shah
On (Sat) 30 Apr 2011 [11:23:42], Alon Levy wrote: > On Fri, Apr 29, 2011 at 06:26:49PM +0530, Amit Shah wrote: > > On (Fri) 29 Apr 2011 [14:25:06], Alon Levy wrote: > > > Instead of calling flush_queued_data when unthrottling, schedule > > > a bh. That way we can retur

[Qemu-devel] [PULL] virtio-serial: use bh for unthrottling

2011-05-12 Thread Amit Shah
The following changes since commit 0225e254ae81c5638463cda8f5730f31619113b6: usb-linux: Add missing break statement (2011-05-09 16:18:32 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony Alon Levy (1): virtio-serial-bus

[Qemu-devel] [PATCH 1/1] virtio-serial-bus: use bh for unthrottling

2011-05-12 Thread Amit Shah
Levy Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 12 ++-- hw/virtio-serial.h |5 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index f10d48f..ca0581b 100644 --- a/hw/virtio-serial-bus.c +++ b/hw

Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command

2011-12-08 Thread Amit Shah
On (Thu) 08 Dec 2011 [16:52:58], Luiz Capitulino wrote: > This is basically suspend to disk on a Linux guest. > > Signed-off-by: Luiz Capitulino > --- > > This is an RFC because I did it as simple as possible and I'm open to > suggestions... > > Now, while testing this or even "echo disk > /sys

[Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised

2011-12-09 Thread Amit Shah
not, let me know and I'll change it to something else. Please review and apply. Amit Shah (3): balloon: Make functions return 0 on OK, -1 on error. balloon: report error if ballooning operation fails virtio-balloon: report error if balloon driver in guest not availabl

[Qemu-devel] [PATCH 1/3] balloon: Make functions return 0 on OK, -1 on error.

2011-12-09 Thread Amit Shah
Current semantics of 1 on OK and 0 on error are slightly weird. qemu_balloon() and qemu_balloon_stats() do this. Other functions in the file use the standard 0 and -1 return values. This commit makes the file consistent in returning such values. Signed-off-by: Amit Shah --- balloon.c | 14

[Qemu-devel] [PATCH 3/3] virtio-balloon: report error if balloon driver in guest not available

2011-12-09 Thread Amit Shah
was still updated, resulting in the ballooning value being applied to the guest after the guest loads the balloon module. This may not be the desirable thing to do at this later stage. Signed-off-by: Amit Shah --- hw/virtio-balloon.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions

[Qemu-devel] [PATCH 2/3] balloon: report error if ballooning operation fails

2011-12-09 Thread Amit Shah
Ballooning operations can fail (e.g. driver in guest not available). Let the user know of such an error condition instead of silently ignoring errors. Signed-off-by: Amit Shah --- balloon.c |7 +-- balloon.h |2 +- hw/virtio-balloon.c |3 ++- 3 files changed

Re: [Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised

2011-12-09 Thread Amit Shah
On (Fri) 09 Dec 2011 [11:55:21], Daniel P. Berrange wrote: > On Fri, Dec 09, 2011 at 05:19:35PM +0530, Amit Shah wrote: > > Hello, > > > > These patches make qemu generate an error on failure in setting a > > balloon value: > > > > (qemu) balloon 400 >

Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command

2011-12-09 Thread Amit Shah
On (Fri) 09 Dec 2011 [10:22:25], Luiz Capitulino wrote: > On Thu, 08 Dec 2011 21:18:00 -0600 > Michael Roth wrote: > > > On 12/08/2011 12:52 PM, Luiz Capitulino wrote: > > > This is basically suspend to disk on a Linux guest. > > > > > > Signed-off-by: Luiz Capitulino > > > --- > > > > > > This i

Re: [Qemu-devel] [RFC] virtio-console fails on unconnected pty

2011-12-16 Thread Amit Shah
Hi Christian, On (Thu) 15 Dec 2011 [13:44:41], Christian Borntraeger wrote: > Amit, > > when I tried qemu with -virtio-console pty the guest hangs and attaching on > /dev/pts/ does > not return anything if the attachement is too late. Unfortunately we don't yet have chardevs to signal to fronte

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-16 Thread Amit Shah
On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > In pci_enable_msix(), the guest's virtio-serial driver tries to set msi-x > with one vector per queue. But it fails and eventually all virtio-serial > ports share one MSI-X vector. Because every virtio-seria

Re: [Qemu-devel] [PATCH] virtio-serial: Allow one MSI-X vector per virtqueue

2011-12-18 Thread Amit Shah
On (Mon) 19 Dec 2011 [14:09:43], Zang Hongyong wrote: > 于 2011/12/16,星期五 17:39, Amit Shah 写道: > >On (Fri) 16 Dec 2011 [09:14:26], zanghongy...@huawei.com wrote: > >>From: Hongyong Zang > >> > >>In pci_enable_msix(), the guest's virtio-serial driver tries t

Re: [Qemu-devel] [PATCH] Migration: Generate the completed event only when we complete

2015-10-13 Thread Amit Shah
up racing with the actual end of migration. > > This corresponds to RH bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1271145 > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah > migration/migration.c | 8 +++- > 1 file changed, 7 insertions(+), 1 de

[Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
done just before the VM is runnable. Signed-off-by: Amit Shah --- migration/migration.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index b7de9b7..ca21ba8 100644 --- a/migration/migration.c +++ b/migration/migration.c

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
On (Wed) 14 Oct 2015 [13:38:30], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > there were errors detected after this announcement was done, the > > migration

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-14 Thread Amit Shah
On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > > Amit Shah wrote: > > > We were announcing the dest host's IP as our new IP a bit too soon -- if > > > there were errors detected after

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

2015-10-15 Thread Amit Shah
On (Thu) 15 Oct 2015 [08:36:49], Juan Quintela wrote: > Amit Shah wrote: > > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > >> > Amit Shah wrote: > >> > > We were anno

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

2015-10-25 Thread Amit Shah
On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote: > > > Some cleanup operations take long time during the pause and copy > > > stage, especially with the KVM patch 3ea3b7fa9af067, do these > > > operations after the completion of live migration can help to reduce > > > VM > > downtime. > > > >

Re: [Qemu-devel] Reminder: we're now in softfreeze

2015-10-25 Thread Amit Shah
Hey Peter, On (Thu) 22 Oct 2015 [11:30:57], Peter Maydell wrote: > [Apologies for the huge cc list, which is basically "everybody > I have accepted a pullreq from this release cycle.] > > Just a reminder that we're now in softfreeze (ie "no new big > features, start the process of cutting down to

Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread Amit Shah
On (Wed) 22 Jul 2015 [10:19:52], Daniel P. Berrange wrote: > On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > If vnc's password is configured, it will leak memory > > which cipher variable pointed on every vnc connection. > > > > Cc: Daniel P. Be

Re: [Qemu-devel] [PATCH v7 27/42] postcopy: ram_enable_notify to switch on userfault

2015-07-22 Thread Amit Shah
gt; Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 28/42] Postcopy: Postcopy startup in migration thread

2015-07-22 Thread Amit Shah
On (Mon) 13 Jul 2015 [18:56:55], Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > > +/* > > > + * send rest of state - note things that are doing postcopy > > > + * will notice we're in POSTCOPY_ACTIVE and not actually > > > + * wrap their state up h

Re: [Qemu-devel] [PATCH v7 28/42] Postcopy: Postcopy startup in migration thread

2015-07-22 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:41], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Rework the migration thread to setup and start postcopy. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 29/42] Postcopy end in migration_thread

2015-07-22 Thread Amit Shah
postcopy. > > The end of migration code is getting a bit complciated now, so > move out into its own function. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 29/42] Postcopy end in migration_thread

2015-07-23 Thread Amit Shah
On (Mon) 13 Jul 2015 [15:15:07], Juan Quintela wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > The end of migration in postcopy is a bit different since some of > > the things normally done at the end of migration have already been > > done on the transit

Re: [Qemu-devel] [PATCH v7 30/42] Page request: Add MIG_RP_MSG_REQ_PAGES reverse command

2015-07-23 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:43], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add MIG_RP_MSG_REQ_PAGES command on Return path for the postcopy > destination to request a page from the source. > > Signed-off-by: Dr. David Alan Gilbert > --- a/migration/migration.c >

Re: [Qemu-devel] [PATCH v7 31/42] Page request: Process incoming page request

2015-07-23 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:44], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > On receiving MIG_RPCOMM_REQ_PAGES look up the address and > queue the page. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 32/42] Page request: Consume pages off the post-copy queue

2015-07-26 Thread Amit Shah
st linear > walk that break as soon as we do a queued page. > > c) We have to be careful to not break up host-page size chunks, since > this makes it harder to place the pages on the destination. > > Signed-off-by: Dr. David Alan Gilbert Reviewed

Re: [Qemu-devel] [PATCH v7 33/42] postcopy_ram.c: place_page and helpers

2015-07-26 Thread Amit Shah
avid Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 33/42] postcopy_ram.c: place_page and helpers

2015-07-26 Thread Amit Shah
On (Tue) 14 Jul 2015 [12:05:33], Juan Quintela wrote: > "Dr. David Alan Gilbert (git)" wrote: > > +/* > > + * Place a host page (from) at (host) atomically > > + * all_zero: Hint that the page being placed is 0 throughout > > + * returns 0 on success > > + */ > > +int postcopy_place_page(Migratio

Re: [Qemu-devel] [PATCH] virtio-serial: fix ANY_LAYOUT

2015-07-26 Thread Amit Shah
On (Mon) 27 Jul 2015 [09:37:47], Michael S. Tsirkin wrote: > Don't assume a specific layout for control messages. > Required by virtio 1. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Amit Shah > --- > hw/char/virtio-serial-bus.c | 3 ++- > 1 file changed, 2

Re: [Qemu-devel] [PATCH v7 34/42] Postcopy: Use helpers to map pages during migration

2015-07-27 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:47], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In postcopy, the destination guest is running at the same time > as it's receiving pages; as we receive new pages we must put > them into the guests address space atomically to avoid a runnin

Re: [Qemu-devel] [PATCH v7 35/42] Don't sync dirty bitmaps in postcopy

2015-07-27 Thread Amit Shah
dest, because after a migration, we don't ever think of looking at messages on the src. And chances are the dest could blow up after a migration is successful because of such "corruption".) > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 37/42] Postcopy; Handle userfault requests

2015-07-27 Thread Amit Shah
nowledge those stalls and tell the accessing > thread to carry on. > > We convert the requests from the kernel into messages back to the > source asking for the pages. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 39/42] postcopy: Wire up loadvm_postcopy_handle_ commands

2015-07-27 Thread Amit Shah
> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 40/42] End of migration for postcopy

2015-07-27 Thread Amit Shah
thread. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-27 Thread Amit Shah
On (Tue) 14 Jul 2015 [17:22:13], Juan Quintela wrote: > "Dr. David Alan Gilbert (git)" wrote: > > +if (enable_mlock) { > > +if (os_mlock() < 0) { > > +error_report("mlock: %s", strerror(errno)); > > +/* > > + * It doesn't feel right to fail at this

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-27 Thread Amit Shah
ere. > > munlock the pages we userfault protect before postcopy. > mlock everything again at the end if mlock is enabled. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 42/42] Inhibit ballooning during postcopy

2015-07-27 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:55], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy detects accesses to pages that haven't been transferred yet > using userfaultfd, and it causes exceptions on pages that are 'not > present'. > Ballooning also causes pages to be mark

Re: [Qemu-devel] [PATCH v7 00/42] Postcopy implementation

2015-07-27 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:13], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is the 7th cut of my version of postcopy; it is designed for use with > the Linux kernel additions posted by Andrea Arcangeli here: > > git clone --reference linux -b userfault21 > gi

Re: [Qemu-devel] [PATCH v7 42/42] Inhibit ballooning during postcopy

2015-07-28 Thread Amit Shah
On (Tue) 28 Jul 2015 [10:08:15], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Tue) 16 Jun 2015 [11:26:55], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Postcopy detects a

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-08-02 Thread Amit Shah
On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote: > On Thu, 30 Jul 2015, Stefano Stabellini wrote: > > On Thu, 30 Jul 2015, Juan Quintela wrote: > > > Anthony PERARD wrote: > > > > This is a critical issue for Xen as migration either with the same > > > > version > > > > of QEMU, or from

[Qemu-devel] [PULL for-2.4 3/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Amit Shah
From: Anthony PERARD This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD Message-Id: <1438098885-4339-4-git-send-email-anthony.per...@citrix.com> Signed-off-by: Amit Shah --- migration/savevm.c | 5 + 1 file chan

[Qemu-devel] [PULL for-2.4 0/3] Regression fix for migration on Xen

2015-08-03 Thread Amit Shah
The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/qemu/amit/migration for-2.4 for you to fetch changes up to 040f70812f1fc25239

[Qemu-devel] [PULL for-2.4 1/3] migration: Fix regretion for xenfv machine.

2015-08-03 Thread Amit Shah
uration sectin and the section footers are not going to be present in previous version of QEMU with xenfv machine, so we skip them. Signed-off-by: Anthony PERARD Message-Id: <1438098885-4339-2-git-send-email-anthony.per...@citrix.com> Signed-off-by: Amit Shah --- hw/i386/pc_piix.c |

[Qemu-devel] [PULL for-2.4 2/3] migration: Fix global state with Xen.

2015-08-03 Thread Amit Shah
state. Also, the toolstack expect QEMU to autostart when the migration is finished. So this patch store "running" as it's current runstate. Signed-off-by: Anthony PERARD Message-Id: <1438098885-4339-3-git-send-email-anthony.per...@citrix.com> Signed-off-by: Amit Shah -

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [10:37:26], Stefano Stabellini wrote: > On Mon, 3 Aug 2015, Amit Shah wrote: > > On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote: > > > On Thu, 30 Jul 2015, Stefano Stabellini wrote: > > > > On Thu, 30 Jul 2015, Juan Quintela wrote: &

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:53:57], Stefano Stabellini wrote: > On Mon, 3 Aug 2015, Anthony PERARD wrote: > > When doing migration via the QMP command xen_save_devices_state, the > > current runstate is not store into the global state section. Also the > > current runstate is not the one we want on th

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: > Hi, > > We've spotted several regression which prevent migration with Xen using the > same version of QEMU or from a previous version of QEMU (tryied with 2.2). > > Regression have been introduce by at least: > - df4b1024526cae3479da3492d63

Re: [Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2015-08-03 Thread Amit Shah
On (Tue) 28 Jul 2015 [09:17:25], Quwj wrote: > I met two bugs above.QEMU version is 2.1.3 and VM is Windows7. > QEMU Log is: > qemu-system-x86_64: virtio-serial-bus: Unexpected port id 15819934 for device > virtio-serial0.0 (snip) > Bug description: > With qemu-kvm-0.15.0-rc1 virtio-serial-bus

Re: [Qemu-devel] [PATCH v7 01/42] Start documenting how postcopy works.

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:14], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah A few minor comments: > --- > docs/migration.txt | 167 > +++

Re: [Qemu-devel] [PATCH v7 03/42] Init page sizes in qtest

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:16], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > One of my patches used a loop that was based on host page size; > it dies in qtest since qtest hadn't bothered init'ing it. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v7 19/42] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream

2015-08-03 Thread Amit Shah
he destination guarantees that the whole MIG_CMD_PACKAGED > is read off the stream prior to parsing the contents. > > This is used by postcopy to load device state (from the package) > while leaving the main stream free to receive memory pages. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

2015-08-03 Thread Amit Shah
s we need. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 35/42] Don't sync dirty bitmaps in postcopy

2015-08-03 Thread Amit Shah
On (Fri) 31 Jul 2015 [10:50:46], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Tue) 16 Jun 2015 [11:26:48], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Once we're in po

Re: [Qemu-devel] QEMU Summit 2015 agenda

2015-08-05 Thread Amit Shah
On (Tue) 04 Aug 2015 [16:56:26], Stefan Hajnoczi wrote: > On Tue, Aug 4, 2015 at 4:40 PM, Peter Maydell > wrote: > > * Can we as a project do more to advertise the features > >and improvements we make? > > The QEMU Google+ page can do Hangouts On Air video streaming. > Community members can

Re: [Qemu-devel] [PATCH] monitor: remove QAPI_EVENT_VSERPORT_CHANGE throttle

2015-08-12 Thread Amit Shah
On (Tue) 11 Aug 2015 [20:21:18], Laszlo Ersek wrote: > On 08/11/15 19:04, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port > > state. However, the events may be for different ports, but the throttle > > mecha

Re: [Qemu-devel] [PATCH v6 11/47] Return path: Open a return path on QEMUFile for sockets

2015-06-10 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:37], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy needs a method to send messages from the destination back to > the source, this is the 'return path'. > > Wire it up for 'socket' QEMUFile's using a dup'd fd. I'm not too sure we s

Re: [Qemu-devel] [PATCH v3] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-15 Thread Amit Shah
On (Tue) 15 Sep 2015 [14:26:06], David Gibson wrote: > On Mon, Sep 14, 2015 at 08:32:36AM +0200, Thomas Huth wrote: > > On 14/09/15 04:15, David Gibson wrote: > > > On Fri, Sep 11, 2015 at 11:17:01AM +0200, Thomas Huth wrote: > > >> The PAPR interface defines a hypercall to pass high-quality > > >>

Re: [Qemu-devel] [PATCH] migration: Use g_new() & friends where that makes obvious sense

2015-09-15 Thread Amit Shah
more type errors. > > This commit only touches allocations with size arguments of the form > sizeof(T). Same Coccinelle semantic patch as in commit b45c03f. > > Signed-off-by: Markus Armbruster Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal

2015-09-15 Thread Amit Shah
Hi, On (Fri) 17 Apr 2015 [14:12:59], Bohdan Trach wrote: > From: Bohdan Trach > > This patchset contains a checkpoint-assisted migration feature as > proposed earlier on this list [1]. It allows reusing existing memory > snapshots of guests to speed up migration of VMs between physical > hosts.

Re: [Qemu-devel] [PATCH 1/5] migration/ram.c: Use RAMBlock rather than MemoryRegion

2015-09-15 Thread Amit Shah
clean it up just to avoid the > MemoryRegion use. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH 2/5] Split out end of migration code from migration_thread

2015-09-15 Thread Amit Shah
> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah > --- > migration/migration.c | 75 > --- > trace-events | 2 ++ > 2 files changed, 49 insertions(+), 28 deletions(-) > > diff --git a/migr

Re: [Qemu-devel] [PATCH 4/5] migration: size_t'ify some of qemu-file

2015-09-15 Thread Amit Shah
ize_t return values (like read(2)) > and fixes up all the different implementations of them. > > Note that I've not yet followed this deeply into bdrv_ implementations. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah This is really nice, thanks! (Though it

Re: [Qemu-devel] [PATCH 5/5] migration: qemu-file more size_t'ifying

2015-09-15 Thread Amit Shah
On (Thu) 13 Aug 2015 [11:51:34], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This time convert the external functions: > qemu_get_buffer, qemu_peek_buffer > qemu_put_buffer and qemu_put_buffer_async > > Signed-off-by: Dr. David A

[Qemu-devel] [PATCH 1/1] target-i386: get/put MSR_TSC_AUX across reset and migration

2015-09-22 Thread Amit Shah
There's one report of migration breaking due to missing MSR_TSC_AUX save/restore. Fix this by adding a new subsection that saves the state of this MSR. https://bugzilla.redhat.com/show_bug.cgi?id=1261797 Reported-by: Xiaoqing Wei Signed-off-by: Amit Shah CC: Paolo Bonzini CC: Juan Qui

Re: [Qemu-devel] [PATCH 1/2] Move dirty page search state into separate structure

2015-09-23 Thread Amit Shah
set; > +pss.complete_round = false; > + > +if (!pss.block) > +pss.block = QLIST_FIRST_RCU(&ram_list.blocks); Missing {} around if With those fixed: Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH 2/2] ram_find_and_save_block: Split out the finding

2015-09-23 Thread Amit Shah
On (Wed) 16 Sep 2015 [19:11:54], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split out the finding of the dirty page and all the wrap detection > into a separate function since it was getting a bit hairy. > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/

Re: [Qemu-devel] [PATCH v2 0/2] Split up ram_find_and_save_block

2015-09-23 Thread Amit Shah
y previous 5 patch cleanup series posted > in August, but rebased on current qemu master. Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v2 2/2] ram_find_and_save_block: Split out the finding

2015-09-23 Thread Amit Shah
On (Wed) 23 Sep 2015 [15:27:11], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split out the finding of the dirty page and all the wrap detection > into a separate function since it was getting a bit hairy. > > Signed-off-by: Dr. David Alan Gilbert > +if (pss->co

[Qemu-devel] Maintainer talking about the QEMU 2.4 release

2015-09-07 Thread Amit Shah
Hello all, For the 2.4 release, we tried a little experiment. I asked maintainers who had pull reqs merged in the 2.4 release to give me a few talking points for their subsystem via email. Since the release also coincided with the QEMU Summit / KVM Forum, I got a chance to meet a few contributor

Re: [Qemu-devel] [PATCH 0/3] monitor: throttle VSERPORT_CHANGED by "id"

2015-09-09 Thread Amit Shah
On (Tue) 08 Sep 2015 [12:18:53], Marc-André Lureau wrote: > ping I'd rather the qmp / qapi maintainers chimed in - the changes touch that part of code rather than the virtio-serial related code. > > On Wed, Sep 2, 2015 at 1:09 PM, wrote: > > From: Marc-André Lureau > > > > QAPI_EVENT_VSERPORT

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

2015-08-30 Thread Amit Shah
On (Wed) 26 Aug 2015 [14:26:55], Sören Brinkmann wrote: > On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote: > > On 14 August 2015 at 07:16, Soren Brinkmann > > wrote: > > > The macro is defined twice in identical ways. > > > > > > Signed-off-by: Soren Brinkmann > > > --- > > > I have the

[Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b: s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/qemu/amit/virtio-serial vser-for-2.5 for you to fetch changes up to 1717c47170ec8df29

[Qemu-devel] [PULL 1/1] monitor: remove QAPI_EVENT_VSERPORT_CHANGE throttle

2015-09-01 Thread Amit Shah
ow_bug.cgi?id=1244064 Signed-off-by: Marc-André Lureau Message-Id: <1439312647-22245-1-git-send-email-marcandre.lur...@redhat.com> Reviewed-by: Daniel P. Berrange Signed-off-by: Amit Shah --- monitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/monitor.c b/monitor.c index fc32f12

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [13:13:56], Peter Maydell wrote: > On 1 September 2015 at 13:04, Amit Shah wrote: > > The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b: > > > > s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) > > > > ar

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [14:27:48], Marc-André Lureau wrote: > Hi Amit > > Out of curiosity, did you check the series "monitor: throttle > VSERPORT_CHANGED by id"? That would fix the throttling instead of just > removing it. This can be applied later, but reviews are always welcome > :) So do you wa

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [17:32:07], Peter Maydell wrote: > On 1 September 2015 at 13:47, Amit Shah wrote: > > On (Tue) 01 Sep 2015 [14:27:48], Marc-André Lureau wrote: > >> Hi Amit > >> > >> Out of curiosity, did you check the series "monitor: throttle >

Re: [Qemu-devel] [PATCH v2 2/2] ppc/spapr_hcall: Implement H_RANDOM hypercall in QEMU

2015-09-01 Thread Amit Shah
On (Mon) 31 Aug 2015 [20:46:02], Thomas Huth wrote: > The PAPR interface provides a hypercall to pass high-quality > hardware generated random numbers to guests. So let's provide > this call in QEMU, too, so that guests that do not support > virtio-rnd yet can get good random numbers, too. virtio-

Re: [Qemu-devel] [PATCH 0/2] Optimization with AVX2 instruction

2015-09-01 Thread Amit Shah
On (Fri) 28 Aug 2015 [16:54:11], Liang Li wrote: > The buffer_find_nonzero_offset() will be called to check the zero page > during live migration, it's a hot function. buffer_find_nonzero_offset() > has already been optimized with SSE2 instructions, for platform that > supports AVX2, we can optimiz

Re: [Qemu-devel] [PATCH v2 2/2] ppc/spapr_hcall: Implement H_RANDOM hypercall in QEMU

2015-09-02 Thread Amit Shah
On (Wed) 02 Sep 2015 [17:48:01], David Gibson wrote: > On Wed, Sep 02, 2015 at 11:04:12AM +0530, Amit Shah wrote: > > On (Mon) 31 Aug 2015 [20:46:02], Thomas Huth wrote: > > > The PAPR interface provides a hypercall to pass high-quality > > > hardware generated random

Re: [Qemu-devel] [PATCH v2 2/2] ppc/spapr_hcall: Implement H_RANDOM hypercall in QEMU

2015-09-02 Thread Amit Shah
On (Wed) 02 Sep 2015 [10:58:57], Thomas Huth wrote: > On 02/09/15 09:48, David Gibson wrote: > > On Wed, Sep 02, 2015 at 11:04:12AM +0530, Amit Shah wrote: > >> On (Mon) 31 Aug 2015 [20:46:02], Thomas Huth wrote: > >>> The PAPR interface provides a hypercall to pa

Re: [Qemu-devel] [PATCH v7 04/42] qemu_ram_block_from_host

2015-07-10 Thread Amit Shah
t sent on the > wire. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-12 Thread Amit Shah
On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote: >Timer was added in virtio-rng to rate limit the > entropy. It used to trigger at regular intervals to > bump up the quota value. The value of quota and timer > slice is decided based on entropy source rate in host. It doesn't necessaril

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [02:53:36], Pankaj Gupta wrote: > Hi Amit, > > Thanks for the review. > > > > > On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote: > > >    Timer was added in virtio-rng to rate limit the > > > entropy. It used to trigger at regular intervals to > > > bump up the quota val

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [04:01:01], Pankaj Gupta wrote: > > > > Hi Amit, > > > > > > Thanks for the review. > > > > > > > > > > > On (Fri) 10 Jul 2015 [15:04:00], Pankaj Gupta wrote: > > > > >    Timer was added in virtio-rng to rate limit the > > > > > entropy. It used to trigger at regular inter

Re: [Qemu-devel] [PATCH] virtio-rng: Bump up quota value only when guest requests entropy

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [10:55:55], Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 01:04:45PM +0530, Amit Shah wrote: > > That also saves us the trouble with live migration: if we hold onto a > > buffer, that becomes state, and we'll have to migrate it as well. > > T

Re: [Qemu-devel] [PATCH v7 05/42] Add qemu_get_buffer_less_copy to avoid copies some of the time

2015-07-13 Thread Amit Shah
avoiding the copy. This isn't always possible > depending on the size and alignment of the data. > > Thus 'qemu_get_buffer_less_copy' either copies the data to a supplied > buffer or updates a pointer to the internal buffer if convenient. > > Sign

Re: [Qemu-devel] [PATCH v7 07/42] ram_debug_dump_bitmap: Dump a migration bitmap as text

2015-07-13 Thread Amit Shah
Lines that are all the expected value are excluded so the output > can be quite compact for many bitmaps. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 08/42] migrate_init: Call from savevm

2015-07-13 Thread Amit Shah
nding. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewd-by: Amit Shah Amit

Re: [Qemu-devel] [PULL v2 04/16] ich9: add TCO interface emulation

2015-07-13 Thread Amit Shah
On (Wed) 08 Jul 2015 [12:41:35], Michael S. Tsirkin wrote: > From: Paulo Alcantara > > This interface provides some registers within a 32-byte range and can be > acessed through PCI-to-LPC bridge interface (PMBASE + 0x60). > > It's commonly used as a watchdog timer to detect system lockups throu

Re: [Qemu-devel] [PATCH] migration: reduce the count of strlen call

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [17:34:10], Liang Li wrote: > 'strlen' is called three times in 'save_page_header', it's > inefficient. > > Signed-off-by: Liang Li Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 10/42] Return path: Open a return path on QEMUFile for sockets

2015-07-13 Thread Amit Shah
; QEMUFile's. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Thanks, this looks better than the dup way of doing it. Amit

Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [12:15:22], Paolo Bonzini wrote: > > > On 13/07/2015 10:13, pyssl...@ludd.ltu.se wrote: > > Commit 812c1057 introduced HUP detection on unix and tcp sockets prior > > to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2 > > which relied on the old behaviour wher

Re: [Qemu-devel] [PATCH v7 11/42] Return path: socket_writev_buffer: Block even on non-blocking fd's

2015-07-13 Thread Amit Shah
e can safely write to the return path. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 12/42] Migration commands

2015-07-13 Thread Amit Shah
gration process. > > For use in postcopy. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v7 13/42] Return path: Control commands

2015-07-13 Thread Amit Shah
ation > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] ich9: fix skipped vmstate_memhp_state subsection

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [17:45:42], Paulo Alcantara wrote: > By declaring another .subsections array for vmstate_tco_io_state made > vmstate_memhp_state not registered anymore. There must be only one > .subsections array for all subsections. > > Cc: Michael S. Tsirkin > Cc: Amit S

Re: [Qemu-devel] [PATCH 2/2 v2] virtio-rng: Serve pending request if any after timer bumps up quota.

2015-07-14 Thread Amit Shah
On (Tue) 14 Jul 2015 [13:03:10], Pankaj Gupta wrote: > We are arming timer when we get first request from guest. > Even if guest pulls all the data we will be serving guest > only when timer bumps up new quota. When timer expires > we check if we have a pending request from guest, we > serve it

<    5   6   7   8   9   10   11   12   13   14   >