Re: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()

2015-03-23 Thread Andreas Färber
; CPUWatchpoint *wp; Clearly my fault and might explain some breakage in our OBS, Reviewed-by: Andreas Färber afaer...@suse.de Riku, are you queuing this (-rc1 tomorrow!) or should I take it for a CPU pull? Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Andreas Färber
Hi, For consistency in git-log, please use qom: rather than object:. Am 23.03.2015 um 13:06 schrieb Paolo Bonzini: On 23/03/2015 11:36, Peter Crosthwaite wrote: I don't think TypeInfo is the right place for this. You can however define function hooks for Object in ObjectClass. See the

Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl

2015-03-23 Thread Andreas Färber
Hi Lin, Am 23.03.2015 um 11:10 schrieb Lin Ma: Add can_be_deleted callback, If it is not null and returns false, The qmp_object_del won't delete the given object. Signed-off-by: Lin Ma l...@suse.com --- include/qom/object.h | 12 qmp.c| 7 +++

Re: [Qemu-devel] [PATCH] linux-user: fix broken cpu_copy()

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 14:02 schrieb Andreas Färber: Am 23.03.2015 um 13:55 schrieb Leon Alrae: New threads always point at the same env which is incorrect and usually leads Please remember to break after 76 chars. (Look at `git log` output.) Andreas to a crash. Signed-off-by: Leon Alrae leon.al

Re: [Qemu-devel] RFC: memory API changes

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 13:24 schrieb Peter Maydell: * address_space_rw c to be renamed: address_space_rw - as_rw_buf address_space_read - as_read_buf address_space_write - as_write_buf address_space_map - as_map_buf c This is just so the names line up nicely and we have a

Re: [Qemu-devel] RFC: memory API changes

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 16:11 schrieb Peter Maydell: On 23 March 2015 at 14:39, Paolo Bonzini pbonz...@redhat.com wrote: On 23/03/2015 13:24, Peter Maydell wrote: * cpu_physical_memory_rw are obsolete and should be replaced with uses of the as_* functions -- we should at least note this in

[Qemu-devel] [PATCH RFC 3/4] pc: Create sockets and cores for CPUs

2015-03-23 Thread Andreas Färber
Inline realized=true from pc_new_cpu() so that the realization can be deferred, as it would otherwise create a device[n] node. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 66 1 file changed, 58 insertions(+), 8

[Qemu-devel] [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1

2015-03-23 Thread Andreas Färber
: Igor Mammedov imamm...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Peter Maydell peter.mayd...@linaro.org Cc: Bharata B Rao bhar...@linux.vnet.ibm.com Cc: Christian Borntraeger borntrae...@de.ibm.com Andreas Färber (4): cpu: Prepare Socket container type target-i386: Prepare CPU

[Qemu-devel] [PATCH RFC 1/4] cpu: Prepare Socket container type

2015-03-23 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cpu/Makefile.objs| 2 +- hw/cpu/socket.c | 21 + include/hw/cpu/socket.h | 14 ++ 3 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 hw/cpu/socket.c create mode 100644 include/hw

[Qemu-devel] [PATCH RFC 4/4] pc: Create initial CPUs in-place

2015-03-23 Thread Andreas Färber
Inline pc_new_cpu() for the initial setup. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 39 ++- include/hw/i386/cpu-core.h | 3 +++ 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[Qemu-devel] [PATCH RFC 2/4] target-i386: Prepare CPU socket/core abstraction

2015-03-23 Thread Andreas Färber
Short of generic recursive device realization, realize cores and threads recursively. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/Makefile.objs| 1 + hw/i386/cpu-core.c | 45 hw/i386/cpu-socket.c | 45

Re: [Qemu-devel] RFC: memory API changes

2015-03-23 Thread Andreas Färber
Am 23.03.2015 um 15:39 schrieb Paolo Bonzini: On 23/03/2015 13:24, Peter Maydell wrote: The point of indicating failure via MemTxResult is that at some point we need to correct the current broken handling of the CPUClass do_unassigned_access hook, because that should only be invoked if the

Re: [Qemu-devel] [PATCH v3] rcu tests: fix compilation on 32-bit ppc

2015-03-23 Thread Andreas Färber
(-) Tested-by: Andreas Färber afaer...@suse.de Passing these tests now, but running into unrelated qtest failures. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH] rcutorture: fix compilation on 32-bit ppc

2015-03-21 Thread Andreas Färber
--- tests/rcutorture.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) Tested-by: Andreas Färber afaer...@suse.de This lets rcutorture pass, but the same error occurs in test-rcu-list... Btw any reason rcutorture does not fit one of the three naming schemes? Regards

Re: [Qemu-devel] [PATCH v2] rcu tests: fix compilation on 32-bit ppc

2015-03-21 Thread Andreas Färber
Am 21.03.2015 um 19:13 schrieb Paolo Bonzini: 32-bit PPC cannot do atomic operations on long long. Inside the loops, we are already using local counters that are summed at the end of the run---with some exceptions (rcu_stress_count for rcutorture, n_nodes for test-rcu-list): fix them to use

Re: [Qemu-devel] [PATCH for-2.3] linux-user: fix emulation of splice syscall

2015-03-20 Thread Andreas Färber
Am 10.03.2015 um 17:27 schrieb Peter Maydell: On 10 March 2015 at 16:23, Andreas Schwab sch...@suse.de wrote: Peter Maydell peter.mayd...@linaro.org writes: What's changed? Only the title. Please don't drop all the reviewed-by: you got on the first version, then! i.e., Reviewed-by:

Re: [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures

2015-03-20 Thread Andreas Färber
Snow (4): ide: fix cmd_write_pio when nsectors 1 ide: fix cmd_read_pio when nsectors 1 ahci: Fix sglist offset manipulation for BE machines ahci-test: improve rw buffer patterns Confirming that it resolves the observed failure, Tested-by: Andreas Färber afaer...@suse.de Thanks

Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 10:07 schrieb Chen Fan: when I use 'make check' to run the test case. seems failure. GTESTER check-qtest-x86_64 blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' main-loop: WARNING: I/O thread spun for 1000 iterations main-loop: WARNING: I/O thread spun for

Re: [Qemu-devel] [PATCH v3 for-2.3 1/2] numa: introduce machine callback for VCPU to node mapping

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:09 schrieb Igor Mammedov: Current default round-robin way of distributing VCPUs among NUMA nodes might be wrong in case on multi-core/threads CPUs. Making guests confused wrt topology where cores from the same socket are on different nodes. Allow a machine to override

[Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture

2015-03-19 Thread Andreas Färber
Use qtest_add_func() instead of g_test_add_func() to reflect the architecture tested, changing GTester paths as follows: /fw_cfg/foo - /x86_64/fw_cfg/foo etc. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/fw_cfg-test.c | 26 +- 1 file changed, 13 insertions

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:09 schrieb Igor Mammedov: Changes since v2: - fix spelling errors - split out PC hunks itno a separate patch Igor Mammedov (2): numa: introduce machine callback for VCPU to node mapping pc: fix default VCPU to NUMA node mapping Reviewed-by: Andreas Färber afaer

Re: [Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:47 schrieb Andreas Färber: Use qtest_add_func() instead of g_test_add_func() to reflect the architecture tested, changing GTester paths as follows: /fw_cfg/foo - /x86_64/fw_cfg/foo etc. Actually this should even be Cc: qemu-sta...@nongnu.org It's been wrong since

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Andreas Färber
Igor, Some minor nits I overlooked: Am 18.03.2015 um 17:38 schrieb Igor Mammedov: since commit Since :) dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT Linux kernel actually tries to use CPU to Node mapping from QEMU provided SRAT table instead of discarding it, and that

[Qemu-devel] [PATCH] checkrom: Fix typo in error message

2015-03-19 Thread Andreas Färber
increate - increase Signed-off-by: Andreas Färber afaer...@suse.de --- scripts/checkrom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkrom.py b/scripts/checkrom.py index 377277d..aced5e2 100755 --- a/scripts/checkrom.py +++ b/scripts/checkrom.py @@ -39,7

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Andreas Färber
changed, 30 insertions(+), 7 deletions(-) Looks great to me now, the hook name with _socket_id is perfect, Reviewed-by: Andreas Färber afaer...@suse.de but can we do that in three steps please? machine: adding callback and default implementation, numa: switching to use it and pc: overriding the new

Re: [Qemu-devel] [PATCH qemu] target-ppc: Remove never existed POWER5+ v0.0

2015-03-18 Thread Andreas Färber
: 1898.10MHz revision : 2.0 (pvr 003b 0200) I believe 3b 0201 is also something real and it is defined already in QEMU so here is a patch. Yes, I have a 2.1, so having POWER5+ point to it should be fine, it being the latest and now only one we have. Reviewed-by: Andreas Färber afaer

[Qemu-devel] [PULL 3/7] qom: Implement qom-list HMP command

2015-03-17 Thread Andreas Färber
...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13 + hmp.c | 26 ++ hmp.h | 1 + 3 files changed, 40 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 9c1e849..527fa2d 100644 --- a/hmp-commands.hx

[Qemu-devel] [PULL 5/7] qom: Implement info qom-tree HMP command

2015-03-17 Thread Andreas Färber
...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx| 2 ++ include/monitor/qdev.h | 1 + monitor.c | 7 +++ qdev-monitor.c | 57 ++ 4 files changed, 67 insertions(+) diff --git a/hmp-commands.hx

[Qemu-devel] [PULL 4/7] qom: Implement qom-set HMP command

2015-03-17 Thread Andreas Färber
Re-implemented based on qmp_qom_set() to facilitate argument parsing. Warn about ambiguous path arguments. Reviewed-by: Gonglei arei.gong...@huawei.com Tested-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13

[Qemu-devel] [PULL 2/7] scripts: Add qom-tree script

2015-03-17 Thread Andreas Färber
-by: Andreas Färber afaer...@suse.de --- scripts/qmp/qom-tree | 70 1 file changed, 70 insertions(+) create mode 100755 scripts/qmp/qom-tree diff --git a/scripts/qmp/qom-tree b/scripts/qmp/qom-tree new file mode 100755 index 000..aea11d4 --- /dev

[Qemu-devel] [PULL 7/7] qdev: Move owner-less IRQs to /machine/unattached

2015-03-17 Thread Andreas Färber
Move non-qdev-gpio[*] from /machine into /machine/unattached. For the PC this moves 25 nodes from the stable namespace into the unstable. Cc: Peter Crosthwaite peter.crosthwa...@xilinx.com Tested-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PULL 0/7] QOM devices patch queue 2015-03-17

2015-03-17 Thread Andreas Färber
qom-tree HMP command * Cleanups for /machine QOM composition tree Alistair Francis (1): cadence_uart: Convert to QOM realize() Andreas Färber (6): scripts: Add qom-tree script qom: Implement qom-list HMP command

[Qemu-devel] [PULL 1/7] cadence_uart: Convert to QOM realize()

2015-03-17 Thread Andreas Färber
-by: Andreas Färber afaer...@suse.de --- hw/char/cadence_uart.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index 7044b35..a5dc2a4 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -476,18

[Qemu-devel] [PULL 6/7] memory: Move owner-less MemoryRegions to /machine/unattached

2015-03-17 Thread Andreas Färber
-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 20f6d9e..ee3f2a8 100644 --- a/memory.c +++ b/memory.c @@ -868,7 +868,7 @@ void memory_region_init

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 09:39 schrieb Bharata B Rao: On Tue, Mar 17, 2015 at 07:56:41AM +0100, Alexander Graf wrote: On 13.03.15 12:56, Bharata B Rao wrote: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the

Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 10:08 schrieb Chen Fan: ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bus-less CPU+APIC hotplug, handling them in

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Andreas Färber
Am 13.03.2015 um 12:56 schrieb Bharata B Rao: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available index is calculated by counting the existing number of CPUs. This is

Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree

2015-03-17 Thread Andreas Färber
Am 12.03.2015 um 17:43 schrieb Andreas Färber: Andreas Färber (9): scripts: Add qom-tree script qom: Implement qom-list HMP command qom: Implement qom-set HMP command qom: Implement info qom-tree HMP command Applied this half. qapi: Stub out StringOutputVisitor struct support

Re: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 18:04 schrieb Eduardo Habkost: On Tue, Mar 17, 2015 at 05:46:36PM +0100, Andreas Färber wrote: [...] @@ -1054,7 +1055,12 @@ void pc_hot_add_cpu(const int64_t id, Error **errp) icc_bridge = DEVICE(object_resolve_path_type(icc-bridge

[Qemu-devel] [PULL 0/3] QOM CPUState patch queue 2015-03-17

2015-03-17 Thread Andreas Färber
Andreas Färber (2): pc: Suppress APIC ID compatibility warning for QTest tests: Add PC CPU test Eduardo Habkost (1): target-i386: Remove icc_bridge parameter from cpu_x86_create() hw/i386/pc.c| 19 +-- target-i386/cpu.c

[Qemu-devel] [PULL 1/3] pc: Suppress APIC ID compatibility warning for QTest

2015-03-17 Thread Andreas Färber
This avoids cluttering GTester output with irrelevant warnings. Cc: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b5b2aad..642105f 100644

[Qemu-devel] [PULL 2/3] tests: Add PC CPU test

2015-03-17 Thread Andreas Färber
, and test for graceful failure otherwise. Cc: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- tests/Makefile | 2 + tests/pc-cpu-test.c | 147 2 files changed, 149 insertions(+) create mode 100644 tests

[Qemu-devel] [PULL 3/3] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-17 Thread Andreas Färber
() is called. But this shouldn't make any difference, as property setters shouldn't depend on icc_bridge. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 16 target

Re: [Qemu-devel] [PATCH for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 17:42 schrieb Eduardo Habkost: On Tue, Mar 17, 2015 at 03:48:38PM +, Igor Mammedov wrote: since commit dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT Linux kernel actually tries to use CPU to Node mapping from QEMU provided SRAT table instead of

[Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus

2015-03-17 Thread Andreas Färber
pc_new_cpu() into its callers. The APIC operations on the last CPU in pc_cpus_init() are still potentially insecure, but that is beyond the scope of this code movement. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v3 1/1] char: cadence_uart: Convert to realize()

2015-03-16 Thread Andreas Färber
Am 17.03.2015 um 00:19 schrieb Alistair Francis: On Sat, Feb 28, 2015 at 6:52 PM, Alistair Francis alistair.fran...@xilinx.com wrote: On Sat, Feb 28, 2015 at 3:59 AM, Andreas Färber afaer...@suse.de wrote: Am 27.02.2015 um 02:48 schrieb Alistair Francis: Use the DeviceClass realize() and init

[Qemu-devel] [PATCH for-2.3 1/2] pc: Suppress APIC ID compatibility warning for QTest

2015-03-16 Thread Andreas Färber
This avoids cluttering GTester output with irrelevant warnings. Cc: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c756404..4b46c29 100644

[Qemu-devel] [PATCH for-2.3 2/2] tests: Add PC CPU test

2015-03-16 Thread Andreas Färber
, and test for graceful failure otherwise. Cc: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- tests/Makefile | 2 + tests/pc-cpu-test.c | 147 2 files changed, 149 insertions(+) create mode 100644 tests

[Qemu-devel] [PATCH for-2.3 0/2] qtest: Add tests for x86 PC cpu-add

2015-03-16 Thread Andreas Färber
-default model and monotonic cpu-add via QMP for 1.5+ and graceful error handling otherwise. Regards, Andreas Cc: Eduardo Habkost ehabk...@redhat.com Cc: Zhu Guihua zhugh.f...@cn.fujitsu.com Cc: Chen Fan chen.fan.f...@cn.fujitsu.com Cc: Peter Maydell peter.mayd...@linaro.org Andreas Färber (2): pc

Re: [Qemu-devel] [RFC PATCH] target-ppc: Register CPU class per family only when needed

2015-03-16 Thread Andreas Färber
Am 16.03.2015 um 05:58 schrieb Alexey Kardashevskiy: On 03/06/2015 12:17 AM, Alexander Graf wrote: On 05.03.15 02:56, Alexey Kardashevskiy wrote: At the moment when running in KVM mode, QEMU registers host class to match the current CPU PVR value. It also registers another CPU class with a

Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first function call successfully

2015-03-15 Thread Andreas Färber
Am 15.03.2015 um 15:19 schrieb Chen Gang: If no additional reply of this thread within 3 days, I shall send a new patch which will include system call implementation. Please use a proper subject then, saying what it does (rather what works afterwards). In particular don't forget target-tilegx:.

Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

2015-03-14 Thread Andreas Färber
Am 13.03.2015 um 20:45 schrieb Eduardo Habkost: On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas Färber wrote: Only thing that comes to mind is whether it might make sense to hierarchically make Broadwell the parent type of Broadwell-noTSX, to avoid duplication. But then again we already have

Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

2015-03-13 Thread Andreas Färber
Am 13.03.2015 um 20:09 schrieb Eduardo Habkost: With the Intel microcode update that removed HLE and RTM, there will be different kinds of Haswell and Broadwell CPUs out there: some that still have the HLE and RTM features, and some that don't have the HLE and RTM features. On both cases

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-12 Thread Andreas Färber
Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote: Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: Make it safe to include hw/boards.h in exec.c for linux-user configurations. We don't need any of its contents though. Signed

[Qemu-devel] [PATCH v2 4/9] qom: Implement info qom-tree HMP command

2015-03-12 Thread Andreas Färber
To complement qdev's bus-oriented info qtree, info qom-tree prints a hierarchical view of the QOM composition tree. By default, the machine composition tree is shown. This can be overriden by supplying a path argument, such as info qom-tree /. Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree

2015-03-12 Thread Andreas Färber
Capitulino lcapitul...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Markus Armbruster arm...@redhat.com Cc: Eric Blake ebl...@redhat.com Cc: Peter Crosthwaite peter.crosthwa...@xilinx.com Andreas Färber (9): scripts: Add qom-tree script qom: Implement qom-list HMP command qom: Implement qom

[Qemu-devel] [PATCH v2 7/9] qom: Add verbose option to info qom-tree HMP command

2015-03-12 Thread Andreas Färber
It lists object properties, as equivalent to what info qtree displays. Cc: Hani Benhabiles h...@linux.com Signed-off-by: Andreas Färber afaer...@suse.de --- monitor.c | 6 +++--- qdev-monitor.c | 49 ++--- 2 files changed, 45 insertions(+), 10

[Qemu-devel] [PATCH v2 1/9] scripts: Add qom-tree script

2015-03-12 Thread Andreas Färber
Functionally it is a recursive qom-list with qom-get per non-child property. Some failures needed to be handled, such as trying to read a pointer property, which is not representable in QMP. Those print a literal EXCEPTION. Signed-off-by: Andreas Färber afaer...@suse.de --- scripts/qmp/qom-tree

[Qemu-devel] [PATCH v2 5/9] qapi: Stub out StringOutputVisitor struct support

2015-03-12 Thread Andreas Färber
Avoid a segfault when visiting, e.g., the QOM rtc-time property, by implementing the struct callbacks and raising an Error. Signed-off-by: Andreas Färber afaer...@suse.de --- qapi/string-output-visitor.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/string-output

[Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command

2015-03-12 Thread Andreas Färber
Implement it as a wrapper for QMP qom-list, but mimic the behavior of scripts/qmp/qom-list in making the path argument optional and listing the root if absent, to hint users what kind of path to pass. Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13 + hmp.c

[Qemu-devel] [PATCH v2 3/9] qom: Implement qom-set HMP command

2015-03-12 Thread Andreas Färber
Re-implemented based on qmp_qom_set() to facilitate argument parsing. Warn about ambiguous path arguments. Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13 + hmp.c | 21 + hmp.h | 1 + 3 files changed, 35 insertions

[Qemu-devel] [PATCH v2 9/9] qdev: Move owner-less IRQs to /machine/unattached

2015-03-12 Thread Andreas Färber
Move non-qdev-gpio[*] from /machine into /machine/unattached. For the PC this moves 25 nodes from the stable namespace into the unstable. Cc: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/core/qdev.c | 5 +++-- 1 file changed, 3 insertions

[Qemu-devel] [PATCH v2 6/9] qom: Implement qom-get HMP command

2015-03-12 Thread Andreas Färber
Reimplement it based on qmp_qom_get() to avoid converting QObjects back to strings. Inspired-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13 + hmp.c | 22 ++ hmp.h | 1 + 3 files

[Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached

2015-03-12 Thread Andreas Färber
This cleans up the official /machine namespace. In particular /machine/system and /machine/io as well as entries with non-sanitized node names. Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached

2015-03-12 Thread Andreas Färber
Am 12.03.2015 um 19:05 schrieb Paolo Bonzini: On 12/03/2015 17:43, Andreas Färber wrote: This cleans up the official /machine namespace. In particular /machine/system and /machine/io as well as entries with non-sanitized node names. Just a question: isn't it /machine/system[0] and /machine

Re: [Qemu-devel] [PATCH] exec: don't include hw/boards for linux-user

2015-03-11 Thread Andreas Färber
Am 11.03.2015 um 07:58 schrieb Michael S. Tsirkin: As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code. Include it conditionally, and drop the (now unnecessary) ifdef guards in hw/boards.h Reported-by: Andreas Färber afaer...@suse.de Cc: Peter Maydell peter.mayd

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-11 Thread Andreas Färber
Am 11.03.2015 um 09:56 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote: Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: Hi, Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: Fixes

Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-11 Thread Andreas Färber
Am 11.03.2015 um 12:11 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 11:43:41PM +0100, Andreas Färber wrote: Am 10.03.2015 um 22:57 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
x86_cpu_parse_featurestr() is called. But this shouldn't make any difference, as property setters shouldn't depend on icc_bridge. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Looks okay to me, Reviewed-by: Andreas Färber afaer...@suse.de But using this smaller patch will still make inlining pc_new_cpu

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 14:24 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 01:51:26PM +0100, Andreas Färber wrote: Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is that icc_bridge attachment will now be done after

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-10 Thread Andreas Färber
Hi, Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: Fixes a QEMU crash when passing dump_guest_core parameter in command line. Explain that, please? Signed-off-by: Marcel Apfelbaum mar...@redhat.com --- exec.c | 4 ++-- hw/core/machine.c | 6 ++ include/hw/boards.h

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: Make it safe to include hw/boards.h in exec.c for linux-user configurations. We don't need any of its contents though. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Already on my tree as Marcel's patches needed this. Why? Which

Re: [Qemu-devel] [PATCH 0/4] cpu: Make cpu_init() return QOM object

2015-03-10 Thread Andreas Färber
Am 27.02.2015 um 15:40 schrieb Andreas Färber: Hi Eduardo, Am 26.02.2015 um 21:37 schrieb Eduardo Habkost: This series changes cpu_init() to return a CPU QOM object, and changes existing arch-specific code to use the corresponding arch-specific function instead of cpu_init

Re: [Qemu-devel] [PATCH 4/4] cpu: Make cpu_init() return QOM object

2015-03-10 Thread Andreas Färber
Am 26.02.2015 um 21:37 schrieb Eduardo Habkost: Instead of making cpu_init() return CPUArchState, return a CPU object. [snip] In file included from /home/andreas/QEMU/qemu-cpu/include/exec/cpu-all.h:26:0, from /home/andreas/QEMU/qemu-cpu/target-alpha/cpu.h:296,

Re: [Qemu-devel] [PATCH 4/4] cpu: Make cpu_init() return QOM object

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 17:16 schrieb Andreas Färber: Am 26.02.2015 um 21:37 schrieb Eduardo Habkost: Instead of making cpu_init() return CPUArchState, return a CPU object. [snip] In file included from /home/andreas/QEMU/qemu-cpu/include/exec/cpu-all.h:26:0, from /home/andreas

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 14:30 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 02:22:01PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU

Re: [Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 21:50 schrieb John Snow: On 02/24/2015 01:09 PM, John Snow wrote: On 02/24/2015 11:34 AM, Marc Marí wrote: The MSIX interrupt was always acked without checking its value, which caused a race condition. If the ISR was raised between the read and the acking, the ISR was never

[Qemu-devel] [PULL 3/6] target-unicore32: Make uc32_cpu_init() return UniCore32CPU

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost ehabk...@redhat.com This way, the cpu_init() function in target-unicore32 will follow the same pattern used on all other architectures. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-unicore32/cpu.h| 14

[Qemu-devel] [PULL 5/6] unicore32: Use uc32_cpu_init()

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost ehabk...@redhat.com Instead of using the legacy cpu_init() function, use uc32_cpu_init() to create a UniCore32CPU object. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Cc: Guan Xuetao g...@mprc.pku.edu.cn Signed-off-by: Andreas Färber afaer...@suse.de --- hw/unicore32

[Qemu-devel] [PULL 2/6] target-i386: Clean up misuse of qdev_init() in realize method

2015-03-10 Thread Andreas Färber
of the three possible APIC device models. Clean up by cutting out the qdev_init() middle-man: set property realized directly. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/cpu.c | 8

[Qemu-devel] [PULL 4/6] m68k: Use cpu_m68k_init()

2015-03-10 Thread Andreas Färber
From: Eduardo Habkost ehabk...@redhat.com Instead of using the legacy cpu_init() function, use cpu_m68k_init() directly to create a M68kCPU object. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/m68k/dummy_m68k.c | 6 -- 1 file

[Qemu-devel] [PULL 0/6] QOM CPUState patch queue 2015-03-10

2015-03-10 Thread Andreas Färber
Hello Peter, This is my QOM CPU patch queue. Please pull. Regards, Andreas Cc: Peter Maydell peter.mayd...@linaro.org Cc: Eduardo Habkost ehabk...@redhat.com The following changes since commit 1976058109890892db8ec88bfd3273f79c459f6b: Merge remote-tracking branch

[Qemu-devel] [PULL 1/6] cpu: Add missing documentation for some CPUClass methods

2015-03-10 Thread Andreas Färber
-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 12 1 file changed, 12 insertions(+) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 48fd6fb..d6279c0 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -82,6

[Qemu-devel] [PULL 6/6] cpu: Make cpu_init() return QOM CPUState object

2015-03-10 Thread Andreas Färber
...@imgtec.com Cc: Anthony Green gr...@moxielogic.com Cc: Jia Liu pro...@gmail.com Cc: Alexander Graf ag...@suse.de Cc: Bastian Koppelmann kbast...@mail.uni-paderborn.de Cc: Max Filippov jcmvb...@gmail.com [AF: Fixed up cpu_copy() manually] Signed-off-by: Andreas Färber afaer...@suse.de --- bsd-user

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: Hi, Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: Fixes a QEMU crash when passing dump_guest_core parameter in command line. Explain that, please? Pls note the submission

Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 22:57 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is that icc_bridge attachment will now be done after

Re: [Qemu-devel] [PATCH 6/6] target-i386: Call cpu_exec_init() on realize

2015-03-05 Thread Andreas Färber
Am 05.03.2015 um 17:42 schrieb Igor Mammedov: On Thu, 5 Mar 2015 12:38:50 -0300 Eduardo Habkost ehabk...@redhat.com wrote: To allow new code to ask the CPU classes for CPU model information and allow QOM properties to be queried by qmp_device_list_properties(), we need to be able to safely

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-05 Thread Andreas Färber
Am 05.03.2015 um 14:37 schrieb Eduardo Habkost: On Thu, Mar 05, 2015 at 01:32:02AM +0100, Andreas Färber wrote: Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore

Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-05 Thread Andreas Färber
ehabk...@redhat.com This patch is holding the rest of the series, so a Reviewed-by or Acked-by would be welcome. This change removes the 254-CPU limit from {i386,x86_64}-linux-user that Peter and I discussed previously. Reviewed-by: Andreas Färber afaer...@suse.de Are you going to send a new

Re: [Qemu-devel] [PATCH v4 5/5] target-i386: Require APIC ID to be explicitly set before CPU realize

2015-03-04 Thread Andreas Färber
(+), 1 deletion(-) Reviewed-by: Andreas Färber afaer...@suse.de Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-04 Thread Andreas Färber
Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that code can be moved to pc.c. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Andreas Färber

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-04 Thread Andreas Färber
Am 04.03.2015 um 14:49 schrieb Michael S. Tsirkin: On Wed, Mar 04, 2015 at 02:12:32PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 13:11:48 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Mar 03, 2015 at 09:33:51PM +0100, Igor Mammedov wrote: On Tue, 3 Mar 2015 18:35:39 +0100

Re: [Qemu-devel] [PATCH 0/2] target-i386: Small code cleanup

2015-03-04 Thread Andreas Färber
Am 04.03.2015 um 13:28 schrieb Eduardo Habkost: On Tue, Feb 03, 2015 at 04:08:56PM -0200, Eduardo Habkost wrote: Just two small code cleanups in target-i386/cpu.c. Patch 1/2 changes behavior of -cpu ? to not print feature names in reverse order anymore. Patch 2/2 doesn't introduce any

Re: [Qemu-devel] [PATCH] Revert target-ppc: Create versionless CPU class per family if KVM

2015-03-04 Thread Andreas Färber
Am 03.03.2015 um 23:14 schrieb Alexey Kardashevskiy: On 03/04/2015 07:43 AM, Alexander Graf wrote: On 03.03.15 01:42, Alexey Kardashevskiy wrote: On 03/03/2015 12:51 AM, Alexander Graf wrote: On 02.03.15 14:42, Andreas Färber wrote: Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15

Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id

2015-03-04 Thread Andreas Färber
Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: The field doesn't need to be inside CPUState, and it is not specific for You mean CPUX86State or CPUArchState, I guess. :) the CPUID instruction, so move and rename it. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH] target-ppc: Add versions to server CPU descriptions

2015-03-04 Thread Andreas Färber
Alex, Am 04.03.2015 um 13:28 schrieb Alexander Graf: On 04.03.15 02:31, Alexey Kardashevskiy wrote: 5b79b1c target-ppc: Create versionless CPU class per family if KVM added a dynamic CPU class registration with the name of the CPU family which QEMU is running on. For example, this allowed

Re: [Qemu-devel] [PATCH] Revert target-ppc: Create versionless CPU class per family if KVM

2015-03-02 Thread Andreas Färber
Am 02.03.2015 um 14:51 schrieb Alexander Graf: On 02.03.15 14:42, Andreas Färber wrote: Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15 01:31, Andreas Färber wrote: This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avoid double-registration of types: Registering

Re: [Qemu-devel] [PATCH] Revert target-ppc: Create versionless CPU class per family if KVM

2015-03-02 Thread Andreas Färber
Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15 01:31, Andreas Färber wrote: This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avoid double-registration of types: Registering `POWER5+-powerpc64-cpu' which already exists Taking the textual description of a CPU type

<    3   4   5   6   7   8   9   10   11   12   >