[Qemu-devel] [PATCH RFC qom-cpu 2/4] qemu-common.h: Move fprintf_function to qemu-types.h

2012-12-18 Thread Andreas Färber
This avoids a dependency on qemu-common.h from qemu/cpu.h. Signed-off-by: Andreas Färber --- include/qemu/cpu.h |2 +- qemu-common.h |5 - qemu-types.h |6 ++ 3 Dateien geändert, 7 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/include/qemu/cpu.h b

[Qemu-devel] [PATCH qom-cpu 0/4] CPU cleanup and PPC subclasses

2012-12-18 Thread Andreas Färber
d Henderson Cc: Peter Maydell Cc: Alexander Graf Cc: qemu-ppc Cc: David Gibson Andreas Färber (4): cpu: Introduce CPUListState struct qemu-common.h: Move fprintf_function to qemu-types.h target-ppc: Slim conversion of model definitions to QOM subclasses target-ppc: Error out for -cpu host

Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-12-18 Thread Andreas Färber
Am 12.12.2012 10:44, schrieb Jan Kiszka: > On 2012-11-19 15:24, Jan Kiszka wrote: >> See patches for details. >> >> Jan Kiszka (2): >> i2c: Introduce device address mask >> Add AT24Cxx I2C EEPROM device model >> >> hw/Makefile.objs |2 +- >> hw/at24.c| 363 >>

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:03, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: >> On Tue, 18 Dec 2012 14:29:21 -0200 >> Eduardo Habkost wrote: >> >>> Signed-off-by: Eduardo Habkost >>> --- >>> target-i386/cpu.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 del

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 16:59, schrieb Igor Mammedov: > On Tue, 18 Dec 2012 08:53:40 +0100 > Andreas Färber wrote: > >> This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for >> each target. >> >> Signed-off-by: Andreas Färber >&

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:42, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas Färber wrote: >> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h >> index 61b7698..5fbb3f9 100644 >> --- a/include/qemu/cpu.h >> +++ b/include/qemu/cpu.h >&

Re: [Qemu-devel] [PATCH 03/11] qom: preserve object while unparenting it

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > Avoid that the object disappears after it's deleted from the QOM > composition tree, in case that was the only reference to it. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products Gm

Re: [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > CPUs are never added to the composition tree, so delete is achieved > simply by removing the last references to them. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Note however that x86 is undergoing major changes and o

Re: [Qemu-devel] [PATCH 01/11] qdev: export and use qbus_init

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > BusState subclasses need to do their own allocation because > qbus_create_inplace calls object_initialize (which wipes out the > "free" callback). This patch separates the initialization of the object > (object_initialize) from its insertion in the qde

Re: [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > Add missing braces and break lines larger than 80 chars. > > Signed-off-by: Eduardo Habkost Thanks, applied to qom-cpu queue: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, >containing: >- Property types: drive, chr, netdev

Re: [Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Andreas Färber
Am 18.12.2012 21:03, schrieb Eduardo Habkost: > This is just a proof of concept, of how I think we could gradually move to > make the architectures share CPU creation/initialization code. > > I have implemented a quick cpu_realize() function, just for testing, while we > don't have qdev realizefn

Re: [Qemu-devel] [PATCH qom-cpu v2 4/5] target-alpha: Turn CPU definitions into subclasses

2012-12-18 Thread Andreas Färber
Am 09.12.2012 02:40, schrieb Andreas Färber: > Make TYPE_ALPHA_CPU abstract and add types -alpha-cpu. > Use type inheritence, and turn "2*" models into aliases. > > Move cpu_alpha_init() to cpu.c and split out CPU realization. > Default to creating type "ev67-alpha-c

Re: [Qemu-devel] [RFC 09/20] cpu: introduce cpu_realize()

2012-12-18 Thread Andreas Färber
Am 18.12.2012 21:04, schrieb Eduardo Habkost: > This is just for testing/demonstration purposes. Probably this will be > replaced by the more generic DeviceState realize() method, later. > > Signed-off-by: Eduardo Habkost Such a function was nack'ed for Object, the reason being that the goal was

[Qemu-devel] [PATCH] qemu-jeos: Update .gitmodules

2012-12-18 Thread Andreas Färber
sources.redhat.com is timing out, use sourceware.org URL instead. Signed-off-by: Andreas Färber --- .gitmodules |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/.gitmodules b/.gitmodules index d975cd0..a64bf93 100644 --- a/.gitmodules +++ b/.gitmodules

Re: [Qemu-devel] [PATCH v2 00/11] QOM CPUState, part 6: CPU_COMMON for KVM

2012-12-18 Thread Andreas Färber
Am 16.12.2012 01:13, schrieb Andreas Färber: > Here's a rebased version of the series moving KVM-specific fields from > CPU*State struct (CPU_COMMON macro) to QOM CPUState and avoiding use of > CPU*State in KVM's API. > > There was no review feedback on v1, which I'

[Qemu-devel] [PATCH qom-cpu v2] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for each target. Place it in cpu-common.h to avoid circular dependencies. Signed-off-by: Andreas Färber Cc: Eduardo Habkost Cc: Igor Mammedov --- cpu-common.h | 12 target-alpha/cpu.c |9

Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of model definitions to QOM subclasses

2012-12-18 Thread Andreas Färber
Am 18.12.2012 08:53, schrieb Andreas Färber: > +static gint ppc_cpu_compare_class_name(gconstpointer a, gconstpointer b) > +{ > +ObjectClass *oc = (ObjectClass *)a; > +const char *name = b; > > -return NULL; > +if (strncasecmp(name, object_class_get_name(oc

[Qemu-devel] [PATCH 20/20] MAINTAINERS: Include X86CPU in CPU maintenance area

2012-12-19 Thread Andreas Färber
Document that the x86 CPU refactorings are going through the qom-cpu tree. This does not contradict the established practice that patches adding KVM features to the x86 CPU go through the KVM maintainers, it merely takes it out of target-i386 TCG's Odd Fixes status. Signed-off-by: Andreas F

[Qemu-devel] [PATCH 11/20] kvm: Pass CPUState to kvm_vcpu_ioctl()

2012-12-19 Thread Andreas Färber
Adapt helper functions to pass X86CPU / PowerPCCPU / S390CPU. Signed-off-by: Andreas Färber --- hw/kvm/apic.c | 10 +-- hw/kvm/clock.c |2 +- hw/ppc.c |2 +- hw/s390-virtio-bus.c | 12 ++-- hw/spapr.c |2 +- kvm

[Qemu-devel] [PATCH 08/20] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-19 Thread Andreas Färber
many dependencies. The copyright/license of qdev-properties.c isn't explicitly stated at the file, so add a simple copyright/license header pointing to the commit ID of the original file. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/Makefile.objs|1

[Qemu-devel] [PATCH 05/20] target-alpha: Add support for -cpu ?

2012-12-19 Thread Andreas Färber
Implement alphabetical listing of CPU subclasses. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- target-alpha/cpu.c | 41 + target-alpha/cpu.h |2 ++ 2 Dateien geändert, 43 Zeilen hinzugefügt(+) diff --git a/target-alpha/cpu.c b

[Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-19

2012-12-19 Thread Andreas Färber
cpu.git qom-cpu for you to fetch changes up to 62e0c095450f6a7eb37914991f3f7966aa4da7a1: MAINTAINERS: Include X86CPU in CPU maintenance area (2012-12-19 14:09:32 +0100) -------- Andreas Färber (18): target-alpha: Let cpu_alpha_init()

[Qemu-devel] [PATCH 12/20] ppc: Pass PowerPCCPU to ppc_set_irq()

2012-12-19 Thread Andreas Färber
Adapt static caller functions. This cleans up after passing PowerPCCPU to kvmppc_set_interrupt(). Signed-off-by: Andreas Färber --- hw/ppc.c | 66 ++-- hw/ppc.h |2 +- hw/ppc_booke.c | 28 3

[Qemu-devel] [PATCH 18/20] cpu: Move kvm_state field into CPUState

2012-12-19 Thread Andreas Färber
Adapt some functions to take CPUState / {PowerPC,S390}CPU argument. Signed-off-by: Andreas Färber --- cpu-defs.h |2 -- include/qemu/cpu.h |3 +++ kvm-all.c | 28 ++-- kvm.h |4 ++-- target-i386/cpu.c |7 +-- target

[Qemu-devel] [PATCH 19/20] cpu: Move kvm_run into CPUState

2012-12-19 Thread Andreas Färber
Pass CPUState / {X86,S390}CPU to helper functions. Signed-off-by: Andreas Färber --- cpu-defs.h |4 +-- include/qemu/cpu.h |2 ++ kvm-all.c |8 +++--- target-i386/kvm.c |9 +++--- target-s390x/kvm.c | 77 5

[Qemu-devel] [PATCH 04/20] target-alpha: Turn CPU definitions into subclasses

2012-12-19 Thread Andreas Färber
Make TYPE_ALPHA_CPU abstract and add types -alpha-cpu. Use type inheritence, and turn "2*" models into aliases. Move cpu_alpha_init() to cpu.c and split out CPU realization. Default to creating type "ev67-alpha-cpu" as before. Signed-off-by: Andreas Färber Acked-b

[Qemu-devel] [PATCH 02/20] alpha: Pass AlphaCPU array to Typhoon

2012-12-19 Thread Andreas Färber
Also store it in TyphoonCchip. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- hw/alpha_dp264.c | 18 +- hw/alpha_sys.h |2 +- hw/alpha_typhoon.c | 29 - 3 Dateien geändert, 26 Zeilen hinzugefügt(+), 23 Zeilen entfernt

[Qemu-devel] [PATCH 16/20] ppc4xx_devs: Return PowerPCCPU from ppc4xx_init()

2012-12-19 Thread Andreas Färber
Prepares for passing PowerPCCPU to ppc_booke_timers_init(). Signed-off-by: Andreas Färber --- hw/ppc405_uc.c |8 ++-- hw/ppc4xx.h |6 +++--- hw/ppc4xx_devs.c |8 3 Dateien geändert, 13 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/ppc405_uc.c b/hw

[Qemu-devel] [PATCH 01/20] target-alpha: Let cpu_alpha_init() return AlphaCPU

2012-12-19 Thread Andreas Färber
Replace cpu_init() macro with inline function for backwards compatibility. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --- target-alpha/cpu.h | 13 +++-- target-alpha/translate.c |4 ++-- 2 Dateien geändert, 13 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff

[Qemu-devel] [PATCH 03/20] target-alpha: Avoid leaking the alarm timer over reset

2012-12-19 Thread Andreas Färber
Move the timer from CPUAlphaState to AlphaCPU to avoid the pointer being zero'ed once we implement reset. Would cause a segfault in sys_helper.c:helper_set_alarm(). This also simplifies timer initialization in Typhoon. Signed-off-by: Andreas Färber Acked-by: Richard Henderson --

[Qemu-devel] [PATCH 07/20] qdev: Coding style fixes

2012-12-19 Thread Andreas Färber
From: Eduardo Habkost Add missing braces and break lines larger than 80 chars. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/qdev-properties.c | 53 +- hw/qdev.c|3 ++- 2 Dateien geändert, 37 Zeilen

[Qemu-devel] [PATCH 15/20] ppc_booke: Pass PowerPCCPU to {decr, fit, wdt} timer callbacks

2012-12-19 Thread Andreas Färber
Cleans up after passing PowerPCCPU to booke_update_irq(). Signed-off-by: Andreas Färber --- hw/ppc_booke.c | 23 ++- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c index da6bc4a..5748063 100644 --- a/hw

[Qemu-devel] [PATCH 14/20] ppc: Pass PowerPCCPU to [h]decr timer callbacks

2012-12-19 Thread Andreas Färber
Cleans up after passing PowerPCCPU to [h]decr exception callbacks. Signed-off-by: Andreas Färber --- hw/ppc.c | 18 ++ 1 Datei geändert, 10 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git a/hw/ppc.c b/hw/ppc.c index b1b93a1..8c05eb3 100644 --- a/hw/ppc.c +++ b/hw/ppc.c

[Qemu-devel] [PATCH 10/20] kvm: Pass CPUState to kvm_arch_*

2012-12-19 Thread Andreas Färber
Move kvm_vcpu_dirty field into CPUState to simplify things and change its type to bool while at it. Signed-off-by: Andreas Färber --- cpu-defs.h |3 +-- include/qemu/cpu.h |1 + kvm-all.c | 75 ++-- kvm.h

[Qemu-devel] [PATCH 09/20] cpu: Move kvm_fd into CPUState

2012-12-19 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpu-defs.h |1 - include/qemu/cpu.h |5 + kvm-all.c |8 +--- 3 Dateien geändert, 10 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/cpu-defs.h b/cpu-defs.h index 3669241..6373a80 100644 --- a/cpu-defs.h +++ b/cpu

[Qemu-devel] [PATCH 06/20] cpu: Introduce CPUListState struct

2012-12-19 Thread Andreas Färber
This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for each target. Place it in cpu-common.h to avoid circular dependencies. Signed-off-by: Andreas Färber Reviewed-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- cpu-common.h | 12 target-alpha/cpu.c

[Qemu-devel] [PATCH 17/20] ppc_booke: Pass PowerPCCPU to ppc_booke_timers_init()

2012-12-19 Thread Andreas Färber
Cleans up after passing PowerPCCPU to timer callbacks. Signed-off-by: Andreas Färber --- hw/ppc.h |2 +- hw/ppc/e500.c |2 +- hw/ppc405_uc.c |2 +- hw/ppc440_bamboo.c |2 +- hw/ppc_booke.c |5 ++--- hw/virtex_ml507.c |2 +- 6 Dateien geändert, 7

[Qemu-devel] [PATCH qom-cpu 4/7] cpu: Move cpu_index field to CPUState

2012-12-19 Thread Andreas Färber
Note that target-alpha accesses this field from TCG, now using a negative offset. Therefore the field is placed last in CPUState. Pass PowerPCCPU to [kvm]ppc_fixup_cpu() to facilitate this change. Move common parts of mips cpu_state_reset() to mips_cpu_reset(). Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH 13/20] ppc: Pass PowerPCCPU to [h]decr callbacks

2012-12-19 Thread Andreas Färber
Cleans up after passing PowerPCCPU to ppc_set_irq(). Signed-off-by: Andreas Färber --- hw/ppc.c | 60 +--- 1 Datei geändert, 33 Zeilen hinzugefügt(+), 27 Zeilen entfernt(-) diff --git a/hw/ppc.c b/hw/ppc.c index 6db595f..b1b93a1 100644

[Qemu-devel] [PATCH qom-cpu 0/7] QOM CPUState, part 7: CPU_COMMON for topology

2012-12-19 Thread Andreas Färber
]ppc_fixup_cpu() signatures, - drops kvmppc_host_cpu_def(), - splits cpu_ppc_register_internal() into initfn and realizefn. Regards, Andreas Cc: Anthony Liguori Cc: Alexander Graf Cc: Aurélien Jarno Cc: Igor Mammedov Cc: Eduardo Habkost Andreas Färber (7): cpu: Move nr_{cores,threads

[Qemu-devel] [PATCH qom-cpu 3/7] cpu: Move numa_node field to CPUState

2012-12-19 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpu-defs.h |1 - cpus.c |4 +++- exec.c |4 +--- hw/spapr.c |4 +++- include/qemu/cpu.h |2 ++ monitor.c |4 +++- 6 Dateien geändert, 12 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff

Re: [Qemu-devel] [PATCH] MAINTAINERS: Avi has left

2012-12-19 Thread Andreas Färber
Am 14.12.2012 19:41, schrieb Andreas Färber: > For the kernel, Avi removed himself from their maintainers list. > In QEMU such a change was so far not yet applied, and the Red Hat mail > server says "Mailbox disabled for this recipient". So avoid his address > getting cc&#

[Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation

2012-12-19 Thread Andreas Färber
This function will be touched again soon, so a good understanding of env vs. other helps. Adopt gtk-doc style. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 14 +- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/target-mips/op_helper.c b

[Qemu-devel] [PATCH qom-cpu 6/7] xen: Simplify halting of first CPU

2012-12-19 Thread Andreas Färber
Use the global first_cpu variable to halt the CPU rather than using a local first_cpu initialized from qemu_get_cpu(0). This will allow to change qemu_get_cpu() return type to CPUState despite use of the CPU_COMMON halted field in the reset handler. Signed-off-by: Andreas Färber --- xen-all.c

[Qemu-devel] [PATCH qom-cpu 5/7] kvm: Pass CPUState to kvm_init_vcpu()

2012-12-19 Thread Andreas Färber
CPUArchState is no longer needed, and it thereby no longer depends on NEED_CPU_H. Signed-off-by: Andreas Färber --- cpus.c |2 +- kvm-all.c |3 +-- kvm-stub.c |2 +- kvm.h |5 +++-- 4 Dateien geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/cpus.c

[Qemu-devel] [PATCH qom-cpu 7/7] exec: Return CPUState from qemu_get_cpu()

2012-12-19 Thread Andreas Färber
Move the declaration to qemu/cpu.h and add documentation. The implementation still depends on CPUArchState for CPU iteration. Signed-off-by: Andreas Färber --- cpu-all.h |1 - exec.c |6 +++--- hw/pxa2xx_gpio.c|2 +- include/qemu/cpu.h

[Qemu-devel] [PATCH qom-cpu 1/7] cpu: Move nr_{cores, threads} fields to CPUState

2012-12-19 Thread Andreas Färber
Pass MIPSCPU to malta_mips_config(); avoid that for mips_cpu_map_tc() since callers only access MIPS Thread Contexts, inside TCG helpers. Signed-off-by: Andreas Färber --- cpu-defs.h |2 -- cpus.c |4 ++-- hw/mips_malta.c |9 ++--- include

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-19 Thread Andreas Färber
Am 19.12.2012 16:46, schrieb Gleb Natapov: > > Replace Avi with myself as kvm maintainer. > > Signed-off-by: Gleb Natapov That solves my mail bounce issue, too. If you put yourself as main KVM maintainer in Avi's place, note that I received zero feedback from Marcelo on my CPU series, which I

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-19 Thread Andreas Färber
Am 19.12.2012 17:33, schrieb Marcelo Tosatti: > On Wed, Dec 19, 2012 at 05:00:40PM +0100, Andreas Färber wrote: >> Am 19.12.2012 16:46, schrieb Gleb Natapov: >>> >>> Replace Avi with myself as kvm maintainer. >>> >>> Signed-off-by: Gleb Natapov

Re: [Qemu-devel] [PATCH 11/20] target-i386: do not set vendor_override in x86_cpuid_set_vendor()

2012-12-19 Thread Andreas Färber
Am 19.12.2012 18:38, schrieb Eduardo Habkost: > On Mon, Dec 17, 2012 at 05:01:23PM +0100, Igor Mammedov wrote: >> commit d480e1af which introduced vendor property was setting >> env->cpuid_vendor_override = 1, which prevents using vendor property >> on its own without triggering vendor override. >>

Re: [Qemu-devel] [PATCH] MAINTAINERS: Take over kvm maintenance

2012-12-19 Thread Andreas Färber
Am 19.12.2012 20:12, schrieb Marcelo Tosatti: > On Wed, Dec 19, 2012 at 08:05:10PM +0100, Andreas Färber wrote: >> I'm also surprised that there's been no KVM pull since v1.3 - are you >> expecting Anthony to pick up KVM'ish patches himself now? Otherwise, >> so

Re: [Qemu-devel] trying to use -cpu qemu64, +hv_relaxed , get CPU feature hv_relaxed not found

2012-12-21 Thread Andreas Färber
Hi, Am 21.12.2012 11:47, schrieb Alexandre DERUMIER: > I'm trying to pass hyper-v feature, with -cpu qemu64,+hv_relaxed (qemu 1.3) > but I got an > > "CPU feature hv_relaxed not found" > > > Does this require an specific host kernel or host cpu feature support ? I believe it's -cpu qemu64,h

Re: [Qemu-devel] [PATCH 2/2] xen: add missing include

2012-12-21 Thread Andreas Färber
Am 20.12.2012 12:29, schrieb Paolo Bonzini: > xen-all needs to access CharDeviceState's filename field, so > it needs to include char/char.h. > > Signed-off-by: Paolo Bonzini Tested-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germ

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-19

2012-12-22 Thread Andreas Färber
Am 22.12.2012 13:08, schrieb Blue Swirl: > On Wed, Dec 19, 2012 at 1:36 PM, Andreas Färber wrote: >> Hello, >> >> This is my current QOM CPU patch queue. Please pull. > > It conflicts with HEAD, please rebase. Merged on git://repo.or.c

Re: [Qemu-devel] [PATCH v3] qemu-kvm/pci-assign: 64 bits bar emulation

2012-12-23 Thread Andreas Färber
Am 20.12.2012 04:07, schrieb Xudong Hao: > Enable 64 bits bar emulation. > > v3 changes from v2: > - Leave original error string and drop the leading 016. > > v2 changes from v1: > - Change 0lx% to 0x%016 when print a 64 bit variable. > > Test pass with the current seabios which already support

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Andreas Färber
Hello, Am 02.01.2013 05:58, schrieb Samuel Seay: > Attached is a patch for fixing bug #1052857. My local tests show it > working properly on 32 and 64bit. > > Signed-off-by: Samuel Seay > Please submit patches using git-send-email tool so that they arrive text-only

Re: [Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs

2013-01-02 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > diff --git a/stubs/vmstate.c b/stubs/vmstate.c > new file mode 100644 > index 000..badf79e > --- /dev/null > +++ b/stubs/vmstate.c > @@ -0,0 +1,17 @@ > +#include "qemu-common.h" > +#include "vmstate.h" Needed to update this to "migration/vmstate.

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2013-01-02 Thread Andreas Färber
Am 14.12.2012 18:21, schrieb Eduardo Habkost: > On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas Färber wrote: >> Waiting for ack or nack from Paolo here. I am expecting some overlap >> with his header file reorganization series. >> >> My previous (unanswered?) ques

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

2013-01-02 Thread Andreas Färber
Am 02.01.2013 15:08, schrieb Anthony Liguori: > fred.kon...@greensocs.com writes: > >> From: KONRAD Frederic >> >> Add a max_dev field to BusState to specify the maximum amount of devices >> allowed >> on the bus ( have no effect if max_dev=0 ) >> >> Signed-off-by: KONRAD Frederic >> --- >> hw

Re: [Qemu-devel] [PATCH 1/2] target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features

2013-01-02 Thread Andreas Färber
Am 28.12.2012 19:37, schrieb Eduardo Habkost: > The existing -cpu host code simply set every bit inside svm_features > (initializing it to -1), and that makes it impossible to make the > enforce/check options work properly when the user asks for SVM features > explicitly in the command-line. > > S

Re: [Qemu-devel] [PATCH 0/2] Fixes for -cpu host KVM/SVM feature initialization

2013-01-02 Thread Andreas Färber
Am 28.12.2012 19:37, schrieb Eduardo Habkost: > This series has two very similar fixes for feature initizliation for "-cpu > host". This should allow us to make the check/enforce code check for host > support of KVM and SVM features, later. I am out of my field here to verify whether this is seman

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2013-01-02 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This finally makes the CPU class a child of DeviceState, allowing us to > start using DeviceState properties on CPU subclasses. To avoid confusion with child<> properties and DeviceState vs. DeviceClass I have reworded this to "subclass of Device" in

Re: [Qemu-devel] [RFC 0/8] Remove old_portio usage

2013-01-02 Thread Andreas Färber
Am 23.12.2012 16:32, schrieb Hervé Poussineau: > These proposed patches aim at removing the .old_portio member of > MemoryRegionOps structure, and replacing their usage by .read/.write > handlers. > > Patches 2 to 6 are already ready to be committed. In lack of a memory maintainer, I'll volunteer

Re: [Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-03 Thread Andreas Färber
Hi, Am 02.01.2013 20:17, schrieb Christoffer Dall: > I am seeing some brutal crashes with QEMU running virtio using KVM/ARM. > > The culprit seems to be when the process runs out of virtual address > space on 32-bit systems due to some subsystem (virtio?) creating a > large number of pthreads und

Re: [Qemu-devel] [PATCH 0/8] CPU DeviceState v10

2013-01-03 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > Eduardo Habkost (8): [...] > libqemustub: Add qemu_[un]register_reset() stubs > libqemustub: vmstate register/unregister stubs > libqemustub: sysbus_get_default() stub [...] > include qdev code into *-user, too > qom: Make CPU a child of Dev

Re: [Qemu-devel] [PATCH prep for-1.4? v2 1/2] prep_pci: Create PCIBus and PCIDevice in-place

2013-01-24 Thread Andreas Färber
Am 16.01.2013 16:11, schrieb Andreas Färber: > +static void raven_pcihost_finalizefn(Object *obj) > +{ > +PREPPCIState *s = RAVEN_PCI_HOST_BRIDGE(obj); > + > +object_unref(OBJECT(&s->pci_bus)); > +object_unref(OBJECT(&s->pci_dev)); > } [snip] For

[Qemu-devel] [PATCH prep for-1.4 v3 2/2] prep_pci: Convert to QOM realizefn

2013-01-24 Thread Andreas Färber
ization at DeviceState-level is implemented. Signed-off-by: Andreas Färber --- hw/prep_pci.c |8 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index e1420ca..52ee5d9 100644 --- a/hw/prep_pci.c +++ b/hw/prep_pci.c @@ -11

[Qemu-devel] [PATCH prep for-1.4 v3 1/2] prep_pci: Create PCIBus and PCIDevice in-place

2013-01-24 Thread Andreas Färber
Prepares for QOM realizefn by removing object creation from qdev initfn. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 50 +- 1 Datei geändert, 37 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index

[Qemu-devel] [PATCH prep for-1.4 v3 0/2] prep_pci: Prepare for QOM realize

2013-01-24 Thread Andreas Färber
iguori Cc: Paolo Bonzini Cc: Markus Armbruster Cc: Alexander Graf Cc: Hervé Poussineau Andreas Färber (2): prep_pci: Create PCIBus and PCIDevice in-place prep_pci: Convert to QOM realizefn hw/prep_pci.c | 56 1 Datei geändert, 40 Zei

[Qemu-devel] [PATCH for-1.4 v4 10/12] adb: QOM'ify Apple Desktop Bus

2013-01-24 Thread Andreas Färber
It was not a qbus before, turn it into a first-class bus and initialize it properly from CUDA. Leave it a global variable as long as devices are not QOM'ified yet. Signed-off-by: Andreas Färber --- hw/adb.c | 14 ++ hw/adb.h | 16 +--- hw/cuda.c |3 +

[Qemu-devel] [PATCH for-1.4 v4 02/12] macio: QOM'ify some more

2013-01-24 Thread Andreas Färber
Move bar MemoryRegion initialization to an instance_init. Signed-off-by: Andreas Färber --- hw/macio.c | 25 +++-- 1 Datei geändert, 19 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/hw/macio.c b/hw/macio.c index f01fc57..770e3bd 100644 --- a/hw/macio.c +++ b/hw

[Qemu-devel] [PATCH for-1.4 v4 07/12] mac_nvram: QOM'ify MacIO NVRAM

2013-01-24 Thread Andreas Färber
It was not qdev'ified before. Turn it into a SysBusDevice and initialize it via static properties. Prepare Old World specific MacIO state and embed the NVRAM state there. Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or direct use of Memory API. Signed-off-by: Andreas F

[Qemu-devel] [PATCH for-1.4 v4 11/12] adb: QOM'ify ADB devices

2013-01-24 Thread Andreas Färber
d and mouse off into their own files is left for a later point in time. Signed-off-by: Andreas Färber --- hw/adb.c | 244 - hw/adb.h | 31 +-- hw/ppc/mac_newworld.c |6 +- hw/ppc/mac_oldworld.c |6 +- 4 Da

Re: [Qemu-devel] [PATCH V2 1/6] trivial: etraxfs_eth: Eliminate checkpatch errors

2013-01-24 Thread Andreas Färber
c: Anthony Liguori > Cc: Andreas Färber > Signed-off-by: Grant Likely In the future please don't prefix patches with "trivial: " - if they're truely trivial and the code is unmaintained (i.e., not in this case) you should cc qemu-triv...@nongnu.org instead. "

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-24 Thread Andreas Färber
Am 24.01.2013 05:02, schrieb Richard Henderson: > target-i386/cpu.c | 18 +- > target-i386/cpu.h | 24 +- You forgot to CC me: Please point me to where in those 57 patches you are touching the core CPU code. Given the size of the series I assume this is 1.5

[Qemu-devel] [PATCH for-1.4 v4 01/12] ppc: Move Mac machines to hw/ppc/

2013-01-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cuda.c |2 +- hw/grackle_pci.c |2 +- hw/heathrow_pic.c |2 +- hw/ide/macio.c|6 +++--- hw/mac_nvram.c

[Qemu-devel] [PATCH for-1.4 v4 12/12] cuda: Move ADB bus into CUDA state

2013-01-24 Thread Andreas Färber
Replace the global adb_bus with a CUDA-internal one, accessed using regular qdev child bus accessor. Signed-off-by: Andreas Färber --- hw/adb.h |1 - hw/cuda.c |8 +++- hw/ppc/mac.h |2 ++ hw/ppc/mac_newworld.c |7 +-- hw/ppc

[Qemu-devel] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro

2013-01-24 Thread Andreas Färber
It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined. Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert references to logfile/loglevel to use qemu_log*() macros). Cc: Eduardo Habkost Signed-off-by: Andreas Färber --- target-cris/helper.c|

[Qemu-devel] [PATCH for-1.4 v4 00/12] target-ppc: MacIO QOM'ification

2013-01-24 Thread Andreas Färber
#x27;s. Cc: Alexander Graf Cc: qemu-ppc Cc: Markus Armbruster Cc: Kevin Wolf Cc: Hervé Poussineau Cc: Paolo Bonzini Cc: Mark Cave-Ayland (FYI: ADB conversion) Andreas Färber (12): ppc: Move Mac machines to hw/ppc/ macio: QOM'ify some more macio: Delay qdev init until all fie

[Qemu-devel] [PATCH for-1.4 v4 08/12] ide/macio: QOM'ify MacIO IDE

2013-01-24 Thread Andreas Färber
It was not qdev'ified before. Turn it into a SysBusDevice. Embed them into the MacIO devices. Signed-off-by: Andreas Färber Cc: Markus Armbruster --- hw/ide.h |4 -- hw/ide/macio.c| 78 ++--- hw/macio.c|

Re: [Qemu-devel] [Qemu-stable] [PATCH] Revert "serial: fix retry logic"

2013-01-24 Thread Andreas Färber
Am 22.01.2013 12:01, schrieb Michael Tokarev: > Ping^3? > > This issue is still present in qemu 1.3 and current git (1.4-tobe) > versions, > and the said commit is still revertable, and reverting it still fixes the > problem... > > I wonder why only debian users suffer from this problem ;) It wa

[Qemu-devel] [PATCH for-1.4 v4 04/12] macio: Split MacIO in two

2013-01-24 Thread Andreas Färber
Let the machines create two different types. This prepares to move knowledge about sub-devices from the machines into the devices. Signed-off-by: Andreas Färber --- hw/macio.c| 97 +++-- hw/ppc/mac.h | 10 +++-- hw/ppc

[Qemu-devel] [PATCH for-1.4 v4 03/12] macio: Delay qdev init until all fields are initialized

2013-01-24 Thread Andreas Färber
This turns macio_bar_setup() into an implementation detail of the qdev initfn, to be removed step by step. Signed-off-by: Andreas Färber --- hw/macio.c | 11 --- 1 Datei geändert, 8 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/hw/macio.c b/hw/macio.c index 770e3bd

[Qemu-devel] [PATCH for-1.4 v4 09/12] cuda: QOM'ify CUDA

2013-01-24 Thread Andreas Färber
It was not qdev'ified before. Turn it into a SysBusDevice and embed it in MacIO. Signed-off-by: Andreas Färber --- hw/cuda.c | 95 + hw/macio.c| 43 ++ hw/ppc/mac.h |

[Qemu-devel] [PATCH for-1.4 v4 06/12] mac_nvram: Mark as Big Endian

2013-01-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/mac_nvram.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/hw/mac_nvram.c b/hw/mac_nvram.c index bcde07d..0a22e66 100644 --- a/hw/mac_nvram.c +++ b/hw/mac_nvram.c @@ -96,7 +96,7 @@ static uint64_t macio_nvram_readb(void

[Qemu-devel] [PATCH for-1.4 v4 05/12] mac_nvram: Clean up public API

2013-01-24 Thread Andreas Färber
The state data field is accessed in uint8_t quantities, so switch from uint32_t argument and return value to uint8_t. Fix debug format specifiers while at it. Signed-off-by: Andreas Färber --- hw/mac_nvram.c | 21 ++--- hw/ppc/mac.h |4 ++-- 2 Dateien geändert, 12

Re: [Qemu-devel] [PATCH for-1.4] target-cris: Fix typo in D_LOG() macro

2013-01-24 Thread Andreas Färber
Am 24.01.2013 10:51, schrieb Andreas Färber: > It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined. __VA_ARGS__ obviously. :) Please fix when committing. Andreas > > Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert > references to lo

Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints

2013-01-24 Thread Andreas Färber
Am 24.01.2013 11:32, schrieb Markus Armbruster: > Peter Lieven writes: > >> Latest git doesn't compile with this patch: >> >> hw/fw_cfg.c: In function 'fw_cfg_write': >> hw/fw_cfg.c:207:5: error: implicit declaration of function >> trace_fw_cfg_write' [-Werror=implicit-function-declaration] >> hw

Re: [Qemu-devel] [A cry for sanity]: make_device_config.sh: Fix target path in generated dependency file

2013-01-24 Thread Andreas Färber
23:31, mdroth wrote: >> On Sat, Oct 27, 2012 at 12:32:28PM +0400, Michael Tokarev wrote: >>> Ping? >> >> Ping. >> >> Fix still applicable for 1.3, also looking to pull it in for 1.2.2. >> >>> >>> /mjt >>> >>> On 18.09.20

Re: [Qemu-devel] [PATCH] s390: Add default support for SCLP console

2013-01-24 Thread Andreas Färber
Am 24.01.2013 12:23, schrieb Alexander Graf: > The current s390 machine uses the virtio console as default console, > but this doesn't mean that we always want to keep it that way for new > machines. > > This patch introduces a way for a machine type to specify that it wants > the default console

Re: [Qemu-devel] [PATCH 08/11] s390: Add new channel I/O based virtio transport.

2013-01-24 Thread Andreas Färber
Am 24.01.2013 13:28, schrieb Cornelia Huck: > Add a new virtio transport that uses channel commands to perform > virtio operations. > > Signed-off-by: Cornelia Huck > > --- > > v5 -> v6: > - Get rid of qemu_get_ram_ptr usage > - Adapt to virtual css changes > - Constify TypeInfos > - Prepare fo

Re: [Qemu-devel] [PATCH 08/11] s390: Add new channel I/O based virtio transport.

2013-01-24 Thread Andreas Färber
Am 24.01.2013 15:42, schrieb Cornelia Huck: > On Thu, 24 Jan 2013 14:18:10 +0100 > Andreas Färber wrote: > > Forgot one point :) > >>> +/* DeviceState to VirtioCcwData. Note: used on datapath, >>> + * be careful and test performance if you change this. >>

Re: [Qemu-devel] [PATCH 2/2] s390: Add s390-ccw-virtio machine.

2013-01-24 Thread Andreas Färber
Am 24.01.2013 16:29, schrieb Cornelia Huck: > +machine_init(ccw_machine_init); Alex, can you drop the semicolon when applying please? :) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-01-24 Thread Andreas Färber
`basename` to strip the directory path. Reported-by: Gerhard Wiesinger Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- scripts/make_device_config.sh |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/scripts/make_device_config.sh b/scripts

Re: [Qemu-devel] [PATCH] s390: Add default support for SCLP console

2013-01-24 Thread Andreas Färber
Am 24.01.2013 13:44, schrieb Alexander Graf: > > On 24.01.2013, at 13:37, Andreas Färber wrote: > >> Am 24.01.2013 12:23, schrieb Alexander Graf: >>> @@ -4060,6 +4106,8 @@ int main(int argc, char **argv, char **envp) >>> exit(1); >>>

Re: [Qemu-devel] [PATCH v2] s390: Add default support for SCLP console

2013-01-24 Thread Andreas Färber
gt; the default console to be an SCLP console, which is a lot closer to what > real hardware does. > > Signed-off-by: Alexander Graf Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 46/57] target-i386: Implement ANDN

2013-01-24 Thread Andreas Färber
Am 24.01.2013 05:03, schrieb Richard Henderson: > As this is the first of the BMI insns to be implemented, > this carries quite a bit more baggage than normal. > > Signed-off-by: Richard Henderson > --- > target-i386/cpu.c | 10 +- > target-i386/translate.c | 19 +--

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-24 Thread Andreas Färber
Am 17.01.2013 21:13, schrieb Blue Swirl: > On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi wrote: >> Tell me what you consider the "correct" tab width for readers and I'll >> find a piece of QEMU code that was authored for a different tab width >> :). > > 8. So FWIW one exception is target-cris

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-01-24 Thread Andreas Färber
Am 24.01.2013 17:17, schrieb Richard Henderson: > On 2013-01-24 01:35, Andreas Färber wrote: >> Am 24.01.2013 05:02, schrieb Richard Henderson: >>> target-i386/cpu.c | 18 +- >>> target-i386/cpu.h | 24 +- >> >>

<    4   5   6   7   8   9   10   11   12   13   >