CLZERO CPUID should be passed on to the guests that use EPYC or EPYC-IBPB CPU
model when the AMD ZEN based host supports it. This change makes it recognize
this CPUID for guests which use EPYC or EPYC-IBPB CPU model.
Signed-off-by: Ani Sinha
---
target/i386/cpu.c | 2 ++
1 file changed, 2
Hi :
Can I get some love for this patch?
thanks
ani
On Dec 4, 2019, 3:06 PM +0530, Ani Sinha , wrote:
CLZERO CPUID should be passed on to the guests that use EPYC or EPYC-IBPB CPU
model when the AMD ZEN based host supports it. This change makes it recognize
this CPUID for guests which use EPYC
Hi :
I am looking at a patch where we disable TOPOEXT when -cpu host or -cpu max is
passed to qemu :
if (cpu->max_features) {
for (w = 0; w < FEATURE_WORDS; w++) {
/* Override only features that weren't set explicitly
* by the user.
*/
env->features[w] |=
Hi :
I am looking at a patch where we disable TOPOEXT when -cpu host or -cpu max is
passed to qemu :
if (cpu->max_features) {
for (w = 0; w < FEATURE_WORDS; w++) {
/* Override only features that weren't set explicitly
* by the user.
*/
env->features[w] |=
Hi :
I am looking at a patch where we disable TOPOEXT when -cpu host or -cpu max is
passed to qemu :
if (cpu->max_features) {
for (w = 0; w < FEATURE_WORDS; w++) {
/* Override only features that weren't set explicitly
* by the user.
*/
env->features[w] |=
CLZERO CPUID should be passed on to the guests that use EPYC or EPYC-IBPB CPU
model when the AMD ZEN based host supports it. This change makes it recognize
this CPUID for guests which use EPYC or EPYC-IBPB CPU model.
Signed-off-by: Ani Sinha
---
target/i386/cpu.c | 2 ++
1 file changed, 2
Ping …
> On Dec 18, 2019, at 5:23 PM, Paolo Bonzini wrote:
>
> On 18/12/19 10:05, Ani Sinha wrote:
>> CLZERO CPUID should be passed on to the guests that use EPYC or EPYC-IBPB CPU
>> model when the AMD ZEN based host supports it. This change makes it recognize
>>
> On Feb 6, 2020, at 5:30 AM, Moger, Babu wrote:
>
> Ani, I am already working on it.
Wow, I see a whole new AMD-Rome CPU model with it’s own cache info data :
https://lore.kernel.org/qemu-devel/157314966312.23828.17684821666338093910.st...@naples-babu.amd.com/
Thanks!
ani
> On Feb 6, 2020, at 11:16 AM, Ani Sinha wrote:
>
>
>
>> On Feb 6, 2020, at 5:30 AM, Moger, Babu wrote:
>>
>> Ani, I am already working on it.
>
> Wow, I see a whole new AMD-Rome CPU model with it’s own cache info data :
>
Sorry Eduardo, it took a little while for me to get to this thread again.
> On Dec 18, 2019, at 8:41 PM, Eduardo Habkost wrote:
>
> On Wed, Dec 18, 2019 at 12:53:45PM +0100, Paolo Bonzini wrote:
>> On 18/12/19 10:05, Ani Sinha wrote:
>>> CLZERO CPUID should be passed o
> On Dec 22, 2019, at 1:45 PM, Paolo Bonzini wrote:
>
>
>
> Il dom 22 dic 2019, 08:49 Ani Sinha ha scritto:
>
> Ping …
>
> Why ping? You got questions from Eduardo, so you need to answer them and/or
> send a fixed version of the patch.
>
Maybe he resp
> On Dec 23, 2019, at 1:44 PM, Ani Sinha wrote:
>
>
>
>> On Dec 22, 2019, at 1:45 PM, Paolo Bonzini wrote:
>>
>>
>>
>> Il dom 22 dic 2019, 08:49 Ani Sinha ha scritto:
>>
>> Ping …
>>
>> Why ping? You got question
+Laine
> On Apr 17, 2020, at 9:39 PM, Michael S. Tsirkin wrote:
>
> Problem is, I think this is not something we can support with pcie or shpc.
> I'm reluctant to add features that only ACPI can support,
> we are trying to phase that out.
Hmm. I see. We use conventional PCI and hence was
vices from being hot plugged into the
guest.
The patch is initial version and is a rough implementation. It has
been tested on Windows guests.
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 3 +++
hw/i386/acpi-build.c | 40 ++--
2 files changed, 29
> On Apr 17, 2020, at 8:57 PM, Michael S. Tsirkin wrote:
>
> Is there a real reason to do this? Can't we just limit the
> hotplug control to pcie ports? At some point I'd like us to
> start leaving piix alone..
Yes we really need this feature as want to be able to hot plug devices into the
Hi Igor:
> On Mar 24, 2020, at 7:47 PM, Igor Mammedov wrote:
>
> if you are interested in hacking ACPI PCI hotplug more, look at how
> build_append_pci_bus_devices() works
I am trying to disable hot unplug of a device on PCI-PCI bridge without
removing the capability to hot plug. Will it be
+Julia who implemented https://patchwork.kernel.org/patch/1131/
> On Apr 18, 2020, at 3:26 AM, Laine Stump wrote:
>
> On 4/17/20 12:35 PM, Ani Sinha wrote:
>> +Laine
>>> On Apr 17, 2020, at 9:39 PM, Michael S. Tsirkin wrote:
>>>
>>> Proble
> On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin wrote:
>
> But I for one would like to focus on keeping PIIX stable
> and focus development on q35. Not bloating PIIX with lots of new
> features is IMHO a good way to do that.
Does this mean this patch is a no-go then? :(
> On Apr 20, 2020, at 8:34 PM, Ani Sinha wrote:
>
>
>
>> On Apr 18, 2020, at 6:18 PM, Marcel Apfelbaum
>> wrote:
>>
>> A PCIe Root Port or a PCI slot can or cannot support hot-plugging. Anything
>> in the middle can't be done at PCIe/PCI lev
> On Apr 20, 2020, at 2:54 PM, Daniel P. Berrangé wrote:
>
> From the upstream POV, there's been no decision / agreement to phase
> out PIIX, this is purely a RHEL downstream decision & plan. If other
> distros / users have a different POV, and find the feature useful, we
> should accept the
> On Apr 18, 2020, at 6:18 PM, Marcel Apfelbaum
> wrote:
>
> Hi Ani,
>
> On 4/18/20 6:25 AM, Ani Sinha wrote:
>> +Julia who implemented
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_1131_=DwICaQ=s883GpUCOChKOHiocYtG
> On Apr 18, 2020, at 6:18 PM, Marcel Apfelbaum
> wrote:
>
> A PCIe Root Port or a PCI slot can or cannot support hot-plugging. Anything
> in the middle can't be done at PCIe/PCI level (as far as I know).
Is it possible to dynamically set PCI_EXP_SLTCAP_HPC for a slot at runtime?
> On Apr 25, 2020, at 12:14 AM, Eduardo Habkost wrote:
>
> On Fri, Apr 24, 2020 at 03:23:56PM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 22, 2020, at 4:15 PM, Ani Sinha wrote:
>>>
>>>
>>>
>>>> On Apr 21, 2020, at 8:32
On Tue, Apr 28, 2020 at 9:51 PM Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2020 at 09:39:16PM +0530, Ani Sinha wrote:
> >
> > Ani
> > On Apr 28, 2020, 21:35 +0530, Michael S. Tsirkin ,
> wrote:
> >
> > On Tue, Apr 28, 2020 at 10:16:52AM +, Ani Sinha
Ani
On Apr 28, 2020, 21:35 +0530, Michael S. Tsirkin , wrote:
> On Tue, Apr 28, 2020 at 10:16:52AM +0000, Ani Sinha wrote:
> > A new option "use_acpi_unplug" is introduced for PIIX which will
> > selectively only disable hot unplugging of both hot plugged and
> >
> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:11:20AM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>>>
>>> o if there's a need to disable
>>&g
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> For example, how about hot-plugging a bridge which doesn't
> support hotplug itself?
So now for every device we want to hot plug, we will add a new bridge? Sounds
not a scalable and elegant idea.
> Would that happen to make
> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:54:52AM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 06:11:20AM +, An
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> o if there's a need to disable
> just one of these, commit log needs to do a better job documenting the
> usecase.
The use case is simple. With this feature admins will be able to do what they
were forced to do from Windows
On Wed, Apr 29, 2020 at 2:15 AM Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2020 at 10:10:18PM +0530, Ani Sinha wrote:
> >
> >
> > On Tue, Apr 28, 2020 at 9:51 PM Michael S. Tsirkin
> wrote:
> >
> > On Tue, Apr 28, 2020 at 09:39:16PM +0530, Ani
> On Apr 22, 2020, at 4:15 PM, Ani Sinha wrote:
>
>
>
>> On Apr 21, 2020, at 8:32 PM, Daniel P. Berrangé wrote:
>>
>> On Tue, Apr 21, 2020 at 02:45:04PM +, Ani Sinha wrote:
>>>
>>>
>>>> On Apr 20, 2020, at 8:32 PM, Mi
> On Apr 21, 2020, at 8:32 PM, Daniel P. Berrangé wrote:
>
> On Tue, Apr 21, 2020 at 02:45:04PM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin wrote:
>>>
>>> But I for one would like to focus on keep
.
Accidental? So maybe what you need is actually something else then -
avoid *removing* the device when it's powered down.
You don’t get it. It is not hypervisor admins who are unplugging it. It is
the end users. Even RedHat customers want this feature. See following
resources:
+julie
+ laine
Rebased patch to latest Qemu master. Only minimal changes.
> On Apr 28, 2020, at 3:46 PM, Ani Sinha wrote:
>
> A new option "use_acpi_unplug" is introduced for PIIX which will
> selectively only disable hot unplugging of both hot plugged and
> cold p
vices from being hot plugged into the
guest.
It has been tested on Windows guests.
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 3 +++
hw/i386/acpi-build.c | 40 ++--
2 files changed, 29 insertions(+), 14 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/
> On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote:
>
> Even if it seems to work for guests now, if we don't stick to emulating
> capabilities that hardware interfaces provide we can never be sure it
> will keep working.
OS es use ACPI for PCI bridges:
> On Apr 29, 2020, at 2:44 PM, Anirban Sinha wrote:
>
>
> Note that “these control methods are optional” line. If the OS adheres to the
> spec, it should not expect them to exist all the time
Linux for example, detects it here:
> On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 07:02:56AM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 06:54:52AM +, An
> On Apr 29, 2020, at 1:39 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 07:43:04AM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 07:02:56AM +, An
> On Apr 29, 2020, at 3:45 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 09:14:26AM +0000, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 2:26 PM, Michael S. Tsirkin wrote:
>>>
>>> Even if it seems to work for guests now,
>>>
>>> Yes. So if there's no _EJx then it's reasonable to assume you can't
>>> isolate the slot, and so no hot-plug will happen either.
>>
>> Where are you getting that?
>
> It's well known. For example, the pci hot-plug specification, version
> 1.1, states:
>
> 1.6 Asssumptions
>
> ...
>
> On May 12, 2020, at 12:23 AM, Igor Mammedov wrote:
>
>>
>> static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus,
>> - bool pcihp_bridge_en)
>> + bool pcihp_bridge_en,
>> +
> On Apr 29, 2020, at 9:02 PM, Igor Mammedov wrote:
>
> On Fri, 24 Apr 2020 14:44:48 -0400
> Eduardo Habkost wrote:
>
>> On Fri, Apr 24, 2020 at 03:23:56PM +, Ani Sinha wrote:
>>>
>>>
>>>> On Apr 22, 2020, at 4:15 PM, Ani Sinha wrot
> On May 14, 2020, at 1:13 AM, Igor Mammedov wrote:
>
>>
>>
>>> Will following hack work for you?
>>> possible permutations
>>> 1) ACPI hotplug everywhere
>>> -global PIIX4_PM.acpi-pci-hotplug=on -global
>>> PIIX4_PM.acpi-pci-hotplug-with-bridge-support=on -device
>>>
Fixed the build breakage. Sorry for breaking the build.
on Windows 2016.
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 18 --
hw/i386/acpi-build.c | 46 ++
2 files changed, 42 insertions(+), 22 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 964d6f5..91b7e86 100644
---
on Windows 2016.
Change-Id: I6a79f5c69dab2c06fc3578b098bf085fb8741ce6
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 19 ---
hw/i386/acpi-build.c | 46 ++
2 files changed, 42 insertions(+), 23 deletions(-)
diff --git a/hw/acpi/pi
Igor, here’s my attempt in cooking up a patch which disabled global ACPI hot
plug.
You said something about SHPC also adding AMLs when enabled but I could not
figure out where that is being done.
Please provide suggestions.
> On May 15, 2020, at 3:36 PM, Ani Sinha wrote:
>
> A n
> On Mar 24, 2020, at 4:38 PM, Igor Mammedov wrote:
>
> question is do you need to disable only unplug side both
> (plug+unplug) operations (like we did with PCIE)?
I need to disable the unplug side only.
Ani
> On Mar 24, 2020, at 7:47 PM, Igor Mammedov wrote:
>
> if you are interested in hacking ACPI PCI hotplug more, look at how
> build_append_pci_bus_devices() works
Cool. Will keep digging while stuck at home :-)
A
> On Mar 24, 2020, at 7:39 PM, Igor Mammedov wrote:
>
> disable acpi pci hotplug globally for VM
This sounds like a good idea for our needs.
A
@igor Did you get a chance to look?
On May 15, 2020, 22:57 +0530, Ani Sinha , wrote:
> A new option "acpi-pci-hotplug" is introduced for PIIX which will
> globally disable hot-plugging of both hot plugged and
> cold plugged PCI devices. This will prevent
> hot-pluggi
On Fri, Aug 28, 2020 at 3:19 PM Igor Mammedov wrote:
>
> On Thu, 27 Aug 2020 23:29:34 +0530
> Ani Sinha wrote:
>
> > On Thu, Aug 27, 2020 at 11:11 PM Igor Mammedov wrote:
> > >
> > > On Thu, 27 Aug 2020 09:40:34 -0400
> > > "Michael
Arg0 & 0x4000))
-{
-Notify (SF0, Arg1)
-}
-
-If ((Arg0 & 0x8000))
-{
-Notify (SF8, Arg1)
-}
-}
-
Method (PCNT, 0, NotSerialized)
on the latest upstream master branch HEAD because there seems
to be an issue
with the latest upstream tip with qemu crashing consistently.
Thanks to Igor for pushing on this.
--Ani
Ani Sinha (3):
tests/acpi: document addition of table DSDT.roothp for unit testing
root pci hotplug on/off
tests
t bus")
This change documents the fact that this new file addition was made as a part
of the
unit test change.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/b
ter branch on top of tag
v5.1.0.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index d49b3988ec..8f7d87c0f6 100644
--- a/tests/qtest/bios-tables-te
34548.html
In this patch, we fix the issue in this function by checking if the bus which is
returned by the function is actually hotpluggable. If not, we simply return
NULL.
This avoids the scenario where we were returning a non-hotpluggable bus.
This patch is based off of tag v5.10
Signed-off-by:
.c:162
162if (!qbus_is_hotpluggable(BUS(find.bus))) {
(gdb) p find.bus
$1 = (PCIBus *) 0x0
I will submit a rework soon.
On Thu, Sep 3, 2020 at 3:55 PM Ani Sinha wrote:
>
> When ACPI hotplug for the root bus is disabled, the bsel property for that
> bus is not set. Please see the following commit
On Sat, Sep 5, 2020 at 4:05 PM Ani Sinha wrote:
>
> The following patchset adds the unit test for the change:
> f80ba9e599 ("tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
> bridge flag")
Apologies. This change is incorrect. It should be :
e78c1c9a2e (&q
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for
testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under
i440fx.
This change documents this fact.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1
-1779,22 +1299,21 @@
If ((Arg0 & 0x4000))
{
Notify (SF0, Arg1)
}
If ((Arg0 & 0x8000))
{
Notify (SF8, Arg1)
}
}
Method (PCNT, 0, NotSerialized)
Notify (SF8, Arg1)
}
}
Method (PCNT, 0, NotSerialized)
{
BNUM = Zero
DVNT (PCIU, One)
DVNT (PCID, 0x03)
-^S18.PCNT ()
}
}
}
}
Signed-off-by: Ani
of tag v5.1.0
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index a2c0070306..e52a36e775 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest
I have seen that when hotplug for pci bridge devices are turned off and devices
are attached
behind the bridge, I still see Windows trying to hot remove the pci bridge and
failing. Today
looking at the AML disassembly, I realized that we are addding slot enumeration
and EJ0
methods even for the
2012R2 guest image running on Ubuntu host.
This
change is based off of upstream qemu master branch tag v5.1.0.
Signed-off-by: Ani Sinha
---
hw/i386/acpi-build.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index
Can someone please review this?
On Aug 29, 2020, 13:42 +0530, Ani Sinha , wrote:
> When ACPI hotplug for the root bus is disabled, the bsel property for that
> bus is not set. Please see the following commit:
>
> 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotpl
On Fri, Aug 28, 2020 at 6:40 PM Julia Suvorova wrote:
>
> On Fri, Aug 28, 2020 at 11:53 AM Ani Sinha wrote:
> >
> >
> > Ani
> > On Aug 28, 2020, 15:19 +0530, Igor Mammedov , wrote:
> >
> > On Thu, 27 Aug 2020 23:29:34 +0530
> >
> > Ani Sinh
On Tue, Sep 1, 2020 at 8:39 PM Ani Sinha wrote:
>
> A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order
> to unit test hotplug on/off capability on the root pci bus for i440fx.
> The diff between the table DSDT.bridge and DSDT.roothp is listed below:
>
&
On Tue, Sep 1, 2020 at 11:57 AM Ani Sinha wrote:
>
> On Fri, Aug 28, 2020 at 6:40 PM Julia Suvorova wrote:
> >
> > On Fri, Aug 28, 2020 at 11:53 AM Ani Sinha wrote:
> > >
> > >
> > > Ani
> > > On Aug 28, 2020, 15:19 +0530, Igor Mammedov ,
.
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 6 --
hw/i386/acpi-build.c | 10 --
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index e6163bb6ce..b70b1f98af 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -596,8 +596,10
This is a RFC patch. This patch attempts to disable all acpi hotplug related
hardware
initialization and amls when hotplug for both pci root port and pci bridges are
disabled on i440fx machines.
Thanks for looking at it and please provide comments. I will add unit tests
when the final
patch is
> On Aug 31, 2020, at 2:27 AM, Michael S. Tsirkin wrote:
>
> On Thu, Aug 27, 2020 at 11:29:34PM +0530, Ani Sinha wrote:
>>> On Thu, Aug 27, 2020 at 11:11 PM Igor Mammedov wrote:
>>>
>>> On Thu, 27 Aug 2020 09:40:34 -0400
>>> "Mic
Please provide comments for this patch.
On Sep 1, 2020, 15:20 +0530, Ani Sinha , wrote:
> When acpi hotplug is turned off for both root pci bus as well as for pci
> bridges, we should not generate the related amls for DSDT table or initialize
> related hw ports or reserve hw resources. Th
On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote:
> This change adds a new unit test for the global flag
> 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
> bridges in i440fx. The flag can be used to turn off acpi based hotplug support
> for all the slot
Gentle reminder to kindly review this patch :-)
@Julia Suvorova @Michael S. Tsirkin
On Mon, Sep 7, 2020 at 6:47 PM Ani Sinha wrote:
>
> Julia Michael,
>
> Can you please provide your inputs on this one and the corresponding unit
> tests?
>
> On Fri, Sep 4, 2020 at 9:4
On Sep 11, 2020, 18:15 +0530, Igor Mammedov , wrote:
> On Thu, 10 Sep 2020 22:34:20 +0530
> Ani Sinha wrote:
>
> > On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote:
> > > This change adds a new unit test for the global flag
> > > 'acpi-pci-hotplug-with-bridge-sup
On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote:
>
> On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote:
> > On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote:
> >
> > On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote:
> >
> > On F
On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote:
>
> On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote:
> > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote:
> > >
> > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote:
> > &
On Fri, Sep 11, 2020 at 8:29 PM Michael S. Tsirkin wrote:
>
> On Thu, Sep 10, 2020 at 10:34:20PM +0530, Ani Sinha wrote:
> > On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote:
> >
> > This change adds a new unit test for the global flag
> >
> > 'acpi-pc
On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote:
>
>
> I am not sure why, but the expected files did not match for me.
>
> I dropped these for now:
>
> tests/acpi: add a new ACPI table in order to test root pci hotplug on/off
> tests/acpi: add a new unit test to test hotplug off/on
On Fri, Sep 11, 2020 at 9:45 PM Ani Sinha wrote:
>
> On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote:
> >
> > On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote:
> > > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin
> > > wrote:
> >
I can't repro the breakage. What test command line are you running
with? I am using " make check-qtest-x86_64 V=1"
On Fri, Sep 11, 2020 at 9:41 PM Ani Sinha wrote:
>
> On Fri, Sep 11, 2020 at 9:38 PM Michael S. Tsirkin wrote:
> >
> >
> > I am not sure why, bu
On Fri, Sep 11, 2020 at 9:51 PM Ani Sinha wrote:
>
> I can't repro the breakage. What test command line are you running
> with? I am using " make check-qtest-x86_64 V=1"
Ok I was working off v5.1.0 tag. Did not realize. I rebased all my
patches to the latest master and reworke
Notify (SF8, Arg1)
}
}
Method (PCNT, 0, NotSerialized)
{
BNUM = Zero
DVNT (PCIU, One)
DVNT (PCID, 0x03)
-^S18.PCNT ()
}
}
}
}
Signed-off-by: Ani
ter branch on top of tag
v5.1.0.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 504b810af5..d8c7d57557 100644
--- a/tests/qtest/bios-tables-te
34548.html
In this patch, we fix the issue in this function by checking if the bus which is
returned by the function is actually hotpluggable. If not, we simply return
NULL.
This avoids the scenario where we were returning a non-hotpluggable bus.
This patch is based off of tag v5.10
Signed-off-by:
mp; 0x4000))
-{
-Notify (SF0, Arg1)
-}
-
-If ((Arg0 & 0x8000))
-{
-Notify (SF8, Arg1)
-}
-}
-
Method (PCNT, 0, NotSerialized)
{
-
t bus")
This change documents the fact that this new file addition was made as a part
of the
unit test change.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/b
.
Signed-off-by: Ani Sinha
---
hw/acpi/piix4.c | 6 --
hw/i386/acpi-build.c | 10 --
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index e6163bb6ce..b70b1f98af 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -596,8 +596,10
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for
testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under
i440fx.
This change documents this fact.
Signed-off-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1
-off-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index d8c7d57557..7632cfe1be 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
guest image running on Ubuntu 18.04 host. This change is based off of upstream
qemu master branch tag v5.1.0.
Signed-off-by: Ani Sinha
---
hw/i386/acpi-build.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 7a5a8b352
On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote:
>
> On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote:
> > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote:
> > >
> > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote:
> > &
On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote:
> On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote:
> >
> > Cold plugged bridges are not hot unpluggable, even when their hotplug
> > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please
On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote:
> On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote:
> > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote:
> > >
> > > Cold plugged bridges are not hot unpluggable, even when their hotplug
> > > property (
On Sep 8, 2020, 19:35 +0530, Michael S. Tsirkin , wrote:
> On Tue, Sep 01, 2020 at 03:19:22PM +0530, Ani Sinha wrote:
> > When acpi hotplug is turned off for both root pci bus as well as for pci
> > bridges, we should not generate the related amls for DSDT table or
> > init
On Mon, Sep 14, 2020 at 9:11 PM Ani Sinha wrote:
>
> On Mon, Sep 14, 2020 at 8:51 PM Ani Sinha wrote:
> >
> > On Mon, Sep 14, 2020 at 8:20 PM Ani Sinha wrote:
> > >
> > > On Mon, Sep 14, 2020 at 7:39 PM Igor Mammedov wrote:
> > > >
> > &g
On Tue, Sep 15, 2020 at 7:12 PM Igor Mammedov wrote:
>
> On Tue, 15 Sep 2020 18:25:55 +0530
> Ani Sinha wrote:
>
> > On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
> > >
> > > On Tue, 15 Sep 2020 17:40:25 +0530
> > > Ani Sinha wrote:
>
On Tue, Sep 15, 2020 at 6:19 PM Igor Mammedov wrote:
>
> On Tue, 15 Sep 2020 17:40:25 +0530
> Ani Sinha wrote:
>
> > On Tue, Sep 15, 2020 at 5:21 PM Igor Mammedov wrote:
> > >
> > > On Mon, 14 Sep 2020 20:20:21 +0530
> > > Ani Sinha wrote:
>
1 - 100 of 1417 matches
Mail list logo
