[Qemu-devel] Re: [PULL 00/10] Block patches

2010-11-04 Thread Anthony Liguori
for flushes vpc: Implement bdrv_flush qcow2: Invalidate cache after failed read ide: Handle immediate bdrv_aio_flush failure virtio-blk: Handle immediate flush failure properly scsi-disk: Fix immediate failure of bdrv_aio_* Pulled. Thanks. Regards, Anthony

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Anthony Liguori
On 11/04/2010 07:54 AM, Kevin Wolf wrote: Am 27.10.2010 20:19, schrieb Anthony Liguori: Signed-off-by: Anthony Liguorialigu...@us.ibm.com diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const

[Qemu-devel] Re: KVM call agenda for Nov 9

2010-11-08 Thread Anthony Liguori
On 11/08/2010 08:23 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. For once I start: - report from linux plumbers virt track (jes?, anthony?) - report from linux kernel summit (avi?) Good thinking. Regards, Anthony Liguori Cheers, Juan

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-10 Thread Anthony Liguori
On 10/08/2010 05:08 AM, Daniel P. Berrange wrote: On Thu, Oct 07, 2010 at 02:53:05PM -0500, Anthony Liguori wrote: On 10/07/2010 06:15 AM, Gerd Hoffmann wrote: This patch adds support for expiring passwords to vnc. It adds a new lifetime parameter to the vnc_display_password

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-10 Thread Anthony Liguori
implemented outside of QEMU. Of course, if both you and Dan disagree strongly, since this is so little code, I'll leave the final decision up to you. Regards, Anthony Liguori cheers, Gerd

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-10 Thread Anthony Liguori
of the coding style issues and make the code fit into QEMU. Dropping a bunch of junk into target-i386/ is not making the code fit into QEMU. If you post just what you have now in patch form, I can try to provide more concrete advice ignoring the coding style problems. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
descriptors and then map them to a command? Regards, Anthony Liguori Regards, Daniel

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
= commands covered in QMP already? Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Anthony Liguori
but session boundaries aren't really well defined. I don't think it's an obvious win. Regards, Anthony Liguori Regards, Daniel

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-12 Thread Anthony Liguori
On 11/12/2010 06:14 AM, Ian Molton wrote: On 10/11/10 17:47, Anthony Liguori wrote: On 11/10/2010 11:22 AM, Ian Molton wrote: Ping ? I think the best way forward is to post patches. I posted links to the git trees. I can post patches, but they are *large*. Do you really want me to post

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-12 Thread Anthony Liguori
nicely also has the advantage of making this work with other formats like Ogg which are a bit more Open Source friendly. Regards, Anthony Liguori François.

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
that the guest memory no longer changes. Regards, Anthony Liguori Later, Juan.

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-15 Thread Anthony Liguori
, Anthony Liguori Signed-off-by: Anthony PERARDanthony.per...@citrix.com --- arch_init.c |5 +++ arch_init.h |1 + qemu-options.hx | 10 ++ vl.c| 85 +++--- 4 files changed, 90 insertions(+), 11 deletions

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-15 Thread Anthony Liguori
On 11/12/2010 10:54 AM, François Revol wrote: Le 12 nov. 2010 à 15:32, Anthony Liguori a écrit : I did try years ago, but at least the current wav driver really didn't like fifos back then. I recall trying for hours to get it pipe to ffmpeg or others without much luck. Also, this poses

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Anthony Liguori
On 11/15/2010 12:54 PM, Mike Ryan wrote: Anyone care to comment? I must admit, I don't understand the use-case well enough to really give an appropriate amount of review as to whether this is the best solution to the problem. Michael, do you have any thoughts? Regards, Anthony

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
enough determinism to fix the problem in practice. Regards, Anthony Liguori See above. IMO it's a different problem. Unlike Kemari, I don't really see any drawbacks to stop all callbacks. Do you? I think it's going to be extremely difficult to get right and keep right. A bunch

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
-unfriendly behavior down the road. Regards, Anthony Liguori Stefan

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-15 Thread Anthony Liguori
been historically fickle so doing the extra work to simplify review is worth it. Regards, Anthony Liguori Signed-off-by: Arun R Bharadwaja...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.Vaneesh.ku...@linux.vnet.ibm.com Signed-off-by: Gautham R Shenoygautham.she...@gmail.com Signed-off

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Anthony Liguori
is SIOCGIFADDR? I suspect that's very Linux-centric.. Regards, Anthony Liguori On Mon, Nov 15, 2010 at 01:36:28PM -0600, Anthony Liguori wrote: On 11/15/2010 12:54 PM, Mike Ryan wrote: Anyone care to comment? I must admit, I don't understand the use-case well enough

Re: [Qemu-devel] virtio-blk broken after system reset

2010-11-15 Thread Anthony Liguori
. Obviously, we can fix some of these by just simple code refactoring. Regards, Anthony Liguori Why it is trying to print things to stderr is a different matter, it should be using a proper error-reporting routine, but this is a different story. Jep. Even worse: the above message

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
with a state notifier to kick the queue on start would do the trick. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support

2010-11-16 Thread Anthony Liguori
slot-size == size) { +return slot; +} + +if (ranges_overlap(start_addr, size, slot-start_addr, slot-size)) { +abort(); Should display a message before aborting. Why not use hw_error? Another good suggestion. Regards, Anthony Liguori

Re: [Qemu-devel] [RESEND][PATCH] Remove 16-character limit on process title

2010-11-16 Thread Anthony Liguori
://libvirt.org/git/?p=libvirt.git;a=commit;h=c08c7b0143b8cdc542e5f4137623d412340c5cf2 Needs a Signed-off-by. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-16 Thread Anthony Liguori
for generating DTrace files * Makefile.obj: Don't build trace.o for DTrace, use trace-dtrace.o generated by 'dtrace' instead * tracetool: Support for generating DTrace data files Signed-off-by: Daniel P. Berrangeberra...@redhat.com Applied both. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH RESEND] apic: Don't iterate past last used apic

2010-11-16 Thread Anthony Liguori
apic_get_delivery_bitmask() from #3 in the profile to down in the noise. Signed-off-by: Alex Williamsonalex.william...@redhat.com Applied. Thanks. Regards, Anthony LIguori --- hw/apic.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index 63d62c7..5f4a87c

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-16 Thread Anthony Liguori
On 11/16/2010 10:10 AM, Anthony PERARD wrote: On Mon, 15 Nov 2010, Anthony Liguori wrote: On 11/15/2010 09:45 AM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-16 Thread Anthony Liguori
on a dom0, a domU, or a KVM-enabled normal Linux. Regards, Anthony Liguori Regards, Daniel

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-16 Thread Anthony Liguori
prefers to use it's own in-kernel local APIC (and IOAPIC). That makes it a property of the machine. Regards, Anthony Liguori Alex

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-16 Thread Anthony Liguori
On 11/16/2010 11:24 AM, Alexander Graf wrote: On 16.11.2010, at 18:20, Anthony Liguori wrote: On 11/16/2010 10:59 AM, Alexander Graf wrote: Surely, only if it is running on a Xen Dom0. If you use -M xenpv on a KVM host, then -M xenpv should imply -machine accel=kvm (ie

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-16 Thread Anthony Liguori
with systemtap support, but --trace-backend=nop should work regardless. Regards, Anthony Liguori seem to have broken building on x86: git clone git://git.qemu.org/qemu.git cd qemu ./configure make fails with LINK i386-softmmu/trace /usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/crt1.o

[Qemu-devel] [Bug 563582] Re: KVM 9.10 crashes for suse-10 as guest

2010-11-16 Thread Anthony Liguori
Please do not file bugs against upstream unless they've been explicitly reproduced against an upstream version. Thanks. ** Changed in: qemu Status: New = Invalid -- KVM 9.10 crashes for suse-10 as guest https://bugs.launchpad.net/bugs/563582 You received this bug notification because

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-16 Thread Anthony Liguori
On 11/16/2010 12:49 PM, Alexander Graf wrote: On 16.11.2010, at 19:22, Anthony PERARD wrote: On Tue, 16 Nov 2010, Anthony Liguori wrote: On 11/16/2010 11:24 AM, Alexander Graf wrote: On 16.11.2010, at 18:20, Anthony Liguori wrote: On 11/16/2010 10:59 AM

[Qemu-devel] Re: Hitting 29 NIC limit

2010-11-16 Thread Anthony Liguori
On 11/16/2010 11:23 AM, Michael S. Tsirkin wrote: On Thu, Oct 14, 2010 at 05:17:36PM -0500, Anthony Liguori wrote: On 10/14/2010 05:12 PM, Anjali Kulkarni wrote: Thanks. Does this work for e1000 as well? Haven't tried. I don't know how various e1000 drivers would react

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-16 Thread Anthony Liguori
a patch? I think I'm not seeing this because I build with srcdir != objdir. Regards, Anthony Liguori -- PMM

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-16 Thread Anthony Liguori
the host TSC in which case, your SOL because the code in QEMU that uses the host TSC assumes a UP host which aren't all that common anymore :-) Regards, Anthony Liguori (does [KVM] even work on OSX ?) No. Andreas

Re: [Qemu-devel] Fwd: [PATCH v2] Guest OS hangs on usb_add

2010-11-16 Thread Anthony Liguori
On 11/16/2010 01:36 PM, TJ wrote: On 11/16/2010 10:00 AM, Anthony Liguori wrote: On 11/02/2010 09:51 AM, TJ wrote: Doesn't look like this has ever been committed. qemu-kvm-0.13 has just arrived to the portage tree, but I am still having problems with it. I checked the git log

Re: [Qemu-devel] [PATCH v2 1/2] rtl8139: add vlan tag insertion

2010-11-16 Thread Anthony Liguori
); +*(uint16_t *)(s-cplus_txbuffer + 2 * ETHER_ADDR_LEN + ETHER_TYPE_LEN) += cpu_to_le16(txdw1 CP_TX_VLAN_TAG_MASK); This looks wrong. You check for txsize = 2 * ETHER_ADDR_LEN but then you assign at 2 * ETHER_ADDR_LEN. This is a potential overflow, no? Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-16 Thread Anthony Liguori
it to the author's discretion. Regards, Anthony Liguori [...]

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-11-16 Thread Anthony Liguori
. Regards, Anthony Liguori --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index f9097a2..e710bbb 100644 --- a/hw/multiboot.c +++ b/hw/multiboot.c @@ -171,6 +171,12 @@ int load_multiboot(void *fw_cfg

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-16 Thread Anthony Liguori
during business hours (9-5). Setting an expiration time for 8 hours is quite a bit less straight forward than just unsetting the password during the off hours. Regards, Anthony Liguori cheers, Gerd

Re: [Qemu-devel] [PATCH 0/3] spice: misc bugfixes

2010-11-16 Thread Anthony Liguori
00:41:04 +0300) are available in the git repository at: git://anongit.freedesktop.org/spice/qemu bugfix.2 Ping? Got it. In the future, please include a [PULL] in your subject line. Regards, Anthony Liguori cheers, Gerd

Re: [Qemu-devel] [PATCH] Force object directory use

2010-11-16 Thread Anthony Liguori
. Signed-off-by: Blue Swirlblauwir...@gmail.com Interesting idea. I certainly would support this. Regards, Anthony Liguori --- Makefile | 369 +- Makefile.top | 367

Re: [Qemu-devel] [PATCH] Delete IOHandlers after potentially running them

2010-11-16 Thread Anthony Liguori
on an IOHandler that is marked for deletion. Signed-off-by: Stefan Hajnoczistefa...@linux.vnet.ibm.com Applied. Thanks. Regards, Anthony Liguori --- vl.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/vl.c b/vl.c index 7038952..6f56123 100644

Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed

2010-11-16 Thread Anthony Liguori
On 11/05/2010 04:40 PM, Alex Williamson wrote: We can't let the compiler define the alignment for qemu_cfg data. Signed-off-by: Alex Williamsonalex.william...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- hw/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-16 Thread Anthony Liguori
On 11/09/2010 01:36 AM, Gleb Natapov wrote: Properly check array bounds before accessing array element. Signed-off-by: Gleb Natapovg...@redhat.com Applied. Thanks. Regards, Anthony Liguori diff --git a/hw/usb-net.c b/hw/usb-net.c index 70f9263..84e2d79 100644 --- a/hw/usb-net.c +++ b

Re: [Qemu-devel] [PATCH 1/3] usb-linux: Store devpath into USBHostDevice when usb_fs_type == USB_FS_SYS

2010-11-16 Thread Anthony Liguori
On 11/10/2010 03:06 AM, Hans de Goede wrote: This allows us to recreate the sysfspath used during scanning later (which will be used in a later patch in this series). Applied all three. Thanks. Regards, Anthony Liguori --- usb-linux.c | 26 +++--- 1 files

Re: [Qemu-devel] [PATCH] Fix compilation failure with simple trace when srcdir==objdir

2010-11-16 Thread Anthony Liguori
On 11/16/2010 02:07 PM, Peter Maydell wrote: Fix a makefile error that meant that qemu would not compile if the source and object directories were the same. Signed-off-by: Peter Maydellpeter.mayd...@linaro.org Applied. Thanks. Regards, Anthony Liguori --- Makefile.target | 11

Re: [Qemu-devel] [PATCH] Add missing braces

2010-11-16 Thread Anthony Liguori
. Signed-off-by: Jes Sorensenjes.soren...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- hw/e1000.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 532efdc..724dfbe 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -444,9

Re: [Qemu-devel] [PATCH] pc: Fix e820 fw_cfg for big endian

2010-11-16 Thread Anthony Liguori
On 11/07/2010 09:57 PM, Alex Williamson wrote: Signed-off-by: Alex Williamsonalex.william...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- Compile tested only. Only current user is kvm, no cross-arch users. hw/pc.c | 14 +++--- 1 files changed, 7 insertions

Re: [Qemu-devel] [RFC][PATCH v3 07/21] virtproxy: add read handler for communication channel

2010-11-16 Thread Anthony Liguori
one RPC request to be queued on either end at a given time. This is really the key to success, by the nature of the communication, we can demultiplex into finite buffers. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/1] [PULL] qemu-kvm.git uq/master queue

2010-11-17 Thread Anthony Liguori
On 11/05/2010 07:44 PM, Marcelo Tosatti wrote: The following changes since commit d33ea50a958b2e050d2b28e5f17e3b55e91c6d74: scsi-disk: Fix immediate failure of bdrv_aio_* (2010-11-04 13:54:37 +0100) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-17 Thread Anthony Liguori
On 11/16/2010 03:24 PM, Alex Williamson wrote: On Tue, 2010-11-16 at 08:58 -0600, Anthony Liguori wrote: On 11/01/2010 10:14 AM, Alex Williamson wrote: Register the actual VM RAM using the new API Signed-off-by: Alex Williamsonalex.william...@redhat.com --- hw/pc.c | 12

Re: [Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Anthony Liguori
not that atypical. Keep in mind, we already create per-target build directories and use them. Building the rest of the objects in a different directory isn't really all that bizarre. Regards, Anthony Liguori Paolo

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-17 Thread Anthony Liguori
On 11/17/2010 05:35 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 09:46:20AM -0600, Anthony Liguori wrote: On 11/08/2010 01:33 PM, Daniel P. Berrange wrote: This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core

Re: [Qemu-devel] [RFC][PATCH v4 09/18] virtagent: add va_shutdown RPC

2010-11-18 Thread Anthony Liguori
shutdown either FWIW. Regards, Anthony Liguori Cheers, Jes

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Anthony Liguori
not a fan of the typedefmeharder approach you are taking in here, but others may disagree with me. Isn't typedef'ing structured types part of the qemu coding style guidelines? Yes, I think Jes was just looking for an excuse to say typedefmeharder :-) Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable segments the i440fx can toggle are 12 fixed 16k segments from 0xc to 0xe and a single 64k

Re: [Qemu-devel] Fwd: [PATCH v2] Guest OS hangs on usb_add

2010-11-18 Thread Anthony Liguori
impossible to review. Why does this work on bare metal? Regards, Anthony Liguori -TJ Original Message Subject: [PATCH v2] Guest OS hangs on usb_add Date: Mon, 28 Jun 2010 10:47:03 -0400 From: TJone.timothy.jo...@gmail.com To: qemu-devel@nongnu.orgqemu-devel@nongnu.org CC

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-18 Thread Anthony Liguori
characteristics of QEMU coding style. Regards, Anthony Liguori It's just a really bad habit that is applied all over the place in QEMU :( http://www.linuxjournal.com/article/5780?page=0,2 search for typedef, for a lot of good reasoning why we shouldn't do this. Jes

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-18 Thread Anthony Liguori
On 11/18/2010 09:57 AM, Avi Kivity wrote: On 11/18/2010 05:46 PM, Anthony Liguori wrote: On 11/18/2010 09:22 AM, Avi Kivity wrote: On 11/18/2010 01:42 AM, Anthony Liguori wrote: Gack. For the benefit of those that want to join the fun without digging up the spec, these magic flippable

Re: [Qemu-devel] [PATCH] spice: connection events.

2010-11-18 Thread Anthony Liguori
, phost, pport); +#endif A DPRINTF would be nicer but otherwise, Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori + +server = qdict_new(); +qdict_put(server, host, qstring_from_str(lhost)); +qdict_put(server, port, qstring_from_str(lport

Re: [Qemu-devel] Re: [PATCH v2 0/4] use new vgabios.

2010-11-19 Thread Anthony Liguori
. * add a new clean up patch, removes bits which where used by video.x code only. The qemu patches are also available from git://anongit.freedesktop.org/spice/qemu vgabios.2 please pull, Gerd Ping? Merged this and the qemu patches (vgabios.3 branch). Thanks. Regards, Anthony

Re: [Qemu-devel] [PULL] vhost, netdev, e1000, pci

2010-11-19 Thread Anthony Liguori
. Regards, Anthony Liguori are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Alex Williamson (2): e1000: Fix TCP checksum overflow with TSO PCI: Bus number from the bridge, not the device Michael S. Tsirkin (3

Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support

2010-11-20 Thread Anthony Liguori
100644 index 000..0c17ff9 --- /dev/null +++ b/memory.h @@ -0,0 +1,18 @@ +#ifndef QEMU_MEMORY_H +#define QEMU_MEMORY_H + +#include qemu-common.h +#include cpu-common.h Header needs copyright and would be nice to have some comments explaining these functions. Regards, Anthony Liguori +int

Re: [Qemu-devel] [PATCH v2] ioport: Fix duplicated code

2010-11-20 Thread Anthony Liguori
this. Regards, Anthony Liguori --- v2: Fix error messages and make register_ioport_rw() register both handlers at the same call ioport.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/ioport.c b/ioport.c index ec3dc65..4560973

Re: [Qemu-devel] Re: [PATCH v2 0/4] use new vgabios.

2010-11-20 Thread Anthony Liguori
On 11/17/2010 04:26 AM, Gerd Hoffmann wrote: On 11/16/10 15:51, Anthony Liguori wrote: On 11/01/2010 11:03 AM, Gerd Hoffmann wrote: On 10/15/10 12:02, Gerd Hoffmann wrote: This patch series will put the new vgabios into use for stdvga and vmware_vga. The vgabios patches have been posted

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-20 Thread Anthony Liguori
a series of PCI slots as no supporting hotplug. It would be convenient in order to ensure that your virtio-net wasn't accidentally ejected by a click-happy Windows user. Regards, Anthony Liguori Gerd Hoffmann (3): qdev: allow devices being tagged as not hotpluggable. piix: tag as non

Re: [Qemu-devel] [PATCH] stop the iteration when too many pages is transferred

2010-11-20 Thread Anthony Liguori
be implemented. Regards, Anthony Liguori --- arch_init.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/arch_init.c b/arch_init.c index 4486925..67e90f8 100644 --- a/arch_init.c +++ b/arch_init.c @@ -212,6 +212,14 @@ uint64_t ram_bytes_total(void

[Qemu-devel] Re: Oudated vgabios.git on git.qemu.org

2010-11-21 Thread Anthony Liguori
On 11/21/2010 04:23 AM, Avi Kivity wrote: qemu.git points to vgabios.git 19ea12c230ded95928ecaef0db47a82231c2e485, which isn't available on git.qemu.org/vgabios.git. As I mentioned in another mail, I had to switch the repo from mirror to push mode. It's all now fixed up. Regards, Anthony

Re: [Qemu-devel] [PATCH] configure: Add compiler option -Wmissing-format-attribute

2010-11-21 Thread Anthony Liguori
that there remain few (if any) functions without format checking. Cc: Blue Swirlblauwir...@gmail.com Signed-off-by: Stefan Weilw...@mail.berlios.de This breaks the build for me. disas.c doesn't build. Regards, Anthony Liguori --- HACKING |3 --- configure |1 + 2 files changed, 1

Re: [Qemu-devel] [PATCH] vgabios update: handle compatibility with older qemu versions

2010-11-21 Thread Anthony Liguori
/ Signed-off-by: Gerd Hoffmannkra...@redhat.com Applied. Thanks. Regards, Anthony Liguori Cc: a...@redhat.com --- hw/pc_piix.c| 16 hw/vga-pci.c|5 + hw/vmware_vga.c |5 + 3 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH][RESEND] pcnet: Do not receive external frames in loopback mode

2010-11-21 Thread Anthony Liguori
Kiszkajan.kis...@siemens.com Applied. Thanks. Regards, Anthony Liguori --- hw/pcnet.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.c index b52935a..f970bda 100644 --- a/hw/pcnet.c +++ b/hw/pcnet.c @@ -1048,9 +1048,10 @@ ssize_t

Re: [Qemu-devel] [PATCH 0/2] msi support for virtfs

2010-11-21 Thread Anthony Liguori
. Regards, Anthony Liguori please apply, Gerd Gerd Hoffmann (2): pc: add 0.13 pc machine type virtfs: enable MSI-X hw/pc_piix.c| 18 +- hw/virtio-pci.c |5 - 2 files changed, 21 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] trace: Trace vm_start()/vm_stop()

2010-11-21 Thread Anthony Liguori
, Anthony Liguori --- trace-events |3 +++ vl.c |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/trace-events b/trace-events index 947f8b0..da03d4b 100644 --- a/trace-events +++ b/trace-events @@ -189,3 +189,6 @@ disable sun4m_iommu_mem_writel_pgflush

Re: [Qemu-devel] [PATCH 0/4] virtio: Convert fprintf() to error_report()

2010-11-21 Thread Anthony Liguori
of bailing out with exit(1) but this series does not attempt to fix that yet. Leave virtio-9p for now where there are many cases of fprintf(stderr, ...) and development is still very active. Applied all. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] trace: Use fprintf_function (format checking)

2010-11-21 Thread Anthony Liguori
On 11/15/2010 02:17 PM, Stefan Weil wrote: fprintf_function adds format checking with GCC_FMT_ATTR. Cc: Blue Swirlblauwir...@gmail.com Signed-off-by: Stefan Weilw...@mail.berlios.de Applied. Thanks. Regards, Anthony Liguori --- simpletrace.h |6 +++--- 1 files changed, 3

Re: [Qemu-devel] [PATCH] slirp: Remove unused code for bad sprintf

2010-11-21 Thread Anthony Liguori
, the unused code was removed. Cc: Blue Swirlblauwir...@gmail.com Signed-off-by: Stefan Weilw...@mail.berlios.de Applied. Thanks. Regards, Anthony Liguori --- slirp/misc.c | 42 -- slirp/slirp.h| 14 -- slirp

Re: [Qemu-devel] [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-21 Thread Anthony Liguori
: - Use better alternative handling for UTIME_NOW/OMIT - Move qemu_utimensat() to cutils.c V2: - Introduce qemu_utimensat() Signed-off-by: Hidetoshi Setoseto.hideto...@jp.fujitsu.com Applied. Thanks. Regards, Anthony Liguori --- cutils.c | 43

Re: [Qemu-devel] [patch 0/3] block migration fixes

2010-11-21 Thread Anthony Liguori
On 11/08/2010 01:02 PM, Marcelo Tosatti wrote: Following patchset fixes block migration corruption issues Applied all. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Makefile: Fix check dependency breakage

2010-11-21 Thread Anthony Liguori
On 11/12/2010 08:55 AM, Luiz Capitulino wrote: Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests build, fix it. Signed-off-by: Luiz Capitulinolcapitul...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- Makefile | 14 -- 1 files changed, 8

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
with it. It doesn't have any external dependencies that you could avoid this way, does it? Using block format whitelisting should be enough to disable nbd. I don't see a need for an explicit --disable-nbd option. Regards, Anthony Liguori Kevin

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
On 11/22/2010 08:58 AM, Jes Sorensen wrote: On 11/22/10 15:54, Anthony Liguori wrote: On 11/22/2010 08:38 AM, Kevin Wolf wrote: You're free to dislike NBD as much as you want. Just compiling it out unconditionally and calling it a cleanup is a bit too much. ;-) A configure option

Re: [Qemu-devel] [PATCH 1/1] NBD isn't used by qemu-img, so don't link qemu-img against NBD objects

2010-11-22 Thread Anthony Liguori
On 11/22/2010 09:10 AM, Jes Sorensen wrote: On 11/22/10 16:08, Anthony Liguori wrote: On 11/22/2010 08:58 AM, Jes Sorensen wrote: On 11/22/10 15:54, Anthony Liguori wrote: Using block format whitelisting should be enough to disable nbd. I don't see a need for an explicit

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-22 Thread Anthony Liguori
simpler just to include the emulation in qemu like we do for every other device... Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
and stops the CPU as appropriate. The monitor commands provide a more elegant solution that signals because it ensures that a stopped vcpu isn't holding the qemu_mutex. I'll reply to this note with an example tool. Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/hmp-commands.hx b

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-22 Thread Anthony Liguori
On 11/22/2010 03:45 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. usb-ccid - vcpu hard limits Regards, Anthony Liguori -- To unsubscribe from this list: send the line unsubscribe kvm

[Qemu-devel] Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:00 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. The purpose of these commands are to implement CPU hard limits using

[Qemu-devel] Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:04 PM, Chris Wright wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. In the past

[Qemu-devel] Re: [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-22 Thread Anthony Liguori
On 11/22/2010 05:56 PM, Chris Wright wrote: * Anthony Liguori (aligu...@linux.vnet.ibm.com) wrote: On 11/22/2010 05:04 PM, Chris Wright wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
On 11/23/2010 12:41 AM, Avi Kivity wrote: On 11/23/2010 01:00 AM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start individual vcpus. The purpose

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
On 11/23/2010 02:16 AM, Dor Laor wrote: On 11/23/2010 08:41 AM, Avi Kivity wrote: On 11/23/2010 01:00 AM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals, introduce monitor commands that stop and start

Re: [Qemu-devel] [PATCH] qemu-kvm: introduce cpu_start/cpu_stop commands

2010-11-23 Thread Anthony Liguori
second. You could monitor threads separately but stop the entire process. Stopping individual threads will break apart as soon as they start taking locks. I don't think so.. PLE should work as expected. It's no different than a normally contended system. Regards, Anthony Liguori

[Qemu-devel] Re: [PATCHv6 00/16] boot order specification

2010-11-23 Thread Anthony Liguori
On 11/23/2010 09:31 AM, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it be applied? Does that mean everyone's happy or have folks not gotten around to review it? IOW, last call if you have objections :-) Regards, Anthony Liguori On Wed

[Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
to carry in QEMU? Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/cpu-defs.h b/cpu-defs.h index 51533c6..6434dca 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -220,6 +220,7 @@ struct KVMCPUState { const char *cpu_model_str; \ struct

Re: [Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
not supported: Hrm, is there a portable way to do this (distinguish a signal on a particular thread)? Regards, Anthony Liguori $ cat thread.c static __thread int sigusr1_wfd; $ gcc thread.c -c thread.c:1: error: thread-local storage not supported for this target $ gcc -v Reading specs from

Re: [Qemu-devel] [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-23 Thread Anthony Liguori
On 11/23/2010 05:43 PM, Paolo Bonzini wrote: On 11/23/2010 10:46 PM, Anthony Liguori wrote: +static __thread int sigusr1_wfd; While OpenBSD finally updated the default compiler to 4.2.1 from 3.x series, thread local storage is still not supported: Hrm, is there a portable way to do

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-24 Thread Anthony Liguori
On 11/24/2010 02:18 AM, Avi Kivity wrote: On 11/23/2010 06:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to approximate the behavior of SIGSTOP/SIGCONT

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
and Xen. I think as an overall community, we're large enough that we could support a pretty sizable conference and I think everyone would benefit from being more exposed to other aspects of the stack. Regards, Anthony Liguori Alex

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
poking the LF folks for some advice. But the key point is breadth, it should not be a KVM Forum but rather an Open Virtualization conference with topics as high level as cloud software automation and as low level as asynchronous page faults :-) Regards, Anthony Liguori Cheers, Jes

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-11-26 Thread Anthony Liguori
On 11/26/2010 09:15 AM, Alexander Graf wrote: On 26.11.2010, at 15:21, Anthony Liguori wrote: On 11/26/2010 08:15 AM, Jes Sorensen wrote: I would be all in favor of this! Do you want to attach it to another conference or totally standalone? Attaching is easier logistically

<    6   7   8   9   10   11   12   13   14   15   >