Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
like git-send-email and split this patch up into more manageable chunks. Is there an Open Source rehub available? As a project policy, adding external APIs specifically for proprietary software is not something we're willing to do. Regards, Anthony Liguori Documentation of the module

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/06/2012 01:46 PM, Scott Wood wrote: On 02/03/2012 04:52 PM, Anthony Liguori wrote: On 02/03/2012 12:07 PM, Eric Northup wrote: On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivity wrote: [...] Moving to syscalls avoids these problems, but introduces new ones: - adding new syscalls is

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
n you direct me to the lock I need? The function I call from a new thread context is bdrv_aio_readv. One thing that has me confused about this proposal. Why not just make rehub be an iSCSI target provider and call it a day? Regards, Anthony Liguori -Original Message- From: Dor Laor [mail

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 06:40 AM, Avi Kivity wrote: On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be selective with access because of that. As is true of the rest of the kernel. If you want

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
ple instances, we'll have to fix it up manually but that really shouldn't be all that hard. That gives us composition paths and a clear goal for removing the legacy paths (we'd want to work toward eliminating /legacy-machine). device_add doesn't use qdev_create() and ne

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
format code as a shared library and let drbd link against it. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
ho is more mature in Qemu? Personally I prefer NBD because it is lighter-weight and there is a server inside QEMU (so you can use it easily with non-raw images). It is more mature, but it is a bit less extensible. Which is also fine. You could also just use DRBD ;-) Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 01/19] Revert "qemu-char: Print strerror message on failure" and deps

2012-02-07 Thread Anthony Liguori
ts dependencies, and fix up the silent error paths instead. This reverts commit 6e1db57b2ac9025c2443c665a0d9e78748637b26. Ack on this, but see comments in other patches for what I think we should do instead. Regards, Anthony Liguori Conflicts: console.c hw/baum.c qemu-char.c This revert

Re: [Qemu-devel] [PATCH 03/19] qemu-char: Re-apply style fixes from just reverted aad04cd0

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-char.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 368df2e

Re: [Qemu-devel] [PATCH 02/19] qemu-char: Use qemu_open() to avoid leaking fds to children

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Fixed silently in commit aad04cd0, but that just got reverted. Re-apply the fixes, plus one missed instance: parport on Linux. Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-char.c |8

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 07:18 AM, Avi Kivity wrote: On 02/07/2012 02:51 PM, Anthony Liguori wrote: On 02/07/2012 06:40 AM, Avi Kivity wrote: On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be sele

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-07 Thread Anthony Liguori
return -1; } sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0); if (sock< 0) { -perror("socket(unix)"); -return -1; +goto err; } memset(&un, 0, sizeof(un)); un.sun_family = AF_UNIX; snprintf(un.sun_path, sizeof(un.sun_path), "%s", path); if (connect(sock, (struct sockaddr*)&un, sizeof(un))< 0) { -fprintf(stderr, "connect(unix:%s): %s\n", path, strerror(errno)); -close(sock); - return -1; +goto err; } return sock; + +err: +error_report("Can't connect to socket %s: %s", + un.sun_path, strerror(errno)); +if (sock>= 0) { +close(sock); +} +return -1; } Basically, same thing here and the remaining functions. Let's not introduce additional uses of error_report(). That said, I imagine you don't want to introduce a bunch of error types for these different things and that's probably not productive anyway. So let's compromise and introduce a generic QERR_INTERNAL_ERROR that takes a single human readable string as an argument. We can have a wrapper for it that also records location information in the error object. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 06:03 AM, Avi Kivity wrote: On 02/06/2012 09:11 PM, Anthony Liguori wrote: I'm not so sure. ioeventfds and a future mmio-over-socketpair have to put the kthread to sleep while it waits for the other end to process it. This is effectively equivalent to a heavy weight exit

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
kernel since two threads are likely going to be accessing it at the same time. That either means an expensive sync operation or a reliance on atomic instructions. But not all architectures offer non-word sized atomic instructions so it gets fairly nasty in practice. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Cleaned up silently in commit aad04cd0, but that just got reverted. Re-apply this part. Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- qemu-char.c |4 1 files changed, 0 insertions

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 10:02 AM, Avi Kivity wrote: On 02/07/2012 05:17 PM, Anthony Liguori wrote: On 02/07/2012 06:03 AM, Avi Kivity wrote: On 02/06/2012 09:11 PM, Anthony Liguori wrote: I'm not so sure. ioeventfds and a future mmio-over-socketpair have to put the kthread to sleep while it wait

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 10:18 AM, Jan Kiszka wrote: On 2012-02-07 17:02, Avi Kivity wrote: On 02/07/2012 05:17 PM, Anthony Liguori wrote: On 02/07/2012 06:03 AM, Avi Kivity wrote: On 02/06/2012 09:11 PM, Anthony Liguori wrote: I'm not so sure. ioeventfds and a future mmio-over-socketpair have t

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
On 02/07/2012 09:21 AM, Paolo Bonzini wrote: On 02/07/2012 03:56 PM, Anthony Liguori wrote: Another related question is, should the 4th QOM series present a full composition tree based on the legacy qdev bus concept? Composition, no. The legacy qbus concept doesn't model composition be

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
On 02/07/2012 09:20 AM, Stefan Hajnoczi wrote: On Tue, Feb 7, 2012 at 2:59 PM, Anthony Liguori wrote: On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolfwrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
On 02/07/2012 10:27 AM, Paolo Bonzini wrote: On 02/07/2012 05:24 PM, Anthony Liguori wrote: I'm wary of all plans that require to go through all the code once. What about simply /devices/default/child[...] or something like that? The paths would be unstable, but maybe that's okay. I

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
ways change it later. For PC-style machines I'd expect board-level stuff like the CPUs to appear directly under /. That would roughly correspond to the OpenFirmware device tree then. I think devices trees are a bad example that should not be emulated. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH RFC v3 02/21] qom: Add QOM support to user emulators

2012-02-07 Thread Anthony Liguori
On 02/07/2012 11:25 AM, Peter Maydell wrote: On 6 February 2012 19:16, Anthony Liguori wrote: If we're going to go down this road, then I have a hard requirement. We need to build the common infrastructure only once. Otherwise build times are going to explode and we'll e

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
s what the time planning for the 4th QOM series looks like. Are there things that developers of new devices should keep in mind / start doing differently wrt SysBus? I think I answered this elsewhere. Regards, ANthony Liguori Andreas

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
On 02/07/2012 12:17 PM, Andreas Färber wrote: Am 07.02.2012 19:01, schrieb Anthony Liguori: On 02/07/2012 07:45 AM, Andreas Färber wrote: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg04065.html How is the realize step (DeviceState::init) supposed to translate to Object-derived

Re: [Qemu-devel] [RFC] Replication agent requirements (was [RFC PATCH] replication agent module)

2012-02-08 Thread Anthony Liguori
Gluster is appealing as a pluggable storage interface although the license is problematic for us today. I'm quite confident that we shouldn't be in the business of replicating storage though. If the answer is NBD++, that's fine too. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
= "arm_linux_loader", +.parent= TYPE_DEVICE, +.class_init= arm_boot_class_init, +.instance_size = sizeof(struct ArmBoot), +}; + +static void arm_boot_register(void) +{ +type_register_static(&arm_boot_info_); +} + +device_i

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
composes together other objects and forwards properties. We don't want any actually logic to live in the machines. Regards. Anthony Liguori Alex

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
stent. But patches should always go to the mailing list. I certainly would have acked such a patch FWIW. I think people get a bit too excited about coding style. There are much more important things to worry about in life than the number of spaces before a parenthesis :-) Regards, Anthony Li

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:36 AM, Andreas Färber wrote: Am 08.02.2012 16:23, schrieb Anthony Liguori: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
eeds to be done. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
set (realization). I posted a series for the i440fx that started doing this refactoring for the PC. Regards, Anthony Liguori Paul

Re: [Qemu-devel] Restore consistent formatting

2012-02-09 Thread Anthony Liguori
On 02/09/2012 03:48 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not

Re: [Qemu-devel] [PATCH v2] qom: Unify type registration

2012-02-09 Thread Anthony Liguori
necessary and don't put a semicolon after the closing brace. Ugh, touching the whole tree again? Yeah, it's not coming from me at least :-) I doubt this will cause any rebase problems though. Regards, Anthony Liguori -- PMM

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-02-09 Thread Anthony Liguori
ble sizes? Can we just use a fixed size (pre-allocated) array and then use a VMSTATE_SUB_ARRAY? If it's truly variable size with no upper bound, then that's actually a security problem since it implies a guest can do unbounded memory allocation. Regards, Anthony Liguori - PMM

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Anthony Liguori
deletions(-) It's not a win in terms of code size. If you plan on introducing additional handlers, perhaps you should include this in that series where it's more appropriately justified. As a change on it's own, it doesn't seem to make a lot of sense. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Anthony Liguori
On 02/10/2012 11:09 AM, Amit Shah wrote: On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Signed-off-by

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-10 Thread Anthony Liguori
to convert them all at once or make the code deviate from the style it's already using. Isn't it be better to revert a patch that introduced checkpatch.pl errors? No. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers

2012-02-10 Thread Anthony Liguori
On 02/10/2012 12:08 PM, Kevin Wolf wrote: Am 10.02.2012 18:22, schrieb Anthony Liguori: On 02/10/2012 11:09 AM, Amit Shah wrote: On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: On 02/10/2012 07:19 AM, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
vhost=on -vnc :1 -monitor stdio Here's the fix. I need to do some regression testing and then I'll post as a proper top-level patch. Thanks for the report. Regards, Anthony Liguori -- MST >From b7fc6f1eb7c5e041eac7d610061a1be950707e5b Mon Sep 17 00:00:00 2001 From: Ant

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: From: Anthony Liguori Date: Sun, 12 Feb 2012 11:36:24 -0600 Subject: [PATCH] device_add: don't add a /peripheral link until init is complete Otherwise we end up with a dan

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: From: Anthony Liguori Date: Sun, 12 Feb 2012 11:36:24 -0600

Re: [Qemu-devel] virtio-blk throughput

2012-02-13 Thread Anthony Liguori
local disk. Try that and I think you'll see an improvement. We should throw a bug on aio=native, cache != none. linux-aio blocks on io_submit if the caching mode isn't O_DIRECT and that will kill performance. Regards, Anthony Liguori Stefan

[Qemu-devel] QEMU Mascot Competition

2012-02-13 Thread Anthony Liguori
le times but please limit yourself to one vote for any given Mascot. Thanks to everyone that has participate so far! Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
nd give a nice error message. Normal malloc failures should call abort(). Regards, Anthony Liguori Allocating RAM for the emulated machine is perhaps the only scenario where a core dump is indeed not reasonable. In most other cases, out-of-memory is an indication of a QEMU internal problem, so a

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
directly here instead of using the typical QEMU abort-on-failure wrappers. g_try_malloc glib already has a suite of functions for this. Regards, Anthony Liguori Stefan

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Anthony Liguori
rare exceptions (like a bad -m argument), we should handle those as special cases. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-14 Thread Anthony Liguori
On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbruster writes: Anthony Liguori writes: [Anthony asking for error_set() instead of error_report()...] Basically, same thing here and the remaining functions. Let's not introduce additional uses of error_report(). That sa

[Qemu-devel] [MASCOT CONTEST] Alex Bradbury #1

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Clare Liguori #1

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Clare Liguori #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

Re: [Qemu-devel] QEMU Mascot Competition

2012-02-15 Thread Anthony Liguori
On 02/13/2012 03:24 PM, Anthony Liguori wrote: Hi, First, let me apologize that this has taken so long. But it's time to start voting on the submitted QEMU Mascots so we can pick Q! Here's how it will work: I will send a series of notes to the mailing list tomorrow morning with

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #5

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #7

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #5

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #4

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

Re: [Qemu-devel] QEMU Mascot Competition

2012-02-15 Thread Anthony Liguori
On 02/15/2012 09:23 AM, Jan Kiszka wrote: On 2012-02-15 15:48, Anthony Liguori wrote: On 02/13/2012 03:24 PM, Anthony Liguori wrote: Hi, First, let me apologize that this has taken so long. But it's time to start voting on the submitted QEMU Mascots so we can pick Q! Here's how it

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #6

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Alex Bradbury #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #3

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #1

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #3

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #1

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Wei-Ren Chen #4

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Stefan Weil #6

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

[Qemu-devel] [MASCOT CONTEST] Benoit Canet #1

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-15 Thread Anthony Liguori
w CR3 but maybe that wouldn't be so bad with VPIDs. Then you could implement the PIT as guest firmware using kvmclock as the time base. Once you're back in the guest, you could install the old CR3. Perhaps just hide a portion of the physical address space with the e820. Regard

[Qemu-devel] [MASCOT CONTEST] Benoit Canet #2

2012-02-15 Thread Anthony Liguori
Please respond to this note with an '+1', or an Ack, to vote for this icon. <>

Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add monitor command

2012-02-15 Thread Anthony Liguori
, but unless you've got qdev-ification patches in the earlier ones (haven't made the list yet), device_add is not the right place for this. There's no such thing as "cpu-pc" either. You should start with a cpu_add command. Regards, Anthony Liguori --- hw/pc.c |

Re: [Qemu-devel] [PULL 00/15] Block patches

2012-02-15 Thread Anthony Liguori
On 02/10/2012 06:47 AM, Kevin Wolf wrote: The following changes since commit 57c83dacfe179bf061b8fa79d9553ebabe4d2ff4: make: Remove duplicate use of GLIB_CFLAGS (2012-02-09 20:44:38 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at: git

Re: [Qemu-devel] [PULL 00/28] usb patch queue

2012-02-15 Thread Anthony Liguori
. Thanks. Regards, Anthony Liguori please pull, Gerd The following changes since commit 57c83dacfe179bf061b8fa79d9553ebabe4d2ff4: make: Remove duplicate use of GLIB_CFLAGS (2012-02-09 20:44:38 +0400) are available in the git repository at: git://git.kraxel.org/qemu usb.38 Gerd Hoffmann (26

Re: [Qemu-devel] [PULL] vnc patch collection

2012-02-15 Thread Anthony Liguori
has no vnc entry too, so I'll try a straigt pull request this time, hoping to get the bits merged finally. please pull, Pulled. Thanks. Regards, Anthony Liguori Gerd The following changes since commit 57c83dacfe179bf061b8fa79d9553ebabe4d2ff4: make: Remove duplicate use of GLIB_C

Re: [Qemu-devel] [PATCH 0/3] [PULL] qemu-kvm.git uq/master queue

2012-02-15 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori Jan Kiszka (3): kvm: Allow to set shadow MMU size kvm: Implement kvm_irqchip_in_kernel like kvm_enabled apic: Fix legacy vmstate loading for KVM hw/apic_common.c |7 ++- hw/pc.c |4 ++-- hw/pc_piix.c

Re: [Qemu-devel] [PULL] slirp: cleanups & fixes

2012-02-15 Thread Anthony Liguori
. Thanks. Regards, Anthony Liguori Jan Kiszka (1): slirp: Prevent sending ICMP error replies to source-only addresses Stefan Weil (1): slirp: Remove unused variable and unused code slirp/ip_icmp.c |5 slirp/misc.c| 67

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Anthony Liguori
this to the guest (we expose a fixed number of pluggable sockets). Regards, Anthony Liguori Jan

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
with a shallow conversion is okay but only if there's a clear path to a proper conversion. I don't think this approach fits that requirement. The approach is a bit too pc centric. It's not clear how it would generalize. Regards, Anthony Liguori --- hw/pc.c

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
/features via QOM properties 9) make machine expose target specific CPUState links that can be set by the user. Regards, Anthony Liguori As a shortcut, "-smp N" would continue to replicate a "-device cpu-XX" N times. Otherwise, configuration becomes inconsistent. Jan

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:50 AM, Jan Kiszka wrote: On 2012-02-16 13:42, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus "ICC&quo

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-16 Thread Anthony Liguori
On 02/16/2012 02:57 AM, Gleb Natapov wrote: On Wed, Feb 15, 2012 at 03:59:33PM -0600, Anthony Liguori wrote: On 02/15/2012 07:39 AM, Avi Kivity wrote: On 02/07/2012 08:12 PM, Rusty Russell wrote: I would really love to have this, but the problem is that we'd need a general purpose byteco

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:54 AM, Jan Kiszka wrote: On 2012-02-16 13:51, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = "cpu-pc", +.qdev.size = sizeof(CPUPC), +.

Re: [Qemu-devel] [PULL 0/3] NBD pull request for 2012-02-17

2012-02-17 Thread Anthony Liguori
/qemu.git nbd-for-anthony Pulled. Thanks. Regards, Anthony Liguori Michael Tokarev (1): do not chdir(/) in qemu-nbd before opening all files Paolo Bonzini (2): open /dev/nbd in nbd_client_thread nbd: add git tree to MAINTAINERS MAINTAINERS |1 + qemu-nbd.c | 42

Re: [Qemu-devel] [PULL 00/22] arm-devs queue

2012-02-17 Thread Anthony Liguori
change that means it needs rebasing again :-)) Pulled. Thanks. Regards, Anthony Liguori thanks -- PMM The following changes since commit 9de36b1a7cf61aa8be365f13c81668b3e19fbc7f: Make -machine/-enable-kvm options merge into a single list (2012-02-17 09:10:13 +0100) are available in

Re: [Qemu-devel] [PULL 0/9] Trivial patches for 28 January to 10 February 2012

2012-02-17 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori Benjamin MARSILI (1): net: remove extra spaces in help messages Hervé Poussineau (1): ide: fix compilation errors when DEBUG_IDE is set Luiz Capitulino (1): virtio: Remove unneeded g_free() check in virtio_cleanup() Paul Brook (1

Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events

2012-02-17 Thread Anthony Liguori
On 02/15/2012 04:28 AM, Gerd Hoffmann wrote: Send qmp events on suspend and wakeup so libvirt has a chance to track the vm state. Signed-off-by: Gerd Hoffmann Luiz, please Ack. Regards, Anthony Liguori --- monitor.c |6 ++ monitor.h |2 ++ vl.c | 15

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-17 Thread Anthony Liguori
On 02/11/2012 03:44 AM, Blue Swirl wrote: On Fri, Feb 10, 2012 at 17:47, Anthony Liguori wrote: On 02/09/2012 10:02 PM, malc wrote: On Fri, 10 Feb 2012, Evgeny Voevodin wrote: On 02/09/2012 06:59 PM, Andreas F?rber wrote: Disable warnings for spaces before opening parenthesis in hw/{ac97

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-17 Thread Anthony Liguori
On 02/17/2012 08:55 AM, Markus Armbruster wrote: Anthony Liguori writes: I really hate having these discussions. I would almost rather we just pay the one-time cost of re-indenting so we can stop debating about this. For folks that feel strongly about this, please submit the following: An

Re: [Qemu-devel] [PATCH v2 5/5] block: use QSLIST for the AIO free list

2012-02-17 Thread Anthony Liguori
ke sure it gets adequate review. Regards, Anthony Liguori --- block.c |9 - block_int.h |4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block.c b/block.c index 3f072f6..acb54b1 100644 --- a/block.c +++ b/block.c @@ -3242,9 +3242,9 @@ void *qemu_aio_g

Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event

2012-02-17 Thread Anthony Liguori
a cleaner approach from a QEMU perspective. There's nothing generic about this functionality. It's extremely specific to virtio-balloon. We just lacked ways to expose device specific function pre-QOM. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] vnc: Don't demote authentication scheme when changing password/disabling login

2012-02-17 Thread Anthony Liguori
owngrading your security protocol. Fix this by only changing the authentication protocol if the current authentication protocol is AUTH_NONE. That ensures we're never downgrading. Signed-off-by: Daniel P. Berrange Signed-off-by: Anthony Liguori Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 0/5] qemu-queue cleanups

2012-02-17 Thread Anthony Liguori
provides some memory saving over QTAILQ. Stefan, these are a bit borderline for qemu-trivial. Let me know if they're fine. Applied 1-4 since 5 introduced a regression. Thanks. Regards, Anthony Liguori Paolo Bonzini (5): notifier: switch to QLIST qemu-queue: add QSLIST qemu-

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() semantics

2012-02-17 Thread Anthony Liguori
kvm_enabled() check and early QOM type registration. Check whether the class exists before calling object_new(), so that the caller (e.g., qdev_create) can fail gracefully, telling us which device could not be created. Signed-off-by: Andreas Färber Cc: Anthony Liguori Er, it's late here...

Re: [Qemu-devel] [PATCH v4 0/7] pit, hpet, pcspk: fixes & preparation for KVM

2012-02-17 Thread Anthony Liguori
PROP_PTR users) CC: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori Jan Kiszka (7): i8254: Do not raise IRQ level on reset hpet: Save/restore cached RTC IRQ level i8254: Factor out interface header i8254: Pass alternative IRQ output object on initialization i8254: Rework

Re: [Qemu-devel] [PATCH] libcacard configure fixes

2012-02-17 Thread Anthony Liguori
On 02/09/2012 01:05 PM, Paul Brook wrote: libcacard is only used by system emulation. Only define libcacard_libs/cflags once. Signed-off-by: Paul Brook Ah, I applied this without realizing it was from pbrook :-) Regards, Anthony Liguori --- configure | 12 ++-- 1 files

Re: [Qemu-devel] [PATCH] input: send kbd+mouse events only to running guests.

2012-02-17 Thread Anthony Liguori
is in running state. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori --- input.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/input.c b/input.c index 9ade63f..b48408d 100644 --- a/input.c +++ b/input.c @@ -130,6 +130,9 @@ void

Re: [Qemu-devel] [PATCH] configure: Remove OpenBSD workaround for curses probe

2012-02-17 Thread Anthony Liguori
On 02/10/2012 02:59 PM, Brad Smith wrote: Remove the OpenBSD workaround for the curses probe. This has not been necessary for 5 releases now. Signed-off-by: Brad Smith Applied. Thanks. Regards, Anthony Liguori diff --git a/configure b/configure index 763db24..c9729f8 100755 --- a

Re: [Qemu-devel] [PATCH 0/2] Some small documentation fixes

2012-02-17 Thread Anthony Liguori
ions (e.g., #Objects) lead to warnings. * Some structs are not picked up correctly, such as Object. Applied all. Thanks. Regards, Anthony Liguori Regards, Andreas Cc: Anthony Liguori Andreas Färber (2): qom: Fix typo in Object's documentation qom: Fix identifiers in documentation

Re: [Qemu-devel] [PATCH] i8259: Do not clear level-triggered lines in IRR on init

2012-02-17 Thread Anthony Liguori
. Thanks. Regards, Anthony Liguori --- hw/i8259.c|2 +- hw/i8259_common.c |2 +- hw/kvm/i8259.c|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 3005ce2..264bfc6 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -231,8 +231,8

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-10 Thread Anthony Liguori
ture, but it seems they're blessed in PCI > 2.3. 2.3 was standardized in 2002. Are we confident that vendor extensions play nice with pre-2.3 OSes like Win2k, WinXP, etc? I still think it's a bad idea to rely on something so "new" in something as fundamental as virtio-pci unl

<    1   2   3   4   5   6   7   8   9   10   >