Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Juan Quintela writes:
> Hi
>
> Please send in any agenda topics you are interested in.
FYI, I have a conflict for today so I won't be able to attend.
Regards,
Anthony Liguori
>
> Later, Juan.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm
);
>
> -memread(s->addr + OMAP_I2C_CNT, &data, 2);
> +omap_i2c_read16(s->addr + OMAP_I2C_CNT, &data);
> g_assert_cmpuint(data, ==, len);
>
> while (len > 0) {
> - memread(s->addr + OMAP_I2C_STAT, &data, 2);
> +omap_i2c_read16(
hat the GA date is not changing here. I plan on tagging
-rc1 toward the end of the day tomorrow US/Central so please get in any
patches/pull requests by mid-day if you want them considered for -rc1.
Regards,
Anthony Liguori
end up with a 128KB binary.
So do I on Fedora 18. Unless someone has a reason why this is a bad
thing, I'll commit a 128kb binary and we can avoid this problem for 1.4.
Obviously, we need to figure it out but that at least buys us some time...
Regards,
Anthony Liguori
>I'm n
ios/out/biostables.d
> -rw-rw-r--. 1 kraxel kraxel 11872 Feb 6 09:52 seabios/out/biostablRes.o
I assume you got this backwards, right? RHEL6 gives you the larger
build?
Regards,
Anthony Liguori
> With no config options changed.
>
>> Obviously, we need to figure it out but that at l
chr_new_from_opts to create ChardevBackend and use
> the new QMP code path for initialization everywhere. Once this point is
> reached both HMP and QMP will provide identical features.
>
> Obviously that isn't an option for 1.4.
>
>> If we're 100% serious about the rule, we need to disable HMP chardev-add
>> for the release.
>
> Fine with me.
Ack.
Regards,
Anthony Liguori
> cheers,
> Gerd
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
g the
old config size. This is something we're going to have to fix for all
virtio devices...
However, I also like Michael's patch that gets rid of the mq option so
Michael, please rebase that patch on top of -rc1 and then we can avoid
having to explicitly turn mq on.
Regards,
Anthony L
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
derson)
- bswap: Fix width of swap in leul_to_cpu (Richard Henderson)
- bios: recompile BIOS (Anthony Liguori)
- trace: Fix location of simpletrace.py in docs (Markus Armbruster)
- trace: Clean up the "try to update atomic until it worked" loops (Markus
Armbruster)
- trace: Direct acce
"Michael S. Tsirkin" writes:
> On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote:
>> "Michael S. Tsirkin" writes:
>>
>> This is about bug-for-bug compatibility with older QEMU.
>
> Sorry, with which version?
>
> It looks like
ray[0]) + 1), you're also
> allowed to eval ((&x) + 1).
>
>
> Anyway the above expression could be reworked for more portability with
> offsetof and sizeof. As-is, it contains a pointer-to-non-void to
> intptr_t conversion; what's more, with the resultant integer value meant
> to be used numerically later on (ie. not for converting it back to
> (void*), C99 7.18.1.4p). (The use of the null pointer is valid, the
> dereference is not evaluated because it's the operand of &, C99
> 6.5.2.3p4 and 6.5.3.2p3.)
>
> Instead, what about
>
> #define endof(container, field) \
> (offsetof(container, field) + sizeof ((container *)0)->field)
That's fine too and probably a lot easier to understand.
Regards,
Anthony Liguori
>
> Laszlo
n't necessary.
>
> Just use offsetof() the *next* field or sizeof() the entire struct
> (for the last field). That way you let someone else do the dirty
> pointer tricks.
You don't always have a next field so it would get syntactically
awkward.
Regards,
Anthony Liguori
>
> Stefan
"Michael S. Tsirkin" writes:
> On Thu, Feb 07, 2013 at 11:46:55AM -0600, Anthony Liguori wrote:
>
> So why do we add extra code who's sole effect is breaking old
> windows drivers?
A little dramatic, no?
> I like the idea but why add code for status and mac featu
sn't imply
that there would be any kind of weird layout. Ultimately, a pointer to
a member needs to behave the same way that a pointer to that type
declared in an unpacked structure would behave since the knowledge of
the fact that it's in a packed structure is quickly lost.
> Ho
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Andreas Färber writes:
> On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be
> unsigned long long. Account for this by always using strtoull().
> We were already using strtoll() for int64_t.
>
> Signed-off-by: Andreas Färber
Reviewed-by: Anthony Liguori
Re
Andreas Färber writes:
> Introduce [qtest_]{read,write}[bwlq]() libqtest functions and
> corresponding QTest protocol commands to replace local versions in
> libi2c-omap.c.
>
> Signed-off-by: Andreas Färber
Reviewed-by: Anthony Liguori
Regards,
Anthony Liguori
&
Stefan Berger writes:
> Introduce --enable-tpm-passthrough configure option.
You're duplicating the subject line here.
Regards,
Anthony Liguori
>
> Signed-off-by: Stefan Berger
> ---
> configure | 17 +
> 1 file changed, 17 insertions(+)
>
this field also allows me to provide more accurate commit
notification since the current mechanism is based entirely on
heuristics.
Regards,
Anthony Liguori
rebuilt?
>
> We also build optionroms and spapr-rtas automatically, not seabios
> though and there's no option to disable/enable those.
It's all historical I guess. We should try to build everything we can
and prefer to install that over the binaries that are shipped.
Regards,
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Paolo Bonzini writes:
> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>> Applied. Thanks.
>>
>> Regards,
>>
>> Anthony Liguori
>
> I guess this was a mistake, please revert.
No, it wasn't. The patch was reviewed and tested. What's the pr
Kevin Wolf writes:
> Am 11.02.2013 22:14, schrieb Anthony Liguori:
>> Paolo Bonzini writes:
>>
>>> Il 11/02/2013 21:13, Anthony Liguori ha scritto:
>>>> Applied. Thanks.
>>>>
>>>> Regards,
>>>>
>>>> Anthony L
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
ing like:
>
> { 'command': 'my_cmd',
> 'data': { 'param1': 'Foo' },
> 'returns': {} }
>
> to:
>
> void my_cmd(Foo *param1);
>
> At some point in development we rightly decided that:
>
> { 'command': 'my_cmd',
> 'data': { 'param1': 'Foo' } }
>
> was more efficient, which triggers the 'name == None' case and has the same
> effect.
>
> So, as long as we stay consistent about defining commands in this fashion, we
> can map 'param_name': {} to something like 'struct {}', and use it in place of
> schema-defined dummy types.
>
> Though, as I mentioned on IRC, I think just defining a:
>
> { 'type': 'Dummy', 'data' {} }
>
> Somewhere in the schema and re-using that might actually be cleaner and have
> the same affect.
Yes. I don't think we really ought to support inline structures. It
keeps the declarations easier to read to make all structs top level
types.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
ook doesn't do anything useful and we need to apply
Andreas' patch anyway, I don't think there's any benefit to apply this one.
Regards,
Anthony Liguori
>
> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
pick it up for 1.4.
>
> Sure, whatever. Can we please just get whichever damn fix *in*.
For the sake of completeness, "rth's patch" means:
commit 91107fdf4443d2171e06840e87277bb7a047343b
Author: Richard Henderson
Date: Mon Feb 4 16:21:06 2013 -0
too late. If we're already beyond the point where we can
>> do that, too bad, we'll live.
>>
>> Please consider seriously.
>
> Seems reasonable to me to get this into 1.4.
>
> Series: Reviewed-by: Eric Blake
Agreed. Assuming it doesn't break anything,
Haven't seen all the patches, but just FYI, this is too late for 1.4.
I'm already testing a locally tagged version. But looks like it will
potentially be a nice cleanup!
Regards,
Anthony Liguori
Markus Armbruster writes:
> Signed-off-by: Markus Armbruster
> ---
> q
Fifth Floor, Boston,
> + MA 02110-1301, USA. */
QEMU is GPLv2 only so we can't take GPLv3 code. We're stuck on binutils
code that predates the v3 relicense.
Regards,
Anthony Liguori
d the automated checkpatch bot because it got too annoying. It
throws way too many false positives or annoying nits that shouldn't keep
us from merging useful code.
I haven't applied this patch because we're in freeze for the 1.4
release.
Regards,
Anthony Liguori
> The patch as
->phy_reg[PHY_STATUS] & MII_SR_AUTONEG_COMPLETE)) {
> @@ -1343,6 +1366,8 @@ static void qdev_e1000_reset(DeviceState *dev)
>
> static Property e1000_properties[] = {
> DEFINE_NIC_PROPERTIES(E1000State, conf),
> +DEFINE_PROP_BIT("x-qemu_13_compat", E1000State,
> +
virtio-net: disable multiqueue by default (Jesse Larrew)
- hw/virtio-net.c: set config size using host features (Jesse Larrew)
- virtio-net: pass host features to virtio_net_init (Anthony Liguori)
- net: fix infinite loop on exit (Michael Roth)
- tests/test-string-input-visitor: Handle errors provoked by fuzz test (Peter
Maydell)
Regards,
Anthony Liguori
Richard Henderson writes:
> On 02/13/2013 06:28 PM, Anthony Liguori wrote:
>> QEMU is GPLv2 only so we can't take GPLv3 code. We're stuck on binutils
>> code that predates the v3 relicense.
>
> Ok, this is something that's going to bite us more and more.
>
bit of LLVM infrastructure for parsing the machine
> descriptions. It didn't look particularly easy, but this is just
> from 15 minutes browsing a source tree, so if anybody more LLVM
> aware here has an opinion do say.
LLVM is a beast. I played around with using cfront to make a QAPI front
end and it took 4-5G worth of dispatch just to get it building.
Regards,
Anthony Liguori
>
>> But most of all I think we should have a plan.
>
> Agreed.
>
> -- PMM
Blue Swirl writes:
> On Thu, Feb 14, 2013 at 2:34 AM, Anthony Liguori
> wrote:
>> Joel Schopp writes:
>>
>>>>> +if(popen_file == NULL) {
>>>>
>>>> Please make a preparatory patch which adds missing spaces between 'if'
&
suggestion elsewhere in the thread that instead
of changing default values, an "auto detect" value is a more user
friendly way of having this behavior.
Regards,
Anthony Liguori
>
> --
> Eduardo
esting out -rcs, or reporting bugs during the release process!
Regards,
Anthony Liguori
Happy hacking!
Regards,
Anthony Liguori
Eric Johnson writes:
> On 02/15/2013 03:41 PM, Anthony Liguori wrote:
>> Happy hacking!
>>
>> Regards,
>>
>> Anthony Liguori
>
> We might want to update the planning section of
> http://wiki.qemu.org/Contribute/StartHere to link to 1.4 and 1.5.
Th
nfb_update’:
/home/aliguori/git/qemu/hw/xenfb.c:759:18: error: too few arguments to function
‘qemu_create_displaysurface_from’
In file included from /home/aliguori/git/qemu/hw/xenfb.c:39:0:
/home/aliguori/git/qemu/include/ui/console.h:186:17: note: declared here
make: *** [hw/xenfb.o] Error
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Paolo Bonzini writes:
> Il 18/02/2013 21:43, Paolo Bonzini ha scritto:
>> Il 18/02/2013 17:02, Anthony Liguori ha scritto:
>>> Applied. Thanks.
>>
>> Hmm, since this is late for 1.4 patch 2 should be reverted.
>
> Oops, it's just the applied message tha
This allows a front-end to request for a callback when the backend
is writable again.
Signed-off-by: Anthony Liguori
---
include/char/char.h | 4
qemu-char.c | 32 +++-
2 files changed, 35 insertions(+), 1 deletion(-)
diff --git a/include/char/char.h b
From: Amit Shah
Signed-off-by: Amit Shah
---
qemu-char.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index e59e580..160bcea 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2462,6 +2462,12 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char
*buf, si
Signed-off-by: Anthony Liguori
---
qemu-char.c | 68 -
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 160bcea..d3303e9 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -990,12 +990,50
From: Amit Shah
The virtio-serial-bus already has the logic to make flow control work
properly. Hook into the char layer's new ability to signal a backend is
writable again.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/
Signed-off-by: Anthony Liguori
---
hw/serial.c | 28 +++-
hw/serial.h | 2 --
2 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/hw/serial.c b/hw/serial.c
index f0ce9b0..eb38f22 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -256,16 +256,17 @@ static void
This lets ptys support adding front end watchs.
Signed-off-by: Anthony Liguori
---
qemu-char.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 572c5ea..e59e580 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1008,6 +1008,12 @@ static int pty_chr_write
Signed-off-by: Anthony Liguori
---
hw/baum.c | 9 -
hw/baum.h | 30 --
qemu-char.c | 4
vl.c| 1 -
4 files changed, 8 insertions(+), 36 deletions(-)
delete mode 100644 hw/baum.h
diff --git a/hw/baum.c b/hw/baum.c
index 09dcb9c..d75b150
Signed-off-by: Anthony Liguori
---
qemu-char.c | 6 --
spice-qemu-char.c | 10 ++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 0c375f9..8b4c9a5 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3681,12 +3681,6 @@ static void
Signed-off-by: Anthony Liguori
---
include/char/char.h | 2 +
qemu-char.c | 123 +++-
2 files changed, 67 insertions(+), 58 deletions(-)
diff --git a/include/char/char.h b/include/char/char.h
index e8b781c..2e24270 100644
--- a/include
qemu-char is now independent of the QEMU main loop.
Signed-off-by: Anthony Liguori
---
include/char/char.h | 2 +-
qemu-char.c | 12 +---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/char/char.h b/include/char/char.h
index 09ac401..e8b781c 100644
--- a
901 - 1000 of 10201 matches
Mail list logo
